Ros-dev

ros-dev@reactos.org

5788 discussions

Off-topic: Understanding win32k system calls - help please

by Jeetu Golani

Hi, First, I'd like to apologize since what I'm asking doesn't directly relate to ReactOS however I'm hoping someone here might be able to shed some light. I've built a rudimentary win32k profiler and I've hooked the win32k SDT and hooked onto the NtUserCreateWindowEx function in the hope of studying values returned by it. I see some strange (to me) values for the x and y coordinates - values such as 1547372 etc. I'm not sure how to interpret these values and convert them into pixel units or traditional coordinate mechanisms. I first thought there must be something wrong with my code however I'm not so sure anymore. Would someone here be able to guide me on how to interpret these values??? Thanks and sorry again Bye for now

16 years

Re: [ros-dev] Trying to push ideas (again:) )

by chris evans

> > 7. Running on 16-bit systems like 286/386/486 in a "ReactOS Essentials" > > (equivalent to a stripped-down XP) mode * > > It should be the same operating system, but in 16-bit mode only. That's > > an ideal scenario and I'm sure it cannot be done no matter how good the > > programmers are. So, what can someone do on a 286 ? Listen to mp3's ? No Safe Mode. Just load Video, File and network drivers and allow direct access to int13 so fdisk and format can run so user can diag/fix it. Curious if ReactOS has a an Emergency Boot Disk system that it can make ? Perhaps, keep a Freedos 1.44m disk image and allow suer to rawrite it when needed. Or even a dual bootable Freedos partition (FAT16) with the appropriate recovery tools on it. --chris 1-916-410-7677 http://nxdos.sourceforge.net/ http://bbx.flnet.org/ http://teknopup.angelfire.com/

16 years

Re: [ros-dev] [ros-diffs] [sginsberg] 36436: - Attempt satisfy Alex

by Aleksey Bragin

For consistency, I would think OB, IO, PS and other modules having such tracing system should be turned off by default then too. WBR, Aleksey. On Sep 23, 2008, at 11:54 PM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Tue Sep 23 14:54:13 2008 > New Revision: 36436 > > URL: http://svn.reactos.org/svn/reactos?rev=36436&view=rev > Log: > - Attempt to satisfy Alex

16 years

Re: [ros-dev] [ros-diffs] [gedmurphy] 36435: Don't risk a negative array subscript. Fixes our one and only REVERSE_NEGATIVE error Fix for Coverity error CID: 766

by Timo Kreuzer

For me it looks like you try to trick Coverity here. No real fix, unless you check for (nColor >= 0) gedmurphy(a)svn.reactos.org schrieb: > Author: gedmurphy > Date: Tue Sep 23 14:02:32 2008 > New Revision: 36435 > > URL: http://svn.reactos.org/svn/reactos?rev=36435&view=rev > Log: > Don't risk a negative array subscript. Fixes our one and only REVERSE_NEGATIVE error > Fix for Coverity error CID: 766 > > Modified: > trunk/reactos/dll/cpl/desk/advappdlg.c > > Modified: trunk/reactos/dll/cpl/desk/advappdlg.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/advappdlg.c?r… > ============================================================================== > --- trunk/reactos/dll/cpl/desk/advappdlg.c [iso-8859-1] (original) > +++ trunk/reactos/dll/cpl/desk/advappdlg.c [iso-8859-1] Tue Sep 23 14:02:32 2008 > @@ -23,7 +23,6 @@ > RECT rect; > HBRUSH hbrush; > HWND hwndColorButton; > - COLORREF crColor = g->ThemeAdv.crColor[nColor]; > HGDIOBJ hgdiTmp; > > if (nColor != -1) > @@ -42,7 +41,7 @@ > rect.top = 2; > rect.right = 22; > rect.bottom = 13; > - hbrush = CreateSolidBrush(crColor); > + hbrush = CreateSolidBrush(g->ThemeAdv.crColor[nColor]); > FillRect(hdcCompat, &rect, hbrush); > DeleteObject(hbrush); > > > >

16 years

Re: [ros-dev] [ros-diffs] [sginsberg] 36428: - Add basic tracing to CmpReferenceKeyControlBlock, CmpDereferenceKeyControlBlock and CmpDereferenceKeyControlBlockWithLock

by Alex Ionescu

Do you think you could maybe turn OFF debugging by default so that not every build gets spammed with this code? On 23-Sep-08, at 10:15 AM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Tue Sep 23 09:15:56 2008 > New Revision: 36428 > > URL: http://svn.reactos.org/svn/reactos?rev=36428&view=rev > Log: > - Add basic tracing to CmpReferenceKeyControlBlock, > CmpDereferenceKeyControlBlock and > CmpDereferenceKeyControlBlockWithLock > > Modified: > trunk/reactos/ntoskrnl/config/cmkcbncb.c > > Modified: trunk/reactos/ntoskrnl/config/cmkcbncb.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmkcbncb.c… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/config/cmkcbncb.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/config/cmkcbncb.c [iso-8859-1] Tue Sep 23 > 09:15:56 2008 > @@ -354,6 +354,9 @@ > NTAPI > CmpReferenceKeyControlBlock(IN PCM_KEY_CONTROL_BLOCK Kcb) > { > + CMTRACE(CM_REFERENCE_DEBUG, > + "%s - Referencing KCB: %p\n", __FUNCTION__, Kcb); > + > /* Check if this is the KCB's first reference */ > if (Kcb->RefCount == 0) > { > @@ -570,6 +573,8 @@ > { > LONG OldRefCount, NewRefCount; > ULONG ConvKey; > + CMTRACE(CM_REFERENCE_DEBUG, > + "%s - Dereferencing KCB: %p\n", __FUNCTION__, Kcb); > > /* Get the ref count and update it */ > OldRefCount = *(PLONG)&Kcb->RefCount; > @@ -602,6 +607,9 @@ > CmpDereferenceKeyControlBlockWithLock(IN PCM_KEY_CONTROL_BLOCK Kcb, > IN BOOLEAN LockHeldExclusively) > { > + CMTRACE(CM_REFERENCE_DEBUG, > + "%s - Dereferencing KCB: %p\n", __FUNCTION__, Kcb); > + > /* Sanity check */ > ASSERT_KCB_VALID(Kcb); > > Best regards, Alex Ionescu

16 years

Re: [ros-dev] [ros-diffs] [cwittich] 36368: sync msiexec with wine 1.1.5

by Aleksey Bragin

I wonder why this A/W mess? WBR, Aleksey. On Sep 21, 2008, at 4:00 PM, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sun Sep 21 07:00:07 2008 > New Revision: 36368 > > URL: http://svn.reactos.org/svn/reactos?rev=36368&view=rev > Log: > sync msiexec with wine 1.1.5 > > Modified: > trunk/reactos/base/system/msiexec/msiexec.c > trunk/reactos/base/system/msiexec/service.c

16 years

Re: [ros-dev] [ros-diffs] [tkreuzer] 36379: preprocess all spec files

by Aleksey Bragin

There is a big problem with this change, originally this was added only for "our own" .spec files, which don't have comments starting with #. Wine .spec files have such comments, and thus will be preprocessed incorrectly. WBR, Aleksey. On Sep 21, 2008, at 6:34 PM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Sun Sep 21 09:34:48 2008 > New Revision: 36379 > > URL: http://svn.reactos.org/svn/reactos?rev=36379&view=rev > Log: > preprocess all spec files > > Modified: > branches/ros-amd64-bringup/reactos/tools/rbuild/backend/mingw/ > modulehandler.cpp > > Modified: branches/ros-amd64-bringup/reactos/tools/rbuild/backend/ > mingw/modulehandler.cpp > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/ > reactos/tools/rbuild/backend/mingw/modulehandler.cpp? > rev=36379&r1=36378&r2=36379&view=diff

16 years

who create the physical device object of scsi disk

by 钢陈

Hi, I just joined in the mail list and I want to ask a question. I have a question about scsiport module. I have seen the code scsiport.c and tried to find where it create the physical device object for scsi disk however I didn't find it. I just saw the function SpiScanAdapter which would send inquiry scsi command to scsi miniport driver. So I want to know who create the pdo for scsi disk? Gang Chen

16 years

Re: [ros-dev] [ros-diffs] [cgutman] 36337: - Zero the memory after we allocate it

by Aleksey Bragin

I think if it's a generic buffer-allocating function, its callers should not rely on the memory being zeroed. (like they don't rely on pool and heap allocations, unless called with zero-heap flag). At least the comments to the function does not say "it returns a zeroed buffer". WBR, Aleksey. On Sep 20, 2008, at 4:31 AM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Fri Sep 19 19:31:02 2008 > New Revision: 36337 > > URL: http://svn.reactos.org/svn/reactos?rev=36337&view=rev > Log: > - Zero the memory after we allocate it > > Modified: > branches/aicom-network-fixes/drivers/network/tcpip/tcpip/pool.c

16 years

Re: [ros-dev] [ros-diffs] [janderwald] 36295: - Update Status Icon when there is activity - Also update the Taskbar Notification Icon

by gedmurphy

Our LoadIcon is broken and can result in badly drawn / ugly icons. You should use LoadImage instead. LoadIcon is deprecated anyway, no one should be using it anymore. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of janderwald(a)svn.reactos.org Sent: 17 September 2008 22:59 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [janderwald] 36295: - Update Status Icon when there is activity - Also update the Taskbar Notification Icon + hIcon = NULL; + if (pContext->dwInOctets == IfEntry.dwInOctets && pContext->dwOutOctets == IfEntry.dwOutOctets && pContext->Status != 0) + { + hIcon = LoadIcon(netshell_hInstance, MAKEINTRESOURCE(IDI_NET_IDLE)); + pContext->Status = 0; + } + else if (pContext->dwInOctets != IfEntry.dwInOctets && pContext->dwOutOctets !=

16 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev