Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [pschweitzer] 36709: Fixed a FIXME A bit cleaned header
by Aleksey Bragin 11 Oct '08

11 Oct '08

Do you really need finally clause in this case? It's not the most beautiful way when doing it via PSEH. WBR, Aleksey. On Oct 10, 2008, at 11:26 PM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Fri Oct 10 14:26:42 2008 > New Revision: 36709 > > URL: http://svn.reactos.org/svn/reactos?rev=36709&view=rev > Log: > Fixed a FIXME > A bit cleaned header > > Modified: > branches/pierre-fsd/drivers/filesystems/fastfat/finfo.c > branches/pierre-fsd/drivers/filesystems/fastfat/vfat.h > > Modified: branches/pierre-fsd/drivers/filesystems/fastfat/finfo.c > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/drivers/ > filesystems/fastfat/finfo.c?rev=36709&r1=36708&r2=36709&view=diff > ====================================================================== > ======== > --- branches/pierre-fsd/drivers/filesystems/fastfat/finfo.c > [iso-8859-1] (original) > +++ branches/pierre-fsd/drivers/filesystems/fastfat/finfo.c > [iso-8859-1] Fri Oct 10 14:26:42 2008 > @@ -443,6 +443,10 @@ > } > > > +_SEH_FINALLYFUNC(VfatGetEaInformationFinal_PSEH) > +{ > +} > + > static NTSTATUS > VfatGetEaInformation(PFILE_OBJECT FileObject, > PVFATFCB Fcb, > @@ -452,15 +456,19 @@ > { > PDEVICE_EXTENSION DeviceExt = DeviceObject->DeviceExtension; > > - /* FIXME - use SEH to access the buffer! */ > - Info->EaSize = 0; > - *BufferLength -= sizeof(*Info); > - if (DeviceExt->FatInfo.FatType == FAT12 || > - DeviceExt->FatInfo.FatType == FAT16) > - { > - /* FIXME */ > - DPRINT1("VFAT: FileEaInformation not implemented!\n"); > - } > + _SEH_TRY > + { > + RtlZeroMemory(Info, sizeof(FILE_EA_INFORMATION)); > + if (DeviceExt->FatInfo.FatType == FAT12 || > + DeviceExt->FatInfo.FatType == FAT16) > + { > + /* FIXME */ > + DPRINT1("VFAT: FileEaInformation not implemented!\n"); > + } > + *BufferLength -= sizeof(FILE_EA_INFORMATION); > + } > + _SEH_FINALLY(VfatGetEaInformationFinal_PSEH) > + _SEH_END; > return STATUS_SUCCESS; > } > > > Modified: branches/pierre-fsd/drivers/filesystems/fastfat/vfat.h > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/drivers/ > filesystems/fastfat/vfat.h?rev=36709&r1=36708&r2=36709&view=diff > ====================================================================== > ======== > --- branches/pierre-fsd/drivers/filesystems/fastfat/vfat.h > [iso-8859-1] (original) > +++ branches/pierre-fsd/drivers/filesystems/fastfat/vfat.h > [iso-8859-1] Fri Oct 10 14:26:42 2008 > @@ -608,15 +608,7 @@ > > /* -------------------------------------------------------- > string.c */ > > -VOID > -vfatSplitPathName(PUNICODE_STRING PathNameU, > - PUNICODE_STRING DirNameU, > - PUNICODE_STRING FileNameU); > - > BOOLEAN vfatIsLongIllegal(WCHAR c); > - > -BOOLEAN wstrcmpjoki (PWSTR s1, > - PWSTR s2); > > /* ----------------------------------------------------------- > fat.c */ > > @@ -702,6 +694,11 @@ > > /* ----------------------------------------------------------- > fcb.c */ > > +VOID > +vfatSplitPathName(PUNICODE_STRING PathNameU, > + PUNICODE_STRING DirNameU, > + PUNICODE_STRING FileNameU); > + > PVFATFCB vfatNewFCB (PDEVICE_EXTENSION pVCB, > PUNICODE_STRING pFileNameU); > >

2 1

Re: [ros-dev] confused by "rtlpInitDeferedCriticalSection"
by tamlin＠algonet.se 11 Oct '08

11 Oct '08

Colin wrote: >The name "Rtlp..." already says it: This is a private function only used >internally by ntdll. To elaborate: if the name has a "p" in it after the "namespace" name (here Rtl), it usually means "private". -- Mike

1 0

question about InterlockedCompareExchange.
by Jack Yi 10 Oct '08

10 Oct '08

question about InterlockedCompareExchange. MSDN says: The function returns the initial value of the destination. I just don't understand, why can we get the initial value of destination as return value by 'return 0Ch' ? Thank you! .text:7C8097A2 ; PVOID __stdcall InterlockedCompareExchange(PVOID *Destination,PVOID Exchange,PVOID Comperand) .text:7C8097A2 public _InterlockedCompareExchange@12 .text:7C8097A2 _InterlockedCompareExchange@12 proc near .text:7C8097A2 ; CODE XREF: BaseComputeProcessDllPath(x,x)+97B3p .text:7C8097A2 ; CreateActCtxW(x)+15D2Dp .text:7C8097A2 .text:7C8097A2 Destination = dword ptr 4 .text:7C8097A2 Exchange = dword ptr 8 .text:7C8097A2 Comperand = dword ptr 0Ch .text:7C8097A2 .text:7C8097A2 mov ecx, [esp+Destination] .text:7C8097A6 mov edx, [esp+Exchange] .text:7C8097AA mov eax, [esp+Comperand] .text:7C8097AE .text:7C8097AE loc_7C8097AE: ; DATA XREF: .data:7C884014o .text:7C8097AE lock cmpxchg [ecx], edx .text:7C8097B2 retn 0Ch .text:7C8097B2 _InterlockedCompareExchange@12 endp

3 2

confused by "rtlpInitDeferedCriticalSection"
by Jack Yi 10 Oct '08

10 Oct '08

hi, guys! How and when should I use this function(lib\rtl\critical.c, line 222) ? In fact,I can not find such a fuction in the export table of ntdll(XP sp2).

2 1

Re: [ros-dev] [ros-diffs] [cgutman] 36699: - Some of my work on NDIS 6.0 - Doesn't compile yet - Part 1 of X
by gedmurphy 08 Oct '08

08 Oct '08

please pair ExAllocatePoolWithTag with ExFreePoolWithTag -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cgutman(a)svn.reactos.org Sent: 08 October 2008 22:17 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cgutman] 36699: - Some of my work on NDIS 6.0 - Doesn't compile yet - Part 1 of X Author: cgutman Date: Wed Oct 8 16:17:10 2008 New Revision: 36699 URL: http://svn.reactos.org/svn/reactos?rev=36699&view=rev Log: - Some of my work on NDIS 6.0 - Doesn't compile yet - Part 1 of X Added: branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c (with props) Added: branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c (added) +++ branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c [iso-8859-1] Wed Oct 8 16:17:10 2008 @@ -1,0 +1,40 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS NDIS library + * FILE: object.c + * PURPOSE: Implements the NDIS 6.0 object interface + * PROGRAMMERS: Cameron Gutman (aicommander(a)gmail.com) + */ + +#include "ndissys.h" + +PNDIS_GENERIC_OBJECT +EXPORT +NdisAllocateGenericObject( + IN PDRIVER_OBJECT DriverObject OPTIONAL, + IN ULONG Tag, + IN USHORT Size) +{ + PNDIS_GENERIC_OBJECT Object; + + Object = ExAllocatePoolWithTag(NonPagedPool, sizeof(NDIS_GENERIC_OBJECT) + Size, Tag); + if (!Object) return NULL; + + RtlZeroMemory(Object, sizeof(NDIS_GENERIC_OBJECT) + Size); + + Object->DriverObject = DriverObject; + Object->Header.Type = NDIS_OBJECT_TYPE_GENERIC_OBJECT; + Object->Header.Revision = NDIS_GENERIC_OBJECT_REVISION_1; + Object->Header.Size = sizeof(NDIS_GENERIC_OBJECT); + + return Object; +} + +VOID +EXPORT +NdisFreeGenericObject( + IN PNDIS_GENERIC_OBJECT NdisGenericObject) +{ + ExFreePool(NdisGenericObject); +} + Propchange: branches/aicom-network-fixes/drivers/network/ndis/ndis/object.c ------------------------------------------------------------------------------ svn:eol-style = native

1 0

WDK not working
by മഹേഷ് മുകുന്ദന് | Mahesh M 08 Oct '08

08 Oct '08

hi.. I tried the latest WDK provided by Micrsoft - http://download.microsoft.com/download/9/0/f/90f019ac-8243-48d3-91cf-81fc40… It was attached to Qemu as a CDROM. It did boot showing the D:\ But I couldnt install it. I tried installing via wine in Lenny.That too didnt work. Any help.. Can i get an alternative older one that works with ROS? -- Mahesh M Happy hacking... , , / \ ((__-^^-,-^^-__)) `-_---' `---_-' `--|o` 'o|--' \ ` / ): :( :o_o: "-"

5 6

[gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty
by Gabriel ilardi 07 Oct '08

07 Oct '08

Commit by gedmurphy :: r36658 reactos/base/shell/explorer/shell/ (mainframe.cpp mainframe.h): Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty Hi everyone, Even though explorer looks nicer indeed with this change, bear in mind that you can't use the internal web browser anymore (you can't type any web address). Regards, Gabriel. _________________________________________________________________ Stanco della solita finestra? Personalizza la tua Hotmail! http://www.messenger.it/personalizza.html#sfondi

4 7

Re : Re : [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty
by Sylvain Petreolle 06 Oct '08

06 Oct '08

----- Message d'origine ---- > De : Christoph von Wittich <Christoph(a)apiviewer.de> > À : ReactOS Development List <ros-dev(a)reactos.org> > Envoyé le : Lundi, 6 Octobre 2008, 16h35mn 25s > Objet : Re: [ros-dev] Re : [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty > > > > iexplore doesnt compile now : > > shdocvw's IEWinMain is still a stub for now (shdocvw synced to 0.9.5 according > to README.WINE) > > > > Kind regards, > > Sylvain Petreolle > > > > > > Here is a patch to sync shdocvw - it builds - but Explorer crashes on > "Web" without any debug output. > > http://iso.reactos.org/temp/shdocvw_patch.diff > > Regards, > Christoph von Wittich With that patched shdocvw and wine msimtf (attached in msimtf.zip), you can run iexplore without problem. In iexplore_mozillaactivex.zip : 1/winemshtml.reg adds needed registry keys for mshtml in order load gecko. 2/put version in mozilla activex directory (mshtml checks for it). Last: regsvr32 msimtf. Screenshots: Reactos Home http://img234.imageshack.us/my.php?image=iexploremozillaactivexzg8.png Maximized(better) http://img444.imageshack.us/my.php?image=iexploremaximzedbetterwq8.png Acid3 test :) http://img397.imageshack.us/my.php?image=iexploreacid3id3.png

1 0

Event invitation [jornadas Imaginática 2009]
by Marc Piulachs 06 Oct '08

06 Oct '08

Hi All, I have been contacted/invited to participate and give a talk about ReactOS in an event organized by the university of Seville, spain (very beautiful city!) on 2-6 March 2009. It would be great if some of the other spanish based members are also interested on participate, I have been disconnected from the project lately due to offline life but would be willing to participate in this event and help to spread the word about reactos in academic circles. More information here (in spanish): http://imaginatica.org/2009/descargas/Dossier.pdf Regards, /Marc

1 0

Re : [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty
by Sylvain Petreolle 06 Oct '08

06 Oct '08

----- Message d'origine ---- > De : Steven Edwards <winehacker(a)gmail.com> > À : ReactOS Development List <ros-dev(a)reactos.org> > Envoyé le : Lundi, 6 Octobre 2008, 13h55mn 01s > Objet : Re: [ros-dev] [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty > > On Mon, Oct 6, 2008 at 7:23 AM, gedmurphy wrote: > > I'll put an address bar in, along with a few other changes. > > Just remind me so I don't forget. > > Could you look at whats required or left to get iexplore working? The > Wine import of all of the dlls is done and it should download the wine > gecko package if you start it but I believe someone was having > problems when they tried to install/run it, under Wine there is a > registry key we set in the wine.inf that stores the gecko download url > so maybe that is whats needed. Just enable iexplore in > reactos/base/applications and try to run it under ReactOS. If it works > we could ship it with the wine gecko binary as part of the release > process. > > -- > Steven Edwards iexplore doesnt compile now : shdocvw's IEWinMain is still a stub for now (shdocvw synced to 0.9.5 according to README.WINE) Kind regards, Sylvain Petreolle

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev