Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [cgutman] 36337: - Zero the memory after we allocate it

by Aleksey Bragin

I think if it's a generic buffer-allocating function, its callers should not rely on the memory being zeroed. (like they don't rely on pool and heap allocations, unless called with zero-heap flag). At least the comments to the function does not say "it returns a zeroed buffer". WBR, Aleksey. On Sep 20, 2008, at 4:31 AM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Fri Sep 19 19:31:02 2008 > New Revision: 36337 > > URL: http://svn.reactos.org/svn/reactos?rev=36337&view=rev > Log: > - Zero the memory after we allocate it > > Modified: > branches/aicom-network-fixes/drivers/network/tcpip/tcpip/pool.c

16 years, 12 months

Re: [ros-dev] [ros-diffs] [janderwald] 36295: - Update Status Icon when there is activity - Also update the Taskbar Notification Icon

by gedmurphy

Our LoadIcon is broken and can result in badly drawn / ugly icons. You should use LoadImage instead. LoadIcon is deprecated anyway, no one should be using it anymore. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of janderwald(a)svn.reactos.org Sent: 17 September 2008 22:59 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [janderwald] 36295: - Update Status Icon when there is activity - Also update the Taskbar Notification Icon + hIcon = NULL; + if (pContext->dwInOctets == IfEntry.dwInOctets && pContext->dwOutOctets == IfEntry.dwOutOctets && pContext->Status != 0) + { + hIcon = LoadIcon(netshell_hInstance, MAKEINTRESOURCE(IDI_NET_IDLE)); + pContext->Status = 0; + } + else if (pContext->dwInOctets != IfEntry.dwInOctets && pContext->dwOutOctets !=

17 years

On the use of stabs

by Samuel serapion

In my recent endeavors into porting ReactOS to the amd64 architecture I have discovered that the the x86_64-pc-mingw32 target uses DWARF debugging symbols by default. The reason for this change was very simple, stabs are strictly 32bit. A stabs record only has 32 bits to represent an address, it represents less information, was never properly standardized, so gdb is pretty much the only debugger which can handle gcc stabs in their full glory, and it is larger to boot. DWARF is better in every aspect. There is no reason to use stabs these days. encoded • does i386-mingw32 support DWARF2 ? NightStrike • the plan is that gcc4.3 will NightStrike • more specifically, it will also drop support for sjlj Dwarf 2 Unwind frames for mingw32/cygwin patch<http://gcc.gnu.org/ml/gcc-patches/2006-12/msg00133.html> mingw32-gcc4.3 packages are so patched afaics: http://sourceforge.net/project/showfiles.php?group_id=2435&package_id=241304 Right now ReactOS has a tool called rsym that parses stabs and coff symbol data. arty • rsym was made to keep compact line number info Ask yourself: Could we eliminate an entire build step that is imposed on all ros binaries? How hard would it be to teach the kernel about DWARF? (If we really wanted to) sedwards • wine dbghelp supports pdb too sedwards • CV, PDB, Stabs and Dwarf sedwards • as far as I know Reading Material: http://dwarfstd.org/dwarf-2.0.0.pdf http://dwarfstd.org/Dwarf3.pdf

17 years

Re: [ros-dev] [ros-diffs] [cgutman] 36275: - Add ADDRINFOW

by gedmurphy

All these recent umode network commits need to be reverted. Public definitions don't belong in a private header. As I said in my original commit " It won't build yet as it will rely on a rewrite of the network headers". When the header rewrites are committed (maybe a week from now) everything will build. It's at this point that people can get involved in getting the new umode architecture working in ros. Cheers, Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cgutman(a)svn.reactos.org Sent: 17 September 2008 04:07 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cgutman] 36275: - Add ADDRINFOW Author: cgutman Date: Tue Sep 16 22:07:15 2008 New Revision: 36275 URL: http://svn.reactos.org/svn/reactos?rev=36275&view=rev Log: - Add ADDRINFOW Modified: branches/umode-network-branch/dll/win32/ws2_32/inc/ws2_32p.h Modified: branches/umode-network-branch/dll/win32/ws2_32/inc/ws2_32p.h URL: http://svn.reactos.org/svn/reactos/branches/umode-network-branch/dll/win32/… ============================================================================== --- branches/umode-network-branch/dll/win32/ws2_32/inc/ws2_32p.h [iso-8859-1] (original) +++ branches/umode-network-branch/dll/win32/ws2_32/inc/ws2_32p.h [iso-8859-1] Tue Sep 16 22:07:15 2008 @@ -21,6 +21,18 @@ WsAsyncGetServByPort, WsAsyncTerminate, } WSASYNCOPS; + +typedef struct _ADDRINFOW +{ + INT ai_flags; + INT ai_family; + INT ai_socktype; + INT ai_protocol; + SIZE_T ai_addrlen; + PWSTR ai_canonname; + struct SOCKADDR *ai_addr; + struct ADDRINFOW *ai_next; +} ADDRINFOW, *PADDRINFOW; typedef struct _WSASYNCBLOCK {

17 years

test, please ignore

by Aleksey Bragin

Test of mailing list system operability.

17 years

Re: [ros-dev] [ros-diffs] [cwittich] 36188: sync most of rpcrt4 to wine 1.1.4

by Aleksey Bragin

I would prefer to have a log message saying what was NOT synced too. On Sep 13, 2008, at 7:52 PM, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sat Sep 13 10:52:50 2008 > New Revision: 36188 > > URL: http://svn.reactos.org/svn/reactos?rev=36188&view=rev > Log: > sync most of rpcrt4 to wine 1.1.4

17 years

Comment about r36137

by Pierre SCHWEITZER

Hi, the change done in r36137 on cdfs/fsctl.c appears to me to be wrong. For CDFS, IoCreateDevice should have its 4th parameter set to FILE_DEVICE_CD_ROM_FILE_SYSTEM and not to FILE_DEVICE_DISK_FILE_SYSTEM. For fastfat driver, it's OK. WBR, P. Schweitzer _________________________________________________________________ Installez gratuitement les 20 émôticones Windows Live Messenger les plus fous ! Cliquez ici ! http://www.emoticones-messenger.fr/

17 years

Re: [ros-dev] [ros-diffs] [dchapyshev] 36054: - Import pstorec from wine head

by Steven Edwards

On Mon, Sep 8, 2008 at 9:48 AM, <dchapyshev(a)svn.reactos.org> wrote: > Author: dchapyshev > Date: Mon Sep 8 08:48:25 2008 > New Revision: 36054 > > URL: http://svn.reactos.org/svn/reactos?rev=36054&view=rev > Log: > - Import pstorec from wine head Here is a patch from the CrossOver wine that are not in the Winehq tree. Feel free to fork for a while as no one in winehq has touched this dll for a while. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years

Re: [ros-dev] [ros-diffs] [cwittich] 36065: forgot to add these files

by Aleksey Bragin

This wouldn't happen if you used winesync script by hpoussin. On Sep 8, 2008, at 8:58 PM, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Mon Sep 8 11:58:34 2008 > New Revision: 36065 > > URL: http://svn.reactos.org/svn/reactos?rev=36065&view=rev > Log: > forgot to add these files > > Added: > trunk/reactos/dll/win32/msxml3/bsc.c (with props) > trunk/reactos/dll/win32/msxml3/cdata.c (with props) > trunk/reactos/dll/win32/msxml3/dispex.c (with props) > trunk/reactos/dll/win32/msxml3/docfrag.c (with props) > trunk/reactos/dll/win32/msxml3/domimpl.c (with props) > trunk/reactos/dll/win32/msxml3/entityref.c (with props) > trunk/reactos/dll/win32/msxml3/msxml3_v1.idl (with props) > trunk/reactos/dll/win32/msxml3/saxreader.c (with props)

17 years

Re: [ros-dev] [ros-diffs] [sginsberg] 36005: - Make sure we get a Subkey in RegDeleteKeyA/W. Fixes Winetests causing a system crash, but (for now) hides a bug in CM.

by Steven Edwards

On Sat, Sep 6, 2008 at 5:02 PM, <sginsberg(a)svn.reactos.org> wrote: > - Make sure we get a Subkey in RegDeleteKeyA/W. Fixes Winetests causing a system crash, but (for now) hides a bug in CM. Maybe we should throw a DPRINT1 here so we are reminded that the bug is still there. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

17 years

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev