Ros-dev

ros-dev@reactos.org

2 participants
5791 discussions

Re : [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty
by Sylvain Petreolle 06 Oct '08

06 Oct '08

----- Message d'origine ---- > De : Steven Edwards <winehacker(a)gmail.com> > À : ReactOS Development List <ros-dev(a)reactos.org> > Envoyé le : Lundi, 6 Octobre 2008, 13h55mn 01s > Objet : Re: [ros-dev] [gedmurphy] 36658: Remove the address and command windows from the bottom of the file browser. They're buggy and they're not too pretty > > On Mon, Oct 6, 2008 at 7:23 AM, gedmurphy wrote: > > I'll put an address bar in, along with a few other changes. > > Just remind me so I don't forget. > > Could you look at whats required or left to get iexplore working? The > Wine import of all of the dlls is done and it should download the wine > gecko package if you start it but I believe someone was having > problems when they tried to install/run it, under Wine there is a > registry key we set in the wine.inf that stores the gecko download url > so maybe that is whats needed. Just enable iexplore in > reactos/base/applications and try to run it under ReactOS. If it works > we could ship it with the wine gecko binary as part of the release > process. > > -- > Steven Edwards iexplore doesnt compile now : shdocvw's IEWinMain is still a stub for now (shdocvw synced to 0.9.5 according to README.WINE) Kind regards, Sylvain Petreolle

2 1

Re: [ros-dev] [ros-diffs] [cfinck] 36643: Update some links properly and update the description of Opera (sounds stupid to use the same for Firefox and Opera)
by Aleksey Bragin 05 Oct '08

05 Oct '08

Using "latest-X.0" looks more correct than specifying exact version number two times. WBR, Aleksey. On Oct 4, 2008, at 5:00 PM, cfinck(a)svn.reactos.org wrote: > Author: cfinck > Date: Sat Oct 4 08:00:33 2008 > New Revision: 36643 > > URL: http://svn.reactos.org/svn/reactos?rev=36643&view=rev > Log: > Update some links properly and update the description of Opera > (sounds stupid to use the same for Firefox and Opera) > > Modified: > trunk/rosapps/applications/downloader/downloader.xml > > Modified: trunk/rosapps/applications/downloader/downloader.xml > URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/ > downloader/downloader.xml?rev=36643&r1=36642&r2=36643&view=diff > ====================================================================== > ======== > --- trunk/rosapps/applications/downloader/downloader.xml > [iso-8859-1] (original) > +++ trunk/rosapps/applications/downloader/downloader.xml > [iso-8859-1] Sat Oct 4 08:00:33 2008 > @@ -12,13 +12,13 @@ > <licence>MPL/GPL/LGPL</licence> > <version>2.0.0.17</version> > <description>The most popular and one of the best free Web > Browsers out there.</description> > - <location>http://releases.mozilla.org/pub/mozilla.org/firefox/ > releases/latest-2.0/win32/en-US/Firefox%20Setup%202.0.0.17.exe</ > location> > + <location>http://releases.mozilla.org/pub/mozilla.org/firefox/ > releases/2.0.0.17/win32/en-US/Firefox%20Setup%202.0.0.17.exe</ > location> > </application> > <application name="Opera"> > <regname>Opera</regname> > <licence>Freeware</licence> > <version>9.26</version> > - <description>The most popular and one of the best free Web > Browsers out there.</description> > + <description>The popular Opera Browser with many advanced > features and including a Mail and BitTorrent client.</description> > <location>http://mirror.nwps.ws/opera/win/926/en/ > Opera_9.26_Classic_Setup.exe</location> > </application> > <application name="Thunderbird 1.5"> > @@ -26,20 +26,20 @@ > <licence>MPL/GPL/LGPL</licence> > <version>1.5.0.14</version> > <description>The most popular and one of the best free Mail > Clients out there.</description> > - <location>http://releases.mozilla.org/pub/mozilla.org/ > thunderbird/releases/latest-1.5/win32/en-US/Thunderbird%20Setup% > 201.5.0.14.exe</location> > + <location>http://releases.mozilla.org/pub/mozilla.org/ > thunderbird/releases/1.5.0.14/win32/en-US/Thunderbird%20Setup% > 201.5.0.14.exe</location> > </application> > <application name="Thunderbird 2.0"> > <regname>Mozilla Thunderbird (2.0.0.16)</regname> > <licence>MPL/GPL/LGPL</licence> > <version>2.0.0.16</version> > <description>The most popular and one of the best free Mail > Clients out there.</description> > - <location>http://releases.mozilla.org/pub/mozilla.org/ > thunderbird/releases/latest-2.0/win32/en-US/Thunderbird%20Setup% > 202.0.0.16.exe</location> > + <location>http://releases.mozilla.org/pub/mozilla.org/ > thunderbird/releases/2.0.0.17/win32/en-US/Thunderbird%20Setup% > 202.0.0.17.exe</location> > </application> > <application name="SeaMonkey"> > <regname>SeaMonkey (1.1.9)</regname> > <version>1.1.9</version> > <description>Mozilla Suite is alive. This is the one and only > Browser, Mail, Chat, and Composer bundle you will ever need.</ > description> > - <location>http://releases.mozilla.org/pub/mozilla.org/seamonkey/ > releases/1.1.9/seamonkey-1.1.9.en-US.win32.installer.exe</location> > + <location>http://releases.mozilla.org/pub/mozilla.org/seamonkey/ > releases/1.1.12/seamonkey-1.1.12.en-US.win32.installer.exe</location> > </application> > <application name="Mozilla ActiveX Control"> > <regname>Mozilla ActiveX Control v1.7.12 (ReactOS special)</ > regname> >

2 1

Re: [ros-dev] [ros-diffs] [fireball] 36426: [FORMATTING] - Reformat to the kernel coding style.
by Alex Ionescu 05 Oct '08

05 Oct '08

Please show me where the developers of this code agreed to having their code GPL V3 licensed. I would like to see a full trail of every developer that wrote this code, as well as written permission from them for you to slap on this license. Thank you. On 23-Sep-08, at 7:45 AM, fireball(a)svn.reactos.org wrote: > + * LICENSE: GPL v2 or later - See COPYING in the top level > directory Best regards, Alex Ionescu

7 9

Re: [ros-dev] Reformat to the kernel coding style.
by chris evans 04 Oct '08

04 Oct '08

Pasting gpl notices in every file of a project, takes up space. better to put in license.txt in project root to encompass all source files. but most that don't like a license will refuse to use it and just copy paste the code anyways, and not say where they got it. (happens all the time). kinda makes me wonder why we got licenses for software in the first place, seems to be silly constructs of obstructionism. GPLv3 don't allow you to control the software that runs on the custom hardware, inability to link to the code with out upsetting the original author. ce From: James Tabor <jimtabor.rosdev(a)gmail.com> To: ReactOS Development List <ros-dev(a)reactos.org> Sent: Saturday, October 4, 2008 12:38:23 AM Subject: Re: Reformat to the kernel coding style. 1st: No to v3! 2nd: No to v3! 3rd: No to v3! On Fri, Oct 3, 2008 at 11:44 PM, Alex Ionescu <ionucu(a)videotron.ca> wrote: > You basically assumed that a header from another file (probably copy- > pasted) applies to the file you modified. > > While I'm certainly being pedantic, and I admit it -- this shouldn't > be a change to brush over. > > Someone needs to figure out if the devs agree with v3 or not -- I

1 0

[ros-diffs] [sginsberg] 36624: - Add missing APIENTRY to ntgdi.h, syscalls are always stdcall.
by James Tabor 02 Oct '08

02 Oct '08

Hi! Something looks wrong with this patch..... >From the latest SDK I have Version 6. __kernel_entry W32KAPI BOOL NtGdiUpdateTransform( __in HDC hdc ); __kernel_entry W32KAPI BOOL NtGdiSetPUMPDOBJ( __in_opt HUMPD humpd, __in BOOL bStoreID, __inout_opt HUMPD *phumpd, __out_opt BOOL *pbWOW64 ); __kernel_entry W32KAPI BOOL NtGdiBRUSHOBJ_DeleteRbrush( __in_opt BRUSHOBJ *pbo, __in_opt BRUSHOBJ *pboB ); __kernel_entry W32KAPI BOOL NtGdiUMPDEngFreeUserMem( __in KERNEL_PVOID *ppv ); Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [hyperion] 36610: modified ke/i386/cpu.c Added CMPXCHG8B enabling/detection code for TransMeta, Centaur and Rise (source: <URL: http://www.geoffchappell.com/notes/windows/kernel/cpu/cx8.htm>). Code dead until each vendor will be officially supported Alex and others: please review
by Aleksey Bragin 01 Oct '08

01 Oct '08

Why wrap into #ifdefs? I thought it's supposed to be runtime, not compile time. WBR, Aleksey. On Oct 1, 2008, at 3:54 PM, hyperion(a)svn.reactos.org wrote: > Author: hyperion > Date: Wed Oct 1 06:54:29 2008 > New Revision: 36610 > > URL: http://svn.reactos.org/svn/reactos?rev=36610&view=rev > Log: > modified ke/i386/cpu.c > Added CMPXCHG8B enabling/detection code for TransMeta, Centaur > and Rise (source: <URL: http://www.geoffchappell.com/notes/windows/ > kernel/cpu/cx8.htm>). Code dead until each vendor will be > officially supported > Alex and others: please review

2 1

CMPXHG8B Support
by Alex Ionescu 01 Oct '08

01 Oct '08

I was asked on IRC to add support for non-Intel and AMD CPUs to the kernel. Obviously I can't do that -- but I mentioned that some special "magic tricks" need to be done to enable support for the instruction on other CPUs, which is why I made the kernel bugcheck. Thankfully, someone documented the steps required, so I won't get in trouble for pointing out this link for you: http://www.geoffchappell.com/notes/windows/kernel/cpu/cx8.htm. I can confirm that's what the kernel does. Do that too, and you can then support Transmeta/Rise/VIA CPUs. Best regards, Alex Ionescu

2 1

Re: [ros-dev] [ros-diffs] [jimtabor] 36596: - Patch by Vincent Povirk, Handle undocumented WM_POPUPSYSTENNEBU message.
by Alex Ionescu 30 Sep '08

30 Sep '08

James, if it's undocumented, please don't add it to the SDK headers. On 29-Sep-08, at 8:27 PM, jimtabor(a)svn.reactos.org wrote: > WM_POPUPSYSTEMMENU Best regards, Alex Ionescu

2 1

Re: [ros-dev] [ros-diffs] [hyperion] 36586: modified dll/win32/kernel32/kernel32.def modified dll/win32/kernel32/kernel32.rbuild added dll/win32/kernel32/misc/icustubs.cpp Export NormalizeString and IsStringNormalized from kernel32.dll. This (finally) makes normaliz.dll (50%) functional. Link kernel32.dll to ICU. Finally. Binary size increased by about 300 KB on a debug build (this is only the beginning). Umpteenth copy of C++ and Win32 stubs required to get ICU to link properly added to kernel32.dll. This
by Aleksey Bragin 29 Sep '08

29 Sep '08

It's going (if not already) to overflow the baseaddress range given to it, thus making ntdll.dll relocated, which leads to obvious problems. WBR, Aleksey. On Sep 29, 2008, at 2:39 AM, hyperion(a)svn.reactos.org wrote: > Author: hyperion > Date: Sun Sep 28 17:39:45 2008 > New Revision: 36586 > > URL: http://svn.reactos.org/svn/reactos?rev=36586&view=rev > Log: > modified dll/win32/kernel32/kernel32.def > modified dll/win32/kernel32/kernel32.rbuild > added dll/win32/kernel32/misc/icustubs.cpp > Export NormalizeString and IsStringNormalized from kernel32.dll. > This (finally) makes normaliz.dll (50%) functional. > Link kernel32.dll to ICU. Finally. Binary size increased by > about 300 KB on a debug build (this is only the beginning). > Umpteenth copy of C++ and Win32 stubs required to get ICU to > link properly added to kernel32.dll. > This commit dedicated to Timo Kreuzer. <3.

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 36580: - Raise IRQL to DISPATCH_LEVEL before using KeAcquireSpinLockAtDpcLevel/KeReleaseSpinLockFromDpcLevel
by Aleksey Bragin 29 Sep '08

29 Sep '08

Is it really supposed to be so? Why don't you just use KeAcquireSpinlock, which would save you the current IRQL level? For me it looks like a hack. WBR, Aleksey Bragin. On Sep 28, 2008, at 11:58 PM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Sun Sep 28 14:58:09 2008 > New Revision: 36580 > > URL: http://svn.reactos.org/svn/reactos?rev=36580&view=rev > Log: > - Raise IRQL to DISPATCH_LEVEL before using > KeAcquireSpinLockAtDpcLevel/KeReleaseSpinLockFromDpcLevel > > Modified: > branches/aicom-network-fixes/drivers/network/ndis/ndis/protocol.c > > Modified: branches/aicom-network-fixes/drivers/network/ndis/ndis/ > protocol.c > URL: http://svn.reactos.org/svn/reactos/branches/aicom-network- > fixes/drivers/network/ndis/ndis/protocol.c? > rev=36580&r1=36579&r2=36580&view=diff > ====================================================================== > ======== > --- branches/aicom-network-fixes/drivers/network/ndis/ndis/ > protocol.c [iso-8859-1] (original) > +++ branches/aicom-network-fixes/drivers/network/ndis/ndis/ > protocol.c [iso-8859-1] Sun Sep 28 14:58:09 2008 > @@ -67,6 +67,7 @@ > { > UINT BufferedLength; > UINT PacketLength; > + KIRQL OldIrql; > > NDIS_DbgPrint(MAX_TRACE, ("Called.\n")); > > @@ -75,6 +76,8 @@ > #endif > > NdisQueryPacket(Packet, NULL, NULL, NULL, &PacketLength); > + > + KeRaiseIrql(DISPATCH_LEVEL, &OldIrql); > > NDIS_DbgPrint(MAX_TRACE, ("acquiring miniport block lock\n")); > KeAcquireSpinLockAtDpcLevel(&Adapter->NdisMiniportBlock.Lock); > @@ -102,6 +105,8 @@ > Adapter->NdisMiniportBlock.IndicatedPacket > [KeGetCurrentProcessorNumber()] = NULL; > } > KeReleaseSpinLockFromDpcLevel(&Adapter->NdisMiniportBlock.Lock); > + > + KeLowerIrql(OldIrql); > > return STATUS_SUCCESS; > } >

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev