Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

NtUserCreateWindowEx parameters
by Jeetu Golani 23 Oct '08

23 Oct '08

Hi there, I've been snooping into the internals of Win XP and have setup a win32sys SDT hook on the NtUserCreateWindowEx function. I'd written sometime back to the list stating that the x,y,nWidth and nHeight parameters were showing values I couldn't understand - negative values et al. Since then I realized that this had to do with the fact that the parameter positions in the prototype I was using seemed to be in a different order (discovered a window.c file from this project on koders.com and was using this prototype). I think this could possibly be because maybe the ros team has been looking at a version of windows that isn't XP (possible??)..dunno Anyways the parameter ordering I've deduced seems to be : NtUserCreateWindowEx(DWORD dwExStyle,PUNICODE_STRING UnsafeClassName,PUNICODE_STRING UnsafeWindowName,DWORD dwUnknown1,DWORD dwStyle,LONG x, LONG y,LONG nWidth, LONG nHeight,HWND hWndParent,HMENU,hMenu,HINSTANCE hInstance,LPVOID lpParam,DWORD dwShowMode,DWORD dwUnknown2) This seems to be correct with regards the dwExStyle,dwStyle,x,y,nWidth,nHeight,hWndParent.hMenu,hInstance,lpParam arguments. I'm still not able to verify the rest. My immediate concern though are the UnsafeClassName and UnsafeWindowName arguments. I'm trying to print out these values...or test out what these values hold...but can't seem to get anywhere....don't even know for sure if these are UNICODE_STRING structure vals or LPCTSTR. I'd like to be able to retrieve/interpret the ClassName and WindowName......any help would be appreciated. Bye for now

3 6

Re: [ros-dev] [ros-diffs] [hyperion] 36761: added lib/rtl/rtl-common.rbuild modified lib/rtl/rtl.rbuild Compile rtl twice, as rtl_umode and rtl_kmode. Allows conditional compilation of RTL (finally!), instead of necessitating hacks like RtlpGetMode()
by Alex Ionescu 20 Oct '08

20 Oct '08

"It's like NT does" isn't an advantage... cloning *build methods* of the Core OS Division at Microsoft doesn't do anything positive (nor negative) to the quality and reliability of the code. You have to look at *what* the method involves and analyze that way. Your other argument applies: building RTL multiple times reduces the need for the small support library ReactOS uses and gives one consistent place for RTL code. Disadvantages: - Building RTL up to 4 times, increasing build time substantially (rtl is a pretty big library). - Quadruple-conditional compilation...meaning people will have to test their rtl changes by BUILDING FOUR TIMES with different conditionals. Will people really remember to do this? Will people really write code knowing exactly what do ifdef and where, and how? - To do this right, you'll need a host-rtl too. Have fun writing one. - Right now the commit did only half the work -- now compile time is doubled, but libsupp is still there, making the situation even worse. The commiter made the assumption "other people" will pick up the slack, which probably won't happen, and this will rot forever. Best regards, Alex Ionescu On Wed, Oct 15, 2008 at 2:41 PM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > I knew about this post-factum, so let's gather opinions. > > Advantage: It's like NT does, less hacks, possible removal of libsupp > stuff in ntoskrnl, freeldr, ntdll, etc (which I actually thought > would be done in the same commit). > > Disadvantage: To be proper, you need a bootloader RTL too, otherwise > RTL will still contain "necessitating hacks" aka libsupp stuff. This > is gonna make at least 3x time RTL compilation. (thankfully / sadly > we don't test it directly). > > > WBR, > Aleksey. > > > > On Oct 15, 2008, at 10:02 PM, Alex Ionescu wrote: > >> Well, you just removed the one thing ReactOS did different from NT and >> that I thought was really revolutionary and innovative, because it >> saves on compile time. It's funny, because I've been trying to sell >> this as a better approach to building RTL (It's built at least 4 times >> in the real NT tree, I think -- loader, user-mode tools/testing, >> kernel, user-mode). >> >> Best regards, >> Alex Ionescu > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

2 2

Re : [ros-diffs] [pschweitzer] 36771: Apply fix at the right place.......
by Sylvain Petreolle 17 Oct '08

17 Oct '08

Good old patch seems ok to me. Kind regards, Sylvain Petreolle Support artists, not multinationals - http://Iwouldntsteal.net Supportez les artistes, pas les multinationales - http://Iwouldntsteal.net ----- Message d'origine ---- > De : Pierre SCHWEITZER <heis_spiter(a)hotmail.com> > À : ReactOS Development List <ros-dev(a)reactos.org> > Envoyé le : Vendredi, 17 Octobre 2008, 14h37mn 51s > Objet : Re: [ros-dev] [ros-diffs] [pschweitzer] 36771: Apply fix at the right place....... > > > Shamefully, yes. > I didn't find good programme to do it under Linux. Speaking of that, if someone > using Linux could give me some pieces of advice about GUI svn clients under > Linux, I would be glad :). > TIA, > Pierre > ---------------------------------------- > > From: aleksey(a)reactos.org > > Date: Fri, 17 Oct 2008 10:44:46 +0400 > > To: ros-dev(a)reactos.org > > Subject: Re: [ros-dev] [ros-diffs] [pschweitzer] 36771: Apply fix at the > right place....... > > > > Are you merging manually? > > > > On Oct 16, 2008, at 10:21 PM, pschweitzer(a)svn.reactos.org wrote: > > > >> Author: pschweitzer > >> Date: Thu Oct 16 13:21:05 2008 > >> New Revision: 36771 > >> > >> URL: http://svn.reactos.org/svn/reactos?rev=36771&view=rev > >> Log: > >> Apply fix at the right place....... > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > _________________________________________________________________ > Inédit ! Des Emoticônes Déjantées! Installez les dans votre Messenger ! > http://www.ilovemessenger.fr/Emoticones/EmoticonesDejantees.aspx > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 36771: Apply fix at the right place.......
by Aleksey Bragin 17 Oct '08

17 Oct '08

Are you merging manually? On Oct 16, 2008, at 10:21 PM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Thu Oct 16 13:21:05 2008 > New Revision: 36771 > > URL: http://svn.reactos.org/svn/reactos?rev=36771&view=rev > Log: > Apply fix at the right place.......

4 4

Re: [ros-dev] [ros-diffs] [sginsberg] 36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord
by gedmurphy 17 Oct '08

17 Oct '08

Why do you need to publically state it was broken and who broke it? Does it make you feel more important and help to boost your ego? -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of sginsberg(a)svn.reactos.org Sent: 16 October 2008 21:02 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [sginsberg] 36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord Author: sginsberg Date: Thu Oct 16 15:02:22 2008 New Revision: 36773 URL: http://svn.reactos.org/svn/reactos?rev=36773&view=rev Log: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord Modified: trunk/reactos/dll/win32/gdi32/objects/text.c Modified: trunk/reactos/dll/win32/gdi32/objects/text.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/objects/te… ============================================================================== --- trunk/reactos/dll/win32/gdi32/objects/text.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/gdi32/objects/text.c [iso-8859-1] Thu Oct 16 15:02:22 2008 @@ -358,20 +358,24 @@ * @implemented */ INT -STDCALL +WINAPI GetTextFaceW(HDC hDC, - int nCount, - LPWSTR lpFaceName) -{ - INT retValue = 0; - if ((!lpFaceName) || (nCount)) - { - retValue = NtGdiGetTextFaceW(hDC,nCount,lpFaceName,0); + INT nCount, + PWSTR pFaceName) +{ + INT retValue; + + if ((pFaceName && nCount) || + !(pFaceName && nCount)) + { + retValue = NtGdiGetTextFaceW(hDC, nCount, pFaceName, 0); } else { SetLastError(ERROR_INVALID_PARAMETER); - } + retValue = 0; + } + return retValue; }

7 8

36773: - Unbreak GetTextFaceA/W, broken since 28730 by GreatLord
by Sylvain Petreolle 17 Oct '08

17 Oct '08

Isnt that condition always true ? + if ((pFaceName && nCount) || + !(pFaceName && nCount)) Kind regards, Sylvain Petreolle Support artists, not multinationals - http://Iwouldntsteal.net Supportez les artistes, pas les multinationales - http://Iwouldntsteal.net

2 1

Re: [ros-dev] [ros-diffs] [janderwald] 36762: - Implement Advanced Status IP Information Dialog - Import language strings from netcfgx - Add icon group (32x32) - ncpa is now a candidate for deletion
by gedmurphy 16 Oct '08

16 Oct '08

Well, we can't actually delete ncpa, it just needs to be rewritten to use the netshell library instead. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of janderwald(a)svn.reactos.org Sent: 15 October 2008 18:21 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [janderwald] 36762: - Implement Advanced Status IP Information Dialog - Import language strings from netcfgx - Add icon group (32x32) - ncpa is now a candidate for deletion - ncpa is now a candidate for deletion

1 0

15 Oct '08

Well, you just removed the one thing ReactOS did different from NT and that I thought was really revolutionary and innovative, because it saves on compile time. It's funny, because I've been trying to sell this as a better approach to building RTL (It's built at least 4 times in the real NT tree, I think -- loader, user-mode tools/testing, kernel, user-mode). Best regards, Alex Ionescu On Wed, Oct 15, 2008 at 11:45 AM, <hyperion(a)svn.reactos.org> wrote: > Author: hyperion > Date: Wed Oct 15 10:45:11 2008 > New Revision: 36761 > > URL: http://svn.reactos.org/svn/reactos?rev=36761&view=rev > Log: > added lib/rtl/rtl-common.rbuild > modified lib/rtl/rtl.rbuild > Compile rtl twice, as rtl_umode and rtl_kmode. Allows conditional compilation of RTL (finally!), instead of necessitating hacks like RtlpGetMode() > "rtl" module now a dummy static library for things like <include base="rtl"> > > modified boot/freeldr/freeldr/freeldr.rbuild > modified boot/freeldr/freeldr/setupldr.rbuild > modified ntoskrnl/ntoskrnl-generic.rbuild > rtl -> rtl_kmode > > modified dll/ntdll/ntdll.rbuild > rtl -> rtl_umode > > This commit dedicated to Fireball and Stefan100 (now get to work! >:3) > > Added: > trunk/reactos/lib/rtl/rtl-common.rbuild (with props) > Modified: > trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild > trunk/reactos/boot/freeldr/freeldr/setupldr.rbuild > trunk/reactos/dll/ntdll/ntdll.rbuild > trunk/reactos/lib/rtl/rtl.rbuild > trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild > > Modified: trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/freel… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -11,7 +11,7 @@ > <library>freeldr_main</library> > <library>rossym</library> > <library>cmlib</library> > - <library>rtl</library> > + <library>rtl_kmode</library> > <library>libcntpr</library> > <linkerflag>-static</linkerflag> > <linkerflag>-lgcc</linkerflag> > > Modified: trunk/reactos/boot/freeldr/freeldr/setupldr.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/setup… > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/setupldr.rbuild [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/setupldr.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -9,7 +9,7 @@ > <library>setupldr_main</library> > <library>rossym</library> > <library>cmlib</library> > - <library>rtl</library> > + <library>rtl_kmode</library> > <library>libcntpr</library> > <linkerflag>-nostartfiles</linkerflag> > <linkerflag>-nostdlib</linkerflag> > > Modified: trunk/reactos/dll/ntdll/ntdll.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ntdll.rbuild?rev… > ============================================================================== > --- trunk/reactos/dll/ntdll/ntdll.rbuild [iso-8859-1] (original) > +++ trunk/reactos/dll/ntdll/ntdll.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -12,7 +12,7 @@ > <define name="_WIN32_WINNT">0x0502</define> > <define name="_NTOSKRNL_" /> > <define name="__NO_CTYPE_INLINES" /> > - <library>rtl</library> > + <library>rtl_umode</library> > <library>ntdllsys</library> > <library>libcntpr</library> > <library>pseh</library> > > Added: trunk/reactos/lib/rtl/rtl-common.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/rtl-common.rbuild?… > ============================================================================== > --- trunk/reactos/lib/rtl/rtl-common.rbuild (added) > +++ trunk/reactos/lib/rtl/rtl-common.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -1,0 +1,98 @@ > +<?xml version="1.0"?> > + > +<include base="rtl">.</include> > +<define name="_NTOSKRNL_" /> > +<define name="__NO_CTYPE_INLINES" /> > +<define name="NO_RTL_INLINES" /> > +<define name="_NTSYSTEM_" /> > +<define name="_NTDLLBUILD_" /> > +<if property="ARCH" value="i386"> > + <directory name="i386"> > + <file>debug_asm.S</file> > + <file>except_asm.s</file> > + <file>except.c</file> > + <file>random_asm.S</file> > + <file>rtlswap.S</file> > + <file>rtlmem.s</file> > + <file>res_asm.s</file> > + <file>thread.c</file> > + </directory> > +</if> > +<if property="ARCH" value="powerpc"> > +<directory name="powerpc"> > + <file>debug.c</file> > + <file>except.c</file> > + <file>interlocked.c</file> > + <file>rtlmem.s</file> > + <file>rtlswap.s</file> > + <file>thread.c</file> > +</directory> > +</if> > +<if property="ARCH" value="arm"> > + <directory name="arm"> > + <file>debug_asm.S</file> > + </directory> > + <file>mem.c</file> > + <file>memgen.c</file> > +</if> > +<directory name="austin"> > + <file>avl.c</file> > + <file>tree.c</file> > +</directory> > + > +<file>access.c</file> > +<file>acl.c</file> > +<file>actctx.c</file> > +<file>atom.c</file> > +<file>bitmap.c</file> > +<file>bootdata.c</file> > +<file>compress.c</file> > +<file>condvar.c</file> > +<file>crc32.c</file> > +<file>critical.c</file> > +<file>dbgbuffer.c</file> > +<file>debug.c</file> > +<file>dos8dot3.c</file> > +<file>encode.c</file> > +<file>env.c</file> > +<file>error.c</file> > +<file>exception.c</file> > +<file>generictable.c</file> > +<file>handle.c</file> > +<file>heap.c</file> > +<file>image.c</file> > +<file>interlck.c</file> > +<file>message.c</file> > +<file>largeint.c</file> > +<file>luid.c</file> > +<file>network.c</file> > +<file>nls.c</file> > +<file>path.c</file> > +<file>ppb.c</file> > +<file>process.c</file> > +<file>propvar.c</file> > +<file>qsort.c</file> > +<file>random.c</file> > +<file>rangelist.c</file> > +<file>registry.c</file> > +<file>res.c</file> > +<file>resource.c</file> > +<file>sd.c</file> > +<file>security.c</file> > +<file>slist.c</file> > +<file>sid.c</file> > +<file>sprintf.c</file> > +<file>srw.c</file> > +<file>swprintf.c</file> > +<file>splaytree.c</file> > +<file>thread.c</file> > +<file>time.c</file> > +<file>timezone.c</file> > +<file>timerqueue.c</file> > +<file>unicode.c</file> > +<file>unicodeprefix.c</file> > +<file>vectoreh.c</file> > +<file>version.c</file> > +<file>wait.c</file> > +<file>workitem.c</file> > +<pch>rtl.h</pch> > > Propchange: trunk/reactos/lib/rtl/rtl-common.rbuild > ------------------------------------------------------------------------------ > svn:eol-style = native > > Modified: trunk/reactos/lib/rtl/rtl.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/rtl.rbuild?rev=367… > ============================================================================== > --- trunk/reactos/lib/rtl/rtl.rbuild [iso-8859-1] (original) > +++ trunk/reactos/lib/rtl/rtl.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -1,100 +1,15 @@ > <?xml version="1.0"?> > <!DOCTYPE module SYSTEM "../../tools/rbuild/project.dtd"> > -<module name="rtl" type="staticlibrary"> > - <define name="_NTOSKRNL_" /> > - <define name="__NO_CTYPE_INLINES" /> > - <define name="NO_RTL_INLINES" /> > - <define name="_NTSYSTEM_" /> > - <define name="_NTDLLBUILD_" /> > - <include base="rtl">.</include> > - <if property="ARCH" value="i386"> > - <directory name="i386"> > - <file>debug_asm.S</file> > - <file>except_asm.s</file> > - <file>except.c</file> > - <file>random_asm.S</file> > - <file>rtlswap.S</file> > - <file>rtlmem.s</file> > - <file>res_asm.s</file> > - <file>thread.c</file> > - </directory> > - </if> > - <if property="ARCH" value="powerpc"> > - <directory name="powerpc"> > - <file>debug.c</file> > - <file>except.c</file> > - <file>interlocked.c</file> > - <file>rtlmem.s</file> > - <file>rtlswap.s</file> > - <file>thread.c</file> > - </directory> > - </if> > - <if property="ARCH" value="arm"> > - <directory name="arm"> > - <file>debug_asm.S</file> > - </directory> > - <file>mem.c</file> > - <file>memgen.c</file> > - </if> > - <directory name="austin"> > - <file>avl.c</file> > - <file>tree.c</file> > - </directory> > > - <file>access.c</file> > - <file>acl.c</file> > - <file>actctx.c</file> > - <file>atom.c</file> > - <file>bitmap.c</file> > - <file>bootdata.c</file> > - <file>compress.c</file> > - <file>condvar.c</file> > - <file>crc32.c</file> > - <file>critical.c</file> > - <file>dbgbuffer.c</file> > - <file>debug.c</file> > - <file>dos8dot3.c</file> > - <file>encode.c</file> > - <file>env.c</file> > - <file>error.c</file> > - <file>exception.c</file> > - <file>generictable.c</file> > - <file>handle.c</file> > - <file>heap.c</file> > - <file>image.c</file> > - <file>interlck.c</file> > - <file>message.c</file> > - <file>largeint.c</file> > - <file>luid.c</file> > - <file>network.c</file> > - <file>nls.c</file> > - <file>path.c</file> > - <file>ppb.c</file> > - <file>process.c</file> > - <file>propvar.c</file> > - <file>qsort.c</file> > - <file>random.c</file> > - <file>rangelist.c</file> > - <file>registry.c</file> > - <file>res.c</file> > - <file>resource.c</file> > - <file>sd.c</file> > - <file>security.c</file> > - <file>slist.c</file> > - <file>sid.c</file> > - <file>sprintf.c</file> > - <file>srw.c</file> > - <file>swprintf.c</file> > - <file>splaytree.c</file> > - <file>thread.c</file> > - <file>time.c</file> > - <file>timezone.c</file> > - <file>timerqueue.c</file> > - <file>unicode.c</file> > - <file>unicodeprefix.c</file> > - <file>vectoreh.c</file> > - <file>version.c</file> > - <file>wait.c</file> > - <file>workitem.c</file> > - <pch>rtl.h</pch> > -</module> > +<group xmlns:xi="http://www.w3.org/2001/XInclude"> > + <module name="rtl_umode" type="staticlibrary"> > + <xi:include href="rtl-common.rbuild" /> > + </module> > + > + <module name="rtl_kmode" type="staticlibrary"> > + <xi:include href="rtl-common.rbuild" /> > + </module> > + > +  > + <module name="rtl" type="staticlibrary" /> > +</group> > > Modified: trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl-generic.… > ============================================================================== > --- trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] Wed Oct 15 10:45:11 2008 > @@ -26,7 +26,7 @@ > <library>hal</library> > <library>pseh</library> > <library>cmlib</library> > - <library>rtl</library> > + <library>rtl_kmode</library> > <library>rossym</library> > <library>libcntpr</library> > <library>kdcom</library> > >

4 4

Re: [ros-dev] [ros-diffs] [cgutman] 36754: - Fix a crash that happens when DriverEntry doesn't complete successfully - Return the correct status when LoopRegisterAdapter fails
by gedmurphy 15 Oct '08

15 Oct '08

I know I'm being pedantic here, but this patch is pretty ugly. A prime case for a goto IMO. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cgutman(a)svn.reactos.org Sent: 15 October 2008 00:15 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cgutman] 36754: - Fix a crash that happens when DriverEntry doesn't complete successfully - Return the correct status when LoopRegisterAdapter fails Author: cgutman Date: Tue Oct 14 18:15:22 2008 New Revision: 36754 URL: http://svn.reactos.org/svn/reactos?rev=36754&view=rev Log: - Fix a crash that happens when DriverEntry doesn't complete successfully - Return the correct status when LoopRegisterAdapter fails Modified: branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c Modified: branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c [iso-8859-1] Tue Oct 14 18:15:22 2008 @@ -686,7 +686,8 @@ FILE_DEVICE_NETWORK, 0, FALSE, &RawIPDeviceObject); if (!NT_SUCCESS(Status)) { TI_DbgPrint(MIN_TRACE, ("Failed to create RawIP device object. Status (0x%X).\n", Status)); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); return Status; } @@ -695,7 +696,9 @@ FILE_DEVICE_NETWORK, 0, FALSE, &UDPDeviceObject); if (!NT_SUCCESS(Status)) { TI_DbgPrint(MIN_TRACE, ("Failed to create UDP device object. Status (0x%X).\n", Status)); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); return Status; } @@ -704,7 +707,10 @@ FILE_DEVICE_NETWORK, 0, FALSE, &TCPDeviceObject); if (!NT_SUCCESS(Status)) { TI_DbgPrint(MIN_TRACE, ("Failed to create TCP device object. Status (0x%X).\n", Status)); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); return Status; } @@ -713,7 +719,11 @@ EntityList = ExAllocatePool(NonPagedPool, sizeof(TDIEntityID) * MAX_TDI_ENTITIES ); if (!EntityList) { TI_DbgPrint(MIN_TRACE, ("Insufficient resources.\n")); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); return STATUS_INSUFFICIENT_RESOURCES; } @@ -733,14 +743,25 @@ /* Allocate NDIS packet descriptors */ NdisAllocatePacketPool(&NdisStatus, &GlobalPacketPool, 100, sizeof(PACKET_CONTEXT)); if (NdisStatus != NDIS_STATUS_SUCCESS) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); return STATUS_INSUFFICIENT_RESOURCES; } /* Allocate NDIS buffer descriptors */ NdisAllocateBufferPool(&NdisStatus, &GlobalBufferPool, 100); if (NdisStatus != NDIS_STATUS_SUCCESS) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); return STATUS_INSUFFICIENT_RESOURCES; } @@ -762,19 +783,46 @@ /* Initialize transport level protocol subsystems */ Status = RawIPStartup(); if( !NT_SUCCESS(Status) ) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); return Status; } Status = UDPStartup(); if( !NT_SUCCESS(Status) ) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); + RawIPShutdown(); return Status; } Status = TCPStartup(); if( !NT_SUCCESS(Status) ) { - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); + RawIPShutdown(); + UDPShutdown(); return Status; } @@ -794,15 +842,41 @@ NULL, 0, NULL); - TiUnload(DriverObject); + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); + RawIPShutdown(); + UDPShutdown(); + TCPShutdown(); + LANShutdown(); return Status; } /* Open loopback adapter */ - if (!NT_SUCCESS(LoopRegisterAdapter(NULL, NULL))) { + Status = LoopRegisterAdapter(NULL, NULL); + if (!NT_SUCCESS(Status)) { TI_DbgPrint(MIN_TRACE, ("Failed to create loopback adapter. Status (0x%X).\n", Status)); - TiUnload(DriverObject); - return STATUS_INSUFFICIENT_RESOURCES; + ChewShutdown(); + IoDeleteDevice(IPDeviceObject); + IoDeleteDevice(RawIPDeviceObject); + IoDeleteDevice(UDPDeviceObject); + IoDeleteDevice(TCPDeviceObject); + ExFreePool(EntityList); + NdisFreePacketPool(GlobalPacketPool); + NdisFreeBufferPool(GlobalBufferPool); + IPShutdown(); + RawIPShutdown(); + UDPShutdown(); + TCPShutdown(); + LANShutdown(); + LANUnregisterProtocol(); + return Status; } /* Use direct I/O */

1 0

Re: [ros-dev] Ros-dev Digest, Vol 50, Issue 14
by Olaf Siejka 14 Oct '08

14 Oct '08

If i may say anything, I dont think its a good idea to force NET 3.5 dependency. It`ll reduce the software usability range as not everyone is willing to upgrade from NET 2.0 Date: Mon, 13 Oct 2008 11:11:16 +0100 From: "gedmurphy" <gedmurphy(a)gmail.com> Subject: Re: [ros-dev] [ros-diffs] [gschneider] 36737: RosDbg Part 3/3: - Named pipe implementation based on .net namespace IO.Pipes with support of threads - Previous win32 test version would strip random characters from debug messages and crash on entering kdbg (related t To: <ros-dev(a)reactos.org> Message-ID: <001901c92d1c$083d7770$18b86650$@com> Content-Type: text/plain; charset="utf-8" I'd originally refrained from doing it this way, using pinvoke instead to keep .net 2.0 compatibility. Using classes such as NamedPipeServerStream forces a .net 3.5 dependency. Is this ok with everyone? Ged.

3 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev