Um...
KiDeliverApc already sets KernelApcPending = FALSE; Now you're setting
it twice...please revert.
On 1-Jul-08, at 3:08 AM, fireball(a)svn.reactos.org wrote:
> Author: fireball
> Date: Tue Jul 1 05:08:14 2008
> New Revision: 34230
>
> URL: http://svn.reactos.org/svn/reactos?rev=34230&view=rev
> Log:
> - Fix a problem with normal and special APCs being inserted in the
> wrong order, spotted by Jury Sidorov. Now Borland Turbo Debugger
> should be able to debug applications, also it can fix hangs in other
> applications.
> - When delivering kernel APC, set the pending flag to false (by
> analogy with delivering user APC and clearing its pending flag).
> See issue #3426 for more details.
>
> Modified:
> trunk/reactos/ntoskrnl/ke/apc.c (contents, props changed)
>
> Modified: trunk/reactos/ntoskrnl/ke/apc.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/apc.c?rev=3423…
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- trunk/reactos/ntoskrnl/ke/apc.c [iso-8859-1] (original)
> +++ trunk/reactos/ntoskrnl/ke/apc.c [iso-8859-1] Tue Jul 1 05:08:14
> 2008
> @@ -145,8 +145,8 @@
> /* Get the APC */
> QueuedApc = CONTAINING_RECORD(NextEntry, KAPC,
> ApcListEntry);
>
> - /* Is this a Normal APC? If so, break */
> - if (QueuedApc->NormalRoutine) break;
> + /* Is this a No-Normal APC? If so, break */
> + if (!QueuedApc->NormalRoutine) break;
>
> /* Move to the next APC in the Queue */
> NextEntry = NextEntry->Blink;
> @@ -320,6 +320,9 @@
> break;
> }
>
> + /* It's not pending anymore */
> + Thread->ApcState.KernelApcPending = FALSE;
> +
> /* Get the next Entry */
> ApcListEntry = Thread->ApcState.ApcListHead[KernelMode].Flink;
> Apc = CONTAINING_RECORD(ApcListEntry, KAPC, ApcListEntry);
>
> Propchange: trunk/reactos/ntoskrnl/ke/apc.c
> ------------------------------------------------------------------------------
> --- svn:needs-lock (original)
> +++ svn:needs-lock (removed)
> @@ -1,1 +1,0 @@
> -*
>
Best regards,
Alex Ionescu
Hello everyone,
As most devs including me noticed this "the input line is too long" bug
after hpoussin's changes in r34187 to r34191, I did some research on it.
Unfortunately, it looks like it's unfixable if we keep on directly using ld
for linking (as introduced in these revisions) instead of calling the gcc
frontend.
First of all, the "length" of the cmd input line under Windows seems to be
highly affected by quotation marks. If you add a quotation mark to the
working linker command line before hpoussin's commits, it will also be
reported as being too long.
Previously, we didn't use quotation marks in the command line when linking
the binaries.
Now we have to do this because of the changed PROJECT_LFLAGS and
PROJECT_LPPFLAGS variables: They contain the path to i.e. libgcc and as this
path can contain spaces, it has to be put in quotation marks. Just passing
"libgcc.a" without a path doesn't work.
Passing "-lgcc" also doesn't work, because mingw32-ld only seems to search
for libraries in "mingw32/lib", not "lib/gcc/mingw32/4.1.3" as gcc does.
I see no other solution than partly reverting hpoussin's changes and using
gcc for linking again.
If anyone sees another option, please comment or directly commit a fix.
Best regards,
Colin
On Sat, Jun 28, 2008 at 10:58 PM, <ros-arm-bringup(a)svn.reactos.org> wrote:
> +The views and conclusions contained in the software and documentation are those of the authors and
> +should not be interpreted as representing official policies, either expressed or implied, of the ReactOS
> +Project.
Sounds like the Ninja's don't want a libel lawsuit. =)
I don't see anything in this clause that is not GPL compatible, its just funny.
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
Hi,
Generate? fat.h and fat32.h are already included in the code base ,
installfreeldr will compile without problems
Regards,
/Marc
--------------------------------------------------
From: "Hervé Poussineau" <hpoussin(a)reactos.org>
Sent: Thursday, June 26, 2008 7:43 PM
To: <ros-dev(a)reactos.org>
Subject: Re: [ros-dev] [ros-diffs] [mpiulachs] 34106: - remove no
longerrequired bootsect.mak
> Hi,
>
> mpiulachs(a)svn.reactos.org a écrit :
>> Author: mpiulachs
>> Date: Thu Jun 26 10:58:56 2008
>> New Revision: 34106
>>
>> URL: http://svn.reactos.org/svn/reactos?rev=34106&view=rev
>> Log:
>> - remove no longer required bootsect.mak
>>
>> Removed:
>> trunk/reactos/boot/freeldr/bootsect/bootsect.mak
>>
>
> Which rbuild file tells how to generate the files
> reactos/boot/freeldr/bootsect/fat.h and fat32.h?
> They are required by reactos/boot/freeldr/install/install.c.
>
> The inclusion of install/installfreeldr.rbuild has been removed in
> r34055. I don't know if it is an error or not.
>
> Hervé
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
Hi,
mpiulachs(a)svn.reactos.org a écrit :
> Author: mpiulachs
> Date: Thu Jun 26 10:58:56 2008
> New Revision: 34106
>
> URL: http://svn.reactos.org/svn/reactos?rev=34106&view=rev
> Log:
> - remove no longer required bootsect.mak
>
> Removed:
> trunk/reactos/boot/freeldr/bootsect/bootsect.mak
>
Which rbuild file tells how to generate the files
reactos/boot/freeldr/bootsect/fat.h and fat32.h?
They are required by reactos/boot/freeldr/install/install.c.
The inclusion of install/installfreeldr.rbuild has been removed in
r34055. I don't know if it is an error or not.
Hervé
Grievance: Cease and Desist Request: Standard Resolution Procedure:
1) The Project Coordinator Should attempt to make decisions according
to the consensus of the Project Members.
Mr. Bragin is making procedural changes with out the full consensus of
all Project Members.
2) The Repository Coordinator Should make decisions which are fair and
reasonable, and preferably consistent with the consensus of the
Project Members.
Due to the unfilled Repository Coordinator position, Mr. Bragin has
assumed full control of that position and making decisions with out
the full consensus of all Project Members.
3) General rules:
a) Violation of first rule: Project Coordinator issued change orders,
Project Members began working on the changes. These changes are
against the general consensus among the Project Members. Reference:
http://www.reactos.org/archives/public/ros-dev/2008-June/010394.html
b) Violation of second rule: Project Coordinator banned Project Member
with out the ability to rejoin the Project at any time.
c) Violation of third rule: Project Coordinator assumed full control
of Repository Coordinator position and used that position to remove
access to a Project Member.
Adhering to: Standard Resolution Procedure: The procedure: The
procedure begins when a draft General Resolution is announced on a
public Project mailing list. Which no other rule can apply, I hereby
request a Cease and Desist until this Grievance is heard by all
Project Members. Project Members have a contractual agreement and must
abide by it.
PS: This is a very serious mater and not at all a joke. If this
project has any merit, it needs to resolve these issues in the open.
We have two different ways to do the same thing. Modules have a "host"
attribute to indicate if the module has to be build by host compiler rather
than target compiler but we also have the "hoststaticlibrary" module type ,
I don't know if "host" property is broken but someone with time should
test/fix it as it's the more appropiate way.
Marc,
--------------------------------------------------
From: <cfinck(a)svn.reactos.org>
Sent: Sunday, June 22, 2008 11:41 PM
To: <ros-diffs(a)reactos.org>
Subject: [ros-diffs] [cfinck] 34051: Build host_wcsfuncs as a host static
library, not a target static library Fixes build for all non-Win32 hosts
> Author: cfinck
> Date: Sun Jun 22 16:41:25 2008
> New Revision: 34051
>
> URL: http://svn.reactos.org/svn/reactos?rev=34051&view=rev
> Log:
> Build host_wcsfuncs as a host static library, not a target static library
> Fixes build for all non-Win32 hosts
>
> Modified:
> trunk/reactos/lib/host/wcsfuncs/wcsfuncs.rbuild
>
> Modified: trunk/reactos/lib/host/wcsfuncs/wcsfuncs.rbuild
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/lib/host/wcsfuncs/wcsfuncs…
> ==============================================================================
> --- trunk/reactos/lib/host/wcsfuncs/wcsfuncs.rbuild [iso-8859-1]
> (original)
> +++ trunk/reactos/lib/host/wcsfuncs/wcsfuncs.rbuild [iso-8859-1] Sun Jun
> 22 16:41:25 2008
> @@ -1,6 +1,6 @@
> <?xml version="1.0"?>
> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd">
> -<module name="host_wcsfuncs" type="staticlibrary">
> +<module name="host_wcsfuncs" type="hoststaticlibrary">
> <include base="ReactOS">include</include>
> <file>wcsfuncs.c</file>
> </module>
>
>