Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [dchapyshev] 33106: - Keyboard layout switching works now in ReactOS!
by gedmurphy 22 Apr '08

22 Apr '08

dchapyshev(a)svn.reactos.org wrote: > > Author: dchapyshev > Date: Tue Apr 22 14:01:56 2008 > New Revision: 33106 > > URL: http://svn.reactos.org/svn/reactos?rev=33106&view=rev > Log: > - Keyboard layout switching works now in ReactOS! Hi, just a few points about this patch. > + if (RegOpenKeyEx(HKEY_CURRENT_USER, _T("Keyboard > Layout\\Substitutes"), 0, KEY_QUERY_VALUE, &hKey) == ERROR_SUCCESS) > + { > + dwBufLen = MAX_PATH; > + > + if (RegQueryValueEx(hKey, szTempLCID, NULL, NULL, > (LPBYTE)szLCID, &dwBufLen) != ERROR_SUCCESS) Firstly, Reg functions work on bytes, so you introduced a potential buffer overflow here. But this is irrelevant due to the next point ;) > - Ret = SystemParametersInfo(SPI_SETDEFAULTINPUTLANG, 0, &hKl, > SPIF_SENDWININICHANGE); > + EnumWindows(EnumWindowsProc, (LPARAM) hKl); This looks like a hack. The original method was correct, it just need implementing in win32k. Have a look in NtUserSystemParametersInfo. Thirdly, what is this kbswitch app? It's not a standard windows tool, yet it's included in our base. Keyboard switching is done in intl.cpl, or via ctfmon (which we don't yet have) on a per app basis. Regards, Ged.

1 0

Re: [ros-dev] [ros-diffs] [greatlrd] 33014: fixed pipe working again from cmd more investigate are need it to figout who to really solv bat and pipe and gui apps issue so none regress and working fine in all case. rember gui apps can resive pipe from cmd or send to
by Aleksey 18 Apr '08

18 Apr '08

Any real explanation in the commit message about what was done in this commit? Short, real and clean, so every developer reading the commit messages could understand what was done and why. I'm suspicious that it "fixes" one bug, and reopens another. The same note applies to "start kill the bad macro DXG_GET_INDEX_FUNCTION that is instable" (rev. 33012). Macro is a preprocessor definition, it can't be stable or not, it's being performed before the actual compile stage. Better to explain while enumerating through all functions to find the best one is worse than just getting a pointer by indexing. Or why it was done so in the beginning. With the best regards, Aleksey Bragin. ----- Original Message ----- From: <greatlrd(a)svn.reactos.org> To: <ros-diffs(a)reactos.org> Sent: Friday, April 18, 2008 4:56 AM Subject: [ros-diffs] [greatlrd] 33014: fixed pipe working again from cmd more investigate are need it to figout who to really solv bat and pipe and gui apps issue so none regress and working fine in all case. rember gui apps can resive pipe from cmd or send to cmd > Author: greatlrd > Date: Thu Apr 17 19:56:01 2008 > New Revision: 33014 > > URL: http://svn.reactos.org/svn/reactos?rev=33014&view=rev > Log: > fixed pipe working again from cmd > more investigate are need it to figout who to really solv bat and pipe and > gui apps issue > so none regress and working fine in all case. rember gui apps can resive > pipe from cmd or send to cmd

1 0

ReactOS gdt limit
by Henning Schild 17 Apr '08

17 Apr '08

Hello ROS dev-team, i am currently working on qemu/kqemu and found that ROS sets the gdt limit to 0x800. At least this is what i see in qemu, i did not check ROS source. http://www.intel.com/design/processor/manuals/253668.pdf (3.5.1 p. 3-21) >> the GDT limit should always be one less than an integral multiple of >> eight (that is, 8N – 1) This may or may not be a problem. For all i can say ROS was the only of many different OSs that triggered the check in my setup. I may be wrong and wont investigate this any further. Just wanted to let you know. I used this version: http://prdownloads.sourceforge.net/reactos/ReactOS-0.3.4-REL-qemu.zip and that are the values i saw: base = 0x808bdac0 limit = 0x00000800 regards, Henning

3 2

Ntifs.h
by Gabriel ilardi 15 Apr '08

15 Apr '08

Hi Team, I came across this site: http://www.acc.umu.se/~bosse/ which has some windows drivers examples, and talks about filesystem drivers, it has a gnu version of ntifs.h (http://www.acc.umu.se/~bosse/ntifs.h), I've taken a look at it, and noticed that ours misses some defines and some definitions use other types instead of ours. I thought perhaps someone from the team would want to take a look at it, perhaps we could use it. Thanks. Best regards, Gabriel ilardi. PS: If you already knew about it please ignore this email. _________________________________________________________________ Racconta le tue emozioni sul blog! http://home.services.spaces.live.com/

3 2

Re : [ros-bugs] [Bug 3177] New: I try ReactOS-0.3.4-QEMU. When i try screensaver it gives bluescreen
by Sylvain Petreolle 13 Apr '08

13 Apr '08

Fireball, could you commit the bug writing guidelignes change to avoid this, please ? *saying Pleaase ... Help as Milla Jovovitch in the Fifth Element* Kind regards,Sylvain Petreolle (aka Usurp) Support artists, not multinationals - http://Iwouldntsteal.net Supportez les artistes, pas les multinationales - http://Iwouldntsteal.net ----- Message d'origine ---- > De : "ReactOS.Bugzilla(a)www.reactos.org" <ReactOS.Bugzilla(a)www.reactos.org> > À : ros-bugs(a)reactos.org > Envoyé le : Samedi, 12 Avril 2008, 22h08mn 14s > Objet : [ros-bugs] [Bug 3177] New: I try ReactOS-0.3.4-QEMU. When i try screensaver it gives bluescreen > > http://www.reactos.org/bugzilla/show_bug.cgi?id=3177 > > Summary: I try ReactOS-0.3.4-QEMU. When i try screensaver it > gives bluescreen > Product: ReactOS > Version: 0.3.4 > Platform: QEmu > OS/Version: Microsoft Windows XP > Status: UNCONFIRMED > Severity: normal > Priority: P3 > Component: Win32 > AssignedTo: ros-bugs(a)reactos.org > ReportedBy: maviates(a)gmail.com > QAContact: ros-bugs(a)reactos.org > > > Created an attachment (id=2431) > --> (http://www.reactos.org/bugzilla/attachment.cgi?id=2431) > BlueScreen > > I try ReactOS-0.3.4-QEMU. When i try screensaver it gives bluescreen > > > -- > Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are the QA contact for the bug. > You are the assignee for the bug. > _______________________________________________ > Ros-bugs mailing list > Ros-bugs(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-bugs >

2 1

Re: [ros-dev] [ros-diffs] [cfinck] 32909: Manually sync "comctl32" and "comdlg32" on request of Apostolos Alexiadis. Just translation updates
by Aleksey 12 Apr '08

12 Apr '08

I thought those are on auto-winesync, aren't they? If you come to agreement with Herve, I don't mind. But anyway, Apostolos should submit those translation updates to Wine project. WBR, Aleksey Bragin. ----- Original Message ----- From: <cfinck(a)svn.reactos.org> To: <ros-diffs(a)reactos.org> Sent: Friday, April 11, 2008 1:00 AM Subject: [ros-diffs] [cfinck] 32909: Manually sync "comctl32" and "comdlg32" on request of Apostolos Alexiadis. Just translation updates > Author: cfinck > Date: Thu Apr 10 16:00:16 2008 > New Revision: 32909 > > URL: http://svn.reactos.org/svn/reactos?rev=32909&view=rev > Log: > Manually sync "comctl32" and "comdlg32" on request of Apostolos Alexiadis. > Just translation updates > > Modified: > trunk/reactos/dll/win32/comctl32/comctl_El.rc > trunk/reactos/dll/win32/comctl32/comctl_Si.rc > trunk/reactos/dll/win32/comdlg32/cdlg_El.rc > trunk/reactos/dll/win32/comdlg32/cdlg_No.rc > trunk/reactos/dll/win32/comdlg32/cdlg_Si.rc

2 2

About ext2 driver installer
by King InuYasha 04 Apr '08

04 Apr '08

I looked at the ReactOS website and noticed that you guys are having problems getting an installer written for an ext2 driver for Windows XP? I would be happy to write an NSIS-based installer for the ext2 driver, if either someone could compile the driver for me, or tell me where the driver is in the ReactOS tree so I can build it myself and create an installer for it. I have written NSIS installers before, some that have advanced functionalities using Component Manager and ExperienceUI. Please let me know if you guys would like me to make this installer....

7 7

win32k public headers
by Timo Kreuzer 03 Apr '08

03 Apr '08

I am currently trying to clean up our win32k headers. The situation so far: - ntgdi.h in psdk which should be compatible to ms version of ntgdi.h from the sdk - ntgdytyp.h containing a bunch of gdi related types in include/reactos/win32k - ntgdihdl.h containing handle related types and macros in include/reactos/win32k - ntgdibad.h containing private and ms incompatible functions and structures in include/reactos/win32k - ntuser.h containing ntuser functions and types in include/reactos/win32k - ntusertyp.h containing ntuser related types in include/reactos/win32k - W32CLIENTINFO is defined in both ntusertyp.h and ntgdityp.h (less complete). - there is the PATRECT structure in ntuser.h, and if ntuser.h is not included, also in ntgdityp.h, this should be named POLYPATBLT as defined in ntgdi.h, but there is only an incomplete type without the structure definition. (IMO ms should have put this structure into wingdi.h together with PolyPatBlt, but they don't seem to want anyone use that gdi32 exported function.) I wonder why ms put ntgdi.h into the sdk at all, as it's completely useless to user mode application writers, but well, ncie to have the prototypes ;-) So how do we clean up this mess? Suggestions: - when ms puts ntgdi.h into the sdk, we could also put ntuser.h there. - if we want to stay 100% compatible with sdk headers, we can add a define, like #ifdef USE_NON_SDK // put non sdk compatible but still windows compatible definitions here #endif - use a version definition, like I did with the simplecall definitions in ntuser.h to make it compatible to different windows versions - keep ntgdibad.h and create ntuserbad.h for incompatible definitions - ntgdihdl.h is used by win32k and gdi32, both also import ntgdityp.h. So I'd suggest merging that stuff into ntgdityp.h - maybe merge types into ntgdi.h and ntuser.h? Some definitions are already in there. - create win32ktypes.h and put ntuser/ntgdi shared stuff there, like W32CLIENTINFO - maybe add POLYPATBLT and PolyPatBlt() (others?) to wingdi.h inside USE_NON_SDK ifdef plus a POLYPATBLT_DEFINED I don't think it's a problem to make our sdk headers more complete than ms ones. This might help if we don't want a header mess or extra definitions inside the .c files. Comments appreciated. Thanks, Timo

2 3

[ros-diffs] [tkreuzer] 32743: - make Simplecall definitions (NtUserCallXxx) compatible to different Win versions
by James Tabor 02 Apr '08

02 Apr '08

Hi! Thank you Timo, I can not believe I missed this one.... This fixes a commit back at rev 14041. With out starting a review in real world history,, once an enemy gains control the first thing they do is erase history. New eras evolve and build on top of old ones. Our old world ruins are a good example. Look at Cuzco, Greece and Rome. You see them now uncovering the past. Thanks again! James

1 0

A question about SepCreateSystemProcessToken
by Xiaoming Gao 24 Mar '08

24 Mar '08

SepCreateSystemProcessToken calls ObCreateObject like this: Status = ObCreateObject(KernelMode, SepTokenObjectType, NULL, KernelMode, NULL, sizeof(TOKEN), 0, 0, (PVOID*)&AccessToken); the ObjectAttributes parameter is set to NULL,and ObCreateObject passes ObjectAttributes to call ObpCaptureObjectAttributes like this: Status = ObpCaptureObjectAttributes(ObjectAttributes, ProbeMode, FALSE, ObjectCreateInfo, &ObjectName); and in ObpCaptureObjectAttributes ,there's a check condition that checks if ObjectAttributes is NULL, if ObjectAttributes is NULL,it will cause ObpCaptureObjectAttributes fail,and then cause ObCreateObject fail,then cause SepCreateSystemProcessToken fail,and the return value of SepCreateSystemProcessToken will ever be NULL. Could someone explain why???am i wrong??

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev