Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [fireball] 32321: - Kernel's entrypoint is called NtProcessStartup right now, for ReactOS. If this is to be changed, it should be changed for all archs, not only for ARM.
by Alex Ionescu 12 Feb '08

12 Feb '08

Actually, I've never heard of the entrypoint being called NtProcessStartup for the kernel... Why not fix the name in the x86 sources? On 12-Feb-08, at 8:34 AM, fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Tue Feb 12 16:34:33 2008 > New Revision: 32321 > > URL: http://svn.reactos.org/svn/reactos?rev=32321&view=rev > Log: > - Kernel's entrypoint is called NtProcessStartup right now, for > ReactOS. If this is to be changed, it should be changed for all > archs, not only for ARM. > > Modified: > trunk/reactos/tools/rbuild/module.cpp > > Modified: trunk/reactos/tools/rbuild/module.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/module.cpp?re… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/rbuild/module.cpp (original) > +++ trunk/reactos/tools/rbuild/module.cpp Tue Feb 12 16:34:33 2008 > @@ -1033,7 +1033,7 @@ > switch ( type ) > { > case Kernel: > - return "KiSystemStartup"; > + return "NtProcessStartup"; > case KernelModeDLL: > case KernelModeDriver: > return "DriverEntry@8"; > > Best regards, Alex Ionescu

1 0

misc.c: LengthOfStrResource, AllocAndLoadString
by Timo Kreuzer 09 Feb '08

09 Feb '08

I wonder why those functions spread around that much (cacls, sndvol, aclui, servman, etc...), since windows has already the needed function: LoadString will store a pointer to the string resource in *lpBuffer, if nBufferMax is set to 0, so allocating additional memory is not neccessary in most cases. And it also returns the full length. http://msdn2.microsoft.com/en-us/library/ms647486(VS.85).aspx > > Author: cfinck > Date: Sat Feb 2 00:40:18 2008 > New Revision: 32079 > > URL: http://svn.reactos.org/svn/reactos?rev=32079&view=rev <http://svn.reactos.org/svn/reactos?rev=32079&view=rev> > Log: > Wrote a Win32 Font Editor for our VGA Fonts used in blue.sys. > > It has a MDI user interface, imports binary fonts (.bin) and PC Screen Fonts (.psf) and exports .bin fonts. > Compiles without any warnings with GCC and MSVC (at /W3). > > The "misc.c" file was taken from devmgmt (thanks Ged!) and modified. > >

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 32215: - Start implement Advanced General page - Update Russian translation
by gedmurphy 08 Feb '08

08 Feb '08

Please stop mixing tchar and unicode. You're creating the potential for a whole host of problems. If you're unsure, ask someone. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dchapyshev(a)svn.reactos.org Sent: 08 February 2008 13:08 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dchapyshev] 32215: - Start implement Advanced General page - Update Russian translation Author: dchapyshev Date: Fri Feb 8 16:07:37 2008 New Revision: 32215 URL: http://svn.reactos.org/svn/reactos?rev=32215&view=rev Log: - Start implement Advanced General page - Update Russian translation

1 0

[ros-diffs] [tkreuzer] 32203: remove obsolete syscalls
by James Tabor 08 Feb '08

08 Feb '08

Hi! Somehow NtUserGetWindowThreadProcessId was moved to the main list. This is wrong! With in the next six months NtUserGetWindowThreadProcessId (unless it was added in Vista) and friends will no longer be in ReactOS. Please do not create more work than it is necessary to accomplish this rewrite. -# ReactOS only system calls -NtUserAcquireOrReleaseInputOwnership 1 -NtUserGetWindowThreadProcessId 2 -NtUserGetQueueStatus 1 Thanks, James

2 1

right way form shared modules
by netzimme＠aim.com 07 Feb '08

07 Feb '08

Hello I want port some function from wine kernel32.dll to ReactOS kernel32.dll but have some problems. First i have two modules and the question is where is the right place to put them. I need /tools/unicode/wctype.c also here /dll/win32/kernel32/misc/ to compile. 1.) Is it better to leave this module in /tools/unicode/ ? -> What must i write in kernel32.rbuild to build this module with kernel32.dll 2.) or copy this file to /dll/win32/kernel32/misc/ the second solution is a bit ugly because we have tow files whit the same contents. 3.) ??? thanks Daniel ________________________________________________________________________ More new features than ever. Check out the new AIM(R) Mail ! - http://webmail.aim.com

3 3

Re: [ros-dev] [ros-diffs] [dchapyshev] 32137: - Add Russian translation - Move application title to resources
by gedmurphy 05 Feb '08

05 Feb '08

dchapyshev(a)svn.reactos.org wrote: > > + LoadString(hInstance, IDS_APPTITLE, szAppName, MAX_STRING); > + > hMainWnd = CreateWindowExW(0, > szMainWndClass, > szAppName, Stick with the current mapping, you've just introduced a potential overflow. Ged.

1 0

Re: [ros-dev] [ros-diffs] [cwittich] 32018: compilerflags can be set for compiler {ALL|CC|CPP} now (ALL is default)
by tamlin＠algonet.se 27 Jan '08

27 Jan '08

Alex wrote: >On 26-Jan-08, at 2:34 PM, Marc Piulachs wrote: > >> Hi, >> >> I'm not very sure about r32018-r32022. >> >> Some compiler warnings are stupid and useless, some others not. > >This one is stupid. Actually, I'd say the stupidity is in using a runtime assert, when a compile-time assert will do the trick (not using CPU at runtime, while enforcing the condition). Unless memory fails me, in C++ you can implement ct_assert(x) like: typedef char[x!=0] foo; as an array of size zero is an error. How does current C compilers react to typedefs of zero-sized arrays? Sure, one can't use it exactly as in C++, but it could still be useful to at least know about this idiom. Problems should be trapped as early as possible. -- Mike

2 1

Re: [ros-dev] [ros-diffs] [cwittich] 32018: compilerflags can be set for compiler {ALL|CC|CPP} now (ALL is default)
by Marc Piulachs 26 Jan '08

26 Jan '08

Hi, I'm not very sure about r32018-r32022. Some compiler warnings are stupid and useless, some others not. I think we should solve the underlying problem when possible. Yes, I know it's easier to say than to do but silent them in an indiscriminate way just because clean builds are cooler is not the solution. Warnings are there for something... Also, we should work to actually remove <compilerflags> and <linkerflags> elements and express that information in a compiler/linker agnostic language now that we want to support at least an additional compiler and linker(MSVC) Regards, /Marc > -----Original Message----- > From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] > On Behalf Of cwittich(a)svn.reactos.org > Sent: Saturday, January 26, 2008 7:28 PM > To: ros-diffs(a)reactos.org > Subject: [ros-diffs] [cwittich] 32018: compilerflags can be set for > compiler {ALL|CC|CPP} now (ALL is default) > > Author: cwittich > Date: Sat Jan 26 21:27:37 2008 > New Revision: 32018 > > URL: http://svn.reactos.org/svn/reactos?rev=32018&view=rev > Log: > compilerflags can be set for compiler {ALL|CC|CPP} now (ALL is default) > > Modified: > trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp > trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp > trunk/reactos/tools/rbuild/backend/mingw/modulehandler.h > trunk/reactos/tools/rbuild/compilerflag.cpp > trunk/reactos/tools/rbuild/rbuild.h > > Modified: trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/ming > w/mingw.cpp?rev=32018&r1=32017&r2=32018&view=diff > ========================================================================== > ==== > --- trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp (original) > +++ trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp Sat Jan 26 21:27:37 > 2008 > @@ -448,10 +448,13 @@ > > for ( i = 0; i < data.compilerFlags.size(); i++ ) > { > - fprintf ( > - fMakefile, > - " %s", > - data.compilerFlags[i]->flag.c_str() ); > + if ( data.compilerFlags[i]->compiler == CompilerTypeDontCare ) > + { > + fprintf ( > + fMakefile, > + " %s", > + data.compilerFlags[i]->flag.c_str() ); > + } > } > > fprintf ( fMakefile, "\n" ); > > Modified: trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/ming > w/modulehandler.cpp?rev=32018&r1=32017&r2=32018&view=diff > ========================================================================== > ==== > --- trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp (original) > +++ trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp Sat Jan 26 > 21:27:37 2008 > @@ -764,15 +764,18 @@ > } > > string > -MingwModuleHandler::GenerateCompilerParametersFromVector ( const > vector<CompilerFlag*>& compilerFlags ) const > +MingwModuleHandler::GenerateCompilerParametersFromVector ( const > vector<CompilerFlag*>& compilerFlags, const CompilerType type ) const > { > string parameters; > for ( size_t i = 0; i < compilerFlags.size (); i++ ) > { > CompilerFlag& compilerFlag = *compilerFlags[i]; > - if ( parameters.length () > 0 ) > - parameters += " "; > - parameters += compilerFlag.flag; > + if ( compilerFlag.compiler == type ) > + { > + if ( parameters.length () > 0 ) > + parameters += " "; > + parameters += compilerFlag.flag; > + } > } > return parameters; > } > @@ -848,7 +851,7 @@ > > if ( generatingCompilerMacro ) > { > - string compilerParameters = > GenerateCompilerParametersFromVector ( data.compilerFlags ); > + string compilerParameters = > GenerateCompilerParametersFromVector ( data.compilerFlags , > CompilerTypeDontCare ); > if ( compilerParameters.size () > 0 ) > { > fprintf ( > @@ -1719,21 +1722,25 @@ > { > const FileLocation& sourceFile = compilationUnit.GetFilename (); > string extension = GetExtension ( sourceFile ); > + string flags = cflagsMacro; > + flags += " "; > if ( extension == ".c" || extension == ".C" ) > { > + flags += GenerateCompilerParametersFromVector ( > module.non_if_data.compilerFlags , CompilerTypeCC ); > GenerateGccCommand ( &sourceFile, > GetCompilationUnitDependencies ( > compilationUnit ) + extraDependencies, > cc, > - cflagsMacro ); > + flags ); > } > else if ( extension == ".cc" || extension == ".CC" || > extension == ".cpp" || extension == ".CPP" || > extension == ".cxx" || extension == ".CXX" ) > { > + flags += GenerateCompilerParametersFromVector ( > module.non_if_data.compilerFlags , CompilerTypeCPP ); > GenerateGccCommand ( &sourceFile, > GetCompilationUnitDependencies ( > compilationUnit ) + extraDependencies, > cppc, > - cflagsMacro ); > + flags ); > } > else if ( extension == ".s" || extension == ".S" ) > { > > Modified: trunk/reactos/tools/rbuild/backend/mingw/modulehandler.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/ming > w/modulehandler.h?rev=32018&r1=32017&r2=32018&view=diff > ========================================================================== > ==== > --- trunk/reactos/tools/rbuild/backend/mingw/modulehandler.h (original) > +++ trunk/reactos/tools/rbuild/backend/mingw/modulehandler.h Sat Jan 26 > 21:27:37 2008 > @@ -130,7 +130,7 @@ > std::string ConcatenatePaths ( const std::string& path1, > const std::string& path2 ) const; > std::string GenerateGccDefineParameters () const; > - std::string GenerateCompilerParametersFromVector ( const > std::vector<CompilerFlag*>& compilerFlags ) const; > + std::string GenerateCompilerParametersFromVector ( const > std::vector<CompilerFlag*>& compilerFlags, const CompilerType type ) > const; > std::string GenerateLinkerParametersFromVector ( const > std::vector<LinkerFlag*>& linkerFlags ) const; > std::string GenerateImportLibraryDependenciesFromVector ( const > std::vector<Library*>& libraries ); > std::string GenerateLinkerParameters () const; > > Modified: trunk/reactos/tools/rbuild/compilerflag.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/compilerflag > .cpp?rev=32018&r1=32017&r2=32018&view=diff > ========================================================================== > ==== > --- trunk/reactos/tools/rbuild/compilerflag.cpp (original) > +++ trunk/reactos/tools/rbuild/compilerflag.cpp Sat Jan 26 21:27:37 2008 > @@ -55,7 +55,25 @@ > node.location, > "<compilerflag> is empty." ); > } > + > flag = node.value; > + compiler = CompilerTypeDontCare; > + > + const XMLAttribute* att = node.GetAttribute ( "compiler", false ); > + if ( att != NULL) > + { > + if ( att->value == "cpp" ) > + compiler = CompilerTypeCPP; > + else if ( att->value == "cc" ) > + compiler = CompilerTypeCC; > + else > + { > + throw InvalidAttributeValueException ( > + node.location, > + "compiler", > + att->value ); > + } > + } > } > > void > > Modified: trunk/reactos/tools/rbuild/rbuild.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/rbuild.h?rev > =32018&r1=32017&r2=32018&view=diff > ========================================================================== > ==== > --- trunk/reactos/tools/rbuild/rbuild.h (original) > +++ trunk/reactos/tools/rbuild/rbuild.h Sat Jan 26 21:27:37 2008 > @@ -309,6 +309,13 @@ > HostDefault, > HostTrue, > HostDontCare, > +}; > + > +enum CompilerType > +{ > + CompilerTypeDontCare, > + CompilerTypeCC, > + CompilerTypeCPP, > }; > > class FileLocation > @@ -592,6 +599,7 @@ > const Module* module; > const XMLElement& node; > std::string flag; > + CompilerType compiler; > > CompilerFlag ( const Project& project, > const XMLElement& compilerFlagNode ); >

4 3

Re: [ros-dev] [ros-diffs] [arty] 32007: Fix termination of process under debug.
by Alex Ionescu 26 Jan '08

26 Jan '08

This is incorrect behavior, the terminate should be instant. This will likely cause bugs in the user-mode debugging framework. On 26-Jan-08, at 4:20 AM, arty(a)svn.reactos.org wrote: > Author: arty > Date: Sat Jan 26 12:20:56 2008 > New Revision: 32007 > > URL: http://svn.reactos.org/svn/reactos?rev=32007&view=rev > Log: > Fix termination of process under debug. > > Modified: > trunk/reactos/ntoskrnl/dbgk/dbgkobj.c > > Modified: trunk/reactos/ntoskrnl/dbgk/dbgkobj.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/dbgk/dbgkobj.c?re… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/dbgk/dbgkobj.c (original) > +++ trunk/reactos/ntoskrnl/dbgk/dbgkobj.c Sat Jan 26 12:20:56 2008 > @@ -1065,6 +1065,17 @@ > > VOID > NTAPI > +DbgkpDelayedTerminateProcess(PVOID Arg) > +{ > + PWORK_QUEUE_ITEM WorkItem = (PWORK_QUEUE_ITEM)Arg; > + PEPROCESS OwnerProcess = *((PEPROCESS *)&WorkItem[1]); > + ExFreePool(WorkItem); > + /* Terminate the process */ > + PsTerminateProcess(OwnerProcess, STATUS_DEBUGGER_INACTIVE); > +} > + > +VOID > +NTAPI > DbgkpCloseObject(IN PEPROCESS OwnerProcess OPTIONAL, > IN PVOID ObjectBody, > IN ACCESS_MASK GrantedAccess, > @@ -1079,6 +1090,8 @@ > DBGKTRACE(DBGK_OBJECT_DEBUG, "OwnerProcess: %p DebugObject: %p\n", > OwnerProcess, DebugObject); > > + DPRINT("APC DISABLE: %d\n", ((PETHREAD)KeGetCurrentThread())- > >Tcb.CombinedApcDisable); > + > /* If this isn't the last handle, do nothing */ > if (SystemHandleCount > 1) return; > > @@ -1127,8 +1140,16 @@ > /* Check if we terminate on exit */ > if (DebugObject->KillProcessOnExit) > { > - /* Terminate the process */ > - PsTerminateProcess(OwnerProcess, > STATUS_DEBUGGER_INACTIVE); > + PWORK_QUEUE_ITEM WorkItem = > + ExAllocatePool > + (NonPagedPool, > + sizeof(WORK_QUEUE_ITEM) + sizeof(PVOID)); > + ExInitializeWorkItem > + (WorkItem, > + DbgkpDelayedTerminateProcess, > + WorkItem); > + *((PEPROCESS *)&WorkItem[1]) = OwnerProcess; > + ExQueueWorkItem(WorkItem, CriticalWorkQueue); > } > > /* Dereference the debug object */ > > Best regards, Alex Ionescu

1 0

Re: [ros-dev] [ros-diffs] [cwittich] 31978: remove statement with no effect
by Alex Ionescu 25 Jan '08

25 Jan '08

Um, this statement is useful. Try to understand compiler warnings, not just obey them :) On 24-Jan-08, at 3:47 PM, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Thu Jan 24 23:47:56 2008 > New Revision: 31978 > > URL: http://svn.reactos.org/svn/reactos?rev=31978&view=rev > Log: > remove statement with no effect > > Modified: > trunk/reactos/dll/win32/kernel32/mem/local.c > > Modified: trunk/reactos/dll/win32/kernel32/mem/local.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/mem/loc… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/dll/win32/kernel32/mem/local.c (original) > +++ trunk/reactos/dll/win32/kernel32/mem/local.c Thu Jan 24 23:47:56 > 2008 > @@ -254,8 +254,6 @@ > NTAPI > LocalLock(HLOCAL hMem) > { > - /* This is the same as a GlobalLock, assuming these never > change */ > - ASSERT(LMEM_LOCKCOUNT == GMEM_LOCKCOUNT); > return GlobalLock(hMem); > } > > >

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev