Ros-dev

ros-dev@reactos.org

5790 discussions

Crash caused by Sysinternals FileMon 7.04 found by Christoph
by James Tabor 12 Jan '08

12 Jan '08

Hi, >From this patch http://svn.reactos.org/svn/reactos?view=rev&revision=30477, I found when WindowObject->Wnd is NULL and WindowObject is not NULL it crashes in vis.c line 89. This patch is okay. My best guess, when Wnd is null that means the window is on the way of removal. Luck of the thread? I can patch and protect the while loops in vis.c but the crash moves to another place based on the same null Wnd problem. Since this crash is started in GetDCEx with a NULL "Window" call leaves me with a bad taste. The code was written prior to having Desktop support, later hax. So having null window associated with DCE is okay then, not now. Any Ideas? Thanks, James

1 0

advapi32 crypt update from wine
by Christoph Brill 08 Jan '08

08 Jan '08

Hi list, attached is a patch to update the crypt-related part of advapi from wine. Hope this patch is useful. It's less intrusive than earlier patches from me. Please use it, Christoph (aka egore on IRC)

3 2

Patch for misc cleanups from Wine
by Christoph Brill 06 Jan '08

06 Jan '08

Hi list, on my way on comparing wine with reactos I found several differences which were cleanups in wine. Attached is a patch to merge over theses changes. Regards, Christoph Brill

2 2

Update shdocvw from wine
by Christoph Brill 06 Jan '08

06 Jan '08

Hi list, I tried to sync shdocvw today. Our version is quite different from what I found in wine. Both seem to have started from a similar point but both got some development done. I'm not sure I'm doing anything correct here, but to outline my changes (and later on the issues): - Import the new "class hierarchie" (ConnectionPointContainer->DocHost->WebBrowser) - stuff like IPersistMemory, IOleCommandTarget, IHlinkFrame, IDispatch, IServiceProvider - URL-History and Navigation (Forward, Backward) Issues: - I commented out regsvr.c because factory.c had similar functions. I'm not sure which one is better, but whichever we choose it should be put in regserv.c and merged back to wine. - DllGetClassObject in shdocvw_main.c commented out in favour of factory.c. Same as above. - I removed "extern const GUID CLSID_InternetShortcut;" from include/psdk/isguids.h. We needed CLSID_InternetShortcut to be static in factory.c. You see: factory.c causes me a major headache. I'll see if I can fix these issues but I really like one with knowledge(!) to look over the patches and at least tell me: Hey, what you are doing is (more or less) right/wrong. Feedback please! Thanks, Christoph Brill

1 0

Patch for msvcrt20
by Christoph Brill 06 Jan '08

06 Jan '08

Hi list, attached is a patch to update msvcrt20 against wine. It changes: - use the .spec file from wine to generate the .def - Add some CDECL's That's it, Christoph Brill

1 0

[PATCH] Sync msiexec againt wine
by Christoph Brill 06 Jan '08

06 Jan '08

Hi list, attached is a patch that updates our msiexec from the wine sources. From what I can tell it has 2 major changes: - option handling is now much more sane (no "if (!xyz)" but "if (xyz)") - addition of argument "/regserver" I also added the icon from wine for msiexec. Not sure if it's ok. Tell me if I should create another (if someone tells me how the icon should look like I would do a better one). Regards, Christoph Brill

1 0

dll/cpl/usrmgr translation status
by Olaf Siejka 05 Jan '08

05 Jan '08

I would like to ask if usrmgr is open for translation. As Eric Kohl left the following message inside en-US.rc: * Attention Translators: * DO NOT TRANSLATE THESE RESOURCES YET! it should be quite evident, its not ready yet. Alas, a russian translation exists, commited by Fireball himself. Regards Olaf Siejka aka Caemyr aka Haos

1 0

bug in vfatfs.sys?
by Oriol 04 Jan '08

04 Jan '08

I get an error while trying to install Firefox 2.0 on a bootcd compilation, finally i found the possibly bug is in vfatfs.sys i modified some lines but is not my code.....it seems to install Firefox. Also, testing firefox i found problems with gdi and also done some modifications, still testing them.. Here is my patch..NO WARRANTY he he..

3 4

Re: [ros-dev] bug in vfatfs.sys?
by Aleksey Bragin 04 Jan '08

04 Jan '08

Basically, Oriol just uncommented your #if0-ed code, and substituted SEH-wrapped pointer operation with a worse "if not null" check. And that's filtering a number of unrelated debug-messages hacks. But, Oriol, you're giving good signs you're improving! :-) The VFAT problem of not clearing the delete pending flag is a good thing (Christoph discovered that, however there are still problems if you clear the flag). With the best regards, Aleksey Bragin. On Jan 4, 2008, at 10:46 AM, James Tabor wrote: > Hi, > I can only write about the gdi code changes. > > 1st dll/win32/gdi32/misc/misc.c looks good! > 2nd the dc.c changes,,, ATM the support code for dirty bit sets is not > inplace, but the patch is good. > > I will apply your patch ASAP for the GDI changes, it does look good. > > Thanks, > James > > On Jan 3, 2008 3:41 PM, Oriol <oripipa(a)yahoo.es> wrote: >> I get an error while trying to install Firefox 2.0 on a bootcd >> compilation, finally i found the possibly bug is in vfatfs.sys i >> modified some lines but is not my code.....it seems to install >> Firefox. >> Also, testing firefox i found problems with gdi and also done some >> modifications, still testing them.. >> Here is my patch..NO WARRANTY he he..

1 0

Re : bug in vfatfs.sys?
by Sylvain Petreolle 04 Jan '08

04 Jan '08

Hi Oriol, now you can send the vfatfs.sys patch ;) Kind regards, Sylvain Petreolle (aka Usurp) Je ne suis pas d'accord avec ce que vous dites, mais je me battrai jusqu'à la mort pour que vous ayez le droit de le dire.I may disagree with what you have to say, but I shall defend, to the death, your right to say it. - VoltaireRun your favorite Windows apps with free ReactOS : http://www.reactos.orgListen to non-DRMised Music: http://www.jamendo.com ----- Message d'origine ---- De : Oriol <oripipa(a)yahoo.es> À : ros-dev(a)reactos.org Envoyé le : Jeudi, 3 Janvier 2008, 22h41mn 57s Objet : [ros-dev] bug in vfatfs.sys? I get an error while trying to install Firefox 2.0 on a bootcd compilation, finally i found the possibly bug is in vfatfs.sys i modified some lines but is not my code.....it seems to install Firefox. Also, testing firefox i found problems with gdi and also done some modifications, still testing them.. Here is my patch..NO WARRANTY he he..

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev