Is this code for human ?
"@@ -81,7 +81,7 @@
* if they forget set it, the ddraw will autoamtic
* set it for system memory.
*/
- if ((pDDSD->dwFlags & DDSCAPS_SYSTEMMEMORY) != DDSCAPS_SYSTEMMEMORY)
+ if ((pDDSD->ddsCaps.dwCaps & DDSCAPS_SYSTEMMEMORY) ==
DDSCAPS_SYSTEMMEMORY)
{
pDDSD->dwFlags = pDDSD->dwFlags | DDSD_LPSURFACE;
}"
On Dec 16, 2007 1:46 AM, <greatlrd(a)svn.reactos.org> wrote:
> Author: greatlrd
> Date: Sun Dec 16 03:46:43 2007
> New Revision: 31268
>
> URL: http://svn.reactos.org/svn/reactos?rev=31268&view=rev
> Log:
> fix a typo
>
> Modified:
> trunk/reactos/dll/directx/ddraw/Surface/createsurface.c
>
> Modified: trunk/reactos/dll/directx/ddraw/Surface/createsurface.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/ddraw/Surface/…
>
> ==============================================================================
> --- trunk/reactos/dll/directx/ddraw/Surface/createsurface.c (original)
> +++ trunk/reactos/dll/directx/ddraw/Surface/createsurface.c Sun Dec 16
> 03:46:43 2007
> @@ -81,7 +81,7 @@
> * if they forget set it, the ddraw will autoamtic
> * set it for system memory.
> */
> - if ((pDDSD->dwFlags & DDSCAPS_SYSTEMMEMORY) != DDSCAPS_SYSTEMMEMORY)
> + if ((pDDSD->ddsCaps.dwCaps & DDSCAPS_SYSTEMMEMORY) ==
> DDSCAPS_SYSTEMMEMORY)
> {
> pDDSD->dwFlags = pDDSD->dwFlags | DDSD_LPSURFACE;
> }
>
>
>
--
MVH
Simon Blomqvist
Tel - 0735307474
IT www.AgentEyes.com
Internet Café www.cafe.agenteyes.com
Konst www.konstgrossisten.com/
Jag ringer gratis med www.skype.se mitt id är: simonblomqvist
Hi!
Let us start on this now.... It is time to restructure the GDI OBJ
Lock Unlock mess! Don't wait for me.
I'm working on the DCE issue which is a mess due to gdiobj.c over
think object locking system. The new
ideas I have will not be compatible with the current system.
Thanks,
James
Hi!
Sorry for the delay here,,,
This is what we know to be correct sofar. The "Book" section 3.4
GdiTableCell structure is not necessarily correct.
typedef struct _GDI_TABLE_ENTRY
{
PVOID KernelData;
SHORT Count:15; Count number of refs.
SHORT Lock:1; Does set if locked by process. It also
explains why the count shows 1 -> 3 most of the time.
SHORT ProcessId; Process Id is here.
SHORT nUpper; should match the upper half of the handle.
CHAR ObjectType; example-> 0x0401, // not all memdc, dc =1, etc,,,
CHAR Flags; --> 0x04 is here, set if memdc, sometimes~.
PVOID UserData;
} GDI_TABLE_ENTRY, *PGDI_TABLE_ENTRY;
Thanks,
James
why waste the last handle?
> author: jimtabor
> Date: Thu Dec 13 23:27:28 2007
> New Revision: 31204
> - for ( i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT; i++ )
> + for ( i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT-1; i++
> - if (HandleIndex >= GDI_HANDLE_COUNT)
> + if (HandleIndex >= GDI_HANDLE_COUNT-1)
On Dec 12, 2007 7:08 AM, <hpoussin(a)svn.reactos.org> wrote:
> Author: hpoussin
> Date: Wed Dec 12 15:08:11 2007
> New Revision: 31182
> - * Copyright (C) 2002, 2003, 2004 ReactOS Team
> + * Copyright (C) ReactOS Team
A proper copyright header needs to show all of the years like
* Copyright (C) 2002-2004,2007 ReactOS Team
Thanks
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
dchapyshev(a)svn.reactos.org wrote:
> Author: dchapyshev
> Date: Thu Dec 6 22:49:12 2007
> New Revision: 31048
> URL: http://svn.reactos.org/svn/reactos?rev=31048&view=rev
> Log:
> - Move all hardcode strings to resource
This isn't actually used. It should be deleted.
Ged.