Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

[ros-diffs] [jimtabor] 31174: A partial implementation of NtGdiCreate/DeleteClientObj.
by Timo Kreuzer 13 Dec '07

13 Dec '07

You probably meant GDI_OBJECT_TYPE_CLIOBJ > Author: jimtabor > Date: Wed Dec 12 05:29:21 2007 > New Revision: 31174 > > > + HANDLE handle = GDIOBJ_AllocObj(GdiHandleTable, GDI_OBJECT_TAG_CLIOBJ); > + return GDIOBJ_FreeObj(GdiHandleTable, h, GDI_OBJECT_TAG_CLIOBJ); >

2 1

Re: [ros-dev] [ros-diffs] [hpoussin] 31182: Remove useless test
by Steven Edwards 12 Dec '07

12 Dec '07

On Dec 12, 2007 7:08 AM, <hpoussin(a)svn.reactos.org> wrote: > Author: hpoussin > Date: Wed Dec 12 15:08:11 2007 > New Revision: 31182 > - * Copyright (C) 2002, 2003, 2004 ReactOS Team > + * Copyright (C) ReactOS Team A proper copyright header needs to show all of the years like * Copyright (C) 2002-2004,2007 ReactOS Team Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 31048: - Move all hardcode strings to resource
by Ged Murphy 06 Dec '07

06 Dec '07

dchapyshev(a)svn.reactos.org wrote: > Author: dchapyshev > Date: Thu Dec 6 22:49:12 2007 > New Revision: 31048 > URL: http://svn.reactos.org/svn/reactos?rev=31048&view=rev > Log: > - Move all hardcode strings to resource This isn't actually used. It should be deleted. Ged.

1 0

Re: [ros-dev] [ros-diffs] [fireball] 31043: - Fix Greatlordisms: * Don't try to link *user*mode program to static *kernelmode* libcntpr. msvcrt.dll exists for this. * Fix main()'s declaration and definition. * The above changes fix compiling of rostest module.
by Alex Ionescu 06 Dec '07

06 Dec '07

Something is wrong with your development process if you believe libcntpr is a "kernel-mode" library. I always compile my native programs with it on Windows -- in fact so should ntdll in ReactOS. If it doesn't you may want to check your brains before bashing Greatlord... including msvcrt in a native program is a sure recipe for disaster... -- Best regards, Alex Ionescu On 6-Dec-07, at 10:44 AM, fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Thu Dec 6 18:44:23 2007 > New Revision: 31043 > > URL: http://svn.reactos.org/svn/reactos?rev=31043&view=rev > Log: > - Fix Greatlordisms: > * Don't try to link *user*mode program to static *kernelmode* > libcntpr. msvcrt.dll exists for this. > * Fix main()'s declaration and definition. > * The above changes fix compiling of rostest module. > > Modified: > trunk/rostests/tests/D3DParseUnknownCommand_show/ > D3DParseUnknownCommand_show.rbuild > trunk/rostests/tests/D3DParseUnknownCommand_show/main.c > > Modified: trunk/rostests/tests/D3DParseUnknownCommand_show/ > D3DParseUnknownCommand_show.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/tests/ > D3DParseUnknownCommand_show/D3DParseUnknownCommand_show.rbuild? > rev=31043&r1=31042&r2=31043&view=diff > ====================================================================== > ======== > --- trunk/rostests/tests/D3DParseUnknownCommand_show/ > D3DParseUnknownCommand_show.rbuild (original) > +++ trunk/rostests/tests/D3DParseUnknownCommand_show/ > D3DParseUnknownCommand_show.rbuild Thu Dec 6 18:44:23 2007 > @@ -5,7 +5,6 @@ > <library>kernel32</library> > <library>gdi32</library> > <library>ddraw</library> > - <library>libcntpr</library> > <library>user32</library> > <file>main.c</file> > </module> > > Modified: trunk/rostests/tests/D3DParseUnknownCommand_show/main.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/tests/ > D3DParseUnknownCommand_show/main.c? > rev=31043&r1=31042&r2=31043&view=diff > ====================================================================== > ======== > --- trunk/rostests/tests/D3DParseUnknownCommand_show/main.c (original) > +++ trunk/rostests/tests/D3DParseUnknownCommand_show/main.c Thu > Dec 6 18:44:23 2007 > @@ -22,10 +22,10 @@ > * > */ > > -INT main(INT argc, CHAR argv[]); > +INT main(INT argc, TCHAR *argv[]); > VOID BuildReturnCode(DWORD * ReturnCode); > > -INT main(INT argc, TCHAR argv[]) > +INT main(INT argc, TCHAR *argv[]) > { > DWORD ReturnCode[256]; > > @@ -44,6 +44,6 @@ > { > dp2command.bCommand = t; > ReturnCode[t] = D3DParseUnknownCommand ( (LPVOID) > &dp2command, (LPVOID *) lplpvReturnedCommand) ; > - printf("D3DParseUnknownCommand return code = %x command %d > \n", ReturnCode[t], t); > + printf("D3DParseUnknownCommand return code = %x command %d > \n", (UINT)ReturnCode[t], t); > } > } > >

1 0

Re: [ros-dev] [ros-diffs] [fireball] 31019: - Fix a bug.
by Ged Murphy 05 Dec '07

05 Dec '07

fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Wed Dec 5 22:07:23 2007 > New Revision: 31019 > > URL: http://svn.reactos.org/svn/reactos?rev=31019&view=rev > Log: > - Fix a bug. janderwald??

1 0

Re: [ros-dev] Autogenerating compiler specific .def files
by Aleksey Bragin 03 Dec '07

03 Dec '07

Marc, I think I haven't been very clear on this. What I mean, is that the .spec format already includes *everything* needed to produce either gcc or msvc-format .def file. So no point in creating yet another format. Nothing more nothing less, that's what I ment. I'm glad to hear disadvantages of that way. WBR, Aleksey Bragin. On Nov 24, 2007, at 7:01 PM, Marc Piulachs wrote: > >> There is absolutely no need to invent yet another format for storing >> export functions. It was invented once by MSVC, it was invented by >> GCC/MinGW, both are incompatible, it was invented by Wine to have >> ability of easy functions stubbing. Should there be another invention >> of the same wheel by ReactOS now? > >> If GCC/MinGW wouldn't be that *strange*, it could stdcall-fixup, and >> then properly link, this way .def could be created in the lowest >> common denominator format. > > That's the problem I'm trying to solve..:) The point on this change > is not > really store them in xml inset of plain text, is not that > important, for me > there are two reasons, first declare this information so rbuild can > manipulate it as objects and apply checking , logic , whatever ... > and the > most important store the information on a neutral , compiler > agnostic and > rich format that allow us to generate (export to) ANY format we > desire out > of it. Currently def files are tided to mingw which is bad. > > At the end the information must be there so what's the difference > between > having it in a file with extension .def or .spec and having it on a > file > with .rbuild extension? IMO It's not reinventing the wheel > > /Marc

6 5

Build is broken as of Eric's change in r30958
by Colin Finck 02 Dec '07

02 Dec '07

Hello, As I don't know how to contact Eric, I post this on the mailing list now: With the change in r30958, the build is broken (at least for the BuildBot, see http://reactos.org:8010/ReactOS_%28Debug%29/builds/5979/step-shell_2/0). LD misses the "NetUserSetInfo" function. I looked into dll/win32/netapi32/netapi32.spec and it's declared there, but only as a stub. Don't know how to properly fix this now. Maybe it requires a real implementation of this function. Regards, Colin

2 2

Re: [ros-dev] [ros-diffs] [tkreuzer] 30929: patch by jimtabor: add GdiBCSelObj to GdiFlushUserBatch
by Aleksey Bragin 01 Dec '07

01 Dec '07

> + if(!dc) break; This additional check is not needed, because dc is checked at the beginning of the function now. WBR, Aleksey Bragin. On Dec 1, 2007, at 5:09 AM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Sat Dec 1 05:09:39 2007 > New Revision: 30929 > > URL: http://svn.reactos.org/svn/reactos?rev=30929&view=rev > Log: > patch by jimtabor: add GdiBCSelObj to GdiFlushUserBatch > > Modified: > trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > > Modified: trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ > win32/win32k/objects/gdibatch.c?rev=30929&r1=30928&r2=30929&view=diff > ====================================================================== > ======== > --- trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c Sat > Dec 1 05:09:39 2007 > @@ -49,7 +49,13 @@ > case GdiBCExtSelClipRgn: > break; > case GdiBCSelObj: > - break; > + { > + PGDIBSOBJECT pgO; > + if(!dc) break; > + pgO = (PGDIBSOBJECT) pHdr; > + if(NT_SUCCESS(TextIntRealizeFont((HFONT) pgO->hgdiobj))) > + Dc_Attr->hlfntNew = (HFONT) pgO->hgdiobj; > + } > case GdiBCDelObj: > case GdiBCDelRgn: > { > @@ -115,3 +121,4 @@ > return STATUS_SUCCESS; > } > > + > >

2 1

ros-diffs] [cwittich] 30916: revert r28932
by James Tabor 30 Nov '07

30 Nov '07

Hi! That is why I hate CONTAINING_RECORD! It is so cheesy! Thanks Christoph, James

1 0

Re: [ros-dev] [ros-diffs] [cwittich] 30899: remove the const from the DrawShadowText function to be compatible to PSDK
by Steven Edwards 30 Nov '07

30 Nov '07

On Nov 29, 2007 11:04 AM, <cwittich(a)svn.reactos.org> wrote: > Author: cwittich > Date: Thu Nov 29 19:04:38 2007 > New Revision: 30899 > > URL: http://svn.reactos.org/svn/reactos?rev=30899&view=rev > Log: > remove the const from the DrawShadowText function to be compatible to PSDK Please send this on to winehq. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev