Maybe let's postpone mc translations to further releases (like 0.4)?
WBR,
Aleksey Bragin.
On Dec 24, 2007, at 5:21 AM, Timo Kreuzer wrote:
> I have just compiled kernel32 with 2 different .mcs in the rbuild file
> and it compiles without problems.
> The resources shown by PE explorer were as expected the German ones
> (2nd
> mc file)
> It also created 2 headers.
> A slight change to the rbuild syntax could fix that problem:
>
> <file locale="en-US">lang/errcodes-en-US.mc</file>
> <file locale="de-DE">lang/errcodes-de-DE.mc</file>
> <mcheader target="include/psdk/errcodes.h>msg-en-US.mc</file>
>
> I had to manually add the #include to the rc file. This job should
> also
> be done by rbuild.
> rbuild should create the rsrc.rc in the intermediate dir and
> include all
> locaized rcs and precompiled mcs for the languages
> that are to be compiled. IIRC this feature is already in the rbuild
> branch.
>
> Greeting,
> Timo
I have just compiled kernel32 with 2 different .mcs in the rbuild file
and it compiles without problems.
The resources shown by PE explorer were as expected the German ones (2nd
mc file)
It also created 2 headers.
A slight change to the rbuild syntax could fix that problem:
<file locale="en-US">lang/errcodes-en-US.mc</file>
<file locale="de-DE">lang/errcodes-de-DE.mc</file>
<mcheader target="include/psdk/errcodes.h>msg-en-US.mc</file>
I had to manually add the #include to the rc file. This job should also
be done by rbuild.
rbuild should create the rsrc.rc in the intermediate dir and include all
locaized rcs and precompiled mcs for the languages
that are to be compiled. IIRC this feature is already in the rbuild branch.
Greeting,
Timo
Hello everybody,
For your information, I finished a new version of RosBE-Unix. To be on the
safe side, I marked it as a BETA version, so you still have time to try it
out :-)
You can get the BETA version of RosBE-Unix 1.1 from
http://reactos.colinfinck.de.
The major changes are updated compilers (they are exactly the same as in
RosBE-Windows 1.1 now) and several bug fixes.
A complete list of changes is available here:
http://www.reactos.org/forum/viewtopic.php?p=39179#39179.
Please try it out and report bugs if you find some.
Best regards,
Colin Finck
On Dec 21, 2007 5:26 AM, <hpoussin(a)svn.reactos.org> wrote:
> Author: hpoussin
> Date: Fri Dec 21 13:26:41 2007
> New Revision: 31369
>
> URL: http://svn.reactos.org/svn/reactos?rev=31369&view=rev
> Log:
> No need to compile libxml2, as it is not used
It should be. If you change the config.h for the wine modules and add
an include path so that msi and msxml can find the libxml2 public
headers and compile I bet Office 2003 and friends will install on
ReactOS.
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
Generic behavior is to
1) use .spec for DLLs (because usually DLLs are shared with Wine,
which uses the same format), but for msvcrt it was not possible.
2) implement a stub as soon as possible whenever it is hit
WBR,
Aleksey Bragin.
On Dec 19, 2007, at 4:20 PM, Sylvain Petreolle wrote:
> Could these stubs be added to other dlls too ?
>
> For example, audiosrv crashes is being killed by EXCEPTION_WINE_STUB,
> because setupapi misses the CMP_RegisterNotification function.
>
> Kind regards,
> Sylvain Petreolle (aka Usurp)
Could these stubs be added to other dlls too ?
For example, audiosrv crashes is being killed by EXCEPTION_WINE_STUB,
because setupapi misses the CMP_RegisterNotification function.
Kind regards,
Sylvain Petreolle (aka Usurp)
Je ne suis pas d'accord avec ce que vous dites, mais je me battrai jusqu'à la mort pour que vous ayez le droit de le dire.I may disagree with what you have to say, but I shall defend, to the death, your right to say it. - VoltaireRun your favorite Windows apps with free ReactOS : http://www.reactos.orgListen to non-DRMised Music: http://www.jamendo.com
On Dec 18, 2007 6:03 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
> I merged it, taking in account winebuild's changes (using output()
> function for example), so in 31300 it seems to work correctly.
>
> I didn't really understood that AJ's message - Wine does not need
> stubs as stubbed functions at all, but rather want all of them to be
> manually implemented in a standalone .c file as stubs? or?
As we discused on IRC he wants to do away with pseudo-stubs or at
least does not think they should be used in a PE build. I tend to
agree a function should either be implemented, fully stubbed or not
there at all unless an application is proven to need it. Needless
stubbing results in breakage when an application calls
GetProcAddress/LoadLibrary and would normally fail with grace if the
function is not there. Instead it can hit one of these fake stubs,
assume its safe to keep working and blow up on you.
As for your other question about decoration in mangled symbols for
stdcall functions I am not quite sure I understand it. The only
decorated functions I saw in the spec file were all cdecl. There were
others that are exported variables and some stdcall functions but they
did not have decoration unless I just missed it.
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
I merged it, taking in account winebuild's changes (using output()
function for example), so in 31300 it seems to work correctly.
I didn't really understood that AJ's message - Wine does not need
stubs as stubbed functions at all, but rather want all of them to be
manually implemented in a standalone .c file as stubs? or?
WBR,
Aleksey Bragin.
On Dec 18, 2007, at 5:11 AM, Steven Edwards wrote:
> On Dec 17, 2007 6:36 PM, <cfinck(a)svn.reactos.org> wrote:
>> Every change I try for fixing the build in one component breaks
>> the build for another component.
>> winebuild wasn't synchronized completely to the Wine version
>> anyway, and the current Wine version removed support for the --
>> pedll option we use, so a full clean sync isn't possible.
>
> Can you merge the --pedll patch up to the trunk rather than reverting?
> You might want to comment out the stubs anyway or add real stubs and
> submit them to wine as per Alexandre's rejection of the patch by GvG
>
> http://www.winehq.org/pipermail/wine-devel/2004-December/031978.html
>
> Thanks
> --
> Steven Edwards
>
> "There is one thing stronger than all the armies in the world, and
> that is an idea whose time has come." - Victor Hugo
On Dec 17, 2007 6:36 PM, <cfinck(a)svn.reactos.org> wrote:
> Every change I try for fixing the build in one component breaks the build for another component.
> winebuild wasn't synchronized completely to the Wine version anyway, and the current Wine version removed support for the --pedll option we use, so a full clean sync isn't possible.
Can you merge the --pedll patch up to the trunk rather than reverting?
You might want to comment out the stubs anyway or add real stubs and
submit them to wine as per Alexandre's rejection of the patch by GvG
http://www.winehq.org/pipermail/wine-devel/2004-December/031978.html
Thanks
--
Steven Edwards
"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
On Dec 16, 2007, at 4:10 PM, Marc Piulachs wrote:
> Hi Alex,
>
> Let me see if I understood this correctly. The problem is not
> really on
> manually choosing the base address, the problem is that module's
> "baseaddress" attribute is optional, even when the module is of type
> "win32dll", if this attribute is empty rbuild sets a common default
> base
> address (0x10000000 for win32 dll's).
No, the problem is exactly choosing the address: modules overlap with
each other, and manually calculating baseaddresses often doesn't
work. Alex proposed to automate this process and do a
baseaddress.rbuild file generator.
There are not many dlls with baseaddress missing, and if it's
missing, it should be added to those (in trunk).
> AFAIK we are using the same base address that the equivalent
> component has
> on windows so auto generating it using any sort of tool is not
> really an
> option.
Not really, in most cases (might be with a few exceptions), it's not
possible to use exactly Windows' base address (because size of our
modules and windows modules often differs). The problem is to
distribute the dlls in the memory address space so that they don't
overlap.
As for baseaddress in xml form - baseaddress is a module's property,
it's not a standalone object which is part of the module. I don't see
why it should be given a standalone tag (maybe I'm missing something).
WBR,
Aleksey Bragin.