Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-dev] [ros-diffs] [cwittich] 30829: translated some DPRINTs from GreatLordish into a human readable format
by Ged Murphy 28 Nov '07

28 Nov '07

Cwittich wrote: > - DPRINT1("Warring no dxg.sys in ReactOS"); > + DPRINT1("Warning: dxg.sys not found\n"); The 'warring' returns, lmao, brilliant :)

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 30807: Revert 30780 for gdibatch. Size, space and time are very critical in here. If you dont know what your are doing? Do not play in here.
by Aleksey Bragin 27 Nov '07

27 Nov '07

How come size, space and time matter in this particular case of where the variable is declared (it's still defined in the stack, wherever you write it)? In the kernel, there is a rule to allocate all variables at top of the function (not in subsequent {} blocks). It should be extended to win32k too, it's cleaner, gives the developer an overview of all vars used in the function, and prevents possible cases of defining vars with the same name both atop of the function and in some subsequent block of code. Not to mention this is not fully correct to do in a C language. With the best regards, Aleksey Bragin. On Nov 27, 2007, at 4:14 AM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Tue Nov 27 04:14:38 2007 > New Revision: 30807 > > URL: http://svn.reactos.org/svn/reactos?rev=30807&view=rev > Log: > Revert 30780 for gdibatch. Size, space and time are very critical > in here. If you dont know what your are doing? Do not play in here. > > Modified: > trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > > Modified: trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ > win32/win32k/objects/gdibatch.c?rev=30807&r1=30806&r2=30807&view=diff > ====================================================================== > ======== > --- trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c > (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c Tue > Nov 27 04:14:38 2007 > @@ -20,7 +20,6 @@ > { > PDC dc = NULL; > PDC_ATTR Dc_Attr = NULL; > - PGDIBSSETBRHORG pgSBO; > if (hDC) > { > dc = DC_LockDc(hDC); > @@ -40,6 +39,7 @@ > break; > case GdiBCSetBrushOrg: > { > + PGDIBSSETBRHORG pgSBO; > if (!dc) break; > pgSBO = (PGDIBSSETBRHORG) pHdr; > Dc_Attr->ptlBrushOrigin = pgSBO->ptlBrushOrigin; > >

2 1

Paste service
by Sylvain Petreolle 27 Nov '07

27 Nov '07

Looking at bug #933 in bugzilla, I see the following paste : http://www.reactos.org/paste/index.php/37693cf/ It has been posted on november 14th and set to expire after 7 days. Today is november 27, therefore this paste should have expired. Kind regards, Sylvain Petreolle (aka Usurp) Je ne suis pas d'accord avec ce que vous dites, mais je me battrai jusqu'à la mort pour que vous ayez le droit de le dire. I may disagree with what you have to say, but I shall defend, to the death, your right to say it. - Voltaire Run your favorite Windows apps with free ReactOS : http://www.reactos.org Listen to non-DRMised Music: http://www.jamendo.com

2 1

Re: [ros-dev] Autogenerating compiler specific .def files
by Aleksey Bragin 24 Nov '07

24 Nov '07

Theoretically extending this logic to infinity will lead to creation of a new high level language, stored in xml documents, parsing which rbuild generates source code in C or other language needed. :-). The thing is, .def is rather simple, .spec is a bit more advanced to include more stuff ("stub", what else does reactos use from it?). There is absolutely no need to invent yet another format for storing export functions. It was invented once by MSVC, it was invented by GCC/MinGW, both are incompatible, it was invented by Wine to have ability of easy functions stubbing. Should there be another invention of the same wheel by ReactOS now? If GCC/MinGW wouldn't be that *strange*, it could stdcall-fixup, and then properly link, this way .def could be created in the lowest common denominator format. With the best regards, Aleksey Bragin. On Nov 24, 2007, at 4:36 PM, Marc Piulachs wrote: > I wouldn't use .spec files for several reasons, first of all is > that it > violates the way how rbuild currently works. Rbuild reads xml > documents in a > custom format and produce different outputs depending on various > conditions. > IMO rbuild shouldn't be extended to parse anything else but > just .rbuild > files. > > Also, winebuild from the rbuild point of view is not different from > any > other compiler , so I think the problem is just the opposite , > rbuild should > use the information stored in it's rbuild file to produce the spec > file in > addition to the specific def file (it shouldn't be produced by > winebuild > anymore) as both files are required to compile wine module XYZ. > > Having the information in rbuild files has also other advantages, > the most > important is that it would allow us to use the conditional logic to > export > functions based on a given condition, for example hacks like > /lib/debugsup.rbuild won't be necessary anymore. > > I wouldn't fork winebuild. > > Regards, > Marc

4 8

Autogenerating compiler specific .def files
by Marc Piulachs 24 Nov '07

24 Nov '07

Hi All, I have lately seen a big effort to make more modules compilable under Visual C , one of our current problems when building dlls is that our .def files are mingw/gcc specific not directly compatible with msvc or any other future compiler we may support. Currently we are using not very elegant solutions to archive compatibility with msvc like stripping some information from mingw def files. As Alex suggested I think it's a good idea to move that information to rbuild files and let rbuild generate full compatible compiler def files in the intermediate folder. The advantages are obvious. As I have little experience with mingw def files I would like to request some help from other developers to evaluate/validate my proposal. >From my research on the ros codebase I have found that possible variations: - CcRosInitializeFileCache@8 - FsRtlGetFileSize - @HalExamineMBR@16 - PsChargeProcessNonPagedPoolQuota@4=PsDereferenceImpersonationToken@4 - ConvertSecurityDescriptorToAccessNamedA=ConvertSecurityDescriptorToAccessA@2 8 - GetSecurityDescriptorLength(a)4=NTDLL.RtlLengthSecurityDescriptor - ??1type_info@@UAE@XZ=__thiscall_MSVCRT_type_info_dtor @15 - ChkdskEx=VfatChkdsk@24 My proposed syntax is as following and it should support all of the above cases: <exportfunction name="CcRosInitializeFileCache" ordinal="8" /> (required) (optional) <exportfunction name="CcRosInitializeFileCache" ordinal="8" mappedname="PsDereferenceImpersonationToken" mappedordinal="4"/> (required) (optional) (optional) (optional) <exportfunction name="GetSecurityDescriptorLength" ordinal="4" mappedname="RtlLengthSecurityDescriptor" mappedordinal="4" module="ntdll"/> (required) (optional) (optional) (optional) (optional) With this information rbuild will generate a modulename_gcc.def when you type "make" and modulename_msvc.def on the intermediate folder when you type "make msvc". Opinions, comments? Regards, Marc

3 3

Re: [ros-dev] Autogenerating compiler specific .def files
by Aleksey Bragin 24 Nov '07

24 Nov '07

Hi, why can't .spec be used for this purpose (extended to support msvc files generation)? They are going to stay anyway for wine-shared modules. With the best regards, Aleksey Bragin. On Nov 24, 2007, at 3:04 AM, Marc Piulachs wrote: > Hi All, > > > > I have lately seen a big effort to make more modules compilable > under Visual C , one of our current problems when building dlls is > that our .def files are mingw/gcc specific not directly compatible > with msvc or any other future compiler we may support. Currently we > are using not very elegant solutions to archive compatibility with > msvc like stripping some information from mingw def files. As Alex > suggested I think it’s a good idea to move that information to > rbuild files and let rbuild generate full compatible compiler def > files in the intermediate folder. The advantages are obvious. > > > > As I have little experience with mingw def files I would like to > request some help from other developers to evaluate/validate my > proposal. > > > > From my research on the ros codebase I have found that possible > variations:

3 2

Re: [ros-dev] [ros-diffs] [cwittich] 30460: sync CryptAcquireContext to wine (this fixes some Unicode issues)
by Alex Ionescu 23 Nov '07

23 Nov '07

"HCRYPTHASH hPrivate; /*CSP's handle - Should not be given to application under any circumstances!*/" Are Wine people aware that DLLs load in the same address space as applications? There is no way to protect this handle from the application unless you store it in kernel-mode. On Nov 15, 2007 9:08 AM, <cwittich(a)svn.reactos.org> wrote: > Author: cwittich > Date: Thu Nov 15 17:08:18 2007 > New Revision: 30460 > > URL: http://svn.reactos.org/svn/reactos?rev=30460&view=rev > Log: > sync CryptAcquireContext to wine (this fixes some Unicode issues) > > Modified: > trunk/reactos/dll/win32/advapi32/crypt/crypt.c > trunk/reactos/dll/win32/advapi32/crypt/crypt.h > > Modified: trunk/reactos/dll/win32/advapi32/crypt/crypt.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/crypt/c… > > ============================================================================== > --- trunk/reactos/dll/win32/advapi32/crypt/crypt.c (original) > +++ trunk/reactos/dll/win32/advapi32/crypt/crypt.c Thu Nov 15 17:08:18 > 2007 > @@ -55,45 +55,56 @@ > #define CRYPT_Alloc(size) ((LPVOID)LocalAlloc(LMEM_ZEROINIT, size)) > #define CRYPT_Free(buffer) (LocalFree((HLOCAL)buffer)) > > -static inline PSTR CRYPT_GetProvKeyName(PCSTR pProvName) > -{ > - PCSTR KEYSTR = > "Software\\Microsoft\\Cryptography\\Defaults\\Provider\\"; > - PSTR keyname; > - > - keyname = CRYPT_Alloc(strlen(KEYSTR) + strlen(pProvName) +1); > +static inline PWSTR CRYPT_GetProvKeyName(PCWSTR pProvName) > +{ > + static const WCHAR KEYSTR[] = { > + 'S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\', > + 'C','r','y','p','t','o','g','r','a','p','h','y','\\', > + 'D','e','f','a','u','l','t','s','\\', > + 'P','r','o','v','i','d','e','r','\\',0 > + }; > + PWSTR keyname; > + > + keyname = CRYPT_Alloc((wcslen(KEYSTR) + wcslen(pProvName) > +1)*sizeof(WCHAR)); > if (keyname) > { > - strcpy(keyname, KEYSTR); > - strcpy(keyname + strlen(KEYSTR), pProvName); > - } > - else > - { > + wcscpy(keyname, KEYSTR); > + wcscpy(keyname + wcslen(KEYSTR), pProvName); > + } else > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - } > - > return keyname; > } > > -static inline PSTR CRYPT_GetTypeKeyName(DWORD dwType, BOOL user) > -{ > - PCSTR MACHINESTR = > "Software\\Microsoft\\Cryptography\\Defaults\\Provider Types\\Type XXX"; > - PCSTR USERSTR = "Software\\Microsoft\\Cryptography\\Provider Type > XXX"; > - PSTR keyname; > - PSTR ptr; > - > - keyname = CRYPT_Alloc( (user ? strlen(USERSTR) : > strlen(MACHINESTR)) +1); > +static inline PWSTR CRYPT_GetTypeKeyName(DWORD dwType, BOOL user) > +{ > + static const WCHAR MACHINESTR[] = { > + 'S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\', > + 'C','r','y','p','t','o','g','r','a','p','h','y','\\', > + 'D','e','f','a','u','l','t','s','\\', > + 'P','r','o','v','i','d','e','r',' > ','T','y','p','e','s','\\', > + 'T','y','p','e',' ','X','X','X',0 > + }; > + static const WCHAR USERSTR[] = { > + 'S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\', > + 'C','r','y','p','t','o','g','r','a','p','h','y','\\', > + 'P','r','o','v','i','d','e','r',' ','T','y','p','e',' > ','X','X','X',0 > + }; > + PWSTR keyname; > + PWSTR ptr; > + > + keyname = CRYPT_Alloc( ((user ? wcslen(USERSTR) : > wcslen(MACHINESTR)) +1)*sizeof(WCHAR)); > if (keyname) > { > - user ? strcpy(keyname, USERSTR) : strcpy(keyname, > MACHINESTR); > - ptr = keyname + strlen(keyname); > + user ? wcscpy(keyname, USERSTR) : wcscpy(keyname, > MACHINESTR); > + ptr = keyname + wcslen(keyname); > *(--ptr) = (dwType % 10) + '0'; > *(--ptr) = ((dwType / 10) % 10) + '0'; > *(--ptr) = (dwType / 100) + '0'; > - } > - else > - { > + } else > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - } > return keyname; > } > > @@ -178,26 +189,23 @@ > > #define CRYPT_GetProvFunc(name) \ > if ( !(provider->pFuncs->p##name = > (void*)GetProcAddress(provider->hModule, #name)) ) goto error > - > #define CRYPT_GetProvFuncOpt(name) \ > provider->pFuncs->p##name = > (void*)GetProcAddress(provider->hModule, #name) > -PCRYPTPROV CRYPT_LoadProvider(PSTR pImage) > +static PCRYPTPROV CRYPT_LoadProvider(PCWSTR pImage) > { > PCRYPTPROV provider; > DWORD errorcode = ERROR_NOT_ENOUGH_MEMORY; > > - if (!(provider = CRYPT_Alloc(sizeof(CRYPTPROV)))) > + if ( !(provider = CRYPT_Alloc(sizeof(CRYPTPROV))) ) goto error; > + if ( !(provider->pFuncs = CRYPT_Alloc(sizeof(PROVFUNCS))) ) goto > error; > + if ( !(provider->pVTable = CRYPT_Alloc(sizeof(VTableProvStruc))) ) > goto error; > + if ( !(provider->hModule = LoadLibraryW(pImage)) ) > + { > + errorcode = (GetLastError() == ERROR_FILE_NOT_FOUND) ? > NTE_PROV_DLL_NOT_FOUND : NTE_PROVIDER_DLL_FAIL; > + DPRINT("Failed to load dll %S\n", pImage); > goto error; > - if (!(provider->pFuncs = CRYPT_Alloc(sizeof(PROVFUNCS)))) > - goto error; > - if (!(provider->pVTable = CRYPT_Alloc(sizeof(VTableProvStruc)))) > - goto error; > - if (!(provider->hModule = LoadLibraryA(pImage))) > - { > - errorcode = (GetLastError() == ERROR_FILE_NOT_FOUND) ? > NTE_PROV_DLL_NOT_FOUND : NTE_PROVIDER_DLL_FAIL; > - DPRINT1("Failed to load dll %s\n", pImage); > - goto error; > - } > + } > + provider->dwMagic = MAGIC_CRYPTPROV; > provider->refcount = 1; > > errorcode = NTE_PROVIDER_DLL_FAIL; > @@ -243,6 +251,7 @@ > SetLastError(errorcode); > if (provider) > { > + provider->dwMagic = 0; > if (provider->hModule) > FreeLibrary(provider->hModule); > CRYPT_Free(provider->pVTable); > @@ -256,30 +265,35 @@ > > > > /****************************************************************************** > - * CryptAcquireContextA (ADVAPI32.@) > + * CryptAcquireContextW (ADVAPI32.@) > + * > * Acquire a crypto provider context handle. > * > * PARAMS > - * phProv: Pointer to HCRYPTPROV for the output. > - * pszContainer: Key Container Name > - * pszProvider: Cryptographic Service Provider Name > - * dwProvType: Crypto provider type to get a handle. > - * dwFlags: flags for the operation > - * > - * RETURNS TRUE on success, FALSE on failure. > - */ > -BOOL WINAPI CryptAcquireContextA (HCRYPTPROV *phProv, LPCSTR > pszContainer, > - LPCSTR pszProvider, DWORD dwProvType, DWORD dwFlags) > + * phProv [O] Pointer to HCRYPTPROV for the output. > + * pszContainer [I] Key Container Name > + * pszProvider [I] Cryptographic Service Provider Name > + * dwProvType [I] Crypto provider type to get a handle. > + * dwFlags [I] flags for the operation > + * > + * RETURNS > + * TRUE on success, FALSE on failure. > + */ > +BOOL WINAPI CryptAcquireContextW (HCRYPTPROV *phProv, LPCWSTR > pszContainer, > + LPCWSTR pszProvider, DWORD dwProvType, DWORD dwFlags) > { > PCRYPTPROV pProv = NULL; > HKEY key; > - PSTR imagepath = NULL, keyname = NULL, provname = NULL, temp = > NULL; > - BYTE* signature; > + PWSTR imagepath = NULL, keyname = NULL, provname = NULL, temp = > NULL; > + PSTR provnameA = NULL, pszContainerA = NULL; > DWORD keytype, type, len; > ULONG r; > - > - DPRINT("(%p, %s, %s, %ld, %08lx)\n", phProv, pszContainer, > - pszProvider, dwProvType, dwFlags); > + static const WCHAR nameW[] = {'N','a','m','e',0}; > + static const WCHAR typeW[] = {'T','y','p','e',0}; > + static const WCHAR imagepathW[] = {'I','m','a','g','e',' > ','P','a','t','h',0}; > + > + DPRINT("(%p, %S, %S, %d, %08x)\n", phProv, pszContainer, > + pszProvider, dwProvType, dwFlags); > > if (dwProvType < 1 || dwProvType > MAXPROVTYPES) > { > @@ -298,26 +312,21 @@ > /* No CSP name specified so try the user default CSP first > * then try the machine default CSP > */ > - if (!(keyname = CRYPT_GetTypeKeyName(dwProvType, TRUE))) > - { > - DPRINT("No provider registered for crypto provider > type %ld.\n", dwProvType); > + if ( !(keyname = CRYPT_GetTypeKeyName(dwProvType, TRUE)) ) > { > + DPRINT("No provider registered for crypto provider > type %d.\n", dwProvType); > SetLastError(NTE_PROV_TYPE_NOT_DEF); > return FALSE; > } > - > - if (RegOpenKeyA(HKEY_CURRENT_USER, keyname, &key)) > + if (RegOpenKeyW(HKEY_CURRENT_USER, keyname, &key)) > { > CRYPT_Free(keyname); > - if (!(keyname = CRYPT_GetTypeKeyName(dwProvType, > FALSE))) > - { > - DPRINT("No type registered for crypto > provider type %ld.\n", dwProvType); > + if ( !(keyname = CRYPT_GetTypeKeyName(dwProvType, > FALSE)) ) { > + DPRINT("No type registered for crypto > provider type %d.\n", dwProvType); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_NOT_DEF); > goto error; > } > - > - if (RegOpenKeyA(HKEY_LOCAL_MACHINE, keyname, > &key)) > - { > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, keyname, > &key)) { > DPRINT("Did not find registry entry of > crypto provider for %S.\n", keyname); > CRYPT_Free(keyname); > RegCloseKey(key); > @@ -325,44 +334,41 @@ > goto error; > } > } > - > CRYPT_Free(keyname); > - r = RegQueryValueExA(key, "Name", NULL, &keytype, NULL, > &len); > - if (r != ERROR_SUCCESS || !len || keytype != REG_SZ) > + r = RegQueryValueExW(key, nameW, NULL, &keytype, NULL, > &len); > + if( r != ERROR_SUCCESS || !len || keytype != REG_SZ) > { > - DPRINT("error %ld reading size of 'Name' from > registry\n", r ); > + DPRINT("error %d reading size of 'Name' from > registry\n", r ); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > goto error; > } > - if (!(provname = CRYPT_Alloc(len))) > + if(!(provname = CRYPT_Alloc(len))) > { > RegCloseKey(key); > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > goto error; > } > - r = RegQueryValueExA(key, "Name", NULL, NULL, > (LPBYTE)provname, &len); > - if (r != ERROR_SUCCESS) > + r = RegQueryValueExW(key, nameW, NULL, NULL, > (LPBYTE)provname, &len); > + if( r != ERROR_SUCCESS ) > { > - DPRINT("error %ld reading 'Name' from registry\n", > r ); > + DPRINT("error %d reading 'Name' from registry\n", > r ); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > goto error; > } > RegCloseKey(key); > - } > - else > - { > - if (!(provname = CRYPT_Alloc(strlen(pszProvider) +1))) > + } else { > + if ( !(provname = CRYPT_Alloc((wcslen(pszProvider) > +1)*sizeof(WCHAR))) ) > { > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > goto error; > } > - strcpy(provname, pszProvider); > + wcscpy(provname, pszProvider); > } > > keyname = CRYPT_GetProvKeyName(provname); > - r = RegOpenKeyA(HKEY_LOCAL_MACHINE, keyname, &key); > + r = RegOpenKeyW(HKEY_LOCAL_MACHINE, keyname, &key); > CRYPT_Free(keyname); > if (r != ERROR_SUCCESS) > { > @@ -370,7 +376,7 @@ > goto error; > } > len = sizeof(DWORD); > - r = RegQueryValueExA(key, "Type", NULL, NULL, (BYTE*)&type, &len); > + r = RegQueryValueExW(key, typeW, NULL, NULL, (BYTE*)&type, &len); > if (r != ERROR_SUCCESS) > { > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > @@ -378,15 +384,15 @@ > } > if (type != dwProvType) > { > - DPRINT("Crypto provider has wrong type (%ld vs expected > %ld).\n", type, dwProvType); > + DPRINT("Crypto provider has wrong type (%d vs expected > %d).\n", type, dwProvType); > SetLastError(NTE_PROV_TYPE_NO_MATCH); > goto error; > } > > - r = RegQueryValueExA(key, "Image Path", NULL, &keytype, NULL, > &len); > + r = RegQueryValueExW(key, imagepathW, NULL, &keytype, NULL, &len); > if ( r != ERROR_SUCCESS || keytype != REG_SZ) > { > - DPRINT("error %ld reading size of 'Image Path' from > registry\n", r ); > + DPRINT("error %d reading size of 'Image Path' from > registry\n", r ); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > goto error; > @@ -397,90 +403,44 @@ > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > goto error; > } > - r = RegQueryValueExA(key, "Image Path", NULL, NULL, (LPBYTE)temp, > &len); > - if (r != ERROR_SUCCESS) > - { > - DPRINT("error %ld reading 'Image Path' from registry\n", r > ); > + r = RegQueryValueExW(key, imagepathW, NULL, NULL, (LPBYTE)temp, > &len); > + if( r != ERROR_SUCCESS ) > + { > + DPRINT("error %d reading 'Image Path' from registry\n", r > ); > RegCloseKey(key); > SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > goto error; > } > - > - r = RegQueryValueExA(key, "Signature", NULL, &keytype, NULL, > &len); > - if (r == ERROR_SUCCESS && keytype == REG_BINARY) > - { > - if (!(signature = CRYPT_Alloc(len))) > - { > - RegCloseKey(key); > - SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - goto error; > - } > - r = RegQueryValueExA(key, "Signature", NULL, NULL, > signature, &len); > - if (r != ERROR_SUCCESS) > - { > - DPRINT("error %ld reading 'Signature'\n", r ); > - CRYPT_Free(signature); > - RegCloseKey(key); > - SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > - goto error; > - } > - } > - else > - { > - r = RegQueryValueExA(key, "SigInFile", NULL, &keytype, > NULL, &len); > - if (r != ERROR_SUCCESS) > - { > - DPRINT("error %ld reading size of 'SigInFile'\n", > r ); > - RegCloseKey(key); > - SetLastError(NTE_PROV_TYPE_ENTRY_BAD); > - goto error; > - } > - else > - { > - /* FIXME: The presence of the SigInFile value > indicates the > - * provider's signature is in its resources, so > need to read it. > - * But since CRYPT_VerifyImage is stubbed, provide > any old thing > - * for now. > - */ > - if (!(signature = CRYPT_Alloc(1))) > - { > - RegCloseKey(key); > - SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - goto error; > - } > - } > - } > RegCloseKey(key); > - len = ExpandEnvironmentStringsA(temp, NULL, 0); > - if (!(imagepath = CRYPT_Alloc(len))) > - { > - CRYPT_Free(signature); > + len = ExpandEnvironmentStringsW(temp, NULL, 0); > + if ( !(imagepath = CRYPT_Alloc(len*sizeof(WCHAR))) ) > + { > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > goto error; > } > - if (!ExpandEnvironmentStringsA(temp, imagepath, len)) > - { > - CRYPT_Free(signature); > + if (!ExpandEnvironmentStringsW(temp, imagepath, len)) > + { > /* ExpandEnvironmentStrings will call SetLastError */ > goto error; > } > - > - if (!CRYPT_VerifyImage(imagepath, signature)) > - { > - CRYPT_Free(signature); > - SetLastError(NTE_SIGNATURE_FILE_BAD); > - goto error; > - } > pProv = CRYPT_LoadProvider(imagepath); > - CRYPT_Free(signature); > - if (!pProv) > - { > + if (!pProv) { > /* CRYPT_LoadProvider calls SetLastError */ > goto error; > } > pProv->pVTable->dwProvType = dwProvType; > - pProv->pVTable->pszProvName = provname; > - if (pProv->pFuncs->pCPAcquireContext(&pProv->hPrivate, > (CHAR*)pszContainer, dwFlags, pProv->pVTable)) > + if(!CRYPT_UnicodeToANSI(provname, &provnameA, -1)) > + { > + /* CRYPT_UnicodeToANSI calls SetLastError */ > + goto error; > + } > + pProv->pVTable->pszProvName = provnameA; > + if(!CRYPT_UnicodeToANSI(pszContainer, &pszContainerA, -1)) > + { > + /* CRYPT_UnicodeToANSI calls SetLastError */ > + goto error; > + } > + if (pProv->pFuncs->pCPAcquireContext(&pProv->hPrivate, > pszContainerA, dwFlags, pProv->pVTable)) > { > /* MSDN: When this flag is set, the value returned in > phProv is undefined, > * and thus, the CryptReleaseContext function need > not be called afterwards. > @@ -488,15 +448,17 @@ > */ > if (dwFlags & CRYPT_DELETEKEYSET) > { > + pProv->dwMagic = 0; > FreeLibrary(pProv->hModule); > - CRYPT_Free(provname); > + CRYPT_Free(provnameA); > + CRYPT_Free(pProv->pVTable); > CRYPT_Free(pProv->pFuncs); > CRYPT_Free(pProv); > - } > - else > - { > + } else { > *phProv = (HCRYPTPROV)pProv; > } > + CRYPT_Free(pszContainerA); > + CRYPT_Free(provname); > CRYPT_Free(temp); > CRYPT_Free(imagepath); > return TRUE; > @@ -505,51 +467,51 @@ > error: > if (pProv) > { > + pProv->dwMagic = 0; > if (pProv->hModule) > FreeLibrary(pProv->hModule); > - if (pProv->pVTable) > - CRYPT_Free(pProv->pVTable); > - if (pProv->pFuncs) > - CRYPT_Free(pProv->pFuncs); > + CRYPT_Free(pProv->pVTable); > + CRYPT_Free(pProv->pFuncs); > CRYPT_Free(pProv); > } > - if (provname) > - CRYPT_Free(provname); > - if (temp) > - CRYPT_Free(temp); > - if (imagepath) > - CRYPT_Free(imagepath); > + CRYPT_Free(pszContainerA); > + CRYPT_Free(provnameA); > + CRYPT_Free(provname); > + CRYPT_Free(temp); > + CRYPT_Free(imagepath); > return FALSE; > } > > > /****************************************************************************** > - * CryptAcquireContextW (ADVAPI32.@) > - * > - * see CryptAcquireContextA > - */ > -BOOL WINAPI CryptAcquireContextW (HCRYPTPROV *phProv, LPCWSTR > pszContainer, > - LPCWSTR pszProvider, DWORD dwProvType, DWORD dwFlags) > -{ > - PSTR pProvider = NULL, pContainer = NULL; > + * CryptAcquireContextA (ADVAPI32.@) > + * > + * See CryptAcquireContextW. > + */ > +BOOL WINAPI CryptAcquireContextA (HCRYPTPROV *phProv, LPCSTR > pszContainer, > + LPCSTR pszProvider, DWORD dwProvType, DWORD dwFlags) > +{ > + PWSTR pProvider = NULL, pContainer = NULL; > BOOL ret = FALSE; > > - DPRINT("(%p, %S, %S, %ld, %08lx)\n", phProv, pszContainer, > + DPRINT("(%p, %s, %s, %d, %08x)\n", phProv, pszContainer, > pszProvider, dwProvType, dwFlags); > > - if (!CRYPT_UnicodeToANSI(pszContainer, &pContainer, -1)) > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - if (!CRYPT_UnicodeToANSI(pszProvider, &pProvider, -1)) > + if ( !CRYPT_ANSIToUnicode(pszContainer, &pContainer, -1) ) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + if ( !CRYPT_ANSIToUnicode(pszProvider, &pProvider, -1) ) > { > CRYPT_Free(pContainer); > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - } > - > - ret = CryptAcquireContextA(phProv, pContainer, pProvider, > dwProvType, dwFlags); > - > - if (pContainer) > - CRYPT_Free(pContainer); > - if (pProvider) > - CRYPT_Free(pProvider); > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + > + ret = CryptAcquireContextW(phProv, pContainer, pProvider, > dwProvType, dwFlags); > + > + CRYPT_Free(pContainer); > + CRYPT_Free(pProvider); > > return ret; > } > @@ -1256,7 +1218,7 @@ > } > > > /****************************************************************************** > - * CryptGetDefaultProviderA (ADVAPI32.@) > + * CryptGetDefaultProviderW (ADVAPI32.@) > * > * Finds the default CSP of a certain provider type. > * > @@ -1275,29 +1237,43 @@ > * If pszProvName is NULL, pcbProvName will hold the size of the buffer > for > * memory allocation purposes on return. > */ > -BOOL WINAPI CryptGetDefaultProviderA (DWORD dwProvType, DWORD > *pdwReserved, > - DWORD dwFlags, LPSTR pszProvName, DWORD *pcbProvName) > +BOOL WINAPI CryptGetDefaultProviderW (DWORD dwProvType, DWORD > *pdwReserved, > + DWORD dwFlags, LPWSTR pszProvName, DWORD *pcbProvName) > { > HKEY hKey; > - PSTR keyname; > + PWSTR keyname; > DWORD result; > + static const WCHAR nameW[] = {'N','a','m','e',0}; > > if (pdwReserved || !pcbProvName) > - CRYPT_ReturnLastError(ERROR_INVALID_PARAMETER); > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > if (dwFlags & ~(CRYPT_USER_DEFAULT | CRYPT_MACHINE_DEFAULT)) > - CRYPT_ReturnLastError(NTE_BAD_FLAGS); > + { > + SetLastError(NTE_BAD_FLAGS); > + return FALSE; > + } > if (dwProvType > 999) > - CRYPT_ReturnLastError(NTE_BAD_PROV_TYPE); > - if (!(keyname = CRYPT_GetTypeKeyName(dwProvType, dwFlags & > CRYPT_USER_DEFAULT))) > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - if (RegOpenKeyA((dwFlags & CRYPT_USER_DEFAULT) ? > HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE ,keyname, &hKey)) > + { > + SetLastError(NTE_BAD_PROV_TYPE); > + return FALSE; > + } > + if ( !(keyname = CRYPT_GetTypeKeyName(dwProvType, dwFlags & > CRYPT_USER_DEFAULT)) ) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + if (RegOpenKeyW((dwFlags & CRYPT_USER_DEFAULT) ? > HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE ,keyname, &hKey)) > { > CRYPT_Free(keyname); > - CRYPT_ReturnLastError(NTE_PROV_TYPE_NOT_DEF); > + SetLastError(NTE_PROV_TYPE_NOT_DEF); > + return FALSE; > } > CRYPT_Free(keyname); > - > - result = RegQueryValueExA(hKey, "Name", NULL, NULL, > (LPBYTE)pszProvName, pcbProvName); > + > + result = RegQueryValueExW(hKey, nameW, NULL, NULL, > (LPBYTE)pszProvName, pcbProvName); > if (result) > { > if (result != ERROR_MORE_DATA) > @@ -1313,29 +1289,38 @@ > } > > > /****************************************************************************** > - * CryptGetDefaultProviderW (ADVAPI32.@) > - * > - * see CryptGetDefaultProviderA > - */ > -BOOL WINAPI CryptGetDefaultProviderW (DWORD dwProvType, DWORD > *pdwReserved, > - DWORD dwFlags, LPWSTR pszProvName, DWORD *pcbProvName) > -{ > - PSTR str = NULL; > + * CryptGetDefaultProviderA (ADVAPI32.@) > + * > + * See CryptGetDefaultProviderW. > + */ > +BOOL WINAPI CryptGetDefaultProviderA (DWORD dwProvType, DWORD > *pdwReserved, > + DWORD dwFlags, LPSTR pszProvName, DWORD *pcbProvName) > +{ > + PWSTR str = NULL; > DWORD strlen; > BOOL ret = FALSE; > > - DPRINT("(%ld, %p, %08ld, %p, %p)\n", dwProvType, pdwReserved, > dwFlags, pszProvName, pcbProvName); > - > - strlen = *pcbProvName / sizeof(WCHAR); > - if (pszProvName && !(str = CRYPT_Alloc(strlen))) > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - ret = CryptGetDefaultProviderA(dwProvType, pdwReserved, dwFlags, > str, &strlen); > + DPRINT("(%d, %p, %08x, %p, %p)\n", dwProvType, pdwReserved, > dwFlags, pszProvName, pcbProvName); > + > + CryptGetDefaultProviderW(dwProvType, pdwReserved, dwFlags, NULL, > &strlen); > + if ( pszProvName && !(str = CRYPT_Alloc(strlen)) ) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + ret = CryptGetDefaultProviderW(dwProvType, pdwReserved, dwFlags, > str, &strlen); > if (str) > - { > - CRYPT_ANSIToUnicode(str, &pszProvName, *pcbProvName); > + CRYPT_UnicodeToANSI(str, &pszProvName, *pcbProvName); > + *pcbProvName = strlen / sizeof(WCHAR); > + if (str) > + { > CRYPT_Free(str); > - } > - *pcbProvName = strlen * sizeof(WCHAR); > + if (GetLastError() == ERROR_INSUFFICIENT_BUFFER) > + { > + SetLastError(ERROR_MORE_DATA); > + return FALSE; > + } > + } > return ret; > } > > @@ -1726,7 +1711,7 @@ > } > > > /****************************************************************************** > - * CryptSetProviderExA (ADVAPI32.@) > + * CryptSetProviderExW (ADVAPI32.@) > * > * Specifies the default CSP. > * > @@ -1740,58 +1725,75 @@ > * Success: TRUE > * Failure: FALSE > */ > -BOOL WINAPI CryptSetProviderExA (LPCSTR pszProvName, DWORD dwProvType, > DWORD *pdwReserved, DWORD dwFlags) > +BOOL WINAPI CryptSetProviderExW (LPCWSTR pszProvName, DWORD dwProvType, > DWORD *pdwReserved, DWORD dwFlags) > { > HKEY hProvKey, hTypeKey; > - PSTR keyname; > - > - DPRINT("(%s, %ld, %p, %08ld)\n", pszProvName, dwProvType, > pdwReserved, dwFlags); > + PWSTR keyname; > + static const WCHAR nameW[] = {'N','a','m','e',0}; > + > + DPRINT("(%S, %d, %p, %08x)\n", pszProvName, dwProvType, > pdwReserved, dwFlags); > > if (!pszProvName || pdwReserved) > - CRYPT_ReturnLastError(ERROR_INVALID_PARAMETER); > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > if (dwProvType > MAXPROVTYPES) > - CRYPT_ReturnLastError(NTE_BAD_PROV_TYPE); > + { > + SetLastError(NTE_BAD_PROV_TYPE); > + return FALSE; > + } > if (dwFlags & ~(CRYPT_MACHINE_DEFAULT | CRYPT_USER_DEFAULT | > CRYPT_DELETE_DEFAULT) > || dwFlags == CRYPT_DELETE_DEFAULT) > - CRYPT_ReturnLastError(NTE_BAD_FLAGS); > + { > + SetLastError(NTE_BAD_FLAGS); > + return FALSE; > + } > > if (!(keyname = CRYPT_GetTypeKeyName(dwProvType, dwFlags & > CRYPT_USER_DEFAULT))) > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > - if (RegOpenKeyA((dwFlags & CRYPT_USER_DEFAULT) ? HKEY_CURRENT_USER > : HKEY_LOCAL_MACHINE, > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + if (RegOpenKeyW((dwFlags & CRYPT_USER_DEFAULT) ? HKEY_CURRENT_USER > : HKEY_LOCAL_MACHINE, > keyname, &hTypeKey)) > { > CRYPT_Free(keyname); > - CRYPT_ReturnLastError(NTE_BAD_PROVIDER); > + SetLastError(NTE_BAD_PROVIDER); > + return FALSE; > } > CRYPT_Free(keyname); > - > + > if (dwFlags & CRYPT_DELETE_DEFAULT) > { > - RegDeleteValueA(hTypeKey, "Name"); > + RegDeleteValueW(hTypeKey, nameW); > } > else > { > if (!(keyname = CRYPT_GetProvKeyName(pszProvName))) > { > RegCloseKey(hTypeKey); > - CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > } > - if (RegOpenKeyA((dwFlags & CRYPT_USER_DEFAULT) ? > HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE, > + if (RegOpenKeyW((dwFlags & CRYPT_USER_DEFAULT) ? > HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE, > keyname, &hProvKey)) > { > CRYPT_Free(keyname); > RegCloseKey(hTypeKey); > - CRYPT_ReturnLastError(NTE_BAD_PROVIDER); > + SetLastError(NTE_BAD_PROVIDER); > + return FALSE; > } > CRYPT_Free(keyname); > - > - if (RegSetValueExA(hTypeKey, "Name", 0, REG_SZ, > (LPBYTE)pszProvName, strlen(pszProvName) + 1)) > + > + if (RegSetValueExW(hTypeKey, nameW, 0, REG_SZ, (const BYTE > *)pszProvName, > + (wcslen(pszProvName) + 1)*sizeof(WCHAR))) > { > RegCloseKey(hTypeKey); > RegCloseKey(hProvKey); > return FALSE; > } > - > + > RegCloseKey(hProvKey); > } > RegCloseKey(hTypeKey); > @@ -1800,20 +1802,20 @@ > } > > > /****************************************************************************** > - * CryptSetProviderExW (ADVAPI32.@) > - * > - * See CryptSetProviderExA > - */ > -BOOL WINAPI CryptSetProviderExW (LPCWSTR pszProvName, DWORD dwProvType, > DWORD *pdwReserved, DWORD dwFlags) > + * CryptSetProviderExA (ADVAPI32.@) > + * > + * See CryptSetProviderExW. > + */ > +BOOL WINAPI CryptSetProviderExA (LPCSTR pszProvName, DWORD dwProvType, > DWORD *pdwReserved, DWORD dwFlags) > { > BOOL ret = FALSE; > - PSTR str = NULL; > - > - DPRINT("(%S, %ld, %p, %08ld)\n", pszProvName, dwProvType, > pdwReserved, dwFlags); > - > - if (CRYPT_UnicodeToANSI(pszProvName, &str, -1)) > - { > - ret = CryptSetProviderExA(str, dwProvType, pdwReserved, > dwFlags); > + PWSTR str = NULL; > + > + DPRINT("(%s, %d, %p, %08x)\n", pszProvName, dwProvType, > pdwReserved, dwFlags); > + > + if (CRYPT_ANSIToUnicode(pszProvName, &str, -1)) > + { > + ret = CryptSetProviderExW(str, dwProvType, pdwReserved, > dwFlags); > CRYPT_Free(str); > } > return ret; > > Modified: trunk/reactos/dll/win32/advapi32/crypt/crypt.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/crypt/c… > > ============================================================================== > --- trunk/reactos/dll/win32/advapi32/crypt/crypt.h (original) > +++ trunk/reactos/dll/win32/advapi32/crypt/crypt.h Thu Nov 15 17:08:18 > 2007 > @@ -15,7 +15,7 @@ > * > * You should have received a copy of the GNU Lesser General Public > * License along with this library; if not, write to the Free Software > - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 > USA > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > */ > > #ifndef __WINE_CRYPT_H > @@ -56,25 +56,28 @@ > BOOL (WINAPI *pCPVerifySignature)(HCRYPTPROV hProv, HCRYPTHASH > hHash, CONST BYTE *pbSignature, DWORD dwSigLen, HCRYPTKEY hPubKey, LPCWSTR > sDescription, DWORD dwFlags); > } PROVFUNCS, *PPROVFUNCS; > > +#define MAGIC_CRYPTPROV 0xA39E741F > + > typedef struct tagCRYPTPROV > { > + DWORD dwMagic; > UINT refcount; > HMODULE hModule; > PPROVFUNCS pFuncs; > - HCRYPTPROV hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > + HCRYPTPROV hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > PVTableProvStruc pVTable; > } CRYPTPROV, *PCRYPTPROV; > > typedef struct tagCRYPTKEY > { > PCRYPTPROV pProvider; > - HCRYPTKEY hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > + HCRYPTKEY hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > } CRYPTKEY, *PCRYPTKEY; > > typedef struct tagCRYPTHASH > { > PCRYPTPROV pProvider; > - HCRYPTHASH hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > + HCRYPTHASH hPrivate; /*CSP's handle - Should not be given to > application under any circumstances!*/ > } CRYPTHASH, *PCRYPTHASH; > > #define MAXPROVTYPES 999 > @@ -82,7 +85,17 @@ > extern unsigned char *CRYPT_DESkey8to7( unsigned char *dst, const > unsigned char *key ); > extern unsigned char *CRYPT_DEShash( unsigned char *dst, const unsigned > char *key, > const unsigned char *src ); > +extern unsigned char *CRYPT_DESunhash( unsigned char *dst, const unsigned > char *key, > + const unsigned char *src ); > > extern VOID byteReverse(unsigned char *buf, unsigned longs); > > +struct ustring { > + DWORD Length; > + DWORD MaximumLength; > + unsigned char *Buffer; > +}; > + > +NTSTATUS WINAPI SystemFunction032(struct ustring *data, struct ustring > *key); > + > #endif /* __WINE_CRYPT_H_ */ > > > -- Best regards, Alex Ionescu

3 2

High-side Redzone Overwritten
by James Tabor 15 Nov '07

15 Nov '07

Hi, This does happen often with Qemu Linux and Windows. Very intermittent, one out of 50. Rev is at 30454. (ntoskrnl/kd/kdio.c:191) ----------------------------------------------------- (ntoskrnl/kd/kdio.c:192) ReactOS 0.4-SVN (Build 20071115-rUNKNOWN) (ntoskrnl/kd/kdio.c:193) Command Line: NOGUIBOOT DEBUGPORT=COM1 NOGUIBOOT DEBUGPORT=COM1 (ntoskrnl/kd/kdio.c:194) ARC Paths: multi(0)disk(0)cdrom(224) \ multi(0)disk(0)cdrom(224) \reactos\ (ntoskrnl/mm/mminit.c:266) Base Length Type (ntoskrnl/mm/mminit.c:272) 000000A0 00000060 FirmwarePermanent (ntoskrnl/mm/mminit.c:272) 00000800 0000028E SystemCode (ntoskrnl/mm/mminit.c:272) 00000A8E 0000000E BootDriver (ntoskrnl/mm/mminit.c:272) 00000A9C 0000001A HalCode (ntoskrnl/mm/mminit.c:272) 00000AB6 00000009 BootDriver (ntoskrnl/mm/mminit.c:272) 00000ABF 00000003 RegistryData (ntoskrnl/mm/mminit.c:272) 00000AC2 00000011 NlsData (ntoskrnl/mm/mminit.c:272) 00000AD3 00000011 NlsData (ntoskrnl/mm/mminit.c:272) 00000AE4 00000002 NlsData (ntoskrnl/mm/mminit.c:272) 00000AE6 0000002A BootDriver (ntoskrnl/mm/mminit.c:272) 00000B10 00000015 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B25 00000017 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B3C 0000000D BootDriver (ntoskrnl/mm/mminit.c:272) 00000B49 00000011 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B5A 00000019 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B73 00000012 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B85 00000011 BootDriver (ntoskrnl/mm/mminit.c:272) 00000B96 00000013 BootDriver (ntoskrnl/mm/mminit.c:272) 00000BA9 00000013 BootDriver (ntoskrnl/mm/mminit.c:272) 00000BBC 0000000D BootDriver (ntoskrnl/mm/mminit.c:272) 00000BC9 00000009 BootDriver (ntoskrnl/mm/mminit.c:272) 00000BD2 0000042E Free (ntoskrnl/mm/mminit.c:272) 00000FC0 FFFFF840 SpecialMemory (ntoskrnl/mm/mminit.c:276) Total: 000000A0 (0 MB) Used memory 131008Kb (ntoskrnl/ke/i386/kiinit.c:47) Large Page support detected but not yet taken advantage of! (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 WARNING: IoReportResourceUsage at ntoskrnl/io/iomgr/iorsrce.c:701 is UNIMPLEMENTED! WARNING: IoReportResourceUsage at ntoskrnl/io/iomgr/iorsrce.c:701 is UNIMPLEMENTED! (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 (drivers/storage/scsiport/scsiport.c:1101) SpiCreatePortConfig() failed with Status 0xC00000C0 (ntoskrnl/io/iomgr/driver.c:1283) '\Driver\BUSLOGIC' initialization failed, status (0xc00000c0) (drivers/storage/class/disk/disk.c:1161) IoReadPartitionTable() status: 0x00000000 (ntoskrnl/io/iomgr/driver.c:1283) '\Driver\FLOPPY' initialization failed, status (0xc000000e) (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack (ntoskrnl/io/iomgr/file.c:414) Using IopParseDevice() hack NPPOL: High-side redzone overwritten, Block 81281b98, Size 64, Tag 4552414d(ERAM), Caller 80854458 KeBugCheck at ntoskrnl/mm/npool.c:1514 *** Fatal System Error: 0x00000000 (0x00000000,0x00000000,0x00000000,0x00000000) <\SystemRoot\System32\NTOSKRNL.EXE: 2ae0> ke/bug.c:1359 (KeBugCheck@4) <\SystemRoot\System32\NTOSKRNL.EXE: 56c6c> mm/npool.c:1514 (check_redzone_header) <\SystemRoot\System32\NTOSKRNL.EXE: 56d6e> mm/npool.c:1579 (ExFreeNonPagedPool@4) <\SystemRoot\System32\NTOSKRNL.EXE: 59c64> mm/pool.c:239 (ExFreePool@4) <\SystemRoot\System32\NTOSKRNL.EXE: 59ca2> mm/pool.c:249 (ExFreePoolWithTag@8) <\SystemRoot\System32\NTOSKRNL.EXE: 54803> mm/marea.c:854 (MmFreeMemoryArea@16) <\SystemRoot\System32\NTOSKRNL.EXE: dde5> cc/view.c:923 (CcRosInternalFreeCacheSegment) <\SystemRoot\System32\NTOSKRNL.EXE: f350> cc/view.c:381 (CcRosTrimCache) <\SystemRoot\System32\NTOSKRNL.EXE: 51c6d> mm/balance.c:147 (MiTrimMemoryConsumer@4) <\SystemRoot\System32\NTOSKRNL.EXE: 51fc0> mm/balance.c:205 (MmRequestPageMemoryConsumer@12) <\SystemRoot\System32\NTOSKRNL.EXE: ef81> cc/view.c:709 (CcRosCreateCacheSegment) <\SystemRoot\System32\NTOSKRNL.EXE: f0dd> cc/view.c:817 (CcRosGetCacheSegment@24) <\SystemRoot\System32\NTOSKRNL.EXE: f114> cc/view.c:860 (CcRosRequestCacheSegment@20) <\SystemRoot\System32\NTOSKRNL.EXE: da90> cc/pin.c:64 (CcMapData@24) <\SystemRoot\System32\drivers\VFATFS.SYS: 5274> fat.c:415 (CountAvailableClusters) <\SystemRoot\System32\drivers\VFATFS.SYS: ba1c> volume.c:119 (VfatQueryVolumeInformation) <\SystemRoot\System32\drivers\VFATFS.SYS: 97ac> misc.c:121 (VfatDispatchRequest) <\SystemRoot\System32\drivers\VFATFS.SYS: 98ab> misc.c:167 (VfatBuildRequest@8) <\SystemRoot\System32\NTOSKRNL.EXE: 44f96> io/iomgr/irp.c:1134 (@IofCallDriver@8) <\SystemRoot\System32\NTOSKRNL.EXE: 3f924> io/iomgr/iofunc.c:137 (IopPerformSynchronousRequest@28) <\SystemRoot\System32\NTOSKRNL.EXE: 41c2d> io/iomgr/iofunc.c:3157 (NtQueryVolumeInformationFile@20) <\SystemRoot\System32\NTOSKRNL.EXE: 893ba> ke/i386/trap.s:244 (KiFastCallEntry) <\SystemRoot\System32\NTOSKRNL.EXE: 84ab9> ex/zw.S:1694 (ZwQueryVolumeInformationFile) <\SystemRoot\System32\NTOSKRNL.EXE: 18208> config/cmsysini.c:101 (CmpInitHiveFromFile@20) <\SystemRoot\System32\NTOSKRNL.EXE: 1b7d2> cm/regfile.c:38 (CmiLoadHive) <\SystemRoot\System32\NTOSKRNL.EXE: 1ba0d> cm/registry.c:408 (CmiInitHives) <\SystemRoot\System32\NTOSKRNL.EXE: 1a6ae> cm/ntfunc.c:637 (NtInitializeRegistry@4) <\SystemRoot\System32\NTOSKRNL.EXE: 893ba> ntoskrnl/ke/i386/trap.s:244 (KiFastCallEntry)

1 0

[ros-diffs] [weiden] 29670: Tweak the ScrollDC implementation a bit so that it produces a better output. The implementation still is completely incorrect as it should call the driver for this operation instead of doing a BitBlt operation...
by Timo Kreuzer 14 Nov '07

14 Nov '07

NtGdiBitBlt calls IntEngBitBlt, wich calls DrvBitBlt if available. There's no DrvScroll function. Timo > Author: weiden > Date: Fri Oct 19 07:23:04 2007 > New Revision: 29670 > > URL: http://svn.reactos.org/svn/reactos?rev=29670&view=rev <http://svn.reactos.org/svn/reactos?rev=29670&view=rev> > Log: > Tweak the ScrollDC implementation a bit so that it produces a better output. The implementation still is completely incorrect as it should call the driver for this operation instead of doing a BitBlt operation... > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/painting.c >

3 2

Re: [ros-dev] About UNICODE<->ASCII support.
by carlo.bramix 14 Nov '07

14 Nov '07

Hello, honestly, your enthusiasm seems a bit to exagerated to me! In the specific case, it looks like that all TCHARs in Taskmgr have been converted to WCHAR because the programme receives from the API some informations that are UNICODE only. I can understand and I agree to that, afterall it can be made working with unicows layer, if someone wants (and infact, I did it). Athough you should also admit that two WideCharToMultiByte() calls are not exactly something we can call "drammatic" code, which is automatically excluded by the presence of the magic UNICODE macro. I also agree with the fact that there could be the source code which interacts with UNICODE-only variables and the direct usage of WCHAR instead of TCHAR is very helpful and clean. But how many functions have this behavior (WCHAR-only)? It is not too difficult to count them and in my opinion this does not justify a refresh of sources for making TCHAR>WCHAR, or MessageBox>MessageBoxW... Last but not last... human beings can do errors, their changes may always introduce new errors, so more time for testing, etc... If I can do a suggestion, I would avoid unnecesary changes for this reason too. Afterall the binary code of the executable won't change by a single bit when TCHARs are converted to WCHARs at compile time, if there are not drawbacks like tons of conversions which will make the source code unreadable (it's also important that people understand the code for contribuiting). But if there are just TCHARs/_tcscpy/... I don't understand the reason. Sincerely, Carlo Bramini. ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Mon, 5 Nov 2007 23:55:35 +0000 Subject : Re: [ros-dev] About UNICODE<->ASCII support. > On Nov 5, 2007 5:53 PM, Colin Finck <mail(a)colinfinck.de> wrote: > > Hi Ged, > > > > > Ged wrote: > > > This is the wrong way to be working. We should be dropping > > > support for ASCII where ever possible now. > > > > Is this really the official course now? > > This has pretty much always been the course. > There is absolutely no reason to use TCHAR, it was relevant 10 years > ago, but not any more. > > (btw, in case anyone thinks I'm contradicting myself with mstsc, TCHAR > is only being used as it's currently a port of an ASCII app) > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

4 3

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev