Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-svn] [jimtabor] 20559: Clean up and fixed NtUserGetMenuItemRect. Needs more testing. I watch mplayerc swip all the menu items with crashing.
by James Tabor 04 Jan '06

04 Jan '06

jimtabor(a)svn.reactos.org wrote: > Clean up and fixed NtUserGetMenuItemRect. Needs more testing. I watch mplayerc swip all the menu items with out crashing. > > > Updated files: > trunk/reactos/subsys/win32k/ntuser/menu.c > *out

1 0

Info about debugger
by Juan Rodriguez 04 Jan '06

04 Jan '06

what debugger can i use on ros?

1 0

install problem
by Hartmut Birr 04 Jan '06

04 Jan '06

Hi, it seems, some people have problems to install reactos from the boot cd. The reason is, all newer pc with a P4-HT or an AMD64X2 cpu are multiprocessor compliant. In this case, the auto choice is multiprocessor for the computer type. If the choice isn't changed, the multiprocessor hal and the uniprocessor kernel are installed. The next boot will show an empty colored (light green or red) screen after freeldr has started reactos. I think, we should disable the auto choice for the computer type. - Hartmut

2 1

RE: [ros-dev] RE: [ros-diffs] [mbosma] 20543: fix typos.
by Murphy, Ged (Bolton) 03 Jan '06

03 Jan '06

Thomas Weidenmueller wrote: > Murphy, Ged (Bolton) wrote: > > which, IIRC (I don't have a compiler to hand) would throw > up 'assignment in > > expression' errors with our MSVC /w4 setting. We would > therefore need > > something like : > > Then don't use that warning level if it rejects good code that's not > even confusing. It's set via rbuilds MSDN backend. It needs functionality to set different warning levels for different components. e.g. /w4 for core components only. Having to do it manually is far too much effort for your average programmer ;) Maybe I should stop moaning and correct it .... hmmm :p > > Which has suddenly become rather long for a normally simple > message loop > > routine ..... LOL > > It's exactly the same, just ugly IMO. I know, as I said, it was just for fun. First day back at work after the Christmas break is hard going ;) (and why are these mails being sent to both ros-diff and ros-dev when only addressed to ros-dev, Gé ?) Ged. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

3 2

Re: [ros-svn] [greatlrd] 20548: forget remove a calc value in the for loop it can do outside the loop.
by James Tabor 03 Jan '06

03 Jan '06

Hi GreatLord! greatlrd(a)svn.reactos.org wrote: > forget remove a calc value in the for loop it can do outside the loop. > > > > Updated files: > trunk/reactos/subsys/win32k/dib/dib16bpp.c > I'm getting this even after a make clean, [CC] subsys/win32k/dib/dib16bpp.c subsys/win32k/dib/dib16bpp.c: In function `CheckClipRegion': subsys/win32k/dib/dib16bpp.c:631: error: structure has no member named `Height' make[1]: *** [obj-i386/subsys/win32k/dib/dib16bpp.o] Error 1 Thanks, James

2 1

Why GAS not NASM?
by Alex Buell 03 Jan '06

03 Jan '06

I think our problem is because we are using GAS and NASM to assemble the various assembly files. Oughtn't we standardise on NASM? Why not? -- http://www.munted.org.uk Anyone that thinks an imaginary deity is going to protect them against earthquakes and hurricanes needs psychiatric help.

3 3

RE: [ros-diffs] [mbosma] 20543: fix typos.
by Murphy, Ged (Bolton) 03 Jan '06

03 Jan '06

This should really be while( GetMessage( &msg, NULL, 0, 0 ) > 0 ) as GetMessage returns <0 on failure. It will then break on failure or WM_QUIT Just being anal though as GetMessage should never really fail ;) -----Original Message----- From: mbosma(a)svn.reactos.org [mailto:mbosma@svn.reactos.org] Sent: 03 January 2006 11:50 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [mbosma] 20543: fix typos. + while(GetMessage(&msg,NULL,0,0)) ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

3 2

RE: [ros-dev] RE: [ros-diffs] [mbosma] 20543: fix typos.
by Murphy, Ged (Bolton) 03 Jan '06

03 Jan '06

Thomas Weidenmueller wrote > Murphy, Ged (Bolton) wrote: > > This should really be > > > > while( GetMessage( &msg, NULL, 0, 0 ) > 0 ) > > > > as GetMessage returns <0 on failure. > > It will then break on failure or WM_QUIT > > > > Just being anal though as GetMessage should never really fail ;) > > See > http://msdn.microsoft.com/library/default.asp?url=/library/en- > us/winui/WinUI/WindowsUserInterface/Windowing/MessagesandMessa > geQueues/MessagesandMessageQueuesReference/MessagesandMessageQ > ueuesFunctions/GetMessage.asp > > The loop shouldn't be broken if GetMessage returns -1. > > - Thomas True, I suppose it depends on the reasoning behind the GetMessage error. MSDN does have this to say: "Warning Because the return value can be nonzero, zero, or -1, avoid code like this: while (GetMessage( lpMsg, hWnd, 0, 0)) ..." For a bit of light hearted fun, here is the MSDN suggestion: while( (bRet = GetMessage( &msg, NULL, 0, 0 )) != 0) { if (bRet == -1) { // handle the error and possibly exit } else { TranslateMessage(&msg); DispatchMessage(&msg); } } which, IIRC (I don't have a compiler to hand) would throw up 'assignment in expression' errors with our MSVC /w4 setting. We would therefore need something like : bRet = GetMessage( &msg, NULL, 0, 0 ); while( bRet != 0 ) { if (bRet == -1) { // handle the error and possibly exit } else { TranslateMessage(&msg); DispatchMessage(&msg); } bRet = GetMessage( &msg, NULL, 0, 0 ); } Which has suddenly become rather long for a normally simple message loop routine ..... LOL A nice case for a #pragma warning() ..... or reduce the warning level for non core components (ping) Ged ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

Re: [ros-svn] [hbirr] 20532: Simplified the definition of the interrupt handlers for non smp machines.
by Alex Ionescu 02 Jan '06

02 Jan '06

hbirr(a)svn.reactos.org wrote: >Simplified the definition of the interrupt handlers for non smp machines. > > > >Updated files: >trunk/reactos/ntoskrnl/ke/i386/irqhand.s > > > > GMTA :) Best regards, Alex Ionescu

1 0

ntoskrnl/ex/i386/interlck_asm.S fails to compile due to EFLAG_SELECT
by Alex Buell 02 Jan '06

02 Jan '06

I thought that it was agreed that the minimum version of binutils would be at least 2.15.90.0.2? The fix for this requires a newer version? make[1]: Entering directory `/home/alex/src/OpSys/reactos' [GAS] ntoskrnl/ex/i386/interlck_asm.S ntoskrnl/ex/i386/interlck_asm.S: Assembler messages: ntoskrnl/ex/i386/interlck_asm.S:440: Error: Unrecognized token `|0x4000' ntoskrnl/ex/i386/interlck_asm.S:459: Error: Unrecognized token `| 0x4000)' ntoskrnl/ex/i386/interlck_asm.S:459: Error: Unexpected token `' ntoskrnl/ex/i386/interlck_asm.S:508: Error: Unrecognized token `| 0x4000)' ntoskrnl/ex/i386/interlck_asm.S:508: Error: Unexpected token `' ntoskrnl/ex/i386/interlck_asm.S:527: Error: Unrecognized token `| 0x4000)' ntoskrnl/ex/i386/interlck_asm.S:527: Error: Unexpected token `' make[1]: *** [obj-i386/ntoskrnl/ex/i386/interlck_asm.o] Error 1 -- http://www.munted.org.uk Anyone that thinks an imaginary deity is going to protect them against earthquakes and hurricanes needs psychiatric help.

3 8

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev