Ros-dev

ros-dev@reactos.org

5789 discussions

RE: [ros-svn] [ekohl] 20496: - Service list entries use a pointer to agroup list entry instead of the goup name.

by Ge van Geldorp

> From: ekohl(a)svn.reactos.org > > - Service list entries use a pointer to a group list entry > instead of the goup name. > - New group list entries are created in the > unknown-group-list for services of unknown groups. I'm seeing some crashes now because the lpGroup->lpService pointer is NULL. Patch below seems to fix it, but I have no idea if it's the correct fix. GvG Index: subsys/system/services/rpcserver.c =================================================================== --- subsys/system/services/rpcserver.c (revision 20508) +++ subsys/system/services/rpcserver.c (working copy) @@ -927,7 +927,7 @@ if (lpdwTagId != NULL) { - dwError = ScmAssignNewTag(lpService->lpGroup->lpGroupName, + dwError = ScmAssignNewTag(lpLoadOrderGroup, &lpService->dwTag); if (dwError != ERROR_SUCCESS) goto done; @@ -1161,7 +1161,7 @@ if (lpdwTagId != NULL) { - dwError = ScmAssignNewTag(lpService->lpGroup->lpGroupName, + dwError = ScmAssignNewTag(lpLoadOrderGroup, &lpService->dwTag); if (dwError != ERROR_SUCCESS) goto done;

19 years, 6 months

Remove svn.reactos.com DNS entry

by Ge van Geldorp

Sunday night I will remove the svn.reactos.com DNS entry, please use svn.reactos.org in the future. If you currently have a working copy checked out from svn://svn.reactos.com you can tell svn to use svn.reactos.org in the future by: > From: WaxDragon > > Say you have a checkout in ~/src/reactos that was originally checked > out from svn://svn.reactos.com/trunk/reactos. from the root of the > checkout (~src/reactos) issue: > > svn switch --relocate svn://svn.reactos.com/trunk/reactos svn://svn.reactos.org/trunk/reactos If you're using Tortoise: > From: Maarten Bosma > > Just right click in root dir, chosse "TortiseSVN > Relocate..." and then > enter svn://svn.reactos.org/trunk/reactos into the dialog. Or if you have no local changes you could just delete your working copy and check out a new one from reactos.org. If you insist on using svn.reactos.com, add a line "213.173.252.2 svn.reactos.com" to your hosts file (/etc/hosts for Linux/Unix, %SystemRoot%\System32\drivers\etc\hosts on Windows). Gé van Geldorp.

19 years, 6 months

Re: [ros-diffs] [gedmurphy] 20459: Put skeleton in place for 'internet time' tab in the 'date and time' control panel applet

by Ged Murphy

gedmurphy(a)svn.reactos.org wrote: > + CONTROL "Automatically synchronize with an Internet time server", IDC_AUTODAYLIGHT, > + "Button", BS_AUTOCHECKBOX | WS_GROUP | WS_TABSTOP,11,7,241,10 > oops, ignore the IDC_AUTODAYLIGHT typo, I'll fix it when I get round to putting the rest of the code in :) Ged.

19 years, 6 months

libjpeg

by Maarten Bosma

Does anyone mind if I import libjpeg for jpg support ? The License is not a problem, but the patent might be. Sorry that ask so late (did already a vendor import). I asked 2 times on IRC and thought that would be enough, but GreatLord convinced me that I have to asked here too. Maarten Bosma PS: The size of the files that would go into reactos/lib is 694 KB.

19 years, 6 months

RE: [ros-diffs] [hpoussin] 20456: Forward ChangeServiceConfig2W call toservices.exe

by Casper Hornstrup

Missing return in success path. Casper _____ From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of hpoussin(a)svn.reactos.org Sent: 30. december 2005 11:29 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [hpoussin] 20456: Forward ChangeServiceConfig2W call toservices.exe Forward ChangeServiceConfig2W call to services.exe Modified: trunk/reactos/include/idl/svcctl.idl Modified: trunk/reactos/lib/advapi32/advapi32.def Modified: trunk/reactos/lib/advapi32/service/scm.c Modified: trunk/reactos/subsys/system/services/rpcserver.c _____ Modified: trunk/reactos/lib/advapi32/service/scm.c --- trunk/reactos/lib/advapi32/service/scm.c 2005-12-30 01:41:02 UTC (rev 20455) +++ trunk/reactos/lib/advapi32/service/scm.c 2005-12-30 10:29:07 UTC (rev 20456) @@ -78,6 +78,53 @@ /********************************************************************** + * ChangeServiceConfig2W + * + * @implemented + */ +BOOL WINAPI +ChangeServiceConfig2W(SC_HANDLE hService, + DWORD dwInfoLevel, + LPVOID lpInfo) +{ + DWORD lpInfoSize; + DWORD dwError; + + DPRINT("ChangeServiceConfig2W() called\n"); + + /* Determine the length of the lpInfo parameter */ + switch (dwInfoLevel) + { + case SERVICE_CONFIG_DESCRIPTION: + lpInfoSize = sizeof(SERVICE_DESCRIPTION); + case SERVICE_CONFIG_FAILURE_ACTIONS: + lpInfoSize = sizeof(SERVICE_FAILURE_ACTIONS); + default: + DPRINT1("Unknown info level 0x%lx\n", dwInfoLevel); + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + + if (lpInfo == NULL) + return TRUE; + + HandleBind(); + + dwError = ScmrChangeServiceConfig2W(BindingHandle, + (unsigned int)hService, + dwInfoLevel, + lpInfo, + lpInfoSize); + if (dwError != ERROR_SUCCESS) + { + DPRINT1("ScmrChangeServiceConfig2W() failed (Error %lu)\n", dwError); + SetLastError(dwError); + return FALSE; + } +} + + +/********************************************************************** * ChangeServiceConfigA * * @implemented @@ -1553,7 +1600,7 @@ #if 0 DWORD dwError; - DPRINT("StartServiceW()\n", ScLock); + DPRINT("StartServiceW()\n"); HandleBind();

19 years, 6 months

VMWare (player) image of ROS

by Oliver Schneider

A while ago, when it was mentioned that ROS 2.9 is soon to be released I proposed to put out a VMWare image of it - never got a reply though, or missed it. It has been mentioned multiple times that VMWare is used by some ROS-devs, so this shouldn't be a problem in the first place. Since the authors of VMWare have released a so-called VMWare-Player (see http://www.vmware.com/products/player/ ), it is easy for anyone to get both (given that they don't have VMWare, yet). VMWare is certainly faster than QEMU or Bochs for several reasons and thus would be a better "experience" for potential ROS testers and users. And please don't tell me that is a kind of endorsement of VMWare, since the link on the website already is. There is at least one (much cheaper) alternative to VPC and VMWAre, called Parallels which is not mentioned on the website at all ( http://www.parallels.com/en/products/workstation/ ). I just wanted to remind all of you of this idea for (re)consideration. Cheers, Oliver

19 years, 6 months

commit problem

by Hartmut Birr

Hi, I've fixed Alex' win32k changes. First, I try to commit the original changes. I've used 'svn merge -r20366:20368 svn://svn.reactos.org/trunk/reactos' to get the changes and I'm using 'svn commit' to commit the changes again. I get an error message: I:\Sandbox\ros_work\reactos>svn commit Lösche include\win32k\bitmaps.h <snip> Sende w32api\include\wingdi.h Übertrage Daten ................svn: Übertragen fehlgeschlagen (Details folgen): svn: Source url 'svn://svn.reactos.org/trunk/reactos/include/win32k/ntgdibad.h' is from different repository svn: Ihre Log-Meldung wurde in einer Temporärdatei abgelegt: svn: 'I:/Sandbox/ros_work/reactos/svn-commit.2.tmp' Usually, I get all error messages in german. What do I make wrong? - Hartmut

19 years, 6 months

Re: [ros-diffs] [ion] 20436: - Fix InterlockedBitTestAndReset and InterlockedBitTestAndSet

by Thomas Weidenmueller

ion(a)svn.reactos.org wrote: > + /* Value changed... wait until it's locked */ > + while (*SpinLock == 1) YieldProcessor(); This might be optimized away since SpinLock was not defined as volatile KSPIN_LOCK* - Thomas

19 years, 6 months

Re: [ros-diffs] [greatlrd] 20421: some case from win32k can call to RtlClearAllBits with NULL pointer. and check for null pointer after RtlClearAllBits. This take care of those case for moment.

by Thomas Weidenmueller

greatlrd(a)svn.reactos.org wrote: > some case from win32k can call to RtlClearAllBits with NULL pointer. and check for null pointer after RtlClearAllBits. This take care of those case for moment. This change is wrong, please revert it and fix win32k instead. - Thomas

19 years, 6 months

Re: [ros-diffs] [ion] 20366: - Added support for NTLDR style freeloader GUI. To enable, edit freeldr.ini and add:

by Hartmut Birr

ion(a)svn.reactos.com wrote: > - Also made the boot-up screen black, not blue, since that's the actual color it's been after NT4. If booting without NOGUIBOOT, this results in a much nicer transition to the boot screen (especially if using the NTLDR theme) > This changes the 'blue screen of death' to a 'black screen of death'. I don't like it if you change every and any thing to the real windows implementation. I see no reason for this cloning. - Hartmut

19 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev