Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-diffs] [jimtabor] 20647: Patch by Raimonds Praude raimonds.praude at sets.lv
by Filip Navara 07 Jan '06

07 Jan '06

>+ case CB_LIMITTEXT: >+ if( lphc->wState & CBF_EDIT ) >+ return SendMessageW(lphc->hWndEdit, EM_LIMITTEXT, wParam, lParam); > > <- "break;" statement is missing here and the indentation is fscked up. - Filip

1 0

Re: [ros-svn] [ion] 20656: - Do not generate manifest files for drivers or native apps.
by James Tabor 07 Jan '06

07 Jan '06

Hi Alex, ion(a)svn.reactos.org wrote: > - Get portcls to compile. > trunk/reactos/drivers/multimedia/portcls/portcls.c > trunk/reactos/drivers/multimedia/portcls/portcls.h Was OSR wrong? Wow! 8^o Thanks, James

2 2

Re: [ros-svn] [ion] 20653: - Get chew and csq to compile.
by James Tabor 07 Jan '06

07 Jan '06

ion(a)svn.reactos.org wrote: > - Get chew and csq to compile. > > > Updated files: > trunk/reactos/drivers/lib/chew/workqueue.c > trunk/reactos/drivers/lib/csq/csq.c > Sorry Alex! darkstar:/home/ros/rosbackup# make depends make[1]: Entering directory `/home/ros/rosbackup' [RBUILD] makefile.auto Reading build files...done ExecuteInvocations Detecting compiler...detected (mingw32-gcc) Detecting binutils...detected (mingw32-ld) Detecting netwide assembler...detected (nasm) Detecting compiler -pipe support...detected Detecting compiler pre-compiled header support...detected Processing modules...done Creating directories...done Unpacking WINE resources...done Generating test support code...done Generating compilation unit support code...done Generating syssetup.inf...done Generating proxy makefiles...done Checking automatic dependencies...done make[1]: Leaving directory `/home/ros/rosbackup' make[1]: Entering directory `/home/ros/rosbackup' [CC] drivers/lib/chew/workqueue.c drivers/lib/chew/workqueue.c:63: error: conflicting types for 'ChewCreate' include/chew/chew.h:34: error: previous declaration of 'ChewCreate' was here drivers/lib/chew/workqueue.c:63: error: conflicting types for 'ChewCreate' include/chew/chew.h:34: error: previous declaration of 'ChewCreate' was here make[1]: *** [obj-i386/drivers/lib/chew/workqueue.o] Error 1 make[1]: Leaving directory `/home/ros/rosbackup' make: *** [depends] Error 2 Darn! B^( James

2 1

Update Combo.c CB_LIMITTEXT
by James Tabor 07 Jan '06

07 Jan '06

Hi to anyone from the Wine developer group, Here is my first patch. 8^D Thanks, James Index: combo.c =================================================================== RCS file: /home/wine/wine/dlls/user/combo.c,v retrieving revision 1.16 diff -u -r1.16 combo.c --- combo.c 6 Jan 2006 20:53:00 -0000 1.16 +++ combo.c 7 Jan 2006 07:11:32 -0000 @@ -29,7 +29,6 @@ * TODO: * - ComboBox_[GS]etMinVisible() * - CB_GETMINVISIBLE, CB_SETMINVISIBLE - * - CB_LIMITTEXT * - CB_SETTOPINDEX */

1 0

Finding Problems With Exceptions, No not Casper
by James Tabor 06 Jan '06

06 Jan '06

Hi all, Most common, when exiting a app by clicking the "X" in the upper right corner, (./subsys/win32k/objects/gdiobj.c:591) Attempted to free global gdi handle 0xe04 04b4, caller needs to get ownership first!!! (lib/rtl/exception.c:75) RtlRaiseStatus(Status 0xc0000005) (./subsys/win32k/ntuser/message.c:1121) Failed to copy message to kernel: invali d usermode buffer (lib/comctl32/toolbar.c:417) bitmap for ID 0, index 0 is not valid, number of bi tmaps in imagelist: -2 (./ntoskrnl/ke/queue.c:420) Unwaiting Thread: 5 (lib/rtl/exception.c:75) RtlRaiseStatus(Status 0xc0000005) (./subsys/win32k/ntuser/message.c:1121) Failed to copy message to kernel: invali d usermode buffer C0000005 is an Access error, due to MmCopyToCaller being called inside kernel space when copying one object to another with in kernel space, sometimes but it is common. In win32k/ntuser/message.c there is and it's my best guess, Status = MmCopyFromCaller(KernelMem, (PVOID) UserModeMsg->lParam, Size); at line ~1118, in function CopyMsgToKernelMem. If that function is used to copy data inside kernel space it will through and exception. This one is from OpenOffice, Some where in kernel32.dll. (lib/rtl/exception.c:29) RtlRaiseException(Status 0054f404) (lib/rtl/exception.c:36) ExceptionAddress 7c801217 (./ntoskrnl/ke/exception.c:94) KiRaiseException (lib/rtl/exception.c:29) RtlRaiseException(Status 0054f41c) (lib/rtl/exception.c:36) ExceptionAddress 7c801217 (./ntoskrnl/ke/exception.c:94) KiRaiseException 0 bytes requested - initiating pool verification 0 bytes requested - initiating pool verification Sorry I haven't looked at this one yet, I just started! 8^> James

3 3

RE: [ros-diffs] [jimtabor] 20610: Revert, thx Thomas, wasnt sure.
by Murphy, Ged (Bolton) 06 Jan '06

06 Jan '06

Do those debug prints really need to be DPRINT1's ?? -----Original Message----- From: jimtabor(a)svn.reactos.org [mailto:jimtabor@svn.reactos.org] Sent: 06 January 2006 14:24 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [jimtabor] 20610: Revert, thx Thomas, wasnt sure. Revert, thx Thomas, wasnt sure. Modified: trunk/reactos/subsys/win32k/ntuser/menu.c _____ Modified: trunk/reactos/subsys/win32k/ntuser/menu.c --- trunk/reactos/subsys/win32k/ntuser/menu.c 2006-01-06 13:57:38 UTC (rev 20609) +++ trunk/reactos/subsys/win32k/ntuser/menu.c 2006-01-06 14:23:26 UTC (rev 20610) @@ -33,7 +33,7 @@ #define NDEBUG #include <debug.h> -extern PMENU_OBJECT FASTCALL +PMENU_OBJECT FASTCALL IntGetSystemMenu(PWINDOW_OBJECT Window, BOOL bRevert, BOOL RetMenu); @@ -1659,7 +1659,7 @@ MENUBARINFO kmbi; DECLARE_RETURN(BOOL); - DPRINT("Enter NtUserGetMenuBarInfo\n"); + DPRINT1("Enter NtUserGetMenuBarInfo\n"); UserEnterShared(); if (!(WindowObject = UserGetWindowObject(hwnd))) @@ -1849,7 +1849,7 @@ RETURN(Res); CLEANUP: - DPRINT("Leave NtUserGetMenuBarInfo, ret=%i\n",_ret_); + DPRINT1("Leave NtUserGetMenuBarInfo, ret=%i\n",_ret_); UserLeave(); END_CLEANUP; } @@ -1887,7 +1887,7 @@ PMENU_ITEM MenuItem; DECLARE_RETURN(BOOL); - DPRINT("Enter NtUserGetMenuItemRect\n"); + DPRINT1("Enter NtUserGetMenuItemRect\n"); UserEnterShared(); if (!(Menu = UserGetMenuObject(hMenu))) @@ -1923,7 +1923,7 @@ RETURN( TRUE); CLEANUP: - DPRINT("Leave NtUserGetMenuItemRect, ret=%i\n",_ret_); + DPRINT1("Leave NtUserGetMenuItemRect, ret=%i\n",_ret_); UserLeave(); END_CLEANUP; } ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

Re: [ros-diffs] [jimtabor] 20609: Should have placed extern in there.
by Thomas Weidenmueller 06 Jan '06

06 Jan '06

jimtabor(a)svn.reactos.org wrote: > Should have placed extern in there. > > Modified: trunk/reactos/subsys/win32k/ntuser/menu.c > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/subsys/win32k/ntuser/menu.c* > > --- trunk/reactos/subsys/win32k/ntuser/menu.c 2006-01-06 11:58:17 UTC (rev 20608) > +++ trunk/reactos/subsys/win32k/ntuser/menu.c 2006-01-06 13:57:38 UTC (rev 20609) > @@ -33,7 +33,7 @@ > > #define NDEBUG > #include <debug.h> > > > -PMENU_OBJECT FASTCALL > > +extern PMENU_OBJECT FASTCALL > > IntGetSystemMenu(PWINDOW_OBJECT Window, BOOL bRevert, BOOL RetMenu); > > > 'extern' for forward declarations of functions is obsolete. The standards don't require it. - Thomas

1 0

Re: [ros-svn] [ion] 20580: - New ERESOURCE implementation: fixes the return value of some functions (VOID vs NTSTATUS, USHORT vs ULONG), as well as optimized the code loops and general structure of the code. Additionnaly, functions do not simply call other functions with similar names; the exact implementation of each function has now been properly separated (see the DDK for more information on this) to have the most optimized scenarios.
by Hartmut Birr 05 Jan '06

05 Jan '06

ion(a)svn.reactos.org wrote: > - New ERESOURCE implementation: fixes the return value of some functions (VOID vs NTSTATUS, USHORT vs ULONG), as well as optimized the code loops and general structure of the code. Additionnaly, functions do not simply call other functions with similar names; the exact implementation of each function has now been properly separated (see the DDK for more information on this) to have the most optimized scenarios. > - Also, the spinlock is not actually acquired on non-SMP builds; instead, interrupts are blocked and unblocked for acquire/release, this optimizes locking. > - Added many asserts and bugcheck scenarios. > - Added thread priority boosting. > - Added some debugging helpers and deadlock detection. > - Added RESOURCE_NOT_OWNED bugcehck message. > * Thanks again to Waxdragon (Andrew) for testing this build. It seems, that your implementation is broken. On a non SMP machine during 'make clean' on the ros source: KeBugCheckEx at ./ntoskrnl/ex/resource.c:1847 A problem has been detected and ReactOS has been shut down to prevent damage to your computer. Technical information: *** STOP: 0x000000E3 (0x81a5eb0c,0x81a55c70,0x00000000,0x00000002) Frames: <ntoskrnl.exe:2599 (./ntoskrnl/ke/bug.c:483 (KeBugCheckEx))> <ntoskrnl.exe:27ac4 (./ntoskrnl/ex/resource.c:1843 (ExReleaseResourceLite))> <vfatfs.sys:3ee2 (drivers/fs/vfat/dir.c:471 (DoQuery))> <vfatfs.sys:416f (drivers/fs/vfat/dir.c:486 (VfatDirectoryControl))> <vfatfs.sys:dc06 (drivers/fs/vfat/misc.c:119 (VfatDispatchRequest))> <vfatfs.sys:dd8f (drivers/fs/vfat/misc.c:167 (VfatBuildRequest))> <ntoskrnl.exe:4369b (./ntoskrnl/io/irp.c:1076 (IofCallDriver))> <ntoskrnl.exe:53a3a (ntoskrnl/io/file.c:2607 (NtQueryDirectoryFile))> <ntoskrnl.exe:a0daa (ntoskrnl\ke\i386\syscall.S:372 (KiSystemService))> <kernel32.dll:9b22 (./lib/kernel32/file/find.c:143 (InternalFindNextFile))> The same on a SMP machine (no back trace available): KeBugCheckEx at ./ntoskrnl/ex/resource.c:1868 (./ntoskrnl/mm/mm.c:292 CPU0) Page fault at high IRQL was 2, address c2410 A problem has been detected and ReactOS has been shut down to prevent damage to your computer. Technical information: *** STOP: 0x000000E3 (0x8131d0d8,0x81620d68,0x81376640,0x00000002) - Hartmut

2 4

Project Status Report
by Steven Edwards 05 Jan '06

05 Jan '06

Hi, So here is the first in what I hope to be quarterly reports. In future reports I will provide more detail such as charts and graphs if I feel so inclined. Depending on how much goes on in a period we may make it every 6 months instead of every 3 months. Basically this report just covers what has gone on during the 0.2.x development and where we plan on going. Developers that I spoke with in private or that I have worked with are listed here as to the project I know you have or are working on. If your not listed please add yourself to http://www.reactos.org/wiki/index.php/People_of_ReactOS Also could someone convert this from Microsoft Word to OpenOffice and or PDF and check the formatting of the doc? I lack good artistic skill so feel free to make corrections before spamming it anywhere. I think I spelled all the names right. Sorry if I left off any accent. Also as a final note if I left of your project or did not give it the coverage you feel it deserves do not take it personal. We are working on a massive project and I have not even talked to all of the people with commit access let alone know all of the things people are working on. I have tried to keep the information here as general as possible except where I feel that the public may have interest. Thanks -- Steven Edwards - ReactOS and Wine developer "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

4 3

servman.rc
by Alex Buell 05 Jan '06

05 Jan '06

Please remember that some of us don't use Windows ;o) make[1]: Entering directory `/home/alex/src/OpSys/reactos' [CC] subsys/system/servman/servman.c [WRC] obj-i386/subsys/system/servman/servman.coff subsys/system/servman/servman.rc:15:17: En.rc: No such file or directory make[1]: *** [obj-i386/subsys/system/servman/servman.coff] Error 1 make[1]: Leaving directory `/home/alex/src/OpSys/reactos' -- http://www.munted.org.uk Anyone that thinks an imaginary deity is going to protect them against earthquakes and hurricanes needs psychiatric help.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev