Ros-dev

ros-dev@reactos.org

1 participants
5791 discussions

Re: [ros-diffs] [cwittich] 19291: implemented CreateServiceA
by Thomas Weidenmueller 17 Nov '05

17 Nov '05

cwittich(a)svn.reactos.com wrote: > implemented CreateServiceA This implementation theoretically is wrong, at least in windows this is also done using RPC (see the .idl file, there should be methods for ansi and unicode). - Thomas

2 1

0.3 release plan - Again
by Steven Edwards 17 Nov '05

17 Nov '05

Hi All, My how history repeats itself. I would like to call for a feature freeze on Jan 1st with the approval of the Testing Coordinator. Although we have not had that many releases of the 0.2.x line I feel enough has changed to and that we need to bump to 0.3. Lets review some history 0.1.x - winhello 0.2.x - explorer and a few wine dlls 0.3.x - OpenGL games, Firefox, Mirc, OpenOffice, third party drivers, start of PnP, USB, Xbox support, Initial DirectX Support, etc For the record we really did not plan on all of this other stuff for 0.3 and a year ago most of us would have been happy with just Firefox and Mirc working under VMware and Qemu. In fact we were planning on that work for the 0.3 line to be included in 0.4 release. Which is great! I am happy to see that we have gone much further beyond our once limited goals. What I propose now is that everyone that has a open project try to either get it to a Alpha state by Jan 1st or admit that it just wont be ready for 0.3 and accept that. Current major works in progress: DirectX - GreatLord USB - Fireball PnP - hpoussin Ws2 - Ionescu msvcDDK - sedwards Can we get all of these in for 0.3? Ws2 is a showstopper for 0.3, USB at least for the Xbox in my mind is a showstopper as well. PnP would be really, really nice to have but if its not ready I think we should ship anyway and plan on doing a short run to 0.4 before we fully support PnP. DirectX I have no idea how close it is to working and my current pet project for MSVC/DDK and rbuild is not a feature. I would like to be able to build ReactOS with our DDK under msvc in the hopes of getting more developers to join the project and improve the quality of our code but I am happy to admit this is not a priority. So what does everyone think? Can we shot for a feeze for Jan 1st? How does Feb 1st sound for a release? Thanks Steven __________________________________ Yahoo! Mail - PC Magazine Editors' Choice 2005 http://mail.yahoo.com

8 8

[hpoussin] 19288: Second attempt to have a workingkeyboard and mouse at third reboot
by Ge van Geldorp 17 Nov '05

17 Nov '05

> From: hpoussin(a)svn.reactos.com > > Second attempt to have a working keyboard and mouse at third > reboot May fix bug 1018 It does. Thanks! GvG

1 0

RE: [ros-dev] 0.3 release plan - Again
by Murphy, Ged (Bolton) 17 Nov '05

17 Nov '05

> -----Original Message----- > From: Steven Edwards [mailto:steven_ed4153@yahoo.com] > Sent: 17 November 2005 04:35 > To: ros-dev(a)reactos.org > Subject: [ros-dev] 0.3 release plan - Again > > > So what does everyone think? Can we shot for a feeze for Jan > 1st? How does Feb 1st sound for a release? Considering the state of HEAD at the moment, I think we should be going for a feature freeze much sooner than this. 1st of Jan is quite a long way off and it would be difficult to make any headway, especially on networking which is our showstopper, until this is sorted. IMO, we should be calling for a feature freeze as soon as the TC is elected. If that feature freeze gets HEAD back in stable and usable condition quickly, and with a bit of collaboration on networking, we could even aim at going for a Christmas release for 0.3.0 ?? If we are only stating networking must run for qemu and vmware, then I don't think we are that far off. It's been running in these two environments, intermittently, for quite some time now. Stable networking on real hardware could be kept for the 0.3.1 release. -- my glass is half full ;) Ged. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

RE: [ros-dev] RE: [ros-diffs] [cwittich] 19266: fix memory leak i n case of erro r
by Murphy, Ged (Bolton) 16 Nov '05

16 Nov '05

sorry ignore, I didn't read the full function. -----Original Message----- From: Murphy, Ged (Bolton) [mailto:MurphyG@cmpbatteries.co.uk] Sent: 16 November 2005 15:57 To: 'ros-dev(a)reactos.org' Subject: [ros-dev] RE: [ros-diffs] [cwittich] 19266: fix memory leak in case of erro r There is another here : HardwareIdW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); if (!HardwareIdW) { SetLastError(ERROR_GEN_FAILURE); return FALSE; } -----Original Message----- From: cwittich(a)svn.reactos.com [mailto:cwittich@svn.reactos.com] Sent: 16 November 2005 15:54 To: ros-diffs(a)reactos.com Subject: [ros-diffs] [cwittich] 19266: fix memory leak in case of error fix memory leak in case of error Modified: trunk/reactos/lib/newdev/newdev.c _____ Modified: trunk/reactos/lib/newdev/newdev.c --- trunk/reactos/lib/newdev/newdev.c 2005-11-16 15:14:31 UTC (rev 19265) +++ trunk/reactos/lib/newdev/newdev.c 2005-11-16 15:53:16 UTC (rev 19266) @@ -66,6 +66,7 @@ FullInfPathW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); if (!FullInfPathW) { + HeapFree(GetProcessHeap(), 0, HardwareIdW); SetLastError(ERROR_GEN_FAILURE); return FALSE; } ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

RE: [ros-diffs] [cwittich] 19266: fix memory leak in case of erro r
by Murphy, Ged (Bolton) 16 Nov '05

16 Nov '05

There is another here : HardwareIdW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); if (!HardwareIdW) { SetLastError(ERROR_GEN_FAILURE); return FALSE; } -----Original Message----- From: cwittich(a)svn.reactos.com [mailto:cwittich@svn.reactos.com] Sent: 16 November 2005 15:54 To: ros-diffs(a)reactos.com Subject: [ros-diffs] [cwittich] 19266: fix memory leak in case of error fix memory leak in case of error Modified: trunk/reactos/lib/newdev/newdev.c _____ Modified: trunk/reactos/lib/newdev/newdev.c --- trunk/reactos/lib/newdev/newdev.c 2005-11-16 15:14:31 UTC (rev 19265) +++ trunk/reactos/lib/newdev/newdev.c 2005-11-16 15:53:16 UTC (rev 19266) @@ -66,6 +66,7 @@ FullInfPathW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); if (!FullInfPathW) { + HeapFree(GetProcessHeap(), 0, HardwareIdW); SetLastError(ERROR_GEN_FAILURE); return FALSE; } ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

Re: [ros-svn] [cwittich] 19264: added UpdateDriverForPlugAndPlayDevicesA (untested)
by Thomas Weidenmueller 16 Nov '05

16 Nov '05

cwittich(a)svn.reactos.com wrote: > added UpdateDriverForPlugAndPlayDevicesA (untested) It leaks memory in some error cases. Also, ERROR_GEN_FAILURE doesn't look like the correct error code, although i might be wrong. Maybe it'd be ok if the buffers are on the stack, that would save memory allocations. - Thomas

1 0

RE: [ros-dev] Setup for Net Card
by James Tabor 16 Nov '05

16 Nov '05

Hi Herve! It's coming along nicely. I wanted to paste it but you have left the channel. Thanks, James (subsys/csrss/win32csr/conio.c:1079) Console_Api Ctrl-C FIXME: CopyImage doesn't support IMAGE_ICON correctly! (lib/ntdll/ldr/utils.c:1190) LdrGetExportByName(): failed to find mxdMessage (lib/ntdll/ldr/utils.c:2015) Failed to create or open dll section of 'msacm.drv' (Status c0000135) (lib/ntdll/ldr/utils.c:2015) Failed to create or open dll section of 'midimap.dr v' (Status c0000135) (lib/setupapi/parser.c:1119) D:\6102v25VIA\FETNDIS.inf Net 2 00000000 (lib/setupapi/parser.c:1166) L"D:\\6102v25VIA\\FETNDIS.inf" -> 00533c90 (lib/setupapi/parser.c:1531) (00533c90,L"Version",L"ClassGUID"): returning 4 (lib/setupapi/parser.c:1531) (00533c90,L"Version",L"Class"): returning 3 (lib/setupapi/parser.c:1104) Returning 1 (lib/setupapi/parser.c:1433) (00533c90,L"Manuf",(null)): returning 2/0 (lib/setupapi/parser.c:1706) context 00533c90/00533c90/2/0 index 2 returning "PC I\\VEN_1106&DEV_3065&SUBSYS_01021106" (lib/setupapi/parser.c:1706) context 00533c90/00533c90/2/1 index 2 returning "PC I\\VEN_1106&DEV_3043&SUBSYS_01001106" (lib/setupapi/devinst.c:1663) (null) L"PCI" 00000000 0x00000006 00000000 (null) 00000000 (lib/setupapi/devinst.c:623) 00000000 00000000 <NULL> 00000000 (lib/setupapi/devinst.c:1693) : flag DIGCF_PRESENT ignored (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3065&SUBSYS_734C1462&REV_ 74\1&644af68e&12' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3059&SUBSYS_73401462&REV_ 50\1&644af68e&B1' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_0571&SUBSYS_73401462&REV_ 06\1&644af68e&31' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3177&SUBSYS_31771106&REV_ 00\1&644af68e&11' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3104&SUBSYS_73401462&REV_ 82\1&644af68e&70' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3038&SUBSYS_30381106&REV_ 80\1&644af68e&50' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3038&SUBSYS_30381106&REV_ 80\1&644af68e&30' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3038&SUBSYS_30381106&REV_ 80\1&644af68e&10' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_10EC&DEV_8029&SUBSYS_802910EC&REV_ 00\1&644af68e&05' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_B198&SUBSYS_00000000&REV_ 00\1&644af68e&01' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3205&SUBSYS_32051106&REV_ 00\1&644af68e&00' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_7205&SUBSYS_73481462&REV_ 01\2&ddb52e18&00' to device info set 00533c10 (lib/setupapi/devinst.c:670) 00533c10, 0x00000000, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000001, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000002, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000003, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000004, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000005, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000006, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000007, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000008, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000009, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x0000000a, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x0000000b, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x0000000c, 0052fc90 (lib/setupapi/devinst.c:1902) 00533c10 (lib/setupapi/devinst.c:1915) Returning 1 (lib/setupapi/devinst.c:1663) (null) L"PCI" 00000000 0x00000006 00000000 (null) 00000000 (lib/setupapi/devinst.c:623) 00000000 00000000 <NULL> 00000000 (lib/setupapi/devinst.c:1693) : flag DIGCF_PRESENT ignored (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3065&SUBSYS_734C1462&REV_ 74\1&644af68e&12' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3059&SUBSYS_73401462&REV_ 50\1&644af68e&B1' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_0571&SUBSYS_73401462&REV_ 06\1&644af68e&31' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3177&SUBSYS_31771106&REV_ 00\1&644af68e&11' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3104&SUBSYS_73401462&REV_ 82\1&644af68e&70' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3038&SUBSYS_30381106&REV_ 80\1&644af68e&50' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3038&SUBSYS_30381106&REV_ 80\1&644af68e&30' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3038&SUBSYS_30381106&REV_ 80\1&644af68e&10' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_10EC&DEV_8029&SUBSYS_802910EC&REV_ 00\1&644af68e&05' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_B198&SUBSYS_00000000&REV_ 00\1&644af68e&01' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_3205&SUBSYS_32051106&REV_ 00\1&644af68e&00' to device info set 00533c10 (lib/setupapi/devinst.c:1221) Adding 'PCI\VEN_1106&DEV_7205&SUBSYS_73481462&REV_ 01\2&ddb52e18&00' to device info set 00533c10 (lib/setupapi/devinst.c:670) 00533c10, 0x00000000, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000001, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000002, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000003, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000004, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000005, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000006, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000007, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000008, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x00000009, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x0000000a, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x0000000b, 0052fc90 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 00000000 0 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 00531d80 0 0052fc38 (lib/setupapi/devinst.c:2332) Returning 0 (lib/setupapi/devinst.c:2079) 00533c10 0052fc90 1 0052fc88 0053a170 146 0052fc80 (lib/setupapi/devinst.c:2154) 00533c10 0052fc90 1 0052fc40 0053a210 292 0052fc38 (lib/setupapi/devinst.c:2332) Returning 1 (lib/setupapi/devinst.c:670) 00533c10, 0x0000000c, 0052fc90 (lib/setupapi/devinst.c:1902) 00533c10 (lib/setupapi/devinst.c:1915) Returning 1 (lib/setupapi/stubs.c:70) stub: source "D:\\6102v25VIA\\FETNDIS.inf" location "D :\\6102v25VIA\\" ... (lib/rpcrt4/ndr_marshall.c:499) sized string format=68 (lib/rpcrt4/ndr_marshall.c:446) sized string format=68 (lib/rpcrt4/ndr_marshall.c:563) sized string format=68 (lib/rtl/exception.c:29) RtlRaiseException(Status 0052fb98) (lib/rtl/exception.c:36) ExceptionAddress 7c801fd1 (ntoskrnl/ke/exception.c:94) KiRaiseException Unhandled exception ExceptionCode: 80000100 Address: 7c801fd1 C:\ReactOS\system32\KERNEL32.dll lib/kernel32/except/except.c:268 (RaiseException) CS:EIP 1b:7c801fd1 DS 23 ES 23 FS 3b GS 0 EAX: 0052f8a8 EBX: 0000000c ECX: 0052f638 EDX: 00000023 EBP: 0052fbf0 ESI: 0040900c ESP: 0052fb88 EDI: 0052fc62 EFLAGS: 00000212 Frames: 76660000+21555 C:\ReactOS\system32\SETUPAPI.dll lib/setupapi/setupapi.stubs.c:16 (__wine_spec_unimplemented_stub) 76660000+21f68 C:\ReactOS\system32\SETUPAPI.dll lib/setupapi/setupapi.stubs.c:112 (__wine_stub_setupapi_dll_154) 400000+1330 D:\6102v25VIA\winsetup\w2kxp\w2ksetup.EXE 7c800000+31095 C:\ReactOS\system32\KERNEL32.dll lib/kernel32/process/create.c:68 (BaseProcessStartup) (subsys/win32k/ntuser/class.c:125) Failed to lookup class atom! (subsys/win32k/ntuser/class.c:125) Failed to lookup class atom! (subsys/win32k/ntuser/class.c:125) Failed to lookup class atom! (subsys/win32k/ntuser/class.c:125) Failed to lookup class atom! (subsys/win32k/ntuser/class.c:125) Failed to lookup class atom! (subsys/win32k/ntuser/class.c:125) Failed to lookup class atom!

2 3

RE: [ros-diffs] [cwittich] 19254: add a check for SPDRP_CONFIGFLAGSwhich is not working yet
by Casper Hornstrup 15 Nov '05

15 Nov '05

~1700 lines to add a check? In the future, please do reformatting in its own patch without semantic changes. This patch would require an hour or more to review if anyone dared to do it and even if someone did, that person would have be superhuman to be able to keep track of that many lines of information. The risk of introducing a bug is higher with some types of operations than others. Formatting is a relatively safe operation while semantic changes to complex code is a highly risky operation. This means that reviewing a formatting patch is not as important as reviewing a patch with semantic changes to complex code (and thus it doesn't hurt so much if a formatting change is large). When mixing safe and unsafe operations, the overall risk of a introducing a bug in a given patch is the same as if the changes were spread over several patches. However, the risk of the individual patch is equal to risk of the most risky operation in the patch. So if a 1 line highly risky change is hidden in a 1700 line otherwise safe patch, then the overall risk for the whole patch is highly risky. It may not seem important to have only a few bugs in releases now. We can always use the excuse that ReactOS is alpha software. However, if we ever want to have an 1.x release which is more than a toy-OS, then we have to learn to build better software. And I would prefer that we learn it before 1 day before the deadline for 1.0.0 since that might give us some years to get really good at it. I've written several school papers the night before the deadline, and they were never any good ;-( Another side effect of starting early is that some might even be able to use ReactOS before 1.0.0. Casper

2 4

GDI32.DLL exports
by tobitosso 15 Nov '05

15 Nov '05

I used Depends.exe and examined gdi32.dll. I found out that at least there functions are missing in the gdi32.dll api status at svn.reactos.com: AnimatePalette Arc ArcTo BitBlt cGetTTFFromFOT CombineRgn CombineTransform CreateBitmap CreateBitmapIndirect CreateCompatibleBitmap CreateCompatibleDC CreateDiscardableBitmap CreateEllipticRgn CreateEllipticRgnIndirect CreateHalftonePalette CreateHatchBrush CreatePalette CreatePatternBrush CreatePen CreatePenIndirect CreatePolygonRgn CreatePolyPolygonRgn CreateRectRgn CreateRectRgnIndirect CreateRoundRectRgn CreateSolidBrush DdEntry0 DdEntry1 DdEntry10 --------------------------------- Gesendet von Yahoo! Mail - Jetzt mit 1GB kostenlosem Speicher

2 3

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev