> -----Original Message-----
> From: Steven Edwards [mailto:steven_ed4153@yahoo.com]
> Sent: 17 November 2005 04:35
> To: ros-dev(a)reactos.org
> Subject: [ros-dev] 0.3 release plan - Again
>
>
> So what does everyone think? Can we shot for a feeze for Jan
> 1st? How does Feb 1st sound for a release?
Considering the state of HEAD at the moment, I think we should be going for
a feature freeze much sooner than this. 1st of Jan is quite a long way off
and it would be difficult to make any headway, especially on networking
which is our showstopper, until this is sorted.
IMO, we should be calling for a feature freeze as soon as the TC is elected.
If that feature freeze gets HEAD back in stable and usable condition
quickly, and with a bit of collaboration on networking, we could even aim at
going for a Christmas release for 0.3.0 ??
If we are only stating networking must run for qemu and vmware, then I don't
think we are that far off. It's been running in these two environments,
intermittently, for quite some time now.
Stable networking on real hardware could be kept for the 0.3.1 release.
-- my glass is half full ;)
Ged.
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
sorry ignore, I didn't read the full function.
-----Original Message-----
From: Murphy, Ged (Bolton) [mailto:MurphyG@cmpbatteries.co.uk]
Sent: 16 November 2005 15:57
To: 'ros-dev(a)reactos.org'
Subject: [ros-dev] RE: [ros-diffs] [cwittich] 19266: fix memory leak in case
of erro r
There is another here :
HardwareIdW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
if (!HardwareIdW)
{
SetLastError(ERROR_GEN_FAILURE);
return FALSE;
}
-----Original Message-----
From: cwittich(a)svn.reactos.com [mailto:cwittich@svn.reactos.com]
Sent: 16 November 2005 15:54
To: ros-diffs(a)reactos.com
Subject: [ros-diffs] [cwittich] 19266: fix memory leak in case of error
fix memory leak in case of error
Modified: trunk/reactos/lib/newdev/newdev.c
_____
Modified: trunk/reactos/lib/newdev/newdev.c
--- trunk/reactos/lib/newdev/newdev.c 2005-11-16 15:14:31 UTC (rev 19265)
+++ trunk/reactos/lib/newdev/newdev.c 2005-11-16 15:53:16 UTC (rev 19266)
@@ -66,6 +66,7 @@
FullInfPathW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
if (!FullInfPathW)
{
+ HeapFree(GetProcessHeap(), 0, HardwareIdW);
SetLastError(ERROR_GEN_FAILURE);
return FALSE;
}
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
There is another here :
HardwareIdW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
if (!HardwareIdW)
{
SetLastError(ERROR_GEN_FAILURE);
return FALSE;
}
-----Original Message-----
From: cwittich(a)svn.reactos.com [mailto:cwittich@svn.reactos.com]
Sent: 16 November 2005 15:54
To: ros-diffs(a)reactos.com
Subject: [ros-diffs] [cwittich] 19266: fix memory leak in case of error
fix memory leak in case of error
Modified: trunk/reactos/lib/newdev/newdev.c
_____
Modified: trunk/reactos/lib/newdev/newdev.c
--- trunk/reactos/lib/newdev/newdev.c 2005-11-16 15:14:31 UTC (rev 19265)
+++ trunk/reactos/lib/newdev/newdev.c 2005-11-16 15:53:16 UTC (rev 19266)
@@ -66,6 +66,7 @@
FullInfPathW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
if (!FullInfPathW)
{
+ HeapFree(GetProcessHeap(), 0, HardwareIdW);
SetLastError(ERROR_GEN_FAILURE);
return FALSE;
}
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
cwittich(a)svn.reactos.com wrote:
> added UpdateDriverForPlugAndPlayDevicesA (untested)
It leaks memory in some error cases. Also, ERROR_GEN_FAILURE doesn't
look like the correct error code, although i might be wrong. Maybe it'd
be ok if the buffers are on the stack, that would save memory allocations.
- Thomas
~1700 lines to add a check? In the future, please do reformatting in its own patch without semantic changes. This patch would
require an hour or more to review if anyone dared to do it and even if someone did, that person would have be superhuman to be able
to keep track of that many lines of information.
The risk of introducing a bug is higher with some types of operations than others. Formatting is a relatively safe operation while
semantic changes to complex code is a highly risky operation. This means that reviewing a formatting patch is not as important as
reviewing a patch with semantic changes to complex code (and thus it doesn't hurt so much if a formatting change is large). When
mixing safe and unsafe operations, the overall risk of a introducing a bug in a given patch is the same as if the changes were
spread over several patches. However, the risk of the individual patch is equal to risk of the most risky operation in the patch. So
if a 1 line highly risky change is hidden in a 1700 line otherwise safe patch, then the overall risk for the whole patch is highly
risky.
It may not seem important to have only a few bugs in releases now. We can always use the excuse that ReactOS is alpha software.
However, if we ever want to have an 1.x release which is more than a toy-OS, then we have to learn to build better software. And I
would prefer that we learn it before 1 day before the deadline for 1.0.0 since that might give us some years to get really good at
it. I've written several school papers the night before the deadline, and they were never any good ;-( Another side effect of
starting early is that some might even be able to use ReactOS before 1.0.0.
Casper
I used Depends.exe and examined gdi32.dll. I found out that at least there functions are missing in the gdi32.dll api status at svn.reactos.com:
AnimatePalette
Arc
ArcTo
BitBlt
cGetTTFFromFOT
CombineRgn
CombineTransform
CreateBitmap
CreateBitmapIndirect
CreateCompatibleBitmap
CreateCompatibleDC
CreateDiscardableBitmap
CreateEllipticRgn
CreateEllipticRgnIndirect
CreateHalftonePalette
CreateHatchBrush
CreatePalette
CreatePatternBrush
CreatePen
CreatePenIndirect
CreatePolygonRgn
CreatePolyPolygonRgn
CreateRectRgn
CreateRectRgnIndirect
CreateRoundRectRgn
CreateSolidBrush
DdEntry0
DdEntry1
DdEntry10
---------------------------------
Gesendet von Yahoo! Mail - Jetzt mit 1GB kostenlosem Speicher
> > It's been 7 days since the TC position was put up for
> discussion, thus
> > I have created the poll for voting to commence.
> > _http://www.reactos.org/forum/viewtopic.php?t=1140_
> >
> > Anyone wanna take a bet on the outcome ;)
> >
> I think the only bet that could be placed would be on whether
> it's going
> to be unanimous :P
That's what I was referring too, and I know what my money would be on ;)
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
It's been 7 days since the TC position was put up for discussion, thus I
have created the poll for voting to commence.
http://www.reactos.org/forum/viewtopic.php?t=1140
<http://www.reactos.org/forum/viewtopic.php?t=1140>
Anyone wanna take a bet on the outcome ;)
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com