Ros-dev

ros-dev@reactos.org

5788 discussions

Start a nNew thread

ReactOS trademark and logo violation

by Alexander Rechitskiy

9 years, 7 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 66101: [CDMAKE] It's totally pointless to nullify after calloc

by Timo Kreuzer

This code change doesn't help to make the code more readable. Am 28.01.2015 um 21:41 schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Wed Jan 28 20:41:23 2015 > New Revision: 66101 > > URL: http://svn.reactos.org/svn/reactos?rev=66101&view=rev > Log: > [CDMAKE] > It's totally pointless to nullify after calloc > > Modified: > trunk/reactos/tools/cdmake/dirhash.c > > Modified: trunk/reactos/tools/cdmake/dirhash.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/dirhash.c?rev… > ============================================================================== > --- trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] (original) > +++ trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] Wed Jan 28 20:41:23 2015 > @@ -137,8 +137,6 @@ > free(parentcase); > > de = calloc(1, sizeof(*de)); > - de->head = NULL; > - de->child = NULL; > de->parent = parent_de; > de->normalized_name = strdup(targetnorm); > de->case_name = strdup(chop_filename(casename)); > > >

9 years, 7 months

Re: [ros-dev] [ros-diffs] [hbelusca] 65678: [MSGINA]: Update the function names of stubs, with (in comments) the number of parameters they take. See CORE-8459 for more information. CORE-8459 #resolve #comment Fixed in r65678.

by Thomas Faber

On 2014-12-15 22:07, hbelusca(a)svn.reactos.org wrote: > +1 stub -noname ShellGetUserList ; (long long long) For future reference, you might as well write this kind of thing as 1 stdcall -stub -noname ShellGetUserList(long long long) Then spec2def will create a stub that uses the correct calling convention and also prints out the arguments. Plus it's easier to change to the real thing when someone implements it ;)

9 years, 7 months

Re: [ros-dev] [ros-diffs] [jimtabor] 66085: [Win32ss] - Fix window from point so it handles disabled windows correctly. - Cleanup processing mouse routine. - See CORE-7447.

by Thomas Faber

On 2015-01-25 16:57, jimtabor(a)svn.reactos.org wrote: > - if (*HitTest == HTNOWHERE) *HitTest = HTCLIENT; > + if (*HitTest == HTNOWHERE && pwndChild == NULL) *HitTest = HTCLIENT; pwndChild cannot be non-NULL here.

9 years, 7 months

Re: [ros-dev] [ros-diffs] [hbelusca] 66083: [CDMAKE] - Disable unused dir_hash_next_dir function and corresponding target_dir_traversal structure definition. - Be really sure de->head and de->child are initialized at NULL. ...

by Pierre Schweitzer

On 24/01/2015 01:15, hbelusca(a)svn.reactos.org wrote: > ============================================================================== > --- trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] (original) > +++ trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] Sat Jan 24 00:15:08 2015 > @@ -138,12 +138,14 @@ > hashcode = djb_hash(targetnorm); > de = calloc(1, sizeof(*de)); > de->parent = parent_de; > + de->head = NULL; > + de->child = NULL; de has been allocated few lines upper with calloc. head & child CANNOT be different from NULL. This is non sense. > @@ -170,6 +172,7 @@ > tf->target_name = strdup(chop_filename(target)); > } > > +#if 0 > static struct target_dir_entry * > dir_hash_next_dir(struct target_dir_hash *dh, struct target_dir_traversal *t) > { > @@ -200,13 +203,13 @@ > return t->it; > } > } > +#endif Once again, this is trunk, not your working copy. If you 0 out, please add a comment explaining it's just unused and not buggy. And actually, because it's trunk & unusued, it would be better just to remove them. svn history can help finding them back if really needed. > ============================================================================== > --- trunk/reactos/tools/cdmake/dirhash.h [iso-8859-1] (original) > +++ trunk/reactos/tools/cdmake/dirhash.h [iso-8859-1] Sat Jan 24 00:15:08 2015 > @@ -26,11 +26,13 @@ > struct target_dir_entry root; > }; > > +#if 0 > struct target_dir_traversal > { > struct target_dir_entry *it; > int i; > }; > +#endif See comment above. Cheers, -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

9 years, 8 months

New Flyers for FOSDEM required

by Colin Finck

Hi all, We're still preparing merchandising products for FOSDEM, and flyers are probably most important here and still doable in time. Can somebody please take the template from https://svn.reactos.org/press-media/trunk/Events/2009%20-%20FOSDEM/Flyer/ and alter it a bit to reflect current ReactOS state? The best would be a flyer not including a certain ReactOS version number, so that it is universally usable. If you don't have InDesign to modify the file, just send me the modified text here. Thanks! Colin

9 years, 8 months

Security issue on ReactOS.org website

by Pierre Schweitzer

Dear all, Just to make sure you read it: https://www.reactos.org/node/928 The SVN accounts are not affected. Cheers, -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

9 years, 8 months

ReactOS Hybrid CDs

by Hermès BÉLUSCA - MAÏTO

Hi all ! Our build system is now able to build so-called hybrid cds . What are they? They are boot+live-cd all-in-one. In addition it is now possible with them to load the live cd as a ramdisk. For that the contents of the bootcd is placed into a bootcd/ directory, the contents of the livecd is placed into a livecd/ directory, and the livecd image itself is also included (this is the one that is used for livecd ramdisk). You can notice that makes a lot of redundancy, but its the best thing I could do for now. The best way would be to build some kind of flat HDD image that is used as the livecd ramdisk (and never use the livecd with reads from the cd as we currently do) . Anyways. So here it is ! In addition you can add extra custom files via the build process: just place your files into a <your_ROS_source>/modules/hybridcd_extras/ directory (this directory doesnt exist by default, its up to you to create and populate it; I think its better to create a directory somewhere else and then add a symlink hybridcd_extras to this directory, inside the modules/ directory, as you already do with rosapps and rostests). After that you configure a build, build the host-tools and then ninja hybridcd !! If then you need to change the custom files, do it and then reconfigure a build with the cmake . command (when youre inside <your_ROS_builddir>/reactos/ ) so that cmake can build again the list of files to be included into the hybridcd. See https://jira.reactos.org/browse/CORE-9069 for few more details. Cheers, Hermès.

9 years, 8 months

Revision 66026 - Directory Listing Modified Sun Jan 11 14:38:26 2015 UTC (3 days, 7 hours ago) by dreimer [RAPPS] Database Update. This fixes the now dead LibreOffice link, too. I completely skipped MirandaIM because they suck by deciding to do the same shit, Filezilla did. SF Malware "optimized" installer!

by Javier Agustìn Fernàndez Arroyo

Hello Daniel, There are links to filezilla which doesnt lead to the malware installer shit. This link ends with ".../download?nowrap" maybe adding this works for MirandaIM too http://sourceforge.net/projects/filezilla/files/FileZilla_Client/3.10.0.1/F…

9 years, 8 months

Installing ReactOS to a folder

by João Jerónimo

Hello, Is there a build command to install ReactOS to a folder. Something equivalent to "make install" of good old RBuild days? I used to install ReactOS on real hardware this way, because it allowed me to have more control over the install process (aka control it completely). Thanks, João Jerónimo

9 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev