Ros-dev

ros-dev@reactos.org

5791 discussions

Re: [ros-dev] [ros-diffs] [hbelusca] 66144: [FREELDR] - Fix date format in CHANGELOG (that uses that #$@! of US format) - Diverse code style changes (whitespace, extra braces, C++ to C-style comments, ...)
by Aleksey Bragin 03 Feb '15

03 Feb '15

On 01.02.2015 23:22, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Sun Feb 1 20:22:13 2015 > New Revision: 66144 > > URL: http://svn.reactos.org/svn/reactos?rev=66144&view=rev > Log: > [FREELDR] > - Fix date format in CHANGELOG (that uses that #$@! of US format) > - Diverse code style changes (whitespace, extra braces, C++ to C-style comments, ...) > ============================================================================== > --- trunk/reactos/boot/freeldr/freeldr/CHANGELOG [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/CHANGELOG [iso-8859-1] Sun Feb 1 20:22:13 2015 > @@ -1,4 +1,4 @@ > -Changes in v3.0+ (05/01/2015) (hbelusca) > +Changes in v3.0+ (01/05/2015) (hbelusca) Don't make our dear American contributors feel offended! :-) Also there is ISO 8601 standard, you know, the big-endian style YYYY-MM-DD. Regards, Aleksey Bragin

2 1

Re: [ros-dev] [ros-diffs] [hbelusca] 66143: [FREELDR] - Remove an unexisting function declaration. - Move some boot methods back to suitable place. - Whitespace fixes.
by Timo Kreuzer 02 Feb '15

02 Feb '15

Why are you moving a file out of the i386 folder and then add #ifdef _M_IX86 around all the code??? Am 01.02.2015 um 18:49 schrieb hbelusca(a)svn.reactos.org: > --- trunk/reactos/boot/freeldr/freeldr/arch/i386/custom.c [iso-8859-1] (original) > +++ trunk/reactos/boot/freeldr/freeldr/custom.c [iso-8859-1] Sun Feb 1 17:49:11 2015 > @@ -19,6 +19,7 @@ > > #include <freeldr.h> > > +#ifdef _M_IX86 > > const CHAR BootDrivePrompt[] = "Enter the boot drive.\n\nExamples:\nfd0 - first floppy drive\nhd0 - first hard drive\nhd1 - second hard drive\ncd0 - first CD-ROM drive.\n\nBIOS drive numbers may also be used:\n0 - first floppy drive\n0x80 - first hard drive\n0x81 - second hard drive"; > const CHAR BootPartitionPrompt[] = "Enter the boot partition.\n\nEnter 0 for the active (bootable) partition."; > @@ -448,3 +449,5 @@ > DiskStopFloppyMotor(); > Reboot(); > } > + > +#endif // _M_IX86

2 1

Re: [ros-dev] ReactOS trademark and logo violation
by Daniel Reimer 01 Feb '15

01 Feb '15

I hope you are not talking about the ... Right arm? ^^Am 01.02.2015 00:27 schrieb Hermès BÉLUSCA - MAÏTO <hermes.belusca(a)sfr.fr>: > > And after that, people go to #reactos by mistake to ask for Java-related questions... By the way, if one believes Wikipedia, this ReactJS was created in 2013: http://en.wikipedia.org/wiki/ReactJS > > <troll>Now… look carefully at the video around 0:40 up to 0:50… \o ^^ </troll> > > > > De : Ros-dev [mailto:ros-dev-bounces@reactos.org] De la part de Timo Kreuzer > Envoyé : samedi 31 janvier 2015 22:50 > À : ReactOS Development List > Objet : Re: [ros-dev] ReactOS trademark and logo violation > > > > > I agree this is pretty nasty. Too much consonance for me to believe in accidental coincidence. ("ReactJS"? Srsly?) > > Are we going to sue them? > Let's make them PAY! :D > > > Am 31.01.2015 um 20:01 schrieb Alexander Rechitskiy: >> >> I clearly see that ReactOS trademark and logo are violated by Facebooks' ReactJS project >> >> >> >> http://www.youtube.com/watch?v=KVZ-P-ZI6W4 >> >> >> >> -- >> >> Best regards, >> Alexander Rechitskiy >> >> +79286331900 >> >> >> >> >> >> >> _______________________________________________ >> >> Ros-dev mailing list >> >> Ros-dev(a)reactos.org >> >> http://www.reactos.org/mailman/listinfo/ros-dev > >

2 1

ReactOS trademark and logo violation
by Alexander Rechitskiy 31 Jan '15

31 Jan '15

3 2

Re: [ros-dev] [ros-diffs] [pschweitzer] 66101: [CDMAKE] It's totally pointless to nullify after calloc
by Timo Kreuzer 28 Jan '15

28 Jan '15

This code change doesn't help to make the code more readable. Am 28.01.2015 um 21:41 schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Wed Jan 28 20:41:23 2015 > New Revision: 66101 > > URL: http://svn.reactos.org/svn/reactos?rev=66101&view=rev > Log: > [CDMAKE] > It's totally pointless to nullify after calloc > > Modified: > trunk/reactos/tools/cdmake/dirhash.c > > Modified: trunk/reactos/tools/cdmake/dirhash.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/dirhash.c?rev… > ============================================================================== > --- trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] (original) > +++ trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] Wed Jan 28 20:41:23 2015 > @@ -137,8 +137,6 @@ > free(parentcase); > > de = calloc(1, sizeof(*de)); > - de->head = NULL; > - de->child = NULL; > de->parent = parent_de; > de->normalized_name = strdup(targetnorm); > de->case_name = strdup(chop_filename(casename)); > > >

2 1

Re: [ros-dev] [ros-diffs] [hbelusca] 65678: [MSGINA]: Update the function names of stubs, with (in comments) the number of parameters they take. See CORE-8459 for more information. CORE-8459 #resolve #comment Fixed in r65678.
by Thomas Faber 26 Jan '15

26 Jan '15

On 2014-12-15 22:07, hbelusca(a)svn.reactos.org wrote: > +1 stub -noname ShellGetUserList ; (long long long) For future reference, you might as well write this kind of thing as 1 stdcall -stub -noname ShellGetUserList(long long long) Then spec2def will create a stub that uses the correct calling convention and also prints out the arguments. Plus it's easier to change to the real thing when someone implements it ;)

2 1

Re: [ros-dev] [ros-diffs] [jimtabor] 66085: [Win32ss] - Fix window from point so it handles disabled windows correctly. - Cleanup processing mouse routine. - See CORE-7447.
by Thomas Faber 25 Jan '15

25 Jan '15

On 2015-01-25 16:57, jimtabor(a)svn.reactos.org wrote: > - if (*HitTest == HTNOWHERE) *HitTest = HTCLIENT; > + if (*HitTest == HTNOWHERE && pwndChild == NULL) *HitTest = HTCLIENT; pwndChild cannot be non-NULL here.

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 66083: [CDMAKE] - Disable unused dir_hash_next_dir function and corresponding target_dir_traversal structure definition. - Be really sure de->head and de->child are initialized at NULL. ...
by Pierre Schweitzer 24 Jan '15

24 Jan '15

On 24/01/2015 01:15, hbelusca(a)svn.reactos.org wrote: > ============================================================================== > --- trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] (original) > +++ trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] Sat Jan 24 00:15:08 2015 > @@ -138,12 +138,14 @@ > hashcode = djb_hash(targetnorm); > de = calloc(1, sizeof(*de)); > de->parent = parent_de; > + de->head = NULL; > + de->child = NULL; de has been allocated few lines upper with calloc. head & child CANNOT be different from NULL. This is non sense. > @@ -170,6 +172,7 @@ > tf->target_name = strdup(chop_filename(target)); > } > > +#if 0 > static struct target_dir_entry * > dir_hash_next_dir(struct target_dir_hash *dh, struct target_dir_traversal *t) > { > @@ -200,13 +203,13 @@ > return t->it; > } > } > +#endif Once again, this is trunk, not your working copy. If you 0 out, please add a comment explaining it's just unused and not buggy. And actually, because it's trunk & unusued, it would be better just to remove them. svn history can help finding them back if really needed. > ============================================================================== > --- trunk/reactos/tools/cdmake/dirhash.h [iso-8859-1] (original) > +++ trunk/reactos/tools/cdmake/dirhash.h [iso-8859-1] Sat Jan 24 00:15:08 2015 > @@ -26,11 +26,13 @@ > struct target_dir_entry root; > }; > > +#if 0 > struct target_dir_traversal > { > struct target_dir_entry *it; > int i; > }; > +#endif See comment above. Cheers, -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

New Flyers for FOSDEM required
by Colin Finck 22 Jan '15

22 Jan '15

Hi all, We're still preparing merchandising products for FOSDEM, and flyers are probably most important here and still doable in time. Can somebody please take the template from https://svn.reactos.org/press-media/trunk/Events/2009%20-%20FOSDEM/Flyer/ and alter it a bit to reflect current ReactOS state? The best would be a flyer not including a certain ReactOS version number, so that it is universally usable. If you don't have InDesign to modify the file, just send me the modified text here. Thanks! Colin

1 0

Security issue on ReactOS.org website
by Pierre Schweitzer 21 Jan '15

21 Jan '15

Dear all, Just to make sure you read it: https://www.reactos.org/node/928 The SVN accounts are not affected. Cheers, -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev