Ros-dev

ros-dev@reactos.org

5791 discussions

Re: [ros-dev] [ros-diffs] [gadamopoulos] 62011: [atl] - Fix atl thunks to be allocated in executable memory and not from the stack in order to run libraries that use atl (such as browseui) in windows with DEP enabled
by Jerome Gardou 06 Feb '14

06 Feb '14

Hey Giannis. How big qre the thunks ? A whole page for each of them looks like a lot of resources. What about a special heap ? Keep it up! Regards Jérôme Le jeudi 6 février 2014, 13:07:37 gadamopoulos(a)svn.reactos.org a écrit : > Author: gadamopoulos > Date: Thu Feb 6 13:07:37 2014 > New Revision: 62011 > > URL: http://svn.reactos.org/svn/reactos?rev=62011&view=rev > Log: > [atl] > - Fix atl thunks to be allocated in executable memory and not from the stack > in order to run libraries that use atl (such as browseui) in windows with > DEP enabled > > Modified: > branches/shell-experiments/lib/atl/atlwin.h > > Modified: branches/shell-experiments/lib/atl/atlwin.h > URL: > http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/atl/atlwi > n.h?rev=62011&r1=62010&r2=62011&view=diff > =========================================================================== > === --- branches/shell-experiments/lib/atl/atlwin.h [iso-8859-1] (original) > +++ branches/shell-experiments/lib/atl/atlwin.h [iso-8859-1] Thu Feb 6 > 13:07:37 2014 @@ -153,21 +153,32 @@ > class CWndProcThunk > { > public: > - thunkCode m_thunk; > + thunkCode *m_pthunk; > _AtlCreateWndData cd; > public: > + > + CWndProcThunk() > + { > + m_pthunk = (thunkCode*)VirtualAlloc(NULL, sizeof(thunkCode), > MEM_COMMIT, PAGE_EXECUTE_READWRITE); + } > + > + ~CWndProcThunk() > + { > + VirtualFree(m_pthunk, sizeof(thunkCode), MEM_RELEASE); > + } > + > BOOL Init(WNDPROC proc, void *pThis) > { > - m_thunk.m_mov = 0x042444C7; > - m_thunk.m_this = PtrToUlong(pThis); > - m_thunk.m_jmp = 0xe9; > - m_thunk.m_relproc = DWORD(reinterpret_cast<char *>(proc) - > (reinterpret_cast<char *>(this) + sizeof(thunkCode))); + m_pthunk- >m_mov = > 0x042444C7; > + m_pthunk->m_this = PtrToUlong(pThis); > + m_pthunk->m_jmp = 0xe9; > + m_pthunk->m_relproc = DWORD(reinterpret_cast<char *>(proc) - > (reinterpret_cast<char *>(m_pthunk) + sizeof(thunkCode))); return TRUE; > } > > WNDPROC GetWNDPROC() > { > - return reinterpret_cast<WNDPROC>(&m_thunk); > + return reinterpret_cast<WNDPROC>(m_pthunk); > } > };

1 0

Re: [ros-dev] [ros-diffs] [cwittich] 61898: [baseaddress] hackfix for VLC Player startup
by Aleksey Bragin 01 Feb '14

01 Feb '14

I would ask, what's the problem? Short description of the problem: <Christoph_vW> wsock32 only redirects to ws2_32 <Christoph_vW> when it gets relocated vlc does not work anymore Any clues? Regards, Aleksey Bragin On 01.02.2014 12:55, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sat Feb 1 08:55:54 2014 > New Revision: 61898 > > URL: http://svn.reactos.org/svn/reactos?rev=61898&view=rev > Log: > [baseaddress] > hackfix for VLC Player startup > > Modified: > trunk/reactos/cmake/baseaddress.cmake > > Modified: trunk/reactos/cmake/baseaddress.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/baseaddress.cmake?re… > ============================================================================== > --- trunk/reactos/cmake/baseaddress.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/baseaddress.cmake [iso-8859-1] Sat Feb 1 08:55:54 2014 > @@ -283,7 +283,7 @@ > set(baseaddress_ws2_32_new 0x70790000) > set(baseaddress_wshirda 0x70760000) > set(baseaddress_wshtcpip 0x70730000) > -set(baseaddress_wsock32 0x70700000) > +set(baseaddress_wsock32 0x78700000) # FIXME: hackfix for VLC player > set(baseaddress_wtsapi32 0x706d0000) > set(baseaddress_wuapi 0x70690000) > set(baseaddress_xinput1_1 0x70660000) > >

1 0

Status Meeting (January 2014)
by Aleksey Bragin 30 Jan '14

30 Jan '14

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 30th of January, 19:00 UTC. Put that into your calendars so you don't forget. And that's in two days! IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (send them to me shortly before the meeting starts). Hermes sent the first suggestion well before the meeting, so please follow his example and send your suggestions too. Regards, Aleksey Bragin

5 4

Re: [ros-dev] [ros-diffs] [hbelusca] 61875: [NTVDM] - Enable experimental sound support (only PC speaker for the moment, aka. uses beep.sys). - Introduce a #define WORKING_TIMER which aim is to disable the currently problem...
by Timo Kreuzer 29 Jan '14

29 Jan '14

What about reading the current TickCount from the shared user page? Am 29.01.2014 01:25, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Wed Jan 29 00:25:43 2014 > New Revision: 61875 > > URL: http://svn.reactos.org/svn/reactos?rev=61875&view=rev > Log: > [NTVDM] > - Enable experimental sound support (only PC speaker for the moment, aka. uses beep.sys). > - Introduce a #define WORKING_TIMER which aim is to disable the currently problematic approximate performance counter value calculation done in order not to call QueryPerformanceCounter each time. > The problem is that we then compute a number of clock ticks for the PIT, which becomes negative, and therefore everything starts to hang. > Disabling this code and calling each time QueryPerformanceCounter, fixes everything; we gain in precision but we loose in performance... > A definitive fix must be found, [TheFlash] !! > > This fixes sound (and hangs) in Advanced NetWars, Dangerous Dave, ElitePlus and Rescue Rover (the games that I've tested so far). > >

1 0

[PATCH] fix typo in several names and comments
by Sergei Antonov 27 Jan '14

27 Jan '14

Hello! 'Lastest' (with 's') is a typo. The patch fixes or replaces it in several places.

1 0

[PATCH] wrong way to get section count in pefixup.c
by Sergei Antonov 27 Jan '14

27 Jan '14

Hello! This is my fix to an error in pefixup tool. The section count was taken from a wrong struct member and the tool only worked (when worked) by chance.

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 61755: [KSECDD] Implement IRP_MJ_QUERY_INFORMATION and IRP_MJ_QUERY_VOLUME_INFORMATION
by Michael Fritscher 23 Jan '14

23 Jan '14

Hello Timo, > +static > +NTSTATUS > +KsecQueryVolumeInformation( > + PVOID InfoBuffer, > + FS_INFORMATION_CLASS FsInformationClass, > + PSIZE_T BufferLength) > +{ > + PFILE_FS_DEVICE_INFORMATION DeviceInformation; > + > + /* Only FileFsDeviceInformation is supported */ > + if (FsInformationClass == FileFsDeviceInformation) > + { > + return STATUS_INVALID_INFO_CLASS; > + } shouldn't be that "FsInformationClass != FileFsDeviceInformation" ? ;) Best regards, Michael Fritscher

2 1

GPU drivers for XP/2003
by Javier Agustìn Fernàndez Arroyo 19 Jan '14

19 Jan '14

Hello all, XP support will come to end on April this year, and i suppose GPU vendors and manufacturers will drop driver releases for those systems as well. So, my question is, what about trying to contact them and try to convince them to release those drivers as "ReactOS" instead of "Windows XP"? :)

2 2

While in Screen Saver
by James Tabor 16 Jan '14

16 Jan '14

Hello, Something not to worry about... Maybe someone knows about? Thanks, James While sitting for days idle this occurred. Real hardware Build 20140112-r61596 IRQ 2 is cascade (../../win32ss/user/ntuser/input.c:70) err: Screensaver is Idle (../../win32ss/user/ntuser/input.c:70) err: Screensaver is Idle WARNING: RtlUnhandledExceptionFilter at ../../lib/rtl/exception.c:302 is UNIMPLEMENTED! Unhandled exception MM:***PAGE FAULT AT IRQL > 1 Va 05000450, IRQL 2 MM:***EIP 8089B32A, EFL 00010282 MM:***EAX 0206000B, ECX 05000400 EDX 00000100 MM:***EBX 05000400, ESI 00000000 EDI 00000279 Entered debugger on last-chance exception (Exception Code: 0xc0000006) (Unknown/User defined exception) (../../ntoskrnl/mm/mmfault.c:122) Page fault at high IRQL was 2, address 0 Entered debugger on last-chance exception (Exception Code: 0xc0000006) (Unknown/User defined exception) kdb:> bt Eip: <NTOSKRNL.EXE:91d76 (include/ddk/wdm.h:9607 (KiTimerExpiration))> Frames: <NTOSKRNL.EXE:9293d (ntoskrnl/ke/dpc.c:576 (KiRetireDpcList))> <NTOSKRNL.EXE:28c6 (:0 (KiRetireDpcListInDpcStack))> <NTOSKRNL.EXE:1d185c (:0 (KdbInitFileBuffer))> Couldn't access memory at 0x00000018! kdb:> cont *** Fatal System Error: 0x0000001e (0xC0000006,0x80891D76,0xF78A7E30,0x00000000) Entered debugger on embedded INT3 at 0x0008:0x8094dc0c. (../../ntoskrnl/mm/mmfault.c:122) Page fault at high IRQL was 2, address 4 Entered debugger on last-chance exception (Exception Code: 0xc0000006) (Unknown/User defined exception) kdb:> bt Eip: <NTOSKRNL.EXE:91d73 (include/ddk/wdm.h:9606 (KiTimerExpiration))> Frames: <NTOSKRNL.EXE:9293d (ntoskrnl/ke/dpc.c:576 (KiRetireDpcList))> <NTOSKRNL.EXE:28c6 (:0 (KiRetireDpcListInDpcStack))> <HAL.DLL:b3e2 (hal/halx86/up/pic.c:1323 (HalpDispatchInterrupt2))> <HAL.DLL:b648 (hal/halx86/up/pic.c:687 (KfLowerIrql))> <NTOSKRNL.EXE:173c87 (:0 (PortInfo))> <NTOSKRNL.EXE:14ac4a (ntoskrnl/kd/kdmain.c:207 (KdpEnterDebuggerException))> Couldn't access memory at 0x0000006C! kdb:>

1 0

r61585 Buildbot test failures
by Eric Kohl 11 Jan '14

11 Jan '14

Hi! You may have noticed that my latest patch causes buildbot failures. This happens because the patch breaks winlogons AutoAdminLogon feature. Please do not revert that patch! I'll provide a fix for the AutoAdminLogon feature as soon as possible. Regards Eric

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev