Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] [ros-diffs] [tfaber] 62266: [CRT] - Force the use of memory operands in bit test intrinsics. Bit offsets above 31 (or 63) can't behave correctly with registers (the constant case is fine because it ensures low...

by Timo Kreuzer

While the bug was definately on our side, I still think there is a GCC/CLANG bug here as well. Memory operands larger than register size are a rare case (probably limited to the bittest instructions) but allowing a register operand here should cause the compiler to either error out or in the worst case emit something like "mov eax, [BaseAddress]; bt eax, cl;" or "mov eax, [PointerToBaseAddress]; mov eax, [eax]; bt eax, cl;" rather than "bt [PointerToBaseAddress], cl;", which it actually did. Changing the constraint to something that wasn't working changed the behaviour in a way that changed the level of dereference! The operation was done on the pointer instead of on the memory pointed to by the pointer! Maybe we should file a bugreport. Am 20.02.2014 20:28, schrieb tfaber(a)svn.reactos.org: > Author: tfaber > Date: Thu Feb 20 19:28:27 2014 > New Revision: 62266 > > URL: http://svn.reactos.org/svn/reactos?rev=62266&view=rev > Log: > [CRT] > - Force the use of memory operands in bit test intrinsics. Bit offsets above 31 (or 63) can't behave correctly with registers (the constant case is fine because it ensures low offsets). Thanks to Timo Kreuzer and Alex Radocea. > > Modified: > trunk/reactos/include/crt/mingw32/intrin_x86.h > > Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/mingw32/intrin… > ============================================================================== > --- trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] (original) > +++ trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] Thu Feb 20 19:28:27 2014 > @@ -1032,7 +1032,7 @@ > if(__builtin_constant_p(b)) > __asm__("bt %[b], %[a]; setb %b[retval]" : [retval] "=q" (retval) : [a] "mr" (*(a + (b / 32))), [b] "Ir" (b % 32)); > else > - __asm__("bt %[b], %[a]; setb %b[retval]" : [retval] "=q" (retval) : [a] "mr" (*a), [b] "r" (b)); > + __asm__("bt %[b], %[a]; setb %b[retval]" : [retval] "=q" (retval) : [a] "m" (*a), [b] "r" (b)); > > return retval; > } > @@ -1045,7 +1045,7 @@ > if(__builtin_constant_p(b)) > __asm__("bt %[b], %[a]; setb %b[retval]" : [retval] "=q" (retval) : [a] "mr" (*(a + (b / 64))), [b] "Ir" (b % 64)); > else > - __asm__("bt %[b], %[a]; setb %b[retval]" : [retval] "=q" (retval) : [a] "mr" (*a), [b] "r" (b)); > + __asm__("bt %[b], %[a]; setb %b[retval]" : [retval] "=q" (retval) : [a] "m" (*a), [b] "r" (b)); > > return retval; > } > @@ -1058,7 +1058,7 @@ > if(__builtin_constant_p(b)) > __asm__("btc %[b], %[a]; setb %b[retval]" : [a] "+mr" (*(a + (b / 32))), [retval] "=q" (retval) : [b] "Ir" (b % 32)); > else > - __asm__("btc %[b], %[a]; setb %b[retval]" : [a] "+mr" (*a), [retval] "=q" (retval) : [b] "r" (b)); > + __asm__("btc %[b], %[a]; setb %b[retval]" : [a] "+m" (*a), [retval] "=q" (retval) : [b] "r" (b)); > > return retval; > } > @@ -1070,7 +1070,7 @@ > if(__builtin_constant_p(b)) > __asm__("btr %[b], %[a]; setb %b[retval]" : [a] "+mr" (*(a + (b / 32))), [retval] "=q" (retval) : [b] "Ir" (b % 32)); > else > - __asm__("btr %[b], %[a]; setb %b[retval]" : [a] "+mr" (*a), [retval] "=q" (retval) : [b] "r" (b)); > + __asm__("btr %[b], %[a]; setb %b[retval]" : [a] "+m" (*a), [retval] "=q" (retval) : [b] "r" (b)); > > return retval; > } > @@ -1082,7 +1082,7 @@ > if(__builtin_constant_p(b)) > __asm__("bts %[b], %[a]; setb %b[retval]" : [a] "+mr" (*(a + (b / 32))), [retval] "=q" (retval) : [b] "Ir" (b % 32)); > else > - __asm__("bts %[b], %[a]; setb %b[retval]" : [a] "+mr" (*a), [retval] "=q" (retval) : [b] "r" (b)); > + __asm__("bts %[b], %[a]; setb %b[retval]" : [a] "+m" (*a), [retval] "=q" (retval) : [b] "r" (b)); > > return retval; > } > > >

10 years, 10 months

Re: [ros-dev] [ros-diffs] [hbelusca] 62267: [KERNEL32] Revert r62264. Reason: all APIs set the last error when a CSR* call doesn't return STATUS_SUCCESS. If some winetests fail because of this, this is because we do not cor...

by Aleksey Bragin

Well, it would make sense to talk to Christoph first. It's not THAT obvious where the real bug is, and he might have been willing to try to find it and fix. Regards, Aleksey Bragin On 21.02.2014 0:17, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Thu Feb 20 20:17:53 2014 > New Revision: 62267 > > URL: http://svn.reactos.org/svn/reactos?rev=62267&view=rev > Log: > [KERNEL32] > Revert r62264. > Reason: all APIs set the last error when a CSR* call doesn't return STATUS_SUCCESS. If some winetests fail because of this, this is because we do not correctly do what's needed here (normally the TRUE or FALSE value is returned by the console server, and is not retrieved by a success or failure of a CSR call contrary to what's done here). > > Modified: > trunk/reactos/dll/win32/kernel32/client/console/console.c > > Modified: trunk/reactos/dll/win32/kernel32/client/console/console.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… > ============================================================================== > --- trunk/reactos/dll/win32/kernel32/client/console/console.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/kernel32/client/console/console.c [iso-8859-1] Thu Feb 20 20:17:53 2014 > @@ -796,6 +796,7 @@ > sizeof(CONSOLE_VERIFYHANDLE)); > if (!NT_SUCCESS(Status)) > { > + BaseSetLastNTError(Status); > return FALSE; > } > > >

10 years, 10 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 62249: [NTOSKRNL] Fix returned symbolic links in IoGetDeviceInterfaces.

by Alex Ionescu

Was this the Video Driver bug in ReactBox? Best regards, Alex Ionescu On Tue, Feb 18, 2014 at 11:53 AM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Tue Feb 18 19:53:48 2014 > New Revision: 62249 > > URL: http://svn.reactos.org/svn/reactos?rev=62249&view=rev > Log: > [NTOSKRNL] > Fix returned symbolic links in IoGetDeviceInterfaces. > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/deviface.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/deviface.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/deviface… > ============================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/deviface.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/deviface.c [iso-8859-1] Tue Feb 18 19:53:48 2014 > @@ -466,7 +466,7 @@ > goto cleanup; > } > > - /* Enumerate subkeys (ie the different device objets) */ > + /* Enumerate subkeys (i.e. the different device objects) */ > while (TRUE) > { > Status = ZwEnumerateKey( > @@ -729,14 +729,17 @@ > Status = STATUS_UNSUCCESSFUL; > goto cleanup; > } > - KeyName.Length = KeyName.MaximumLength = (USHORT)bip->DataLength - 4 * sizeof(WCHAR); > - KeyName.Buffer = &((PWSTR)bip->Data)[4]; > + KeyName.Length = KeyName.MaximumLength = (USHORT)bip->DataLength; > + KeyName.Buffer = (PWSTR)bip->Data; > + > + /* Fixup the prefix (from "\\?\") */ > + RtlCopyMemory(KeyName.Buffer, L"\\??\\", 4 * sizeof(WCHAR)); > > /* Add new symbolic link to symbolic link list */ > if (ReturnBuffer.Length + KeyName.Length + sizeof(WCHAR) > ReturnBuffer.MaximumLength) > { > PWSTR NewBuffer; > - ReturnBuffer.MaximumLength = (USHORT)max(ReturnBuffer.MaximumLength * 2, > + ReturnBuffer.MaximumLength = (USHORT)max(ReturnBuffer.MaximumLength * sizeof(WCHAR), > (USHORT)(ReturnBuffer.Length + > KeyName.Length + > 2 * sizeof(WCHAR))); > >

10 years, 10 months

Re: [ros-dev] [ros-diffs] [dquintana] 62226: [RSHELL] * CMenuBand: Handle WM_COMMAND and run SMC_EXEC for static menu items (Run, Shutdown). CORE-7881

by Jerome Gardou

Hi David > + if (m_staticToolbar != NULL) > + hr = m_staticToolbar->GetWindow(&hwndStatic); > + if (FAILED(hr)) > + return hr; You are using potentially uninitialized variable here. are you compiling without "-Werror" (or /WX on msvc)? Keep it up :-) Greetings Jérôme

10 years, 10 months

Re: [ros-dev] [ros-diffs] [hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.

by Alex Ionescu

SP2 was not out when we made the choice. And before we move to SP2, I'd rather move to Win 7 =) -- Best regards, Alex Ionescu -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of hbelusca(a)svn.reactos.org Sent: Wednesday, February 12, 2014 2:58 PM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142. Author: hbelusca Date: Wed Feb 12 22:58:13 2014 New Revision: 62142 URL: http://svn.reactos.org/svn/reactos?rev=62142&view=rev Log: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142. Modified: trunk/reactos/boot/bootdata/hivesys.inf trunk/reactos/include/psdk/ntverp.h trunk/reactos/ntoskrnl/ex/init.c Modified: trunk/reactos/boot/bootdata/hivesys.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1143,8 +1143,8 @@ ; ReactOS specific - by default we report ourselves as Server for the user, ; but we can also report as Workstation if some application needs it. HKLM,"SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version","ReportAsWorkstation",0x00010001,0x00000000 -; Some installers check for SP2 -HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000200 +; Some installers check for SP1 +HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001 +,0x00000100 HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders","SecurityProviders",2,"schannel.dll" HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders\SaslProfiles",,0x00000012 Modified: trunk/reactos/include/psdk/ntverp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntverp.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/ntverp.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ntverp.h [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -14,10 +14,10 @@ */ // -// Windows NT Build 3790.3959 +// Windows NT Build 3790.1830 // #define VER_PRODUCTBUILD 3790 -#define VER_PRODUCTBUILD_QFE 3959 +#define VER_PRODUCTBUILD_QFE 1830 // // Windows NT Version 5.2 Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=621… ============================================================================== --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1072,12 +1072,12 @@ /* Setup initial system settings */ CmGetSystemControlValues(LoaderBlock->RegistryBase, CmControlVector); - /* Load static defaults for Service Pack 2 and add our SVN revision */ + /* Load static defaults for Service Pack 1 and add our SVN revision + */ /* Format of CSD : SPMajor - SPMinor */ - CmNtCSDVersion = 0x200 | (KERNEL_VERSION_BUILD_HEX << 16); + CmNtCSDVersion = 0x100 | (KERNEL_VERSION_BUILD_HEX << 16); CmNtCSDReleaseType = 0; - /* Set Service Pack data for Service Pack 2 */ + /* Set Service Pack data for Service Pack 1 */ CmNtSpBuildNumber = VER_PRODUCTBUILD_QFE; if (!(CmNtCSDVersion & 0xFFFF0000)) {

10 years, 11 months

Re: [ros-dev] [ros-diffs] [hbelusca] 62140: [REACTOS] Go fully to Win2k3 SP2 version reporting. CORE-6611 #resolve #comment Fixed in r62140.

by Alex Ionescu

I am so sick of these types of changes being made without consultation. The kernel is not SP2. Please do not update this value, as we are missing exports/functionality exposed on SP2. Best regards, Alex Ionescu On Wed, Feb 12, 2014 at 12:03 PM, <hbelusca(a)svn.reactos.org> wrote: > Author: hbelusca > Date: Wed Feb 12 20:03:57 2014 > New Revision: 62140 > > URL: http://svn.reactos.org/svn/reactos?rev=62140&view=rev > Log: > [REACTOS] > Go fully to Win2k3 SP2 version reporting. > CORE-6611 #resolve #comment Fixed in r62140. > > Modified: > trunk/reactos/boot/bootdata/hivesys.inf > trunk/reactos/include/psdk/ntverp.h > trunk/reactos/ntoskrnl/ex/init.c > > Modified: trunk/reactos/boot/bootdata/hivesys.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?… > ============================================================================== > --- trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] Wed Feb 12 20:03:57 2014 > @@ -1143,8 +1143,8 @@ > ; ReactOS specific - by default we report ourselves as Server for the user, > ; but we can also report as Workstation if some application needs it. > HKLM,"SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version","ReportAsWorkstation",0x00010001,0x00000000 > -; Some installers check for SP1 > -HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000100 > +; Some installers check for SP2 > +HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000200 > > HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders","SecurityProviders",2,"schannel.dll" > HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders\SaslProfiles",,0x00000012 > > Modified: trunk/reactos/include/psdk/ntverp.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntverp.h?rev=… > ============================================================================== > --- trunk/reactos/include/psdk/ntverp.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/ntverp.h [iso-8859-1] Wed Feb 12 20:03:57 2014 > @@ -14,10 +14,10 @@ > */ > > // > -// Windows NT Build 3790.1830 > +// Windows NT Build 3790.3959 > // > #define VER_PRODUCTBUILD 3790 > -#define VER_PRODUCTBUILD_QFE 1830 > +#define VER_PRODUCTBUILD_QFE 3959 > > // > // Windows NT Version 5.2 > > Modified: trunk/reactos/ntoskrnl/ex/init.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=621… > ============================================================================== > --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Wed Feb 12 20:03:57 2014 > @@ -1072,12 +1072,12 @@ > /* Setup initial system settings */ > CmGetSystemControlValues(LoaderBlock->RegistryBase, CmControlVector); > > - /* Load static defaults for Service Pack 1 and add our SVN revision */ > + /* Load static defaults for Service Pack 2 and add our SVN revision */ > /* Format of CSD : SPMajor - SPMinor */ > - CmNtCSDVersion = 0x100 | (KERNEL_VERSION_BUILD_HEX << 16); > + CmNtCSDVersion = 0x200 | (KERNEL_VERSION_BUILD_HEX << 16); > CmNtCSDReleaseType = 0; > > - /* Set Service Pack data for Service Pack 1 */ > + /* Set Service Pack data for Service Pack 2 */ > CmNtSpBuildNumber = VER_PRODUCTBUILD_QFE; > if (!(CmNtCSDVersion & 0xFFFF0000)) > { > >

10 years, 11 months

Server fixes

by Colin Finck

Hi all, Pierre and me changed the HTTP server software on the VM for build.reactos.org, git.reactos.org, source.reactos.org and svn.reactos.org today. This may or may not fix the performance issues people were recently experiencing at git.reactos.org. At least, the stability has improved and the full configuration is less complex, making further changes easier. If anything got noticably worse, please report here. Cheers, Colin

10 years, 11 months

Re: [ros-dev] [ros-diffs] [gadamopoulos] 62011: [atl] - Fix atl thunks to be allocated in executable memory and not from the stack in order to run libraries that use atl (such as browseui) in windows with DEP enabled

by Jerome Gardou

Hey Giannis. How big qre the thunks ? A whole page for each of them looks like a lot of resources. What about a special heap ? Keep it up! Regards Jérôme Le jeudi 6 février 2014, 13:07:37 gadamopoulos(a)svn.reactos.org a écrit : > Author: gadamopoulos > Date: Thu Feb 6 13:07:37 2014 > New Revision: 62011 > > URL: http://svn.reactos.org/svn/reactos?rev=62011&view=rev > Log: > [atl] > - Fix atl thunks to be allocated in executable memory and not from the stack > in order to run libraries that use atl (such as browseui) in windows with > DEP enabled > > Modified: > branches/shell-experiments/lib/atl/atlwin.h > > Modified: branches/shell-experiments/lib/atl/atlwin.h > URL: > http://svn.reactos.org/svn/reactos/branches/shell-experiments/lib/atl/atlwi > n.h?rev=62011&r1=62010&r2=62011&view=diff > =========================================================================== > === --- branches/shell-experiments/lib/atl/atlwin.h [iso-8859-1] (original) > +++ branches/shell-experiments/lib/atl/atlwin.h [iso-8859-1] Thu Feb 6 > 13:07:37 2014 @@ -153,21 +153,32 @@ > class CWndProcThunk > { > public: > - thunkCode m_thunk; > + thunkCode *m_pthunk; > _AtlCreateWndData cd; > public: > + > + CWndProcThunk() > + { > + m_pthunk = (thunkCode*)VirtualAlloc(NULL, sizeof(thunkCode), > MEM_COMMIT, PAGE_EXECUTE_READWRITE); + } > + > + ~CWndProcThunk() > + { > + VirtualFree(m_pthunk, sizeof(thunkCode), MEM_RELEASE); > + } > + > BOOL Init(WNDPROC proc, void *pThis) > { > - m_thunk.m_mov = 0x042444C7; > - m_thunk.m_this = PtrToUlong(pThis); > - m_thunk.m_jmp = 0xe9; > - m_thunk.m_relproc = DWORD(reinterpret_cast<char *>(proc) - > (reinterpret_cast<char *>(this) + sizeof(thunkCode))); + m_pthunk- >m_mov = > 0x042444C7; > + m_pthunk->m_this = PtrToUlong(pThis); > + m_pthunk->m_jmp = 0xe9; > + m_pthunk->m_relproc = DWORD(reinterpret_cast<char *>(proc) - > (reinterpret_cast<char *>(m_pthunk) + sizeof(thunkCode))); return TRUE; > } > > WNDPROC GetWNDPROC() > { > - return reinterpret_cast<WNDPROC>(&m_thunk); > + return reinterpret_cast<WNDPROC>(m_pthunk); > } > };

10 years, 11 months

Re: [ros-dev] [ros-diffs] [cwittich] 61898: [baseaddress] hackfix for VLC Player startup

by Aleksey Bragin

I would ask, what's the problem? Short description of the problem: <Christoph_vW> wsock32 only redirects to ws2_32 <Christoph_vW> when it gets relocated vlc does not work anymore Any clues? Regards, Aleksey Bragin On 01.02.2014 12:55, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sat Feb 1 08:55:54 2014 > New Revision: 61898 > > URL: http://svn.reactos.org/svn/reactos?rev=61898&view=rev > Log: > [baseaddress] > hackfix for VLC Player startup > > Modified: > trunk/reactos/cmake/baseaddress.cmake > > Modified: trunk/reactos/cmake/baseaddress.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/baseaddress.cmake?re… > ============================================================================== > --- trunk/reactos/cmake/baseaddress.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/baseaddress.cmake [iso-8859-1] Sat Feb 1 08:55:54 2014 > @@ -283,7 +283,7 @@ > set(baseaddress_ws2_32_new 0x70790000) > set(baseaddress_wshirda 0x70760000) > set(baseaddress_wshtcpip 0x70730000) > -set(baseaddress_wsock32 0x70700000) > +set(baseaddress_wsock32 0x78700000) # FIXME: hackfix for VLC player > set(baseaddress_wtsapi32 0x706d0000) > set(baseaddress_wuapi 0x70690000) > set(baseaddress_xinput1_1 0x70660000) > >

10 years, 11 months

Status Meeting (January 2014)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 30th of January, 19:00 UTC. Put that into your calendars so you don't forget. And that's in two days! IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Pierre before the meeting started to get one. The agenda will be posted shortly before the meeting, suggestions are welcome (send them to me shortly before the meeting starts). Hermes sent the first suggestion well before the meeting, so please follow his example and send your suggestions too. Regards, Aleksey Bragin

10 years, 11 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev