Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [pschweitzer] 62675: [CHARMAP] Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible
by Timo Kreuzer 07 Apr '14

07 Apr '14

I don't really see the reason here. Whether using the secure function or not is is a question of whether we need null-termination or not. If we need it the secure function will do the right thing. If we do not need null-termination the non-secure function does the right thing and the secure function would not add any security, but simply do the wrong thing. MSDN says about the lfFaceName member of the LOGFONT structure "A null-terminated string that specifies the typeface name of the font. " So we want it to be null-terminated and adding one more character does not add anything useful, but will result in a broken structure. Another difference is that the non-secure function pads the destination array with nulls, the secure function does - afaik - not. If that is the reason, I'd prefer zeroing it out before copying the string. Am 06.04.2014 22:20, schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Sun Apr 6 20:20:39 2014 > New Revision: 62675 > > URL: http://svn.reactos.org/svn/reactos?rev=62675&view=rev > Log: > [CHARMAP] > Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible > > Modified: > trunk/reactos/base/applications/charmap/lrgcell.c > trunk/reactos/base/applications/charmap/map.c > > Modified: trunk/reactos/base/applications/charmap/lrgcell.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… > ============================================================================== > --- trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] Sun Apr 6 20:20:39 2014 > @@ -48,9 +48,9 @@ > hdc); > > lf.lfCharSet = DEFAULT_CHARSET; > - wcscpy_s(lf.lfFaceName, > - sizeof(lf.lfFaceName) / sizeof(lf.lfFaceName[0]), > - lpFontName); > + wcsncpy(lf.lfFaceName, > + lpFontName, > + sizeof(lf.lfFaceName) / sizeof(lf.lfFaceName[0])); > > hFont = CreateFontIndirectW(&lf); > > > Modified: trunk/reactos/base/applications/charmap/map.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… > ============================================================================== > --- trunk/reactos/base/applications/charmap/map.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/charmap/map.c [iso-8859-1] Sun Apr 6 20:20:39 2014 > @@ -228,9 +228,9 @@ > ReleaseDC(infoPtr->hMapWnd, hdc); > > infoPtr->CurrentFont.lfCharSet = DEFAULT_CHARSET; > - wcscpy_s(infoPtr->CurrentFont.lfFaceName, > - sizeof(infoPtr->CurrentFont.lfFaceName) / sizeof(infoPtr->CurrentFont.lfFaceName[0]), > - lpFontName); > + wcsncpy(infoPtr->CurrentFont.lfFaceName, > + lpFontName, > + sizeof(infoPtr->CurrentFont.lfFaceName) / sizeof(infoPtr->CurrentFont.lfFaceName[0])); > > infoPtr->hFont = CreateFontIndirectW(&infoPtr->CurrentFont); > > > >

3 3

Re: [ros-dev] [ros-diffs] [khornicek] 62665: [MAIN] - fix a copypasta - fix a possible buffer overrun (x5) - fix a negative array index access
by Thomas Faber 06 Apr '14

06 Apr '14

You guys should consider replacing that stuff with strsafe functions while you're at it ;) On 2014-04-06 18:45, khornicek(a)svn.reactos.org wrote: > Author: khornicek > Date: Sun Apr 6 16:45:21 2014 > New Revision: 62665 > > URL: http://svn.reactos.org/svn/reactos?rev=62665&view=rev > Log: > [MAIN] > - fix a copypasta > - fix a possible buffer overrun (x5) > - fix a negative array index access > > Modified: > trunk/reactos/dll/cpl/main/mouse.c > > Modified: trunk/reactos/dll/cpl/main/mouse.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/main/mouse.c?rev=6… > ============================================================================== > --- trunk/reactos/dll/cpl/main/mouse.c [iso-8859-1] (original) > +++ trunk/reactos/dll/cpl/main/mouse.c [iso-8859-1] Sun Apr 6 16:45:21 2014 > @@ -499,7 +499,7 @@ > /* Remove quotation marks */ > if (szTempData[0] == _T('"')) > { > - lpStart = szValueData + 1; > + lpStart = szTempData + 1; > szTempData[_tcslen(szTempData) - 1] = 0; > } > else > @@ -1022,9 +1022,9 @@ > static VOID > LoadInitialCursorScheme(HWND hwndDlg) > { > - TCHAR szSchemeName[256]; > - TCHAR szSystemScheme[256]; > - TCHAR szCursorPath[256]; > + TCHAR szSchemeName[MAX_PATH]; > + TCHAR szSystemScheme[MAX_PATH]; > + TCHAR szCursorPath[MAX_PATH]; > HKEY hCursorKey; > LONG lError; > DWORD dwDataSize; > @@ -1057,7 +1057,7 @@ > > if (dwSchemeSource != 0) > { > - dwDataSize = 256 * sizeof(TCHAR); > + dwDataSize = MAX_PATH * sizeof(TCHAR); > lError = RegQueryValueEx(hCursorKey, > NULL, > NULL, > @@ -1101,8 +1101,8 @@ > else if (dwSchemeSource == 2) > { > LoadString(hApplet, IDS_SYSTEM_SCHEME, szSystemScheme, MAX_PATH); > - _tcscat(szSchemeName, _T(" ")); > - _tcscat(szSchemeName, szSystemScheme); > + _tcsncat(szSchemeName, _T(" "), MAX_PATH - _tcslen(szSchemeName)); > + _tcsncat(szSchemeName, szSystemScheme, MAX_PATH - _tcslen(szSchemeName)); > } > > /* Search and select the curent scheme name from the scheme list */ > @@ -1276,6 +1276,10 @@ > { > case LBN_SELCHANGE: > nSel = SendMessage((HWND)lParam, LB_GETCURSEL, 0, 0); > + > + if(nSel == LB_ERR) > + break; > + > SendDlgItemMessage(hwndDlg, IDC_IMAGE_CURRENT_CURSOR, STM_SETIMAGE, IMAGE_CURSOR, > (LPARAM)g_CursorData[nSel].hCursor); > EnableWindow(GetDlgItem(hwndDlg,IDC_BUTTON_USE_DEFAULT_CURSOR), > >

2 1

Re: [ros-dev] [ros-diffs] [hbelusca] 62662: [NTDLL_APITEST]: Add braces and remove an unneeded trace.
by Thomas Faber 06 Apr '14

06 Apr '14

This will make any failure messages in the loop useless, since you won't know which test they're about. Just because the tests are succeeding now doesn't mean they always will. On 2014-04-06 17:51, hbelusca(a)svn.reactos.org wrote: > @@ -188,7 +190,6 @@ > > for (i = 0; i < TestCount; i++) > { > - trace("i = %d\n", i); > switch (TestCases[i].PrefixType) > { > case PrefixNone: > >

2 2

Re: [ros-dev] [ros-diffs] [dgorbachev] 62598: [BUGCODES] - Add an error message for Proprietary Software Execution Prevention feature supported by recent CPUs. - TODO: Implement this feature in the kernel.‏
by Pierre Schweitzer 01 Apr '14

01 Apr '14

Nice one :-). I thought you'd commit your ReactOS 1.0 patch today! Beware though, you're sitting BUGCODE_NDIS_DRIVER. Regards, -- Pierre Schweitzer <pierre(a)reactos.org> System Administrator ReactOS Foundation

4 3

Re: [ros-dev] [ros-builds] Linux_AMD64_2 VMWPlayer-Test: build failed
by Pierre Schweitzer 01 Apr '14

01 Apr '14

Working on DB server atm (hence the fails). Results will be properly submitted later on. Ignore failed shell errors for the next hour. Sorry about that. On 04/01/2014 11:24 AM, buildbot(a)reactos.org wrote: > The Buildbot has detected a failed build on builder Linux_AMD64_2 VMWPlayer-Test while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Linux_AMD64_2%20VMWPlayer-Test/builds/3636 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Linux_AMD64_2 > > Build Reason: Triggerable(Linux_AMD64_1 KVM-Test Trigger) > Build Source Stamp: 62598 > Blamelist: > > BUILD FAILED: failed shell > > sincerely, > -The Buildbot > > > > -- Pierre Schweitzer <pierre(a)reactos.org> System Administrator ReactOS Foundation

1 0

Installing driver without reboot
by Maxime Daniel 28 Mar '14

28 Mar '14

Hi, Is it possible to install a driver (virtual network interface) witout reboot the system ? I tried TAP interface (installation with devcon: devcon install inf-file tap0901) but the interface is only loaded during the next reboot (same for a ndis sample from DDK) Is there a way to load a driver interface with a true plug'n'play mechanism ? -- Daniel Maxime Linux version 3.6.9-maxux64 (emy) (gcc version 4.7.3 (Gentoo 4.7.3-r1 p1.4, pie-0.5.5) ) #3 SMP PREEMPT Wed Feb 19 16:40:22 CET 2014 16:33:29 up 24 days, 8 min, 1 user, load average: 0.31, 0.68, 0.72

1 0

Re: [ros-dev] Installing and running ReactOS on modern hardware
by Thomas Mueller 28 Mar '14

28 Mar '14

from "David Quintana (gigaherz)" <gigaherz(a)gmail.com>: > [-- Type: multipart/alternative, Encoding: 7bit, Size: 5.8K --] > Content-Type: multipart/alternative; boundary=001a1135f7ac55c1ca04f557713d > Content-Type: text/plain; charset=UTF-8 > First of all, I'm not an expert when it comes to what ReactOS supports in > terms of real hardware. > I believe (someone will correct me if I'm wrong), that ReactOS is not > currently able to boot from USB, and in fact, will fail to boot at all if > an incompatible USB controller (which is most of them, I think?) is > present. Burning a CD-ROM with the setup or livecd images, and possibly > disabling the USB controllers from your bios config, may give you better > results. > I'm assuming that your intention is to try ReactOS in real hardware, > otherwise it would be better advised to just use VMware, VirtualBox, or > QEMU, as those work mostly out of the box. > Ideally, your real-hardware testing platform should have a serial port, and > this serial port should be connected to another computer with a serial > port, by using a null-modem cable. This way you could see debug messages > through the serial port, and interact with the remote debugger driver when > (more than if) it crashes. > ReactOS currently only supports FAT32, because it's a simple driver that > does not need advanced features of the storage system. As the storage stack > improves, it will be possible to attempt using more complex drivers. We > already have an EXT2 driver, but last I heard it was not stable enough to > be able to boot from it. > That's all I know. If it's not enough, maybe someone with more experience > can add to it. Thanks for response, but surely one-part plain text would be better than multipart/alternative? I could try commands such as drivemap in GRUB 2, but then ReactOS would be lost when trying to boot. Would MS-Windows drivers work in ReactOS when running from within VirtualBox or QEMU? I don't really want to try ReactOS on the same disk with FreeBSD and Linux installations that I want to keep intact, might be too hazardous. I don't have any serial ports but have serial headers on motherboard, could conceivably make a serial port. FreeDOS can boot from USB stick thanks to recognition by the BIOS/UEFI. I really would want to install ReactOS to something rewritable; having to burn a new CD for every little change is too much. With ReactOS being far from ready for production use, I figure I would have to make frequent changes/adjustments. I downloaded the installation iso for ReactOS 0.3.15, burned to CD, but that failed to boot. I believe Linux and *BSD are far more flexible in where they can install to than MS-Windows or OS/2. I hope ReactOS could rise above such Windows booting limitations. I ran OS/2 from 16-bit 1.3 in 1990 or 1991 to OS/2 Warp 4 in the single-digit days of April 2001. Then following a crash, on the next boot, CHKDSK, which ran automatically on the uncleanly-dismounted file system, ran amok and trashed everything on the hard drive. I was never again able to boot OS/2 after that. Now Linux and FreeBSD capabilities seem to far surpass OS/2 and its successor eComStation. Tom

2 4

Status Meeting (March 2014)
by Aleksey Bragin 27 Mar '14

27 Mar '14

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 27th of March, 19:00 UTC. Put that into your calendars so you don't forget. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Pierre before the meeting started to get one. Please send agenda proposals to me. Regards, Aleksey Bragin

2 1

ndis netvmini adapter
by Maxime Daniel 27 Mar '14

27 Mar '14

Hi, I'm trying to compile and test the netvmini ndis 5 adapter code from WDK, at first to understand how it works, then to modify it for another purpose. At this time I: - put the code on driver/network/dd/netvmini and adapted CMakeLists - put the inf on media/inf and adapted CMakeLists - fixed the code, it builds - add an entry to hivesys.inf to load the driver at boot The driver is well displayed during boot, debug message appears (the DriverEntry), on NtObj, the driver is visible and it appears on "Non Plug and Play" on device manager. Now, I don't know exactly what to do with it. How can I call the driver and add an adapter ? The userland tool given with the code works (I needed to comment some functions and add _DEV_BROADCAST_HANDLE struct by hand, it seems to not be implemented on dbt.h). When I run the userland tools, it fails with EnumDevices. Some help ? Thanks

2 1

Resuscitating MSVC 2008 builds (at least) for testing purposes only :P
by Hermès BÉLUSCA - MAÏTO 26 Mar '14

26 Mar '14

Because I was recently shocked (if I may say :D) that, for building a 2003-class operating system, we need 2010+ tools, I was wondering whether it was still possible to build ReactOS with MSVC 2008 and 2005. Ive created a task for that in Jira: http://jira.reactos.org/browse/CORE-8023 . After application of the configure.cmd patch that I give in the report, plus few tweaks in two headers (and adding some stdint.h in the correct directory for MSVC, needed for compiling host-tools, because this file is not included in default MSVC installation until MSVC 2010+), I was able to build a full bootcd and livecd (see the details in the abovementioned report, basically it currently builds with MSVC 2008 but not 2005). However there happens an interesting thing: the [boot|live]cd boots (freeldr seems to work and load the kernel and drivers), but after that, the kernel (debugged in WinDbg) hangs indefinitely here: Windows Server 2003 Kernel Version 3790 UP Checked x86 compatible Built by: 20140326-r62565 Machine Name: Kernel base = 0x80400000 PsLoadedModuleList = 0x005fcf88 System Uptime: not available (f:\ros_vs_test\ntoskrnl\ke\i386\cpu.c:494) Supported CPU features : KF_V86_VIS KF_RDTSC KF_CR4 KF_CMOV KF_GLOBAL_PAGE KF_LARGE_PAGE KF_MTRR KF_CMPXCHG8B KF_MMX KF_WORKING_PTE KF_PAT KF_FXSR KF_FAST_SYSCALL KF_XMMI KF_XMMI64 KF_NX_BIT (f:\ros_vs_test\ntoskrnl\ke\i386\cpu.c:801) Prefetch Cache: 64 bytes L2 Cache: 0 bytes L2 Cache Line: 64 bytes L2 Cache Associativity: 0 <_hangs_forever_here_> If some of you have an idea what *might* happen there, Im all ears! Cheers, Hermès.

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev