Ros-dev

ros-dev@reactos.org

5789 discussions

by Alexander Rechitskiy

Let's bring up the webOS topic again. There is an interesting idea to port Nyx portability layer to Win32 and thus make Open webOS running in ReactOS/Windows. Nice user interface would be a benefit! http://www.openwebosproject.org/docs/architecture#.U1l8Uvl_vTo -- Best regards, Alexander Reachitskiy

11 years

Status Meeting (April 2014)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 24th of April, 19:00 UTC. And this date is very close to now! IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Pierre before the meeting started to get one. Please send agenda proposals to me before the meeting, so that we can start with a proposed agenda. Regards, Aleksey Bragin

11 years

Re: [ros-dev] [ros-diffs] [akhaldi] 62898: [PSDK] * Add missing MAXLONGLONG definition.

by Timo Kreuzer

Am 22.04.2014 23:43, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Tue Apr 22 21:43:39 2014 > New Revision: 62898 > > URL: http://svn.reactos.org/svn/reactos?rev=62898&view=rev > Log: > [PSDK] > * Add missing MAXLONGLONG definition. > > Modified: > trunk/reactos/include/psdk/winnt.h > > Modified: trunk/reactos/include/psdk/winnt.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winnt.h?rev=6… > ============================================================================== > --- trunk/reactos/include/psdk/winnt.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/winnt.h [iso-8859-1] Tue Apr 22 21:43:39 2014 > @@ -1480,6 +1480,7 @@ > #define MAXBYTE 0xff > #define MAXWORD 0xffff > #define MAXDWORD 0xffffffff > +#define MAXLONGLONG (((LONGLONG)0x7fffffff << 32) | 0xffffffff) > #define PROCESSOR_INTEL_386 386 > #define PROCESSOR_INTEL_486 486 > #define PROCESSOR_INTEL_PENTIUM 586 > > > Why not use 0x7FFFFFFFFFFFFFFFLL ?

11 years

Re: [ros-dev] [ros-diffs] [aandrejevic] 62892: [NTVDM] Quit when ntvdm becomes the last process attached to the console.

by Thomas Faber

On 2014-04-22 22:46, aandrejevic(a)svn.reactos.org wrote: > --- branches/ntvdm/subsystems/ntvdm/ntvdm.c [iso-8859-1] (original) > +++ branches/ntvdm/subsystems/ntvdm/ntvdm.c [iso-8859-1] Tue Apr 22 20:46:50 2014 > @@ -196,6 +197,11 @@ > EmulatorInterrupt(0x23); > break; > } > + case CTRL_LAST_CLOSE_EVENT: > + { > + if (CommandThread) TerminateThread(CommandThread, 0); > + break; > + } > default: > { > /* Stop the VDM if the user logs out or closes the console */ Wasn't there an event to tell that thread to exit? Using TerminateThread like this feels icky.

11 years

Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something

by Pierre Schweitzer

Hey! That's indeed a typo! Can someone commit a fix? I can't before Monday evening. Thanks! Pierre -------- Message original -------- Objet : Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something De : Alexander Andrejevic <theflash(a)sdf.lonestar.org> À : ReactOS Development List <ros-dev(a)reactos.org> Cc : Hi, Correct me if I'm wrong, but the original version didn't modify the string length. Are you sure that should be "=" and not "=="? Regards, Alex On Sat, Apr 19, 2014 at 09:31:44AM +0200, Thomas Faber wrote: > On 2014-04-18 23:40, pschweitzer(a)svn.reactos.org wrote: > > --- trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] (original) > > +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] Fri Apr 18 21:40:02 2014 > > @@ -129,7 +131,7 @@ > > BOOLEAN > > CdfsFCBIsRoot(PFCB Fcb) > > { > > - return(wcscmp(Fcb->PathName, L"\\") == 0); > > + return (Fcb->PathName.Length = sizeof(WCHAR) && Fcb->PathName.Buffer[0] == L'\\'); > > } > > == > > > > Generally I'm seeing a lot of manual work where > RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used. > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev -- Alexander Andrejevic <theflash(a)sdf.lonestar.org> SDF Public Access UNIX System - http://sdf.lonestar.org _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

11 years

Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something

by Thomas Faber

On 2014-04-18 23:40, pschweitzer(a)svn.reactos.org wrote: > --- trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] Fri Apr 18 21:40:02 2014 > @@ -129,7 +131,7 @@ > BOOLEAN > CdfsFCBIsRoot(PFCB Fcb) > { > - return(wcscmp(Fcb->PathName, L"\\") == 0); > + return (Fcb->PathName.Length = sizeof(WCHAR) && Fcb->PathName.Buffer[0] == L'\\'); > } == Generally I'm seeing a lot of manual work where RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used.

11 years

Re: [ros-dev] [ros-bugs] [jira] (ONLINE-446) "Prove you are a human" game is hidden by AdBlock

by Richard Campbell

I couldn't resist. As a publisher...maybe you shouldn't run ad block eh? :) On Thu, Apr 17, 2014 at 12:09 AM, Sergey Bugaev (JIRA) <noreply(a)reactos.org>wrote: > > [ > http://jira.reactos.org/browse/ONLINE-446?page=com.atlassian.jira.plugin.sy…] > > Sergey Bugaev resolved ONLINE-446. > ---------------------------------- > > Resolution: Cannot Reproduce > > > "Prove you are a human" game is hidden by AdBlock > > ------------------------------------------------- > > > > Key: ONLINE-446 > > URL: http://jira.reactos.org/browse/ONLINE-446 > > Project: ReactOS Online Service > > Issue Type: Improvement > > Reporter: Sergey Bugaev > > Assignee: Aleksey Bragin > > > > https://www.reactos.org/user/register (use incognito mode or just log > out to see the issue) > > There is a game to prove you are a human. > > However if you are using AdBlock ( > https://chrome.google.com/webstore/detail/adblock/gighmmpiobklfepjocnamgkkb…, > the most popular Chrome extension with more than 15 million users) the game > is not visible, so newcomer can't register. > > The error message is "You didn't pass the game", which is not very > informative in that case. > > Should be something like "You didn't pass the game, try disabling > AdBlock to see it". The best solution would be making the game visible > anyway. > > Tested in Google Chrome > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira > > _______________________________________________ > Ros-bugs mailing list > Ros-bugs(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-bugs >

11 years

Heartbleed issue on the ReactOS infrastructure

by Pierre Schweitzer

Dear all, In case you don't use SSL/TLS on our infrastructure (web sites - drupal, jira, fisheye), skip reading (and reconsider your choices about such non-usage). As you may (should?) have heard recently, OpenSSL has suffered a critical security vulnerability (CVE-2014-0160), known as Heartbleed Bug (http://heartbleed.com/). Most of our services were using an affected release of OpenSSL, with heartbeat feature activated. Be it, mails services, web services (Drupal, Jira). We reacted quickly passed the public announcement, and the availability of the fix to apply it on our infrastructure to limit the risks. Anyway, this might have been enough (actually, the issue has been here for two years!) to allow potentials attackers to, for instance, steal our SSL private keys. So, we took the decision to renew all our certificates and private keys to guarantee safe infrastructure usage. Due to the nature of the security issue, we don't know what may have been compromised in the infrastructure and in the user database. Hence our drastic measures. What does it mean for you? It means that your account information (username + password) might have been compromised, and your account itself could have been compromised (cookie stealth with the attack). We highly recommend you to change your passwords and check that everything is fine on your account. I shall remind you that password change can take up to 6h to propagate to Fisheye & Jira. As a side note, we enabled a while ago Perfect Forward Secrecy on our infrastructure that should ensure that even if our private keys leaked, your past communications (so, login on the infrastructure, for instance) can't be deciphered. Unless your session ticket leaked as well... We are really sorry for the caused inconvenience. I'm available by email or on IRC to answer your questions and clear your doubts. With my best regards, -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

11 years

Short announce: My Serial port-on-MMIO implementation works - allowing debug logging on laptops

by Minas Abrahamyan

Hi all, With this few words I would like to share the joyous event of MMIO-based serial port implementation has finally worked for me. This is the equivalent of earlycon serial port implementation in Linux with some extension (so now it is even better then Linux one) Some work yet is needed to be done to transform the work into the normal patch, but the good news is it is working, and still doesn't require PNPmanager for work, i.e. it starts very early in kernel and writes kernel log messages. I use ExpressCard 34 extension board Serial RS232 port, on laptop, but think it will work fro PC Cards too (former name PCMCIA). ==Importance: Touching the hardware== For the more developers we need more working PC models ( Real Hardware) Almost all modern PCs are laptops with PCIe bus (the rest are desktops) (but few of them able to boot the ReactOS) Modern serial ports are recommended to use /often use MMIO-based data transfer instead of former I/O ports. So now possibility appears to debug these new computers and force the ReactOS to work on this important part of new PCs. Thanks for attention -Minas Abrahamyan PS Curious note: for catching the debug logs I use the (small and cheap) soap box-sized microcontroller board with LCD (ready-unit), and I call it "ReactOS debug logger" appliance. It doesn't take space and doesn't produce any noise

11 years

Re: [ros-dev] [ros-diffs] [pschweitzer] 62675: [CHARMAP] Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible

by Timo Kreuzer

I don't really see the reason here. Whether using the secure function or not is is a question of whether we need null-termination or not. If we need it the secure function will do the right thing. If we do not need null-termination the non-secure function does the right thing and the secure function would not add any security, but simply do the wrong thing. MSDN says about the lfFaceName member of the LOGFONT structure "A null-terminated string that specifies the typeface name of the font. " So we want it to be null-terminated and adding one more character does not add anything useful, but will result in a broken structure. Another difference is that the non-secure function pads the destination array with nulls, the secure function does - afaik - not. If that is the reason, I'd prefer zeroing it out before copying the string. Am 06.04.2014 22:20, schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Sun Apr 6 20:20:39 2014 > New Revision: 62675 > > URL: http://svn.reactos.org/svn/reactos?rev=62675&view=rev > Log: > [CHARMAP] > Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible > > Modified: > trunk/reactos/base/applications/charmap/lrgcell.c > trunk/reactos/base/applications/charmap/map.c > > Modified: trunk/reactos/base/applications/charmap/lrgcell.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… > ============================================================================== > --- trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] Sun Apr 6 20:20:39 2014 > @@ -48,9 +48,9 @@ > hdc); > > lf.lfCharSet = DEFAULT_CHARSET; > - wcscpy_s(lf.lfFaceName, > - sizeof(lf.lfFaceName) / sizeof(lf.lfFaceName[0]), > - lpFontName); > + wcsncpy(lf.lfFaceName, > + lpFontName, > + sizeof(lf.lfFaceName) / sizeof(lf.lfFaceName[0])); > > hFont = CreateFontIndirectW(&lf); > > > Modified: trunk/reactos/base/applications/charmap/map.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… > ============================================================================== > --- trunk/reactos/base/applications/charmap/map.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/charmap/map.c [iso-8859-1] Sun Apr 6 20:20:39 2014 > @@ -228,9 +228,9 @@ > ReleaseDC(infoPtr->hMapWnd, hdc); > > infoPtr->CurrentFont.lfCharSet = DEFAULT_CHARSET; > - wcscpy_s(infoPtr->CurrentFont.lfFaceName, > - sizeof(infoPtr->CurrentFont.lfFaceName) / sizeof(infoPtr->CurrentFont.lfFaceName[0]), > - lpFontName); > + wcsncpy(infoPtr->CurrentFont.lfFaceName, > + lpFontName, > + sizeof(infoPtr->CurrentFont.lfFaceName) / sizeof(infoPtr->CurrentFont.lfFaceName[0])); > > infoPtr->hFont = CreateFontIndirectW(&infoPtr->CurrentFont); > > > >

11 years

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev