Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] [ros-diffs] [cwittich] 63452: [bootdata] convert hivecls.inf and hivedef.inf to UTF16LE fixes CORE-7614

by Thomas Faber

This is not the right solution. SVN has terrible UTF-16 handling so we should not convert these back to UTF-16. https://jira.reactos.org/browse/CORE-7703 https://jira.reactos.org/browse/CORE-8221 On 2014-05-25 22:17, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sun May 25 20:17:25 2014 > New Revision: 63452 > > URL: http://svn.reactos.org/svn/reactos?rev=63452&view=rev > Log: > [bootdata] > convert hivecls.inf and hivedef.inf to UTF16LE > fixes CORE-7614 > > Modified: > trunk/reactos/boot/bootdata/hivecls.inf (contents, props changed) > trunk/reactos/boot/bootdata/hivedef.inf (contents, props changed) >

10 years, 3 months

Regarding recent FAT32 partition handling work by Eric

by Caemyr

I would like to applaud Eric for his outstanding work with ROS partition handling, which we are able to experience since recently. Eric himself had tested this code including GParted, but i`ve that is not all. 7z is able to read FAT partition image files, but this didn't work at all. Right now i was able to open up ROS vmdk image, created by ReactOS itself and view/extract anything of its contents. I cannot express enough how handy this is going to be, allowing to access ROS vm hard disk contents without the pesky hdd mounting (which never really work reliably for me), transferring anything out of the vm by LAN/Internet or booting other VM with those HDDs co-mounted. Simply I cannot thank you enough for your work. Pic included as proof. -- With best regards Caemyr

10 years, 3 months

Re: [ros-dev] [ros-diffs] [cwittich] 63423: [shell32] revert one line of r63414

by Thomas Faber

> --- trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] Fri May 23 17:14:39 2014 > @@ -459,7 +459,7 @@ > startup.dwFlags = STARTF_USESHOWWINDOW; > startup.wShowWindow = psei->nShow; > dwCreationFlags = CREATE_UNICODE_ENVIRONMENT; > - if (!(psei->fMask & SEE_MASK_NO_CONSOLE)) > + if (psei->fMask & SEE_MASK_NO_CONSOLE) > dwCreationFlags |= CREATE_NEW_CONSOLE; > startup.lpTitle = (LPWSTR)(psei->fMask & (SEE_MASK_HASLINKNAME | SEE_MASK_HASTITLE) ? psei->lpClass : NULL); This is the opposite of what the documentation says?

10 years, 4 months

Re: [ros-dev] [ros-diffs] [akhaldi] 63353: [CMAKE/MSVC] * Define _ALLOW_KEYWORD_MACROS to get the news MSVC toolchain to allow us to redefine inline (it became a keyword). Reported by David Quintana.

by Thomas Faber

Hrm, why not just limit the define to C instead? On 2014-05-18 16:39, akhaldi(a)svn.reactos.org wrote: > Author: akhaldi > Date: Sun May 18 14:39:03 2014 > New Revision: 63353 > > URL: http://svn.reactos.org/svn/reactos?rev=63353&view=rev > Log: > [CMAKE/MSVC] > * Define _ALLOW_KEYWORD_MACROS to get the news MSVC toolchain to allow us to redefine inline (it became a keyword). Reported by David Quintana. > > Modified: > trunk/reactos/CMakeLists.txt > > Modified: trunk/reactos/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeLists.txt?rev=63353&r… > ============================================================================== > --- trunk/reactos/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/CMakeLists.txt [iso-8859-1] Sun May 18 14:39:03 2014 > @@ -62,6 +62,9 @@ > if(MSVC) > if(ARCH STREQUAL "i386") > add_definitions(/D_X86_ /DWIN32 /D_WINDOWS) > + endif() > + if(MSVC_VERSION GREATER 1799) > + add_definitions(/D_ALLOW_KEYWORD_MACROS) > endif() > add_definitions(/Dinline=__inline) > else() > >

10 years, 4 months

Re: [ros-dev] [ros-diffs] [hbelusca] 63398: [USETUP] - Fix a bit the translation of yesterday; - Use TEXT_PADDING_BIG instead of hardcoding 3 spaces in the status messages.

by Pierre Schweitzer

On 05/21/2014 02:23 PM, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Wed May 21 12:23:04 2014 > New Revision: 63398 > > URL: http://svn.reactos.org/svn/reactos?rev=63398&view=rev > Log: > [USETUP] > - Fix a bit the translation of yesterday; > - Use TEXT_PADDING_BIG instead of hardcoding 3 spaces in the status messages. > > Modified: > trunk/reactos/base/setup/usetup/lang/fr-FR.h > > Modified: trunk/reactos/base/setup/usetup/lang/fr-FR.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/lang/fr-… > ============================================================================== > --- trunk/reactos/base/setup/usetup/lang/fr-FR.h [iso-8859-1] (original) > +++ trunk/reactos/base/setup/usetup/lang/fr-FR.h [iso-8859-1] Wed May 21 12:23:04 2014 > @@ -642,8 +642,8 @@ > { > 0, > 0, > - " Veuillez attendre ...", > - TEXT_TYPE_STATUS, > + "Veuillez attendre ...", > + TEXT_TYPE_STATUS | TEXT_PADDING_BIG > }, > { > 0, It would be better to have "Veuillez patienter..." "Attendre" sounds so weird in that context. > @@ -850,8 +850,8 @@ > { > 0, > 0, > - " Patienter...", > - TEXT_TYPE_STATUS > + "Patienter...", > + TEXT_TYPE_STATUS | TEXT_PADDING_BIG > }, > { > 0, Here, it's likely to be "Patientez..." (to be checked though). -- Pierre Schweitzer <pierre(a)reactos.org> System Administrator ReactOS Foundation

10 years, 4 months

New Patchbot is ready

by Colin Finck

The new Linux-based Patchbot is finally live. Do whatever you want with it.

10 years, 4 months

Re: [ros-dev] [ros-diffs] [ekohl] 63330: [NTOSKRNL] Partial revert of r63326! The correct partition numbers cause boot failures.

by Alex Ionescu

Lol so maybe you should think twice next time you see "FIXFIX REACTOS HACK" like I originally wrote it ;-) Best regards, Alex Ionescu On Sat, May 17, 2014 at 4:42 PM, <ekohl(a)svn.reactos.org> wrote: > Author: ekohl > Date: Sat May 17 14:42:28 2014 > New Revision: 63330 > > URL: http://svn.reactos.org/svn/reactos?rev=63330&view=rev > Log: > [NTOSKRNL] > Partial revert of r63326! The correct partition numbers cause boot failures. > > Modified: > trunk/reactos/ntoskrnl/fstub/disksup.c > > Modified: trunk/reactos/ntoskrnl/fstub/disksup.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?r… > ============================================================================== > --- trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] Sat May 17 14:42:28 2014 > @@ -1655,7 +1655,9 @@ > UInt32x32To64(GET_PARTITION_LENGTH(PartitionDescriptor), > SectorSize); > > - PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0; > + // BUGBUGBUG: The correct partition numbers seem to cause boot failures!!! > +// PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0; > + PartitionInfo->PartitionNumber = i + 1; > } > else > { > >

10 years, 4 months

libusb-win32 - can we use it?

by Alexander Rechitskiy

http://sourceforge.net/apps/trac/libusb-win32/wiki -- Best regards, Alexander Rechitskiy

10 years, 4 months

Re: [ros-dev] [ros-diffs] [ekohl] 63326: [NTOSKRNL] xHalIoReadPartitionTable: Only used non-container partition entries have a non-zero partition number.

by Pierre Schweitzer

Hey Eric, This fix unfortunately broke trunk. Our four testbots are red. Have a look here, for instance: http://build.reactos.org/builders/Linux_AMD64_1%20KVM-Test/builds/6442/step… Cheers, Pierre On 17/05/2014 14:55, ekohl(a)svn.reactos.org wrote: > Author: ekohl > Date: Sat May 17 12:55:06 2014 > New Revision: 63326 > > URL: http://svn.reactos.org/svn/reactos?rev=63326&view=rev > Log: > [NTOSKRNL] > xHalIoReadPartitionTable: Only used non-container partition entries have a non-zero partition number. > > Modified: > trunk/reactos/ntoskrnl/fstub/disksup.c > > Modified: trunk/reactos/ntoskrnl/fstub/disksup.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?r… > ============================================================================== > --- trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/fstub/disksup.c [iso-8859-1] Sat May 17 12:55:06 2014 > @@ -1655,8 +1655,7 @@ > UInt32x32To64(GET_PARTITION_LENGTH(PartitionDescriptor), > SectorSize); > > - /* FIXME: REACTOS HACK */ > - PartitionInfo->PartitionNumber = i + 1; > + PartitionInfo->PartitionNumber = (!IsContainerPartition(PartitionType)) ? i : 0; > } > else > { > @@ -1667,7 +1666,6 @@ > PartitionInfo->PartitionLength.QuadPart = 0; > PartitionInfo->HiddenSectors = 0; > > - /* FIXME: REACTOS HACK */ > PartitionInfo->PartitionNumber = 0; > } > } > > -- Pierre Schweitzer<pierre at reactos.org> System Administrator ReactOS Foundation

10 years, 4 months

Re: [ros-dev] [ros-diffs] [hbelusca] 63135: Arch, please do not mix up ANSI vs. UNICODE string functions, do you?

by Aleksey Bragin

Speaking of that (1000s time), the proper way would be to convert everything to UNICODE. It would help. Regards, Aleksey Bragin On 03.05.2014 21:24, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Sat May 3 17:24:22 2014 > New Revision: 63135 > > URL: http://svn.reactos.org/svn/reactos?rev=63135&view=rev > Log: > Arch, please do not mix up ANSI vs. UNICODE string functions, do you? > > Modified: > trunk/reactos/base/applications/network/ftp/cmds.c > > Modified: trunk/reactos/base/applications/network/ftp/cmds.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… > ============================================================================== > --- trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] (original) > +++ trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] Sat May 3 17:24:22 2014 > @@ -1303,13 +1303,13 @@ > > if (argc > 1) > { > - strncat(CmdLine, " /C", MAX_PATH - wcslen(Cmdline) - 1); > + strncat(CmdLine, " /C", MAX_PATH - strlen(Cmdline) - 1); > } > > for (i=1; i<argc; i++) > { > - strncat(CmdLine, " ", MAX_PATH - wsclen(Cmdline) - 1); > - strncat(CmdLine, argv[i], MAX_PATH - wsclen(Cmdline) -1); > + strncat(CmdLine, " ", MAX_PATH - strlen(Cmdline) - 1); > + strncat(CmdLine, argv[i], MAX_PATH - strlen(Cmdline) -1); > } > > StartupInfo.cb = sizeof( StartupInfo ); > >

10 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev