Ros-dev

ros-dev@reactos.org

5788 discussions

by Hermès BÉLUSCA - MAÏTO

Hi everybody! During some little maintenance of rosapps I was doing during some work pause, I wanted to know from where we found our still unused (until someone programs the defragmentation API :P) defragger called Fraginator. Since it doesnt contain any information about his initial author I tried to check into the SVN log, and I found that it was added in our codebase in 2006 by Ged: see the commit log http://svn.reactos.org/svn/reactos?view=revision <http://svn.reactos.org/svn/reactos?view=revision&revision=21411> &revision=21411 ; notice that the committer mentioned that [Fraginator] is pretty hard to come by on the net now. Nevertheless nothing is said about his author. However (!!) googling at fraginator defragger, I fell on this webpage, certainly written by the actual Fraginator author: http://blog.getpaint.net/2012/03/28/college-adventures-in-open-source-fragin ator-edition/ . In this blog entry you have the story of the Fraginator defragger! (if someone can add an entry, he/shes welcome). Nice reading! Hermès.

10 years, 4 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 63247: [DDK/XDK/NTOSKRNL/DRIVERS] Fix incompatible definition of a number of NTOSKRNL data imports. These imports are declared in MS DDK in a way that is usually not how you would declar...

by Thomas Faber

Woohoo, thanks! Questions/comments inline. On 2014-05-12 01:11, tkreuzer(a)svn.reactos.org wrote: > --- trunk/reactos/include/ddk/ntifs.h [iso-8859-1] (original) > +++ trunk/reactos/include/ddk/ntifs.h [iso-8859-1] Sun May 11 23:11:16 2014 > @@ -870,11 +870,11 @@ > (NTAPI *PRTL_FREE_STRING_ROUTINE)( > _In_ __drv_freesMem(Mem) _Post_invalid_ PVOID Buffer); > > -extern const PRTL_ALLOCATE_STRING_ROUTINE RtlAllocateStringRoutine; > -extern const PRTL_FREE_STRING_ROUTINE RtlFreeStringRoutine; > +extern NTKERNELAPI const PRTL_ALLOCATE_STRING_ROUTINE RtlAllocateStringRoutine; > +extern NTKERNELAPI const PRTL_FREE_STRING_ROUTINE RtlFreeStringRoutine; > > #if _WIN32_WINNT >= 0x0600 > -extern const PRTL_REALLOCATE_STRING_ROUTINE RtlReallocateStringRoutine; > +extern NTKERNELAPI const PRTL_REALLOCATE_STRING_ROUTINE RtlReallocateStringRoutine; > #endif > > _Function_class_(RTL_HEAP_COMMIT_ROUTINE) Do you have any idea what RtlAllocateStringRoutine and friends are? They don't seem to exist. (NDK defines them for user mode btw, without dllimport) > Modified: trunk/reactos/include/ddk/wdm.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=6324… > ============================================================================== > --- trunk/reactos/include/ddk/wdm.h [iso-8859-1] (original) > +++ trunk/reactos/include/ddk/wdm.h [iso-8859-1] Sun May 11 23:11:16 2014 > @@ -82,10 +85,13 @@ > #endif > > /* For ReactOS */ > -#if !defined(_NTOSKRNL_) && !defined(_BLDR_) > +#if !defined(_NTOSKRNL_) && !defined(_BLDR_) && !defined(_NTSYSTEM_) > #define NTKERNELAPI DECLSPEC_IMPORT > #else > #define NTKERNELAPI > +#ifndef _NTSYSTEM_ > +#define _NTSYSTEM_ > +#endif > #endif > > #if defined(_X86_) && !defined(_NTHAL_) We should probably switch to using _NTSYSTEM_ instead of _NTOSKRNL_ at some point? > @@ -129,6 +135,29 @@ > #define ALLOC_DATA_PRAGMA 1 > #endif > > +#endif /* _MSC_VER */ > + > +/* These macros are used to create aliases for imported data. We need to do > + this to have declarations that are compatible with MS DDK */ > +#ifdef _M_IX86 > +#define __SYMBOL(_Name) "_"#_Name > +#define __IMPORTSYMBOL(_Name) "__imp__"#_Name > +#define __IMPORTNAME(_Name) _imp__##_Name > +#else > +#define __SYMBOL(_Name) #_Name > +#define __IMPORTSYMBOL(_Name) "__imp_"#_Name > +#define __IMPORTNAME(_Name) __imp_##_Name > +#endif > +#ifdef _MSC_VER > +#define __CREATE_NTOS_DATA_IMPORT_ALIAS(_Name) \ > + __pragma(comment(linker, "/alternatename:"__SYMBOL(_Name) "=" __IMPORTSYMBOL(_Name))) > +#else /* !_MSC_VER */ > +#ifndef __STRINGIFY > +#define __STRINGIFY(_exp) #_exp > +#endif > +#define _Pragma_redifine_extname(_Name, _Target) _Pragma(__STRINGIFY(redefine_extname _Name _Target)) > +#define __CREATE_NTOS_DATA_IMPORT_ALIAS(_Name) \ > + _Pragma_redifine_extname(_Name,__IMPORTNAME(_Name)) > #endif > > #if defined(_WIN64) s/redifine/redefine/ > --- trunk/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] Sun May 11 23:11:16 2014 > @@ -1903,9 +1903,7 @@ > > /* We are disabled now */ > KdDebuggerEnabled = FALSE; > -#undef KdDebuggerEnabled > SharedUserData->KdDebuggerEnabled = FALSE; > -#define KdDebuggerEnabled _KdDebuggerEnabled > } > } Should this not use KD_DEBUGGER_ENABLED? (same in kdinit.c)

10 years, 4 months

Re: [ros-dev] [ros-diffs] [cwittich] 63225: [comctl32] Notify the parent on a return key press. fixes return key in device manager

by Hermès BÉLUSCA - MAÏTO

Hi Christoph ! Are you sure that before committing this fix in Wine code, you: 1- made a patch to wine's code, 2- sent it to them, and 3- checked that they merged too in their code base? Because otherwise your fix here might be lost in the next Wine code sync... Cheers, Hermès. -----Message d'origine----- Author: cwittich Date: Sun May 11 05:04:56 2014 New Revision: 63225 URL: http://svn.reactos.org/svn/reactos?rev=63225&view=rev Log: [comctl32] Notify the parent on a return key press. fixes return key in device manager Modified: trunk/reactos/dll/win32/comctl32/treeview.c Modified: trunk/reactos/dll/win32/comctl32/treeview.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/treeview .c?rev=63225&r1=63224&r2=63225&view=diff ============================================================================ == --- trunk/reactos/dll/win32/comctl32/treeview.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/comctl32/treeview.c [iso-8859-1] Sun May 11 05:04:56 2014 @@ -5242,6 +5242,10 @@ newSelection = TREEVIEW_GetNextListItem(infoPtr, prevItem); break; + case VK_RETURN: + TREEVIEW_SendSimpleNotify(infoPtr, NM_RETURN); + break; + case VK_HOME: newSelection = infoPtr->root->firstChild; break;

10 years, 4 months

Re: [ros-dev] [ros-diffs] [hbelusca] 63202: [RPCRT4] Detect whether we are connecting to a pipe on the local machine and use the \\.\ prefix instead of the full machine name. This patch modifies ReactOS-specific code (that ...

by Timo Kreuzer

Am 09.05.2014 03:57, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Fri May 9 01:57:43 2014 > New Revision: 63202 > > URL: http://svn.reactos.org/svn/reactos?rev=63202&view=rev > Log: > [RPCRT4] > Detect whether we are connecting to a pipe on the local machine and use the \\.\ prefix instead of the full machine name. > This patch modifies ReactOS-specific code (that was introduced by Eric in revision 53630) (Wine still supports only local pipes), so I also update our rpcrt4_ros.diff file accordingly, r63201 with respect to the latest Wine 1.7.17 rpcrt4 code. > Modified: trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpcrt4_ro… > ============================================================================== > [...] > > +diff -prudN .\wine\dlls\rpcrt4/msvc.S .\reactos\dll\win32\rpcrt4/msvc.S > +--- .\wine\dlls\rpcrt4/msvc.S 1970-01-01 01:00:00.000000000 +0100 > ++++ .\reactos\dll\win32\rpcrt4/msvc.S 2012-02-14 21:27:35.943001900 +0100 > +@@ -0,0 +1,146 @@ > > +diff -prudN .\wine\dlls\rpcrt4/precomp.h .\reactos\dll\win32\rpcrt4/precomp.h > +--- .\wine\dlls\rpcrt4/precomp.h 1970-01-01 01:00:00.000000000 +0100 > ++++ .\reactos\dll\win32\rpcrt4/precomp.h 2014-03-14 01:43:22.357516600 +0100 > > +diff -prudN .\wine\dlls\rpcrt4/unix_func.c .\reactos\dll\win32\rpcrt4/unix_func.c > +--- .\wine\dlls\rpcrt4/unix_func.c 1970-01-01 01:00:00.000000000 +0100 > ++++ .\reactos\dll\win32\rpcrt4/unix_func.c 2013-01-25 00:19:53.278052800 +0100 Why add these to the diff?

10 years, 4 months

r58367 - Fix a bug in StartupWindowThread

by Aleksey Bragin

Hi, http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/gui.c?r1=… Is there a point in that DuplicateHandle call? "When SetThreadDesktop is called the system closes the desktop handle when needed so we have to create a new handle because this handle may still be in use by winlogon" Sorry, I re-read that comment a few times and still can't understand. I take it that SetThreadDesktop closes the old handle which was set before. And it may, for some reason, be used by winlogon. Shouldn't that be a place to fix, rather than the hack in r58367? And why is the SetThreadDesktop(OldDesk) is removed by this revision? Regards, Aleksey Bragin

10 years, 4 months

Re: [ros-dev] [ros-diffs] [dquintana] 63044: [RSHELL] [SHELL32] * Move the IID_NULL_PPV_ARG macro to the shobj_undoc header, next to the (also ros-specific) IID_PPV_ARG macro, so that it can be used elsewhere. [SHELL32] * M...

by Thomas Faber

On 2014-04-29 13:14, dquintana(a)svn.reactos.org wrote: > [SHELL32] > * Make use of IID_NULL_PPV_ARG in all the calls to GetUIObjectOf, and fix one instance of mismatched riid/pointer. I don't see that mismatch. What am I missing? ;)

10 years, 4 months

Re: [ros-dev] [ros-diffs] [tfaber] 63030: [FIND] - Avoid printf on a non-format string. Spotted by Víctor - Remove broken pseudo-TCHAR usage CORE-8112 #resolve

by Timo Kreuzer

Am 28.04.2014 10:06, schrieb tfaber(a)svn.reactos.org: > @@ -235,9 +235,9 @@ > } > else > { > - LoadString(GetModuleHandle(NULL), IDS_CANNOT_OPEN, (LPTSTR)lpMessage, 4096); > - CharToOem(lpMessage, lpMessage); > - fprintf (stderr, lpMessage, > + LoadString (GetModuleHandle (NULL), IDS_CANNOT_OPEN, szMessage, sizeof(szMessage) / sizeof(szMessage[0])); > + CharToOemA (szMessage, szMessage); > + fprintf (stderr, szMessage, > finddata.name); > } LoadString -> LoadStringA? Also, shouldn't we go unicode?

10 years, 4 months

Re: [ros-dev] [ros-diffs] [tfaber] 63032: [NETCFGX] - Use correct parent key instead of an uninitialized handle in INetCfgComponentControl_fnApplyRegistryChanges CORE-8115 #resolve

by Thomas Faber

Uh, this is missing the "Patch by Víctor Martínez" part, sorry. On 2014-04-28 10:27, tfaber(a)svn.reactos.org wrote: > Author: tfaber > Date: Mon Apr 28 08:27:57 2014 > New Revision: 63032 > > URL: http://svn.reactos.org/svn/reactos?rev=63032&view=rev > Log: > [NETCFGX] > - Use correct parent key instead of an uninitialized handle in INetCfgComponentControl_fnApplyRegistryChanges > CORE-8115 #resolve > > Modified: > trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c > > Modified: trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netcfgx/tcpipcon… > ============================================================================== > --- trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c [iso-8859-1] Mon Apr 28 08:27:57 2014 > @@ -3141,7 +3141,7 @@ > //MessageBoxW(NULL, L"INetCfgComponentControl_fnApplyRegistryChanges", NULL, MB_OK); > > > - if (RegCreateKeyExW(hKey, L"SYSTEM\\CurrentControlSet\\Services\\Tcpip\\Parameters", 0, NULL, 0, KEY_WRITE, NULL, &hKey, NULL) == ERROR_SUCCESS) > + if (RegCreateKeyExW(HKEY_LOCAL_MACHINE, L"SYSTEM\\CurrentControlSet\\Services\\Tcpip\\Parameters", 0, NULL, 0, KEY_WRITE, NULL, &hKey, NULL) == ERROR_SUCCESS) > { > if (pCurrentConfig->pDNS) > { > >

10 years, 4 months

Re: [ros-dev] [ros-diffs] [jimtabor] 63027: [Win32k] - Moved to new menu structures, synced in wine code and started first phase to server side. Resulting that more tests are running and failing less. Unplugged ntuser bad f...

by Thomas Faber

Jim, this introduced a new warning: win32ss/user/user32/windows/menu.c:1952:14: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Thanks. On 2014-04-28 08:40, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Mon Apr 28 03:55:23 2014 > New Revision: 63027 > > URL: http://svn.reactos.org/svn/reactos?rev=63027&view=rev > Log: > [Win32k] > - Moved to new menu structures, synced in wine code and started first phase to server side. Resulting that more tests are running and failing less. Unplugged ntuser bad functions. > - See CORE-5605, CORE-7447, CORE-7967, CORE-8098 and CORE-8107 > > Modified: > trunk/reactos/win32ss/include/ntuser.h > trunk/reactos/win32ss/user/ntuser/accelerator.c > trunk/reactos/win32ss/user/ntuser/menu.c > trunk/reactos/win32ss/user/ntuser/menu.h > trunk/reactos/win32ss/user/ntuser/object.c > trunk/reactos/win32ss/user/ntuser/simplecall.c > trunk/reactos/win32ss/user/ntuser/userfuncs.h > trunk/reactos/win32ss/user/ntuser/window.c > trunk/reactos/win32ss/user/user32/windows/menu.c > > [This mail would be too long, it was shortened to contain the URLs only.] > > Modified: trunk/reactos/win32ss/include/ntuser.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/include/ntuser.h?r… > > Modified: trunk/reactos/win32ss/user/ntuser/accelerator.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/accele… > > Modified: trunk/reactos/win32ss/user/ntuser/menu.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/menu.c… > > Modified: trunk/reactos/win32ss/user/ntuser/menu.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/menu.h… > > Modified: trunk/reactos/win32ss/user/ntuser/object.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/object… > > Modified: trunk/reactos/win32ss/user/ntuser/simplecall.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/simple… > > Modified: trunk/reactos/win32ss/user/ntuser/userfuncs.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/userfu… > > Modified: trunk/reactos/win32ss/user/ntuser/window.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/window… > > Modified: trunk/reactos/win32ss/user/user32/windows/menu.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/window… > >

10 years, 4 months

WebOS and ReactOS

by Alexander Rechitskiy

Let's bring up the webOS topic again. There is an interesting idea to port Nyx portability layer to Win32 and thus make Open webOS running in ReactOS/Windows. Nice user interface would be a benefit! http://www.openwebosproject.org/docs/architecture#.U1l8Uvl_vTo -- Best regards, Alexander Reachitskiy

10 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev