Ros-dev

ros-dev@reactos.org

2 participants
5791 discussions

Resuscitating MSVC 2008 builds (at least) for testing purposes only :P
by Hermès BÉLUSCA - MAÏTO 26 Mar '14

26 Mar '14

Because I was recently shocked (if I may say :D) that, for building a 2003-class operating system, we need 2010+ tools, I was wondering whether it was still possible to build ReactOS with MSVC 2008 and 2005. Ive created a task for that in Jira: http://jira.reactos.org/browse/CORE-8023 . After application of the configure.cmd patch that I give in the report, plus few tweaks in two headers (and adding some stdint.h in the correct directory for MSVC, needed for compiling host-tools, because this file is not included in default MSVC installation until MSVC 2010+), I was able to build a full bootcd and livecd (see the details in the abovementioned report, basically it currently builds with MSVC 2008 but not 2005). However there happens an interesting thing: the [boot|live]cd boots (freeldr seems to work and load the kernel and drivers), but after that, the kernel (debugged in WinDbg) hangs indefinitely here: Windows Server 2003 Kernel Version 3790 UP Checked x86 compatible Built by: 20140326-r62565 Machine Name: Kernel base = 0x80400000 PsLoadedModuleList = 0x005fcf88 System Uptime: not available (f:\ros_vs_test\ntoskrnl\ke\i386\cpu.c:494) Supported CPU features : KF_V86_VIS KF_RDTSC KF_CR4 KF_CMOV KF_GLOBAL_PAGE KF_LARGE_PAGE KF_MTRR KF_CMPXCHG8B KF_MMX KF_WORKING_PTE KF_PAT KF_FXSR KF_FAST_SYSCALL KF_XMMI KF_XMMI64 KF_NX_BIT (f:\ros_vs_test\ntoskrnl\ke\i386\cpu.c:801) Prefetch Cache: 64 bytes L2 Cache: 0 bytes L2 Cache Line: 64 bytes L2 Cache Associativity: 0 <_hangs_forever_here_> If some of you have an idea what *might* happen there, Im all ears! Cheers, Hermès.

2 1

Need assistance on bug 7965
by Alexander Varnin 26 Mar '14

26 Mar '14

Hello, dear developers! Sorry if I am doing something wrong, but I am not sure, if everyone who may help would be notified by JIRA. I made some bug hunting on CORE-7965 and now need some assistance in finding way to fix it. I have posted the results in my last comment on JIRA: http://jira.reactos.org/browse/CORE-7965?focusedCommentId=57456&page=com.at… In short: a bug is related to some interprocess virtual address transmission that is leading to access attempt on unallocated virtual memory, that finally crashes ReactOS.

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 62562: [EXT2] try_return() == try_return(S) with nothing in S . The code sometimes use it. Shut up MSVC warning C4003: not enough actual parameters for macro 'try_return'.
by Thomas Faber 26 Mar '14

26 Mar '14

That's illegal, macros can't be overloaded. drivers/filesystems/ext2/inc/ext2fsd.h:64:0: warning: "try_return" redefined [enabled by default] You could try #define try_return(...) { __VA_ARGS__; goto try_exit; } If that doesn't do it, it might simply need a separate macro (I'm not sure to what extent this is third party code though) (also if these were the last instances of that -- and I think so --, we might want to make 4003 an error) On 2014-03-24 23:20, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Mon Mar 24 22:20:52 2014 > New Revision: 62562 > > URL: http://svn.reactos.org/svn/reactos?rev=62562&view=rev > Log: > [EXT2] > try_return() == try_return(S) with nothing in S . The code sometimes use it. > Shut up MSVC warning C4003: not enough actual parameters for macro 'try_return'. > > Modified: > trunk/reactos/drivers/filesystems/ext2/inc/ext2fsd.h > > Modified: trunk/reactos/drivers/filesystems/ext2/inc/ext2fsd.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/i… > ============================================================================== > --- trunk/reactos/drivers/filesystems/ext2/inc/ext2fsd.h [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/ext2/inc/ext2fsd.h [iso-8859-1] Mon Mar 24 22:20:52 2014 > @@ -60,6 +60,7 @@ > extern Ext2Data Ext2GlobalData; > > // try-finally simulation > +#define try_return() { goto try_exit; } > #define try_return(S) { S; goto try_exit; } > #define try_return1(S) { S; goto try_exit1; } > #define try_return2(S) { S; goto try_exit2; } > >

3 5

Installing and running ReactOS on modern hardware
by Thomas Mueller 24 Mar '14

24 Mar '14

I would like to build and install ReactOS from source but may be strapped for where to install it. I have USB sticks, 3 TB SATA hard drives, and 3 TB USB 3.0 hard drive. Hard drives are GPT-partitioned, which ReactOS apparently doesn't support. I have some old IDE hard drives which I access with USB 2.0 enclosure: 1271 MB and 40 GB. I also have an old 341 MB IDE hard drive that I can't read through USB 2.0 enclosure. I could compile from Linux or FreeBSD with ROSBE, could do further builds that way or with Wine and MinGW under Linux or FreeBSD. I don't want to do heavy compiling on USB stick if I can avoid it. I believe the only file system ReactOS currently supports is FAT16 or FAT32, which limits possible partition size compared to NTFS or Linux or BSD file systems. Can I install to USB stick, 4GB or 8 GB, and are there any other possibilities with my hardware? Tom

2 1

What's happening to the build bots??
by Hermès BÉLUSCA - MAÏTO 21 Mar '14

21 Mar '14

Hi all! Since some time now, most of our build bots are unavailable (see http://build.reactos.org/builders , the ones maintained by Olaf). What is happening to them? I sent him a mail but no answer so far I have received. We *need* those bots! , and especially the patch-bot that I am waiting for, because I have two big patches in my local wc that need to be tested and I cannot proceed further for now (and surely other have too, according to some recent Jira reports). Please fix them asap. if possible :D Cheers, Hermès

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 62480: [PSDK] winternl.h: Fix RtlLookupAtomInAtomTable prototype (should be sent to wine? not sure)
by Thomas Faber 20 Mar '14

20 Mar '14

This is intentional, their RTL_ATOM_TABLE is already a pointer: /* Wine doesn't implement atom table as NT does: * - in NT, atom tables are user space tables, which ntdll directly accesses * - on Wine, (even local) atom tables are wineserver objects, hence a HANDLE */ typedef struct atom_table *RTL_ATOM_TABLE, **PRTL_ATOM_TABLE; So that would need to be changed consistently. (also, winternl.h should be used by Wine code only, so shouldn't affect us -- since we have NDK to use instead) On 2014-03-11 23:48, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Tue Mar 11 22:48:04 2014 > New Revision: 62480 > > URL: http://svn.reactos.org/svn/reactos?rev=62480&view=rev > Log: > [PSDK] > winternl.h: Fix RtlLookupAtomInAtomTable prototype (should be sent to wine? not sure) > > Modified: > trunk/reactos/include/psdk/winternl.h > > Modified: trunk/reactos/include/psdk/winternl.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winternl.h?re… > ============================================================================== > --- trunk/reactos/include/psdk/winternl.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/winternl.h [iso-8859-1] Tue Mar 11 22:48:04 2014 > @@ -632,7 +632,7 @@ > FileFsMaximumInformation > } FS_INFORMATION_CLASS, *PFS_INFORMATION_CLASS; > > -typedef enum _KEY_INFORMATION_CLASS { > +typedef enum _KEY_INFORMATION_CLASS { > KeyBasicInformation = 0, > KeyNodeInformation = 1, > KeyFullInformation = 2, > @@ -2244,7 +2244,7 @@ > DWORD WINAPI RtlLengthSid(PSID); > NTSTATUS WINAPI RtlLocalTimeToSystemTime(const LARGE_INTEGER*,PLARGE_INTEGER); > BOOLEAN WINAPI RtlLockHeap(HANDLE); > -NTSTATUS WINAPI RtlLookupAtomInAtomTable(RTL_ATOM_TABLE,const WCHAR*,RTL_ATOM*); > +NTSTATUS WINAPI RtlLookupAtomInAtomTable(RTL_ATOM_TABLE*,const WCHAR*,RTL_ATOM*); > > NTSTATUS WINAPI RtlMakeSelfRelativeSD(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,LPDWORD); > void WINAPI RtlMapGenericMask(PACCESS_MASK,const GENERIC_MAPPING*); > >

2 1

Thoughts on Kickstarter
by Ólafur Arason 17 Mar '14

17 Mar '14

Hi, I've been following the project for years and I've even used explorer implementation on Windows. I also went to the Montreal event. I'm a linux user so I won't be a full time user any time soon. What I think would make a really good Kickstarter, having watched the Thorium Core progress: Developers Delight: What ReactOS or Thorium D has going for it is fully debugable and fundamental understanding of how Windows works. Microsoft has Visual Studio Online but it's pretty bad, at least at the moment it's a mess to set up. Having a way to run your MinGW-w64 projects, possible compile them. Having support for Clang msvc implementation. And last and not the least is the Visual Studio, which of course is the hardest. Even without that it's going to be really solid. An extra plus is being able to make Windows Embedded development stack running, because Trimble are really tied to that. Also Delphi and what ever other development you can think of. Having git support with CI type workflow is going to be great and with kernel level debug reports what could be better. The MingGW-w64 is going to great for all the open source software developers that need something to develop windows software without touching windows. You should talk with OpenShot they were having problems with that kind of development. This is going to be a double benefit for you guys, not only will it provide you with information about what people are using and what bugs are in your system but also provide a lot of foss software on your platform. Embedded dreams: Now that XP is through people need an embedded version, Windows Embedded isn't it, because it has a really weird api. Vista isn't really there or 7 so, where is your chance. Banks are paying Microsoft to extend XP for their ATMs but not every one can afford it. Enter Thorium E, for all those kiosks and POS. You have greater control so you can build a kit for Embedded user where they decide what's going to be included and what comes up, like not having a screen saver, virus software, IE, only allowing one or two exe files to run and only certain dlls. This would also be perfect to make single use virtual images with only one program running. If you need any help with making the video or with the campaign I would love to help. Regards, Olaf

1 0

[CORE-7969] A week later
by Minas Abrahamyan 15 Mar '14

15 Mar '14

Hi developers, Passed a week after I provided a ready for review and apply patch, a simplest solution for simplest bug. Could anyone review, test, and apply it? https://jira.reactos.org/browse/CORE-7969 Thanks

2 1

ReactOS needs to be self-hostable!
by Hermès BÉLUSCA - MAÏTO 15 Mar '14

15 Mar '14

Hi all ! ReactOS severely needs to be self-hostable for many reasons, one of it because it could allow people who only have Linux to be able to program / debug ReactOS with Windows tools (e.g. we have some people here and there complaining that they cannot use powerful debugging programs for debugging ReactOS (e.g. WinDbg and so on with MSVC builds of ReactOS) and therefore restrain themselves in using the Goode Olde GCC + DPRINT method, because they are running only on Linux). Something more personal is that I really want to program ReactOS on itself (in a VM) when it becomes self-hostable. But there are *only* few steps remaining before ReactOS can really be in such situation !! Ive already tested RosBE on it and I was able to download and configure a build. But there *are still* problems. Here is my setup on a VM: main HDD of letter drive C: with ReactOS, second HDD of letter drive D: with ROS source code in D:\rossrc, third HDD of letter drive E: with build output files in E:\rosbuild . After having successfully configured a build in the usual way (E:\rosbuild> D:\rossrc\configure.cmd), I first tried to compile the host-tools (cd host-tools && ninja). The first thing that Ive noticed is that doing so retriggered a configure, then the compilation as wanted. I retried again, and again it reconfigured the build before actually rebuilding the host-tools. The same phenomenon appears then when trying to build ReactOS proper. After analyzing produced files by the configuration step and comparing with a clean build on windows 2k3, it became clear that few files were missing, because obviously not generated: E:\rosbuild\host-tools\CMakeFiles\2.8.10.2-ReactOS\CMakeCCompiler.cmake and CMakeCXXCompiler.cmake . The other .cmake files that should also be present here (CMakeRCCompiler.cmake and CMakeSystem.cmake) as well as two .bin files and two subdirectories where present (and contain the same things). I was suggesting it might be a problem with the command-line interpreter, so I changed our cmd.exe with the one of windows 2000 (not win2k3, because the latter makes extra calls to some security APIs of advapi32 not implemented on ReactOS before running .bat / .cmd files, and it fails), but nothing changed, the files were not still present. After having enabled extra debug output of cmake (that is called when configuring a build) by adding the flags --debug-output --trace (without quotes) in the cmake calls in configure.cmd (and after redirecting console stdout + stderr to a file when retrigerring a clean configuration), doing that on ReactOS *and* on win2k3 for comparison purposes, I saw that, at some point, some cmake flags concerning compiler recognition (à la: CMAKE_GCC_EXISTS for example) werent set to TRUE or FALSE, but were kept empty. So Im wondering whether it is actually some issue, either concerning our C runtime library (e.g. some called sprintf-like function fails or whatever) is buggy and something fails, OR, something file-system related. Concerning file-system, you know that we have LOTS of kernel32:file winetests failing, about problems for deleting files, recreating (or just creating) them, and so on Maybe for some reason cmake fails to create those CMake(C/CXX)Compiler.cmake files for the same reason one of the kernel32:file tests fail ? I dont know, this previous point being speculative since I didnt test anything regarding that. Therefore it would be very nice *to see you all* trying to uncover where this bug comes from so that you can *finally* declare ReactOS self-hostable before, maybe, the next release !! Cheers, Hermès

2 2

Re: [ros-dev] [ros-diffs] [fireball] 62477: [NTOS] - Remove unneeded macro by David Welch in 2002 and me in 2003.
by Timo Kreuzer 11 Mar '14

11 Mar '14

Good sart, but I'm going to outperform this cleanup approach a bit... ;-) Am 11.03.2014 19:46, schrieb fireball(a)svn.reactos.org: > Author: fireball > Date: Tue Mar 11 18:46:32 2014 > New Revision: 62477 > > URL: http://svn.reactos.org/svn/reactos?rev=62477&view=rev > Log: > [NTOS] > - Remove unneeded macro by David Welch in 2002 and me in 2003. > > Modified: > trunk/reactos/ntoskrnl/mm/i386/page.c > > Modified: trunk/reactos/ntoskrnl/mm/i386/page.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/i386/page.c?re… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] Tue Mar 11 18:46:32 2014 > @@ -40,22 +40,10 @@ > #define PA_ACCESSED (1 << PA_BIT_ACCESSED) > #define PA_GLOBAL (1 << PA_BIT_GLOBAL) > > -#define HYPERSPACE (0xc0400000) > -#define IS_HYPERSPACE(v) (((ULONG)(v) >= HYPERSPACE && (ULONG)(v) < HYPERSPACE + 0x400000)) > +#define IS_HYPERSPACE(v) (((ULONG)(v) >= HYPER_SPACE && (ULONG)(v) <= HYPER_SPACE_END)) > > #define PTE_TO_PFN(X) ((X) >> PAGE_SHIFT) > #define PFN_TO_PTE(X) ((X) << PAGE_SHIFT) > - > -#if defined(__GNUC__) > -#define PTE_TO_PAGE(X) ((LARGE_INTEGER)(LONGLONG)(PAGE_MASK(X))) > -#else > -__inline LARGE_INTEGER PTE_TO_PAGE(ULONG npage) > -{ > - LARGE_INTEGER dummy; > - dummy.QuadPart = (LONGLONG)(PAGE_MASK(npage)); > - return dummy; > -} > -#endif > > const > ULONG > > >

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev