Ros-dev

ros-dev@reactos.org

5789 discussions

Re: [ros-dev] [ros-diffs] [pschweitzer] 62442: [NTOSKRNL] - Implement FsRtlNotifyFilterReportChange - Implement FsRtlNotifyUpdateBuffer - Implement FsRtlCancelNotify - Implement FsRtlNotifyGetLastPartOffset - Fix implementa...

by Jérôme Gardou

Awesomeness, in its purest art. Le 07.03.2014 20:33, pschweitzer(a)svn.reactos.org a écrit : > Author: pschweitzer > Date: Fri Mar 7 19:33:38 2014 > New Revision: 62442 > > URL: http://svn.reactos.org/svn/reactos?rev=62442&view=rev > Log: > [NTOSKRNL] > - Implement FsRtlNotifyFilterReportChange > - Implement FsRtlNotifyUpdateBuffer > - Implement FsRtlCancelNotify > - Implement FsRtlNotifyGetLastPartOffset > - Fix implementation of … [View More]FsRtlNotifyFilterChangeDirectory > > This finishes the implementation of file system notifications inside the kernel. > Data are properly returned to the caller on changes. > > CORE-2582 > > Modified: > trunk/reactos/ntoskrnl/fsrtl/notify.c > trunk/reactos/ntoskrnl/include/internal/fsrtl.h > > Modified: trunk/reactos/ntoskrnl/fsrtl/notify.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/notify.c?re… > ============================================================================== > --- trunk/reactos/ntoskrnl/fsrtl/notify.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/fsrtl/notify.c [iso-8859-1] Fri Mar 7 19:33:38 2014 > @@ -12,6 +12,55 @@ > #define NDEBUG > #include <debug.h> > > +/* INLINED FUNCTIONS *********************************************************/ > + > +/* > + * @implemented > + */ > +FORCEINLINE > +VOID > +FsRtlNotifyAcquireFastMutex(IN PREAL_NOTIFY_SYNC RealNotifySync) > +{ > + ULONG_PTR CurrentThread = (ULONG_PTR)KeGetCurrentThread(); > + > + /* Only acquire fast mutex if it's not already acquired by the current thread */ > + if (RealNotifySync->OwningThread != CurrentThread) > + { > + ExAcquireFastMutexUnsafe(&(RealNotifySync->FastMutex)); > + RealNotifySync->OwningThread = CurrentThread; > + } > + /* Whatever the case, keep trace of the attempt to acquire fast mutex */ > + RealNotifySync->OwnerCount++; > +} > + > +/* > + * @implemented > + */ > +FORCEINLINE > +VOID > +FsRtlNotifyReleaseFastMutex(IN PREAL_NOTIFY_SYNC RealNotifySync) > +{ > + RealNotifySync->OwnerCount--; > + /* Release the fast mutex only if no other instance needs it */ > + if (!RealNotifySync->OwnerCount) > + { > + ExReleaseFastMutexUnsafe(&(RealNotifySync->FastMutex)); > + RealNotifySync->OwningThread = (ULONG_PTR)0; > + } > +} > + > +#define FsRtlNotifyGetLastPartOffset(FullLen, TargLen, Type, Chr) \ > + for (FullPosition = 0; FullPosition < FullLen; ++FullPosition) \ > + if (((Type)NotifyChange->FullDirectoryName->Buffer)[FullPosition] == Chr) \ > + ++FullNumberOfParts; \ > + for (LastPartOffset = 0; LastPartOffset < TargLen; ++LastPartOffset) { \ > + if ( ((Type)TargetDirectory.Buffer)[LastPartOffset] == Chr) { \ > + ++TargetNumberOfParts; \ > + if (TargetNumberOfParts == FullNumberOfParts) \ > + break; \ > + } \ > + } > + > /* PRIVATE FUNCTIONS *********************************************************/ > > VOID > @@ -22,13 +71,161 @@ > FsRtlNotifySetCancelRoutine(IN PIRP Irp, > IN PNOTIFY_CHANGE NotifyChange OPTIONAL); > > +/* > + * @implemented > + */ > VOID > NTAPI > FsRtlCancelNotify(IN PDEVICE_OBJECT DeviceObject, > IN PIRP Irp) > { > + PVOID Buffer; > + PIRP NotifyIrp; > + ULONG BufferLength; > + PIO_STACK_LOCATION Stack; > + PNOTIFY_CHANGE NotifyChange; > + PREAL_NOTIFY_SYNC RealNotifySync; > + PSECURITY_SUBJECT_CONTEXT SubjectContext = NULL; > + > + /* Get the NOTIFY_CHANGE struct and reset it */ > + NotifyChange = (PNOTIFY_CHANGE)Irp->IoStatus.Information; > + Irp->IoStatus.Information = 0; > + /* Reset the cancel routine */ > + IoSetCancelRoutine(Irp, NULL); > + /* And release lock */ > IoReleaseCancelSpinLock(Irp->CancelIrql); > - UNIMPLEMENTED; > + /* Get REAL_NOTIFY_SYNC struct */ > + RealNotifySync = NotifyChange->NotifySync; > + > + FsRtlNotifyAcquireFastMutex(RealNotifySync); > + > + _SEH2_TRY > + { > + /* Remove the IRP from the notifications list and mark it pending */ > + RemoveEntryList(&(Irp->Tail.Overlay.ListEntry)); > + IoMarkIrpPending(Irp); > + > + /* Now, the tricky part - let's find a buffer big enough to hold the return data */ > + if (NotifyChange->Buffer && NotifyChange->AllocatedBuffer == NULL && > + ((Irp->MdlAddress && MmGetSystemAddressForMdl(Irp->MdlAddress) == NotifyChange->Buffer) || > + NotifyChange->Buffer == Irp->AssociatedIrp.SystemBuffer)) > + { > + /* Assume we didn't find any */ > + Buffer = NULL; > + BufferLength = 0; > + > + /* If we don't have IRPs, check if current buffer is big enough */ > + if (IsListEmpty(&NotifyChange->NotifyIrps)) > + { > + if (NotifyChange->BufferLength >= NotifyChange->DataLength) > + { > + BufferLength = NotifyChange->BufferLength; > + } > + } > + else > + { > + /* Otherwise, try to look at next IRP available */ > + NotifyIrp = CONTAINING_RECORD(NotifyChange->NotifyIrps.Flink, IRP, Tail.Overlay.ListEntry); > + Stack = IoGetCurrentIrpStackLocation(NotifyIrp); > + > + /* If its buffer is big enough, get it */ > + if (Stack->Parameters.NotifyDirectory.Length >= NotifyChange->BufferLength) > + { > + /* Is it MDL? */ > + if (NotifyIrp->AssociatedIrp.SystemBuffer == NULL) > + { > + if (NotifyIrp->MdlAddress != NULL) > + { > + Buffer = MmGetSystemAddressForMdl(NotifyIrp->MdlAddress); > + } > + } > + else > + { > + Buffer = NotifyIrp->AssociatedIrp.MasterIrp; > + } > + > + /* Backup our accepted buffer length */ > + BufferLength = Stack->Parameters.NotifyDirectory.Length; > + if (BufferLength > NotifyChange->BufferLength) > + { > + BufferLength = NotifyChange->BufferLength; > + } > + } > + } > + > + /* At that point, we *may* have a buffer */ > + > + /* If it has null length, then note that we won't use it */ > + if (BufferLength == 0) > + { > + NotifyChange->Flags |= NOTIFY_IMMEDIATELY; > + } > + else > + { > + /* If we have a buffer length, but no buffer then allocate one */ > + if (Buffer == NULL) > + { > + PsChargePoolQuota(NotifyChange->OwningProcess, PagedPool, BufferLength); > + Buffer = ExAllocatePoolWithTag(PagedPool | POOL_RAISE_IF_ALLOCATION_FAILURE, BufferLength, 'NrSF'); > + NotifyChange->AllocatedBuffer = Buffer; > + } > + > + /* Copy data in that buffer */ > + RtlCopyMemory(Buffer, NotifyChange->Buffer, NotifyChange->DataLength); > + NotifyChange->ThisBufferLength = BufferLength; > + NotifyChange->Buffer = Buffer; > + } > + > + /* If we don't have valide buffer, ensure everything is 0-ed out */ > + if (NotifyChange->Flags & NOTIFY_IMMEDIATELY) > + { > + NotifyChange->Buffer = 0; > + NotifyChange->AllocatedBuffer = 0; > + NotifyChange->LastEntry = 0; > + NotifyChange->DataLength = 0; > + NotifyChange->ThisBufferLength = 0; > + } > + } > + > + /* It's now time to complete - data are ready */ > + > + /* Set appropriate status and complete */ > + Irp->IoStatus.Status = STATUS_CANCELLED; > + IofCompleteRequest(Irp, EVENT_INCREMENT); > + > + /* If that notification isn't referenced any longer, drop it */ > + if (!InterlockedDecrement((PLONG)&(NotifyChange->ReferenceCount))) > + { > + /* If it had an allocated buffer, delete */ > + if (NotifyChange->AllocatedBuffer) > + { > + PsReturnProcessPagedPoolQuota(NotifyChange->OwningProcess, NotifyChange->ThisBufferLength); > + ExFreePoolWithTag(NotifyChange->AllocatedBuffer, 'NrSF'); > + } > + > + /* In case of full name, remember subject context for later deletion */ > + if (NotifyChange->FullDirectoryName) > + { > + SubjectContext = NotifyChange->SubjectContext; > + } > + > + /* We mustn't have ANY change left anymore */ > + ASSERT(NotifyChange->NotifyList.Flink == NULL); > + ExFreePoolWithTag(NotifyChange, 0); > + } > + } > + _SEH2_FINALLY > + { > + FsRtlNotifyReleaseFastMutex(RealNotifySync); > + > + /* If the subject security context was captured, release and free it */ > + if (SubjectContext) > + { > + SeReleaseSubjectContext(SubjectContext); > + ExFreePool(SubjectContext); > + } > + } > + _SEH2_END; > } > > /* > @@ -58,6 +255,9 @@ > } > } > > +/* > + *@implemented > + */ > PNOTIFY_CHANGE > FsRtlIsNotifyOnList(IN PLIST_ENTRY NotifyList, > IN PVOID FsContext) > @@ -81,22 +281,6 @@ > } > } > return NULL; > -} > - > -FORCEINLINE > -VOID > -FsRtlNotifyAcquireFastMutex(IN PREAL_NOTIFY_SYNC RealNotifySync) > -{ > - ULONG_PTR CurrentThread = (ULONG_PTR)KeGetCurrentThread(); > - > - /* Only acquire fast mutex if it's not already acquired by the current thread */ > - if (RealNotifySync->OwningThread != CurrentThread) > - { > - ExAcquireFastMutexUnsafe(&(RealNotifySync->FastMutex)); > - RealNotifySync->OwningThread = CurrentThread; > - } > - /* Whatever the case, keep trace of the attempt to acquire fast mutex */ > - RealNotifySync->OwnerCount++; > } > > /* > @@ -216,7 +400,7 @@ > > DataLength = NotifyChange->DataLength; > > - NotifyChange->Flags &= (INVALIDATE_BUFFERS | WATCH_TREE); > + NotifyChange->Flags &= (NOTIFY_IMMEDIATELY | WATCH_TREE); > NotifyChange->DataLength = 0; > NotifyChange->LastEntry = 0; > > @@ -233,19 +417,6 @@ > } > } > > -FORCEINLINE > -VOID > -FsRtlNotifyReleaseFastMutex(IN PREAL_NOTIFY_SYNC RealNotifySync) > -{ > - RealNotifySync->OwnerCount--; > - /* Release the fast mutex only if no other instance needs it */ > - if (!RealNotifySync->OwnerCount) > - { > - ExReleaseFastMutexUnsafe(&(RealNotifySync->FastMutex)); > - RealNotifySync->OwningThread = (ULONG_PTR)0; > - } > -} > - > /* > * @implemented > */ > @@ -293,6 +464,91 @@ > > /* Return that we didn't removed cancel routine */ > return FALSE; > +} > + > +/* > + * @implemented > + */ > +BOOLEAN > +FsRtlNotifyUpdateBuffer(OUT PFILE_NOTIFY_INFORMATION OutputBuffer, > + IN ULONG Action, > + IN PSTRING ParentName, > + IN PSTRING TargetName, > + IN PSTRING StreamName, > + IN BOOLEAN IsUnicode, > + IN ULONG DataLength) > +{ > + /* Unless there's an issue with buffers, there's no reason to fail */ > + BOOLEAN Succeed = TRUE; > + ULONG AlreadyWritten = 0, ResultSize; > + > + PAGED_CODE(); > + > + /* Update user buffer with the change that occured > + * First copy parent name if any > + * Then copy target name, there's always one > + * And finally, copy stream name if any > + * If these names aren't unicode, then convert first > + */ > + _SEH2_TRY > + { > + OutputBuffer->NextEntryOffset = 0; > + OutputBuffer->Action = Action; > + OutputBuffer->FileNameLength = DataLength - sizeof(FILE_NOTIFY_INFORMATION); > + if (IsUnicode) > + { > + if (ParentName->Length) > + { > + RtlCopyMemory(OutputBuffer->FileName, ParentName->Buffer, ParentName->Length); > + OutputBuffer->FileName[ParentName->Length / sizeof(WCHAR)] = L'\\'; > + AlreadyWritten = ParentName->Length + sizeof(WCHAR); > + } > + RtlCopyMemory(OutputBuffer->FileName + AlreadyWritten, TargetName->Buffer, TargetName->Length); > + if (StreamName) > + { > + AlreadyWritten += TargetName->Length; > + OutputBuffer->FileName[AlreadyWritten / sizeof(WCHAR)] = L':'; > + RtlCopyMemory(OutputBuffer->FileName + AlreadyWritten + sizeof(WCHAR), > + StreamName->Buffer, StreamName->Length); > + } > + } > + else > + { > + if (!ParentName->Length) > + { > + ASSERT(StreamName); > + RtlCopyMemory(OutputBuffer->FileName, StreamName->Buffer, StreamName->Length); > + } > + else > + { > + RtlOemToUnicodeN(OutputBuffer->FileName, OutputBuffer->FileNameLength, > + &ResultSize, ParentName->Buffer, > + ParentName->Length); > + OutputBuffer->FileName[ResultSize / sizeof(WCHAR)] = L'\\'; > + AlreadyWritten = ResultSize + sizeof(WCHAR); > + > + RtlOemToUnicodeN(OutputBuffer->FileName + AlreadyWritten, > + OutputBuffer->FileNameLength, &ResultSize, > + TargetName->Buffer, TargetName->Length); > + > + if (StreamName) > + { > + AlreadyWritten += ResultSize; > + OutputBuffer->FileName[AlreadyWritten / sizeof(WCHAR)] = L':'; > + RtlOemToUnicodeN(OutputBuffer->FileName + AlreadyWritten + sizeof(WCHAR), > + OutputBuffer->FileNameLength, &ResultSize, > + StreamName->Buffer, StreamName->Length); > + } > + } > + } > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + Succeed = FALSE; > + } > + _SEH2_END; > + > + return Succeed; > } > > /* PUBLIC FUNCTIONS **********************************************************/ > @@ -445,7 +701,7 @@ > > /*++ > * @name FsRtlNotifyFilterChangeDirectory > - * @unimplemented > + * @implemented > * > * FILLME > * > @@ -559,16 +815,16 @@ > NotifyIrp->IoStatus.Status = STATUS_DELETE_PENDING; > IoCompleteRequest(NotifyIrp, EVENT_INCREMENT); > } > - /* Complete if there is directory enumeration and no buffer available any more */ > - if ((NotifyChange->Flags & INVALIDATE_BUFFERS) && (NotifyChange->Flags & ENUMERATE_DIR)) > - { > - NotifyChange->Flags &= ~INVALIDATE_BUFFERS; > + /* Complete now if asked to (and not asked to notify later on) */ > + if ((NotifyChange->Flags & NOTIFY_IMMEDIATELY) && !(NotifyChange->Flags & NOTIFY_LATER)) > + { > + NotifyChange->Flags &= ~NOTIFY_IMMEDIATELY; > IoMarkIrpPending(NotifyIrp); > NotifyIrp->IoStatus.Status = STATUS_NOTIFY_ENUM_DIR; > IoCompleteRequest(NotifyIrp, EVENT_INCREMENT); > } > - /* If no data yet, or directory enumeration, handle */ > - else if (NotifyChange->DataLength == 0 || (NotifyChange->Flags & ENUMERATE_DIR)) > + /* If no data yet, or asked to notify later on, handle */ > + else if (NotifyChange->DataLength == 0 || (NotifyChange->Flags & NOTIFY_LATER)) > { > goto HandleIRP; > } > @@ -612,20 +868,13 @@ > else > { > /* If it can't contain WCHAR, it's ANSI */ > - if (FullDirectoryName->Length < sizeof(WCHAR)) > + if (FullDirectoryName->Length < sizeof(WCHAR) || ((CHAR*)FullDirectoryName->Buffer)[1] != 0) > { > NotifyChange->CharacterSize = sizeof(CHAR); > } > - /* First char is \, so in unicode, right part is 0 > - * whereas in ANSI it contains next char > - */ > - else if (((CHAR*)FullDirectoryName->Buffer)[1] == 0) > + else > { > NotifyChange->CharacterSize = sizeof(WCHAR); > - } > - else > - { > - NotifyChange->CharacterSize = sizeof(CHAR); > } > > /* Now, check is user is willing to watch root */ > @@ -668,7 +917,7 @@ > FsRtlNotifyReleaseFastMutex(RealNotifySync); > > /* If the subject security context was captured and there's no notify */ > - if (SubjectContext && (!NotifyChange || FullDirectoryName)) > + if (SubjectContext && (!NotifyChange || NotifyChange->FullDirectoryName)) > { > SeReleaseSubjectContext(SubjectContext); > ExFreePool(SubjectContext); > @@ -679,7 +928,7 @@ > > /*++ > * @name FsRtlNotifyFilterReportChange > - * @unimplemented > + * @implemented > * > * FILLME > * > @@ -731,7 +980,437 @@ > IN PVOID TargetContext, > IN PVOID FilterContext) > { > - KeBugCheck(FILE_SYSTEM); > + PIRP Irp; > + PVOID OutputBuffer; > + USHORT FullPosition; > + PLIST_ENTRY NextEntry; > + PIO_STACK_LOCATION Stack; > + PNOTIFY_CHANGE NotifyChange; > + PREAL_NOTIFY_SYNC RealNotifySync; > + PFILE_NOTIFY_INFORMATION FileNotifyInfo; > + BOOLEAN IsStream, IsParent, PoolQuotaCharged; > + STRING TargetDirectory, TargetName, ParentName, IntNormalizedParentName; > + ULONG NumberOfBytes, TargetNumberOfParts, FullNumberOfParts, LastPartOffset, ParentNameOffset, ParentNameLength; > + ULONG DataLength, TargetNameLength, AlignedDataLength; > + > + TargetDirectory.Length = 0; > + TargetDirectory.MaximumLength = 0; > + TargetDirectory.Buffer = NULL; > + TargetName.Length = 0; > + TargetName.MaximumLength = 0; > + TargetName.Buffer = NULL; > + ParentName.Length = 0; > + ParentName.MaximumLength = 0; > + ParentName.Buffer = NULL; > + IsStream = FALSE; > + > + PAGED_CODE(); > + > + DPRINT("FsRtlNotifyFilterReportChange(%p, %p, %p, %u, %p, %p, %p, %x, %x, %p, %p)\n", > + NotifySync, NotifyList, FullTargetName, TargetNameOffset, StreamName, NormalizedParentName, > + FilterMatch, Action, TargetContext, FilterContext); > + > + /* We need offset in name */ > + if (!TargetNameOffset && FullTargetName) > + { > + return; > + } > + > + /* Get real structure hidden behind the opaque pointer */ > + RealNotifySync = (PREAL_NOTIFY_SYNC)NotifySync; > + /* Acquire lock - will be released in finally block */ > + FsRtlNotifyAcquireFastMutex(RealNotifySync); > + _SEH2_TRY > + { > + /* Browse all the registered notifications we have */ > + for (NextEntry = NotifyList->Flink; NextEntry != NotifyList; > + NextEntry = NextEntry->Flink) > + { > + /* Try to find an entry matching our change */ > + NotifyChange = CONTAINING_RECORD(NextEntry, NOTIFY_CHANGE, NotifyList); > + if (FullTargetName != NULL) > + { > + ASSERT(NotifyChange->FullDirectoryName != NULL); > + if (!NotifyChange->FullDirectoryName->Length) > + { > + continue; > + } > + > + if (!(FilterMatch & NotifyChange->CompletionFilter)) > + { > + continue; > + } > + > + /* If no normalized name provided, construct it from full target name */ > + if (NormalizedParentName == NULL) > + { > + IntNormalizedParentName.Buffer = FullTargetName->Buffer; > + if (TargetNameOffset != NotifyChange->CharacterSize) > + { > + IntNormalizedParentName.MaximumLength = > + IntNormalizedParentName.Length = TargetNameOffset - NotifyChange->CharacterSize; > + } > + else > + { > + IntNormalizedParentName.MaximumLength = > + IntNormalizedParentName.Length = TargetNameOffset; > + } > + NormalizedParentName = &IntNormalizedParentName; > + } > + > + /* heh? Watched directory bigger than changed file? */ > + if (NormalizedParentName->Length < NotifyChange->FullDirectoryName->Length) > + { > + continue; > + } > + > + /* Same len => parent */ > + if (NormalizedParentName->Length == NotifyChange->FullDirectoryName->Length) > + { > + IsParent = TRUE; > + } > + /* If not, then, we have to be watching the tree, otherwise we don't have to report such changes */ > + else if (!(NotifyChange->Flags & WATCH_TREE)) > + { > + continue; > + } > + /* And finally, we've to check we're properly \-terminated */ > + else > + { > + if (!(NotifyChange->Flags & WATCH_ROOT)) > + { > + if (NotifyChange->CharacterSize == sizeof(CHAR)) > + { > + if (((PSTR)NormalizedParentName->Buffer)[NotifyChange->FullDirectoryName->Length] != '\\') > + { > + continue; > + } > + } > + else > + { > + if (((PWSTR)NormalizedParentName->Buffer)[NotifyChange->FullDirectoryName->Length / sizeof (WCHAR)] != L'\\') > + { > + continue; > + } > + } > + } > + > + IsParent = FALSE; > + } > + > + /* If len matches, then check that both name are equal */ > + if (!RtlEqualMemory(NormalizedParentName->Buffer, NotifyChange->FullDirectoryName->Buffer, > + NotifyChange->FullDirectoryName->Length)) > + { > + continue; > + } > + > + /* Call traverse callback (only if we have to traverse ;-)) */ > + if (!IsParent > + && NotifyChange->TraverseCallback != NULL > + && !NotifyChange->TraverseCallback(NotifyChange->FsContext, > + TargetContext, > + NotifyChange->SubjectContext)) > + { > + continue; > + } > + > + /* And then, filter callback if provided */ > + if (NotifyChange->FilterCallback != NULL > + && FilterContext != NULL > + && !NotifyChange->FilterCallback(NotifyChange->FsContext, FilterContext)) > + { > + continue; > + } > + } > + /* We have a stream! */ > + else > + { > + ASSERT(NotifyChange->FullDirectoryName == NULL); > + if (TargetContext != NotifyChange->SubjectContext) > + { > + continue; > + } > + > + ParentName.Buffer = NULL; > + ParentName.Length = 0; > + IsStream = TRUE; > + IsParent = FALSE; > + } > + > + /* If we don't have to notify immediately, prepare for output */ > + if (!(NotifyChange->Flags & NOTIFY_IMMEDIATELY)) > + { > + /* If we have something to output... */ > + if (NotifyChange->BufferLength) > + { > + /* Get size of the output */ > + NumberOfBytes = 0; > + Irp = NULL; > + if (!NotifyChange->ThisBufferLength) > + { > + if (IsListEmpty(&NotifyChange->NotifyIrps)) > + { > + NumberOfBytes = NotifyChange->BufferLength; > + } > + else > + { > + Irp = CONTAINING_RECORD(NotifyChange->NotifyIrps.Flink, IRP, Tail.Overlay.ListEntry); > + Stack = IoGetCurrentIrpStackLocation(Irp); > + NumberOfBytes = Stack->Parameters.NotifyDirectory.Length; > + } > + } > + else > + { > + NumberOfBytes = NotifyChange->ThisBufferLength; > + } > + > + /* If we're matching parent, we don't care about parent (redundant) */ > + if (IsParent) > + { > + ParentName.Length = 0; > + } > + else > + { > + /* If we don't deal with streams, some more work is required */ > + if (!IsStream) > + { > + if (NotifyChange->Flags & WATCH_ROOT || > + (NormalizedParentName->Buffer != FullTargetName->Buffer)) > + { > + /* Construct TargetDirectory if we don't have it yet */ > + if (TargetDirectory.Buffer == NULL) > + { > + TargetDirectory.Buffer = FullTargetName->Buffer; > + TargetDirectory.Length = TargetNameOffset; > + if (TargetNameOffset != NotifyChange->CharacterSize) > + { > + TargetDirectory.Length = TargetNameOffset - NotifyChange->CharacterSize; > + } > + TargetDirectory.MaximumLength = TargetDirectory.Length; > + } > + /* Now, we start looking for matching parts (unless we watch root) */ > + TargetNumberOfParts = 0; > + if (!(NotifyChange->Flags & WATCH_ROOT)) > + { > + FullNumberOfParts = 1; > + if (NotifyChange->CharacterSize == sizeof(CHAR)) > + { > + FsRtlNotifyGetLastPartOffset(NotifyChange->FullDirectoryName->Length, > + TargetDirectory.Length, PSTR, '\\'); > + } > + else > + { > + FsRtlNotifyGetLastPartOffset(NotifyChange->FullDirectoryName->Length / sizeof(WCHAR), > + TargetDirectory.Length / sizeof(WCHAR), PWSTR, L'\\'); > + LastPartOffset *= NotifyChange->CharacterSize; > + } > + } > + > + /* Then, we can construct proper parent name */ > + ParentNameOffset = NotifyChange->CharacterSize + LastPartOffset; > + ParentName.Buffer = &TargetDirectory.Buffer[ParentNameOffset]; > + ParentNameLength = TargetDirectory.Length; > + } > + else > + { > + /* Construct parent name even for streams */ > + ParentName.Buffer = &NormalizedParentName->Buffer[NotifyChange->FullDirectoryName->Length] + NotifyChange->CharacterSize; > + ParentNameLength = NormalizedParentName->Length - NotifyChange->FullDirectoryName->Length; > + ParentNameOffset = NotifyChange->CharacterSize; > + } > + ParentNameLength -= ParentNameOffset; > + ParentName.Length = ParentNameLength; > + ParentName.MaximumLength = ParentNameLength; > + } > + } > + > + /* Start to count amount of data to write, we've first the structure itself */ > + DataLength = FIELD_OFFSET(FILE_NOTIFY_INFORMATION, FileName); > + > + /* If stream, we'll just append stream name */ > + if (IsStream) > + { > + ASSERT(StreamName != NULL); > + DataLength += StreamName->Length; > + } > + else > + { > + /* If not parent, we've to append parent name */ > + if (!IsParent) > + { > + if (NotifyChange->CharacterSize == sizeof(CHAR)) > + { > + DataLength += RtlOemStringToCountedUnicodeSize(&ParentName); > + } > + else > + { > + DataLength += ParentName.Length; > + } > + DataLength += sizeof(WCHAR); > + } > + > + /* Look for target name & construct it, if required */ > + if (TargetName.Buffer) > + { > + TargetNameLength = TargetName.Length; > + } > + else > + { > + TargetName.Buffer = &FullTargetName->Buffer[TargetNameOffset]; > + TargetNameLength = FullTargetName->Length - TargetNameOffset; > + TargetName.Length = TargetNameLength; > + TargetName.MaximumLength = TargetNameLength; > + } > + > + /* Then, we will append it as well */ > + if (NotifyChange->CharacterSize == sizeof(CHAR)) > + { > + DataLength += RtlOemStringToCountedUnicodeSize(&TargetName); > + } > + else > + { > + DataLength += TargetName.Length; > + } > + > + /* If we also had a stream name, then we can append it as well */ > + if (StreamName != NULL) > + { > + if (NotifyChange->CharacterSize == sizeof(WCHAR)) > + { > + DataLength += StreamName->Length + sizeof(WCHAR); > + } > + else > + { > + DataLength = DataLength + RtlOemStringToCountedUnicodeSize(&TargetName) + sizeof(CHAR); > + } > + } > + } > + > + /* Get the position where we can put our data (aligned!) */ > + AlignedDataLength = ROUND_UP(NotifyChange->DataLength, sizeof(ULONG)); > + /* If it's higher than buffer length, then, bail out without outputing */ > + if (DataLength > NumberOfBytes || AlignedDataLength + DataLength > NumberOfBytes) > + { > + NotifyChange->Flags |= NOTIFY_IMMEDIATELY; > + } > + else > + { > + OutputBuffer = 0; > + FileNotifyInfo = 0; > + /* If we already had a buffer, update last entry position */ > + if (NotifyChange->Buffer != NULL) > + { > + FileNotifyInfo = (PVOID)((ULONG_PTR)NotifyChange->Buffer + NotifyChange->LastEntry); > + FileNotifyInfo->NextEntryOffset = AlignedDataLength - NotifyChange->LastEntry; > + NotifyChange->LastEntry = AlignedDataLength; > + /* And get our output buffer */ > + OutputBuffer = (PVOID)((ULONG_PTR)NotifyChange->Buffer + AlignedDataLength); > + } > + /* If we hadn't buffer, try to find one */ > + else if (Irp != NULL) > + { > + if (Irp->AssociatedIrp.SystemBuffer != NULL) > + { > + OutputBuffer = Irp->AssociatedIrp.SystemBuffer; > + } > + else if (Irp->MdlAddress != NULL) > + { > + OutputBuffer = MmGetSystemAddressForMdl(Irp->MdlAddress); > + } > + > + NotifyChange->Buffer = OutputBuffer; > + NotifyChange->ThisBufferLength = NumberOfBytes; > + } > + > + /* If we couldn't find one, then allocate one */ > + if (NotifyChange->Buffer == NULL) > + { > + PoolQuotaCharged = FALSE; > + _SEH2_TRY > + { > + PsChargePoolQuota(NotifyChange->OwningProcess, PagedPool, NumberOfBytes); > + PoolQuotaCharged = TRUE; > + OutputBuffer = ExAllocatePoolWithTag(PagedPool | POOL_RAISE_IF_ALLOCATION_FAILURE, > + NumberOfBytes, 'NrSF'); > + NotifyChange->Buffer = OutputBuffer; > + NotifyChange->AllocatedBuffer = OutputBuffer; > + } > + /* If something went wrong during allocation, notify immediately instead of outputing */ > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + if (PoolQuotaCharged) > + { > + PsReturnProcessPagedPoolQuota(NotifyChange->OwningProcess, NumberOfBytes); > + } > + NotifyChange->Flags |= NOTIFY_IMMEDIATELY; > + } > + _SEH2_END; > + } > + > + /* Finally, if we have a buffer, fill it in! */ > + if (OutputBuffer != NULL) > + { > + if (FsRtlNotifyUpdateBuffer((FILE_NOTIFY_INFORMATION *)OutputBuffer, > + Action, &ParentName, &TargetName, > + StreamName, NotifyChange->CharacterSize == sizeof(WCHAR), > + DataLength)) > + { > + NotifyChange->DataLength = DataLength + AlignedDataLength; > + } > + /* If it failed, notify immediately */ > + else > + { > + NotifyChange->Flags |= NOTIFY_IMMEDIATELY; > + } > + } > + } > + > + /* If we have to notify right now (something went wrong?) */ > + if (NotifyChange->Flags & NOTIFY_IMMEDIATELY) > + { > + /* Ensure that all our buffers are NULL */ > + if (NotifyChange->Buffer != NULL) > + { > + if (NotifyChange->AllocatedBuffer != NULL) > + { > + PsReturnProcessPagedPoolQuota(NotifyChange->OwningProcess, NotifyChange->ThisBufferLength); > + ExFreePoolWithTag(NotifyChange->AllocatedBuffer, 'NrSF'); > + } > + > + NotifyChange->Buffer = NULL; > + NotifyChange->AllocatedBuffer = NULL; > + NotifyChange->LastEntry = 0; > + NotifyChange->DataLength = 0; > + NotifyChange->ThisBufferLength = 0; > + } > + } > + } > + } > + > + /* If asking for old name in case of a rename, notify later on, > + * so that we can wait for new name. > + * http://msdn.microsoft.com/en-us/library/dn392331.aspx > + */ > + if (Action == FILE_ACTION_RENAMED_OLD_NAME) > + { > + NotifyChange->Flags |= NOTIFY_LATER; > + } > + else > + { > + NotifyChange->Flags &= ~NOTIFY_LATER; > + if (!IsListEmpty(&NotifyChange->NotifyIrps)) > + { > + FsRtlNotifyCompleteIrpList(NotifyChange, STATUS_SUCCESS); > + } > + } > + } > + } > + _SEH2_FINALLY > + { > + FsRtlNotifyReleaseFastMutex(RealNotifySync); > + } > + _SEH2_END; > } > > /*++ > > Modified: trunk/reactos/ntoskrnl/include/internal/fsrtl.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… > ============================================================================== > --- trunk/reactos/ntoskrnl/include/internal/fsrtl.h [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/include/internal/fsrtl.h [iso-8859-1] Fri Mar 7 19:33:38 2014 > @@ -53,9 +53,9 @@ > // Notifications flags > // > #define WATCH_TREE 0x01 > -#define INVALIDATE_BUFFERS 0x02 > +#define NOTIFY_IMMEDIATELY 0x02 > #define CLEANUP_IN_PROCESS 0x04 > -#define ENUMERATE_DIR 0x08 > +#define NOTIFY_LATER 0x08 > #define WATCH_ROOT 0x10 > #define DELETE_IN_PROCESS 0x20 > > > [View Less]

11 years, 1 month

NDIS NdisIMRegisterLayeredMiniport

by Maxime Daniel

Hello, I need to use NDIS NdisIMRegisterLayeredMiniport functions to provide a virtual ethernet card. I read the documentation on MSDN and it seems that this functions is required to build an adapter without physical link (eg, with no hardware IRQ). The problem is that this function is not implemented yet on reactos (svn rev. 62083). Is someone can tell me if it's implementable or if there is an alternative to build a virtual ethernet adapter with current implementation of NDIS. Thanks. -- … [View More]

11 years, 1 month

Re: [ros-dev] [ros-diffs] [hbelusca] 62419: [APITESTS:kernel32] Be more specific about which last error we expect.

by Timo Kreuzer

IIRC, we have something like ok_lasterror() Am 05.03.2014 02:53, schrieb hbelusca(a)svn.reactos.org: > Author: hbelusca > Date: Wed Mar 5 01:53:46 2014 > New Revision: 62419 > > URL: http://svn.reactos.org/svn/reactos?rev=62419&view=rev > Log: > [APITESTS:kernel32] > Be more specific about which last error we expect. > > Modified: > trunk/rostests/apitests/kernel32/dosdev.c > > Modified: trunk/rostests/apitests/kernel32/dosdev.c > URL: http://… [View More]svn.reactos.org/svn/reactos/trunk/rostests/apitests/kernel32/dosdev.… > ============================================================================== > --- trunk/rostests/apitests/kernel32/dosdev.c [iso-8859-1] (original) > +++ trunk/rostests/apitests/kernel32/dosdev.c [iso-8859-1] Wed Mar 5 01:53:46 2014 > @@ -137,7 +137,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -168,7 +168,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -203,7 +203,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -266,7 +266,7 @@ > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > hnd = FindFirstFileA(SUBST_DRIVE_SEARCH, &Data); > ok(hnd == INVALID_HANDLE_VALUE, "Opened subst drive when it should fail\n"); > - ok(GetLastError() == ERROR_INVALID_NAME, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_INVALID_NAME, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_INVALID_NAME), GetLastError()); > if (hnd) FindClose(hnd); > Result = DefineDosDeviceA(DDD_REMOVE_DEFINITION, SUBST_DRIVE, NULL); > ok(Result, "Failed to remove subst drive using NULL Target name\n"); > @@ -313,7 +313,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -333,7 +333,7 @@ > ok(Result, "Failed to subst drive\n"); > DriveType1 = GetDriveTypeA(SUBST_DRIVE_WITH_TRAILING_PATH_SEPERATOR); > ok(DriveType1 != SystemDriveType, "subst drive types match when it shouldn't\n"); > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_FILE_NOT_FOUND), GetLastError()); > dwMaskCur = GetLogicalDrives(); > ok(dwMaskCur != dwMaskPrev, "Drive masks match when it shouldn't\n"); > ok((dwMaskCur & (1 << (SUBST_DRIVE_LETTER - 'A'))), "Drive bit is not set\n"); > @@ -362,7 +362,7 @@ > ok(Result, "Failed to subst drive\n"); > Result = QueryDosDeviceA(SUBST_DRIVE, Buffer, 0); > ok(!Result, "Should fail as the buffer passed is supposed to be small\n"); > - ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_INSUFFICIENT_BUFFER), GetLastError()); > Result = QueryDosDeviceA(SUBST_DRIVE, Buffer, MAX_PATH); > ok(Result, "failed to get target path\n"); > ok(_strnicmp(Buffer, "\\??\\", 4) == 0, "The target returned does have correct prefix set\n"); > @@ -374,7 +374,7 @@ > /* This will try to retrieve all existing MS-DOS device names */ > Result = QueryDosDeviceA(NULL, Buffer, 0); > ok(!Result, "Should fail as the buffer passed is supposed to be small\n"); > - ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "GetLastError() reports unexpected error code\n"); > + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "Wrong last error. Expected %lu, got %lu\n", (DWORD)(ERROR_INSUFFICIENT_BUFFER), GetLastError()); > } > > START_TEST(dosdev) > > > [View Less]

11 years, 1 month

About hotpatchable dlls on ReactOS

by Hermès BÉLUSCA - MAÏTO

Hi guys ! It seems to appear that some games need standard APIs hotpatchable, in the sense of MS: few extra bytes present in the prologue of the functions that allow somebody to detour the API. I knew that this feature was useful for windows updates, but what I didnt know is that there are other programs that use it: see this answer from James on the Epic Win! forum thread: http://www.reactos.org/forum/viewtopic.php?f=2 <http://www.reactos.org/forum/viewtopic.php?f=2&t=10972&… [View More]

11 years, 2 months

jira account

by Alexander Varnin

Hello! I have registered on main site, because I want to login to JIRA, but JIRA says now that my login is incorrect. Does it need some time to make JIRA accout accessible after registration? Or I need to do some actions? Do I need to request account for JIRA separately?

11 years, 2 months

Short Testman downtime tomorrow

by Colin Finck

Hi all, In the process of improving the performance of our website and finally getting rid of old.reactos.org, I'm moving away the Testman database to a new VM tomorrow. This will cause a short downtime, in which you're unable to browse Testman results or submit new ones. Even if something goes wrong during that process, the downtime shouldn't last longer than 2 hours. With best regards, Colin

11 years, 2 months

Status Meeting (February 2014)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last Thursday of this month, 27th of February, 19:00 UTC. Put that into your calendars so you don't forget. And that's in two days! IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of … [View More]

11 years, 2 months

Fwd: [ReactOS Deutschland e.V.] Your organization application has been rejected.

by Amine Khaldi

-------- Original Message -------- Subject: [ReactOS Deutschland e.V.] Your organization application has been rejected. Date: Mon, 24 Feb 2014 18:40:28 +0000 From: no-reply(a)google-melange.appspotmail.com To: amine.khaldi(a)reactos.org Thank you for submitting ReactOS Deutschland e.V.'s application to Google Summer of Code 2014. Unfortunately, we were unable to accept your organization's application at this time. Every year we receive many more applications than we are able to … [View More]

11 years, 2 months

VIA Embedded at Embedded World 2014

by Alexander Rechitskiy

Could somebody visit and represent ReactOS to VIA Embedded at Embedded World 2014? http://www.embedded-world.de/en/ February 25th - 27th in Nuremberg Germany -- Best regards, Alexander Rechitskiy

11 years, 2 months

Changes on FishEye

by Colin Finck

Hi all, I've added the "project-tools" and "web" repositories to FishEye today, so you can browse through their changes as well now. My ultimate plan is to remove "CORE", "ROSAPPS" and "ROSTESTS" too and replace all of them by the already existing "reactos" repository. This resembles our SVN counterparts exactly. I was told this has already been tried in the past with no success due to severe performance issues. As FishEye is running on a more powerful server now, please try again and tell me … [View More]

11 years, 2 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev