Ros-dev

ros-dev@reactos.org

5791 discussions

April 2012 Meeting Minutes
by Amine Khaldi 27 Apr '12

27 Apr '12

April 2012 Meeting Minutes 2012-04-26 19:00 UTC Fezile, #meeting Proceedings =========== * Meeting started at 19:20 UTC by Amine Khaldi. * Point 1: The state of Trunk ----------------------------- * Amine Khaldi mentioned that we still have several regressions to get fixed. Olaf Siejka stressed the fact that developers should actually look into these regressions and fix them, and wondered about the optimal selection process to ensure this. * Timo Kreuzer suggested that we should assign these regressions, to increase the possibility of having them fixed. He explained that the selection should be by the guilty revision first (the revision that triggers the regression), and the author of that revision should at least take a look, and if it's *really* not his fault and he can't fix it, then he can assign it back to ros-bugs. * Amine Khaldi mentioned that at the moment there is no way to know what developers are working on exactly, until they commit, and suggested using bug reports to document the development, so that commits will mention them at the end. * Amine also suggested the following process for the regressions: We assign those regressions to the author of the guilty revision, the developer investigates the regression. If he's able to fix the bug, he changes the bug status to "Assigned" which means he now owns this bug. If he can't fix it, he will document his finding so far (a comment in the bug report) and he assigns the bug to any other developer that he thinks he can fix this, and so on. * Everyone agreed, as a result, that we should assign regressions, and that developers should look at what's assigned to them. * Point 2: Overview of the Atlassian tools ------------------------------------------ * Amine Khaldi gave an overview of what we plan to do with Atlassian products (Jira, FishEye, Crucible, Bamboo..etc) in case people didn't go to their website to read about them and watch their videos (http://www.atlassian.com/). * Olaf Siejka asked about an ETA for the Atlassian tools adoption. Aleksey Bragin mentioned that this will happen in the coming two weeks. * Point 3: Discussing a possible change in the release cycle ------------------------------------------------------------ * Alexander Rechitskiy presented some links from the KDE project about their svn guidelines, commit policy, release schedule, minor point releases...etc. * After a lengthy discussion, the team decided to continue the already started efforts to improve efficiency and minimize regressions (like leveraging Patchbot, the recent major Testman improvements...etc). * Meeting closed at 21:26 UTC by Amine Khaldi. * Minutes written by Amine Khaldi.

1 0

2nd Boot Regional Settings Crash
by James Tabor 27 Apr '12

27 Apr '12

Hi! Did anyone notices this? I think someone on IRC tried to point this out to me..... Tested: rundll32.exe shell32.dll,Control_RunDLL input.dll from the cmd line and it works. user32/windows/message.c:1441) CallWindowProcW Unicode Failed! Msg 273 WndProc 71C25AC8 Entered debugger on first-chance exception (Exception Code: 0xc0000005) (Page Fault) Memory at 0x71C2D810 could not be written: Page protection violation. kdb:> bt Eip: <kernel32.dll:ea7f> client/proc.c:2709 (CreateProcessInternalW@48) Frames: <kernel32.dll:fbd8> client/proc.c:3299 (CreateProcessW@40) <syssetup.DLL:4a9c> syssetup/wizard.c:837 (RunControlPanelApplet) <syssetup.DLL:5c4e> syssetup/wizard.c:914 (LocalePageDlgProc@16) RunControlPanelApplet(hwndDlg, L"rundll32.exe shell32.dll,Control_RunDLL input.dll,@1"); <user32.dll:4dfdc> windows/message.c:1407 (@IntCallWindowProcW@28) <user32.dll:4fd7e> windows/message.c:1747 (CallWindowProcW@20) <user32.dll:36184> windows/dialog.c:1701 (DefDlgProcW@16) <user32.dll:4dfdc> windows/message.c:1407 (@IntCallWindowProcW@28) <user32.dll:4e735> windows/message.c:1667 (IntCallMessageProc@24) <user32.dll:4ea2f> windows/message.c:2266 (SendMessageW@16) <user32.dll:3b57> controls/button.c:424 (ButtonWndProc_common@20) <user32.dll:42a2> controls/button.c:612 (ButtonWndProcW@16) <user32.dll:4dfdc> windows/message.c:1407 (@IntCallWindowProcW@28) <user32.dll:4e735> windows/message.c:1667 (IntCallMessageProc@24) <user32.dll:4fa2b> windows/message.c:1916 (DispatchMessageW@4) <user32.dll:35a65> windows/dialog.c:2591 (IsDialogMessageW@8) <syssetup.DLL:6612> syssetup/wizard.c:2408 (InstallWizard) <syssetup.DLL:2448> syssetup/install.c:957 (InstallReactOS@4) <setup.exe:10cc> <setup.exe:21dc> <setup.exe:149b>--- Press q to abort, any other key to continue --- <setup.exe:14fd> <kernel32.dll:fc4a> <00000000>

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 56356: [NTOSKRNL] Fix SepGet*FromDescriptor, returning NULL, when the relative offset is 0. Fixes VMware tools installer.
by Ged Murphy 18 Apr '12

18 Apr '12

> Author: tkreuzer > [NTOSKRNL] > Fix SepGet*FromDescriptor, returning NULL, when the relative offset is 0. > Fixes VMware tools installer. Someone buy that man a beer!

4 3

Does CMake take longer than rbuild
by Marvin Zhang 13 Apr '12

13 Apr '12

Hi guys, I have compiled the whole project and just want to copy ntoskrnl. Here is what I execute: --------------------------------------------------------------------- D:\ReactOS\src\ReactOS-0.3.14-CLT2012>make ntoskrnl_install [COPY] Z:\ReactOS\system32\ntoskrnl.exe Total Build Time: 00:02:04 --------------------------------------------------------------------- I don't know why it takes more than 2 minutes. Is it correct? Thanks.

4 5

The ReactOS Foundation takes part in the IPv6 Launch Day
by Pierre Schweitzer 11 Apr '12

11 Apr '12

Hi, this year, the 6th of June will be once again a special day. This will be the one, the Internet Society has chosen to launch IPv6: http://www.worldipv6launch.org/. It means that starting with this day, all the participant will enable IPv6 and provide it the days, months, years after. The ReactOS Foundation will take part in this event. Currently some services and servers are already available in IPv6, but are not fully maintained. Starting with the 6th of June, major ReactOS services and servers will be available for everybody with IPv6. A roadmap for IPv6 deployment can be found on the ReactOS wiki at: https://www.reactos.org/wiki/IPv6. You will be able to follow all the progress with IPv6. This means that after the 6th of June, any ReactOS developer will be able to work with an IPv6 only on our infrastructure. The transition will be done smoothly. With my best regards, -- Pierre Schweitzer <pierre(a)reactos.org> Systems Administrator ReactOS Foundation

1 0

I'd like to hear about your plans for 0.4.0
by Brent Newland 07 Apr '12

07 Apr '12

I've posted a topic on the Forums to discuss the roadmap to 0.4.0 (whatever it may be). ReactOS has been on the 0.3.x branch for almost six years, and there's been talk of 0.4, so I'd like to hear from any developers on what plans or goals you might have for 0.4.0, whenever it comes out (within 1-2 years?) If you don't currently have any concrete goals or plans (which I've heard is a possibility), then perhaps it would be a good time to start a dialog between developers and the community so we can start to get an idea of what your (ReactOS) expectations are, and what's in store. http://www.reactos.org/forum/viewtopic.php?f=2&t=11114 It could also give you something to point people to when people ask about 0.4.

2 1

Re: [ros-dev] [ros-diffs] [akhaldi] 56311: * Reorganize the whole ReactOS codebase into a new layout. Discussing it will only waste time, so we better have it then talk about it after. * Put ntoskrnl and ntdll in the same f...
by Aleksey Bragin 06 Apr '12

06 Apr '12

02.04.2012 0:42, akhaldi(a)svn.reactos.org пишет: > Author: akhaldi > Date: Sun Apr 1 20:42:43 2012 > New Revision: 56311 > > URL: http://svn.reactos.org/svn/reactos?rev=56311&view=rev > Log: > * Discussing it will only waste time, so we better have it then talk about it after. I was thinking it's some of my old commits, until I read the line about april fools day :) > * I'm just kidding, you know, April's fool and all ;) > WBR, Aleksey.

1 0

Re: [ros-dev] [ros-diffs] [sginsberg] 56333: - Even while I love having the trap/fpu/context code in C, the bugs this switch introduced continue to amaze me. This time, fix a bug from 45156 when KiFlushNPXState was rewritte...
by Aleksey Bragin 06 Apr '12

06 Apr '12

That was a nice catch! 07.04.2012 0:13, sginsberg(a)svn.reactos.org пишет: > Author: sginsberg > Date: Fri Apr 6 20:13:33 2012 > New Revision: 56333 > > URL: http://svn.reactos.org/svn/reactos?rev=56333&view=rev > Log: > - Even while I love having the trap/fpu/context code in C, the bugs this switch introduced continue to amaze me. This time, fix a bug from 45156 when KiFlushNPXState was rewritten in C. The C version could miss to restore the interrupt state, which would lead to interrupts being disabled when it was not expected. This "interrupt leak" was seen in the page fault handler if a page fault occurred after interrupts had been disabled (which had sometimes been observed to occur on the test server during exception handling and thread creation when KiFlushNPXState had been called). This didn't completely hang the system because during thread creation (and other system calls where this may have happened) interrupts would be re-enabled when returning to user mode when restoring eflags, and the exception handling would result in a system call which would enable interrupts again (it appears exception handler would have run with interrupts disabled, though!). This is now fixed, as well as any other issues this might have caused. The hack in the page fault handler remains until another issue has been fixed. > > Modified: > trunk/reactos/ntoskrnl/ke/i386/cpu.c > > Modified: trunk/reactos/ntoskrnl/ke/i386/cpu.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/cpu.c?rev… > ============================================================================== > --- trunk/reactos/ntoskrnl/ke/i386/cpu.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ke/i386/cpu.c [iso-8859-1] Fri Apr 6 20:13:33 2012 > @@ -1323,7 +1323,12 @@ > if (Thread->NpxState != NPX_STATE_LOADED) > { > /* If there's nothing to load, quit */ > - if (!SaveArea) return; > + if (!SaveArea) > + { > + /* Restore interrupt state and return */ > + __writeeflags(EFlags); > + return; > + } > > /* Need FXSR support for this */ > ASSERT(KeI386FxsrPresent == TRUE); > >

1 0

March 2012 Meeting Minutes
by Colin Finck 30 Mar '12

30 Mar '12

March 2012 Meeting Minutes 2012-03-29 19:00 UTC Fezile, #meeting Proceedings =========== * Meeting started at 19:00 UTC by Aleksey Bragin. * Point 1: The state of Trunk ----------------------------- * Cameron Gutman gave some examples how badly Trunk has regressed since 0.3.14: - Frequent bugchecks and assertions in the console - Broken Unicode in the console - Several key apps such as Firefox, Ping, Dwnl and Notepad being broken or rarely working He opened a discussion about improving the quality of Trunk. * Timo Kreuzer favorized a stricter revert-on-regressions policy. By employing the Patchbot buildslave, "evil" changes should be detected in advance before committing them. According to Giannis Adamopoulos, the Patchbot currently needs 20 minutes in total for building and testing a patch. * Colin Finck asked whether the current regressions were visible in the automated regression tests. Aleksey Bragin denied this for most of them as these were usability problems not detected by our regression tests. * Various people suggested frameworks such as AutoIt and AutoHotKey to automate application testing as well. * To also automate real hardware testing, Jan Blomqvist Kinander has set up another server. He reported that he could successfully perform a remote ReactOS installation on it and just needs some scripts to automate the procedures now. * Aleksey Bragin illustrated his plan to move more towards loosely managed development. In particular, he wants to introduce Atlassian tools such as FishEye and JIRA to plan activity and actually do stuff. * Cameron Gutman wanted a firm decision about dealing with regressions first. Aleksey Bragin responded that the current rules still apply: A commit shall be reverted after one day if it breaks booting or installation. Other regressions shall be reported in Bugzilla using the REGRESSION prefix. * Olaf Siejka criticized the way bugs are currently handled. The list at http://www.reactos.org/wiki/Bug_Filters#Patch_review_list is getting bigger and bigger while developers don't take responsibility for it. He added that a decision was taken to release early last month, although no progress towards implementing it was visible. * Alex Ionescu joined the meeting later and reopened the discussion about using Atlassian tools. In his opinion, JIRA and FishEye can support our development along with Bamboo as a build and continuous integration system. Later on, these systems could be set up to only accept a commit if it can be successfully built by Bamboo. - Olaf Siejka wants to set up a Bamboo test system to evaluate the tool. - Alex Ionescu will send out an E-Mail as soon as our setup is ready for testing. * Point 2: Plan for the next month ---------------------------------- * The previous discussion about improving development using new tools continued here. While Aleksey Bragin outlined that he wants to finish the setup in April, Alex Ionescu gave more examples about what needs to be changed when moving to JIRA: - A dynamic component maintainer list should be added to establish a clear chain of responsibility for all parts of ReactOS. - User privileges should be changed to let only component maintainers classify their bugs. * Furthermore, the list at http://www.reactos.org/wiki/Bug_Filters#Patch_review_list has been discussed again. Alex Ionescu and Timo Kreuzer agreed that such general lists are pointless and the following approach was suggested instead: - Developers owning bugs and being mailed about them - Release not being made until all important bugs are fixed - Someone to prioritize which bugs are blocking a release * Alex Ionescu outlined more ideas about improving the release process. He suggested to create a roadmap for each release and picking several specific bugs as goals for this release. Only fixes for these bugs should go into a release, new features could be prepared in branches. * The branches idea was picked up by Amine Khaldi who questioned that SVN was able to properly handle more branches for new features, release preparation, etc. due to its limited branching capabilities. * Alex Ionescu did not agree with this, because people can merge just subdirectories of a branch into Trunk or even bundle all changes in .patch files and simply apply them. * Timo Kreuzer called for a feature freeze in Trunk before the discussion on point 2 ended, but Aleksey Bragin stated that this would prevent further work on fixing Mm. * Aleksey Bragin finally repeated that he is going to finish the setup of the new tools in April and wants to get everybody used to them. The idea of having modules owners shall get more developer responsibility towards issues and patches. * Point 3: Next release discussion ---------------------------------- * Aleksey Bragin postponed this discussion to the next meeting as most of the topics have already been covered in the discussion about Trunk. No objections were raised. * Point 4: New website status ----------------------------- * Maciej Bialas reported that he is at the point of applying small fixes now as well as importing the user database into Drupal. He stated that every user needs to change his password after the migration because of different hashing algorithms used in Drupal and RosCMS. * Pierre Schweitzer noted that we should prevent another mass mailing of all registered users due to the problems caused by the last one. * Ziliang Guo proposed to just create a sticky forum post and write a mail to a ReactOS mailing list about the password changes. There were no objections. * The participants agreed to continue discussions about website content on the mailing lists. * Point 5: Miscellaneous ------------------------ * Giannis Adamopoulos picked up the new subsystem layout for Win32k, which had already been discussed a year ago and was postponed. He outlined it at http://pastie.org/3694259. Aleksey Bragin, James Tabor and Timo Kreuzer agreed on it, so it will be committed within the next 4 days. * Art Yerkes reported about his work on NewCC. In particular, he is currently looking at a bug not existing in a non-NewCC build. He expects other issues afterwards, but thinks that the entire work is progressing well. * Meeting closed at 21:55 UTC by Aleksey Bragin. * Minutes written by Colin Finck.

3 2

Facebook fanpage
by Ged Murphy 29 Mar '12

29 Mar '12

All Facebook fanpages will be to switch to the new timeline layout this weekend. This means we need a cover picture for our reactos fan page. If artistic guys out there wanna put something together, we'll upload it to our fanpage. Maybe someone could start a thread in the forum to gather some interest? Cheers, Ged.

2 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev