Ros-dev

ros-dev@reactos.org

5791 discussions

Re: [ros-dev] [ros-diffs] [akhaldi] 56104: [CMAKE] * Fix a typo.
by Jérôme Gardou 10 Mar '12

10 Mar '12

Le 10/03/2012 19:02, akhaldi(a)svn.reactos.org a écrit : > Author: akhaldi > Date: Sat Mar 10 18:02:40 2012 > New Revision: 56104 > > URL: http://svn.reactos.org/svn/reactos?rev=56104&view=rev > Log: > [CMAKE] > * Fix a typo. > > Modified: > trunk/reactos/cmake/msvc.cmake > > Modified: trunk/reactos/cmake/msvc.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=56104… > ============================================================================== > --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Sat Mar 10 18:02:40 2012 > @@ -178,7 +178,7 @@ > > # add our library > # NOTE: as stub file and def file are generated in one pass, depending on one is like depending on the other > - _add_library(lib${_file} STATIC EXCLUDE_FROM_ALL > + add_library(lib${_file} STATIC EXCLUDE_FROM_ALL > ${CMAKE_CURRENT_BINARY_DIR}/lib${_file}_stubs.asm) > > # set correct "link rule" > > it wasn't a typo :-)

1 0

Re: [ros-dev] buildbot failure in ReactOS on Windows_AMD64_1 VBox-Test
by caemyr＠myopera.com 10 Mar '12

10 Mar '12

Added yet another check, this time for all builders, which will stop any run passed without revision number. On Sat, Mar 10, 2012, at 05:34 AM, buildbot(a)reactos.org wrote: > The Buildbot has finished a build on builder Windows_AMD64_1 VBox-Test > while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/5238 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Windows_AMD64_2 > > Build Reason: Triggerable(Windows_AMD64_1 VBox-Test Trigger) > Build Source Stamp: 56097 > Blamelist: > > BUILD FAILED: failed Initial preparations > > sincerely, > -The Buildbot > -- With best regards Caemyr

1 0

Re: [ros-dev] buildbot exception in ReactOS on Windows_AMD64_1 VBox-Test
by caemyr＠myopera.com 10 Mar '12

10 Mar '12

Strange vbox lockup at the end of 2nd stage. Build restarted, went fine this time. On Sat, Mar 10, 2012, at 01:24 AM, buildbot(a)reactos.org wrote: > The Buildbot has finished a build on builder Windows_AMD64_1 VBox-Test > while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/5236 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Windows_AMD64_2 > > Build Reason: Triggerable(Windows_AMD64_1 VBox-Test Trigger) > Build Source Stamp: 56096 > Blamelist: spetreolle > > BUILD FAILED: exception test > > sincerely, > -The Buildbot > -- With best regards Caemyr

1 0

Re: [ros-dev] [ros-diffs] [jgardou] 56082: [DAMN_IT] - addendum to r56081
by Jérôme Gardou 08 Mar '12

08 Mar '12

Hey! Can't we add tests to the regular tree, and disable them with a onig flag or something. This is getting retarded, and we must be the only project separating tests and runtime in their tree. Every tester should just build them (not speaking about developers...), and we include them in nightly builds. For me this separation is just pointless... regards. Jérôme Le 07/03/2012 22:46, jgardou(a)svn.reactos.org a écrit : > Author: jgardou > Date: Wed Mar 7 21:46:15 2012 > New Revision: 56082 > > URL: http://svn.reactos.org/svn/reactos?rev=56082&view=rev > Log: > [DAMN_IT] > - addendum to r56081 > > Modified: > trunk/rostests/apitests/w32kdll/w32kdll_2k3sp2/CMakeLists.txt > trunk/rostests/apitests/w32kdll/w32kdll_ros/CMakeLists.txt > trunk/rostests/apitests/w32kdll/w32kdll_vista/CMakeLists.txt > trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt > > Modified: trunk/rostests/apitests/w32kdll/w32kdll_2k3sp2/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… > ============================================================================== > --- trunk/rostests/apitests/w32kdll/w32kdll_2k3sp2/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/rostests/apitests/w32kdll/w32kdll_2k3sp2/CMakeLists.txt [iso-8859-1] Wed Mar 7 21:46:15 2012 > @@ -1,5 +1,5 @@ > > -spec2def(w32kdll_2k3sp2.dll w32kdll_2k3sp2.spec) > +spec2def(w32kdll_2k3sp2.dll w32kdll_2k3sp2.spec ADD_IMPORTLIB) > > add_library(w32kdll_2k3sp2 SHARED > main.c > @@ -9,4 +9,3 @@ > set_entrypoint(w32kdll_2k3sp2 0) > > add_dependencies(w32kdll_2k3sp2 psdk ) > -add_importlib_target(w32kdll_2k3sp2.spec w32kdll_2k3sp2.dll) > > Modified: trunk/rostests/apitests/w32kdll/w32kdll_ros/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… > ============================================================================== > --- trunk/rostests/apitests/w32kdll/w32kdll_ros/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/rostests/apitests/w32kdll/w32kdll_ros/CMakeLists.txt [iso-8859-1] Wed Mar 7 21:46:15 2012 > @@ -1,5 +1,5 @@ > > -spec2def(w32kdll_ros.dll w32kdll_ros.spec) > +spec2def(w32kdll_ros.dll w32kdll_ros.spec ADD_IMPORTLIB) > > add_library(w32kdll_ros SHARED > main.c > @@ -10,4 +10,3 @@ > target_link_libraries(w32kdll_ros win32ksys) > > add_dependencies(w32kdll_ros psdk) > -add_importlib_target(w32kdll_ros.spec w32kdll_ros.dll) > > Modified: trunk/rostests/apitests/w32kdll/w32kdll_vista/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… > ============================================================================== > --- trunk/rostests/apitests/w32kdll/w32kdll_vista/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/rostests/apitests/w32kdll/w32kdll_vista/CMakeLists.txt [iso-8859-1] Wed Mar 7 21:46:15 2012 > @@ -1,5 +1,5 @@ > > -spec2def(w32kdll_dll.spec w32kdll_vista.spec) > +spec2def(w32kdll_vista.spec w32kdll_vista.spec ADD_IMPORTLIB) > > add_library(w32kdll_vista SHARED > main.c > @@ -8,4 +8,3 @@ > set_entrypoint(w32kdll_vista 0) > > add_dependencies(w32kdll_vista psdk ) > -add_importlib_target(w32kdll_vista.spec w32kdll_dll.spec) > > Modified: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… > ============================================================================== > --- trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt [iso-8859-1] Wed Mar 7 21:46:15 2012 > @@ -1,4 +1,4 @@ > -spec2def(w32kdll_xpsp2.dll w32kdll_xpsp2.spec) > +spec2def(w32kdll_xpsp2.dll w32kdll_xpsp2.spec ADD_IMPORTLIB) > > add_library(w32kdll_xpsp2 SHARED > main.c > @@ -6,5 +6,4 @@ > ${CMAKE_CURRENT_BINARY_DIR}/w32kdll_xpsp2.def) > set_entrypoint(w32kdll_xpsp2 0) > > -add_dependencies(w32kdll_xpsp2 psdk ) > -add_importlib_target(w32kdll_xpsp2.spec w32kdll_xpsp2.dll) > +add_dependencies(w32kdll_xpsp2 psdk) > >

10 18

Re: [ros-dev] [ros-diffs] [jgardou] 56083: Branch for C++. Amine will be proud.
by Aleksey Bragin 08 Mar '12

08 Mar '12

On 08.03.2012 2:27, jgardou(a)svn.reactos.org wrote: > Author: jgardou > Date: Wed Mar 7 22:27:48 2012 > New Revision: 56083 > > URL: http://svn.reactos.org/svn/reactos?rev=56083&view=rev > Log: > Branch for C++. > Amine will be proud. > Me too ;)

3 2

Re: [ros-dev] [ros-diffs] [pschweitzer] 56077: [DDK] Fix release build?
by Timo Kreuzer 08 Mar '12

08 Mar '12

This belongs into ntdef.h Am 07.03.2012 20:46, schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Wed Mar 7 19:46:16 2012 > New Revision: 56077 > > URL: http://svn.reactos.org/svn/reactos?rev=56077&view=rev > Log: > [DDK] > Fix release build? > > Modified: > trunk/reactos/include/ddk/wdm.h > > Modified: trunk/reactos/include/ddk/wdm.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=5607… > ============================================================================== > --- trunk/reactos/include/ddk/wdm.h [iso-8859-1] (original) > +++ trunk/reactos/include/ddk/wdm.h [iso-8859-1] Wed Mar 7 19:46:16 2012 > @@ -128,6 +128,16 @@ > #define ALLOC_DATA_PRAGMA 1 > #endif > > +/* Add NOP_FUNCTION support */ > +#ifndef NOP_FUNCTION&& (_MSC_VER>= 1210) > +#define NOP_FUNCTION __noop > +#else > +#define NOP_FUNCTION (void)0 > +#endif > +#else > +#ifndef NOP_FUNCTION > +#define NOP_FUNCTION (void)0 > +#endif > #endif > > #if defined(_WIN64) > > >

1 0

Re: [ros-dev] buildbot failure in ReactOS on Windows_AMD64_1 VBox-Test
by caemyr＠myopera.com 07 Mar '12

07 Mar '12

One last bug squashed (hopefully) - now testbot should detect missing ISO and break up runtime at prepare stage. On Wed, Mar 7, 2012, at 11:30 AM, buildbot(a)reactos.org wrote: > The Buildbot has finished a build on builder Windows_AMD64_1 VBox-Test > while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/5220 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Windows_AMD64_2 > > Build Reason: The web-page 'rebuild' button was pressed by 'osiejka': > > Build Source Stamp: 56072 > Blamelist: > > BUILD FAILED: failed Initial preparations > > sincerely, > -The Buildbot > -- With best regards Caemyr

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 56069: [NTOSKRNL] - Fix the unload path - This does expose some bugs: 2 cont-able assertions in ARM3 after unplugging a USB storage device (during usbstor unload), HID unload doesn't seem...
by Cameron Gutman 06 Mar '12

06 Mar '12

[NTOSKRNL] - Fix the unload path - This does expose some bugs: 2 cont-able assertions in ARM3 after unplugging a USB storage device (during usbstor unload), HID unload doesn't seem to work correctly (somebody still has references to the devices), other issues may pop up too I've tracked this issue down to using loader heap to allocate the LDR data entry (which gets freed by the kernel during init). This makes it invalid when we go to read the module object when we unload it, causing a crash. I'm not sure how to move forward from here but the changes needed are in FreeLoader's peloader.c. After fixing that, I'm running into another issue where it appears that LdrEntry->LoadedImports is no longer valid (set for boot drivers during kernel init) so it results in a null pointer dereference. I've confirmed that this crash only occurs when boot loaded drivers are unloaded; any other PnP driver loaded after boot unloads perfectly. Richard (or someone else knowledgeable in the area), if you could take a few minutes to figure this out for me that would be fantastic. Here is the log and backtrace after I fixed the LDR data entry allocation type: (C:\Users\Cam\reactos\trunk\ntoskrnl\io\iomgr\device.c:447) Unloading driver '\Driver\usbstor' (automatic) (C:\Users\Cam\reactos\trunk\ntoskrnl\io\iomgr\driver.c:61) Deleting driver object '\Driver\usbstor' (C:\Users\Cam\reactos\trunk\ntoskrnl\mm\ARM3\sysldr.c:935) Leaking driver: usbstor.sys Entered debugger on first-chance exception (Exception Code: 0xc0000005) (Page Fault) Memory at 0x00000000 could not be read: Page not present. kdb:> bt Eip: <NTOSKRNL.EXE:b0c71 (ReactOS/ntoskrnl/mm/ARM3/sysldr.c:389 (MiDereferenceImports@4))> Frames: <NTOSKRNL.EXE:b0a7f (ReactOS/ntoskrnl/mm/ARM3/sysldr.c:947 (MmUnloadSystemImage@4))> <NTOSKRNL.EXE:5ce2c (ReactOS/ntoskrnl/io/iomgr/driver.c:80 (IopDeleteDriver@4))> <NTOSKRNL.EXE:d63f5 (ReactOS/ntoskrnl/ob/oblife.c:211 (ObpDeleteObject@8))> <NTOSKRNL.EXE:da790 (ReactOS/ntoskrnl/ob/obref.c:237 (@ObfDereferenceObject@4))> <NTOSKRNL.EXE:59c24 (ReactOS/ntoskrnl/io/iomgr/device.c:61 (IopDeleteDevice@4))> <NTOSKRNL.EXE:d63f5 (ReactOS/ntoskrnl/ob/oblife.c:211 (ObpDeleteObject@8))> <NTOSKRNL.EXE:da790 (ReactOS/ntoskrnl/ob/obref.c:237 (@ObfDereferenceObject@4))> <NTOSKRNL.EXE:73adc (ReactOS/ntoskrnl/io/pnpmgr/pnpmgr.c:1286 (IopSynchronousCall@12))> <NTOSKRNL.EXE:73b23 (ReactOS/ntoskrnl/io/pnpmgr/pnpmgr.c:585 (IopSendRemoveDevice@4))> <NTOSKRNL.EXE:7532a (ReactOS/ntoskrnl/io/pnpmgr/pnpmgr.c:2214 (IopEnumerateDevice))> <NTOSKRNL.EXE:7550c (ReactOS/ntoskrnl/io/pnpmgr/pnpmgr.c:4672 (IoSynchronousInvalidateDeviceRelations@8))> <NTOSKRNL.EXE:75530 (ReactOS/ntoskrnl/io/pnpmgr/pnpmgr.c:889 (IopAsynchronousInvalidateDeviceRelations@8))> <NTOSKRNL.EXE:6a737 (ReactOS/ntoskrnl/io/iomgr/iowork.c:27 (IopWorkItemCallback@4))> <NTOSKRNL.EXE:42056 (ReactOS/ntoskrnl/ex/work.c:162 (ExpWorkerThreadEntryPoint@4))> <NTOSKRNL.EXE:efaca (ReactOS/ntoskrnl/ps/thread.c:156 (PspSystemThreadStartup@8))> <NTOSKRNL.EXE:100d63 (ReactOS/ntoskrnl/ke/i386/thrdini.c:78 (KiThreadStartup@0))> <NTOSKRNL.EXE:efa66 (ReactOS/ntoskrnl/ps/thread.c:625 (PsCreateSystemThread@28))> Regards, Cameron

1 0

Problems with patchbot/newcc/rosbe
by caemyr＠myopera.com 06 Mar '12

06 Mar '12

After a quick look into your problems with patchbot it seems that vbox scripts were missing some errorlevel checks, which should bail out the test run at prepare stage when ISO was not present (which is the situation when you dont pass the proper revision/id number. Same thing was with newcc1 tests. I added some debug prints so if my current solution wont do its job, i`ll at least know bit more about the problem. By that occasion i found out a problem with current ROSBE - its not emitting proper ERRORLEVEL at the end of the build, due to tee/buildtime/flash/sound playback or any of similar crap that is getting the final ERRORLEVEL value. For main building step i hacked around this issue by simply checking for ISO file at the end and erroring out if its not there. For host building part, this is more complicated. I tried removing the stuff mentioned above, but it still doesnt work. Dreimer: it would be of help if you could fix this problem. -- With best regards Caemyr

4 5

Fwd: buildbot failure in ReactOS on Windows_AMD64_1 VBox-Test
by caemyr＠myopera.com 06 Mar '12

06 Mar '12

Sorry for the error spam, had to fix one erroneous check (that forced exiting with errorlevel 0 instead of the proper one). ----- Original message ----- From: buildbot(a)reactos.org To: caemyr(a)myopera.com Date: Tue, 06 Mar 2012 21:18:43 +0000 Subject: buildbot failure in ReactOS on Windows_AMD64_1 VBox-Test The Buildbot has finished a build on builder Windows_AMD64_1 VBox-Test while building ReactOS. Full details are available at: http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/5204 Buildbot URL: http://build.reactos.org/ Buildslave for this Build: Windows_AMD64_2 Build Reason: The web-page 'rebuild' button was pressed by 'osiejka': Build Source Stamp: 56063 Blamelist: cgutman BUILD FAILED: failed Initial preparations sincerely, -The Buildbot -- With best regards Caemyr

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev