Ros-dev

ros-dev@reactos.org

5788 discussions

New set of potential(?) bugs and its fixes(?)

by victor martinez

This is a new set of potential bugs found via Viva64: Example 1. ReactOS project. Incorrect printing of a WCHAR-character( regproc.c 293) . static void REGPROC_unescape_string(WCHAR* str) { ... default: fprintf(stderr, "Warning! Unrecognized escape sequence: \\%c'\n", str[str_idx]); ... }Reason: To fix the code, we should replace '%c' with '%C' in the format string. Example 2. ReactOS project. Assignment error. (menu.c 4347) BOOL WINAPI GetMenuItemInfoA(...) { ... mii->cch = mii->cch; ... } Example 16. ReactOS project. Misprint in a macro.( win32k gradient.c 343 ) #define SWAP(a,b,c) c = a;\ a = b;\ a = c Example 8. ReactOS object. Choosing a wrong object. void CardButton::DrawRect(HDC hdc, RECT *rect, bool fNormal) { ... HPEN hhi = CreatePen(0, 0, MAKE_PALETTERGB(crHighlight)); HPEN hsh = CreatePen(0, 0, MAKE_PALETTERGB(crShadow)); ... if(fNormal) hOld = SelectObject(hdc, hhi); else hOld = SelectObject(hdc, hhi); ... } The 'then' statement is equivalent to the 'else' statement. cardlib cardbutton.cpp 83 The 'hsh' object is not used, while 'hhi' is used twice. This is the correct code: if(fNormal) hOld = SelectObject(hdc, hhi); else hOld = SelectObject(hdc, hsh); Example 10. ReactOS project. Mistake in a variable name. BOOL APIENTRY GreStretchBltMask(...) { ... MaskPoint.x += DCMask->ptlDCOrig.x; MaskPoint.y += DCMask->ptlDCOrig.x; ... } Consider reviewing the correctness of 'x' item's usage. win32k bitblt.c 670 Example 4. ReactOS project. Incorrect calculation of a string length ( vbe.c 57 ) static const PCHAR Nv11Board = "NV11 (GeForce2) Board"; static const PCHAR Nv11Chip = "Chip Rev B2"; static const PCHAR Nv11Vendor = "NVidia Corporation"; BOOLEAN IsVesaBiosOk(...) { ... if (!(strncmp(Vendor, Nv11Vendor, sizeof(Nv11Vendor))) && !(strncmp(Product, Nv11Board, sizeof(Nv11Board))) && !(strncmp(Revision, Nv11Chip, sizeof(Nv11Chip))) && (OemRevision == 0x311)) ... }Reason: The error here is this: the sizeof() operator, absolutely inappropriate in this situation, is used to calculate string lengths. The sizeof() operator actually calculates the pointer size instead of the number of bytes in a string. In this case Abragin said this is not a bug. I'm sending here to discuss about them ;).Are they valid? Link: http://www.viva64.com/en/a/0079/

12 years, 10 months

Kdserial use in first stage

by Sylvain Petreolle

Automatic Continue in kdb has been implemented and improves the debugging on the test bots. However, the KVM bot can't use it in the first stage because it is controlled by keyboard entries at this time. I propose to switch the first stage to kdserial as well. Any objections ? Kind regards, Sylvain Petreolle

12 years, 10 months

Fwd: buildbot failure in ReactOS on CMake_x86_MSVCWin Debug

by caemyr＠myopera.com

..\..\dll\win32\avifil32\avifile_Hu.rc(32) : error RC2101 : invalid directive in preprocessed RC file Still broken, since winesync Best regards ----- Original message ----- From: buildbot(a)reactos.org To: caemyr(a)myopera.com Date: Thu, 15 Mar 2012 23:12:01 +0000 Subject: buildbot failure in ReactOS on CMake_x86_MSVCWin Debug The Buildbot has finished a build on builder CMake_x86_MSVCWin Debug while building ReactOS. Full details are available at: http://build.reactos.org/builders/CMake_x86_MSVCWin%20Debug/builds/808 Buildbot URL: http://build.reactos.org/ Buildslave for this Build: Windows_AMD64_1 Build Reason: scheduler Build Source Stamp: 56167 Blamelist: rharabien BUILD FAILED: failed building bootcd sincerely, -The Buildbot -- With best regards Caemyr

12 years, 10 months

Commit by tfaber :: r56146 / (2 files in 2 dirs): (link) [CLT2012] Done here. Tag the release.

by Javier Agustìn Fernàndez Arroyo

Shouldn´t have you done this in the CTL2012 branch instead of trunk?

12 years, 10 months

Re: [ros-dev] [ros-diffs] [rharabien] 56132: [COMCTL32] - When installing dll copy manifest to winsxs\manifests directory as comctl32 before sync did. Fixes Firefox 10 regression. See issue #6910 for more details.

by Timo Kreuzer

I would prefer if ros specific code would be seperated as much as possible to avoid huge diff files. The bigger the diff file, the more likely it will cause issues in the next sync. Am 12.03.2012 15:16, schrieb rharabien(a)svn.reactos.org: > Author: rharabien > Date: Mon Mar 12 14:16:58 2012 > New Revision: 56132 > > URL: http://svn.reactos.org/svn/reactos?rev=56132&view=rev > Log: > [COMCTL32] > - When installing dll copy manifest to winsxs\manifests directory as comctl32 before sync did. Fixes Firefox 10 regression. > See issue #6910 for more details. > > Modified: > trunk/reactos/dll/win32/comctl32/commctrl.c > > Modified: trunk/reactos/dll/win32/comctl32/commctrl.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/commctr… > ============================================================================== > --- trunk/reactos/dll/win32/comctl32/commctrl.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/comctl32/commctrl.c [iso-8859-1] Mon Mar 12 14:16:58 2012 > @@ -71,6 +71,19 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(commctrl); > > +#define NAME L"microsoft.windows.common-controls" > +#define VERSION L"6.0.2600.2982" > +#define PUBLIC_KEY L"6595b64144ccf1df" > + > +#ifdef __i386__ > +#define ARCH L"x86" > +#elif defined __x86_64__ > +#define ARCH L"amd64" > +#else > +#define ARCH L"none" > +#endif > + > +static const WCHAR manifest_filename[] = ARCH L"_" NAME L"_" PUBLIC_KEY L"_" VERSION L"_none_deadbeef.manifest"; > > static LRESULT WINAPI COMCTL32_SubclassProc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam); > > @@ -91,6 +104,67 @@ > static const WCHAR strCC32SubclassInfo[] = { > 'C','C','3','2','S','u','b','c','l','a','s','s','I','n','f','o',0 > }; > + > +static BOOL create_manifest(BOOL install) > +{ > + WCHAR *pwszBuf; > + HRSRC hResInfo; > + HGLOBAL hResData; > + PVOID pManifest; > + DWORD cchBuf, cbManifest, cbWritten; > + HANDLE hFile; > + BOOL bRet = FALSE; > + > + hResInfo = FindResourceW(COMCTL32_hModule, L"WINE_MANIFEST", RT_MANIFEST); > + if (!hResInfo) > + return FALSE; > + > + cbManifest = SizeofResource(COMCTL32_hModule, hResInfo); > + if (!cbManifest) > + return FALSE; > + > + hResData = LoadResource(COMCTL32_hModule, hResInfo); > + if (!hResData) > + return FALSE; > + > + pManifest = LockResource(hResData); > + if (!pManifest) > + return FALSE; > + > + cchBuf = GetWindowsDirectoryW(NULL, 0) * sizeof(WCHAR) + sizeof(L"\\winsxs\\manifests\\") + sizeof(manifest_filename); > + pwszBuf = (WCHAR*)HeapAlloc(GetProcessHeap(), 0, cchBuf * sizeof(WCHAR)); > + if (!pwszBuf) > + return FALSE; > + > + GetWindowsDirectoryW(pwszBuf, cchBuf); > + lstrcatW(pwszBuf, L"\\winsxs"); > + CreateDirectoryW(pwszBuf, NULL); > + lstrcatW(pwszBuf, L"\\manifests\\"); > + CreateDirectoryW(pwszBuf, NULL); > + lstrcatW(pwszBuf, manifest_filename); > + if (install) > + { > + hFile = CreateFileW(pwszBuf, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); > + if (hFile != INVALID_HANDLE_VALUE) > + { > + if (WriteFile(hFile, pManifest, cbManifest,&cbWritten, NULL)&& cbWritten == cbManifest) > + bRet = TRUE; > + > + CloseHandle(hFile); > + > + if (!bRet) > + DeleteFileW(pwszBuf); > + else > + TRACE("created %s\n", debugstr_w(pwszBuf)); > + } > + } > + else > + bRet = DeleteFileW(pwszBuf); > + > + HeapFree(GetProcessHeap(), 0, pwszBuf); > + > + return bRet; > +} > > > /*********************************************************************** > @@ -930,6 +1004,12 @@ > HRESULT WINAPI DllInstall(BOOL bInstall, LPCWSTR cmdline) > { > TRACE("(%u, %s): stub\n", bInstall, debugstr_w(cmdline)); > + if (!create_manifest(bInstall)) > + { > + ERR("create_manifest failed!\n"); > + return HRESULT_FROM_WIN32(GetLastError()); > + } > + > return S_OK; > } > > > >

12 years, 10 months

Re: [ros-dev] [ros-diffs] [cgutman] 56113: [HIVESYS] - Merge back many old changes from i386 to AMD64

by Cameron Gutman

On Mar 11, 2012, at 7:13 AM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Sun Mar 11 11:13:15 2012 > New Revision: 56113 > > URL: http://svn.reactos.org/svn/reactos?rev=56113&view=rev > Log: > [HIVESYS] > - Merge back many old changes from i386 to AMD64 The way we do hive INFs is very far from ideal right now. I propose to create a base INF that is used to construct each hive and turning the hivexxx_arch.inf into an additional section like livecd.inf is now. This way every architecture inherits a base configuration and turning on/off services or changing certain settings can be done in the arch-specific inf. This would eliminate having to do these merge backs and also prevent tons of breakages and lost time in the future from having to merge the same change 3+ times. Regards, Cameron

12 years, 10 months

INI editor for Reactos

by Aleksey Bragin

FYI -------- Original Message -------- Hi there, Someone recommended that I point out my open-source INI editor for Reactos... Here it is: http://code.google.com/p/ini-settings-editor/ It opens INI files into a pretty tab-based view for editing. Let me know if you have any comments about it.

12 years, 10 months

Re: [ros-dev] [ros-diffs] [akhaldi] 56104: [CMAKE] * Fix a typo.

by Jérôme Gardou

Le 10/03/2012 19:02, akhaldi(a)svn.reactos.org a écrit : > Author: akhaldi > Date: Sat Mar 10 18:02:40 2012 > New Revision: 56104 > > URL: http://svn.reactos.org/svn/reactos?rev=56104&view=rev > Log: > [CMAKE] > * Fix a typo. > > Modified: > trunk/reactos/cmake/msvc.cmake > > Modified: trunk/reactos/cmake/msvc.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=56104… > ============================================================================== > --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Sat Mar 10 18:02:40 2012 > @@ -178,7 +178,7 @@ > > # add our library > # NOTE: as stub file and def file are generated in one pass, depending on one is like depending on the other > - _add_library(lib${_file} STATIC EXCLUDE_FROM_ALL > + add_library(lib${_file} STATIC EXCLUDE_FROM_ALL > ${CMAKE_CURRENT_BINARY_DIR}/lib${_file}_stubs.asm) > > # set correct "link rule" > > it wasn't a typo :-)

12 years, 10 months

Re: [ros-dev] buildbot failure in ReactOS on Windows_AMD64_1 VBox-Test

by caemyr＠myopera.com

Added yet another check, this time for all builders, which will stop any run passed without revision number. On Sat, Mar 10, 2012, at 05:34 AM, buildbot(a)reactos.org wrote: > The Buildbot has finished a build on builder Windows_AMD64_1 VBox-Test > while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/5238 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Windows_AMD64_2 > > Build Reason: Triggerable(Windows_AMD64_1 VBox-Test Trigger) > Build Source Stamp: 56097 > Blamelist: > > BUILD FAILED: failed Initial preparations > > sincerely, > -The Buildbot > -- With best regards Caemyr

12 years, 10 months

Re: [ros-dev] buildbot exception in ReactOS on Windows_AMD64_1 VBox-Test

by caemyr＠myopera.com

Strange vbox lockup at the end of 2nd stage. Build restarted, went fine this time. On Sat, Mar 10, 2012, at 01:24 AM, buildbot(a)reactos.org wrote: > The Buildbot has finished a build on builder Windows_AMD64_1 VBox-Test > while building ReactOS. > Full details are available at: > http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/5236 > > Buildbot URL: http://build.reactos.org/ > > Buildslave for this Build: Windows_AMD64_2 > > Build Reason: Triggerable(Windows_AMD64_1 VBox-Test Trigger) > Build Source Stamp: 56096 > Blamelist: spetreolle > > BUILD FAILED: exception test > > sincerely, > -The Buildbot > -- With best regards Caemyr

12 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev