8 Sep
2011
8 Sep
'11
4:39 p.m.
For the stuff that was obviously designed to warn at least once, have you
filled out bug reports for all these missing features, or do you think that
someone will now remember all this missing code?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 9:28 AM, <fireball(a)svn.reactos.org> wrote:
Author: fireball
Date: Thu Sep 8 08:28:41 2011
New Revision: 53635
URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
Log:
- Downgrade some DPRINT1s to DPRINTs.
Modified:
trunk/reactos/dll/ntdll/ldr/ldrapi.c
trunk/reactos/dll/ntdll/ldr/ldrinit.c
trunk/reactos/ntoskrnl/mm/ARM3/procsup.c
trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c
trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
Modified: trunk/reactos/dll/ntdll/ldr/ldrapi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrapi.c?rev…
==============================================================================
--- trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] (original)
+++ trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] Thu Sep 8 08:28:41
2011
@@ -1542,8 +1542,8 @@
NTAPI
LdrUnloadAlternateResourceModule(IN PVOID BaseAddress)
{
- static BOOLEAN WarnedOnce = FALSE;
- if (WarnedOnce == FALSE) { UNIMPLEMENTED; WarnedOnce = TRUE; }
+ //static BOOLEAN WarnedOnce = FALSE;
+ //if (WarnedOnce == FALSE) { UNIMPLEMENTED; WarnedOnce = TRUE; }
return FALSE;
}
Modified: trunk/reactos/dll/ntdll/ldr/ldrinit.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrinit.c?re…
==============================================================================
--- trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] (original)
+++ trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] Thu Sep 8 08:28:41
2011
@@ -728,7 +728,7 @@
/* Clear it */
//Kernel32ProcessInitPostImportfunction = NULL;
- UNIMPLEMENTED;
+ //UNIMPLEMENTED;
}
/* No root entry? return */
@@ -1988,7 +1988,7 @@
if (NtHeader->OptionalHeader.Subsystem == IMAGE_SUBSYSTEM_WINDOWS_GUI)
{
/* Load kernel32 and call BasePostImportInit... */
- DPRINT1("Unimplemented codepath!\n");
+ DPRINT("Unimplemented codepath!\n");
}
/* Walk the IAT and load all the DLLs */
@@ -2095,7 +2095,7 @@
{
/* Check for Application Compatibility Goo */
//LdrQueryApplicationCompatibilityGoo(hKey);
- DPRINT1("Querying app compat hacks is missing!\n");
+ DPRINT("Querying app compat hacks is missing!\n");
}
/*
Modified: trunk/reactos/ntoskrnl/mm/ARM3/procsup.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/procsup.c…
==============================================================================
--- trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] Thu Sep 8
08:28:41 2011
@@ -590,7 +590,7 @@
ViewShare,
MEM_TOP_DOWN,
PAGE_READONLY);
- DPRINT1("NLS Tables at: %p\n", TableBase);
+ DPRINT("NLS Tables at: %p\n", TableBase);
if (!NT_SUCCESS(Status))
{
/* Cleanup and exit */
@@ -602,7 +602,7 @@
// Allocate the PEB
//
Status = MiCreatePebOrTeb(Process, sizeof(PEB), (PULONG_PTR)&Peb);
- DPRINT1("PEB at: %p\n", Peb);
+ DPRINT("PEB at: %p\n", Peb);
if (!NT_SUCCESS(Status))
{
/* Cleanup and exit */
Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr…
==============================================================================
--- trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c [iso-8859-1]
(original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c [iso-8859-1]
Thu Sep 8 08:28:41 2011
@@ -105,7 +105,7 @@
PROCESS_ALL_ACCESS,
&ObjectAttributes,
&ClientId);
- DPRINT1("CSR Process: %p Handle: %p\n", pProcessData,
pProcessData->Process);
+ DPRINT("CSR Process: %p Handle: %p\n", pProcessData,
pProcessData->Process);
if (!NT_SUCCESS(Status))
{
ProcessData[hash] = pProcessData->next;
Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr…
==============================================================================
--- trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1]
(original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1] Thu
Sep 8 08:28:41 2011
@@ -278,8 +278,8 @@
/* Check if we have a process */
if (CsrProcess)
{
- /* Map the sectio into this process */
- DPRINT1("CSR Process Handle: %p. CSR Process: %p\n",
CsrProcess->Process, CsrProcess);
+ /* Map the section into this process */
+ DPRINT("CSR Process Handle: %p. CSR Process: %p\n",
CsrProcess->Process, CsrProcess);
Status = NtMapViewOfSection(CsrSrvSharedSection,
CsrProcess->Process,
&CsrSrvSharedSectionBase,
@@ -520,7 +520,7 @@
Status = CsrSrvAttachSharedSection(ProcessData, ConnectInfo);
if (NT_SUCCESS(Status))
{
- DPRINT1("Connection ok\n");
+ DPRINT("Connection ok\n");
AllowConnection = TRUE;
}
else
8 Sep
8 Sep
5:34 p.m.
New subject: [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
If someone wants to implement
1. Alternate resource support
2. BasePostImportInit and related advanced stuff
3. Application compatibility hacks support
he should be at least that smart to see that support for those features is totally
non-existant, so there is nothing to warn about.
It’s similar to having this reminder in the early init stage: DPRINT1(“ReactOS is in alpha
stage, some features may be missing. You have been warned!\n”);
WBR,
Aleksey Bragin.
From: Alex Ionescu
Sent: Thursday, September 08, 2011 8:39 PM
To: ros-dev(a)reactos.org
Cc: ros-diffs(a)reactos.org
Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
For the stuff that was obviously designed to warn at least once, have you filled out bug
reports for all these missing features, or do you think that someone will now remember all
this missing code?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 9:28 AM, <fireball(a)svn.reactos.org> wrote:
Author: fireball
Date: Thu Sep 8 08:28:41 2011
New Revision: 53635
URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
Log:
- Downgrade some DPRINT1s to DPRINTs.
Modified:
trunk/reactos/dll/ntdll/ldr/ldrapi.c
trunk/reactos/dll/ntdll/ldr/ldrinit.c
trunk/reactos/ntoskrnl/mm/ARM3/procsup.c
trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c
trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
Modified: trunk/reactos/dll/ntdll/ldr/ldrapi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrapi.c?rev…
==============================================================================
--- trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] (original)
+++ trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] Thu Sep 8 08:28:41 2011
@@ -1542,8 +1542,8 @@
NTAPI
LdrUnloadAlternateResourceModule(IN PVOID BaseAddress)
{
- static BOOLEAN WarnedOnce = FALSE;
- if (WarnedOnce == FALSE) { UNIMPLEMENTED; WarnedOnce = TRUE; }
+ //static BOOLEAN WarnedOnce = FALSE;
+ //if (WarnedOnce == FALSE) { UNIMPLEMENTED; WarnedOnce = TRUE; }
return FALSE;
}
Modified: trunk/reactos/dll/ntdll/ldr/ldrinit.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrinit.c?re…
==============================================================================
--- trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] (original)
+++ trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] Thu Sep 8 08:28:41 2011
@@ -728,7 +728,7 @@
/* Clear it */
//Kernel32ProcessInitPostImportfunction = NULL;
- UNIMPLEMENTED;
+ //UNIMPLEMENTED;
}
/* No root entry? return */
@@ -1988,7 +1988,7 @@
if (NtHeader->OptionalHeader.Subsystem == IMAGE_SUBSYSTEM_WINDOWS_GUI)
{
/* Load kernel32 and call BasePostImportInit... */
- DPRINT1("Unimplemented codepath!\n");
+ DPRINT("Unimplemented codepath!\n");
}
/* Walk the IAT and load all the DLLs */
@@ -2095,7 +2095,7 @@
{
/* Check for Application Compatibility Goo */
//LdrQueryApplicationCompatibilityGoo(hKey);
- DPRINT1("Querying app compat hacks is missing!\n");
+ DPRINT("Querying app compat hacks is missing!\n");
}
/*
Modified: trunk/reactos/ntoskrnl/mm/ARM3/procsup.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/procsup.c…
==============================================================================
--- trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] Thu Sep 8 08:28:41 2011
@@ -590,7 +590,7 @@
ViewShare,
MEM_TOP_DOWN,
PAGE_READONLY);
- DPRINT1("NLS Tables at: %p\n", TableBase);
+ DPRINT("NLS Tables at: %p\n", TableBase);
if (!NT_SUCCESS(Status))
{
/* Cleanup and exit */
@@ -602,7 +602,7 @@
// Allocate the PEB
//
Status = MiCreatePebOrTeb(Process, sizeof(PEB), (PULONG_PTR)&Peb);
- DPRINT1("PEB at: %p\n", Peb);
+ DPRINT("PEB at: %p\n", Peb);
if (!NT_SUCCESS(Status))
{
/* Cleanup and exit */
Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr…
==============================================================================
--- trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c [iso-8859-1] Thu Sep 8
08:28:41 2011
@@ -105,7 +105,7 @@
PROCESS_ALL_ACCESS,
&ObjectAttributes,
&ClientId);
- DPRINT1("CSR Process: %p Handle: %p\n", pProcessData,
pProcessData->Process);
+ DPRINT("CSR Process: %p Handle: %p\n", pProcessData,
pProcessData->Process);
if (!NT_SUCCESS(Status))
{
ProcessData[hash] = pProcessData->next;
Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr…
==============================================================================
--- trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1] Thu Sep 8
08:28:41 2011
@@ -278,8 +278,8 @@
/* Check if we have a process */
if (CsrProcess)
{
- /* Map the sectio into this process */
- DPRINT1("CSR Process Handle: %p. CSR Process: %p\n",
CsrProcess->Process, CsrProcess);
+ /* Map the section into this process */
+ DPRINT("CSR Process Handle: %p. CSR Process: %p\n",
CsrProcess->Process, CsrProcess);
Status = NtMapViewOfSection(CsrSrvSharedSection,
CsrProcess->Process,
&CsrSrvSharedSectionBase,
@@ -520,7 +520,7 @@
Status = CsrSrvAttachSharedSection(ProcessData, ConnectInfo);
if (NT_SUCCESS(Status))
{
- DPRINT1("Connection ok\n");
+ DPRINT("Connection ok\n");
AllowConnection = TRUE;
}
else
--------------------------------------------------------------------------------
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
5:40 p.m.
New subject: [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
Then why not get rid of ALL similar dprints?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 6:34 PM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
If someone wants to implement
1. Alternate resource support
2. BasePostImportInit and related advanced stuff
3. Application compatibility hacks support
he should be at least that smart to see that support for those features is
totally non-existant, so there is nothing to warn about.
It’s similar to having this reminder in the early init stage:
DPRINT1(“ReactOS is in alpha stage, some features may be missing. You have
been warned!\n”);
WBR,
Aleksey Bragin.
*From:* Alex Ionescu <ionucu(a)videotron.ca>
*Sent:* Thursday, September 08, 2011 8:39 PM
*To:* ros-dev(a)reactos.org
*Cc:* ros-diffs(a)reactos.org
*Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
someDPRINT1s to DPRINTs.
For the stuff that was obviously designed to warn at least once, have you
filled out bug reports for all these missing features, or do you think that
someone will now remember all this missing code?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 9:28 AM, <fireball(a)svn.reactos.org> wrote:
Author: fireball
Date: Thu Sep 8 08:28:41 2011
New Revision: 53635
URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
Log:
- Downgrade some DPRINT1s to DPRINTs.
Modified:
trunk/reactos/dll/ntdll/ldr/ldrapi.c
trunk/reactos/dll/ntdll/ldr/ldrinit.c
trunk/reactos/ntoskrnl/mm/ARM3/procsup.c
trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c
trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
Modified: trunk/reactos/dll/ntdll/ldr/ldrapi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrapi.c?rev…
==============================================================================
--- trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] (original)
+++ trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] Thu Sep 8 08:28:41
2011
@@ -1542,8 +1542,8 @@
NTAPI
LdrUnloadAlternateResourceModule(IN PVOID BaseAddress)
{
- static BOOLEAN WarnedOnce = FALSE;
- if (WarnedOnce == FALSE) { UNIMPLEMENTED; WarnedOnce = TRUE; }
+ //static BOOLEAN WarnedOnce = FALSE;
+ //if (WarnedOnce == FALSE) { UNIMPLEMENTED; WarnedOnce = TRUE; }
return FALSE;
}
Modified: trunk/reactos/dll/ntdll/ldr/ldrinit.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrinit.c?re…
==============================================================================
--- trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] (original)
+++ trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] Thu Sep 8 08:28:41
2011
@@ -728,7 +728,7 @@
/* Clear it */
//Kernel32ProcessInitPostImportfunction = NULL;
- UNIMPLEMENTED;
+ //UNIMPLEMENTED;
}
/* No root entry? return */
@@ -1988,7 +1988,7 @@
if (NtHeader->OptionalHeader.Subsystem == IMAGE_SUBSYSTEM_WINDOWS_GUI)
{
/* Load kernel32 and call BasePostImportInit... */
- DPRINT1("Unimplemented codepath!\n");
+ DPRINT("Unimplemented codepath!\n");
}
/* Walk the IAT and load all the DLLs */
@@ -2095,7 +2095,7 @@
{
/* Check for Application Compatibility Goo */
//LdrQueryApplicationCompatibilityGoo(hKey);
- DPRINT1("Querying app compat hacks is missing!\n");
+ DPRINT("Querying app compat hacks is missing!\n");
}
/*
Modified: trunk/reactos/ntoskrnl/mm/ARM3/procsup.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/procsup.c…
==============================================================================
--- trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] Thu Sep 8
08:28:41 2011
@@ -590,7 +590,7 @@
ViewShare,
MEM_TOP_DOWN,
PAGE_READONLY);
- DPRINT1("NLS Tables at: %p\n", TableBase);
+ DPRINT("NLS Tables at: %p\n", TableBase);
if (!NT_SUCCESS(Status))
{
/* Cleanup and exit */
@@ -602,7 +602,7 @@
// Allocate the PEB
//
Status = MiCreatePebOrTeb(Process, sizeof(PEB), (PULONG_PTR)&Peb);
- DPRINT1("PEB at: %p\n", Peb);
+ DPRINT("PEB at: %p\n", Peb);
if (!NT_SUCCESS(Status))
{
/* Cleanup and exit */
Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr…
==============================================================================
--- trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c [iso-8859-1]
(original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c [iso-8859-1]
Thu Sep 8 08:28:41 2011
@@ -105,7 +105,7 @@
PROCESS_ALL_ACCESS,
&ObjectAttributes,
&ClientId);
- DPRINT1("CSR Process: %p Handle: %p\n", pProcessData,
pProcessData->Process);
+ DPRINT("CSR Process: %p Handle: %p\n", pProcessData,
pProcessData->Process);
if (!NT_SUCCESS(Status))
{
ProcessData[hash] = pProcessData->next;
Modified: trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csr…
==============================================================================
--- trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1]
(original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1]
Thu Sep 8 08:28:41 2011
@@ -278,8 +278,8 @@
/* Check if we have a process */
if (CsrProcess)
{
- /* Map the sectio into this process */
- DPRINT1("CSR Process Handle: %p. CSR Process: %p\n",
CsrProcess->Process, CsrProcess);
+ /* Map the section into this process */
+ DPRINT("CSR Process Handle: %p. CSR Process: %p\n",
CsrProcess->Process, CsrProcess);
Status = NtMapViewOfSection(CsrSrvSharedSection,
CsrProcess->Process,
&CsrSrvSharedSectionBase,
@@ -520,7 +520,7 @@
Status = CsrSrvAttachSharedSection(ProcessData, ConnectInfo);
if (NT_SUCCESS(Status))
{
- DPRINT1("Connection ok\n");
+ DPRINT("Connection ok\n");
AllowConnection = TRUE;
}
else
------------------------------
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
6:48 p.m.
New subject: [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
That’d be great but it’s important to not "overdo” the job.
WBR,
Aleksey.
From: Alex Ionescu
Sent: Thursday, September 08, 2011 9:40 PM
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
Then why not get rid of ALL similar dprints?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 6:34 PM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
If someone wants to implement
1. Alternate resource support
2. BasePostImportInit and related advanced stuff
3. Application compatibility hacks support
he should be at least that smart to see that support for those features is totally
non-existant, so there is nothing to warn about.
It’s similar to having this reminder in the early init stage: DPRINT1(“ReactOS is in
alpha stage, some features may be missing. You have been warned!\n”);
WBR,
Aleksey Bragin.
From: Alex Ionescu
Sent: Thursday, September 08, 2011 8:39 PM
To: ros-dev(a)reactos.org
Cc: ros-diffs(a)reactos.org
Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to
DPRINTs.
For the stuff that was obviously designed to warn at least once, have you filled out bug
reports for all these missing features, or do you think that someone will now remember all
this missing code?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 9:28 AM, <fireball(a)svn.reactos.org> wrote:
Author: fireball
Date: Thu Sep 8 08:28:41 2011
New Revision: 53635
URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
Log:
- Downgrade some DPRINT1s to DPRINTs.
7:44 p.m.
New subject: [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
?
And who decides? This sounds like utter BS!
So while navigating it's okay to get 100000 "UIMPLEMENTED FOR PIDL" or 100
IRP unimplemented messages, but it's wrong to get other dprints?!
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 7:48 PM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
That’d be great but it’s important to not
"overdo” the job.
WBR,
Aleksey.
*From:* Alex Ionescu <ionucu(a)videotron.ca>
*Sent:* Thursday, September 08, 2011 9:40 PM
*To:* ReactOS Development List <ros-dev(a)reactos.org>
*Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
someDPRINT1s to DPRINTs.
Then why not get rid of ALL similar dprints?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 6:34 PM, Aleksey Bragin <aleksey(a)reactos.org>wrote;wrote:
If someone wants to implement
1. Alternate resource support
2. BasePostImportInit and related advanced stuff
3. Application compatibility hacks support
he should be at least that smart to see that support for those features is
totally non-existant, so there is nothing to warn about.
It’s similar to having this reminder in the early init stage:
DPRINT1(“ReactOS is in alpha stage, some features may be missing. You have
been warned!\n”);
WBR,
Aleksey Bragin.
*From:* Alex Ionescu <ionucu(a)videotron.ca>
*Sent:* Thursday, September 08, 2011 8:39 PM
*To:* ros-dev(a)reactos.org
*Cc:* ros-diffs(a)reactos.org
*Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
someDPRINT1s to DPRINTs.
For the stuff that was obviously designed to warn at least once, have
you filled out bug reports for all these missing features, or do you think
that someone will now remember all this missing code?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 9:28 AM, <fireball(a)svn.reactos.org> wrote:
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Author: fireball
Date: Thu Sep 8 08:28:41 2011
New Revision: 53635
URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
Log:
- Downgrade some DPRINT1s to DPRINTs.
8:43 p.m.
New subject: [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
Very easy, I explained you in the previous email. If the reminder has no sense, for
example as it was with NTDLL LDR debug prints – they warned about a not implemented app
compat hacks querying, which was never implemented before, then there is no reason to
remind about it at the load of every executable image in ReactOS.
Same applies to other stuff.
However, if the certain dprint is of really reminding nature, e.g. it temporarily changes
behaviour of a certain code path, or shows an unimplemented code path being executed which
other code may rely on – then it should obviously stay.
From: Alex Ionescu
Sent: Thursday, September 08, 2011 11:44 PM
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
?
And who decides? This sounds like utter BS!
So while navigating it's okay to get 100000 "UIMPLEMENTED FOR PIDL" or 100
IRP unimplemented messages, but it's wrong to get other dprints?!
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 7:48 PM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
That’d be great but it’s important to not "overdo” the job.
WBR,
Aleksey.
From: Alex Ionescu
Sent: Thursday, September 08, 2011 9:40 PM
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to
DPRINTs.
Then why not get rid of ALL similar dprints?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 6:34 PM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
If someone wants to implement
1. Alternate resource support
2. BasePostImportInit and related advanced stuff
3. Application compatibility hacks support
he should be at least that smart to see that support for those features is totally
non-existant, so there is nothing to warn about.
It’s similar to having this reminder in the early init stage: DPRINT1(“ReactOS is in
alpha stage, some features may be missing. You have been warned!\n”);
WBR,
Aleksey Bragin.
From: Alex Ionescu
Sent: Thursday, September 08, 2011 8:39 PM
To: ros-dev(a)reactos.org
Cc: ros-diffs(a)reactos.org
Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to
DPRINTs.
For the stuff that was obviously designed to warn at least once, have you filled out
bug reports for all these missing features, or do you think that someone will now remember
all this missing code?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 9:28 AM, <fireball(a)svn.reactos.org> wrote:
Author: fireball
Date: Thu Sep 8 08:28:41 2011
New Revision: 53635
URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
Log:
- Downgrade some DPRINT1s to DPRINTs.
11 Sep
11 Sep
12:52 p.m.
New subject: [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
Can you please justify the following:
1) WARNING: HvpWriteLog at
P:\Trunk_slave\x86_CMake\build\lib\cmlib\hivewrt.c:26 is
UNIMPLEMENTED!
repeated 5-6 times per flush.
2_ (P:\Trunk_slave\x86_CMake\build\ntoskrnl\po\povolume.c:312)
And friends, which happen every shutdown and detail every single
operation (along with poshtdown.c and power.c)
Useless:
(P:\Trunk_slave\x86_CMake\build\drivers\bus\pci\fdo.c:586) Unknown IOCTL 0x9
(P:\Trunk_slave\x86_CMake\build\drivers\bus\pci\fdo.c:586) Unknown IOCTL 0x14
(P:\Trunk_slave\x86_CMake\build\ntoskrnl\io\pnpmgr\pnproot.c:1137)
IRP_MJ_PNP / Unknown minor function 0x3
Too much information:
(P:\Trunk_slave\x86_CMake\build\ntoskrnl\mm\ARM3\sysldr.c:168)
Loading: \SystemRoot\system32\drivers\mouclass.sys at F886E000 with 23
pages
WARNING: RtlSetUnhandledExceptionFilter at
P:\Trunk_slave\x86_CMake\build\lib\rtl\exception.c:186 is
UNIMPLEMENTED!
Happens 15-6 times+ per boot.
And more...
Also, I find it funny that there are SERIOUS problems being reported
in the boot log, but NOBODY fixes them. Yet, here you are removing the
only output that shows there are problems...
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 4:43 PM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
Very easy, I explained you in the previous email. If
the reminder has no
sense, for example as it was with NTDLL LDR debug prints – they warned about
a not implemented app compat hacks querying, which was never implemented
before, then there is no reason to remind about it at the load of every
executable image in ReactOS.
Same applies to other stuff.
However, if the certain dprint is of really reminding nature, e.g. it
temporarily changes behaviour of a certain code path, or shows an
unimplemented code path being executed which other code may rely on – then
it should obviously stay.
*From:* Alex Ionescu <ionucu(a)videotron.ca>
*Sent:* Thursday, September 08, 2011 11:44 PM
*To:* ReactOS Development List <ros-dev(a)reactos.org>
*Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
someDPRINT1s to DPRINTs.
?
And who decides? This sounds like utter BS!
So while navigating it's okay to get 100000 "UIMPLEMENTED FOR PIDL" or 100
IRP unimplemented messages, but it's wrong to get other dprints?!
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 7:48 PM, Aleksey Bragin <aleksey(a)reactos.org>wrote;wrote:
That’d be great but it’s important to not
"overdo” the job.
WBR,
Aleksey.
*From:* Alex Ionescu <ionucu(a)videotron.ca>
*Sent:* Thursday, September 08, 2011 9:40 PM
*To:* ReactOS Development List <ros-dev(a)reactos.org>
*Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
someDPRINT1s to DPRINTs.
Then why not get rid of ALL similar dprints?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 6:34 PM, Aleksey Bragin <aleksey(a)reactos.org>wrote;wrote:
> If someone wants to implement
> 1. Alternate resource support
> 2. BasePostImportInit and related advanced stuff
> 3. Application compatibility hacks support
> he should be at least that smart to see that support for those features
> is totally non-existant, so there is nothing to warn about.
>
> It’s similar to having this reminder in the early init stage:
> DPRINT1(“ReactOS is in alpha stage, some features may be missing. You have
> been warned!\n”);
>
> WBR,
> Aleksey Bragin.
>
> *From:* Alex Ionescu <ionucu(a)videotron.ca>
> *Sent:* Thursday, September 08, 2011 8:39 PM
> *To:* ros-dev(a)reactos.org
> *Cc:* ros-diffs(a)reactos.org
> *Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
> someDPRINT1s to DPRINTs.
>
> For the stuff that was obviously designed to warn at least once, have
> you filled out bug reports for all these missing features, or do you think
> that someone will now remember all this missing code?
>
> Best regards,
> Alex Ionescu
>
>
> On Thu, Sep 8, 2011 at 9:28 AM, <fireball(a)svn.reactos.org> wrote:
>
>> Author: fireball
>> Date: Thu Sep 8 08:28:41 2011
>> New Revision: 53635
>>
>> URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
>> Log:
>> - Downgrade some DPRINT1s to DPRINTs.
>>
>
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
12:53 p.m.
New subject: [ros-diffs] [fireball] 53635: - Downgrade someDPRINT1s to DPRINTs.
Oh, and don't even get me started on the PAGES AND PAGES of debug output
that the ACPI driver does:
http://build.reactos.org/builders/Windows_AMD64_1%20VBox-Test/builds/2939/s…
Best regards,
Alex Ionescu
On Sun, Sep 11, 2011 at 8:52 AM, Alex Ionescu <ionucu(a)videotron.ca> wrote:
Can you please justify the following:
1) WARNING: HvpWriteLog at P:\Trunk_slave\x86_CMake\build\lib\cmlib\hivewrt.c:26 is
UNIMPLEMENTED!
repeated 5-6 times per flush.
2_ (P:\Trunk_slave\x86_CMake\build\ntoskrnl\po\povolume.c:312)
And friends, which happen every shutdown and detail every single operation (along with
poshtdown.c and power.c)
Useless:
(P:\Trunk_slave\x86_CMake\build\drivers\bus\pci\fdo.c:586) Unknown IOCTL 0x9
(P:\Trunk_slave\x86_CMake\build\drivers\bus\pci\fdo.c:586) Unknown IOCTL 0x14
(P:\Trunk_slave\x86_CMake\build\ntoskrnl\io\pnpmgr\pnproot.c:1137) IRP_MJ_PNP / Unknown
minor function 0x3
Too much information:
(P:\Trunk_slave\x86_CMake\build\ntoskrnl\mm\ARM3\sysldr.c:168) Loading:
\SystemRoot\system32\drivers\mouclass.sys at F886E000 with 23 pages
WARNING: RtlSetUnhandledExceptionFilter at
P:\Trunk_slave\x86_CMake\build\lib\rtl\exception.c:186 is UNIMPLEMENTED!
Happens 15-6 times+ per boot.
And more...
Also, I find it funny that there are SERIOUS problems being reported in the boot log, but
NOBODY fixes them. Yet, here you are removing the only output that shows there are
problems...
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 4:43 PM, Aleksey Bragin <aleksey(a)reactos.org>wrote;wrote:
Very easy, I explained you in the previous
email. If the reminder has
no sense, for example as it was with NTDLL LDR debug prints – they warned
about a not implemented app compat hacks querying, which was never
implemented before, then there is no reason to remind about it at the load
of every executable image in ReactOS.
Same applies to other stuff.
However, if the certain dprint is of really reminding nature, e.g. it
temporarily changes behaviour of a certain code path, or shows an
unimplemented code path being executed which other code may rely on – then
it should obviously stay.
*From:* Alex Ionescu <ionucu(a)videotron.ca>
*Sent:* Thursday, September 08, 2011 11:44 PM
*To:* ReactOS Development List <ros-dev(a)reactos.org>
*Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
someDPRINT1s to DPRINTs.
?
And who decides? This sounds like utter BS!
So while navigating it's okay to get 100000 "UIMPLEMENTED FOR PIDL" or 100
IRP unimplemented messages, but it's wrong to get other dprints?!
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 7:48 PM, Aleksey Bragin <aleksey(a)reactos.org>wrote;wrote:
That’d be great but it’s important to not
"overdo” the job.
WBR,
Aleksey.
*From:* Alex Ionescu <ionucu(a)videotron.ca>
*Sent:* Thursday, September 08, 2011 9:40 PM
*To:* ReactOS Development List <ros-dev(a)reactos.org>
*Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
someDPRINT1s to DPRINTs.
Then why not get rid of ALL similar dprints?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 6:34 PM, Aleksey Bragin <aleksey(a)reactos.org>wrote;wrote:
> If someone wants to implement
> 1. Alternate resource support
> 2. BasePostImportInit and related advanced stuff
> 3. Application compatibility hacks support
> he should be at least that smart to see that support for those features
> is totally non-existant, so there is nothing to warn about.
>
> It’s similar to having this reminder in the early init stage:
> DPRINT1(“ReactOS is in alpha stage, some features may be missing. You have
> been warned!\n”);
>
> WBR,
> Aleksey Bragin.
>
> *From:* Alex Ionescu <ionucu(a)videotron.ca>
> *Sent:* Thursday, September 08, 2011 8:39 PM
> *To:* ros-dev(a)reactos.org
> *Cc:* ros-diffs(a)reactos.org
> *Subject:* Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
> someDPRINT1s to DPRINTs.
>
> For the stuff that was obviously designed to warn at least once, have
> you filled out bug reports for all these missing features, or do you think
> that someone will now remember all this missing code?
>
> Best regards,
> Alex Ionescu
>
>
> On Thu, Sep 8, 2011 at 9:28 AM, <fireball(a)svn.reactos.org> wrote:
>
>> Author: fireball
>> Date: Thu Sep 8 08:28:41 2011
>> New Revision: 53635
>>
>> URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
>> Log:
>> - Downgrade some DPRINT1s to DPRINTs.
>>
>
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
4757
days inactive
4760
days old
7 comments
2 participants
participants (2)
-
Aleksey Bragin -
Alex Ionescu