Ros-diffs March 2005

ros-diffs@reactos.org

26 participants
609 discussions

[hbirr] 14335: - Fixed the wrong check for KMUTEX objects in KeRundownThread.

by hbirr＠svn.reactos.com

- Fixed the wrong check for KMUTEX objects in KeRundownThread. - Fixed the endless loop in KeRundownThread. Modified: trunk/reactos/ntoskrnl/ke/kthread.c _____ Modified: trunk/reactos/ntoskrnl/ke/kthread.c --- trunk/reactos/ntoskrnl/ke/kthread.c 2005-03-26 17:52:32 UTC (rev 14334) +++ trunk/reactos/ntoskrnl/ke/kthread.c 2005-03-26 20:14:06 UTC (rev 14335) @@ -355,12 +355,12 @@ /* Lock the Dispatcher Database */ OldIrql = KeAcquireDispatcherDatabaseLock(); - CurrentEntry = Thread->MutantListHead.Flink; - while (CurrentEntry != &Thread->MutantListHead) { + while (!IsListEmpty(&Thread->MutantListHead)) { /* Get the Mutant */ + CurrentEntry = RemoveHeadList(&Thread->MutantListHead); Mutant = CONTAINING_RECORD(CurrentEntry, KMUTANT, MutantListEntry); - ASSERT(Mutant->ApcDisable); + ASSERT(Mutant->ApcDisable == 0); /* Uncondtionally abandon it */ DPRINT("Abandonning the Mutant\n");

19 years, 9 months

[ea] 14334: Exported symbol list updated to 5.1-SP2

by ea＠svn.reactos.com

Exported symbol list updated to 5.1-SP2 Modified: trunk/reactos/lib/advapi32/advapi32.def Modified: trunk/reactos/lib/advapi32/misc/sysfunc.c _____ Modified: trunk/reactos/lib/advapi32/advapi32.def --- trunk/reactos/lib/advapi32/advapi32.def 2005-03-26 16:41:45 UTC (rev 14333) +++ trunk/reactos/lib/advapi32/advapi32.def 2005-03-26 17:52:32 UTC (rev 14334) @@ -14,13 +14,25 @@ AccessCheck@32 AccessCheckAndAuditAlarmA@44 AccessCheckAndAuditAlarmW@44 +;AccessCheckByType +;AccessCheckByTypeAndAuditAlarmA +;AccessCheckByTypeAndAuditAlarmW +;AccessCheckByTypeResultList +;AccessCheckByTypeResultListAndAuditAlarmA +;AccessCheckByTypeResultListAndAuditAlarmByHandleA +;AccessCheckByTypeResultListAndAuditAlarmByHandleW +;AccessCheckByTypeResultListAndAuditAlarmW AddAccessAllowedAce@16 AddAccessAllowedAceEx@20 +;AddAccessAllowedObjectAce AddAccessDeniedAce@16 AddAccessDeniedAceEx@20 +;AddAccessDeniedObjectAce AddAce@20 AddAuditAccessAce@24 AddAuditAccessAceEx@28 +;AddAuditAccessObjectAce +;AddUsersToEncryptedFile AdjustTokenGroups@24 AdjustTokenPrivileges@24 AllocateAndInitializeSid@44 @@ -41,24 +53,94 @@ ;BuildSecurityDescriptorW@36 BuildTrusteeWithNameA@8 BuildTrusteeWithNameW@8 +;BuildTrusteeWithObjectsAndNameA +;BuildTrusteeWithObjectsAndNameW +;BuildTrusteeWithObjectsAndSidA +;BuildTrusteeWithObjectsAndSidW BuildTrusteeWithSidA@8 BuildTrusteeWithSidW@8 +;CancelOverlappedAccess +;ChangeServiceConfig2A +;ChangeServiceConfig2W ChangeServiceConfigA@44 ChangeServiceConfigW@44 CheckTokenMembership@12 ClearEventLogA@8 ClearEventLogW@8 +;CloseCodeAuthzLevel +;CloseEncryptedFileRaw CloseEventLog@4 CloseServiceHandle@4 +;CloseTrace +;CommandLineFromMsiDescriptor +;ComputeAccessTokenFromCodeAuthzLevel ControlService@12 +;ControlTraceA +;ControlTraceW +;ConvertAccessToSecurityDescriptorA +;ConvertAccessToSecurityDescriptorW +;ConvertSDToStringSDRootDomainA +;ConvertSDToStringSDRootDomainW +;ConvertSecurityDescriptorToAccessA +;ConvertSecurityDescriptorToAccessNamedA +;ConvertSecurityDescriptorToAccessNamedW +;ConvertSecurityDescriptorToAccessW +;ConvertSecurityDescriptorToStringSecurityDescriptorA +;ConvertSecurityDescriptorToStringSecurityDescriptorW ConvertSidToStringSidA@8 ConvertSidToStringSidW@8 +;ConvertStringSDToSDDomainA +;ConvertStringSDToSDDomainW +;ConvertStringSDToSDRootDomainA +;ConvertStringSDToSDRootDomainW +;ConvertStringSecurityDescriptorToSecurityDescriptorA +;ConvertStringSecurityDescriptorToSecurityDescriptorW +;ConvertStringSidToSidA +;ConvertStringSidToSidW +;ConvertToAutoInheritPrivateObjectSecurity CopySid@12 +;CreateCodeAuthzLevel ;CreatePrivateObjectSecurity@24 +;CreatePrivateObjectSecurityEx +;CreatePrivateObjectSecurityWithMultipleInheritance CreateProcessAsUserA@44 +;CreateProcessAsUserSecure CreateProcessAsUserW@44 +;CreateProcessWithLogonW +;CreateRestrictedToken CreateServiceA@52 CreateServiceW@52 +;CreateTraceInstanceId +;CreateWellKnownSid +;CredDeleteA +;CredDeleteW +;CredEnumerateA +;CredEnumerateW +;CredFree +;CredGetSessionTypes +;CredGetTargetInfoA +;CredGetTargetInfoW +;CredIsMarshaledCredentialA +;CredIsMarshaledCredentialW +;CredMarshalCredentialA +;CredMarshalCredentialW +;CredProfileLoaded +;CredReadA +;CredReadDomainCredentialsA +;CredReadDomainCredentialsW +;CredReadW +;CredRenameA +;CredRenameW +;CredUnmarshalCredentialA +;CredUnmarshalCredentialW +;CredWriteA +;CredWriteDomainCredentialsA +;CredWriteDomainCredentialsW +;CredWriteW +;CredpConvertCredential +;CredpConvertTargetInfo +;CredpDecodeCredential +;CredpEncodeCredential CryptAcquireContextA@20 CryptAcquireContextW@20 CryptContextAddRef@12 @@ -67,10 +149,18 @@ CryptDeriveKey@20 CryptDestroyHash@4 CryptDestroyKey@4 +;CryptDuplicateHash +;CryptDuplicateKey CryptEncrypt@28 +;CryptEnumProviderTypesA +;CryptEnumProviderTypesW +;CryptEnumProvidersA +;CryptEnumProvidersW CryptExportKey@24 CryptGenKey@16 CryptGenRandom@12 +;CryptGetDefaultProviderA +;CryptGetDefaultProviderW CryptGetHashParam@20 CryptGetKeyParam@20 CryptGetProvParam@20 @@ -83,17 +173,20 @@ CryptSetKeyParam@16 CryptSetProvParam@16 CryptSetProviderA@8 +;CryptSetProviderExA +;CryptSetProviderExW CryptSetProviderW@8 CryptSignHashA@24 ;CryptSignHashW@24 CryptVerifySignatureA@24 ;CryptVerifySignatureW@24 +;DecryptFileA +;DecryptFileW DeleteAce@8 DeleteService@4 -;DenyAccessRightsA -;DenyAccessRightsW DeregisterEventSource@4 ;DestroyPrivateObjectSecurity@4 +;DuplicateEncryptionInfoFile DuplicateToken@12 DuplicateTokenEx@24 ;ElfBackupEventLogFileA@8 @@ -115,48 +208,67 @@ ;ElfRegisterEventSourceW@12 ;ElfReportEventA@48 ;ElfReportEventW@48 +;EnableTrace +;EncryptFileA +;EncryptFileW +;EncryptedFileKeyInfo +;EncryptionDisable EnumDependentServicesA@24 EnumDependentServicesW@24 EnumServiceGroupW@36 EnumServicesStatusA@32 +;EnumServicesStatusExA +;EnumServicesStatusExW EnumServicesStatusW@32 +;EnumerateTraceGuids +;EqualDomainSid EqualPrefixSid@8 EqualSid@8 +;FileEncryptionStatusA +;FileEncryptionStatusW FindFirstFreeAce@8 +;FlushTraceA +;FlushTraceW +;FreeEncryptedFileKeyInfo +;FreeEncryptionCertificateHashList FreeInheritedFromArray@12 FreeSid@4 +;GetAccessPermissionsForObjectA +;GetAccessPermissionsForObjectW GetAce@12 GetAclInformation@16 ;GetAuditedPermissionsFromAclA@16 ;GetAuditedPermissionsFromAclW@16 -;GetAuditedPermissionsFromSDA -;GetAuditedPermissionsFromSDW GetCurrentHwProfileA@4 GetCurrentHwProfileW@4 -;GetEffectiveAccessRightsA -;GetEffectiveAccessRightsW ;GetEffectiveRightsFromAclA@12 ;GetEffectiveRightsFromAclW@12 -;GetEffectiveRightsFromSDA@12 -;GetEffectiveRightsFromSDW@12 -;GetExplicitAccessRightsA -;GetExplicitAccessRightsW +;GetEventLogInformation ;GetExplicitEntriesFromAclA@12 ;GetExplicitEntriesFromAclW@12 GetFileSecurityA@20 GetFileSecurityW@20 +;GetInformationCodeAuthzLevelW +;GetInformationCodeAuthzPolicyW GetInheritanceSourceA@40 GetInheritanceSourceW@40 GetKernelObjectSecurity@20 GetLengthSid@4 +;GetLocalManagedApplicationData +;GetLocalManagedApplications +;GetManagedApplicationCategories +;GetManagedApplications GetMultipleTrusteeA@4 GetMultipleTrusteeOperationA@4 GetMultipleTrusteeOperationW@4 GetMultipleTrusteeW@4 GetNamedSecurityInfoA@32 +;GetNamedSecurityInfoExA +;GetNamedSecurityInfoExW GetNamedSecurityInfoW@32 GetNumberOfEventLogRecords@8 GetOldestEventLogRecord@8 +;GetOverlappedAccessResults ;GetPrivateObjectSecurity@20 GetSecurityDescriptorControl@12 GetSecurityDescriptorDacl@16 @@ -177,6 +289,9 @@ GetSidSubAuthority@8 GetSidSubAuthorityCount@4 GetTokenInformation@20 +;GetTraceEnableFlags +;GetTraceEnableLevel +;GetTraceLoggerHandle GetTrusteeFormA@4 GetTrusteeFormW@4 GetTrusteeNameA@4 @@ -185,11 +300,15 @@ GetTrusteeTypeW@4 GetUserNameA@8 GetUserNameW@8 -;GrantAccessRightsA@16 -;GrantAccessRightsW@16 +;GetWindowsAccountDomainSid ;I_ScGetCurrentGroupStateW@12 +;I_ScIsSecurityProcess +;I_ScPnPGetServiceName +;I_ScSendTSMessage ;I_ScSetServiceBitsA@20 ;I_ScSetServiceBitsW@20 +;IdentifyCodeAuthzLevelW +;ImpersonateAnonymousToken ImpersonateLoggedOnUser@4 ImpersonateNamedPipeClient@4 ImpersonateSelf@4 @@ -197,15 +316,21 @@ InitializeSecurityDescriptor@8 InitializeSid@12 InitiateSystemShutdownA@20 +;InitiateSystemShutdownExA +;InitiateSystemShutdownExW InitiateSystemShutdownW@20 -;IsAccessPermittedA@20 -;IsAccessPermittedW@20 +;InstallApplication IsTextUnicode(a)12=NTDLL.RtlIsTextUnicode +;IsTokenRestricted +;IsTokenUntrusted IsValidAcl@4 IsValidSecurityDescriptor@4 IsValidSid@4 +;IsWellKnownSid LockServiceDatabase@4 LogonUserA@24 +;LogonUserExA +;LogonUserExW LogonUserW@24 LookupAccountNameA@28 LookupAccountNameW@28 @@ -226,6 +351,7 @@ ;LsaCreateAccount@16 ;LsaCreateSecret@16 ;LsaCreateTrustedDomain@16 +;LsaCreateTrustedDomainEx ;LsaDelete@4 ;LsaDeleteTrustedDomain@8 ;LsaEnumerateAccountRights@16 @@ -234,13 +360,18 @@ ;LsaEnumeratePrivileges@20 ;LsaEnumeratePrivilegesOfAccount@8 ;LsaEnumerateTrustedDomains@20 +;LsaEnumerateTrustedDomainsEx LsaFreeMemory@4 ;LsaGetQuotasForAccount@8 +;LsaGetRemoteUserName ;LsaGetSystemAccessAccount@8 LsaGetUserName@8 ;LsaICLookupNames@32 +;LsaICLookupNamesWithCreds ;LsaICLookupSids@32 +;LsaICLookupSidsWithCreds ;LsaLookupNames@20 +;LsaLookupNames2 ;LsaLookupPrivilegeDisplayName@16 ;LsaLookupPrivilegeName@12 ;LsaLookupPrivilegeValue@12 @@ -248,34 +379,44 @@ LsaNtStatusToWinError@4 ;LsaOpenAccount@16 LsaOpenPolicy@16 +;LsaOpenPolicySce ;LsaOpenSecret@16 ;LsaOpenTrustedDomain@16 +;LsaOpenTrustedDomainByName +;LsaQueryDomainInformationPolicy +;LsaQueryForestTrustInformation LsaQueryInfoTrustedDomain@12 LsaQueryInformationPolicy@12 ;LsaQuerySecret@20 ;LsaQuerySecurityObject@12 ;LsaQueryTrustedDomainInfo@16 +;LsaQueryTrustedDomainInfoByName ;LsaRemoveAccountRights@20 ;LsaRemovePrivilegesFromAccount@12 LsaRetrievePrivateData@12 ;LsaSetInformationPolicy@12 +;LsaSetForestTrustInformation +;LsaSetInformationPolicy ;LsaSetInformationTrustedDomain@12 ;LsaSetQuotasForAccount@8 ;LsaSetSecret@12 ;LsaSetSecurityObject@12 ;LsaSetSystemAccessAccount@8 +;LsaSetTrustedDomainInfoByName ;LsaSetTrustedDomainInformation@16 LsaStorePrivateData@12 -MakeAbsoluteSD@44 -MakeSelfRelativeSD@12 -MapGenericMask@8 MD4Final@4 MD4Init@4 MD4Update@12 MD5Final@4 MD5Init@4 MD5Update@12 -;NTAccessMaskToProvAccessRights@12 +;MSChapSrvChangePassword +;MSChapSrvChangePassword2 +MakeAbsoluteSD@44 +;MakeAbsoluteSD2 +MakeSelfRelativeSD@12 +MapGenericMask@8 ;NotifyBootConfigStatus@4 NotifyChangeEventLog@8 ObjectCloseAuditAlarmA@12 @@ -288,6 +429,8 @@ ObjectPrivilegeAuditAlarmW@24 OpenBackupEventLogA@8 OpenBackupEventLogW@8 +;OpenEncryptedFileRawA +;OpenEncryptedFileRawW OpenEventLogA@8 OpenEventLogW@8 OpenProcessToken@12 @@ -296,10 +439,19 @@ OpenServiceA@12 OpenServiceW@12 OpenThreadToken@16 +;OpenTraceA +;OpenTraceW PrivilegeCheck@12 PrivilegedServiceAuditAlarmA@20 PrivilegedServiceAuditAlarmW@20 -;ProvAccessRightsToNTAccessMask +;ProcessIdleTasks +;ProcessTrace +;ProvAccessRightsToNTAccessMask ; ? +;QueryAllTracesA +;QueryAllTracesW +;QueryRecoveryAgentsOnEncryptedFile +;QueryServiceConfig2A +;QueryServiceConfig2W QueryServiceConfigA@16 QueryServiceConfigW@16 QueryServiceLockStatusA@16 @@ -307,7 +459,11 @@ QueryServiceObjectSecurity@20 QueryServiceStatus@8 QueryServiceStatusEx@20 +;QueryTraceA +;QueryTraceW +;QueryUsersOnEncryptedFile ;QueryWindows31FilesMigration@4 +;ReadEncryptedFileRaw ReadEventLogA@28 ReadEventLogW@28 RegCloseKey@4 @@ -321,6 +477,7 @@ RegDeleteKeyW@8 RegDeleteValueA@8 RegDeleteValueW@8 +;RegDisablePredefinedCache RegEnumKeyA@16 RegEnumKeyExA@32 RegEnumKeyExW@32 @@ -332,10 +489,13 @@ RegLoadKeyA@12 RegLoadKeyW@12 RegNotifyChangeKeyValue@20 +;RegOpenCurrentUser RegOpenKeyA@12 RegOpenKeyExA@20 RegOpenKeyExW@20 RegOpenKeyW@12 +;RegOpenUserClassesRoot +;RegOverridePredefKey RegQueryInfoKeyA@48 RegQueryInfoKeyW@48 RegQueryMultipleValuesA@20 @@ -349,6 +509,8 @@ RegRestoreKeyA@12 RegRestoreKeyW@12 RegSaveKeyA@12 +;RegSaveKeyExA +;RegSaveKeyExW RegSaveKeyW@12 RegSetKeySecurity@12 RegSetValueA@20 @@ -359,28 +521,52 @@ RegUnLoadKeyW@8 RegisterEventSourceA@8 RegisterEventSourceW@8 +;RegisterIdleTask RegisterServiceCtrlHandlerA@8 -RegisterServiceCtrlHandlerW@8 RegisterServiceCtrlHandlerExA@12 RegisterServiceCtrlHandlerExW@12 -;ReplaceAllAccessRightsA -;ReplaceAllAccessRightsW +RegisterServiceCtrlHandlerW@8 +;RegisterTraceGuidsA +;RegisterTraceGuidsW +;RemoveTraceCallback +;RemoveUsersFromEncryptedFile ReportEventA@36 ReportEventW@36 RevertToSelf@0 -;RevokeExplicitAccessRightsA@16 -;RevokeExplicitAccessRightsW@16 -;SetAccessRightsA@16 -;SetAccessRightsW@16 +;SaferCloseLevel +;SaferComputeTokenFromLevel +;SaferCreateLevel +;SaferGetLevelInformation +;SaferGetPolicyInformation +;SaferIdentifyLevel +;SaferRecordEventLogEntry +;SaferSetLevelInformation +;SaferSetPolicyInformation +;SaferiChangeRegistryScope +;SaferiCompareTokenLevels +;SaferiIsExecutableFileType +;SaferiPopulateDefaultsInRegistry +;SaferiRecordEventLogEntry +;SaferiReplaceProcessThreadTokens +;SaferiSearchMatchingHashRules SetAclInformation@16 +;SetEntriesInAccessListA +;SetEntriesInAccessListW ;SetEntriesInAclA@16 ;SetEntriesInAclW@16 +;SetEntriesInAuditListA +;SetEntriesInAuditListW SetFileSecurityA@12 SetFileSecurityW@12 +;SetInformationCodeAuthzLevelW +;SetInformationCodeAuthzPolicyW SetKernelObjectSecurity@12 SetNamedSecurityInfoA@28 +;SetNamedSecurityInfoExA +;SetNamedSecurityInfoExW SetNamedSecurityInfoW@28 ;SetPrivateObjectSecurity@20 +;SetPrivateObjectSecurityEx SetSecurityDescriptorControl@12 SetSecurityDescriptorDacl@16 SetSecurityDescriptorGroup@12 @@ -388,15 +574,23 @@ SetSecurityDescriptorRMControl@8 SetSecurityDescriptorSacl@16 SetSecurityInfo@28 +;SetSecurityInfoExA +;SetSecurityInfoExW SetServiceBits@16 SetServiceObjectSecurity@12 SetServiceStatus@8 SetThreadToken@8 SetTokenInformation@16 +;SetTraceCallback +;SetUserFileEncryptionKey StartServiceA@12 StartServiceCtrlDispatcherA@4 StartServiceCtrlDispatcherW@4 StartServiceW@12 +;StartTraceA +;StartTraceW +;StopTraceA +;StopTraceW ;SynchronizeWindows31FilesAndWindowsNTRegistry@16 SystemFunction001@12 SystemFunction002@12 @@ -433,5 +627,60 @@ SystemFunction033@8 SystemFunction034@8 SystemFunction035@8 +SystemFunction036@8 +SystemFunction040@12 +SystemFunction041@12 +;TraceEvent +;TraceEventInstance +;TraceMessage +;TraceMessageVa +;TreeResetNamedSecurityInfoA +;TreeResetNamedSecurityInfoW +;TrusteeAccessToObjectA +;TrusteeAccessToObjectW +;UninstallApplication UnlockServiceDatabase@4 +;UnregisterIdleTask +;UnregisterTraceGuids +;UpdateTraceA +;UpdateTraceW +;WdmWmiServiceMain +;WmiCloseBlock +;WmiCloseTraceWithCursor +;WmiConvertTimestamp +;WmiDevInstToInstanceNameA +;WmiDevInstToInstanceNameW +;WmiEnumerateGuids +;WmiExecuteMethodA +;WmiExecuteMethodW +;WmiFileHandleToInstanceNameA +;WmiFileHandleToInstanceNameW +;WmiFreeBuffer +;WmiGetFirstTraceOffset +;WmiGetNextEvent +;WmiGetTraceHeader +;WmiMofEnumerateResourcesA +;WmiMofEnumerateResourcesW +;WmiNotificationRegistrationA +;WmiNotificationRegistrationW +;WmiOpenBlock +;WmiOpenTraceWithCursor +;WmiParseTraceEvent +;WmiQueryAllDataA +;WmiQueryAllDataMultipleA +;WmiQueryAllDataMultipleW +;WmiQueryAllDataW +;WmiQueryGuidInformation +;WmiQuerySingleInstanceA +;WmiQuerySingleInstanceMultipleA +;WmiQuerySingleInstanceMultipleW +;WmiQuerySingleInstanceW +;WmiReceiveNotificationsA +;WmiReceiveNotificationsW +;WmiSetSingleInstanceA +;WmiSetSingleInstanceW +;WmiSetSingleItemA +;WmiSetSingleItemW +;Wow64Win32ApiEntry +;WriteEncryptedFileRaw ; EOF _____ Modified: trunk/reactos/lib/advapi32/misc/sysfunc.c --- trunk/reactos/lib/advapi32/misc/sysfunc.c 2005-03-26 16:41:45 UTC (rev 14333) +++ trunk/reactos/lib/advapi32/misc/sysfunc.c 2005-03-26 17:52:32 UTC (rev 14334) @@ -452,4 +452,16 @@ return 35; } +/********************************************************************** + * + * @unimplemented + */ +INT +STDCALL +SystemFunction036(INT a, INT b) +{ + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return 36; +} + /* EOF */

19 years, 9 months

[greatlrd] 14333: Fix some more bugs thanks to Tribes.

by greatlrd＠svn.reactos.com

Fix some more bugs thanks to Tribes. Now the mouse y cordinate works fine Set right timestap on the event. Remove time delay on 50ms new code for 50ms event calction. Todo why does the Tribes get wrong x,y cordinate. why does the mouse limit area setup are wrong. Modified: trunk/reactos/lib/dinput/mouse.c _____ Modified: trunk/reactos/lib/dinput/mouse.c --- trunk/reactos/lib/dinput/mouse.c 2005-03-26 12:51:46 UTC (rev 14332) +++ trunk/reactos/lib/dinput/mouse.c 2005-03-26 16:41:45 UTC (rev 14333) @@ -871,6 +871,7 @@ static POINT point; int calc; int count_button; +int add = 0; #endif @@ -898,19 +899,13 @@ if (This->acquired == 0) { WARN(" application tries to get data from an unacquired device !\n"); - //return DIERR_NOTACQUIRED; + return DIERR_NOTACQUIRED; // windows does not get any data if // we do not call manual to mouse Acquire // this is only need if some apps calling on getdevice data direcly // in windows GetdeviceData does always update first the data // then return it. - if (last_event==0) - { - This->absolute = 0; - SysMouseAImpl_Acquire(iface); - FIXME("This make the mouse choppy in Tribes , need new center code for calcuation of the mouse !!!!!!!!\n"); - } } @@ -919,6 +914,7 @@ #ifdef __REACTOS__ + if (*entries == 0) return DIERR_INVALIDPARAM; if (dodsize < sizeof(DIDEVICEOBJECTDATA_DX3)) { @@ -930,44 +926,56 @@ return DIERR_NOTINITIALIZED; } +/* this code are not need it but if we want 100% compatible + with ms we should keep it. but the mouse will be choppy + in Unreal 2004 Demo + if (GetTickCount()-time <50) { *entries=0; return DI_OK; } - time = GetTickCount(); - - +*/ + if (GetTickCount()-time <50) + { + add=0; + } + else + { + add=1; + time = GetTickCount(); + } for (count=0;count<*entries;count++) { - if (save_point.x != point.x) { - dod[count_ent].dwOfs = DIMOFS_X; + + if (save_point.x != point.x) { + dod[count_ent].dwOfs = DIMOFS_X; - dod[count_ent].dwData = point.x - save_point.x; - dod[count_ent].dwTimeStamp = time +1; - dod[count_ent].dwSequence = last_event++; - count_ent++; - save_point.x = point.x; - } + dod[count_ent].dwData = point.x - save_point.x; + dod[count_ent].dwTimeStamp = GetTickCount(); + dod[count_ent].dwSequence = last_event+=add; + count_ent++; + save_point.x = point.x; + } - else if (save_point.y != point.y) { - dod[count_ent].dwOfs = DIMOFS_Y; - dod[count_ent].dwData = point.y - save_point.y; + else if (save_point.y != point.y) { + dod[count_ent].dwOfs = DIMOFS_Y; + dod[count_ent].dwData = point.y - save_point.y; - dod[count_ent].dwTimeStamp = time +1; - dod[count_ent].dwSequence = last_event; - count_ent++; - save_point.y = point.y; - } - + dod[count_ent].dwTimeStamp = GetTickCount(); + dod[count_ent].dwSequence = last_event+=add; + count_ent++; + save_point.y = point.y; + } + else if (save_b[0] != b[0]) { dod[count_ent].dwOfs = DIMOFS_BUTTON0; dod[count_ent].dwData = b[0]; - dod[count_ent].dwTimeStamp = time +1; - dod[count_ent].dwSequence = last_event; + dod[count_ent].dwTimeStamp = GetTickCount(); + dod[count_ent].dwSequence = last_event+=add; count_ent++; save_b[0] = b[0]; } @@ -976,8 +984,8 @@ dod[count_ent].dwOfs = DIMOFS_BUTTON1; dod[count_ent].dwData = b[1]; - dod[count_ent].dwTimeStamp = time ; - dod[count_ent].dwSequence = last_event; + dod[count_ent].dwTimeStamp = GetTickCount(); + dod[count_ent].dwSequence = last_event+=add; count_ent++; save_b[1] = b[1]; } @@ -986,8 +994,8 @@ dod[count_ent].dwOfs = DIMOFS_BUTTON2; dod[count_ent].dwData = b[2]; - dod[count_ent].dwTimeStamp = time ; - dod[count_ent].dwSequence = last_event; + dod[count_ent].dwTimeStamp = GetTickCount(); + dod[count_ent].dwSequence = last_event+=add; count_ent++; save_b[2] = b[2]; } @@ -996,8 +1004,8 @@ dod[count_ent].dwOfs = DIMOFS_BUTTON3; dod[count_ent].dwData = b[3]; - dod[count_ent].dwTimeStamp = time ; - dod[count_ent].dwSequence = last_event; + dod[count_ent].dwTimeStamp = GetTickCount(); + dod[count_ent].dwSequence = last_event+=add; count_ent++; save_b[3] = b[3]; } @@ -1005,8 +1013,8 @@ } // end for -if (count_ent>0)last_event++; -SetCursorPos(save_point.x, save_point.y); + +SetCursorPos(point.x, point.y); *entries = count_ent; #endif

19 years, 9 months

[navaraf] 14332: Created pnpmgr_cleanup branch. The purpose of this branch is to do overall cleanup of the kernel mode part of PnP manager (particulary the device tree functions) and address some long-standing bugs like #262.

by navaraf＠svn.reactos.com

Created pnpmgr_cleanup branch. The purpose of this branch is to do overall cleanup of the kernel mode part of PnP manager (particulary the device tree functions) and address some long-standing bugs like #262. Added: branches/pnpmgr_cleanup/reactos/ _____ Copied: branches/pnpmgr_cleanup/reactos (from rev 14331, trunk/reactos)

19 years, 9 months

[navaraf] 14331: Created pnpmgr_cleanup branch

by navaraf＠svn.reactos.com

Created pnpmgr_cleanup branch Added: branches/pnpmgr_cleanup/

19 years, 9 months

[greatlrd] 14330: Fix a small bug I introdues and fix a old bug for tribes

by greatlrd＠svn.reactos.com

Fix a small bug I introdues and fix a old bug for tribes Modified: trunk/reactos/lib/dinput/mouse.c _____ Modified: trunk/reactos/lib/dinput/mouse.c --- trunk/reactos/lib/dinput/mouse.c 2005-03-26 11:16:14 UTC (rev 14329) +++ trunk/reactos/lib/dinput/mouse.c 2005-03-26 11:58:43 UTC (rev 14330) @@ -898,17 +898,19 @@ if (This->acquired == 0) { WARN(" application tries to get data from an unacquired device !\n"); - return DIERR_NOTACQUIRED; + //return DIERR_NOTACQUIRED; // windows does not get any data if // we do not call manual to mouse Acquire // this is only need if some apps calling on getdevice data direcly // in windows GetdeviceData does always update first the data // then return it. - // SysMouseAImpl_Acquire(iface); - // we are reading the mouse before we reache here. - // we do not need call on SysMouseAImpl_Acquire - // for now. + if (last_event==0) + { + This->absolute = 0; + SysMouseAImpl_Acquire(iface); + FIXME("This make the mouse choppy in Tribes , need new center code for calcuation of the mouse !!!!!!!!\n"); + } } @@ -926,9 +928,7 @@ if (This->data_queue==NULL) { WARN("No buffer have been set up !\n"); return DIERR_NOTINITIALIZED; - } - - FIXME("This is broken in Tribes ??, need right implant of the buffer!!!!!!!!\n"); + } if (GetTickCount()-time <50) { *entries=0;

19 years, 9 months

[greatlrd] 14329: more bugfix for Tribes

by greatlrd＠svn.reactos.com

more bugfix for Tribes but still choppy mouse but not equal as last time Modified: trunk/reactos/lib/dinput/mouse.c _____ Modified: trunk/reactos/lib/dinput/mouse.c --- trunk/reactos/lib/dinput/mouse.c 2005-03-26 10:19:48 UTC (rev 14328) +++ trunk/reactos/lib/dinput/mouse.c 2005-03-26 11:16:14 UTC (rev 14329) @@ -957,9 +957,9 @@ dod[count_ent].dwData = point.y - save_point.y; dod[count_ent].dwTimeStamp = time +1; - dod[count_ent].dwSequence = last_event++; + dod[count_ent].dwSequence = last_event; count_ent++; - save_point.y = point.y; + save_point.y = point.y; } else if (save_b[0] != b[0]) { @@ -967,7 +967,7 @@ dod[count_ent].dwData = b[0]; dod[count_ent].dwTimeStamp = time +1; - dod[count_ent].dwSequence = last_event++; + dod[count_ent].dwSequence = last_event; count_ent++; save_b[0] = b[0]; } @@ -976,8 +976,8 @@ dod[count_ent].dwOfs = DIMOFS_BUTTON1; dod[count_ent].dwData = b[1]; - dod[count_ent].dwTimeStamp = time +1; - dod[count_ent].dwSequence = last_event++; + dod[count_ent].dwTimeStamp = time ; + dod[count_ent].dwSequence = last_event; count_ent++; save_b[1] = b[1]; } @@ -986,8 +986,8 @@ dod[count_ent].dwOfs = DIMOFS_BUTTON2; dod[count_ent].dwData = b[2]; - dod[count_ent].dwTimeStamp = time +1; - dod[count_ent].dwSequence = last_event++; + dod[count_ent].dwTimeStamp = time ; + dod[count_ent].dwSequence = last_event; count_ent++; save_b[2] = b[2]; } @@ -996,26 +996,17 @@ dod[count_ent].dwOfs = DIMOFS_BUTTON3; dod[count_ent].dwData = b[3]; - dod[count_ent].dwTimeStamp = time +1; - dod[count_ent].dwSequence = last_event++; + dod[count_ent].dwTimeStamp = time ; + dod[count_ent].dwSequence = last_event; count_ent++; save_b[3] = b[3]; } - - else if (save_b[4] != b[4]) { - dod[count_ent].dwOfs = DIMOFS_BUTTON4; - - dod[count_ent].dwData = b[4]; - dod[count_ent].dwTimeStamp = time +1; - dod[count_ent].dwSequence = last_event++; - count_ent++; - save_b[4] = b[4]; - } } // end for - +if (count_ent>0)last_event++; +SetCursorPos(save_point.x, save_point.y); *entries = count_ent; #endif

19 years, 9 months

[arty] 14328: Added tools needed to build the ppc boot program.

by arty＠svn.reactos.com

Added tools needed to build the ppc boot program. Modified: trunk/reactos/tools/Makefile Added: trunk/reactos/tools/hack-coff.c Added: trunk/reactos/tools/ppc-le2be.c Added: trunk/reactos/tools/rs6000.h _____ Modified: trunk/reactos/tools/Makefile --- trunk/reactos/tools/Makefile 2005-03-26 09:38:23 UTC (rev 14327) +++ trunk/reactos/tools/Makefile 2005-03-26 10:19:48 UTC (rev 14328) @@ -14,6 +14,8 @@ rsym$(EXE_POSTFIX) \ rtouch$(EXE_POSTFIX) \ mkflpimg$(EXE_POSTFIX) \ + ppc-le2be$(EXE_POSTFIX) \ + hack-coff$(EXE_POSTFIX) \ depends$(EXE_POSTFIX) LIBS = lib_unicode lib_wpp @@ -96,6 +98,24 @@ @$(HOST_CC) $(CFLAGS) -DDOS_PATHS mkflpimg.c -o mkflpimg$(EXE_POSTFIX) endif +ifeq ($(HOST),mingw32-linux) +hack-coff$(EXE_POSTFIX): hack-coff.c + @$(HOST_CC) $(CFLAGS) hack-coff.c -o hack-coff$(EXE_POSTFIX) +endif +ifeq ($(HOST),mingw32-windows) +hack-coff$(EXE_POSTFIX): hack-coff.c + @$(HOST_CC) $(CFLAGS) hack-coff.c -o hack-coff$(EXE_POSTFIX) +endif + +ifeq ($(HOST),mingw32-linux) +ppc-le2be$(EXE_POSTFIX): ppc-le2be.c + @$(HOST_CC) $(CFLAGS) ppc-le2be.c -o ppc-le2be$(EXE_POSTFIX) +endif +ifeq ($(HOST),mingw32-windows) +ppc-le2be$(EXE_POSTFIX): ppc-le2be.c + @$(HOST_CC) $(CFLAGS) ppc-le2be.c -o ppc-le2be$(EXE_POSTFIX) +endif + depends$(EXE_POSTFIX): depends.c @$(HOST_CC) $(CFLAGS) depends.c -o depends$(EXE_POSTFIX) _____ Added: trunk/reactos/tools/hack-coff.c --- trunk/reactos/tools/hack-coff.c 2005-03-26 09:38:23 UTC (rev 14327) +++ trunk/reactos/tools/hack-coff.c 2005-03-26 10:19:48 UTC (rev 14328) @@ -0,0 +1,83 @@ +/* + * hack-coff.c - hack the header of an xcoff file to fill in + * a few fields needed by the Open Firmware xcoff loader on + * Power Macs but not initialized by objcopy. + * + * Copyright (C) Paul Mackerras 1997. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + */ +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> +#include <fcntl.h> +#include <string.h> +#include "rs6000.h" + +#define AOUT_MAGIC 0x010b + +#define get_16be(x) ((((unsigned char *)(x))[0] << 8) \ + + ((unsigned char *)(x))[1]) +#define put_16be(x, v) (((unsigned char *)(x))[0] = (v) >> 8, \ + ((unsigned char *)(x))[1] = (v) & 0xff) +#define get_32be(x) ((((unsigned char *)(x))[0] << 24) \ + + (((unsigned char *)(x))[1] << 16) \ + + (((unsigned char *)(x))[2] << 8) \ + + ((unsigned char *)(x))[3]) + +int main(int ac, char **av) +{ + int fd; + int i, nsect; + int aoutsz; + struct external_filehdr fhdr; + AOUTHDR aout; + struct external_scnhdr shdr; + + if (ac != 2) { + fprintf(stderr, "Usage: hack-coff coff-file\n"); + exit(1); + } + if ((fd = open(av[1], 2)) == -1) { + perror(av[2]); + exit(1); + } + if (read(fd, &fhdr, sizeof(fhdr)) != sizeof(fhdr)) + goto readerr; + i = get_16be(fhdr.f_magic); + if (i != U802TOCMAGIC && i != U802WRMAGIC && i != U802ROMAGIC) { + fprintf(stderr, "%s: not an xcoff file\n", av[1]); + exit(1); + } + aoutsz = get_16be(fhdr.f_opthdr); + if (read(fd, &aout, aoutsz) != aoutsz) + goto readerr; + nsect = get_16be(fhdr.f_nscns); + for (i = 0; i < nsect; ++i) { + if (read(fd, &shdr, sizeof(shdr)) != sizeof(shdr)) + goto readerr; + if (strcmp(shdr.s_name, ".text") == 0) { + put_16be(aout.o_snentry, i+1); + put_16be(aout.o_sntext, i+1); + } else if (strcmp(shdr.s_name, ".data") == 0) { + put_16be(aout.o_sndata, i+1); + } else if (strcmp(shdr.s_name, ".bss") == 0) { + put_16be(aout.o_snbss, i+1); + } + } + put_16be(aout.magic, AOUT_MAGIC); + if (lseek(fd, (long) sizeof(struct external_filehdr), 0) == -1 + || write(fd, &aout, aoutsz) != aoutsz) { + fprintf(stderr, "%s: write error\n", av[1]); + exit(1); + } + close(fd); + exit(0); + +readerr: + fprintf(stderr, "%s: read error or file too short\n", av[1]); + exit(1); +} _____ Added: trunk/reactos/tools/ppc-le2be.c --- trunk/reactos/tools/ppc-le2be.c 2005-03-26 09:38:23 UTC (rev 14327) +++ trunk/reactos/tools/ppc-le2be.c 2005-03-26 10:19:48 UTC (rev 14328) @@ -0,0 +1,25 @@ +#include <stdio.h> + +int main( int argc, char **argv ) { + char buf[8]; + int rlen, i; + FILE *fin = NULL, *fout = NULL; + + if( argc < 3 ) return 1; + + fin = fopen( argv[1], "rb" ); + + if( fin ) + fout = fopen( argv[2], "wb" ); + if( !fout ) return 1; + + do { + rlen = fread( buf, 1, 8, fin ); + for( i = 7; rlen > 0 && i >= 0; i-- ) fputc( buf[i], fout ); + } + while( rlen == 8 ); + + fclose( fout ); + + return 0; +} _____ Added: trunk/reactos/tools/rs6000.h --- trunk/reactos/tools/rs6000.h 2005-03-26 09:38:23 UTC (rev 14327) +++ trunk/reactos/tools/rs6000.h 2005-03-26 10:19:48 UTC (rev 14328) @@ -0,0 +1,243 @@ +/* IBM RS/6000 "XCOFF" file definitions for BFD. + Copyright (C) 1990, 1991 Free Software Foundation, Inc. + FIXME: Can someone provide a transliteration of this name into ASCII? + Using the following chars caused a compiler warning on HIUX (so I replaced + them with octal escapes), and isn't useful without an understanding of what + character set it is. + Written by Mimi Ph\373\364ng-Th\345o V\365 of IBM + and John Gilmore of Cygnus Support. */ + +/********************** FILE HEADER **********************/ + +struct external_filehdr { + char f_magic[2]; /* magic number */ + char f_nscns[2]; /* number of sections */ + char f_timdat[4]; /* time & date stamp */ + char f_symptr[4]; /* file pointer to symtab */ + char f_nsyms[4]; /* number of symtab entries */ + char f_opthdr[2]; /* sizeof(optional hdr) */ + char f_flags[2]; /* flags */ +}; + + /* IBM RS/6000 */ +#define U802WRMAGIC 0730 /* writeable text segments **chh** */ +#define U802ROMAGIC 0735 /* readonly sharable text segments */ +#define U802TOCMAGIC 0737 /* readonly text segments and TOC */ + +#define BADMAG(x) \ + ((x).f_magic != U802ROMAGIC && (x).f_magic != U802WRMAGIC && \ + (x).f_magic != U802TOCMAGIC) + +#define FILHDR struct external_filehdr +#define FILHSZ 20 + + +/********************** AOUT "OPTIONAL HEADER" **********************/ + + +typedef struct +{ + unsigned char magic[2]; /* type of file */ + unsigned char vstamp[2]; /* version stamp */ + unsigned char tsize[4]; /* text size in bytes, padded to FW bdry */ + unsigned char dsize[4]; /* initialized data " " */ + unsigned char bsize[4]; /* uninitialized data " " */ + unsigned char entry[4]; /* entry pt. */ + unsigned char text_start[4]; /* base of text used for this file */ + unsigned char data_start[4]; /* base of data used for this file */ + unsigned char o_toc[4]; /* address of TOC */ + unsigned char o_snentry[2]; /* section number of entry point */ + unsigned char o_sntext[2]; /* section number of .text section */ + unsigned char o_sndata[2]; /* section number of .data section */ + unsigned char o_sntoc[2]; /* section number of TOC */ + unsigned char o_snloader[2]; /* section number of .loader section */ + unsigned char o_snbss[2]; /* section number of .bss section */ + unsigned char o_algntext[2]; /* .text alignment */ + unsigned char o_algndata[2]; /* .data alignment */ + unsigned char o_modtype[2]; /* module type (??) */ + unsigned char o_cputype[2]; /* cpu type */ + unsigned char o_maxstack[4]; /* max stack size (??) */ + unsigned char o_maxdata[4]; /* max data size (??) */ + unsigned char o_resv2[12]; /* reserved */ +} +AOUTHDR; + +#define AOUTSZ 72 +#define SMALL_AOUTSZ (28) +#define AOUTHDRSZ 72 + +#define RS6K_AOUTHDR_OMAGIC 0x0107 /* old: text & data writeable */ +#define RS6K_AOUTHDR_NMAGIC 0x0108 /* new: text r/o, data r/w */ +#define RS6K_AOUTHDR_ZMAGIC 0x010B /* paged: text r/o, both page-aligned */ + + +/********************** SECTION HEADER **********************/ + + +struct external_scnhdr { + char s_name[8]; /* section name */ + char s_paddr[4]; /* physical address, aliased s_nlib */ + char s_vaddr[4]; /* virtual address */ + char s_size[4]; /* section size */ + char s_scnptr[4]; /* file ptr to raw data for section */ + char s_relptr[4]; /* file ptr to relocation */ + char s_lnnoptr[4]; /* file ptr to line numbers */ + char s_nreloc[2]; /* number of relocation entries */ + char s_nlnno[2]; /* number of line number entries*/ + char s_flags[4]; /* flags */ +}; + +/* + * names of "special" sections + */ +#define _TEXT ".text" +#define _DATA ".data" +#define _BSS ".bss" +#define _PAD ".pad" +#define _LOADER ".loader" + +#define SCNHDR struct external_scnhdr +#define SCNHSZ 40 + +/* XCOFF uses a special .loader section with type STYP_LOADER. */ +#define STYP_LOADER 0x1000 + +/* XCOFF uses a special .debug section with type STYP_DEBUG. */ +#define STYP_DEBUG 0x2000 + +/* XCOFF handles line number or relocation overflow by creating + another section header with STYP_OVRFLO set. */ +#define STYP_OVRFLO 0x8000 + +/********************** LINE NUMBERS **********************/ + +/* 1 line number entry for every "breakpointable" source line in a section. + * Line numbers are grouped on a per function basis; first entry in a function + * grouping will have l_lnno = 0 and in place of physical address will be the + * symbol table index of the function name. + */ +struct external_lineno { + union { + char l_symndx[4]; /* function name symbol index, iff l_lnno == 0*/ + char l_paddr[4]; /* (physical) address of line number */ + } l_addr; + char l_lnno[2]; /* line number */ +}; + + +#define LINENO struct external_lineno +#define LINESZ 6 + + +/********************** SYMBOLS **********************/ + +#define E_SYMNMLEN 8 /* # characters in a symbol name */ +#define E_FILNMLEN 14 /* # characters in a file name */ +#define E_DIMNUM 4 /* # array dimensions in auxiliary entry */ + +struct external_syment +{ + union { + char e_name[E_SYMNMLEN]; + struct { + char e_zeroes[4]; + char e_offset[4]; + } e; + } e; + char e_value[4]; + char e_scnum[2]; + char e_type[2]; + char e_sclass[1]; + char e_numaux[1]; +}; + + + +#define N_BTMASK (017) +#define N_TMASK (060) +#define N_BTSHFT (4) +#define N_TSHIFT (2) + + +union external_auxent { + struct { + char x_tagndx[4]; /* str, un, or enum tag indx */ + union { + struct { + char x_lnno[2]; /* declaration line number */ + char x_size[2]; /* str/union/array size */ + } x_lnsz; + char x_fsize[4]; /* size of function */ + } x_misc; + union { + struct { /* if ISFCN, tag, or .bb */ + char x_lnnoptr[4]; /* ptr to fcn line # */ + char x_endndx[4]; /* entry ndx past block end */ + } x_fcn; + struct { /* if ISARY, up to 4 dimen. */ + char x_dimen[E_DIMNUM][2]; + } x_ary; + } x_fcnary; + char x_tvndx[2]; /* tv index */ + } x_sym; + + union { + char x_fname[E_FILNMLEN]; + struct { + char x_zeroes[4]; + char x_offset[4]; + } x_n; + } x_file; + + struct { + char x_scnlen[4]; /* section length */ + char x_nreloc[2]; /* # relocation entries */ + char x_nlinno[2]; /* # line numbers */ + } x_scn; + + struct { + char x_tvfill[4]; /* tv fill value */ + char x_tvlen[2]; /* length of .tv */ + char x_tvran[2][2]; /* tv range */ + } x_tv; /* info about .tv section (in auxent of symbol .tv)) */ + + struct { + unsigned char x_scnlen[4]; + unsigned char x_parmhash[4]; + unsigned char x_snhash[2]; + unsigned char x_smtyp[1]; + unsigned char x_smclas[1]; + unsigned char x_stab[4]; + unsigned char x_snstab[2]; + } x_csect; + +}; + +#define SYMENT struct external_syment +#define SYMESZ 18 +#define AUXENT union external_auxent +#define AUXESZ 18 +#define DBXMASK 0x80 /* for dbx storage mask */ +#define SYMNAME_IN_DEBUG(symptr) ((symptr)->n_sclass & DBXMASK) + + + +/********************** RELOCATION DIRECTIVES **********************/ + + +struct external_reloc { + char r_vaddr[4]; + char r_symndx[4]; + char r_size[1]; + char r_type[1]; +}; + + +#define RELOC struct external_reloc +#define RELSZ 10 + +#define DEFAULT_DATA_SECTION_ALIGNMENT 4 +#define DEFAULT_BSS_SECTION_ALIGNMENT 4 +#define DEFAULT_TEXT_SECTION_ALIGNMENT 4 +/* For new sections we havn't heard of before */ +#define DEFAULT_SECTION_ALIGNMENT 4

19 years, 9 months

[greatlrd] 14327: Fix some bugs for Tirbes in GetDeivceData

by greatlrd＠svn.reactos.com

Fix some bugs for Tirbes in GetDeivceData remove to call for geting mouse data. That are not need it. rest are bugs fix for Tirbes. Left Todo The mouse are bit choppy. The mouse area you can move the mouse are not being set up right. Modified: trunk/reactos/lib/dinput/mouse.c _____ Modified: trunk/reactos/lib/dinput/mouse.c --- trunk/reactos/lib/dinput/mouse.c 2005-03-26 00:10:34 UTC (rev 14326) +++ trunk/reactos/lib/dinput/mouse.c 2005-03-26 09:38:23 UTC (rev 14327) @@ -880,7 +880,6 @@ if (flags != DIGDD_PEEK) { -getmousesvalue(iface); b[0] = ((GetKeyState(VK_LBUTTON) & 0x80) ? 0xFF : 0x00); b[1] = ((GetKeyState(VK_RBUTTON) & 0x80) ? 0xFF : 0x00); b[2] = ((GetKeyState(VK_MBUTTON) & 0x80) ? 0xFF : 0x00); @@ -899,14 +898,17 @@ if (This->acquired == 0) { WARN(" application tries to get data from an unacquired device !\n"); - //return DIERR_NOTACQUIRED; + return DIERR_NOTACQUIRED; // windows does not get any data if // we do not call manual to mouse Acquire // this is only need if some apps calling on getdevice data direcly // in windows GetdeviceData does always update first the data // then return it. - SysMouseAImpl_Acquire(iface); + // SysMouseAImpl_Acquire(iface); + // we are reading the mouse before we reache here. + // we do not need call on SysMouseAImpl_Acquire + // for now. }

19 years, 9 months

[weiden] 14326: always wake waiting threads when releasing the last recursion

by weiden＠svn.reactos.com

always wake waiting threads when releasing the last recursion Modified: trunk/reactos/lib/ntdll/rtl/critical.c _____ Modified: trunk/reactos/lib/ntdll/rtl/critical.c --- trunk/reactos/lib/ntdll/rtl/critical.c 2005-03-25 23:23:35 UTC (rev 14325) +++ trunk/reactos/lib/ntdll/rtl/critical.c 2005-03-26 00:10:34 UTC (rev 14326) @@ -136,7 +136,7 @@ HANDLE Thread = (HANDLE)NtCurrentTeb()->Cid.UniqueThread; /* Try to Lock it */ - if (InterlockedIncrement(&CriticalSection->LockCount)) { + if (InterlockedIncrement(&CriticalSection->LockCount) != 0) { /* * We've failed to lock it! Does this thread @@ -332,12 +332,10 @@ CriticalSection->OwningThread = 0; /* Was someone wanting us? This needs to be done atomically. */ - if (InterlockedDecrement(&CriticalSection->LockCount) >= 0) { + InterlockedDecrement(&CriticalSection->LockCount); - /* Let him have us */ - RtlpUnWaitCriticalSection(CriticalSection); - - } + /* Let him have us */ + RtlpUnWaitCriticalSection(CriticalSection); } /* Sucessful! */

19 years, 9 months

← Newer
1
...
4
5
6
7
8
9
10
...
61
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs March 2005