Remove rant. H&E are very competent developers and made a typical bug
that anyone could've made. I was just pissed for having lost an hour
finding it ;)
Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c
_____
Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c
--- trunk/reactos/drivers/storage/scsiport/scsiport.c 2005-04-28
22:05:26 UTC (rev 14852)
+++ trunk/reactos/drivers/storage/scsiport/scsiport.c 2005-04-28
22:39:50 UTC (rev 14853)
@@ -2147,11 +2147,6 @@
((PUCHAR)AdapterBusInfo + sizeof(SCSI_ADAPTER_BUS_INFO) +
(sizeof(SCSI_BUS_DATA) * (AdapterBusInfo->NumberOfBuses - 1)));
- /*
- * RANT:
- * Whoever originally coded this to depend on the IRP's System Buffer
to be
- * magically cleared for him should never be allowed to code drivers
again.
- */
RtlZeroMemory(UnitInfo, sizeof(*UnitInfo));
for (Bus = 0; Bus < AdapterBusInfo->NumberOfBuses; Bus++)
Fix all these warings
libnurbs/nurbtess/sampleComp.cc: In function `void sampleCompLeft(Real*,
Real*, vertexArray*, Int, Int, vertexArray*, Int, Int,
gridBoundaryChain*, Int, Int, Int, Int, Int, Int, primStream*)':
libnurbs/nurbtess/sampleComp.cc:162: warning: 'gridMidIndex1' might be
used uninitialized in this function
libnurbs/nurbtess/sampleComp.cc:162: warning: 'gridMidIndex2' might be
used uninitialized in this function
libnurbs/nurbtess/sampleCompRight.cc: In function `void
sampleCompRight(Real*, Real*, vertexArray*, Int, Int, vertexArray*, Int,
Int, gridBoundaryChain*, Int, Int, Int, Int, Int, Int, primStream*)':
libnurbs/nurbtess/sampleCompRight.cc:75: warning: 'gridMidIndex1' might
be used uninitialized in this function
libnurbs/nurbtess/sampleCompRight.cc:75: warning: 'gridMidIndex2' might
be used uninitialized in this function
Modified: trunk/reactos/lib/glu32/libnurbs/nurbtess/sampleComp.cc
Modified: trunk/reactos/lib/glu32/libnurbs/nurbtess/sampleCompRight.cc
_____
Modified: trunk/reactos/lib/glu32/libnurbs/nurbtess/sampleComp.cc
--- trunk/reactos/lib/glu32/libnurbs/nurbtess/sampleComp.cc
2005-04-28 13:54:19 UTC (rev 14844)
+++ trunk/reactos/lib/glu32/libnurbs/nurbtess/sampleComp.cc
2005-04-28 13:55:35 UTC (rev 14845)
@@ -157,9 +157,9 @@
/*find out whether there is a trim vertex which is
*inbetween the top and bot grid lines or not.
*/
- Int midIndex1;
- Int midIndex2;
- Int gridMidIndex1, gridMidIndex2;
+ Int midIndex1 = 0;
+ Int midIndex2 = 0;
+ Int gridMidIndex1 = 0, gridMidIndex2 = 0;
//midIndex1: array[i] <= v, array[i-1] > v
//midIndex2: array[i] >= v, array[i+1] < v
// v(gridMidIndex1) >= v(midindex1) > v(gridMidIndex1+1)
_____
Modified: trunk/reactos/lib/glu32/libnurbs/nurbtess/sampleCompRight.cc
--- trunk/reactos/lib/glu32/libnurbs/nurbtess/sampleCompRight.cc
2005-04-28 13:54:19 UTC (rev 14844)
+++ trunk/reactos/lib/glu32/libnurbs/nurbtess/sampleCompRight.cc
2005-04-28 13:55:35 UTC (rev 14845)
@@ -72,7 +72,7 @@
*/
Int midIndex1;
Int midIndex2;
- Int gridMidIndex1, gridMidIndex2;
+ Int gridMidIndex1 =0, gridMidIndex2 =0;
//midIndex1: array[i] <= v, array[i+1] > v
//midIndex2: array[i] >= v, array[i+1] < v
midIndex1 =
rightChain->findIndexBelowGen(rightGridChain->get_v_value(gridIndex1),