merge mixed case startup menu folders
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/startmenu.
cpp
_____
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/startmenu.
cpp
---
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/startmenu.
cpp 2005-05-01 22:20:13 UTC (rev 14936)
+++
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/startmenu.
cpp 2005-05-01 22:26:55 UTC (rev 14937)
@@ -986,7 +986,7 @@
for(ShellEntryMap::iterator it=_entries.begin();
it!=_entries.end(); ++it) {
StartMenuEntry& sme = it->second;
- if (sme._title == title) ///@todo speed
up by using a map indexed by name
+ if (!_tcsicmp(sme._title, title)) ///@todo
speed up by using a map indexed by name
for(ShellEntrySet::iterator
it2=sme._entries.begin(); it2!=sme._entries.end(); ++it2) {
if
((*it2)->_data.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) {
// merge the new shell
entry with the existing of the same name
Do not signal event twice. Thanks to Gunnar for finding the bug
Modified: trunk/reactos/ntoskrnl/io/irp.c
_____
Modified: trunk/reactos/ntoskrnl/io/irp.c
--- trunk/reactos/ntoskrnl/io/irp.c 2005-05-01 21:22:13 UTC (rev
14932)
+++ trunk/reactos/ntoskrnl/io/irp.c 2005-05-01 21:51:57 UTC (rev
14933)
@@ -1279,7 +1279,26 @@
{
/* Signal the Event */
KeSetEvent(Irp->UserEvent, 0, FALSE);
-
+
+ /* Check if we should signal the File Object Event as well
*/
+ if (FileObject)
+ {
+ /* Dereference the Event if this is an ASYNC IRP */
+ if (!Irp->Flags & IRP_SYNCHRONOUS_API)
+ {
+ ObDereferenceObject(Irp->UserEvent);
+ }
+
+ /* If the File Object is SYNC, then we need to signal
its event too */
+ if (FileObject->Flags & FO_SYNCHRONOUS_IO)
+ {
+ /* Signal Event */
+ KeSetEvent(&FileObject->Event, 0, FALSE);
+
+ /* Set the Status */
+ FileObject->FinalStatus = Irp->IoStatus.Status;
+ }
+ }
}
else if (FileObject)
{
@@ -1289,31 +1308,7 @@
/* Set the Status */
FileObject->FinalStatus = Irp->IoStatus.Status;
}
-
- /* Check if there's a File Object */
- if (FileObject)
- {
- /* Dereference the Event if this is an ASYNC IRP */
- if (!Irp->Flags & IRP_SYNCHRONOUS_API)
- {
- if (Irp->UserEvent != &FileObject->Event)
- {
- ObDereferenceObject(Irp->UserEvent);
- }
- }
-
- /* If the File Object is SYNC, then we need to signal its
event too */
- if (FileObject->Flags & FO_SYNCHRONOUS_IO)
- {
- /* Signal Event */
-
- KeSetEvent(&FileObject->Event, 0, FALSE);
-
- /* Set the Status */
- FileObject->FinalStatus = Irp->IoStatus.Status;
- }
- }
-
+
/* Remove the IRP from the list of Thread Pending IRPs */
RemoveEntryList(&Irp->ThreadListEntry);
InitializeListHead(&Irp->ThreadListEntry);
some cleanups in the lean explorer code
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/desktop/desktop.cp
p
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/explorer.h
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/explorer_intres.rc
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/globals.h
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/rosshell.dsp
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/shell/entries.cpp
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/desktopbar
.cpp
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/startmenu.
cpp
_____
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/desktop/desktop.cp
p
---
branches/lean-explorer/reactos/subsys/system/explorer/desktop/desktop.cp
p 2005-05-01 21:03:02 UTC (rev 14929)
+++
branches/lean-explorer/reactos/subsys/system/explorer/desktop/desktop.cp
p 2005-05-01 21:12:50 UTC (rev 14930)
@@ -1,5 +1,5 @@
/*
- * Copyright 2003, 2004 Martin Fuchs
+ * Copyright 2003, 2004, 2005 Martin Fuchs
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
_____
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/explorer.h
--- branches/lean-explorer/reactos/subsys/system/explorer/explorer.h
2005-05-01 21:03:02 UTC (rev 14929)
+++ branches/lean-explorer/reactos/subsys/system/explorer/explorer.h
2005-05-01 21:12:50 UTC (rev 14930)
@@ -1,5 +1,5 @@
/*
- * Copyright 2003, 2004 Martin Fuchs
+ * Copyright 2003, 2004, 2005 Martin Fuchs
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
_____
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/explorer_intres.rc
---
branches/lean-explorer/reactos/subsys/system/explorer/explorer_intres.rc
2005-05-01 21:03:02 UTC (rev 14929)
+++
branches/lean-explorer/reactos/subsys/system/explorer/explorer_intres.rc
2005-05-01 21:12:50 UTC (rev 14930)
@@ -258,7 +258,9 @@
3 TEXTINCLUDE DISCARDABLE
BEGIN
+ "#ifndef ROSSHELL\r\n"
"IDB_TOOLBAR BITMAP DISCARDABLE ""res/toolbar.bmp""\r\n"
+ "#endif\r\n"
"#ifndef _ROS_\r\n"
"LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL\r\n"
"STRINGTABLE DISCARDABLE \r\n"
_____
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/globals.h
--- branches/lean-explorer/reactos/subsys/system/explorer/globals.h
2005-05-01 21:03:02 UTC (rev 14929)
+++ branches/lean-explorer/reactos/subsys/system/explorer/globals.h
2005-05-01 21:12:50 UTC (rev 14930)
@@ -1,5 +1,5 @@
/*
- * Copyright 2003, 2004 Martin Fuchs
+ * Copyright 2003, 2004, 2005 Martin Fuchs
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
_____
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/rosshell.dsp
--- branches/lean-explorer/reactos/subsys/system/explorer/rosshell.dsp
2005-05-01 21:03:02 UTC (rev 14929)
+++ branches/lean-explorer/reactos/subsys/system/explorer/rosshell.dsp
2005-05-01 21:12:50 UTC (rev 14930)
@@ -297,7 +297,7 @@
# End Source File
# Begin Source File
-SOURCE=".\rosshell-jp.rc"
+SOURCE=".\explorer-jp.rc"
# PROP Exclude_From_Build 1
# End Source File
# Begin Source File
_____
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/shell/entries.cpp
---
branches/lean-explorer/reactos/subsys/system/explorer/shell/entries.cpp
2005-05-01 21:03:02 UTC (rev 14929)
+++
branches/lean-explorer/reactos/subsys/system/explorer/shell/entries.cpp
2005-05-01 21:12:50 UTC (rev 14930)
@@ -1,5 +1,5 @@
/*
- * Copyright 2003, 2004 Martin Fuchs
+ * Copyright 2003, 2004, 2005 Martin Fuchs
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
_____
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/desktopbar
.cpp
---
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/desktopbar
.cpp 2005-05-01 21:03:02 UTC (rev 14929)
+++
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/desktopbar
.cpp 2005-05-01 21:12:50 UTC (rev 14930)
@@ -131,9 +131,9 @@
void DesktopBar::ProcessHotKey(int id_hotkey)
{
switch(id_hotkey) {
- case 0:
- explorer_show_frame(SW_SHOWNORMAL);
+ case 0: explorer_show_frame(SW_SHOWNORMAL);
break;
+
///@todo implement all common hotkeys
}
}
_____
Modified:
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/startmenu.
cpp
---
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/startmenu.
cpp 2005-05-01 21:03:02 UTC (rev 14929)
+++
branches/lean-explorer/reactos/subsys/system/explorer/taskbar/startmenu.
cpp 2005-05-01 21:12:50 UTC (rev 14930)
@@ -1,5 +1,5 @@
/*
- * Copyright 2003, 2004 Martin Fuchs
+ * Copyright 2003, 2004, 2005 Martin Fuchs
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public