Ros-diffs June 2005

ros-diffs@reactos.org

22 participants
649 discussions

[weiden] 15989: - fixed a possible deadlock in SmBeginClientInitialization
by weiden＠svn.reactos.com 17 Jun '05

17 Jun '05

- fixed a possible deadlock in SmBeginClientInitialization - fixed SmCompleteClientInitialization to return success when the client data could be found - don't copy the program name to a NULL pointer in SmCreateClient in case allocating the storage failed Modified: trunk/reactos/subsys/smss/client.c _____ Modified: trunk/reactos/subsys/smss/client.c --- trunk/reactos/subsys/smss/client.c 2005-06-17 16:12:33 UTC (rev 15988) +++ trunk/reactos/subsys/smss/client.c 2005-06-17 16:26:04 UTC (rev 15989) @@ -177,6 +177,7 @@ DPRINT("SM: %s: attempt to register again subsystem %d.\n", __FUNCTION__, ConnectData->SubSystemId); + RtlLeaveCriticalSection (& SmpClientDirectory.Lock); return STATUS_UNSUCCESSFUL; } DPRINT("SM: %s: registering subsystem ID=%d \n", @@ -245,7 +246,7 @@ NTSTATUS STDCALL SmCompleteClientInitialization (ULONG ProcessId) { - NTSTATUS Status = STATUS_SUCCESS; + NTSTATUS Status = STATUS_NOT_FOUND; PSM_CLIENT_DATA Client = NULL; DPRINT("SM: %s called\n", __FUNCTION__); @@ -259,11 +260,11 @@ if (ProcessId == Client->ServerProcessId) { SmpSetClientInitialized (Client); + Status = STATUS_SUCCESS; break; } Client = Client->Next; } - Status = STATUS_NOT_FOUND; } RtlLeaveCriticalSection (& SmpClientDirectory.Lock); return Status; @@ -321,13 +322,14 @@ (HANDLE) ProcessInfo->ProcessHandle; SmpClientDirectory.CandidateClient->ServerProcessId = (ULONG) ProcessInfo->ClientId.UniqueProcess; + /* + * Copy the program name + */ + RtlCopyMemory (SmpClientDirectory.CandidateClient->ProgramName, + ProgramName, + SM_SB_NAME_MAX_LENGTH); } - /* - * Copy the program name - */ - RtlCopyMemory (SmpClientDirectory.CandidateClient->ProgramName, - ProgramName, - SM_SB_NAME_MAX_LENGTH); + RtlLeaveCriticalSection (& SmpClientDirectory.Lock); return Status; }

1 0

[chorns] 15988: Build wrc in output tree.
by chorns＠svn.reactos.com 17 Jun '05

17 Jun '05

Build wrc in output tree. Patch by Sylvain Petreolle [spetreolle(a)yahoo.fr]. Modified: trunk/reactos/tools/wrc/wrc.mak _____ Modified: trunk/reactos/tools/wrc/wrc.mak --- trunk/reactos/tools/wrc/wrc.mak 2005-06-17 15:48:15 UTC (rev 15987) +++ trunk/reactos/tools/wrc/wrc.mak 2005-06-17 16:12:33 UTC (rev 15988) @@ -33,7 +33,7 @@ endif WRC_TARGET = \ - $(EXEPREFIX)$(WRC_BASE_)wrc$(EXEPOSTFIX) + $(EXEPREFIX)$(WRC_OUT_)wrc$(EXEPOSTFIX) WRC_SOURCES = $(addprefix $(WRC_BASE_), \ dumpres.c \

1 0

[hpoussin] 15987: Disable some code in cromwell, as you get an infinite loop on some hardware ("ERR: drivers\usb\cromwell\uhci\uhci-hcd.c: 1060: host controller halted. very bad during boot")
by hpoussin＠svn.reactos.com 17 Jun '05

17 Jun '05

Disable some code in cromwell, as you get an infinite loop on some hardware ("ERR: drivers\usb\cromwell\uhci\uhci-hcd.c: 1060: host controller halted. very bad during boot") Modified: trunk/reactos/drivers/usb/cromwell/sys/linuxwrapper.c _____ Modified: trunk/reactos/drivers/usb/cromwell/sys/linuxwrapper.c --- trunk/reactos/drivers/usb/cromwell/sys/linuxwrapper.c 2005-06-17 15:47:10 UTC (rev 15986) +++ trunk/reactos/drivers/usb/cromwell/sys/linuxwrapper.c 2005-06-17 15:48:15 UTC (rev 15987) @@ -118,13 +118,13 @@ ASSERT(KeGetCurrentIrql() == PASSIVE_LEVEL); - PsCreateSystemThread(&hThread, + /*PsCreateSystemThread(&hThread, THREAD_ALL_ACCESS, NULL, NULL, NULL, (PKSTART_ROUTINE)handler, - parm); + parm);*/ DPRINT1("usbcore: Created system thread %d\n", (int)hThread);

1 0

[greatlrd] 15986: New icon from mf. same as cmd icon
by greatlrd＠svn.reactos.com 17 Jun '05

17 Jun '05

New icon from mf. same as cmd icon Modified: trunk/reactos/subsys/csrss/win32csr/res/terminal.ico _____ Modified: trunk/reactos/subsys/csrss/win32csr/res/terminal.ico (Binary files differ)

1 0

[navaraf] 15985: Use W32API.
by navaraf＠svn.reactos.com 17 Jun '05

17 Jun '05

Use W32API. Modified: trunk/reactos/drivers/net/tdi/tdi.xml _____ Modified: trunk/reactos/drivers/net/tdi/tdi.xml --- trunk/reactos/drivers/net/tdi/tdi.xml 2005-06-17 14:00:19 UTC (rev 15984) +++ trunk/reactos/drivers/net/tdi/tdi.xml 2005-06-17 15:10:01 UTC (rev 15985) @@ -1,5 +1,6 @@ <module name="tdi" type="kernelmodedriver" installbase="system32/drivers" installname="tdi.sys"> <importlibrary definition="misc/tdi.def"></importlibrary> + <define name="__USE_W32API" /> <library>ntoskrnl</library> <library>hal</library> <directory name="cte">

1 0

[navaraf] 15984: Get rid of obsolete makefile.
by navaraf＠svn.reactos.com 17 Jun '05

17 Jun '05

Get rid of obsolete makefile. Deleted: trunk/reactos/drivers/storage/floppy/GNUmakefile _____ Deleted: trunk/reactos/drivers/storage/floppy/GNUmakefile --- trunk/reactos/drivers/storage/floppy/GNUmakefile 2005-06-17 13:59:47 UTC (rev 15983) +++ trunk/reactos/drivers/storage/floppy/GNUmakefile 2005-06-17 14:00:19 UTC (rev 15984) @@ -1,37 +0,0 @@ -# ReactOS Floppy Driver -# Copyright (C) 2004, Vizzini (vizzini(a)plasmic.com) -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -# -# PROJECT: ReactOS Floppy Driver -# FILE: GNUMakefile -# PURPOSE: Makefile for ReactOS build system -# PROGRAMMER: Vizzini (vizzini(a)plasmic.com) -# REVISIONS: -# 15-Feb-2004 vizzini - Created/ - -PATH_TO_TOP = ../../.. -TARGET_BOOTSTRAP = yes -TARGET_TYPE = driver -TARGET_NAME = floppy -TARGET_CFLAGS = -Wall -Werror -TARGET_OBJECTS = floppy.o csqrtns.o hardware.o readwrite.o ioctl.o -TARGET_DDKLIBS = csq.a - -DEP_OBJECTS = $(TARGET_OBJECTS) - -include $(PATH_TO_TOP)/rules.mak -include $(TOOLS_PATH)/helper.mk -include $(TOOLS_PATH)/depend.mk

1 0

[navaraf] 15983: CSQ is linked to the kernel also, so make that work.
by navaraf＠svn.reactos.com 17 Jun '05

17 Jun '05

CSQ is linked to the kernel also, so make that work. Modified: trunk/reactos/drivers/lib/csq/csq.xml _____ Modified: trunk/reactos/drivers/lib/csq/csq.xml --- trunk/reactos/drivers/lib/csq/csq.xml 2005-06-17 13:24:50 UTC (rev 15982) +++ trunk/reactos/drivers/lib/csq/csq.xml 2005-06-17 13:59:47 UTC (rev 15983) @@ -1,4 +1,5 @@ <module name="csq" type="staticlibrary"> <define name="__USE_W32API"/> + <define name="_NTOSKRNL_"/> <file>csq.c</file> </module>

1 0

[navaraf] 15982: Use W32API.
by navaraf＠svn.reactos.com 17 Jun '05

17 Jun '05

Use W32API. Modified: trunk/reactos/drivers/lib/oskittcp/oskittcp.xml _____ Modified: trunk/reactos/drivers/lib/oskittcp/oskittcp.xml --- trunk/reactos/drivers/lib/oskittcp/oskittcp.xml 2005-06-17 13:22:12 UTC (rev 15981) +++ trunk/reactos/drivers/lib/oskittcp/oskittcp.xml 2005-06-17 13:24:50 UTC (rev 15982) @@ -3,6 +3,7 @@ <define name="__NTDRIVER__"/> <define name="KERNEL"/> <define name="_DISABLE_TIDENTS"/> + <define name="__USE_W32API"/> <include>drivers/lib/oskittcp/include/freebsd</include> <include>drivers/lib/oskittcp/include/freebsd/sys/include</include> <include>drivers/lib/oskittcp/include/freebsd/src/sys</include>

1 0

[navaraf] 15981: Remove KEBUGCHECK and KEBUGCHECKEX definitions.
by navaraf＠svn.reactos.com 17 Jun '05

17 Jun '05

Remove KEBUGCHECK and KEBUGCHECKEX definitions. Modified: trunk/reactos/drivers/fs/vfat/vfat.h _____ Modified: trunk/reactos/drivers/fs/vfat/vfat.h --- trunk/reactos/drivers/fs/vfat/vfat.h 2005-06-17 13:17:46 UTC (rev 15980) +++ trunk/reactos/drivers/fs/vfat/vfat.h 2005-06-17 13:22:12 UTC (rev 15981) @@ -23,9 +23,6 @@ typedef struct _ROS_QUERY_LCN_MAPPING { LARGE_INTEGER LcnDiskOffset; } ROS_QUERY_LCN_MAPPING, *PROS_QUERY_LCN_MAPPING; #endif -#define KEBUGCHECK(a) DbgPrint("KeBugCheck at %s:%i\n",__FILE__,__LINE__), KeBugCheck(a) -#define KEBUGCHECKEX(a,b,c,d,e) DbgPrint("KeBugCheckEx at %s:%i\n",__FILE__,__LINE__), KeBugCheckEx(a,b,c,d,e) - #define ROUND_UP(N, S) ((((N) + (S) - 1) / (S)) * (S)) #define ROUND_DOWN(N, S) ((N) - ((N) % (S)))

1 0

[navaraf] 15980: Fix a typo. :(
by navaraf＠svn.reactos.com 17 Jun '05

17 Jun '05

Fix a typo. :( Modified: trunk/reactos/include/debug.h _____ Modified: trunk/reactos/include/debug.h --- trunk/reactos/include/debug.h 2005-06-17 13:13:37 UTC (rev 15979) +++ trunk/reactos/include/debug.h 2005-06-17 13:17:46 UTC (rev 15980) @@ -93,7 +93,7 @@ #error Unsupported architecture. #endif -#ifndes KEBUGCHECK +#ifndef KEBUGCHECK #define KEBUGCHECK(a) DbgPrint("KeBugCheck (0x%X) at %s:%i\n", a, __FILE__,__LINE__), KeBugCheck(a) #define KEBUGCHECKEX(a,b,c,d,e) DbgPrint("KeBugCheckEx (0x%X, 0x%X, 0x%X, 0x%X, 0x%X) at %s:%i\n", a, b, c, d, e, __FILE__,__LINE__), KeBugCheckEx(a,b,c,d,e) #endif

1 0

← Newer
1
...
35
36
37
38
39
40
41
...
65
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2005