Ros-diffs October 2006

ros-diffs@reactos.org

17 participants
357 discussions

[weiden] 24473: Make sure the compiler doesn't optimize away writes to video memory
by weiden＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: weiden Date: Mon Oct 9 20:37:27 2006 New Revision: 24473 URL: http://svn.reactos.org/svn/reactos?rev=24473&view=rev Log: Make sure the compiler doesn't optimize away writes to video memory Modified: trunk/reactos/drivers/base/bootvid/vid_vgatext.c Modified: trunk/reactos/drivers/base/bootvid/vid_vgatext.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/vid_v… ============================================================================== --- trunk/reactos/drivers/base/bootvid/vid_vgatext.c (original) +++ trunk/reactos/drivers/base/bootvid/vid_vgatext.c Mon Oct 9 20:37:27 2006 @@ -61,7 +61,7 @@ static VOID NTAPI VidpVgaTextClearDisplay(VOID) { - WORD *ptr = (WORD*)VidpMemory; + volatile WORD *ptr = (volatile WORD*)VidpMemory; ULONG i; for (i = 0; i < SizeX * SizeY; i++, ptr++) @@ -166,13 +166,12 @@ static VOID NTAPI VidpVgaTextScrollDisplay(VOID) { - PUSHORT ptr; + volatile USHORT *ptr; int i; - ptr = (PUSHORT)VidpMemory + SizeX; - RtlMoveMemory(VidpMemory, ptr, SizeX * (SizeY - 1) * 2); - - ptr = (PUSHORT)VidpMemory + (SizeX * (SizeY - 1)); + RtlMoveMemory(VidpMemory, (PUSHORT)VidpMemory + SizeX, SizeX * (SizeY - 1) * 2); + + ptr = (volatile USHORT *)VidpMemory + (SizeX * (SizeY - 1)); for (i = 0; i < (int)SizeX; i++, ptr++) *ptr = (CHAR_ATTRIBUTE << 8) + ' '; } @@ -210,9 +209,9 @@ } else if (*pch != '\r') { - PUSHORT ptr; - - ptr = (PUSHORT)VidpMemory + ((CursorY * SizeX) + CursorX); + volatile USHORT *ptr; + + ptr = (volatile USHORT *)VidpMemory + ((CursorY * SizeX) + CursorX); *ptr = (CHAR_ATTRIBUTE << 8) + *pch; CursorX++;

1 0

[weiden] 24472: Some portability fixes that address possible alignment issues. Read R. Chen's blog 10/06/06 for more information.
by weiden＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: weiden Date: Mon Oct 9 19:09:50 2006 New Revision: 24472 URL: http://svn.reactos.org/svn/reactos?rev=24472&view=rev Log: Some portability fixes that address possible alignment issues. Read R. Chen's blog 10/06/06 for more information. Modified: trunk/reactos/dll/win32/aclui/aclui.c trunk/reactos/dll/win32/advapi32/sec/sid.c trunk/reactos/lib/rtl/sd.c trunk/reactos/lib/rtl/sid.c trunk/reactos/ntoskrnl/se/sid.c Modified: trunk/reactos/dll/win32/aclui/aclui.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/aclui/aclui.c?re… ============================================================================== --- trunk/reactos/dll/win32/aclui/aclui.c (original) +++ trunk/reactos/dll/win32/aclui/aclui.c Mon Oct 9 19:09:50 2006 @@ -1047,7 +1047,8 @@ WORD AceSize; SidLen = GetLengthSid(pSid); - AceSize = sizeof(ACCESS_ALLOWED_ACE) + (WORD)SidLen - sizeof(DWORD); + AceSize = FIELD_OFFSET(ACCESS_ALLOWED_ACE, + SidStart) + (WORD)SidLen; Ace = HeapAlloc(GetProcessHeap(), 0, AceSize); Modified: trunk/reactos/dll/win32/advapi32/sec/sid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/sid… ============================================================================== --- trunk/reactos/dll/win32/advapi32/sec/sid.c (original) +++ trunk/reactos/dll/win32/advapi32/sec/sid.c Mon Oct 9 19:09:50 2006 @@ -184,7 +184,7 @@ return !status; } -#define WINE_SIZE_OF_WORLD_ACCESS_ACL (sizeof(ACL) + sizeof(ACCESS_ALLOWED_ACE) + sizeof(sidWorld) - sizeof(DWORD)) +#define WINE_SIZE_OF_WORLD_ACCESS_ACL (sizeof(ACL) + FIELD_OFFSET(ACCESS_ALLOWED_ACE, SidStart) + sizeof(sidWorld)) /* some helper functions - taken from winehq cvs 20050916 */ @@ -428,7 +428,7 @@ goto lerr; StringAcl++; - length += sizeof(ACCESS_ALLOWED_ACE) - sizeof(DWORD) + sidlen; + length += FIELD_OFFSET(ACCESS_ALLOWED_ACE, SidStart) + sidlen; } *cBytes = length; Modified: trunk/reactos/lib/rtl/sd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/sd.c?rev=24472&r1=… ============================================================================== --- trunk/reactos/lib/rtl/sd.c (original) +++ trunk/reactos/lib/rtl/sd.c Mon Oct 9 19:09:50 2006 @@ -812,8 +812,6 @@ &pSacl, &SaclLength); - ASSERT(sizeof(SECURITY_DESCRIPTOR) > sizeof(SECURITY_DESCRIPTOR_RELATIVE)); - /* calculate the start and end of the data area, we simply just move the data by the difference between the size of the relative and absolute security descriptor structure */ Modified: trunk/reactos/lib/rtl/sid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/sid.c?rev=24472&r1… ============================================================================== --- trunk/reactos/lib/rtl/sid.c (original) +++ trunk/reactos/lib/rtl/sid.c Mon Oct 9 19:09:50 2006 @@ -42,8 +42,8 @@ { PAGED_CODE_RTL(); - return (sizeof(SID) - (ANYSIZE_ARRAY * sizeof(ULONG)) + - (SubAuthorityCount * sizeof(ULONG))); + return (ULONG)FIELD_OFFSET(SID, + SubAuthority[SubAuthorityCount]); } @@ -132,8 +132,8 @@ PAGED_CODE_RTL(); - return (sizeof(SID) - sizeof(Sid->SubAuthority) + - (Sid->SubAuthorityCount * sizeof(ULONG))); + return (ULONG)FIELD_OFFSET(SID, + SubAuthority[Sid->SubAuthorityCount]); } Modified: trunk/reactos/ntoskrnl/se/sid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sid.c?rev=2447… ============================================================================== --- trunk/reactos/ntoskrnl/se/sid.c (original) +++ trunk/reactos/ntoskrnl/se/sid.c Mon Oct 9 19:09:50 2006 @@ -246,7 +246,8 @@ _SEH_TRY { ProbeForRead(Sid, - sizeof(*Sid) - sizeof(Sid->SubAuthority), + FIELD_OFFSET(SID, + SubAuthority), sizeof(UCHAR)); SidSize = RtlLengthRequiredSid(Sid->SubAuthorityCount); ProbeForRead(Sid,

1 0

[fireball] 24471: Revert r24430 changes (by Magnus Olsen) since they are incorrect (additionally confirmed by Filip Navara)
by fireball＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: fireball Date: Mon Oct 9 19:02:33 2006 New Revision: 24471 URL: http://svn.reactos.org/svn/reactos?rev=24471&view=rev Log: Revert r24430 changes (by Magnus Olsen) since they are incorrect (additionally confirmed by Filip Navara) Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c Mon Oct 9 19:02:33 2006 @@ -1221,7 +1221,7 @@ } if (RgnType != ERROR && RgnType != NULLREGION) { - if ((Window->Parent == UserGetDesktopWindow()) && (Window->Style & WS_VISIBLE)) + if (Window->Parent) { NtGdiOffsetRgn(DirtyRgn, Window->WindowRect.left - Window->Parent->ClientRect.left, @@ -1229,7 +1229,7 @@ co_UserRedrawWindow(Window->Parent, NULL, DirtyRgn, RDW_ERASE | RDW_FRAME | RDW_INVALIDATE | RDW_ALLCHILDREN); } - else + else { NtGdiOffsetRgn(DirtyRgn, Window->WindowRect.left - Window->ClientRect.left,

1 0

[weiden] 24470: Fix compilation with GCC4
by weiden＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: weiden Date: Mon Oct 9 18:59:10 2006 New Revision: 24470 URL: http://svn.reactos.org/svn/reactos?rev=24470&view=rev Log: Fix compilation with GCC4 Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iomgr.c?… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iomgr.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iomgr.c Mon Oct 9 18:59:10 2006 @@ -502,7 +502,7 @@ /* Assign drive letters */ IoAssignDriveLetters(LoaderBlock, &NtBootPath, - RootString.Buffer, + (PUCHAR)RootString.Buffer, &RootString); /* Update system root */

1 0

[weiden] 24469: Strings should be const char *. Fixes compilation with GCC4
by weiden＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: weiden Date: Mon Oct 9 18:54:40 2006 New Revision: 24469 URL: http://svn.reactos.org/svn/reactos?rev=24469&view=rev Log: Strings should be const char *. Fixes compilation with GCC4 Modified: trunk/reactos/ntoskrnl/inbv/inbv.c Modified: trunk/reactos/ntoskrnl/inbv/inbv.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/inbv/inbv.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/inbv/inbv.c (original) +++ trunk/reactos/ntoskrnl/inbv/inbv.c Mon Oct 9 18:54:40 2006 @@ -31,7 +31,7 @@ static VOID (NTAPI *VidScreenToBufferBlt)(PUCHAR, ULONG, ULONG, ULONG, ULONG, ULONG); static VOID (NTAPI *VidBitBlt)(PUCHAR, ULONG, ULONG); static VOID (NTAPI *VidSolidColorFill)(ULONG, ULONG, ULONG, ULONG, ULONG); -static VOID (NTAPI *VidDisplayString)(PUCHAR); +static VOID (NTAPI *VidDisplayString)(PCSTR); static NTSTATUS (NTAPI *BootVidDisplayBootLogo)(PVOID); static VOID (NTAPI *BootVidUpdateProgress)(ULONG Progress); static VOID (NTAPI *BootVidFinalizeBootLogo)(VOID);

1 0

[weiden] 24468: Strings should be const char *. Fixes compilation with GCC4
by weiden＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: weiden Date: Mon Oct 9 18:43:16 2006 New Revision: 24468 URL: http://svn.reactos.org/svn/reactos?rev=24468&view=rev Log: Strings should be const char *. Fixes compilation with GCC4 Modified: trunk/reactos/drivers/base/bootvid/bootvid.h trunk/reactos/drivers/base/bootvid/vid.c trunk/reactos/drivers/base/bootvid/vid_vga.c trunk/reactos/drivers/base/bootvid/vid_vgatext.c trunk/reactos/drivers/base/bootvid/vid_xbox.c Modified: trunk/reactos/drivers/base/bootvid/bootvid.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/bootv… ============================================================================== --- trunk/reactos/drivers/base/bootvid/bootvid.h (original) +++ trunk/reactos/drivers/base/bootvid/bootvid.h Mon Oct 9 18:43:16 2006 @@ -39,7 +39,7 @@ VOID NTAPI VidScreenToBufferBlt(PUCHAR, ULONG, ULONG, ULONG, ULONG, ULONG); VOID NTAPI VidBitBlt(PUCHAR, ULONG, ULONG); VOID NTAPI VidSolidColorFill(ULONG, ULONG, ULONG, ULONG, ULONG); -VOID NTAPI VidDisplayString(PUCHAR); +VOID NTAPI VidDisplayString(PCSTR); typedef BOOLEAN (NTAPI *PVID_INITIALIZE)(BOOLEAN); typedef VOID (NTAPI *PVID_CLEAN_UP)(VOID); @@ -48,7 +48,7 @@ typedef VOID (NTAPI *PVID_SCREEN_TO_BUFFER_BLT)(PUCHAR, ULONG, ULONG, ULONG, ULONG, ULONG); typedef VOID (NTAPI *PVID_BITBLT)(PUCHAR, ULONG, ULONG); typedef VOID (NTAPI *PVID_SOLID_COLOR_FILL)(ULONG, ULONG, ULONG, ULONG, ULONG); -typedef VOID (NTAPI *PVID_DISPLAY_STRING)(PUCHAR); +typedef VOID (NTAPI *PVID_DISPLAY_STRING)(PCSTR); typedef struct _VID_FUNCTION_TABLE { Modified: trunk/reactos/drivers/base/bootvid/vid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/vid.c… ============================================================================== --- trunk/reactos/drivers/base/bootvid/vid.c (original) +++ trunk/reactos/drivers/base/bootvid/vid.c Mon Oct 9 18:43:16 2006 @@ -113,7 +113,7 @@ VOID NTAPI VidDisplayString( - IN PUCHAR String) + IN PCSTR String) { VidTable->DisplayString(String); } Modified: trunk/reactos/drivers/base/bootvid/vid_vga.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/vid_v… ============================================================================== --- trunk/reactos/drivers/base/bootvid/vid_vga.c (original) +++ trunk/reactos/drivers/base/bootvid/vid_vga.c Mon Oct 9 18:43:16 2006 @@ -495,7 +495,7 @@ static VOID NTAPI VidVgaDisplayString( - IN PUCHAR String) + IN PCSTR String) { } Modified: trunk/reactos/drivers/base/bootvid/vid_vgatext.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/vid_v… ============================================================================== --- trunk/reactos/drivers/base/bootvid/vid_vgatext.c (original) +++ trunk/reactos/drivers/base/bootvid/vid_vgatext.c Mon Oct 9 18:43:16 2006 @@ -179,9 +179,9 @@ static VOID NTAPI VidVgaTextDisplayString( - IN PUCHAR String) -{ - PCH pch; + IN PCSTR String) +{ + PCSTR pch; int offset; ULONG CursorX; ULONG CursorY; Modified: trunk/reactos/drivers/base/bootvid/vid_xbox.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/vid_x… ============================================================================== --- trunk/reactos/drivers/base/bootvid/vid_xbox.c (original) +++ trunk/reactos/drivers/base/bootvid/vid_xbox.c Mon Oct 9 18:43:16 2006 @@ -85,7 +85,7 @@ static VOID NTAPI VidXboxDisplayString( - IN PUCHAR String) + IN PCSTR String) { }

1 0

[mflyer] 24467: Change copyright to 1996-2006, because a) our earliest version records show 1996 b) we are now in 2006
by mflyer＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: mflyer Date: Mon Oct 9 16:37:03 2006 New Revision: 24467 URL: http://svn.reactos.org/svn/reactos?rev=24467&view=rev Log: Change copyright to 1996-2006, because a) our earliest version records show 1996 b) we are now in 2006 Modified: trunk/reactos/drivers/base/bootvid/bootimage.bmp Modified: trunk/reactos/drivers/base/bootvid/bootimage.bmp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/booti… ============================================================================== Binary files - no diff available.

1 0

[fireball] 24466: Fix mkhive compiling by adding _NTSYSTEM_ define. This is needed after Thomas' fixes to headers.
by fireball＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: fireball Date: Mon Oct 9 12:07:19 2006 New Revision: 24466 URL: http://svn.reactos.org/svn/reactos?rev=24466&view=rev Log: Fix mkhive compiling by adding _NTSYSTEM_ define. This is needed after Thomas' fixes to headers. Modified: trunk/reactos/lib/cmlib/cmlib.mak trunk/reactos/tools/mkhive/mkhive.mak Modified: trunk/reactos/lib/cmlib/cmlib.mak URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmlib.mak?rev=24… ============================================================================== --- trunk/reactos/lib/cmlib/cmlib.mak (original) +++ trunk/reactos/lib/cmlib/cmlib.mak Mon Oct 9 12:07:19 2006 @@ -31,7 +31,7 @@ $(subst $(CMLIB_BASE), $(CMLIB_INT), $(CMLIB_HOST_SOURCES:.c=.o)) CMLIB_HOST_CFLAGS = -O3 -Wall -Wwrite-strings -Wpointer-arith \ - -D_X86_ -D__i386__ -D_REACTOS_ -D_NTOSKRNL_\ + -D_X86_ -D__i386__ -D_REACTOS_ -D_NTOSKRNL_ -D_NTSYSTEM_ \ -DCMLIB_HOST -D_M_IX86 -I$(CMLIB_BASE) -Iinclude/reactos -Iinclude/psdk -Iinclude/ddk -Iinclude/crt \ -D__NO_CTYPE_INLINES Modified: trunk/reactos/tools/mkhive/mkhive.mak URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/mkhive.mak?re… ============================================================================== --- trunk/reactos/tools/mkhive/mkhive.mak (original) +++ trunk/reactos/tools/mkhive/mkhive.mak Mon Oct 9 12:07:19 2006 @@ -31,7 +31,7 @@ $(addprefix $(INTERMEDIATE_), $(MKHIVE_SOURCES:.c=.o)) MKHIVE_HOST_CFLAGS = -fshort-wchar $(xTOOLS_CFLAGS) -I$(INFLIB_BASE) -I$(CMLIB_BASE) \ - -D_NTOSKRNL_ \ + -D_NTOSKRNL_ -D_NTSYSTEM_ \ -Iinclude/reactos -Iinclude/ddk -Iinclude/ndk -Iinclude/psdk -Iinclude -Iinclude/crt -g3 MKHIVE_HOST_LFLAGS = $(xTOOLS_LFLAGS) -g3

1 0

[ion] 24465: - Some misc changes to fix some of the 250+ warnings in the MSVC build.
by ion＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: ion Date: Mon Oct 9 09:59:18 2006 New Revision: 24465 URL: http://svn.reactos.org/svn/reactos?rev=24465&view=rev Log: - Some misc changes to fix some of the 250+ warnings in the MSVC build. Modified: trunk/reactos/ntoskrnl/cm/registry.c trunk/reactos/ntoskrnl/ex/event.c trunk/reactos/ntoskrnl/ex/sem.c trunk/reactos/ntoskrnl/ex/time.c trunk/reactos/ntoskrnl/fs/filelock.c trunk/reactos/ntoskrnl/fs/mcb.c trunk/reactos/ntoskrnl/include/internal/ex.h trunk/reactos/ntoskrnl/include/ntoskrnl.h trunk/reactos/ntoskrnl/io/iomgr/bootlog.c trunk/reactos/ntoskrnl/io/iomgr/iomgr.c trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c trunk/reactos/ntoskrnl/ke/bug.c trunk/reactos/ntoskrnl/mm/i386/pfault.c trunk/reactos/ntoskrnl/mm/mminit.c trunk/reactos/ntoskrnl/ntoskrnl.def trunk/reactos/ntoskrnl/ps/job.c Modified: trunk/reactos/ntoskrnl/cm/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cm/registry.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/cm/registry.c (original) +++ trunk/reactos/ntoskrnl/cm/registry.c Mon Oct 9 09:59:18 2006 @@ -21,9 +21,7 @@ #include "cm.h" #if defined (ALLOC_PRAGMA) -#pragma alloc_text(INIT, CmInitHives) -#pragma alloc_text(INIT, CmInitializeRegistry) -#pragma alloc_text(INIT, CmInit2) +#pragma alloc_text(INIT, CmInitSystem1) #endif /* GLOBALS ******************************************************************/ Modified: trunk/reactos/ntoskrnl/ex/event.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/event.c?rev=24… ============================================================================== --- trunk/reactos/ntoskrnl/ex/event.c (original) +++ trunk/reactos/ntoskrnl/ex/event.c Mon Oct 9 09:59:18 2006 @@ -19,7 +19,7 @@ /* GLOBALS *******************************************************************/ -POBJECT_TYPE ExEventObjectType = NULL; +POBJECT_TYPE _ExEventObjectType = NULL; GENERIC_MAPPING ExpEventMapping = { Modified: trunk/reactos/ntoskrnl/ex/sem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sem.c?rev=2446… ============================================================================== --- trunk/reactos/ntoskrnl/ex/sem.c (original) +++ trunk/reactos/ntoskrnl/ex/sem.c Mon Oct 9 09:59:18 2006 @@ -14,12 +14,12 @@ #include <internal/debug.h> #if defined (ALLOC_PRAGMA) -#pragma alloc_text(INIT, ExpInitializeSemaphoreImplementation() +#pragma alloc_text(INIT, ExpInitializeSemaphoreImplementation) #endif /* GLOBALS ******************************************************************/ -POBJECT_TYPE ExSemaphoreObjectType; +POBJECT_TYPE _ExSemaphoreObjectType; GENERIC_MAPPING ExSemaphoreMapping = { Modified: trunk/reactos/ntoskrnl/ex/time.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/time.c?rev=244… ============================================================================== --- trunk/reactos/ntoskrnl/ex/time.c (original) +++ trunk/reactos/ntoskrnl/ex/time.c Mon Oct 9 09:59:18 2006 @@ -14,10 +14,6 @@ #include <internal/debug.h> #define TICKSPERMINUTE 600000000 - -#if defined (ALLOC_PRAGMA) -#pragma alloc_text(INIT, ExpInitTimeZoneInfo) -#endif /* GLOBALS ******************************************************************/ Modified: trunk/reactos/ntoskrnl/fs/filelock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fs/filelock.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/fs/filelock.c (original) +++ trunk/reactos/ntoskrnl/fs/filelock.c Mon Oct 9 09:59:18 2006 @@ -11,11 +11,6 @@ #include <ntoskrnl.h> #define NDEBUG #include <internal/debug.h> - -#if defined (ALLOC_PRAGMA) -#pragma alloc_text(INIT, FsRtlpInitFileLockingImplementation) -#endif - /* NOTE: Modified: trunk/reactos/ntoskrnl/fs/mcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fs/mcb.c?rev=2446… ============================================================================== --- trunk/reactos/ntoskrnl/fs/mcb.c (original) +++ trunk/reactos/ntoskrnl/fs/mcb.c Mon Oct 9 09:59:18 2006 @@ -312,9 +312,9 @@ IN ULONG SectorCount) { /* Call the large function */ - return FsRtlRemoveLargeMcbEntry(&Mcb->DummyFieldThatSizesThisStructureCorrectly, - (LONGLONG)Vbn, - (LONGLONG)SectorCount); + FsRtlRemoveLargeMcbEntry(&Mcb->DummyFieldThatSizesThisStructureCorrectly, + (LONGLONG)Vbn, + (LONGLONG)SectorCount); } Modified: trunk/reactos/ntoskrnl/include/internal/ex.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/ex.h (original) +++ trunk/reactos/ntoskrnl/include/internal/ex.h Mon Oct 9 09:59:18 2006 @@ -9,6 +9,7 @@ extern ULONG ExpTickCountMultiplier; extern ULONG ExpLastTimeZoneBias; extern POBJECT_TYPE ExEventPairObjectType; +extern POBJECT_TYPE _ExEventObjectType, _ExSemaphoreObjectType; extern ULONG NtBuildNumber; extern ULONG NtMajorVersion; extern ULONG NtMinorVersion; Modified: trunk/reactos/ntoskrnl/include/ntoskrnl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/ntoskrnl.… ============================================================================== --- trunk/reactos/ntoskrnl/include/ntoskrnl.h (original) +++ trunk/reactos/ntoskrnl/include/ntoskrnl.h Mon Oct 9 09:59:18 2006 @@ -62,6 +62,8 @@ // #define IoFileObjectType _IoFileObjectType #define PsThreadType _PsThreadType +#define ExEventObjectType _ExEventObjectType +#define ExSemaphoreObjectType _ExSemaphoreObjectType #define KdDebuggerEnabled _KdDebuggerEnabled #define KdDebuggerNotPresent _KdDebuggerNotPresent #define FsRtlLegalAnsiCharacterArray _FsRtlLegalAnsiCharacterArray Modified: trunk/reactos/ntoskrnl/io/iomgr/bootlog.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/bootlog.… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/bootlog.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/bootlog.c Mon Oct 9 09:59:18 2006 @@ -16,7 +16,7 @@ #if defined (ALLOC_PRAGMA) #pragma alloc_text(INIT, IopInitBootLog) -#pragma alloc_text(INIT, IopStartBootLog() +#pragma alloc_text(INIT, IopStartBootLog) #endif /* GLOBALS ******************************************************************/ Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iomgr.c?… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iomgr.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iomgr.c Mon Oct 9 09:59:18 2006 @@ -59,7 +59,7 @@ #pragma alloc_text(INIT, IoInitCancelHandling) #pragma alloc_text(INIT, IoInitShutdownNotification) #pragma alloc_text(INIT, IopInitLookasideLists) -#pragma alloc_text(INIT, IoInit) +#pragma alloc_text(INIT, IoInitSystem) #endif /* INIT FUNCTIONS ************************************************************/ Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.… ============================================================================== --- trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c (original) +++ trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c Mon Oct 9 09:59:18 2006 @@ -28,9 +28,6 @@ #if defined (ALLOC_PRAGMA) #pragma alloc_text(INIT, PnpInit) #pragma alloc_text(INIT, PnpInit2) -#pragma alloc_text(INIT, IopUpdateRootKey) -#pragma alloc_text(INIT, IopEnumerateDetectedDevices) -#pragma alloc_text(INIT, IopIsAcpiComputer) #endif typedef struct _INVALIDATE_DEVICE_RELATION_DATA @@ -41,7 +38,7 @@ NTSTATUS Status; } INVALIDATE_DEVICE_RELATION_DATA, *PINVALIDATE_DEVICE_RELATION_DATA; -static VOID CALLBACK +static VOID NTAPI IopInvalidateDeviceRelations( IN PDEVICE_OBJECT DeviceObject, IN PVOID InvalidateContext); @@ -2456,7 +2453,7 @@ * The call can be make synchronous by defining the Event field * of the INVALIDATE_DEVICE_RELATION_DATA structure */ -static VOID CALLBACK +static VOID NTAPI IopInvalidateDeviceRelations( IN PDEVICE_OBJECT DeviceObject, IN PVOID InvalidateContext) /* PINVALIDATE_DEVICE_RELATION_DATA */ @@ -2476,7 +2473,7 @@ NTSTATUS Status; ULONG i; - DPRINT("DeviceObject 0x%p, Type %d\n", DeviceObject, Type); + DPRINT("DeviceObject 0x%p\n", DeviceObject); DPRINT("Sending IRP_MN_QUERY_DEVICE_RELATIONS to device stack\n"); Modified: trunk/reactos/ntoskrnl/ke/bug.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/bug.c?rev=2446… ============================================================================== --- trunk/reactos/ntoskrnl/ke/bug.c (original) +++ trunk/reactos/ntoskrnl/ke/bug.c Mon Oct 9 09:59:18 2006 @@ -851,7 +851,7 @@ } /* Raise IRQL to HIGH_LEVEL */ - Ke386DisableInterrupts(); + _disable(); KeRaiseIrql(HIGH_LEVEL, &OldIrql); /* Unlock the Kernel Adress Space if we own it */ Modified: trunk/reactos/ntoskrnl/mm/i386/pfault.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/i386/pfault.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/i386/pfault.c (original) +++ trunk/reactos/ntoskrnl/mm/i386/pfault.c Mon Oct 9 09:59:18 2006 @@ -43,7 +43,7 @@ /* it's safe to enable interrupts after cr2 has been saved */ if (Tf->EFlags & (X86_EFLAGS_VM|X86_EFLAGS_IF)) { - Ke386EnableInterrupts(); + _enable(); } if (cr2 >= (ULONG_PTR)MmSystemRangeStart) Modified: trunk/reactos/ntoskrnl/mm/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mminit.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mminit.c (original) +++ trunk/reactos/ntoskrnl/mm/mminit.c Mon Oct 9 09:59:18 2006 @@ -19,6 +19,7 @@ /* * Compiler defined symbols */ +extern unsigned int _image_base__; extern unsigned int _text_start__; extern unsigned int _text_end__; @@ -158,7 +159,6 @@ 0, BoundaryAddressMultiple); - extern unsigned int _image_base__; BaseAddress = (PVOID)&_image_base__; Length = PAGE_ROUND_UP(((ULONG_PTR)&_text_end__)) - (ULONG_PTR)&_image_base__; ParamLength = ParamLength - Length; Modified: trunk/reactos/ntoskrnl/ntoskrnl.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl.def?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl.def (original) +++ trunk/reactos/ntoskrnl/ntoskrnl.def Mon Oct 9 09:59:18 2006 @@ -99,11 +99,11 @@ ExDeleteNPagedLookasideList@4 ExDeletePagedLookasideList@4 ExDeleteResourceLite@4 -ExDesktopObjectType DATA +ExDesktopObjectType ExDisableResourceBoostLite@4 ExEnumHandleTable@16 @ExEnterCriticalRegionAndAcquireFastMutexUnsafe@4 -ExEventObjectType DATA +ExEventObjectType=_ExEventObjectType ExExtendZone@12 ExFreePool@4 ExFreePoolWithTag@8 @@ -152,7 +152,7 @@ @ExReleaseFastMutexUnsafeAndLeaveCriticalRegion@4 ExReleaseResourceForThreadLite@8 @ExReleaseResourceLite@4 -ExSemaphoreObjectType DATA +ExSemaphoreObjectType=_ExSemaphoreObjectType ExSetResourceOwnerPointer@8 ExSetTimerResolution@8 ExSystemExceptionFilter@0 Modified: trunk/reactos/ntoskrnl/ps/job.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/job.c?rev=2446… ============================================================================== --- trunk/reactos/ntoskrnl/ps/job.c (original) +++ trunk/reactos/ntoskrnl/ps/job.c Mon Oct 9 09:59:18 2006 @@ -14,9 +14,6 @@ #define NDEBUG #include <internal/debug.h> -#if defined (ALLOC_PRAGMA) -#pragma alloc_text(INIT, PsInitJobManagment) -#endif /* GLOBALS *******************************************************************/

1 0

[ion] 24464: - Bootvid rewrite by Filip Navara (with some fixes by myself) - HAL DMA enhancements by Filip Navara. - CSRSS Console enhancements by Filip Navara. - Win32k Primitive Queue/Input/Painting/Focus enhancements by Filip Navara. - Other misc win32k/CSR bug fixes by Filip Navara. - The new bootvid code has some bugs, but try out a GUI Boot!
by ion＠svn.reactos.org 09 Oct '06

09 Oct '06

Author: ion Date: Mon Oct 9 08:00:34 2006 New Revision: 24464 URL: http://svn.reactos.org/svn/reactos?rev=24464&view=rev Log: - Bootvid rewrite by Filip Navara (with some fixes by myself) - HAL DMA enhancements by Filip Navara. - CSRSS Console enhancements by Filip Navara. - Win32k Primitive Queue/Input/Painting/Focus enhancements by Filip Navara. - Other misc win32k/CSR bug fixes by Filip Navara. - The new bootvid code has some bugs, but try out a GUI Boot! Added: trunk/reactos/drivers/base/bootvid/bar.bmp (with props) trunk/reactos/drivers/base/bootvid/bootvid.def trunk/reactos/drivers/base/bootvid/vid.c trunk/reactos/drivers/base/bootvid/vid_vga.c trunk/reactos/drivers/base/bootvid/vid_vgatext.c trunk/reactos/drivers/base/bootvid/vid_xbox.c Modified: trunk/reactos/base/setup/usetup/bootsup.c trunk/reactos/boot/bootdata/txtsetup.sif trunk/reactos/drivers/base/blue/blue.c trunk/reactos/drivers/base/bootvid/bootimage.bmp trunk/reactos/drivers/base/bootvid/bootvid.c trunk/reactos/drivers/base/bootvid/bootvid.h trunk/reactos/drivers/base/bootvid/bootvid.rbuild trunk/reactos/drivers/base/bootvid/bootvid.rc trunk/reactos/drivers/base/bootvid/ntbootvid.h trunk/reactos/drivers/base/bootvid/pixelsup_i386.S trunk/reactos/drivers/base/bootvid/resource.h trunk/reactos/drivers/video/videoprt/dispatch.c trunk/reactos/hal/hal/hal.def trunk/reactos/hal/halx86/generic/display.c trunk/reactos/hal/halx86/generic/dma.c trunk/reactos/hal/halx86/generic/halinit.c trunk/reactos/hal/halx86/include/halp.h trunk/reactos/ntoskrnl/ex/init.c trunk/reactos/ntoskrnl/ex/power.c trunk/reactos/ntoskrnl/inbv/inbv.c trunk/reactos/ntoskrnl/include/internal/inbv.h trunk/reactos/ntoskrnl/kdbg/kdb.c trunk/reactos/ntoskrnl/ke/bug.c trunk/reactos/subsystems/win32/csrss/win32csr/conio.c trunk/reactos/subsystems/win32/csrss/win32csr/dllmain.c trunk/reactos/subsystems/win32/csrss/win32csr/tuiconsole.c trunk/reactos/subsystems/win32/win32k/include/painting.h trunk/reactos/subsystems/win32/win32k/include/userfuncs.h trunk/reactos/subsystems/win32/win32k/ntuser/focus.c trunk/reactos/subsystems/win32/win32k/ntuser/input.c trunk/reactos/subsystems/win32/win32k/ntuser/misc.c trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c trunk/reactos/subsystems/win32/win32k/ntuser/painting.c trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c trunk/reactos/subsystems/win32/win32k/objects/dc.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/base/setup/usetup/bootsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/bootsup.… Modified: trunk/reactos/boot/bootdata/txtsetup.sif URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif… Modified: trunk/reactos/drivers/base/blue/blue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/blue/blue.c?r… Added: trunk/reactos/drivers/base/bootvid/bar.bmp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/bar.b… Modified: trunk/reactos/drivers/base/bootvid/bootimage.bmp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/booti… Modified: trunk/reactos/drivers/base/bootvid/bootvid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/bootv… Added: trunk/reactos/drivers/base/bootvid/bootvid.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/bootv… Modified: trunk/reactos/drivers/base/bootvid/bootvid.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/bootv… Modified: trunk/reactos/drivers/base/bootvid/bootvid.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/bootv… Modified: trunk/reactos/drivers/base/bootvid/bootvid.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/bootv… Modified: trunk/reactos/drivers/base/bootvid/ntbootvid.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/ntboo… Modified: trunk/reactos/drivers/base/bootvid/pixelsup_i386.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/pixel… Modified: trunk/reactos/drivers/base/bootvid/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/resou… Added: trunk/reactos/drivers/base/bootvid/vid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/vid.c… Added: trunk/reactos/drivers/base/bootvid/vid_vga.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/vid_v… Added: trunk/reactos/drivers/base/bootvid/vid_vgatext.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/vid_v… Added: trunk/reactos/drivers/base/bootvid/vid_xbox.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/vid_x… Modified: trunk/reactos/drivers/video/videoprt/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/videoprt/dis… Modified: trunk/reactos/hal/hal/hal.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/hal/hal.def?rev=24464&… Modified: trunk/reactos/hal/halx86/generic/display.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/display… Modified: trunk/reactos/hal/halx86/generic/dma.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/dma.c?r… Modified: trunk/reactos/hal/halx86/generic/halinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/halinit… Modified: trunk/reactos/hal/halx86/include/halp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/include/halp.h?… Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=244… Modified: trunk/reactos/ntoskrnl/ex/power.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/power.c?rev=24… Modified: trunk/reactos/ntoskrnl/inbv/inbv.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/inbv/inbv.c?rev=2… Modified: trunk/reactos/ntoskrnl/include/internal/inbv.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… Modified: trunk/reactos/ntoskrnl/kdbg/kdb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb.c?rev=24… Modified: trunk/reactos/ntoskrnl/ke/bug.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/bug.c?rev=2446… Modified: trunk/reactos/subsystems/win32/csrss/win32csr/conio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/win… Modified: trunk/reactos/subsystems/win32/csrss/win32csr/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/win… Modified: trunk/reactos/subsystems/win32/csrss/win32csr/tuiconsole.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/win… Modified: trunk/reactos/subsystems/win32/win32k/include/painting.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… Modified: trunk/reactos/subsystems/win32/win32k/include/userfuncs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… Modified: trunk/reactos/subsystems/win32/win32k/ntuser/focus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… Modified: trunk/reactos/subsystems/win32/win32k/ntuser/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… Modified: trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… Modified: trunk/reactos/subsystems/win32/win32k/ntuser/painting.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winsta.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… Modified: trunk/reactos/subsystems/win32/win32k/objects/dc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…

1 0

← Newer
1
...
19
20
21
22
23
24
25
...
36
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2006