Ros-diffs May 2006

ros-diffs@reactos.org

19 participants
377 discussions

[hpoussin] 22076: Small fixes by w3seek

by hpoussin＠svn.reactos.org

Author: hpoussin Date: Sat May 27 18:04:08 2006 New Revision: 22076 URL: http://svn.reactos.ru/svn/reactos?rev=22076&view=rev Log: Small fixes by w3seek Modified: trunk/reactos/dll/win32/newdev/wizard.c Modified: trunk/reactos/dll/win32/newdev/wizard.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/newdev/wizard.c?r… ============================================================================== --- trunk/reactos/dll/win32/newdev/wizard.c (original) +++ trunk/reactos/dll/win32/newdev/wizard.c Sat May 27 18:04:08 2006 @@ -346,7 +346,7 @@ LPCTSTR Path; LONG rc; - ComboBox_ResetContent(hwndCombo); + (void)ComboBox_ResetContent(hwndCombo); /* RegGetValue would have been better... */ rc = RegOpenKeyEx( @@ -395,8 +395,8 @@ /* Populate combo box */ for (Path = Buffer; *Path; Path += _tcslen(Path)) - ComboBox_AddString(hwndCombo, Path); - ComboBox_SetCurSel(hwndCombo, 0); + (void)ComboBox_AddString(hwndCombo, Path); + (void)ComboBox_SetCurSel(hwndCombo, 0); cleanup: if (hKey != NULL) @@ -788,7 +788,7 @@ case PSN_WIZBACK: /* Handle a Back button click, if necessary */ - PropSheet_SetCurSelByID(GetParent(hwndDlg), IDD_WELCOMEPAGE); + PropSheet_SetCurSelByID(GetParent(hwndDlg), IDD_CHSOURCE); return TRUE; case PSN_WIZFINISH: @@ -990,7 +990,7 @@ psh.dwFlags = PSH_WIZARD97 | PSH_WATERMARK | PSH_HEADER; psh.hInstance = hDllInstance; psh.hwndParent = hwndParent; - psh.nPages = 7; + psh.nPages = 6; psh.nStartPage = startPage; psh.phpage = ahpsp; psh.pszbmWatermark = MAKEINTRESOURCE(IDB_WATERMARK);

18 years, 3 months

[greatlrd] 22075: sorry for breaking the build, I did put in wrong version I should have retested it

by greatlrd＠svn.reactos.org

Author: greatlrd Date: Sat May 27 17:05:24 2006 New Revision: 22075 URL: http://svn.reactos.ru/svn/reactos?rev=22075&view=rev Log: sorry for breaking the build, I did put in wrong version I should have retested it Modified: trunk/reactos/lib/crt/misc/environ.c Modified: trunk/reactos/lib/crt/misc/environ.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/lib/crt/misc/environ.c?rev=… ============================================================================== --- trunk/reactos/lib/crt/misc/environ.c (original) +++ trunk/reactos/lib/crt/misc/environ.c Sat May 27 17:05:24 2006 @@ -245,11 +245,11 @@ memcpy(name, option, (epos - option) * sizeof(wchar_t)); name[epos - option] = 0; - if (*name == 0) || (wcschr(option, L'=') !=NULL) + if ((*name == 0) || (wcschr(option, L'=') !=NULL)) { /* fixme check see if name contain any space or so so we really locate first char in name and compare - it with equal + it with equal */ free(name); return -1;

18 years, 3 months

[hpoussin] 22074: Fix search of driver on removable media

by hpoussin＠svn.reactos.org

Author: hpoussin Date: Sat May 27 17:03:04 2006 New Revision: 22074 URL: http://svn.reactos.ru/svn/reactos?rev=22074&view=rev Log: Fix search of driver on removable media Modified: trunk/reactos/dll/win32/newdev/newdev.c Modified: trunk/reactos/dll/win32/newdev/newdev.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/newdev/newdev.c?r… ============================================================================== --- trunk/reactos/dll/win32/newdev/newdev.c (original) +++ trunk/reactos/dll/win32/newdev/newdev.c Sat May 27 17:03:04 2006 @@ -309,7 +309,6 @@ return TRUE; } - static BOOL IsDots(IN LPCTSTR str) { @@ -373,7 +372,10 @@ _tcscpy(FullPath, DirPath); _tcscat(FullPath, FileName); if (SearchDriverRecursive(DevInstData, FullPath)) + { + retval = TRUE; break; + } } else {

18 years, 3 months

[greatlrd] 22073: Bugfix environ so it does not allown = in environ name not even as frist char

by greatlrd＠svn.reactos.org

Author: greatlrd Date: Sat May 27 17:00:39 2006 New Revision: 22073 URL: http://svn.reactos.ru/svn/reactos?rev=22073&view=rev Log: Bugfix environ so it does not allown = in environ name not even as frist char Modified: trunk/reactos/lib/crt/misc/environ.c Modified: trunk/reactos/lib/crt/misc/environ.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/lib/crt/misc/environ.c?rev=… ============================================================================== --- trunk/reactos/lib/crt/misc/environ.c (original) +++ trunk/reactos/lib/crt/misc/environ.c Sat May 27 17:00:39 2006 @@ -222,6 +222,7 @@ if (option == NULL || (epos = wcschr(option, L'=')) == NULL) return -1; + remove = (epos[1] == 0); /* Duplicate environment if needed. */ @@ -244,6 +245,15 @@ memcpy(name, option, (epos - option) * sizeof(wchar_t)); name[epos - option] = 0; + if (*name == 0) || (wcschr(option, L'=') !=NULL) + { + /* fixme check see if name contain any space or so + so we really locate first char in name and compare + it with equal + */ + free(name); + return -1; + } /* Find the option we're trying to modify. */ for (index = 0, wenvptr = _wenviron; *wenvptr != NULL; wenvptr++, index++) {

18 years, 3 months

[greatlrd] 22072: [AUDIT] after looking through code no signs of reverse engineering were found.

by greatlrd＠svn.reactos.org

Author: greatlrd Date: Sat May 27 16:59:10 2006 New Revision: 22072 URL: http://svn.reactos.ru/svn/reactos?rev=22072&view=rev Log: [AUDIT] after looking through code no signs of reverse engineering were found. Modified: trunk/reactos/lib/crt/misc/environ.c (props changed) Propchange: trunk/reactos/lib/crt/misc/environ.c ------------------------------------------------------------------------------ --- svn:needs-lock (original) +++ svn:needs-lock (removed) @@ -1,1 +1,0 @@ -*

18 years, 3 months

[greatlrd] 22071: [AUDIT] after looking through code no signs of reverse engineering were found.

by greatlrd＠svn.reactos.org

Author: greatlrd Date: Sat May 27 16:20:10 2006 New Revision: 22071 URL: http://svn.reactos.ru/svn/reactos?rev=22071&view=rev Log: [AUDIT] after looking through code no signs of reverse engineering were found. Modified: trunk/reactos/lib/crt/stdlib/putenv.c (props changed) Propchange: trunk/reactos/lib/crt/stdlib/putenv.c ------------------------------------------------------------------------------ --- svn:needs-lock (original) +++ svn:needs-lock (removed) @@ -1,1 +1,0 @@ -*

18 years, 3 months

[greatlrd] 22070: replacing _swab with wine cvs 2006-05-11 version, this will take care of our problem with overlapped memory problem with swab, and this make also two more wine test pass in wine msvcrt test. 100% pass okay now with wine msvcrt string test.

by greatlrd＠svn.reactos.org

Author: greatlrd Date: Sat May 27 15:37:44 2006 New Revision: 22070 URL: http://svn.reactos.ru/svn/reactos?rev=22070&view=rev Log: replacing _swab with wine cvs 2006-05-11 version, this will take care of our problem with overlapped memory problem with swab, and this make also two more wine test pass in wine msvcrt test. 100% pass okay now with wine msvcrt string test. Modified: trunk/reactos/lib/crt/stdlib/swab.c Modified: trunk/reactos/lib/crt/stdlib/swab.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/lib/crt/stdlib/swab.c?rev=2… ============================================================================== --- trunk/reactos/lib/crt/stdlib/swab.c (original) +++ trunk/reactos/lib/crt/stdlib/swab.c Sat May 27 15:37:44 2006 @@ -12,17 +12,23 @@ /* * @implemented + * + * copy this swab from wine cvs 2006-05-24 */ -void _swab (const char* caFrom, char* caTo, size_t sizeToCopy) +void _swab (const char * src, char * dst, size_t sizeToCopy + ) + { - if (sizeToCopy > 1) + if (sizeToCopy > 1) { - sizeToCopy = sizeToCopy >> 1; + sizeToCopy = (unsigned)sizeToCopy >> 1; while (sizeToCopy--) { - *caTo++ = caFrom[1]; - *caTo++ = *caFrom++; - caFrom++; + char s0 = src[0]; + char s1 = src[1]; + *dst++ = s1; + *dst++ = s0; + src = src + 2; } } }

18 years, 3 months

[greatlrd] 22069: [AUDIT] after looking through code no signs of reverse engineering were found. This swap can not handling overlapped of memory, replace of this will follow in next commit.

by greatlrd＠svn.reactos.org

Author: greatlrd Date: Sat May 27 14:55:35 2006 New Revision: 22069 URL: http://svn.reactos.ru/svn/reactos?rev=22069&view=rev Log: [AUDIT] after looking through code no signs of reverse engineering were found. This swap can not handling overlapped of memory, replace of this will follow in next commit. Modified: trunk/reactos/lib/crt/stdlib/swab.c (props changed) Propchange: trunk/reactos/lib/crt/stdlib/swab.c ------------------------------------------------------------------------------ --- svn:needs-lock (original) +++ svn:needs-lock (removed) @@ -1,1 +1,0 @@ -*

18 years, 3 months

[gedmurphy] 22068: - fixes the definitions of PostQueuedCompletionStatus() and RaiseException() - adds the definitions of AddAccessAllowedObjectAce(), AddAccessDeniedObjectAce() and AddAuditAccessObjectAce() to w32api - prototypes in line with previous r22066 mods - fixes bug 1473

by gedmurphy＠svn.reactos.org

Author: gedmurphy Date: Sat May 27 13:18:10 2006 New Revision: 22068 URL: http://svn.reactos.ru/svn/reactos?rev=22068&view=rev Log: - fixes the definitions of PostQueuedCompletionStatus() and RaiseException() - adds the definitions of AddAccessAllowedObjectAce(), AddAccessDeniedObjectAce() and AddAuditAccessObjectAce() to w32api - prototypes in line with previous r22066 mods - fixes bug 1473 Modified: trunk/reactos/dll/win32/kernel32/except/except.c trunk/reactos/dll/win32/kernel32/file/iocompl.c Modified: trunk/reactos/dll/win32/kernel32/except/except.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/kernel32/except/e… ============================================================================== --- trunk/reactos/dll/win32/kernel32/except/except.c (original) +++ trunk/reactos/dll/win32/kernel32/except/except.c Sat May 27 13:18:10 2006 @@ -278,7 +278,7 @@ DWORD dwExceptionCode, DWORD dwExceptionFlags, DWORD nNumberOfArguments, - CONST DWORD * lpArguments OPTIONAL + CONST ULONG_PTR * lpArguments OPTIONAL ) { EXCEPTION_RECORD ExceptionRecord; Modified: trunk/reactos/dll/win32/kernel32/file/iocompl.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/kernel32/file/ioc… ============================================================================== --- trunk/reactos/dll/win32/kernel32/file/iocompl.c (original) +++ trunk/reactos/dll/win32/kernel32/file/iocompl.c Sat May 27 13:18:10 2006 @@ -146,7 +146,7 @@ PostQueuedCompletionStatus( HANDLE CompletionHandle, DWORD dwNumberOfBytesTransferred, - DWORD dwCompletionKey, + ULONG_PTR dwCompletionKey, LPOVERLAPPED lpOverlapped ) {

18 years, 3 months

[gedmurphy] 22067: [AUDIT] kernel32 - except.c, iocompl.c most of the code is from Wine. All non wine specific functions are documented on MSDN

by gedmurphy＠svn.reactos.org

Author: gedmurphy Date: Sat May 27 13:15:33 2006 New Revision: 22067 URL: http://svn.reactos.ru/svn/reactos?rev=22067&view=rev Log: [AUDIT] kernel32 - except.c, iocompl.c most of the code is from Wine. All non wine specific functions are documented on MSDN Modified: trunk/reactos/dll/win32/kernel32/except/except.c (props changed) trunk/reactos/dll/win32/kernel32/file/iocompl.c (props changed) Propchange: trunk/reactos/dll/win32/kernel32/except/except.c ------------------------------------------------------------------------------ --- svn:needs-lock (original) +++ svn:needs-lock (removed) @@ -1,1 +1,0 @@ -* Propchange: trunk/reactos/dll/win32/kernel32/file/iocompl.c ------------------------------------------------------------------------------ --- svn:needs-lock (original) +++ svn:needs-lock (removed) @@ -1,1 +1,0 @@ -*

18 years, 3 months

← Newer
1
...
4
5
6
7
8
9
10
...
38
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs May 2006