Ros-diffs June 2006

ros-diffs@reactos.org
  • 19 participants
  • 595 discussions

[ion] 22653: - Fix all the failures in the RTLSTR Wine test by merging our old rtl string routines with Wine's. We now pass all 2300 something tests.
by ion@svn.reactos.org
18 years, 6 months

[ion] 22652: - Catch illegal call to Ob functions when ObjectAttributes == NULL and return distinguished status code for this situation (STATUS_INVALID_PARAMETER), instead of failing due to access violation. - Create the BNO Global and Local symbolic links in kernel32. - We pass all the Ob+Native tests in ntdll_winetest om now (we fail some named pipe ones, but I have no idea why WINE calls them "Object Manager" related...)
by ion@svn.reactos.org
18 years, 6 months

[ion] 22651: - Fix another critical bug in ObInsertObject: don't overwrite the lookup status with the handle creation status. If the lookup returned something like OBJECT_NAME_EXISTS (which is a success + warning), we don't want to overwrite it with ObpCreateHandle's STATUS_SUCCESS. This should fix a large number of regressions (and also fixes many WINE ntdll "om" tests). - We also now correctly dereference the object in ObInsertObject, which should reduce one source of leaks (But there is still
by ion@svn.reactos.org
18 years, 6 months

[ion] 22650: - ObpCreateUnnamedHandle/ObpCreateHandle => Reference the object before calling ExCreateHandle. - Fix two critical bugs in ObInsertObject: We were creating a handle for the wrong object (in ObInsertObject) and we were not passing the ReferencedObject parameter to ObpCreateHandle, so that object was never being returned properly to the caller. - ObfDereferenceObject shouldn't check for the OB_FLAG_PERMANENT flag, or else it would never be possible to kill permanent objects while in k
by ion@svn.reactos.org
18 years, 6 months

[ion] 22649: - Lesson One: Don't revert commits because your eyes are inventing the word "copyright". I tried really hard, I really did, but I could not find even the word "copy", much less "copyright". - Lesson Two: What do you know! En and De.rc actually *are* our files, not James Brown's (his is sol.rc, which hasn't been altered with a ROS Header). - Lesson Three: It is official (voted) ROS Policy that all ROS files have a header. Reverting this header violated it.
by ion@svn.reactos.org
18 years, 6 months

[gedmurphy] 22648: You can't really claim copyright for translating a resource file. Secondly, it's not even our code to put headers in. It's James Browns from catch22.net
by gedmurphy@svn.reactos.org
18 years, 6 months

[ion] 22647: - Same fixes for LocalAlloc/LocalReAlloc - We now pass all 278+49 WINE Regression Tests related to Heap/Memory.
by ion@svn.reactos.org
18 years, 6 months

[ion] 22646: - Fix a typo in a comparison (& vs &&) which was breaking GlobalReAlloc in some cases. - Fix a missing | (OR) in GlobalAlloc which created an invalid handle if the first allocation was of size 0.
by ion@svn.reactos.org
18 years, 6 months

[janderwald] 22645: add missing includes
by janderwald@svn.reactos.org
18 years, 6 months

[janderwald] 22644: add missing include
by janderwald@svn.reactos.org
18 years, 6 months
Results per page: