Ros-diffs August 2006

ros-diffs@reactos.org

19 participants
447 discussions

[fireball] 23729: Add testsets to building process too, so that they don't bitrot (compile time is neglectable)
by fireball＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: fireball Date: Sun Aug 27 01:11:08 2006 New Revision: 23729 URL: http://svn.reactos.org/svn/reactos?rev=23729&view=rev Log: Add testsets to building process too, so that they don't bitrot (compile time is neglectable) Modified: trunk/reactos/base/applications/applications.rbuild Modified: trunk/reactos/base/applications/applications.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/applicat… ============================================================================== --- trunk/reactos/base/applications/applications.rbuild (original) +++ trunk/reactos/base/applications/applications.rbuild Sun Aug 27 01:11:08 2006 @@ -67,6 +67,9 @@ <directory name="taskmgr"> <xi:include href="taskmgr/taskmgr.rbuild" /> </directory> +<directory name="testsets"> + <xi:include href="testsets/testsets.rbuild" /> +</directory> <directory name="winefile"> <xi:include href="winefile/winefile.rbuild" /> </directory>

1 0

[fireball] 23728: Don't crash during disconnection if a device doesn't have a driver
by fireball＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: fireball Date: Sun Aug 27 01:09:11 2006 New Revision: 23728 URL: http://svn.reactos.org/svn/reactos?rev=23728&view=rev Log: Don't crash during disconnection if a device doesn't have a driver Modified: trunk/reactos/drivers/usb/nt4compat/usbdriver/gendrv.c Modified: trunk/reactos/drivers/usb/nt4compat/usbdriver/gendrv.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/nt4compat/usbd… ============================================================================== --- trunk/reactos/drivers/usb/nt4compat/usbdriver/gendrv.c (original) +++ trunk/reactos/drivers/usb/nt4compat/usbdriver/gendrv.c Sun Aug 27 01:09:11 2006 @@ -922,6 +922,14 @@ pdrvr = pdev->dev_driver; dev_obj = pdev->dev_obj; } + + if (dev_obj == NULL) + { + // it means no driver was found for the device and thus no device object created + // we just do nothing here + return TRUE; + } + pdrvr_ext = (PGENDRV_DRVR_EXTENSION) pdrvr->driver_ext; pdev_ext = (PGENDRV_DEVICE_EXTENSION) dev_obj->DeviceExtension; }

1 0

[fireball] 23727: Dmitry Philippov: - Implement RTL_QUERY_REGISTRY_DELETE (which simply deletes the key after querying) - Fix REG_MULTI_SZ to actually walk through the whole data, not stopping at the first encountered 0 character. This makes the "ntdll_winetest.exe reg" test behave exactly as on Windows XP
by fireball＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: fireball Date: Sun Aug 27 00:45:30 2006 New Revision: 23727 URL: http://svn.reactos.org/svn/reactos?rev=23727&view=rev Log: Dmitry Philippov: - Implement RTL_QUERY_REGISTRY_DELETE (which simply deletes the key after querying) - Fix REG_MULTI_SZ to actually walk through the whole data, not stopping at the first encountered 0 character. This makes the "ntdll_winetest.exe reg" test behave exactly as on Windows XP Modified: trunk/reactos/lib/rtl/registry.c Modified: trunk/reactos/lib/rtl/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/registry.c?rev=237… ============================================================================== --- trunk/reactos/lib/rtl/registry.c (original) +++ trunk/reactos/lib/rtl/registry.c Sun Aug 27 00:45:30 2006 @@ -9,7 +9,6 @@ /* * TODO: * - finish RtlQueryRegistryValues() - * - support RTL_QUERY_REGISTRY_DELETE */ /* INCLUDES *****************************************************************/ @@ -784,7 +783,7 @@ if (QueryEntry->Flags & RTL_QUERY_REGISTRY_DELETE) { - DPRINT1("FIXME: Delete value: %S\n", QueryEntry->Name); + Status = ZwDeleteValueKey(CurrentKeyHandle, &KeyName); } @@ -828,8 +827,9 @@ !(QueryEntry->Flags & RTL_QUERY_REGISTRY_NOEXPAND)) { DPRINT("Expand REG_MULTI_SZ type\n"); + ULONG DataSize = 0; StringPtr = (PWSTR)ValueInfo->Data; - while (*StringPtr != 0) + while (DataSize < (ValueInfo->DataLength-2)) { StringLen = (wcslen(StringPtr) + 1) * sizeof(WCHAR); Status = QueryEntry->QueryRoutine(QueryEntry->Name, @@ -841,6 +841,7 @@ if(!NT_SUCCESS(Status)) break; StringPtr = (PWSTR)((PUCHAR)StringPtr + StringLen); + DataSize += StringLen; } } else if ((ValueInfo->Type == REG_EXPAND_SZ) && @@ -889,8 +890,7 @@ if (QueryEntry->Flags & RTL_QUERY_REGISTRY_DELETE) { - DPRINT1("FIXME: Delete value: %S\n", QueryEntry->Name); - + Status = ZwDeleteValueKey(CurrentKeyHandle, &KeyName); } RtlpFreeMemory(ValueInfo, TAG_RTLREGISTRY);

1 0

[greatlrd] 23726: fix a typo
by greatlrd＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: greatlrd Date: Sat Aug 26 23:44:47 2006 New Revision: 23726 URL: http://svn.reactos.org/svn/reactos?rev=23726&view=rev Log: fix a typo Modified: trunk/reactos/boot/bootdata/txtsetup.sif Modified: trunk/reactos/boot/bootdata/txtsetup.sif URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif… ============================================================================== --- trunk/reactos/boot/bootdata/txtsetup.sif (original) +++ trunk/reactos/boot/bootdata/txtsetup.sif Sat Aug 26 23:44:47 2006 @@ -70,13 +70,13 @@ vga = "VGA Display (640x480x8)",,Vga,640,480,8 vbe_640x480x8 = "VESA Display (640x480x8)",,VBE,640,480,8 vbe_640x480x16 = "VESA Display (640x480x16)",,VBE,640,480,16 -vbe_640x480x32 = "VESA Display (640x480x16)",,VBE,640,480,32 +vbe_640x480x32 = "VESA Display (640x480x32)",,VBE,640,480,32 vbe_800x600x8 = "VESA Display (800x600x8)",,VBE,800,600,8 vbe = "VESA Display (800x600x16)",,VBE,800,600,16 -vbe_800x600x32 = "VESA Display (800x600x8)",,VBE,800,600,32 +vbe_800x600x32 = "VESA Display (800x600x32)",,VBE,800,600,32 vbe_1024x768x8 = "VESA Display (1024x768x8)",,VBE,1024,768,8 vbe_1024x768x16 = "VESA Display (1024x768x16)",,VBE,1024,768,16 -vbe_1024x768x32 = "VESA Display (1024x768x16)",,VBE,1024,768,32 +vbe_1024x768x32 = "VESA Display (1024x768x32)",,VBE,1024,768,32

1 0

[greatlrd] 23725: adding 640x480x32, 800x600x32, 1024x768x32 select for vbe. accoding to VBE 2.0 spec this mode shall always be while for graphic card with vbe 2.0 or higher.
by greatlrd＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: greatlrd Date: Sat Aug 26 23:40:24 2006 New Revision: 23725 URL: http://svn.reactos.org/svn/reactos?rev=23725&view=rev Log: adding 640x480x32, 800x600x32, 1024x768x32 select for vbe. accoding to VBE 2.0 spec this mode shall always be while for graphic card with vbe 2.0 or higher. Modified: trunk/reactos/boot/bootdata/txtsetup.sif Modified: trunk/reactos/boot/bootdata/txtsetup.sif URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif… ============================================================================== --- trunk/reactos/boot/bootdata/txtsetup.sif (original) +++ trunk/reactos/boot/bootdata/txtsetup.sif Sat Aug 26 23:40:24 2006 @@ -70,10 +70,16 @@ vga = "VGA Display (640x480x8)",,Vga,640,480,8 vbe_640x480x8 = "VESA Display (640x480x8)",,VBE,640,480,8 vbe_640x480x16 = "VESA Display (640x480x16)",,VBE,640,480,16 +vbe_640x480x32 = "VESA Display (640x480x16)",,VBE,640,480,32 vbe_800x600x8 = "VESA Display (800x600x8)",,VBE,800,600,8 vbe = "VESA Display (800x600x16)",,VBE,800,600,16 +vbe_800x600x32 = "VESA Display (800x600x8)",,VBE,800,600,32 vbe_1024x768x8 = "VESA Display (1024x768x8)",,VBE,1024,768,8 vbe_1024x768x16 = "VESA Display (1024x768x16)",,VBE,1024,768,16 +vbe_1024x768x32 = "VESA Display (1024x768x16)",,VBE,1024,768,32 + + + [Map.Display]

1 0

[frik85] 23724: add samba-tng to the packmgr repo
by frik85＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: frik85 Date: Sat Aug 26 22:43:44 2006 New Revision: 23724 URL: http://svn.reactos.org/svn/reactos?rev=23724&view=rev Log: add samba-tng to the packmgr repo Added: trunk/rosapps/packmgr/tree/samba-tng.inst.rps trunk/rosapps/packmgr/tree/samba-tng.xml Modified: trunk/rosapps/packmgr/tree/tree_bare.xml Added: trunk/rosapps/packmgr/tree/samba-tng.inst.rps URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/packmgr/tree/samba-tng.ins… ============================================================================== --- trunk/rosapps/packmgr/tree/samba-tng.inst.rps (added) +++ trunk/rosapps/packmgr/tree/samba-tng.inst.rps Sat Aug 26 22:43:44 2006 @@ -1,0 +1,9 @@ +Sub Main + ' ToDo: Choose from different mirrors + download "http://svn.reactos.org/packages/samba-tng.exe", "samba-tng.exe" +End Sub + +Sub After + shell samba-tng.exe + ' ToDo: Delete samba-tng.exe +End Sub Added: trunk/rosapps/packmgr/tree/samba-tng.xml URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/packmgr/tree/samba-tng.xml… ============================================================================== --- trunk/rosapps/packmgr/tree/samba-tng.xml (added) +++ trunk/rosapps/packmgr/tree/samba-tng.xml Sat Aug 26 22:43:44 2006 @@ -1,0 +1,7 @@ +<package> + <name>Samba-TNG</name> + <version>snapshot</version> + <description>The tiny, fast and portable CIFS-Suite.</description> + <scripts inst="samba-tng.inst.rps"/> +</package> + Modified: trunk/rosapps/packmgr/tree/tree_bare.xml URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/packmgr/tree/tree_bare.xml… ============================================================================== --- trunk/rosapps/packmgr/tree/tree_bare.xml (original) +++ trunk/rosapps/packmgr/tree/tree_bare.xml Sat Aug 26 22:43:44 2006 @@ -7,6 +7,7 @@     <node name="Putty" file="putty.xml"/> + <node name="Samba-TNG" file="samba-tng.xml"/> <node name="TuxPaint" file="tuxpaint.xml"/>   </tree>

1 0

[ion] 23723: - Even though in assembly we return the BOOLEAN in all of EAX, HalBeginSystemInterrupt should, in theory, only use AL and we shouldn't make assumptions about any other bits. So chang ethe code to or al, al, instead of or eax, eax.
by ion＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: ion Date: Sat Aug 26 20:23:59 2006 New Revision: 23723 URL: http://svn.reactos.org/svn/reactos?rev=23723&view=rev Log: - Even though in assembly we return the BOOLEAN in all of EAX, HalBeginSystemInterrupt should, in theory, only use AL and we shouldn't make assumptions about any other bits. So chang ethe code to or al, al, instead of or eax, eax. Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/trap.s?re… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/trap.s (original) +++ trunk/reactos/ntoskrnl/ke/i386/trap.s Sat Aug 26 20:23:59 2006 @@ -1326,7 +1326,7 @@ call _HalBeginSystemInterrupt@12 /* Check if it was spurious or not */ - or eax, eax + or al, al jnz Handled /* Spurious, ignore it */ @@ -1407,7 +1407,7 @@ call _HalBeginSystemInterrupt@12 /* Check if it was handled */ - or eax, eax + or al, al jz SpuriousInt /* Call the 2nd-level handler */ @@ -1444,7 +1444,7 @@ call _HalBeginSystemInterrupt@12 /* Check if it was handled */ - or eax, eax + or al, al jz SpuriousInt /* Acquire the lock */

1 0

[ion] 23722: - Remove useless stack operations in KiInterruptDispatch that I used for debugging.
by ion＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: ion Date: Sat Aug 26 20:07:31 2006 New Revision: 23722 URL: http://svn.reactos.org/svn/reactos?rev=23722&view=rev Log: - Remove useless stack operations in KiInterruptDispatch that I used for debugging. Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/trap.s?re… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/trap.s (original) +++ trunk/reactos/ntoskrnl/ke/i386/trap.s Sat Aug 26 20:07:31 2006 @@ -1446,7 +1446,6 @@ /* Check if it was handled */ or eax, eax jz SpuriousInt - sub esp, 12 /* Acquire the lock */ GetIntLock: @@ -1462,9 +1461,6 @@ /* Release the lock */ RELEASE_SPINLOCK(esi) - /* Clean up the stack */ - add esp, 12 - /* Exit the interrupt */ mov esi, $ cli

1 0

[ion] 23721: - Fix some bugs in KiChainedDispatch.
by ion＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: ion Date: Sat Aug 26 20:04:29 2006 New Revision: 23721 URL: http://svn.reactos.org/svn/reactos?rev=23721&view=rev Log: - Fix some bugs in KiChainedDispatch. Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/trap.s?re… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/trap.s (original) +++ trunk/reactos/ntoskrnl/ke/i386/trap.s Sat Aug 26 20:04:29 2006 @@ -1401,6 +1401,7 @@ sub esp, 4 /* Begin interrupt */ + push esp push eax push ecx call _HalBeginSystemInterrupt@12 @@ -1408,7 +1409,6 @@ /* Check if it was handled */ or eax, eax jz SpuriousInt - sub esp, 12 /* Call the 2nd-level handler */ call _KiChainedDispatch2ndLvl@0 @@ -1436,9 +1436,9 @@ /* Save old irql */ push eax sub esp, 4 + + /* Begin interrupt */ push esp - - /* Begin interrupt */ push eax push ecx call _HalBeginSystemInterrupt@12

1 0

[ion] 23720: - Fix a bug during exceptions, thanks to W3seek, nice find.
by ion＠svn.reactos.org 26 Aug '06

26 Aug '06

Author: ion Date: Sat Aug 26 19:40:27 2006 New Revision: 23720 URL: http://svn.reactos.org/svn/reactos?rev=23720&view=rev Log: - Fix a bug during exceptions, thanks to W3seek, nice find. Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/trap.s?re… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/trap.s (original) +++ trunk/reactos/ntoskrnl/ke/i386/trap.s Sat Aug 26 19:40:27 2006 @@ -722,6 +722,7 @@ call _KiDispatchException@20 /* End the trap */ + mov esp, ebp jmp _Kei386EoiHelper@0 .endfunc

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
45
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2006