Author: dreimer
Date: Sat Oct 20 17:41:55 2007
New Revision: 29709
URL: http://svn.reactos.org/svn/reactos?rev=29709&view=rev
Log:
Make options.exe startable from cmd window. After exiting rosbe resets to use the new settings.
Added:
trunk/tools/RosBE-Windows/Root/options.cmd (with props)
Modified:
trunk/tools/RosBE-Windows/Root/Help.cmd
trunk/tools/RosBE-Windows/Root/RosBE.mac
Modified: trunk/tools/RosBE-Windows/Root/Help.cmd
URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE-Windows/Root/Help.cmd?…
==============================================================================
--- trunk/tools/RosBE-Windows/Root/Help.cmd (original)
+++ trunk/tools/RosBE-Windows/Root/Help.cmd Sat Oct 20 17:41:55 2007
@@ -33,6 +33,8 @@
echo the RosBE build logs.
echo help [COMMAND] - Display the available commands or help on a
echo specific command.
+ echo options - Starts options.exe and reboots to make the
+ echo changes effective at the end.
echo raddr2line [OPTIONS] - Translates program addresses into file names and
echo line numbers to assist Developers to find
echo specific Bugs in ReactOS.
@@ -108,6 +110,12 @@
echo Switches back to the ReactOS source directory.
goto :EOF
)
+if "%1" == "options" (
+ echo Usage: options
+ echo Starts RosBE Configurator and reboots RosBE afterwards to make the
+ echo changes effective at the end.
+ goto :EOF
+)
if "%1" == "scut" (
echo Usage: scut [OPTIONS]
echo Defines, Removes, Switches and Defaults to Shortcutted Source Directories.
Modified: trunk/tools/RosBE-Windows/Root/RosBE.mac
URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE-Windows/Root/RosBE.mac…
==============================================================================
--- trunk/tools/RosBE-Windows/Root/RosBE.mac (original)
+++ trunk/tools/RosBE-Windows/Root/RosBE.mac Sat Oct 20 17:41:55 2007
@@ -7,3 +7,4 @@
RADDR2LINE = "%_ROSBE_BASEDIR%\reladdr2line.cmd" $*
SCUT = "%_ROSBE_BASEDIR%\scut.cmd" $*
SSVN = "%_ROSBE_BASEDIR%\sSVN.cmd" $*
+OPTIONS = "%_ROSBE_BASEDIR%\options.cmd" $*
Added: trunk/tools/RosBE-Windows/Root/options.cmd
URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE-Windows/Root/options.c…
==============================================================================
--- trunk/tools/RosBE-Windows/Root/options.cmd (added)
+++ trunk/tools/RosBE-Windows/Root/options.cmd Sat Oct 20 17:41:55 2007
@@ -1,0 +1,14 @@
+::
+:: PROJECT: RosBE - ReactOS Build Environment for Windows
+:: LICENSE: GPL - See LICENSE.txt in the top level directory.
+:: FILE: Root/options.cmd
+:: PURPOSE: Starts options.exe and reboots RosBE at the End.
+:: COPYRIGHT: Copyright 2007 Daniel Reimer <reimer.daniel(a)freenet.de>
+::
+::
+@echo off
+
+title Options
+
+"%_ROSBE_BASEDIR%\options.exe"
+"%_ROSBE_BASEDIR%\RosBE.cmd"
Propchange: trunk/tools/RosBE-Windows/Root/options.cmd
------------------------------------------------------------------------------
svn:eol-style = native
Author: mnordell
Date: Sat Oct 20 11:36:17 2007
New Revision: 29702
URL: http://svn.reactos.org/svn/reactos?rev=29702&view=rev
Log:
Don't try to open a harddisk for reading when checking for it to create the PhysicalDriveN links. Instead, request FILE_READ_ATTRIBUTES. This silences a hack-warning in IopParseDevice, that now possibly can be removed.
Modified:
trunk/reactos/ntoskrnl/fstub/disksup.c
trunk/reactos/ntoskrnl/io/iomgr/file.c
Modified: trunk/reactos/ntoskrnl/fstub/disksup.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?r…
==============================================================================
--- trunk/reactos/ntoskrnl/fstub/disksup.c (original)
+++ trunk/reactos/ntoskrnl/fstub/disksup.c Sat Oct 20 11:36:17 2007
@@ -481,7 +481,7 @@
NULL);
Status = ZwOpenFile(&FileHandle,
- FILE_READ_DATA | SYNCHRONIZE,
+ FILE_READ_ATTRIBUTES | SYNCHRONIZE,
&ObjectAttributes,
&StatusBlock,
FILE_SHARE_READ,
Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/file.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c Sat Oct 20 11:36:17 2007
@@ -404,6 +404,9 @@
/* FIXME: Small hack still exists, have to check why...
* This is triggered multiple times by usetup and then once per boot.
+ * TMN: NOTE: It might have been fixed now, by changing the requested
+ * openmode in xHalIoAssignDriveLetters from FILE_READ_DATA to
+ * FILE_READ_ATTRIBUTES. If verified, this hack should be removed.
*/
if (!(DirectOpen) &&
!(RemainingName->Length) &&
Author: peterw
Date: Sat Oct 20 10:37:14 2007
New Revision: 29701
URL: http://svn.reactos.org/svn/reactos?rev=29701&view=rev
Log:
- Fix some typos, bit more cleanup.
Modified:
trunk/tools/RosBE-Windows/Root/Help.cmd
trunk/tools/RosBE-Windows/Root/RosBE.cmd
trunk/tools/RosBE-Windows/Tools/config/options.c
Modified: trunk/tools/RosBE-Windows/Root/Help.cmd
URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE-Windows/Root/Help.cmd?…
==============================================================================
--- trunk/tools/RosBE-Windows/Root/Help.cmd (original)
+++ trunk/tools/RosBE-Windows/Root/Help.cmd Sat Oct 20 10:37:14 2007
@@ -18,7 +18,7 @@
echo.
echo Available Commands:
echo make [OPTIONS] - Without options it does a standard build of
- echo ReactOS. OPTIONS1 are the standard ReactOS build
+ echo ReactOS. OPTIONS are the standard ReactOS build
echo options ie. "bootcd"
echo makex [OPTIONS] - Same as 'make' but automatically determines the
echo number of CPU Cores in the system and uses -j
@@ -43,16 +43,16 @@
goto :EOF
)
if "%1" == "make" (
- echo Usage: make [OPTIONS1] [OPTIONS2]
- echo Without options it does a standard build of ReactOS. OPTIONS1 are the
+ echo Usage: make [OPTIONS]
+ echo Without options it does a standard build of ReactOS. OPTIONS are the
echo standard ReactOS build options ie. "bootcd", "livecd", etc.
goto :EOF
)
if "%1" == "makex" (
- echo Usage: makex [OPTIONS1] [OPTIONS2]
+ echo Usage: makex [OPTIONS]
echo Same as 'make' but automatically determines the number of CPU Cores in
echo the system and uses "make -j x" with the appropriate number.
- echo NOTE: The number makex uses can be modified by editing Build-Multi.cmd
+ echo NOTE: The number makex uses can be modified by editing Build.cmd
echo located in the RosBE directory, instructions for doing so are
echo contained within the file.
goto :EOF
Modified: trunk/tools/RosBE-Windows/Root/RosBE.cmd
URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE-Windows/Root/RosBE.cmd…
==============================================================================
--- trunk/tools/RosBE-Windows/Root/RosBE.cmd (original)
+++ trunk/tools/RosBE-Windows/Root/RosBE.cmd Sat Oct 20 10:37:14 2007
@@ -41,7 +41,7 @@
::
if "%1" == "oldmode" (
cls
- set _ROSBE_OLDMODE=
+ set _ROSBE_OLDMODE=""
call :RosBE4
goto :EndCommandParse
)
Modified: trunk/tools/RosBE-Windows/Tools/config/options.c
URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE-Windows/Tools/config/o…
==============================================================================
--- trunk/tools/RosBE-Windows/Tools/config/options.c (original)
+++ trunk/tools/RosBE-Windows/Tools/config/options.c Sat Oct 20 10:37:14 2007
@@ -48,7 +48,7 @@
{
int foreground, background;
BOOL showtime, writelog, useccache, strip;
- WCHAR logpath[MAX_PATH], mingwpath[MAX_PATH], checkmgw[MAX_PATH], checklog[MAX_PATH];
+ WCHAR logdir[MAX_PATH], mingwpath[MAX_PATH], checkmgw[MAX_PATH], checklog[MAX_PATH];
WCHAR msgerror[256];
HANDLE hFile;
FILE *pFile;
@@ -59,19 +59,19 @@
strip = SendMessage(GetDlgItem(hwnd, ID_STRIP), BM_GETCHECK, 0, 0);
foreground = SendMessage(GetDlgItem(hwnd, IDC_FONT), CB_GETCURSEL, 0, 0);
background = SendMessage(GetDlgItem(hwnd, IDC_BACK), CB_GETCURSEL, 0, 0);
- GetDlgItemText(hwnd, ID_LOGDIR, logpath, MAX_PATH);
+ GetDlgItemText(hwnd, ID_LOGDIR, logdir, MAX_PATH);
GetDlgItemText(hwnd, ID_MGWDIR, mingwpath, MAX_PATH);
if (writelog)
{
GetCurrentDirectory(MAX_PATH, checklog);
- if (SetCurrentDirectory(logpath))
+ if (SetCurrentDirectory(logdir))
{
SetCurrentDirectory(checklog);
}
else
{
- if (!CreateDirectory(logpath, NULL))
+ if (!CreateDirectory(logdir, NULL))
{
LoadString(hInstance, MSG_DIREFAILED, msgerror, 256);
MessageBox(NULL, msgerror, NULL, MB_ICONERROR);
@@ -106,7 +106,7 @@
fprintf(pFile, "set _ROSBE_USECCACHE=%d\n", useccache);
fprintf(pFile, "set _ROSBE_STRIP=%d\n", strip);
fprintf(pFile, "set _ROSBE_WRITELOG=%d\n", writelog);
- fprintf(pFile, "set _ROSBE_LOGPATH=%S\n", logpath);
+ fprintf(pFile, "set _ROSBE_LOGDIR=%S\n", logdir);
fprintf(pFile, "set _ROSBE_MINGWPATH=%S\n", mingwpath);
fclose(pFile);
return TRUE;