Ros-diffs October 2007

ros-diffs@reactos.org

20 participants
708 discussions

[cfinck] 29479: - Set all Bugzilla text files to svn:eol-style "LF". As far as I know, Bugzilla can get into trouble, when another line-ending style is used. - Remove the unneeded "CVS" subdirectories and ".cvsignore" files from the "bugzilla" directory.

by cfinck＠svn.reactos.org

17 years, 2 months

[cfinck] 29478: Update to MediaWiki 1.10.2 The new release contains many security fixes.

by cfinck＠svn.reactos.org

17 years, 2 months

[fireball] 29477: - Copy kernel's IDT entries to the IDT we've got from the bootloader. Fixes boot-process initiated by ntldr-compatible loaders.

by fireball＠svn.reactos.org

Author: fireball Date: Wed Oct 10 16:39:54 2007 New Revision: 29477 URL: http://svn.reactos.org/svn/reactos?rev=29477&view=rev Log: - Copy kernel's IDT entries to the IDT we've got from the bootloader. Fixes boot-process initiated by ntldr-compatible loaders. Modified: trunk/reactos/ntoskrnl/ke/i386/kiinit.c Modified: trunk/reactos/ntoskrnl/ke/i386/kiinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/kiinit.c?… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/kiinit.c (original) +++ trunk/reactos/ntoskrnl/ke/i386/kiinit.c Wed Oct 10 16:39:54 2007 @@ -661,6 +661,7 @@ ULONG InitialStack; PKGDTENTRY Gdt; PKIDTENTRY Idt; + KIDTENTRY NmiEntry, DoubleFaultEntry; PKTSS Tss; PKIPCR Pcr; @@ -722,6 +723,19 @@ Ke386SetDs(KGDT_R3_DATA | RPL_MASK); Ke386SetEs(KGDT_R3_DATA | RPL_MASK); + /* Save NMI and double fault traps */ + RtlCopyMemory(&NmiEntry, &Idt[2], sizeof(KIDTENTRY)); + RtlCopyMemory(&DoubleFaultEntry, &Idt[8], sizeof(KIDTENTRY)); + + /* Copy kernel's trap handlers */ + RtlCopyMemory(Idt, + (PVOID)KiIdtDescriptor.Base, + KiIdtDescriptor.Limit + 1); + + /* Restore NMI and double fault */ + RtlCopyMemory(&Idt[2], &NmiEntry, sizeof(KIDTENTRY)); + RtlCopyMemory(&Idt[8], &DoubleFaultEntry, sizeof(KIDTENTRY)); + AppCpuInit: /* Loop until we can release the freeze lock */ do

17 years, 2 months

[hpoussin] 29476: Cleanup the LinkerScript class and use it Patch by Marc Piulachs, marc dot puilachs at codexchange dot net See issue #2721 for more details.

by hpoussin＠svn.reactos.org

Author: hpoussin Date: Wed Oct 10 12:44:45 2007 New Revision: 29476 URL: http://svn.reactos.org/svn/reactos?rev=29476&view=rev Log: Cleanup the LinkerScript class and use it Patch by Marc Piulachs, marc dot puilachs at codexchange dot net See issue #2721 for more details. Modified: trunk/reactos/ntoskrnl/ntoskrnl.rbuild trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp trunk/reactos/tools/rbuild/linkerscript.cpp trunk/reactos/tools/rbuild/module.cpp trunk/reactos/tools/rbuild/rbuild.h Modified: trunk/reactos/ntoskrnl/ntoskrnl.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl.rbuild?r… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl.rbuild (original) +++ trunk/reactos/ntoskrnl/ntoskrnl.rbuild Wed Oct 10 12:44:45 2007 @@ -422,4 +422,5 @@ <linkerflag>-nostartfiles</linkerflag> <linkerflag>-nostdlib</linkerflag> <linkerflag>-lgcc</linkerflag> + <linkerscript>ntoskrnl_$(ARCH).lnk</linkerscript> </module> Modified: trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/mingw… ============================================================================== --- trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp (original) +++ trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp Wed Oct 10 12:44:45 2007 @@ -1598,7 +1598,7 @@ string linkerScriptArgument; if ( module.linkerScript != NULL ) - linkerScriptArgument = ssprintf ( "-Wl,-T,%s", module.linkerScript->directory.c_str () ); + linkerScriptArgument = ssprintf ( "-Wl,-T,%s", backend->GetFullName ( module.linkerScript->file ).c_str () ); else linkerScriptArgument = ""; @@ -2469,9 +2469,7 @@ string dependencies = linkDepsMacro + " " + objectsMacro; - string linkerParameters = ssprintf ( "-Wl,-T,%s%cntoskrnl_$(ARCH).lnk -Wl,--subsystem,native -Wl,--entry,%s -Wl,--image-base,%s", - module.output->relative_path.c_str (), - cSep, + string linkerParameters = ssprintf ( "-Wl,--subsystem,native -Wl,--entry,%s -Wl,--image-base,%s", module.GetEntryPoint(true).c_str (), module.baseaddress.c_str () ); GenerateLinkerCommand ( dependencies, Modified: trunk/reactos/tools/rbuild/linkerscript.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/linkerscript.… ============================================================================== --- trunk/reactos/tools/rbuild/linkerscript.cpp (original) +++ trunk/reactos/tools/rbuild/linkerscript.cpp Wed Oct 10 12:44:45 2007 @@ -20,16 +20,10 @@ #include "rbuild.h" -using std::string; -using std::vector; - -LinkerScript::LinkerScript ( const Project& project, - const Module* module, - const XMLElement& node ) - : project ( project ), - module ( module ), - node ( node ), - baseModule ( NULL ) +LinkerScript::LinkerScript ( const XMLElement& node_, + const Module& module_, + const FileLocation& file_ ) + : node(node_), module(module_), file(file_) { } @@ -40,36 +34,4 @@ void LinkerScript::ProcessXML() { - const XMLAttribute* att; - att = node.GetAttribute ( "base", - false ); - if ( att ) - { - bool referenceResolved = false; - if ( att->value == project.name ) - { - basePath = "."; - referenceResolved = true; - } - else - { - const Module* base = project.LocateModule ( att->value ); - if ( base != NULL ) - { - baseModule = base; - basePath = base->output->relative_path; - referenceResolved = true; - } - } - if ( !referenceResolved ) - { - throw XMLInvalidBuildFileException ( - node.location, - "<linkerscript> attribute 'base' references non-existant project or module '%s'", - att->value.c_str() ); - } - directory = NormalizeFilename ( basePath + sSep + node.value ); - } - else - directory = NormalizeFilename ( node.value ); } Modified: trunk/reactos/tools/rbuild/module.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/module.cpp?re… ============================================================================== --- trunk/reactos/tools/rbuild/module.cpp (original) +++ trunk/reactos/tools/rbuild/module.cpp Wed Oct 10 12:44:45 2007 @@ -748,13 +748,31 @@ } else if ( e.name == "linkerscript" ) { + if ( parseContext.ifData ) + { + throw XMLInvalidBuildFileException ( + e.location, + "<linkerscript> is not a valid sub-element of <if>" ); + } if ( linkerScript ) { throw XMLInvalidBuildFileException ( e.location, "Only one <linkerscript> is valid per module" ); } - linkerScript = new LinkerScript ( project, this, e ); + size_t pos = e.value.find_last_of ( "/\\" ); + if ( pos == string::npos ) + { + linkerScript = new LinkerScript ( + e, *this, FileLocation ( SourceDirectory, relative_path, e.value, &e ) ); + } + else + { + string dir = e.value.substr ( 0, pos ); + string name = e.value.substr ( pos + 1); + linkerScript = new LinkerScript ( + e, *this, FileLocation ( SourceDirectory, relative_path + sSep + dir, name, &e ) ); + } subs_invalid = true; } else if ( e.name == "component" ) Modified: trunk/reactos/tools/rbuild/rbuild.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/rbuild.h?rev=… ============================================================================== --- trunk/reactos/tools/rbuild/rbuild.h (original) +++ trunk/reactos/tools/rbuild/rbuild.h Wed Oct 10 12:44:45 2007 @@ -625,16 +625,13 @@ class LinkerScript { public: - const Project& project; - const Module* module; - const XMLElement& node; - const Module* baseModule; - std::string directory; - std::string basePath; - - LinkerScript ( const Project& project, - const Module* module, - const XMLElement& node ); + const XMLElement& node; + const Module& module; + FileLocation file; + + LinkerScript ( const XMLElement& node, + const Module& module, + const FileLocation& file ); ~LinkerScript (); void ProcessXML(); };

17 years, 2 months

[hpoussin] 29475: Do not skip executable name, it is not sent to WinMain command line argument

by hpoussin＠svn.reactos.org

Author: hpoussin Date: Tue Oct 9 23:01:12 2007 New Revision: 29475 URL: http://svn.reactos.org/svn/reactos?rev=29475&view=rev Log: Do not skip executable name, it is not sent to WinMain command line argument Modified: trunk/reactos/base/applications/notepad/main.c Modified: trunk/reactos/base/applications/notepad/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… ============================================================================== --- trunk/reactos/base/applications/notepad/main.c (original) +++ trunk/reactos/base/applications/notepad/main.c Tue Oct 9 23:01:12 2007 @@ -431,21 +431,7 @@ static void HandleCommandLine(LPTSTR cmdline) { - TCHAR delimiter; int opt_print=0; - - /* skip white space */ - while (*cmdline == ' ') cmdline++; - - /* skip executable name */ - delimiter = (*cmdline == _T('"') ? _T('"') : _T(' ')); - - do - { - cmdline++; - } - while (*cmdline && *cmdline != delimiter); - if (*cmdline == delimiter) cmdline++; while (*cmdline == _T(' ') || *cmdline == _T('-') || *cmdline == _T('/')) {

17 years, 2 months

[dreimer] 29474: This should fix the build

by dreimer＠svn.reactos.org

Author: dreimer Date: Tue Oct 9 22:37:48 2007 New Revision: 29474 URL: http://svn.reactos.org/svn/reactos?rev=29474&view=rev Log: This should fix the build Added: trunk/reactos/base/applications/wordpad/ - copied from r29472, trunk/reactos/base/applications/wine_wordpad/ trunk/reactos/base/applications/wordpad/wordpad.rbuild (with props) Removed: trunk/reactos/base/applications/wine_wordpad/ trunk/reactos/base/applications/wordpad/wine_wordpad.rbuild Removed: trunk/reactos/base/applications/wordpad/wine_wordpad.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/wine_wor… ============================================================================== --- trunk/reactos/base/applications/wordpad/wine_wordpad.rbuild (original) +++ trunk/reactos/base/applications/wordpad/wine_wordpad.rbuild (removed) @@ -1,19 +1,0 @@ -<?xml version="1.0"?> -<!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="wine_wordpad" type="win32gui" installbase="system32" installname="wordpad.exe" unicode="yes" allowwarnings="true"> - <include base="wine_wordpad">.</include> - <define name="__USE_W32API" /> - <define name="_WIN32_IE">0x0600</define> - <define name="_WIN32_WINNT">0x0501</define> - <library>kernel32</library> - <library>user32</library> - <library>gdi32</library> - <library>comdlg32</library> - <library>advapi32</library> - <library>shell32</library> - <library>comctl32</library> - <compilationunit name="unit.c"> - <file>wordpad.c</file> - </compilationunit> - <file>rsrc.rc</file> -</module> Added: trunk/reactos/base/applications/wordpad/wordpad.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/wordpad/… ============================================================================== --- trunk/reactos/base/applications/wordpad/wordpad.rbuild (added) +++ trunk/reactos/base/applications/wordpad/wordpad.rbuild Tue Oct 9 22:37:48 2007 @@ -1,0 +1,19 @@ +<?xml version="1.0"?> +<!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> +<module name="wordpad" type="win32gui" installbase="system32" installname="wordpad.exe" unicode="yes" allowwarnings="true"> + <include base="wordpad">.</include> + <define name="__USE_W32API" /> + <define name="_WIN32_IE">0x0600</define> + <define name="_WIN32_WINNT">0x0501</define> + <library>kernel32</library> + <library>user32</library> + <library>gdi32</library> + <library>comdlg32</library> + <library>advapi32</library> + <library>shell32</library> + <library>comctl32</library> + <compilationunit name="unit.c"> + <file>wordpad.c</file> + </compilationunit> + <file>rsrc.rc</file> +</module> Propchange: trunk/reactos/base/applications/wordpad/wordpad.rbuild ------------------------------------------------------------------------------ svn:eol-style = native

17 years, 2 months

[dreimer] 29473: Try to remove the old wordpad and prepare fr the new one

by dreimer＠svn.reactos.org

Author: dreimer Date: Tue Oct 9 22:35:38 2007 New Revision: 29473 URL: http://svn.reactos.org/svn/reactos?rev=29473&view=rev Log: Try to remove the old wordpad and prepare fr the new one Removed: trunk/reactos/base/applications/wordpad/ Modified: trunk/reactos/base/applications/applications.rbuild trunk/reactos/boot/bootdata/packages/reactos.dff Modified: trunk/reactos/base/applications/applications.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/applicat… ============================================================================== --- trunk/reactos/base/applications/applications.rbuild (original) +++ trunk/reactos/base/applications/applications.rbuild Tue Oct 9 22:35:38 2007 @@ -64,7 +64,4 @@ <directory name="wordpad"> <xi:include href="wordpad/wordpad.rbuild" /> </directory> -<directory name="wine_wordpad"> - <xi:include href="wine_wordpad/wine_wordpad.rbuild" /> -</directory> </group> Modified: trunk/reactos/boot/bootdata/packages/reactos.dff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… ============================================================================== --- trunk/reactos/boot/bootdata/packages/reactos.dff (original) +++ trunk/reactos/boot/bootdata/packages/reactos.dff Tue Oct 9 22:35:38 2007 @@ -67,7 +67,7 @@ base\applications\shutdown\shutdown.exe 1 base\applications\sndvol32\sndvol32.exe 1 base\applications\taskmgr\taskmgr.exe 1 -base\applications\wine_wordpad\wordpad.exe 1 +base\applications\wordpad\wordpad.exe 1 base\services\dhcp\dhcp.exe 1 base\services\eventlog\eventlog.exe 1

17 years, 2 months

[dreimer] 29472: Backup WordPad to RosApps

by dreimer＠svn.reactos.org

Author: dreimer Date: Tue Oct 9 22:25:19 2007 New Revision: 29472 URL: http://svn.reactos.org/svn/reactos?rev=29472&view=rev Log: Backup WordPad to RosApps Added: trunk/rosapps/old_wordpad/ trunk/rosapps/old_wordpad/about.c (with props) trunk/rosapps/old_wordpad/dialogs.c (with props) trunk/rosapps/old_wordpad/editwnd.c (with props) trunk/rosapps/old_wordpad/lang/ trunk/rosapps/old_wordpad/lang/bg-BG.rc (with props) trunk/rosapps/old_wordpad/lang/de-DE.rc (with props) trunk/rosapps/old_wordpad/lang/el-GR.rc (with props) trunk/rosapps/old_wordpad/lang/en-US.rc (with props) trunk/rosapps/old_wordpad/lang/fi-FI.rc (with props) trunk/rosapps/old_wordpad/lang/fr-FR.rc (with props) trunk/rosapps/old_wordpad/lang/it-IT.rc (with props) trunk/rosapps/old_wordpad/lang/nb-NO.rc (with props) trunk/rosapps/old_wordpad/lang/nl-NL.rc (with props) trunk/rosapps/old_wordpad/lang/pl-PL.rc (with props) trunk/rosapps/old_wordpad/lang/ru-RU.rc (with props) trunk/rosapps/old_wordpad/lang/th-TH.rc (with props) trunk/rosapps/old_wordpad/lang/uk-UA.rc (with props) trunk/rosapps/old_wordpad/lang/zh-CN.rc (with props) trunk/rosapps/old_wordpad/mainwnd.c (with props) trunk/rosapps/old_wordpad/manifest.xml (with props) trunk/rosapps/old_wordpad/misc.c (with props) trunk/rosapps/old_wordpad/old_wordpad.rbuild (with props) trunk/rosapps/old_wordpad/opensave.c (with props) trunk/rosapps/old_wordpad/precomp.h (with props) trunk/rosapps/old_wordpad/res/ trunk/rosapps/old_wordpad/res/toolbar.bmp (with props) trunk/rosapps/old_wordpad/res/wordpad.ico (with props) trunk/rosapps/old_wordpad/resource.h (with props) trunk/rosapps/old_wordpad/rsrc.rc (with props) trunk/rosapps/old_wordpad/wordpad.c (with props) trunk/rosapps/old_wordpad/wordpad.rc (with props) [This mail would be too long, it was shortened to contain the URLs only.] Added: trunk/rosapps/old_wordpad/about.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/about.c?rev=29… Added: trunk/rosapps/old_wordpad/dialogs.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/dialogs.c?rev=… Added: trunk/rosapps/old_wordpad/editwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/editwnd.c?rev=… Added: trunk/rosapps/old_wordpad/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/bg-BG.rc?… Added: trunk/rosapps/old_wordpad/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/de-DE.rc?… Added: trunk/rosapps/old_wordpad/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/el-GR.rc?… Added: trunk/rosapps/old_wordpad/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/en-US.rc?… Added: trunk/rosapps/old_wordpad/lang/fi-FI.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/fi-FI.rc?… Added: trunk/rosapps/old_wordpad/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/fr-FR.rc?… Added: trunk/rosapps/old_wordpad/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/it-IT.rc?… Added: trunk/rosapps/old_wordpad/lang/nb-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/nb-NO.rc?… Added: trunk/rosapps/old_wordpad/lang/nl-NL.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/nl-NL.rc?… Added: trunk/rosapps/old_wordpad/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/pl-PL.rc?… Added: trunk/rosapps/old_wordpad/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/ru-RU.rc?… Added: trunk/rosapps/old_wordpad/lang/th-TH.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/th-TH.rc?… Added: trunk/rosapps/old_wordpad/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/uk-UA.rc?… Added: trunk/rosapps/old_wordpad/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/lang/zh-CN.rc?… Added: trunk/rosapps/old_wordpad/mainwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/mainwnd.c?rev=… Added: trunk/rosapps/old_wordpad/manifest.xml URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/manifest.xml?r… Added: trunk/rosapps/old_wordpad/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/misc.c?rev=294… Added: trunk/rosapps/old_wordpad/old_wordpad.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/old_wordpad.rb… Added: trunk/rosapps/old_wordpad/opensave.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/opensave.c?rev… Added: trunk/rosapps/old_wordpad/precomp.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/precomp.h?rev=… Added: trunk/rosapps/old_wordpad/res/toolbar.bmp URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/res/toolbar.bm… Added: trunk/rosapps/old_wordpad/res/wordpad.ico URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/res/wordpad.ic… Added: trunk/rosapps/old_wordpad/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/resource.h?rev… Added: trunk/rosapps/old_wordpad/rsrc.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/rsrc.rc?rev=29… Added: trunk/rosapps/old_wordpad/wordpad.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/wordpad.c?rev=… Added: trunk/rosapps/old_wordpad/wordpad.rc URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/old_wordpad/wordpad.rc?rev…

17 years, 2 months

[fireball] 29471: Mike Nordell <tamlin> - Add two checks for infinite loops. The latter gets triggered in some cases, a memory overwrite is suspected, or a race condition.

by fireball＠svn.reactos.org

Author: fireball Date: Tue Oct 9 21:00:11 2007 New Revision: 29471 URL: http://svn.reactos.org/svn/reactos?rev=29471&view=rev Log: Mike Nordell <tamlin> - Add two checks for infinite loops. The latter gets triggered in some cases, a memory overwrite is suspected, or a race condition. Modified: trunk/reactos/ntoskrnl/cm/registry.c Modified: trunk/reactos/ntoskrnl/cm/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cm/registry.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/cm/registry.c (original) +++ trunk/reactos/ntoskrnl/cm/registry.c Tue Oct 9 21:00:11 2007 @@ -97,11 +97,21 @@ !(CurrentKey->Flags & KO_MARKED_FOR_DELETE)) { ObDereferenceObject(CurrentKey); + if (CurrentEntry == CmiKeyObjectListHead.Blink) + { + DPRINT("Registry loop detected! Crashing\n"); + KEBUGCHECK(0); + } CurrentEntry = CmiKeyObjectListHead.Blink; Count++; } else { + if (CurrentEntry == CurrentEntry->Blink) + { + DPRINT("Registry loop detected! Crashing\n"); + KEBUGCHECK(0); + } CurrentEntry = CurrentEntry->Blink; } }

17 years, 2 months

[fireball] 29470: - Null-terminate the ArcBoot path, so that it doesn't contain garbage. Makes winldr be able to boot WinNT 4.0 (but it still hangs shortly after booting in qemu).

by fireball＠svn.reactos.org

Author: fireball Date: Tue Oct 9 15:37:01 2007 New Revision: 29470 URL: http://svn.reactos.org/svn/reactos?rev=29470&view=rev Log: - Null-terminate the ArcBoot path, so that it doesn't contain garbage. Makes winldr be able to boot WinNT 4.0 (but it still hangs shortly after booting in qemu). Modified: branches/winldr/windows/winldr.c Modified: branches/winldr/windows/winldr.c URL: http://svn.reactos.org/svn/reactos/branches/winldr/windows/winldr.c?rev=294… ============================================================================== --- branches/winldr/windows/winldr.c (original) +++ branches/winldr/windows/winldr.c Tue Oct 9 15:37:01 2007 @@ -95,6 +95,7 @@ /* Construct SystemRoot and ArcBoot from SystemPath */ PathSeparator = strstr(SystemPath, "\\") - SystemPath; strncpy(ArcBoot, SystemPath, PathSeparator); + ArcBoot[PathSeparator] = 0; strcpy(SystemRoot, &SystemPath[PathSeparator]); strcat(SystemRoot, "\\");

17 years, 2 months

← Newer
1
...
53
54
55
56
57
58
59
...
71
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2007