Ros-diffs June 2007

ros-diffs@reactos.org

21 participants
420 discussions

[hamtitampti] 27349: Added Repair and update function to installer
by hamtitampti＠svn.reactos.org 30 Jun '07

30 Jun '07

Author: hamtitampti Date: Sat Jun 30 23:37:43 2007 New Revision: 27349 URL: http://svn.reactos.org/svn/reactos?rev=27349&view=rev Log: Added Repair and update function to installer Modified: trunk/reactos/base/setup/usetup/interface/usetup.c Modified: trunk/reactos/base/setup/usetup/interface/usetup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/interfac… ============================================================================== --- trunk/reactos/base/setup/usetup/interface/usetup.c (original) +++ trunk/reactos/base/setup/usetup/interface/usetup.c Sat Jun 30 23:37:43 2007 @@ -81,6 +81,7 @@ LONG UnattendMBRInstallType = -1; LONG UnattendFormatPartition = 0; WCHAR UnattendInstallationDirectory[MAX_PATH]; +BOOLEAN RepairUpdateFlag = FALSE; /* LOCALS *******************************************************************/ @@ -814,11 +815,13 @@ CONSOLE_SetTextXY(6, 12, "The repair functions are not implemented yet."); - CONSOLE_SetTextXY(8, 15, "\x07 Press R for the Recovery Console."); - - CONSOLE_SetTextXY(8, 17, "\x07 Press ESC to return to the main page."); - - CONSOLE_SetTextXY(8, 19, "\x07 Press ENTER to reboot your computer."); + CONSOLE_SetTextXY(8, 15, "\x07 Press U for Updating OS."); + + CONSOLE_SetTextXY(8, 17, "\x07 Press R for the Recovery Console."); + + CONSOLE_SetTextXY(8, 19, "\x07 Press ESC to return to the main page."); + + CONSOLE_SetTextXY(8, 21, "\x07 Press ENTER to reboot your computer."); CONSOLE_SetStatusText(" ESC = Main page ENTER = Reboot"); @@ -829,6 +832,11 @@ if (Ir->Event.KeyEvent.uChar.AsciiChar == 0x0D) /* ENTER */ { return REBOOT_PAGE; + } + else if (toupper(Ir->Event.KeyEvent.uChar.AsciiChar) == 'U') /* U */ + { + RepairUpdateFlag = TRUE; + return INSTALL_INTRO_PAGE; } else if (toupper(Ir->Event.KeyEvent.uChar.AsciiChar) == 'R') /* R */ { @@ -870,6 +878,12 @@ CONSOLE_SetStatusText(" ENTER = Continue F3 = Quit"); + if (RepairUpdateFlag) + { + //return SELECT_PARTITION_PAGE; + return DEVICE_SETTINGS_PAGE; + } + if (IsUnattendedSetup) { return SELECT_PARTITION_PAGE; @@ -1017,7 +1031,12 @@ CONSOLE_SetTextXY(6, 24, "and press ENTER."); CONSOLE_SetStatusText(" ENTER = Continue F3 = Quit"); - + + if (RepairUpdateFlag) + { + return SELECT_PARTITION_PAGE; + } + while(TRUE) { CONSOLE_ConInKey(Ir); @@ -2058,7 +2077,12 @@ DrawFileSystemList (FileSystemList); CONSOLE_SetStatusText (" ENTER = Continue ESC = Cancel F3 = Quit"); - + if (RepairUpdateFlag) + { + return (CHECK_FILE_SYSTEM_PAGE); + //return SELECT_PARTITION_PAGE; + } + if (IsUnattendedSetup) { if (UnattendFormatPartition) @@ -3046,7 +3070,12 @@ CONSOLE_SetTextXY(6, 8, "Setup is updating the system configuration"); CONSOLE_SetStatusText(" Creating registry hives..."); - + + if (RepairUpdateFlag) + { + return SUCCESS_PAGE; + } + if (!SetInstallPathValue(&DestinationPath)) { DPRINT("SetInstallPathValue() failed\n");

1 0

[fireball] 27348: - Commit a fix for KDBG's attach to process problem. See issue #1263 for more details.
by fireball＠svn.reactos.org 30 Jun '07

30 Jun '07

Author: fireball Date: Sat Jun 30 22:58:09 2007 New Revision: 27348 URL: http://svn.reactos.org/svn/reactos?rev=27348&view=rev Log: - Commit a fix for KDBG's attach to process problem. See issue #1263 for more details. Modified: trunk/reactos/ntoskrnl/kdbg/kdb.c Modified: trunk/reactos/ntoskrnl/kdbg/kdb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb.c?rev=27… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb.c (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb.c Sat Jun 30 22:58:09 2007 @@ -168,6 +168,29 @@ /* FIXME: copy v86 registers if TrapFrame is a V86 trapframe */ } +STATIC VOID +KdbpKdbTrapFrameFromKernelStack(PVOID KernelStack, + PKDB_KTRAP_FRAME KdbTrapFrame) +{ + ULONG_PTR *StackPtr; + + RtlZeroMemory(KdbTrapFrame, sizeof(KDB_KTRAP_FRAME)); + StackPtr = (ULONG_PTR *) KernelStack; + KdbTrapFrame->Tf.Ebp = StackPtr[3]; + KdbTrapFrame->Tf.Edi = StackPtr[4]; + KdbTrapFrame->Tf.Esi = StackPtr[5]; + KdbTrapFrame->Tf.Ebx = StackPtr[6]; + KdbTrapFrame->Tf.Eip = StackPtr[7]; + KdbTrapFrame->Tf.HardwareEsp = (ULONG) (StackPtr + 8); + KdbTrapFrame->Tf.HardwareSegSs = KGDT_R0_DATA; + KdbTrapFrame->Tf.SegCs = KGDT_R0_CODE; + KdbTrapFrame->Tf.SegDs = KGDT_R0_DATA; + KdbTrapFrame->Tf.SegEs = KGDT_R0_DATA; + KdbTrapFrame->Tf.SegGs = KGDT_R0_DATA; + + /* FIXME: what about the other registers??? */ +} + /*!\brief Overwrites the instruction at \a Address with \a NewInst and stores * the old instruction in *OldInst. * @@ -1040,7 +1063,8 @@ if (KdbCurrentThread != KdbOriginalThread) { ASSERT(KdbCurrentTrapFrame == &KdbThreadTrapFrame); - KdbpKdbTrapFrameToTrapFrame(KdbCurrentTrapFrame, KdbCurrentThread->Tcb.TrapFrame); + /* Actually, we can't save the context, there's no guarantee that there + * was a trap frame */ } else { @@ -1050,12 +1074,13 @@ /* Switch to the thread's context */ if (Thread != KdbOriginalThread) { - if (Thread->Tcb.TrapFrame == NULL) - { - KdbpPrint("Threads TrapFrame is NULL! Cannot attach.\n"); - return FALSE; - } - KdbpTrapFrameToKdbTrapFrame(Thread->Tcb.TrapFrame, &KdbThreadTrapFrame); + /* The thread we're attaching to isn't the thread on which we entered + * kdb and so the thread we're attaching to is not running. There + * is no guarantee that it actually has a trap frame. So we have to + * peek directly at the registers which were saved on the stack when the + * thread was preempted in the scheduler */ + KdbpKdbTrapFrameFromKernelStack(Thread->Tcb.KernelStack, + &KdbThreadTrapFrame); KdbCurrentTrapFrame = &KdbThreadTrapFrame; } else /* Switching back to original thread */ @@ -1529,11 +1554,8 @@ } } - /* Save the current thread's trapframe */ - if (KdbCurrentTrapFrame == &KdbThreadTrapFrame) - { - KdbpKdbTrapFrameToTrapFrame(KdbCurrentTrapFrame, KdbCurrentThread->Tcb.TrapFrame); - } + /* We can't update the current thread's trapframe 'cause it might not + have one */ /* Detach from attached process */ if (KdbCurrentProcess != KdbOriginalProcess)

1 0

[greatlrd] 27347: forget adding this file sprry I broken the build thx HeisSpiter See issue #2314 for more details.
by greatlrd＠svn.reactos.org 30 Jun '07

30 Jun '07

Author: greatlrd Date: Sat Jun 30 21:47:14 2007 New Revision: 27347 URL: http://svn.reactos.org/svn/reactos?rev=27347&view=rev Log: forget adding this file sprry I broken the build thx HeisSpiter See issue #2314 for more details. Added: trunk/reactos/lib/sdk/libcntpr/string/strtoull.c (with props) Added: trunk/reactos/lib/sdk/libcntpr/string/strtoull.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/libcntpr/string/st… ============================================================================== --- trunk/reactos/lib/sdk/libcntpr/string/strtoull.c (added) +++ trunk/reactos/lib/sdk/libcntpr/string/strtoull.c Sat Jun 30 21:47:14 2007 @@ -1,0 +1,71 @@ +#include <string.h> +#include <errno.h> +#include <fcntl.h> +#include <limits.h> +#include <ctype.h> + + +unsigned long long +strtoull(const char *nptr, char **endptr, int base) +{ + const char *s = nptr; + unsigned long long acc; + int c; + unsigned long long cutoff; + int neg = 0, any, cutlim; + + /* + * See strtol for comments as to the logic used. + */ + do { + c = *s++; + } while (isspace(c)); + if (c == '-') + { + neg = 1; + c = *s++; + } + else if (c == '+') + c = *s++; + if ((base == 0 || base == 16) && + c == '0' && (*s == 'x' || *s == 'X')) + { + c = s[1]; + s += 2; + base = 16; + } + if (base == 0) + base = c == '0' ? 8 : 10; + cutoff = (unsigned long long)ULLONG_MAX / (unsigned long long)base; + cutlim = (unsigned long long)ULLONG_MAX % (unsigned long long)base; + for (acc = 0, any = 0;; c = *s++) + { + if (isdigit(c)) + c -= '0'; + else if (isalpha(c)) + c -= isupper(c) ? 'A' - 10 : 'a' - 10; + else + break; + if (c >= base) + break; + if (any < 0 || acc > cutoff || (acc == cutoff && c > cutlim)) + any = -1; + else { + any = 1; + acc *= base; + acc += c; + } + } + if (any < 0) + { + acc = ULLONG_MAX; + + } + else if (neg) + acc = -acc; + if (endptr != 0) + *endptr = any ? (char *)((size_t)(s - 1)) : (char *)((size_t)nptr); + return acc; +} + + Propchange: trunk/reactos/lib/sdk/libcntpr/string/strtoull.c ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[fireball] 27346: - Revert accidentally committed ASSERT by Magnus in revision 27342.
by fireball＠svn.reactos.org 30 Jun '07

30 Jun '07

Author: fireball Date: Sat Jun 30 20:03:34 2007 New Revision: 27346 URL: http://svn.reactos.org/svn/reactos?rev=27346&view=rev Log: - Revert accidentally committed ASSERT by Magnus in revision 27342. Modified: trunk/reactos/drivers/video/videoprt/dispatch.c Modified: trunk/reactos/drivers/video/videoprt/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/videoprt/dis… ============================================================================== --- trunk/reactos/drivers/video/videoprt/dispatch.c (original) +++ trunk/reactos/drivers/video/videoprt/dispatch.c Sat Jun 30 20:03:34 2007 @@ -110,8 +110,6 @@ PVIDEO_PORT_DRIVER_EXTENSION DriverExtension; DPRINT("IntVideoPortDispatchOpen\n"); - - ASSERT(Irp != NULL); if (CsrssInitialized == FALSE) {

1 0

[fireball] 27345: - Clean up the mess Magnus introduced (remove allowwarnings="true"). - RpcTryFinall set of macros was mapped to PSEH incorrectly, which lead to a "finally" block being treated as an "except" block (thus ending up in a memory leak). Reverting this part for now until a better solution is found.
by fireball＠svn.reactos.org 30 Jun '07

30 Jun '07

Author: fireball Date: Sat Jun 30 20:01:03 2007 New Revision: 27345 URL: http://svn.reactos.org/svn/reactos?rev=27345&view=rev Log: - Clean up the mess Magnus introduced (remove allowwarnings="true"). - RpcTryFinall set of macros was mapped to PSEH incorrectly, which lead to a "finally" block being treated as an "except" block (thus ending up in a memory leak). Reverting this part for now until a better solution is found. Modified: trunk/reactos/dll/win32/aclui/aclui.rbuild trunk/reactos/dll/win32/advapi32/advapi32.rbuild trunk/reactos/include/psdk/rpc.h trunk/reactos/include/reactos/idl/idl.rbuild Modified: trunk/reactos/dll/win32/aclui/aclui.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/aclui/aclui.rbui… ============================================================================== --- trunk/reactos/dll/win32/aclui/aclui.rbuild (original) +++ trunk/reactos/dll/win32/aclui/aclui.rbuild Sat Jun 30 20:01:03 2007 @@ -1,4 +1,4 @@ -<module name="aclui" type="win32dll" baseaddress="${BASEADDRESS_ACLUI}" installbase="system32" installname="aclui.dll" allowwarnings ="true"> +<module name="aclui" type="win32dll" baseaddress="${BASEADDRESS_ACLUI}" installbase="system32" installname="aclui.dll"> <importlibrary definition="aclui.spec.def" /> <include base="aclui">.</include> <define name="UNICODE" /> Modified: trunk/reactos/dll/win32/advapi32/advapi32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/advapi3… ============================================================================== --- trunk/reactos/dll/win32/advapi32/advapi32.rbuild (original) +++ trunk/reactos/dll/win32/advapi32/advapi32.rbuild Sat Jun 30 20:01:03 2007 @@ -1,4 +1,4 @@ -<module name="advapi32" type="win32dll" baseaddress="${BASEADDRESS_ADVAPI32}" installbase="system32" installname="advapi32.dll" allowwarnings ="true"> +<module name="advapi32" type="win32dll" baseaddress="${BASEADDRESS_ADVAPI32}" installbase="system32" installname="advapi32.dll"> <importlibrary definition="advapi32.def" /> <include base="advapi32">.</include> Modified: trunk/reactos/include/psdk/rpc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/rpc.h?rev=273… ============================================================================== --- trunk/reactos/include/psdk/rpc.h (original) +++ trunk/reactos/include/psdk/rpc.h Sat Jun 30 20:01:03 2007 @@ -150,9 +150,9 @@ } \ _SEH_END; - #define RpcTryFinally _SEH_TRY { - #define RpcFinally } _SEH_HANDLE { - #define RpcEndFinally } _SEH_END; + #define RpcTryFinally + #define RpcFinally + #define RpcEndFinally #define RpcExceptionCode() _SEH_GetExceptionCode() /* #define RpcAbnormalTermination() abort() */ Modified: trunk/reactos/include/reactos/idl/idl.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/idl/idl.rb… ============================================================================== --- trunk/reactos/include/reactos/idl/idl.rbuild (original) +++ trunk/reactos/include/reactos/idl/idl.rbuild Sat Jun 30 20:01:03 2007 @@ -1,23 +1,23 @@ <group> -<module name="pnp_server" type="rpcserver" allowwarnings ="true"> +<module name="pnp_server" type="rpcserver"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> <file>pnp.idl</file> </module> -<module name="pnp_client" type="rpcclient" allowwarnings ="true"> +<module name="pnp_client" type="rpcclient"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> <file>pnp.idl</file> </module> -<module name="scm_server" type="rpcserver" allowwarnings ="true"> +<module name="scm_server" type="rpcserver"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> <file switches="--oldnames">svcctl.idl</file> </module> -<module name="scm_client" type="rpcclient" allowwarnings ="true"> +<module name="scm_client" type="rpcclient"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> @@ -35,13 +35,13 @@ <define name="_X86_" /> <file switches="--oldnames">eventlogrpc.idl</file> </module> -<module name="lsa_server" type="rpcserver" allowwarnings ="true"> +<module name="lsa_server" type="rpcserver"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> <file switches="--oldnames">lsa.idl</file> </module> -<module name="lsa_client" type="rpcclient" allowwarnings ="true"> +<module name="lsa_client" type="rpcclient"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" />

1 0

[greatlrd] 27344: accpect pacth in bug 2314, with one smaller change the msvcrt20.def change was not accpect, it need more time for review. and we do not support __set_error in libcntpr. the patch are base on current strtoul, the strtoull are the long long version of strtoul. so he took current stroul and adpate it to long long. and also add missing error code. patch are done by Pierre Schweitzer email heis_spiter at hotmail.com See issue #2314 for more details.
by greatlrd＠svn.reactos.org 30 Jun '07

30 Jun '07

Author: greatlrd Date: Sat Jun 30 18:12:10 2007 New Revision: 27344 URL: http://svn.reactos.org/svn/reactos?rev=27344&view=rev Log: accpect pacth in bug 2314, with one smaller change the msvcrt20.def change was not accpect, it need more time for review. and we do not support __set_error in libcntpr. the patch are base on current strtoul, the strtoull are the long long version of strtoul. so he took current stroul and adpate it to long long. and also add missing error code. patch are done by Pierre Schweitzer email heis_spiter at hotmail.com See issue #2314 for more details. Modified: trunk/reactos/dll/ntdll/def/ntdll.def trunk/reactos/dll/win32/crtdll/crtdll.def trunk/reactos/dll/win32/msvcrt/msvcrt.def trunk/reactos/lib/sdk/libcntpr/libcntpr.rbuild trunk/reactos/lib/sdk/libcntpr/string/strtoul.c Modified: trunk/reactos/dll/ntdll/def/ntdll.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/def/ntdll.def?re… ============================================================================== --- trunk/reactos/dll/ntdll/def/ntdll.def (original) +++ trunk/reactos/dll/ntdll/def/ntdll.def Sat Jun 30 18:12:10 2007 @@ -1065,6 +1065,7 @@ strstr strtol strtoul +strtoull swprintf tan tolower Modified: trunk/reactos/dll/win32/crtdll/crtdll.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/crtdll/crtdll.de… ============================================================================== --- trunk/reactos/dll/win32/crtdll/crtdll.def (original) +++ trunk/reactos/dll/win32/crtdll/crtdll.def Sat Jun 30 18:12:10 2007 @@ -523,6 +523,7 @@ strtok strtol=NTDLL.strtol strtoul +strtoull strxfrm swprintf=crt_swprintf swscanf Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvcrt.de… ============================================================================== --- trunk/reactos/dll/win32/msvcrt/msvcrt.def (original) +++ trunk/reactos/dll/win32/msvcrt/msvcrt.def Sat Jun 30 18:12:10 2007 @@ -797,6 +797,7 @@ strtok strtol=NTDLL.strtol strtoul +strtoull strxfrm swprintf=crt_swprintf swscanf Modified: trunk/reactos/lib/sdk/libcntpr/libcntpr.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/libcntpr/libcntpr.… ============================================================================== --- trunk/reactos/lib/sdk/libcntpr/libcntpr.rbuild (original) +++ trunk/reactos/lib/sdk/libcntpr/libcntpr.rbuild Sat Jun 30 18:12:10 2007 @@ -137,6 +137,7 @@ <file>splitp.c</file> <file>strtol.c</file> <file>strtoul.c</file> + <file>strtoull.c</file> <file>wcstol.c</file> <file>wcstombs.c</file> <file>wcstoul.c</file> Modified: trunk/reactos/lib/sdk/libcntpr/string/strtoul.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/libcntpr/string/st… ============================================================================== --- trunk/reactos/lib/sdk/libcntpr/string/strtoul.c (original) +++ trunk/reactos/lib/sdk/libcntpr/string/strtoul.c Sat Jun 30 18:12:10 2007 @@ -1,6 +1,9 @@ +#include <stdio.h> #include <string.h> +#include <errno.h> #include <limits.h> #include <ctype.h> + /* * Convert a string to an unsigned long integer. @@ -64,6 +67,7 @@ if (any < 0) { acc = ULONG_MAX; + } else if (neg) acc = -acc;

1 0

[greatlrd] 27343: uodate rpc.h aganist trunk
by greatlrd＠svn.reactos.org 30 Jun '07

30 Jun '07

Author: greatlrd Date: Sat Jun 30 13:16:02 2007 New Revision: 27343 URL: http://svn.reactos.org/svn/reactos?rev=27343&view=rev Log: uodate rpc.h aganist trunk Modified: branches/ddk2003/include/ddk2003/rpc.h branches/ddk2003/include/psdk/rpc.h Modified: branches/ddk2003/include/ddk2003/rpc.h URL: http://svn.reactos.org/svn/reactos/branches/ddk2003/include/ddk2003/rpc.h?r… ============================================================================== --- branches/ddk2003/include/ddk2003/rpc.h (original) +++ branches/ddk2003/include/ddk2003/rpc.h Sat Jun 30 13:16:02 2007 @@ -3,6 +3,12 @@ #include <windows.h> #endif +#ifdef __GNUC__ + #ifndef _SEH_NO_NATIVE_NLG + /* FIXME ReactOS SEH support, we need remove this when gcc support native seh */ + #include <libs/pseh/pseh.h> + #endif +#endif #ifndef __RPC_H__ #define __RPC_H__ @@ -63,32 +69,26 @@ #define RPC_ENTRY #endif -#if !defined(DECLSPEC_IMPORT) - #if (defined(_M_MRX000) || defined(_M_IX86) || defined(_M_IA64) || defined(_M_AMD64)) && !defined(MIDL_PASS) - #define DECLSPEC_IMPORT __declspec(dllimport) + +#ifndef __GNUC__ + #if !defined(DECLSPEC_IMPORT) + #define DECLSPEC_IMPORT + #endif + + #if !defined(_RPCRT4_) + #define RPCRTAPI DECLSPEC_IMPORT #else - #define DECLSPEC_IMPORT + #define RPCRTAPI #endif -#endif -#if !defined(DECLSPEC_EXPORT) - #if (defined(_M_MRX000) || defined(_M_IX86) || defined(_M_IA64) || defined(_M_AMD64)) && !defined(MIDL_PASS) - #define DECLSPEC_EXPORT __declspec(dllexport) + #if !defined(_RPCNS4_) + #define RPCNSAPI DECLSPEC_IMPORT #else - #define DECLSPEC_EXPORT + #define RPCNSAPI #endif -#endif - -#if !defined(_RPCRT4_) - #define RPCRTAPI DECLSPEC_IMPORT #else - #define RPCRTAPI DECLSPEC_EXPORT -#endif - -#if !defined(_RPCNS4_) - #define RPCNSAPI DECLSPEC_IMPORT -#else - #define RPCNSAPI DECLSPEC_EXPORT + #define RPCRTAPI + #define RPCNSAPI #endif @@ -115,7 +115,7 @@ #include <poppack.h> #else #include <rpcdce.h> - #include <rpcnsi.h> + /* #include <rpcnsi.h> */ #include <rpcnterr.h> #include <excpt.h> #include <winerror.h> @@ -132,14 +132,31 @@ #else /* FIXME ReactOS SEH support, we need remove this when gcc support native seh */ - #define RpcTryExcept if (1) { - #define RpcExcept(expr) } else { - #define RpcEndExcept } - #define RpcTryFinally - #define RpcFinally - #define RpcEndFinally - #define RpcExceptionCode() 0 - /* #define RpcAbnormalTermination() abort() */ + #ifdef _SEH_NO_NATIVE_NLG + /* hack for _SEH_NO_NATIVE_NLG */ + #define RpcTryExcept if (1) { + #define RpcExcept(expr) } else { + #define RpcEndExcept } + #define RpcTryFinally + #define RpcFinally + #define RpcEndFinally + #define RpcExceptionCode() 0 + #else + #define RpcTryExcept _SEH_TRY { + #define RpcExcept(expr) } _SEH_HANDLE { \ + if (expr) \ + { + #define RpcEndExcept } \ + } \ + _SEH_END; + + #define RpcTryFinally _SEH_TRY { + #define RpcFinally } _SEH_HANDLE { + #define RpcEndFinally } _SEH_END; + #define RpcExceptionCode() _SEH_GetExceptionCode() + + /* #define RpcAbnormalTermination() abort() */ + #endif #endif #endif @@ -153,3 +170,4 @@ #endif + Modified: branches/ddk2003/include/psdk/rpc.h URL: http://svn.reactos.org/svn/reactos/branches/ddk2003/include/psdk/rpc.h?rev=… ============================================================================== --- branches/ddk2003/include/psdk/rpc.h (original) +++ branches/ddk2003/include/psdk/rpc.h Sat Jun 30 13:16:02 2007 @@ -3,6 +3,12 @@ #include <windows.h> #endif +#ifdef __GNUC__ + #ifndef _SEH_NO_NATIVE_NLG + /* FIXME ReactOS SEH support, we need remove this when gcc support native seh */ + #include <libs/pseh/pseh.h> + #endif +#endif #ifndef __RPC_H__ #define __RPC_H__ @@ -63,32 +69,26 @@ #define RPC_ENTRY #endif -#if !defined(DECLSPEC_IMPORT) - #if (defined(_M_MRX000) || defined(_M_IX86) || defined(_M_IA64) || defined(_M_AMD64)) && !defined(MIDL_PASS) - #define DECLSPEC_IMPORT __declspec(dllimport) + +#ifndef __GNUC__ + #if !defined(DECLSPEC_IMPORT) + #define DECLSPEC_IMPORT + #endif + + #if !defined(_RPCRT4_) + #define RPCRTAPI DECLSPEC_IMPORT #else - #define DECLSPEC_IMPORT + #define RPCRTAPI #endif -#endif -#if !defined(DECLSPEC_EXPORT) - #if (defined(_M_MRX000) || defined(_M_IX86) || defined(_M_IA64) || defined(_M_AMD64)) && !defined(MIDL_PASS) - #define DECLSPEC_EXPORT __declspec(dllexport) + #if !defined(_RPCNS4_) + #define RPCNSAPI DECLSPEC_IMPORT #else - #define DECLSPEC_EXPORT + #define RPCNSAPI #endif -#endif - -#if !defined(_RPCRT4_) - #define RPCRTAPI DECLSPEC_IMPORT #else - #define RPCRTAPI DECLSPEC_EXPORT -#endif - -#if !defined(_RPCNS4_) - #define RPCNSAPI DECLSPEC_IMPORT -#else - #define RPCNSAPI DECLSPEC_EXPORT + #define RPCRTAPI + #define RPCNSAPI #endif @@ -115,7 +115,7 @@ #include <poppack.h> #else #include <rpcdce.h> - #include <rpcnsi.h> + /* #include <rpcnsi.h> */ #include <rpcnterr.h> #include <excpt.h> #include <winerror.h> @@ -132,14 +132,31 @@ #else /* FIXME ReactOS SEH support, we need remove this when gcc support native seh */ - #define RpcTryExcept if (1) { - #define RpcExcept(expr) } else { - #define RpcEndExcept } - #define RpcTryFinally - #define RpcFinally - #define RpcEndFinally - #define RpcExceptionCode() 0 - /* #define RpcAbnormalTermination() abort() */ + #ifdef _SEH_NO_NATIVE_NLG + /* hack for _SEH_NO_NATIVE_NLG */ + #define RpcTryExcept if (1) { + #define RpcExcept(expr) } else { + #define RpcEndExcept } + #define RpcTryFinally + #define RpcFinally + #define RpcEndFinally + #define RpcExceptionCode() 0 + #else + #define RpcTryExcept _SEH_TRY { + #define RpcExcept(expr) } _SEH_HANDLE { \ + if (expr) \ + { + #define RpcEndExcept } \ + } \ + _SEH_END; + + #define RpcTryFinally _SEH_TRY { + #define RpcFinally } _SEH_HANDLE { + #define RpcEndFinally } _SEH_END; + #define RpcExceptionCode() _SEH_GetExceptionCode() + + /* #define RpcAbnormalTermination() abort() */ + #endif #endif #endif @@ -153,3 +170,4 @@ #endif +

1 0

[greatlrd] 27342: part 7 of 7 at last removing wine hack, that disable seh in rpc.h we have now seh activate in rpcrt4 and some other idl stuff as well, they where complete hacked to be offline, in wine header, I reworte the header and move some prototype to right header.
by greatlrd＠svn.reactos.org 30 Jun '07

30 Jun '07

Author: greatlrd Date: Sat Jun 30 04:33:38 2007 New Revision: 27342 URL: http://svn.reactos.org/svn/reactos?rev=27342&view=rev Log: part 7 of 7 at last removing wine hack, that disable seh in rpc.h we have now seh activate in rpcrt4 and some other idl stuff as well, they where complete hacked to be offline, in wine header, I reworte the header and move some prototype to right header. Modified: trunk/reactos/dll/win32/advapi32/advapi32.rbuild trunk/reactos/dll/win32/lsasrv/lsasrv.rbuild trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild trunk/reactos/dll/win32/setupapi/setupapi.rbuild trunk/reactos/drivers/video/videoprt/dispatch.c trunk/reactos/include/psdk/rpc.h trunk/reactos/include/psdk/rpcdce.h trunk/reactos/include/psdk/rpcndr.h trunk/reactos/include/reactos/idl/eventlogrpc.idl trunk/reactos/include/reactos/idl/idl.rbuild Modified: trunk/reactos/dll/win32/advapi32/advapi32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/advapi3… ============================================================================== --- trunk/reactos/dll/win32/advapi32/advapi32.rbuild (original) +++ trunk/reactos/dll/win32/advapi32/advapi32.rbuild Sat Jun 30 04:33:38 2007 @@ -1,4 +1,5 @@ -<module name="advapi32" type="win32dll" baseaddress="${BASEADDRESS_ADVAPI32}" installbase="system32" installname="advapi32.dll"> +<module name="advapi32" type="win32dll" baseaddress="${BASEADDRESS_ADVAPI32}" installbase="system32" installname="advapi32.dll" allowwarnings ="true"> + <importlibrary definition="advapi32.def" /> <include base="advapi32">.</include> <include base="scm_client">.</include> @@ -15,6 +16,7 @@ <library>rpcrt4</library> <library>wine</library> <library>kernel32</library> + <library>pseh</library> <pch>advapi32.h</pch> <directory name="crypt"> <file>crypt.c</file> Modified: trunk/reactos/dll/win32/lsasrv/lsasrv.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/lsasrv.rb… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/lsasrv.rbuild (original) +++ trunk/reactos/dll/win32/lsasrv/lsasrv.rbuild Sat Jun 30 04:33:38 2007 @@ -13,6 +13,7 @@ <library>ntdll</library> <library>kernel32</library> <library>rpcrt4</library> + <library>pseh</library> <file>lsarpc.c</file> <file>lsasrv.c</file> <file>lsasrv.rc</file> Modified: trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/oleaut3… ============================================================================== --- trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild (original) +++ trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild Sat Jun 30 04:33:38 2007 @@ -20,6 +20,7 @@ <library>comctl32</library> <library>urlmon</library> <library>uuid</library> + <library>pseh</library> <file>connpt.c</file> <file>dispatch.c</file> <file>hash.c</file> Modified: trunk/reactos/dll/win32/setupapi/setupapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/setupap… ============================================================================== --- trunk/reactos/dll/win32/setupapi/setupapi.rbuild (original) +++ trunk/reactos/dll/win32/setupapi/setupapi.rbuild Sat Jun 30 04:33:38 2007 @@ -24,6 +24,7 @@ <library>rpcrt4</library> <library>version</library> <library>shell32</library> + <library>pseh</library> <file>cfgmgr.c</file> <file>devclass.c</file> <file>devinst.c</file> Modified: trunk/reactos/drivers/video/videoprt/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/videoprt/dis… ============================================================================== --- trunk/reactos/drivers/video/videoprt/dispatch.c (original) +++ trunk/reactos/drivers/video/videoprt/dispatch.c Sat Jun 30 04:33:38 2007 @@ -110,6 +110,8 @@ PVIDEO_PORT_DRIVER_EXTENSION DriverExtension; DPRINT("IntVideoPortDispatchOpen\n"); + + ASSERT(Irp != NULL); if (CsrssInitialized == FALSE) { Modified: trunk/reactos/include/psdk/rpc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/rpc.h?rev=273… ============================================================================== --- trunk/reactos/include/psdk/rpc.h (original) +++ trunk/reactos/include/psdk/rpc.h Sat Jun 30 04:33:38 2007 @@ -1,74 +1,173 @@ -/* - * RPC interface - * - * Copyright (C) the Wine project - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - */ -#ifndef RPC_NO_WINDOWS_H -# ifdef __WINESRC__ -# include <windef.h> -# else -# include <windows.h> -# endif +#if !defined( RPC_NO_WINDOWS_H ) && !defined( MAC ) && !defined( _MAC ) +#include <windows.h> #endif -#ifndef __WINE_RPC_H -#define __WINE_RPC_H +#ifdef __GNUC__ + #ifndef _SEH_NO_NATIVE_NLG + /* FIXME ReactOS SEH support, we need remove this when gcc support native seh */ + #include <libs/pseh/pseh.h> + #endif +#endif -#if defined(__powerpc__) || defined(_MAC) /* ? */ -# define __RPC_MAC__ - /* Also define __RPC_WIN32__ to ensure compatibility */ -# define __RPC_WIN32__ -#elif defined(_WIN64) -# define __RPC_WIN64__ -#else -# define __RPC_WIN32__ +#ifndef __RPC_H__ +#define __RPC_H__ + +#if _MSC_VER > 1000 +#pragma once +#endif + + +#ifdef __cplusplus +extern "C" { +#endif + +#if defined( MAC ) || defined( _MAC ) || defined(__powerpc__) + #define __RPC_MAC__ + #define __RPC_WIN32__ + #include <pshpack2.h> + +#else + #if defined(_M_IA64) || defined(_M_AMD64) || defined(_WIN64) + #define __RPC_WIN64__ + #else + #define __RPC_WIN32__ + #endif #endif #include <basetsd.h> +#if defined(__RPC_WIN64__) + #include <pshpack8.h> +#endif + +#ifndef __MIDL_USER_DEFINED + #define midl_user_allocate MIDL_user_allocate + #define midl_user_free MIDL_user_free + #define __MIDL_USER_DEFINED +#endif + + +typedef void * I_RPC_HANDLE; +typedef long RPC_STATUS; #define __RPC_FAR -#define __RPC_API __stdcall -#define __RPC_USER __stdcall -#define __RPC_STUB __stdcall -#define RPC_ENTRY __stdcall -#define RPCRTAPI -typedef long RPC_STATUS; -typedef void* I_RPC_HANDLE; +#if defined(__RPC_WIN32__) || defined(__RPC_WIN64__) + #define RPC_UNICODE_SUPPORTED +#endif -#include <rpcdce.h> -/* #include <rpcnsi.h> */ -#include <rpcnterr.h> -#include <excpt.h> -#include <winerror.h> -/* ignore exception handling for now */ -#define RpcTryExcept if (1) { -#define RpcExcept(expr) } else { -#define RpcEndExcept } -#define RpcTryFinally -#define RpcFinally -#define RpcEndFinally -#define RpcExceptionCode() 0 -/* #define RpcAbnormalTermination() abort() */ +#if !defined(__RPC_MAC__) + #define __RPC_API __stdcall + #define __RPC_USER __stdcall + #define __RPC_STUB __stdcall + #define RPC_ENTRY __stdcall +#else + #define __RPC_API + #define __RPC_USER + #define __RPC_STUB + #define RPC_ENTRY +#endif -RPC_STATUS RPC_ENTRY RpcImpersonateClient(RPC_BINDING_HANDLE); -RPC_STATUS RPC_ENTRY RpcRevertToSelf(void); -DWORD WINAPI I_RpcMapWin32Status(RPC_STATUS status); -#endif /*__WINE_RPC_H */ +#ifndef __GNUC__ + #if !defined(DECLSPEC_IMPORT) + #define DECLSPEC_IMPORT + #endif + + #if !defined(_RPCRT4_) + #define RPCRTAPI DECLSPEC_IMPORT + #else + #define RPCRTAPI + #endif + + #if !defined(_RPCNS4_) + #define RPCNSAPI DECLSPEC_IMPORT + #else + #define RPCNSAPI + #endif +#else + #define RPCRTAPI + #define RPCNSAPI +#endif + + +#ifdef __RPC_MAC__ + #include <setjmp.h> + #define RPCXCWORD (sizeof(jmp_buf)/sizeof(int)) + + #pragma warning(push) + #pragma warning( disable: 4005 ) + #include <rpcdce.h> + #include <rpcnsi.h> + #include <rpcerr.h> + #include <rpcmac.h> + #pragma warning(pop) + + typedef void (RPC_ENTRY *MACYIELDCALLBACK)(short *) ; + RPC_STATUS RPC_ENTRY + RpcMacSetYieldInfo(MACYIELDCALLBACK pfnCallback) ; + + #if !defined(UNALIGNED) + #define UNALIGNED + #endif + + #include <poppack.h> +#else + #include <rpcdce.h> + /* #include <rpcnsi.h> */ + #include <rpcnterr.h> + #include <excpt.h> + #include <winerror.h> + + #ifndef __GNUC__ + #define RpcTryExcept __try { + #define RpcExcept(expr) } __except (expr) { + #define RpcEndExcept } + #define RpcTryFinally __try { + #define RpcFinally } __finally { + #define RpcEndFinally } + #define RpcExceptionCode() GetExceptionCode() + #define RpcAbnormalTermination() AbnormalTermination() + #else + /* FIXME ReactOS SEH support, we need remove this when gcc support native seh */ + + #ifdef _SEH_NO_NATIVE_NLG + /* hack for _SEH_NO_NATIVE_NLG */ + #define RpcTryExcept if (1) { + #define RpcExcept(expr) } else { + #define RpcEndExcept } + #define RpcTryFinally + #define RpcFinally + #define RpcEndFinally + #define RpcExceptionCode() 0 + #else + #define RpcTryExcept _SEH_TRY { + #define RpcExcept(expr) } _SEH_HANDLE { \ + if (expr) \ + { + #define RpcEndExcept } \ + } \ + _SEH_END; + + #define RpcTryFinally _SEH_TRY { + #define RpcFinally } _SEH_HANDLE { + #define RpcEndFinally } _SEH_END; + #define RpcExceptionCode() _SEH_GetExceptionCode() + + /* #define RpcAbnormalTermination() abort() */ + #endif + #endif +#endif + +#if defined(__RPC_WIN64__) + #include <poppack.h> +#endif + +#ifdef __cplusplus +} +#endif + +#endif + + Modified: trunk/reactos/include/psdk/rpcdce.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/rpcdce.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/rpcdce.h (original) +++ trunk/reactos/include/psdk/rpcdce.h Sat Jun 30 04:33:38 2007 @@ -504,6 +504,13 @@ RPCRTAPI int RPC_ENTRY UuidIsNil( UUID* Uuid, RPC_STATUS* Status_ ); + +RPCRTAPI RPC_STATUS RPC_ENTRY +RpcImpersonateClient (IN RPC_BINDING_HANDLE BindingHandle OPTIONAL); + +RPCRTAPI RPC_STATUS RPC_ENTRY +RpcRevertToSelf (); + #ifdef __cplusplus } #endif Modified: trunk/reactos/include/psdk/rpcndr.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/rpcndr.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/rpcndr.h (original) +++ trunk/reactos/include/psdk/rpcndr.h Sat Jun 30 04:33:38 2007 @@ -651,6 +651,13 @@ RPCRTAPI void RPC_ENTRY NdrRpcSsDefaultFree( void *NodeToFree ); + +#define RPC_BAD_STUB_DATA_EXCEPTION_FILTER \ + ( (RpcExceptionCode() == STATUS_ACCESS_VIOLATION) || \ + (RpcExceptionCode() == STATUS_DATATYPE_MISALIGNMENT) || \ + (RpcExceptionCode() == RPC_X_BAD_STUB_DATA) || \ + (RpcExceptionCode() == RPC_S_INVALID_BOUND) ) + #ifdef __cplusplus } #endif Modified: trunk/reactos/include/reactos/idl/eventlogrpc.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/idl/eventl… ============================================================================== --- trunk/reactos/include/reactos/idl/eventlogrpc.idl (original) +++ trunk/reactos/include/reactos/idl/eventlogrpc.idl Sat Jun 30 04:33:38 2007 @@ -16,6 +16,8 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ + + #ifdef __midl [ @@ -26,6 +28,12 @@ interface eventlog { + cpp_quote("#ifdef __GNUC__") + cpp_quote("/* FIXME ReactOS SEH support, we need remove this when gcc support native seh */") + cpp_quote("#include <pseh/pseh.h>") + cpp_quote("#endif") + + cpp_quote("#define RPC_ENABLED") cpp_quote("#if 0") typedef [handle, unique] wchar_t *LPWSTR; @@ -221,7 +229,10 @@ } #else - + cpp_quote("#ifdef __GNUC__") + cpp_quote("/* FIXME ReactOS SEH support, we need remove this when gcc support native seh */") + cpp_quote("#include <pseh/pseh.h>") + cpp_quote("#endif") [ uuid(82273FDC-E32A-18C3-3F78-827929DC23EA), Modified: trunk/reactos/include/reactos/idl/idl.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/idl/idl.rb… ============================================================================== --- trunk/reactos/include/reactos/idl/idl.rbuild (original) +++ trunk/reactos/include/reactos/idl/idl.rbuild Sat Jun 30 04:33:38 2007 @@ -1,23 +1,23 @@ <group> -<module name="pnp_server" type="rpcserver"> +<module name="pnp_server" type="rpcserver" allowwarnings ="true"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> <file>pnp.idl</file> </module> -<module name="pnp_client" type="rpcclient"> +<module name="pnp_client" type="rpcclient" allowwarnings ="true"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> <file>pnp.idl</file> </module> -<module name="scm_server" type="rpcserver"> +<module name="scm_server" type="rpcserver" allowwarnings ="true"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> <file switches="--oldnames">svcctl.idl</file> </module> -<module name="scm_client" type="rpcclient"> +<module name="scm_client" type="rpcclient" allowwarnings ="true"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> @@ -29,19 +29,19 @@ <define name="_X86_" /> <file switches="--oldnames">eventlogrpc.idl</file> </module> -<module name="eventlog_client" type="rpcclient"> +<module name="eventlog_client" type="rpcclient" > <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> <file switches="--oldnames">eventlogrpc.idl</file> </module> -<module name="lsa_server" type="rpcserver"> +<module name="lsa_server" type="rpcserver" allowwarnings ="true"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" /> <file switches="--oldnames">lsa.idl</file> </module> -<module name="lsa_client" type="rpcclient"> +<module name="lsa_client" type="rpcclient" allowwarnings ="true"> <include base="ReactOS">.</include> <include base="ReactOS">w32api/include</include> <define name="_X86_" />

1 0

[weiden] 27341: Create the named pipe with R/W access for everyone. This enables VMware running without administrative privileges to connect to the service.
by weiden＠svn.reactos.org 29 Jun '07

29 Jun '07

Author: weiden Date: Sat Jun 30 01:43:18 2007 New Revision: 27341 URL: http://svn.reactos.org/svn/reactos?rev=27341&view=rev Log: Create the named pipe with R/W access for everyone. This enables VMware running without administrative privileges to connect to the service. Modified: trunk/tools/vmwaregateway/vmwaregateway.cpp Modified: trunk/tools/vmwaregateway/vmwaregateway.cpp URL: http://svn.reactos.org/svn/reactos/trunk/tools/vmwaregateway/vmwaregateway.… ============================================================================== --- trunk/tools/vmwaregateway/vmwaregateway.cpp (original) +++ trunk/tools/vmwaregateway/vmwaregateway.cpp Sat Jun 30 01:43:18 2007 @@ -36,11 +36,160 @@ // verbose output - traces a lot BOOL verbose = FALSE; +PSECURITY_DESCRIPTOR +CreateVmwareGatewaySD(VOID) +{ + static SID_IDENTIFIER_AUTHORITY LocalSystemAuthority = {SECURITY_NT_AUTHORITY}; + static SID_IDENTIFIER_AUTHORITY WorldAuthority = {SECURITY_WORLD_SID_AUTHORITY}; + PSID LocalSystemSid = NULL; + PSID AdministratorsSid = NULL; + PSID EveryoneSid = NULL; + PACL Dacl; + DWORD DaclSize; + PSECURITY_DESCRIPTOR pSD = NULL; + + /* create the SYSTEM, Administrators and Everyone SIDs */ + if (!AllocateAndInitializeSid(&LocalSystemAuthority, + 1, + SECURITY_LOCAL_SYSTEM_RID, + 0, + 0, + 0, + 0, + 0, + 0, + 0, + &LocalSystemSid) || + !AllocateAndInitializeSid(&LocalSystemAuthority, + 2, + SECURITY_BUILTIN_DOMAIN_RID, + DOMAIN_ALIAS_RID_ADMINS, + 0, + 0, + 0, + 0, + 0, + 0, + &AdministratorsSid) || + !AllocateAndInitializeSid(&WorldAuthority, + 1, + SECURITY_WORLD_RID, + 0, + 0, + 0, + 0, + 0, + 0, + 0, + &EveryoneSid)) + { + printf("Failed initializing the SIDs for the default security descriptor (0x%p, 0x%p, 0x%p)\n", + LocalSystemSid, AdministratorsSid, EveryoneSid); + goto Cleanup; + } + + /* allocate the security descriptor and DACL */ + DaclSize = sizeof(ACL) + + ((GetLengthSid(LocalSystemSid) + + GetLengthSid(AdministratorsSid) + + GetLengthSid(EveryoneSid)) + + (3 * FIELD_OFFSET(ACCESS_ALLOWED_ACE, + SidStart))); + + pSD = (PSECURITY_DESCRIPTOR)LocalAlloc(LMEM_FIXED, + (SIZE_T)DaclSize + sizeof(SECURITY_DESCRIPTOR)); + if (pSD == NULL) + { + printf("Failed to allocate the default security descriptor and ACL\n"); + goto Cleanup; + } + + if (!InitializeSecurityDescriptor(pSD, + SECURITY_DESCRIPTOR_REVISION)) + { + printf("Failed to initialize the default security descriptor\n"); + goto Cleanup; + } + + /* initialize and build the DACL */ + Dacl = (PACL)((ULONG_PTR)pSD + sizeof(SECURITY_DESCRIPTOR)); + if (!InitializeAcl(Dacl, + (DWORD)DaclSize, + ACL_REVISION)) + { + printf("Failed to initialize the DACL of the default security descriptor\n"); + goto Cleanup; + } + + /* add the SYSTEM Ace */ + if (!AddAccessAllowedAce(Dacl, + ACL_REVISION, + FILE_GENERIC_READ | FILE_GENERIC_WRITE | FILE_GENERIC_EXECUTE, + LocalSystemSid)) + { + printf("Failed to add the SYSTEM ACE\n"); + goto Cleanup; + } + + /* add the Administrators Ace */ + if (!AddAccessAllowedAce(Dacl, + ACL_REVISION, + FILE_GENERIC_READ | FILE_GENERIC_WRITE | FILE_GENERIC_EXECUTE, + AdministratorsSid)) + { + printf("Failed to add the Administrators ACE\n"); + goto Cleanup; + } + + /* add the Everyone Ace */ + if (!AddAccessAllowedAce(Dacl, + ACL_REVISION, + FILE_GENERIC_READ | FILE_GENERIC_WRITE | FILE_GENERIC_EXECUTE, + EveryoneSid)) + { + printf("Failed to add the Everyone ACE\n"); + goto Cleanup; + } + + /* set the DACL */ + if (!SetSecurityDescriptorDacl(pSD, + TRUE, + Dacl, + FALSE)) + { + printf("Failed to set the DACL of the default security descriptor\n"); + +Cleanup: + if (pSD != NULL) + { + LocalFree((HLOCAL)pSD); + pSD = NULL; + } + } + + if (LocalSystemSid != NULL) + { + FreeSid(LocalSystemSid); + } + if (AdministratorsSid != NULL) + { + FreeSid(AdministratorsSid); + } + if (EveryoneSid != NULL) + { + FreeSid(EveryoneSid); + } + + return pSD; +} + // the central server loop void Server() { WORD wVersionRequested; WSADATA wsaData; + PSECURITY_DESCRIPTOR sd; + SECURITY_ATTRIBUTES sa; wVersionRequested = MAKEWORD( 2, 2 ); // socket and pipe handles @@ -69,6 +218,12 @@ return; } + // create a suitable security descriptor + sd = CreateVmwareGatewaySD(); + sa.nLength = sizeof(sa); + sa.lpSecurityDescriptor = sd; + sa.bInheritHandle = FALSE; + // first create the named pipe pipe = CreateNamedPipe(PIPE_NAME, PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED, @@ -77,7 +232,9 @@ 100, 100, NMPWAIT_WAIT_FOREVER, - NULL); + &sa); + if (sd != NULL) + LocalFree((HLOCAL)sd); if (pipe == INVALID_HANDLE_VALUE) { printf("Could not create named pipe (%d)\n", GetLastError());

1 0

[fireball] 27340: - Create a branch for an ongoing ReactX work by Magnus Olsen (GreatLord).
by fireball＠svn.reactos.org 29 Jun '07

29 Jun '07

Author: fireball Date: Sat Jun 30 00:51:06 2007 New Revision: 27340 URL: http://svn.reactos.org/svn/reactos?rev=27340&view=rev Log: - Create a branch for an ongoing ReactX work by Magnus Olsen (GreatLord). Added: branches/reactx/ - copied from r27339, trunk/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2007