Ros-diffs July 2007

ros-diffs@reactos.org

20 participants
707 discussions

[weiden] 27959: Make the prototypes match those defined in the .idl files
by weiden＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: weiden Date: Sat Jul 28 22:06:51 2007 New Revision: 27959 URL: http://svn.reactos.org/svn/reactos?rev=27959&view=rev Log: Make the prototypes match those defined in the .idl files Modified: trunk/reactos/base/services/umpnpmgr/umpnpmgr.c Modified: trunk/reactos/base/services/umpnpmgr/umpnpmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/umpnpmgr/ump… ============================================================================== --- trunk/reactos/base/services/umpnpmgr/umpnpmgr.c (original) +++ trunk/reactos/base/services/umpnpmgr/umpnpmgr.c Sat Jul 28 22:06:51 2007 @@ -881,7 +881,7 @@ WCHAR szKeyName[MAX_PATH]; CONFIGRET ret = CR_SUCCESS; HKEY hKey = NULL; - ULONG ulSize; + DWORD dwSize; UNREFERENCED_PARAMETER(BindingHandle); UNREFERENCED_PARAMETER(Flags); @@ -901,20 +901,20 @@ &hKey)) return CR_REGISTRY_ERROR; - ulSize = *Length * sizeof(WCHAR); + dwSize = *Length * sizeof(WCHAR); if (RegQueryValueExW(hKey, L"Class", NULL, NULL, (LPBYTE)Buffer, - &ulSize)) + &dwSize)) { *Length = 0; ret = CR_REGISTRY_ERROR; } else { - *Length = ulSize / sizeof(WCHAR); + *Length = dwSize / sizeof(WCHAR); } RegCloseKey(hKey); @@ -1345,9 +1345,9 @@ CONFIGRET PNP_AddEmptyLogConf(handle_t BindingHandle, wchar_t *DeviceInstance, - ULONG ulPriority, - ULONG *pulLogConfTag, - ULONG ulFlags) + unsigned long ulPriority, + unsigned long *pulLogConfTag, + unsigned long ulFlags) { CONFIGRET ret = CR_SUCCESS; @@ -1370,9 +1370,9 @@ CONFIGRET PNP_FreeLogConf(handle_t BindingHandle, wchar_t *DeviceInstance, - ULONG ulType, - ULONG ulLogConfTag, - ULONG ulFlags) + unsigned long ulType, + unsigned long ulLogConfTag, + unsigned long ulFlags) { CONFIGRET ret = CR_SUCCESS; @@ -1395,9 +1395,9 @@ CONFIGRET PNP_GetFirstLogConf(handle_t BindingHandle, wchar_t *DeviceInstance, - ULONG ulPriority, - ULONG *pulLogConfTag, - ULONG ulFlags) + unsigned long ulPriority, + unsigned long *pulLogConfTag, + unsigned long ulFlags) { CONFIGRET ret = CR_SUCCESS; @@ -1420,10 +1420,10 @@ CONFIGRET PNP_GetNextLogConf(handle_t BindingHandle, wchar_t *DeviceInstance, - ULONG ulLogConfType, - ULONG ulCurrentTag, - ULONG *pulNextTag, - ULONG ulFlags) + unsigned long ulLogConfType, + unsigned long ulCurrentTag, + unsigned long *pulNextTag, + unsigned long ulFlags) { CONFIGRET ret = CR_SUCCESS; @@ -1447,10 +1447,10 @@ CONFIGRET PNP_GetLogConfPriority(handle_t BindingHandle, wchar_t *DeviceInstance, - ULONG ulLogConfType, - ULONG ulCurrentTag, - ULONG *pPriority, - ULONG ulFlags) + unsigned long ulLogConfType, + unsigned long ulCurrentTag, + unsigned long *pPriority, + unsigned long ulFlags) { CONFIGRET ret = CR_SUCCESS;

1 0

[weiden] 27958: Fix definition of DbgPrint to be compatible
by weiden＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: weiden Date: Sat Jul 28 22:03:17 2007 New Revision: 27958 URL: http://svn.reactos.org/svn/reactos?rev=27958&view=rev Log: Fix definition of DbgPrint to be compatible Modified: trunk/reactos/include/reactos/wine/debug.h Modified: trunk/reactos/include/reactos/wine/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/wine/debug… ============================================================================== --- trunk/reactos/include/reactos/wine/debug.h (original) +++ trunk/reactos/include/reactos/wine/debug.h Sat Jul 28 22:03:17 2007 @@ -25,7 +25,7 @@ #define inline __inline #endif -unsigned long DbgPrint(const char *Format,...); +ULONG DbgPrint(const char *Format,...); struct _GUID;

1 0

[weiden] 27957: Fix incompatible pointer types
by weiden＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: weiden Date: Sat Jul 28 22:01:30 2007 New Revision: 27957 URL: http://svn.reactos.org/svn/reactos?rev=27957&view=rev Log: Fix incompatible pointer types Modified: trunk/reactos/base/applications/taskmgr/perfdata.c Modified: trunk/reactos/base/applications/taskmgr/perfdata.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/perfdata.c (original) +++ trunk/reactos/base/applications/taskmgr/perfdata.c Sat Jul 28 22:01:30 2007 @@ -88,7 +88,7 @@ void PerfDataRefresh(void) { - ULONG ulSize; + SIZE_T ulSize; NTSTATUS status; LPBYTE pBuffer; ULONG BufferSize;

1 0

[weiden] 27956: Fix return types
by weiden＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: weiden Date: Sat Jul 28 21:55:58 2007 New Revision: 27956 URL: http://svn.reactos.org/svn/reactos?rev=27956&view=rev Log: Fix return types Modified: trunk/reactos/lib/3rdparty/mingw/crt1.c trunk/reactos/lib/3rdparty/mingw/wcrt1.c Modified: trunk/reactos/lib/3rdparty/mingw/crt1.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/mingw/crt1.c?… ============================================================================== --- trunk/reactos/lib/3rdparty/mingw/crt1.c (original) +++ trunk/reactos/lib/3rdparty/mingw/crt1.c Sat Jul 28 21:55:58 2007 @@ -98,11 +98,11 @@ /* This function will be called when a trap occurs. Thanks to Jacob Navia for his contribution. */ -static CALLBACK long +static LONG CALLBACK _gnu_exception_handler (EXCEPTION_POINTERS * exception_data) { void (*old_handler) (int); - long action = EXCEPTION_CONTINUE_SEARCH; + LONG action = EXCEPTION_CONTINUE_SEARCH; int reset_fpu = 0; switch (exception_data->ExceptionRecord->ExceptionCode) Modified: trunk/reactos/lib/3rdparty/mingw/wcrt1.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/mingw/wcrt1.c… ============================================================================== --- trunk/reactos/lib/3rdparty/mingw/wcrt1.c (original) +++ trunk/reactos/lib/3rdparty/mingw/wcrt1.c Sat Jul 28 21:55:58 2007 @@ -99,11 +99,11 @@ /* This function will be called when a trap occurs. Thanks to Jacob Navia for his contribution. */ -static CALLBACK long +static LONG CALLBACK _gnu_exception_handler (EXCEPTION_POINTERS * exception_data) { void (*old_handler) (int); - long action = EXCEPTION_CONTINUE_SEARCH; + LONG action = EXCEPTION_CONTINUE_SEARCH; int reset_fpu = 0; switch (exception_data->ExceptionRecord->ExceptionCode)

1 0

[janderwald] 27955: - fix cmd not to crash when just typing "start" [enter] See issue #2294 for more details.
by janderwald＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: janderwald Date: Sat Jul 28 21:48:23 2007 New Revision: 27955 URL: http://svn.reactos.org/svn/reactos?rev=27955&view=rev Log: - fix cmd not to crash when just typing "start" [enter] See issue #2294 for more details. Modified: trunk/reactos/base/shell/cmd/start.c Modified: trunk/reactos/base/shell/cmd/start.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/start.c?rev… ============================================================================== --- trunk/reactos/base/shell/cmd/start.c (original) +++ trunk/reactos/base/shell/cmd/start.c Sat Jul 28 21:48:23 2007 @@ -97,7 +97,7 @@ return 1; } SetLastError(0); - size = GetEnvironmentVariable (_T("COMSPEC"), comspec, 512); + size = GetEnvironmentVariable (_T("COMSPEC"), comspec, MAX_PATH); if(GetLastError() == ERROR_ENVVAR_NOT_FOUND) { RestWithoutArgs[0] = _T('c'); @@ -127,7 +127,7 @@ _tcscat(RestWithoutArgs,_T("\"")); } - rest = malloc ( _tcslen(RestWithoutArgs) + 1 * sizeof(TCHAR)); + rest = malloc ( (_tcslen(RestWithoutArgs) + 1) * sizeof(TCHAR)); if (rest == NULL) { if(comspec != NULL) @@ -136,7 +136,7 @@ return 1; } - param =malloc ( _tcslen(RestWithoutArgs) + 1 * sizeof(TCHAR)); + param =malloc ( (_tcslen(RestWithoutArgs) + 1) * sizeof(TCHAR)); if (rest == NULL) { if(comspec != NULL)

1 0

[weiden] 27954: Remove duplicate definition of SHChangeNotification_Lock
by weiden＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: weiden Date: Sat Jul 28 21:47:49 2007 New Revision: 27954 URL: http://svn.reactos.org/svn/reactos?rev=27954&view=rev Log: Remove duplicate definition of SHChangeNotification_Lock Modified: trunk/reactos/include/psdk/shlobj.h Modified: trunk/reactos/include/psdk/shlobj.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/shlobj.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/shlobj.h (original) +++ trunk/reactos/include/psdk/shlobj.h Sat Jul 28 21:47:49 2007 @@ -1105,8 +1105,6 @@ ULONG WINAPI SHChangeNotifyRegister(HWND hwnd, int fSources, LONG fEvents, UINT wMsg, int cEntries, SHChangeNotifyEntry *pshcne); BOOL WINAPI SHChangeNotifyDeregister(ULONG ulID); -HANDLE WINAPI SHChangeNotification_Lock(HANDLE hChangeNotification, DWORD dwProcessId, - LPITEMIDLIST **pppidl, LONG *plEvent); BOOL WINAPI SHChangeNotification_Unlock(HANDLE hLock); HRESULT WINAPI SHGetRealIDL(IShellFolder *psf, LPCITEMIDLIST pidlSimple, LPITEMIDLIST * ppidlReal);

1 0

[weiden] 27953: Fix warnings with -O3
by weiden＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: weiden Date: Sat Jul 28 21:44:39 2007 New Revision: 27953 URL: http://svn.reactos.org/svn/reactos?rev=27953&view=rev Log: Fix warnings with -O3 Modified: trunk/reactos/base/applications/network/arp/arp.c Modified: trunk/reactos/base/applications/network/arp/arp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/arp/arp.c (original) +++ trunk/reactos/base/applications/network/arp/arp.c Sat Jul 28 21:44:39 2007 @@ -153,7 +153,7 @@ UINT i, k; PMIB_IPNETTABLE pIpNetTable = NULL; PMIB_IPADDRTABLE pIpAddrTable = NULL; - DWORD Size = 0; + ULONG Size = 0; struct in_addr inaddr, inaddr2; PTCHAR pszIpAddr; TCHAR szIntIpAddr[20]; @@ -413,7 +413,7 @@ { PMIB_IPNETROW pDelHost = NULL; PMIB_IPNETTABLE pIpNetTable = NULL; - DWORD Size = 0; + ULONG Size = 0; DWORD dwIpAddr = 0; INT iRet; BOOL bFlushTable = FALSE;

1 0

[weiden] 27952: Correctly calculate message time. Fixes slow clicks being interpreted as double clicks. See issue #2238 for more details.
by weiden＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: weiden Date: Sat Jul 28 21:16:51 2007 New Revision: 27952 URL: http://svn.reactos.org/svn/reactos?rev=27952&view=rev Log: Correctly calculate message time. Fixes slow clicks being interpreted as double clicks. See issue #2238 for more details. Modified: trunk/reactos/subsystems/win32/win32k/include/msgqueue.h trunk/reactos/subsystems/win32/win32k/ntuser/input.c trunk/reactos/subsystems/win32/win32k/ntuser/message.c trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c Modified: trunk/reactos/subsystems/win32/win32k/include/msgqueue.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/msgqueue.h (original) +++ trunk/reactos/subsystems/win32/win32k/include/msgqueue.h Sat Jul 28 21:16:51 2007 @@ -268,6 +268,12 @@ VOID FASTCALL MsqRemoveTimersWindow(PUSER_MESSAGE_QUEUE MessageQueue, HWND Wnd); +static __inline LONG +MsqCalculateMessageTime(IN PLARGE_INTEGER TickCount) +{ + return (LONG)(TickCount->QuadPart * (KeQueryTimeIncrement() / 10000)); +} + #endif /* _WIN32K_MSGQUEUE_H */ /* EOF */ Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/input.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/input.c Sat Jul 28 21:16:51 2007 @@ -984,7 +984,7 @@ { LARGE_INTEGER LargeTickCount; KeQueryTickCount(&LargeTickCount); - mi->time = LargeTickCount.u.LowPart; + mi->time = MsqCalculateMessageTime(&LargeTickCount); } SwapButtons = CurInfo->SwapButtons; Modified: trunk/reactos/subsystems/win32/win32k/ntuser/message.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/message.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/message.c Sat Jul 28 21:16:51 2007 @@ -1224,7 +1224,7 @@ IntGetCursorLocation(PsGetCurrentThreadWin32Thread()->Desktop->WindowStation, &KernelModeMsg.pt); KeQueryTickCount(&LargeTickCount); - KernelModeMsg.time = LargeTickCount.u.LowPart * (KeQueryTimeIncrement() / 10000); + KernelModeMsg.time = MsqCalculateMessageTime(&LargeTickCount); MsqPostMessage(Window->MessageQueue, &KernelModeMsg, NULL != MsgMemoryEntry && 0 != KernelModeMsg.lParam, QS_POSTMESSAGE); Modified: trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c Sat Jul 28 21:16:51 2007 @@ -163,7 +163,7 @@ } KeQueryTickCount(&LargeTickCount); - Msg->time = LargeTickCount.u.LowPart; + Msg->time = MsqCalculateMessageTime(&LargeTickCount); /* * If we got WM_MOUSEMOVE and there are already messages in the @@ -694,7 +694,7 @@ Msg.lParam = lParam; KeQueryTickCount(&LargeTickCount); - Msg.time = LargeTickCount.u.LowPart; + Msg.time = MsqCalculateMessageTime(&LargeTickCount); /* We can't get the Msg.pt point here since we don't know thread (and thus the window station) the message will end up in yet. */ @@ -770,7 +770,7 @@ Mesg.wParam = wParam; Mesg.lParam = lParam; KeQueryTickCount(&LargeTickCount); - Mesg.time = LargeTickCount.u.LowPart; + Mesg.time = MsqCalculateMessageTime(&LargeTickCount); IntGetCursorLocation(WinSta, &Mesg.pt); MsqPostMessage(Window->MessageQueue, &Mesg, FALSE, QS_HOTKEY); ObmDereferenceObject(Window); @@ -1787,7 +1787,7 @@ Msg->wParam = (WPARAM) Timer->IDEvent; Msg->lParam = (LPARAM) Timer->TimerFunc; KeQueryTickCount(&LargeTickCount); - Msg->time = LargeTickCount.u.LowPart; + Msg->time = MsqCalculateMessageTime(&LargeTickCount); IntGetCursorLocation(PsGetCurrentThreadWin32Thread()->Desktop->WindowStation, &Msg->pt);

1 0

[janderwald] 27951: - set USERNAME environment variable See issue #2487 for more details.
by janderwald＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: janderwald Date: Sat Jul 28 20:29:33 2007 New Revision: 27951 URL: http://svn.reactos.org/svn/reactos?rev=27951&view=rev Log: - set USERNAME environment variable See issue #2487 for more details. Modified: trunk/reactos/dll/win32/userenv/environment.c Modified: trunk/reactos/dll/win32/userenv/environment.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/environm… ============================================================================== --- trunk/reactos/dll/win32/userenv/environment.c (original) +++ trunk/reactos/dll/win32/userenv/environment.c Sat Jul 28 20:29:33 2007 @@ -383,7 +383,17 @@ /* FIXME: Set 'USERDOMAIN' variable */ - /* FIXME: Set 'USERNAME' variable */ + Length = MAX_PATH; + if (GetUserNameW(Buffer, + &Length)) + { + SetUserEnvironmentVariable(lpEnvironment, + L"USERNAME", + Buffer, + FALSE); + } + + /* Set user environment variables */ SetUserEnvironment (lpEnvironment,

1 0

[weiden] 27950: Also hand 0 read bytes to XML_Parse to make sure we always signal that we're done reading the document
by weiden＠svn.reactos.org 28 Jul '07

28 Jul '07

Author: weiden Date: Sat Jul 28 19:47:56 2007 New Revision: 27950 URL: http://svn.reactos.org/svn/reactos?rev=27950&view=rev Log: Also hand 0 read bytes to XML_Parse to make sure we always signal that we're done reading the document Modified: trunk/rosapps/downloader/xml.c Modified: trunk/rosapps/downloader/xml.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/downloader/xml.c?rev=27950… ============================================================================== --- trunk/rosapps/downloader/xml.c (original) +++ trunk/rosapps/downloader/xml.c Sat Jul 28 19:47:56 2007 @@ -190,7 +190,7 @@ size_t len = fread (buffer, 1, sizeof(buffer), file); done = len < sizeof(buffer); - if(len > 0 && !XML_Parse(parser, buffer, len, done)) + if(!XML_Parse(parser, buffer, len, done)) { MessageBoxW(0,Strings[IDS_XMLERROR_2],0,0); return FALSE;

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
71
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs July 2007