Ros-diffs August 2007

ros-diffs@reactos.org

21 participants
666 discussions

[janderwald] 28638: - remove hack
by janderwald＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: janderwald Date: Wed Aug 29 02:36:21 2007 New Revision: 28638 URL: http://svn.reactos.org/svn/reactos?rev=28638&view=rev Log: - remove hack Modified: trunk/reactos/boot/bootdata/packages/reactos.dff Modified: trunk/reactos/boot/bootdata/packages/reactos.dff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… ============================================================================== --- trunk/reactos/boot/bootdata/packages/reactos.dff (original) +++ trunk/reactos/boot/bootdata/packages/reactos.dff Wed Aug 29 02:36:21 2007 @@ -417,8 +417,6 @@ media\inf\usb.inf 6 media\inf\usbstor.inf 6 media\inf\xboxdisp.inf 6 -boot\bootdata\unattend.inf 6 optional - ; Subsystems subsystems\win32\csrss\csrss.exe 1

1 0

[janderwald] 28637: - remove hack
by janderwald＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: janderwald Date: Wed Aug 29 02:28:56 2007 New Revision: 28637 URL: http://svn.reactos.org/svn/reactos?rev=28637&view=rev Log: - remove hack Modified: trunk/reactos/Makefile Modified: trunk/reactos/Makefile URL: http://svn.reactos.org/svn/reactos/trunk/reactos/Makefile?rev=28637&r1=2863… ============================================================================== --- trunk/reactos/Makefile (original) +++ trunk/reactos/Makefile Wed Aug 29 02:28:56 2007 @@ -444,26 +444,9 @@ world sysregtest: - -mkdir $(OUTPUT_)cd$(SEP)reactos - $(cp) boot$(SEP)bootdata$(SEP)unattend.inf.sample boot$(SEP)bootdata$(SEP)unattend.inf - $(cp) boot$(SEP)bootdata$(SEP)unattend.inf.sample $(OUTPUT_)cd$(SEP)reactos$(SEP)unattend.inf - $(cp) boot$(SEP)bootdata$(SEP)bootcdregtest$(SEP)testboot.bat.sample boot$(SEP)bootdata$(SEP)bootcdregtest$(SEP)testboot.bat - $(MAKE) dbgprint - $(MAKE) bootcdregtest - $(MAKE) sysreg - $(OUTPUT_)tools$(SEP)sysreg$(SEP)sysreg$(EXEPOSTFIX) tools$(SEP)sysreg$(SEP)txtmode.cfg rosboot - $(OUTPUT_)tools$(SEP)sysreg$(SEP)sysreg$(EXEPOSTFIX) tools$(SEP)sysreg$(SEP)secstage.cfg rosboot - $(OUTPUT_)tools$(SEP)sysreg$(SEP)sysreg$(EXEPOSTFIX) tools$(SEP)sysreg$(SEP)runonce.cfg rosboot - -sysregtest_clean: - $(rm) boot$(SEP)bootdata$(SEP)unattend.inf - $(rm) boot$(SEP)bootdata$(SEP)bootcdregtest$(SEP)testboot.bat - $(rm) $(OUTPUT_)cd$(SEP)reactos$(SEP)unattend.inf - -regtest: - $(cp) boot$(SEP)bootdata$(SEP)unattend.inf.sample $(OUTPUT_)cd$(SEP)reactos$(SEP)unattend.inf - $(MAKE) bootcdregtest - $(rm) $(OUTPUT_)cd$(SEP)reactos$(SEP)unattend.inf + $(OUTPUT_)tools$(SEP)sysreg$(SEP)sysreg$(EXEPOSTFIX) tools$(SEP)sysreg$(SEP)txtmode.cfg + $(OUTPUT_)tools$(SEP)sysreg$(SEP)sysreg$(EXEPOSTFIX) tools$(SEP)sysreg$(SEP)txtmode.cfg + $(OUTPUT_)tools$(SEP)sysreg$(SEP)sysreg$(EXEPOSTFIX) tools$(SEP)sysreg$(SEP)txtmode.cfg .PHONY: cb cb: $(RBUILD_TARGET)

1 0

[jimtabor] 28636: - Removed NtGdiPoly/Polygon from source, w32ksvc.db and updated ntgdibad.h. - Renamed the Nt function to GdiCreatePolyPolygonRgn, it is not safe so it will not be named to IntGdiXxX.
by jimtabor＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: jimtabor Date: Wed Aug 29 02:11:55 2007 New Revision: 28636 URL: http://svn.reactos.org/svn/reactos?rev=28636&view=rev Log: - Removed NtGdiPoly/Polygon from source, w32ksvc.db and updated ntgdibad.h. - Renamed the Nt function to GdiCreatePolyPolygonRgn, it is not safe so it will not be named to IntGdiXxX. Modified: trunk/reactos/include/reactos/win32k/ntgdibad.h trunk/reactos/subsystems/win32/win32k/include/region.h trunk/reactos/subsystems/win32/win32k/objects/fillshap.c trunk/reactos/subsystems/win32/win32k/objects/region.c trunk/reactos/subsystems/win32/win32k/w32ksvc.db Modified: trunk/reactos/include/reactos/win32k/ntgdibad.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/win32k/ntg… ============================================================================== --- trunk/reactos/include/reactos/win32k/ntgdibad.h (original) +++ trunk/reactos/include/reactos/win32k/ntgdibad.h Wed Aug 29 02:11:55 2007 @@ -161,14 +161,6 @@ INT Count, INT PolyFillMode); -/* Use NtGdiPolyPolyDraw with PolyPolyRgn. */ -HRGN -STDCALL -NtGdiCreatePolyPolygonRgn(CONST PPOINT pt, - CONST PINT PolyCounts, - INT Count, - INT PolyFillMode); - /* Meta are user-mode. */ BOOL STDCALL @@ -505,21 +497,6 @@ STDCALL NtGdiPolyTextOut(HDC hDC, CONST LPPOLYTEXTW txt, - int Count); - -/* Use NtGdiPolyPolyDraw with GdiPolyPolygon. */ -BOOL -STDCALL -NtGdiPolygon(HDC hDC, - CONST PPOINT Points, - int Count); - -/* Use NtGdiPolyPolyDraw with GdiPolyPolygon. */ -BOOL -STDCALL -NtGdiPolyPolygon(HDC hDC, - CONST LPPOINT Points, - CONST LPINT PolyCounts, int Count); /* Call UserRealizePalette. */ Modified: trunk/reactos/subsystems/win32/win32k/include/region.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/region.h (original) +++ trunk/reactos/subsystems/win32/win32k/include/region.h Wed Aug 29 02:11:55 2007 @@ -18,6 +18,7 @@ BOOL INTERNAL_CALL RGNDATA_Cleanup(PVOID ObjectBody); BOOL FASTCALL IntGdiPaintRgn(PDC, HRGN ); +HRGN FASTCALL GdiCreatePolyPolygonRgn(CONST PPOINT, CONST PINT, INT, INT ); #endif Modified: trunk/reactos/subsystems/win32/win32k/objects/fillshap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/fillshap.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/fillshap.c Wed Aug 29 02:11:55 2007 @@ -805,183 +805,6 @@ #endif -BOOL -STDCALL -NtGdiPolygon(HDC hDC, - CONST PPOINT UnsafePoints, - int Count) -{ - DC *dc; - LPPOINT Safept; - NTSTATUS Status = STATUS_SUCCESS; - BOOL Ret = FALSE; - - if ( Count < 2 ) - { - SetLastWin32Error(ERROR_INVALID_PARAMETER); - return FALSE; - } - - _SEH_TRY - { - ProbeForRead(UnsafePoints, - Count * sizeof(POINT), - 1); - } - _SEH_HANDLE - { - Status = _SEH_GetExceptionCode(); - } - _SEH_END; - - if (!NT_SUCCESS(Status)) - { - SetLastNtError(Status); - return FALSE; - } - - dc = DC_LockDc(hDC); - if(!dc) - SetLastWin32Error(ERROR_INVALID_HANDLE); - else - { - if (dc->IsIC) - { - DC_UnlockDc(dc); - /* Yes, Windows really returns TRUE in this case */ - return TRUE; - } - Safept = ExAllocatePoolWithTag(PagedPool, sizeof(POINT) * Count, TAG_SHAPE); - if(!Safept) - SetLastWin32Error(ERROR_NOT_ENOUGH_MEMORY); - else - { - _SEH_TRY - { - /* pointer was already probed! */ - RtlCopyMemory(Safept, - UnsafePoints, - Count * sizeof(POINT)); - } - _SEH_HANDLE - { - Status = _SEH_GetExceptionCode(); - } - _SEH_END; - - if(!NT_SUCCESS(Status)) - SetLastNtError(Status); - else - Ret = IntGdiPolygon(dc, Safept, Count); - - ExFreePool(Safept); - } - DC_UnlockDc(dc); - } - - return Ret; -} - - -BOOL -STDCALL -NtGdiPolyPolygon(HDC hDC, - CONST LPPOINT Points, - CONST LPINT PolyCounts, - int Count) -{ - DC *dc; - LPPOINT Safept; - LPINT SafePolyPoints; - NTSTATUS Status = STATUS_SUCCESS; - BOOL Ret; - - dc = DC_LockDc(hDC); - if(!dc) - { - SetLastWin32Error(ERROR_INVALID_HANDLE); - return FALSE; - } - if (dc->IsIC) - { - DC_UnlockDc(dc); - /* Yes, Windows really returns TRUE in this case */ - return TRUE; - } - - if(Count > 0) - { - _SEH_TRY - { - ProbeForRead(Points, - Count * sizeof(POINT), - 1); - ProbeForRead(PolyCounts, - Count * sizeof(INT), - 1); - } - _SEH_HANDLE - { - Status = _SEH_GetExceptionCode(); - } - _SEH_END; - - if (!NT_SUCCESS(Status)) - { - DC_UnlockDc(dc); - SetLastNtError(Status); - return FALSE; - } - - Safept = ExAllocatePoolWithTag(PagedPool, (sizeof(POINT) + sizeof(INT)) * Count, TAG_SHAPE); - if(!Safept) - { - DC_UnlockDc(dc); - SetLastWin32Error(ERROR_NOT_ENOUGH_MEMORY); - return FALSE; - } - - SafePolyPoints = (LPINT)&Safept[Count]; - - _SEH_TRY - { - /* pointers already probed! */ - RtlCopyMemory(Safept, - Points, - Count * sizeof(POINT)); - RtlCopyMemory(SafePolyPoints, - PolyCounts, - Count * sizeof(INT)); - } - _SEH_HANDLE - { - Status = _SEH_GetExceptionCode(); - } - _SEH_END; - - if(!NT_SUCCESS(Status)) - { - DC_UnlockDc(dc); - ExFreePool(Safept); - SetLastNtError(Status); - return FALSE; - } - } - else - { - DC_UnlockDc(dc); - SetLastWin32Error(ERROR_INVALID_PARAMETER); - return FALSE; - } - - Ret = IntGdiPolyPolygon(dc, Safept, SafePolyPoints, Count); - - ExFreePool(Safept); - DC_UnlockDc(dc); - - return Ret; -} - ULONG_PTR STDCALL @@ -999,11 +822,11 @@ INT nPoints, nEmpty, nInvalid, i; if (iFunc == GdiPolyPolyRgn) - { // Rename me to FASTCALL GdiCreatePolyPolygonRgn - return (ULONG_PTR) NtGdiCreatePolyPolygonRgn((CONST PPOINT) Points, - (CONST PINT) PolyCounts, - Count, - (INT) hDC); + { + return (ULONG_PTR) GdiCreatePolyPolygonRgn((CONST PPOINT) Points, + (CONST PINT) PolyCounts, + Count, + (INT) hDC); } dc = DC_LockDc(hDC); if(!dc) Modified: trunk/reactos/subsystems/win32/win32k/objects/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/region.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/region.c Wed Aug 29 02:11:55 2007 @@ -3423,8 +3423,8 @@ HRGN -STDCALL -NtGdiCreatePolyPolygonRgn(CONST PPOINT pt, +FASTCALL +GdiCreatePolyPolygonRgn(CONST PPOINT pt, CONST PINT PolyCounts, INT Count, INT PolyFillMode) Modified: trunk/reactos/subsystems/win32/win32k/w32ksvc.db URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/w3… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/w32ksvc.db (original) +++ trunk/reactos/subsystems/win32/win32k/w32ksvc.db Wed Aug 29 02:11:55 2007 @@ -804,8 +804,6 @@ NtGdiPolylineTo 3 NtGdiPolyPolyline 4 NtGdiPolyTextOut 3 -NtGdiPolygon 3 -NtGdiPolyPolygon 4 NtGdiRealizePalette 1 NtGdiRemoveFontResource 1 #

1 0

[janderwald] 28635: - if'd ROS_EMU_TYPE - check for cdrom images + hdd images - check provided image and qemu paths - search for default cdrom image + hdd image
by janderwald＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: janderwald Date: Wed Aug 29 02:07:54 2007 New Revision: 28635 URL: http://svn.reactos.org/svn/reactos?rev=28635&view=rev Log: - if'd ROS_EMU_TYPE - check for cdrom images + hdd images - check provided image and qemu paths - search for default cdrom image + hdd image Modified: trunk/reactos/tools/sysreg/rosboot_test.cpp trunk/reactos/tools/sysreg/rosboot_test.h Modified: trunk/reactos/tools/sysreg/rosboot_test.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/rosboot_test.… ============================================================================== --- trunk/reactos/tools/sysreg/rosboot_test.cpp (original) +++ trunk/reactos/tools/sysreg/rosboot_test.cpp Wed Aug 29 02:07:54 2007 @@ -97,27 +97,107 @@ OsSupport::sleep(m_DelayRead); } } - +//--------------------------------------------------------------------------------------- + void RosBootTest::getDefaultHDDImage(string & img) + { + img = "output-i386"; + + EnvironmentVariable::getValue(_T("ROS_OUTPUT"), img); + img += _T("\\ros.hd"); + } +//--------------------------------------------------------------------------------------- + bool RosBootTest::isFileExisting(string output) + { + FILE * file; + + file = _tfopen(output.c_str(), _T("r")); + + if (file) + { + /* the file exists */ + fclose(file); + return true; + } + return false; + } + +//--------------------------------------------------------------------------------------- + bool RosBootTest::isDefaultHDDImageExisting() + { + string img; + + getDefaultHDDImage(img); + return isFileExisting(img); + } + +//--------------------------------------------------------------------------------------- + bool RosBootTest::createDefaultHDDImage() + { + + string qemuimgdir; + string output; + + if (!getQemuDir(qemuimgdir)) + { + return false; + } + +#ifdef __LINUX___ + qemuimgdir += _T("\\qemu-img"); +#else + qemuimgdir += _T("\\qemu-img.exe"); +#endif + + TCHAR * options[] = { + _T("create"), + NULL, + _T("100M"), + NULL + }; + + getDefaultHDDImage(output); + options[1] = (TCHAR*)output.c_str(); + + cerr << "Creating HDD Image ..." << output << endl; + if (OsSupport::createProcess ((TCHAR*)qemuimgdir.c_str(), 3, options, true)) + { + m_HDDImage = output; + return true; + } + + return false; + } //---------------------------------------------------------------------------------------- - bool RosBootTest::configureQemu() + bool RosBootTest::isQemuPathValid() { string qemupath; + + if (m_BootCmd.length()) + { + /* the boot cmd is already provided + * check if path to qemu is valid + */ + string::size_type pos = m_BootCmd.find_first_of(_T(" ")); + if (pos == string::npos) + { + /* the bootcmd is certainly not valid */ + return false; + } + qemupath = m_BootCmd.substr(0, pos); + } + else + { + /* the qemu path is provided ROS_EMU_PATH variable */ + qemupath = m_EmuPath; + } + + + return isFileExisting(qemupath); + } +//---------------------------------------------------------------------------------------- + bool RosBootTest::getQemuDir(string & qemupath) + { string::size_type pos; - - bool bootfromcd = false; - bool bootcmdprovided = false; - if (m_CDImage != _T("") ) - { - bootfromcd = true; - } - - if (m_BootCmd != _T("") ) - { - /// - /// boot cmd is provided already - /// - bootcmdprovided = true; - } #ifdef __LINUX__ pos = m_EmuPath.find_last_of(_T("/")); @@ -130,56 +210,19 @@ return false; } qemupath = m_EmuPath.substr(0, pos); - - - if (m_HDDImage == _T("")) - { - if(!bootfromcd) - { - cerr << "Error: ROS_CD_IMAGE and ROS_HDD_IMAGE is not set!!!" << endl; - return false; - } - string qemuimgdir = qemupath; - m_HDDImage = _T("ros.img"); -#ifdef __LINUX___ - qemuimgdir += _T("\\qemu-img"); -#else - qemuimgdir += _T("\\qemu-img.exe"); -#endif - /// - /// FIXME - /// call qemu-img to create the tool - /// - TCHAR * options[] = { - _T("create"), - NULL, - _T("100M"), - NULL - }; - string output = "output-i386"; - EnvironmentVariable::getValue(_T("ROS_OUTPUT"), output); - output += _T("\\ros.hd"); - options[1] = (TCHAR*)output.c_str(); - - cerr << "Creating HDD Image ..." << output << endl; - if (OsSupport::createProcess ((TCHAR*)qemuimgdir.c_str(), 3, options, true)) - { - m_HDDImage = output; - } - else - { - return false; - } - } - - if (!bootcmdprovided) - { - if (m_MaxMem == "") - { - // default to 64M - m_MaxMem = "64"; - } - string pipe; + return true; + } +//---------------------------------------------------------------------------------------- + bool RosBootTest::createBootCmd() + { + string pipe; + + if (m_MaxMem.length() == 0) + { + /* set default memory size to 64M */ + m_MaxMem = "64"; + } + #ifdef __LINUX__ pipe = _T("stdio"); m_Src = _T(""); @@ -187,75 +230,244 @@ pipe = _T("pipe:qemu"); m_Src = _T("\\\\.\\pipe\\qemu"); #endif + string qemudir; + if (!getQemuDir(qemudir)) + { + return false; + } - - if (bootfromcd) - { - m_BootCmd = m_EmuPath + _T(" -serial ") + pipe + _T(" -m ") + m_MaxMem + _T(" -hda ") + m_HDDImage + _T(" -boot d -cdrom ") + m_CDImage + _T(" -L ") + qemupath; - } - else - { - m_BootCmd = m_EmuPath + _T(" -L ") + qemupath + _T(" -m ") + m_MaxMem + _T(" -boot c -serial ") + pipe + _T(" -hda ") + m_HDDImage; - } - - if (m_KillEmulator == _T("yes")) - { + m_BootCmd = m_EmuPath + _T(" -L ") + qemudir + _T(" -m ") + m_MaxMem + _T(" -hda ") + m_HDDImage + _T(" -serial ") + pipe; + + if (m_CDImage.length()) + { + /* boot from cdrom */ + m_BootCmd += _T(" -boot d -cdrom ") + m_CDImage; + } + else + { + /* boot from hdd */ + m_BootCmd += _T(" -boot c "); + } + #ifdef __LINUX__ - m_BootCmd += _T(" -pidfile pid.txt"); + /* on linux we need get pid in order to be able + * to terminate the emulator in case of errors + * on windows we can get pid as return of CreateProcess + */ + m_BootCmd += _T(" -pidfile pid.txt"); #endif - } - else - { - m_BootCmd += _T(" -no-reboot "); - } - } - else - { + + m_BootCmd += _T(" -no-reboot "); + + return true; + } +//---------------------------------------------------------------------------------------- + bool RosBootTest::extractPipeFromBootCmd() + { string::size_type pos = m_BootCmd.find(_T("-serial")); - if (pos != string::npos) - { - string pipe = m_BootCmd.substr(pos + 7, m_BootCmd.size() - pos -7); - pos = pipe.find(_T("pipe:")); - if (pos == 0) - { + if (pos == string::npos) + { + /* no debug options provided */ + return false; + } + + string pipe = m_BootCmd.substr(pos + 7, m_BootCmd.size() - pos -7); + pos = pipe.find(_T("pipe:")); + if (pos == 0) + { #ifdef __LINUX__ - cerr << "Error: popen doesnot support reading from pipe" << endl; - return false; + cerr << "Error: reading from pipes is not supported with linux hosts - use stdio" << endl; + return false; #else - pipe = pipe.substr(pos + 5, pipe.size() - pos - 5); - pos = pipe.find(_T(" ")); - if (pos != string::npos) - { - m_Src = _T("\\\\.\\pipe\\") + pipe.substr(0, pos); - } - else - { - m_Src = _T("\\\\.\\pipe\\") + pipe; - } + pipe = pipe.substr(pos + 5, pipe.size() - pos - 5); + pos = pipe.find(_T(" ")); + if (pos != string::npos) + { + m_Src = _T("\\\\.\\pipe\\") + pipe.substr(0, pos); + } + else + { + m_Src = _T("\\\\.\\pipe\\") + pipe; + } + return true; + } +#endif + pos = pipe.find(_T("stdio")); + if (pos == 0) + { +#ifdef __LINUX__ + m_Src = m_BootCmd; + return true; +#else + cerr << "Error: reading from stdio is not supported for windows hosts - use pipes" << endl; + return false; #endif - } - else - { - pos = pipe.find(_T("stdio")); - if (pos == 0) - { -#ifdef __LINUX__ - m_Src = m_BootCmd; -#else - cerr << "Error: sysreg does not support reading stdio" << endl; - return false; -#endif - - } - - - } - - } - - - } - + } + + cerr << "Error: no valid debug port specified - use stdio / pipes" << endl; + return false; + } +//---------------------------------------------------------------------------------------- + bool RosBootTest::configureHDDImage() + { + if (m_HDDImage.length()) + { + /* check if ROS_HDD_IMAGE points to hdd image */ + return isFileExisting(m_HDDImage); + } + + if (isDefaultHDDImageExisting()) + { + /* ROS_HDD_IMAGE is not set but theres + * a default existing image + * to use */ + getDefaultHDDImage(m_HDDImage); + return true; + } + + if (m_CDImage.length()) + { + /* ROS_CD_IMAGE is set but no ROS_HDD_IMAGE is set + * so create hdd image */ + if (!createDefaultHDDImage()) + { + /* failed to create hdd image */ + cerr << "Error: failed to create hdd image " << endl; + return false; + } + getDefaultHDDImage(m_HDDImage); + return true; + } + /// + /// FIXME + /// scan m_BootCmd if theres -hda param provided + /// and check if it exists + + return true; + } +//---------------------------------------------------------------------------------------- + bool RosBootTest::configureCDImage() + { + if (m_CDImage.length()) + { + /* we have a cd image lets check if its valid */ + if (!isFileExisting(m_CDImage)) + { + cerr << "Error: ROS_CD_IMAGE is not valid" << endl; + return false; + } + return true; + } + + /* ROS_CD_IMAGE is not set + * lets check if m_BootCmd provides it + */ + + if (!m_BootCmd.length()) + { + /* ROS_BOOT_CMD not set + * check if theres a default image + */ + + if (isFileExisting(_T("ReactOS-RegTest.iso"))) + { + m_CDImage = _T("ReactOS-RegTest.iso"); + } + return true; + } + + string::size_type pos = m_BootCmd.find(_T("-boot ")); + if (pos == string::npos) + { + /* ROS_BOOT_CMD must provide a boot parameter*/ + cerr << "Error: ROS_BOOT_CMD misses boot parameter" << endl; + return false; + } + + string rest = m_BootCmd.substr(pos + 6, m_BootCmd.length() - pos - 6); + if (rest.length() < 1) + { + /* boot parameter misses option where to boot from */ + cerr << "Error: ROS_BOOT_CMD misses boot parameter" << endl; + return false; + } + if (rest[0] != _T('c') && rest[0] != _T('d')) + { + cerr << "Error: ROS_BOOT_CMD has invalid boot parameter" << endl; + return false; + } + + if (rest[0] == _T('c')) + { + /* ROS_BOOT_CMD boots from hdd */ + return true; + } + + pos = m_BootCmd.find(_T("-cdrom ")); + if (pos == string::npos) + { + cerr << "Error: ROS_BOOT_CMD misses cdrom parameter" << endl; + return false; + } + rest = m_BootCmd.substr(pos + 7, m_BootCmd.length() - pos - 7); + if (!rest.length()) + { + cerr << "Error: ROS_BOOT_CMD misses cdrom parameter" << endl; + return false; + } + pos = rest.find(_T(" ")); + if (pos != string::npos) + { + rest = rest.substr(0, pos); + } + + if (!isFileExisting(rest)) + { + cerr << "Error: cdrom image " << rest << " does not exist" << endl; + return false; + } + else + { + m_CDImage = rest; + return true; + } + } +//---------------------------------------------------------------------------------------- + bool RosBootTest::configureQemu() + { + if (!isQemuPathValid()) + { + cerr << "Error: the path to qemu is not valid" << endl; + return false; + } + + if (!configureCDImage()) + { + cerr << "Error: failed to set a valid cdrom configuration" << endl; + return false; + } + + if (!configureHDDImage()) + { + cerr << "Error: failed to set a valid hdd configuration" << endl; + return false; + } + + if (m_BootCmd.length()) + { + if (!extractPipeFromBootCmd()) + { + return false; + } + } + else + { + if (!createBootCmd()) + { + return false; + } + } + cerr << "Opening Data Source:" << m_BootCmd << endl; @@ -283,11 +495,13 @@ //--------------------------------------------------------------------------------------- bool RosBootTest::readConfigurationValues(ConfigParser &conf_parser) { +#if 0 if (!conf_parser.getStringValue(RosBootTest::ROS_EMU_TYPE, m_EmuType)) { cerr << "Error: ROS_EMU_TYPE is not set" << endl; return false; } +#endif if (!conf_parser.getStringValue(RosBootTest::ROS_EMU_PATH, m_EmuPath)) { @@ -332,7 +546,7 @@ { return false; } - +#if 0 if (m_EmuType == EMU_TYPE_QEMU) { if (!configureQemu()) @@ -357,6 +571,13 @@ cerr << "Error: ROS_EMU_TYPE value is not supported:" << m_EmuType << "=" << EMU_TYPE_QEMU << endl; return false; } +#else + if (!configureQemu()) + { + cerr << "Error: failed to configure qemu" << endl; + return false; + } +#endif #ifndef __LINUX__ OsSupport::sleep(500); #endif Modified: trunk/reactos/tools/sysreg/rosboot_test.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/rosboot_test.… ============================================================================== --- trunk/reactos/tools/sysreg/rosboot_test.h (original) +++ trunk/reactos/tools/sysreg/rosboot_test.h Wed Aug 29 02:07:54 2007 @@ -83,6 +83,16 @@ protected: + void getDefaultHDDImage(string & img); + bool isFileExisting(string filename); + bool isDefaultHDDImageExisting(); + bool createDefaultHDDImage(); + bool isQemuPathValid(); + bool getQemuDir(string &); + bool createBootCmd(); + bool extractPipeFromBootCmd(); + bool configureCDImage(); + bool configureHDDImage(); void getPidFromFile(); bool executeBootCmd(); void delayRead();

1 0

[jimtabor] 28634: Plugin PolyPolygon, Polygon uses the same code and tested good.
by jimtabor＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: jimtabor Date: Wed Aug 29 01:29:03 2007 New Revision: 28634 URL: http://svn.reactos.org/svn/reactos?rev=28634&view=rev Log: Plugin PolyPolygon, Polygon uses the same code and tested good. Modified: trunk/reactos/dll/win32/gdi32/gdi32.def Modified: trunk/reactos/dll/win32/gdi32/gdi32.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/gdi32.def?… ============================================================================== --- trunk/reactos/dll/win32/gdi32/gdi32.def (original) +++ trunk/reactos/dll/win32/gdi32/gdi32.def Wed Aug 29 01:29:03 2007 @@ -495,11 +495,11 @@ PolyBezier@12=NtGdiPolyBezier@12 PolyBezierTo@12=NtGdiPolyBezierTo@12 PolyDraw@16=NtGdiPolyDraw@16 -PolyPolygon@16=NtGdiPolyPolygon@16 +PolyPolygon@16 PolyPolyline@16=NtGdiPolyPolyline@16 PolyTextOutA@12 PolyTextOutW@12 -Polygon@12 ;=NtGdiPolygon@12 +Polygon@12 Polyline@12=NtGdiPolyline@12 PolylineTo@12=NtGdiPolylineTo@12 PtInRegion@12=NtGdiPtInRegion@12

1 0

[gedmurphy] 28633: missed a return type
by gedmurphy＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: gedmurphy Date: Wed Aug 29 00:13:42 2007 New Revision: 28633 URL: http://svn.reactos.org/svn/reactos?rev=28633&view=rev Log: missed a return type Modified: trunk/reactos/base/applications/mscutils/servman/propsheet.c Modified: trunk/reactos/base/applications/mscutils/servman/propsheet.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/propsheet.c (original) +++ trunk/reactos/base/applications/mscutils/servman/propsheet.c Wed Aug 29 00:13:42 2007 @@ -200,7 +200,7 @@ } } - +VOID SaveDlgInfo(PSERVICEPROPSHEET dlgInfo, HWND hwndDlg) {

1 0

[gedmurphy] 28632: fix IsUserAnAdmin
by gedmurphy＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: gedmurphy Date: Wed Aug 29 00:13:09 2007 New Revision: 28632 URL: http://svn.reactos.org/svn/reactos?rev=28632&view=rev Log: fix IsUserAnAdmin Modified: trunk/reactos/dll/win32/shell32/shell32.spec trunk/reactos/dll/win32/shell32/shellord.c Modified: trunk/reactos/dll/win32/shell32/shell32.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shell32.… ============================================================================== --- trunk/reactos/dll/win32/shell32/shell32.spec (original) +++ trunk/reactos/dll/win32/shell32/shell32.spec Wed Aug 29 00:13:09 2007 @@ -244,7 +244,7 @@ 654 stdcall @(long long) shell32_654 # ReadCabinetState@8 660 stdcall -noname FileIconInit(long) - 680 stdcall -noname IsUserAdmin() + 680 stdcall -noname IsUserAnAdmin() 714 stdcall @(ptr) SHELL32_714 # PathIsTemporaryW 730 stdcall -noname RestartDialogEx(long wstr long long) Modified: trunk/reactos/dll/win32/shell32/shellord.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shellord… ============================================================================== --- trunk/reactos/dll/win32/shell32/shellord.c (original) +++ trunk/reactos/dll/win32/shell32/shellord.c Wed Aug 29 00:13:09 2007 @@ -1225,10 +1225,10 @@ return 0; } /************************************************************************* - * IsUserAdmin [SHELL32.680] NT 4.0 - * - */ -HRESULT WINAPI IsUserAdmin(void) + * IsUserAnAdmin [SHELL32.680] NT 4.0 + * + */ +BOOL WINAPI IsUserAnAdmin(VOID) { FIXME("stub\n"); return TRUE; }

1 0

[cfinck] 28631: Include "windef.h" in "mkstemps.c" for our wchar_t check. This is just a temporary solution for fixing the compilation on Mac OS X hosts until host and target headers are fully separated.
by cfinck＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: cfinck Date: Wed Aug 29 00:03:15 2007 New Revision: 28631 URL: http://svn.reactos.org/svn/reactos?rev=28631&view=rev Log: Include "windef.h" in "mkstemps.c" for our wchar_t check. This is just a temporary solution for fixing the compilation on Mac OS X hosts until host and target headers are fully separated. Modified: trunk/reactos/tools/wrc/port/mkstemps.c Modified: trunk/reactos/tools/wrc/port/mkstemps.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/wrc/port/mkstemps.c?… ============================================================================== --- trunk/reactos/tools/wrc/port/mkstemps.c (original) +++ trunk/reactos/tools/wrc/port/mkstemps.c Wed Aug 29 00:03:15 2007 @@ -19,6 +19,7 @@ #include "config.h" #include <sys/types.h> +#include "windef.h" #include <stdlib.h> #include <string.h> #include <errno.h>

1 0

[gedmurphy] 28630: - improve the start code - add an edit button on the properties dialog to give admins the option to modify the service config
by gedmurphy＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: gedmurphy Date: Tue Aug 28 23:54:25 2007 New Revision: 28630 URL: http://svn.reactos.org/svn/reactos?rev=28630&view=rev Log: - improve the start code - add an edit button on the properties dialog to give admins the option to modify the service config Modified: trunk/reactos/base/applications/mscutils/servman/lang/bg-BG.rc trunk/reactos/base/applications/mscutils/servman/lang/de-DE.rc trunk/reactos/base/applications/mscutils/servman/lang/en-US.rc trunk/reactos/base/applications/mscutils/servman/lang/fr-FR.rc trunk/reactos/base/applications/mscutils/servman/lang/id-ID.rc trunk/reactos/base/applications/mscutils/servman/lang/it-IT.rc trunk/reactos/base/applications/mscutils/servman/lang/pl-PL.rc trunk/reactos/base/applications/mscutils/servman/lang/ru-RU.rc trunk/reactos/base/applications/mscutils/servman/lang/th-TH.rc trunk/reactos/base/applications/mscutils/servman/mainwnd.c trunk/reactos/base/applications/mscutils/servman/precomp.h trunk/reactos/base/applications/mscutils/servman/propsheet.c trunk/reactos/base/applications/mscutils/servman/query.c trunk/reactos/base/applications/mscutils/servman/resource.h trunk/reactos/base/applications/mscutils/servman/start.c Modified: trunk/reactos/base/applications/mscutils/servman/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/bg-BG.rc (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/bg-BG.rc Tue Aug 28 23:54:25 2007 @@ -74,7 +74,7 @@ EDITTEXT IDC_LICENSE_EDIT, 8, 44, 174, 107, WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_READONLY | ES_MULTILINE END -IDD_DLG_GENERAL DIALOGEX 6,6,253,225 +IDD_DLG_GENERAL DIALOGEX 6,6,253,232 CAPTION "Îáùî" FONT 8, "MS Shell Dlg",0,0 STYLE WS_BORDER | WS_VISIBLE | WS_DLGFRAME | WS_SYSMENU | WS_THICKFRAME | WS_GROUP | WS_TABSTOP @@ -100,6 +100,7 @@ LTEXT "Ìîæåòå äà çàäàäåòå ïóñêîâè óêàçàíèÿ, êîèòî äà ñå ïðèëîæàò ïðè ïóñêàíå íà óñëóãàòà îò òóê.",IDC_STATIC, 6,177,240,15 LTEXT "Ïóñêîâè óêàçàòåëè:", IDC_STATIC, 6, 200, 58, 11 EDITTEXT IDC_START_PARAM, 68, 199, 178, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP + PUSHBUTTON "Edit", IDC_EDIT, 192, 215, 54, 15, WS_DISABLED END IDD_DLG_DEPEND DIALOGEX 6,6,253,225 Modified: trunk/reactos/base/applications/mscutils/servman/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/de-DE.rc (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/de-DE.rc Tue Aug 28 23:54:25 2007 @@ -74,7 +74,7 @@ EDITTEXT IDC_LICENSE_EDIT, 8, 44, 174, 107, WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_READONLY | ES_MULTILINE END -IDD_DLG_GENERAL DIALOGEX 6,6,253,225 +IDD_DLG_GENERAL DIALOGEX 6,6,253,232 CAPTION "Allgemein" FONT 8, "MS Shell Dlg",0,0 STYLE WS_BORDER | WS_VISIBLE | WS_DLGFRAME | WS_SYSMENU | WS_THICKFRAME | WS_GROUP | WS_TABSTOP @@ -98,6 +98,7 @@ LTEXT "Sie können die Startparameter angeben, die übernommen werden sollen, wenn der Dienst von hier aus gestartet wird.",IDC_STATIC, 6,177,240,20 LTEXT "Startparameter:", IDC_STATIC, 6, 200, 58, 11 EDITTEXT IDC_START_PARAM, 68, 199, 178, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP + PUSHBUTTON "Edit", IDC_EDIT, 192, 215, 54, 15, WS_DISABLED END IDD_DLG_DEPEND DIALOGEX 6,6,253,225 Modified: trunk/reactos/base/applications/mscutils/servman/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/en-US.rc (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/en-US.rc Tue Aug 28 23:54:25 2007 @@ -74,7 +74,7 @@ EDITTEXT IDC_LICENSE_EDIT, 8, 44, 174, 107, WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_READONLY | ES_MULTILINE END -IDD_DLG_GENERAL DIALOGEX 6,6,253,225 +IDD_DLG_GENERAL DIALOGEX 6, 6, 253, 232 CAPTION "General" FONT 8, "MS Shell Dlg",0,0 STYLE WS_BORDER | WS_VISIBLE | WS_DLGFRAME | WS_SYSMENU | WS_THICKFRAME | WS_GROUP | WS_TABSTOP @@ -98,6 +98,7 @@ LTEXT "You can specify the start parameters that apply when you start the service from here.",IDC_STATIC, 6,177,240,15 LTEXT "Start parameters:", IDC_STATIC, 6, 200, 58, 11 EDITTEXT IDC_START_PARAM, 68, 199, 178, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP + PUSHBUTTON "Edit", IDC_EDIT, 192, 215, 54, 15, WS_DISABLED END IDD_DLG_DEPEND DIALOGEX 6,6,253,225 Modified: trunk/reactos/base/applications/mscutils/servman/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/fr-FR.rc (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/fr-FR.rc Tue Aug 28 23:54:25 2007 @@ -75,7 +75,7 @@ EDITTEXT IDC_LICENSE_EDIT, 8, 44, 174, 107, WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_READONLY | ES_MULTILINE END -IDD_DLG_GENERAL DIALOGEX 6,6,253,225 +IDD_DLG_GENERAL DIALOGEX 6,6,253,232 CAPTION "Général" FONT 8, "MS Shell Dlg",0,0 STYLE WS_BORDER | WS_VISIBLE | WS_DLGFRAME | WS_SYSMENU | WS_THICKFRAME | WS_GROUP | WS_TABSTOP @@ -99,6 +99,7 @@ LTEXT "Vous pouvez définir les paramètres passés au service lorsque vous le démarrez.",IDC_STATIC, 6,177,240,15 LTEXT "Paramètres:", IDC_STATIC, 6, 200, 58, 11 EDITTEXT IDC_START_PARAM, 68, 199, 178, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP + PUSHBUTTON "Edit", IDC_EDIT, 192, 215, 54, 15, WS_DISABLED END IDD_DLG_DEPEND DIALOGEX 6,6,253,225 Modified: trunk/reactos/base/applications/mscutils/servman/lang/id-ID.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/id-ID.rc (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/id-ID.rc Tue Aug 28 23:54:25 2007 @@ -74,7 +74,7 @@ EDITTEXT IDC_LICENSE_EDIT, 8, 44, 174, 107, WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_READONLY | ES_MULTILINE END -IDD_DLG_GENERAL DIALOGEX 6,6,253,225 +IDD_DLG_GENERAL DIALOGEX 6,6,253,232 CAPTION "Umum" FONT 8, "MS Shell Dlg",0,0 STYLE WS_BORDER | WS_VISIBLE | WS_DLGFRAME | WS_SYSMENU | WS_THICKFRAME | WS_GROUP | WS_TABSTOP @@ -98,6 +98,7 @@ LTEXT "Anda menetapkan parameter mulai yang diterapkan ketika anda memulai layanan dari sini.",IDC_STATIC, 6,177,240,15 LTEXT "Parameter Mulai:", IDC_STATIC, 6, 200, 58, 11 EDITTEXT IDC_START_PARAM, 68, 199, 178, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP + PUSHBUTTON "Edit", IDC_EDIT, 192, 215, 54, 15, WS_DISABLED END IDD_DLG_DEPEND DIALOGEX 6,6,253,225 Modified: trunk/reactos/base/applications/mscutils/servman/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/it-IT.rc (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/it-IT.rc Tue Aug 28 23:54:25 2007 @@ -74,7 +74,7 @@ EDITTEXT IDC_LICENSE_EDIT, 8, 44, 174, 107, WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_READONLY | ES_MULTILINE END -IDD_DLG_GENERAL DIALOGEX 6,6,253,225 +IDD_DLG_GENERAL DIALOGEX 6,6,253,232 CAPTION "General" FONT 8, "MS Shell Dlg",0,0 STYLE WS_BORDER | WS_VISIBLE | WS_DLGFRAME | WS_SYSMENU | WS_THICKFRAME | WS_GROUP | WS_TABSTOP @@ -98,6 +98,7 @@ LTEXT "Puoi indicarei parametri in uso quando il servizio è avviato da qui.",IDC_STATIC, 6,177,240,15 LTEXT "Parametri di avvio:", IDC_STATIC, 6, 200, 58, 11 EDITTEXT IDC_START_PARAM, 68, 199, 178, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP + PUSHBUTTON "Edit", IDC_EDIT, 192, 215, 54, 15, WS_DISABLED END IDD_DLG_DEPEND DIALOGEX 6,6,253,225 Modified: trunk/reactos/base/applications/mscutils/servman/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/pl-PL.rc (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/pl-PL.rc Tue Aug 28 23:54:25 2007 @@ -81,7 +81,7 @@ EDITTEXT IDC_LICENSE_EDIT, 8, 44, 174, 107, WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_READONLY | ES_MULTILINE END -IDD_DLG_GENERAL DIALOGEX 6,6,253,225 +IDD_DLG_GENERAL DIALOGEX 6,6,253,232 CAPTION "Ogólny" FONT 8, "MS Shell Dlg",0,0 STYLE WS_BORDER | WS_VISIBLE | WS_DLGFRAME | WS_SYSMENU | WS_THICKFRAME | WS_GROUP | WS_TABSTOP @@ -105,6 +105,7 @@ LTEXT "Mo¿esz okreli parametry pocz¹tkowe, które bêd¹ u¿yte przy uruchomieniu us³ugi z tego miejsca.",IDC_STATIC, 6,177,240,15 LTEXT "Parametry uruchomienia:", IDC_STATIC, 6, 200, 58, 11 EDITTEXT IDC_START_PARAM, 68, 199, 178, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP + PUSHBUTTON "Edit", IDC_EDIT, 192, 215, 54, 15, WS_DISABLED END IDD_DLG_DEPEND DIALOGEX 6,6,253,225 Modified: trunk/reactos/base/applications/mscutils/servman/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/ru-RU.rc (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/ru-RU.rc Tue Aug 28 23:54:25 2007 @@ -73,7 +73,7 @@ EDITTEXT IDC_LICENSE_EDIT, 8, 44, 174, 107, WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_READONLY | ES_MULTILINE END -IDD_DLG_GENERAL DIALOGEX 6,6,253,225 +IDD_DLG_GENERAL DIALOGEX 6,6,253,232 CAPTION "Îáùèå" FONT 8, "MS Shell Dlg",0,0 STYLE WS_BORDER | WS_VISIBLE | WS_DLGFRAME | WS_SYSMENU | WS_THICKFRAME | WS_GROUP | WS_TABSTOP @@ -97,6 +97,7 @@ LTEXT "Ìîæíî óêàçàòü ïàðàìåòðû çàïóñêà, ïðèìåíÿåìûå ïðè çàïóñêå ñëóæáû èç ýòîãî êàòàëîãà.",IDC_STATIC, 6,177,240,15 LTEXT "Ïàðàìåòðû çàïóñêà:", IDC_STATIC, 6, 200, 73, 11 EDITTEXT IDC_START_PARAM, 78, 199, 168, 11, WS_CHILD | WS_VISIBLE | WS_TABSTOP + PUSHBUTTON "Edit", IDC_EDIT, 192, 215, 54, 15, WS_DISABLED END IDD_DLG_DEPEND DIALOGEX 6,6,253,225 Modified: trunk/reactos/base/applications/mscutils/servman/lang/th-TH.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/th-TH.rc (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/th-TH.rc Tue Aug 28 23:54:25 2007 @@ -83,7 +83,7 @@ EDITTEXT IDC_LICENSE_EDIT, 8, 44, 174, 107, WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_READONLY | ES_MULTILINE END -IDD_DLG_GENERAL DIALOGEX 6,6,253,225 +IDD_DLG_GENERAL DIALOGEX 6,6,253,232 CAPTION "·ÑèÇä»" FONT 8, "MS Shell Dlg",0,0 STYLE WS_BORDER | WS_VISIBLE | WS_DLGFRAME | WS_SYSMENU | WS_THICKFRAME | WS_GROUP | WS_TABSTOP @@ -107,6 +107,7 @@ LTEXT "¤Ø³ÊÒÁÒÃ¶¡ÓË¹´¤èÒµÑÇá»ÃµèÒ§æã¹µÍ¹àÃÔèÁµé¹¡ÒÃãªé§Ò¹ àÁ×èÍ¤Ø³àÃÔèÁãËéºÃÔ¡ÒÃ·ÕèµÃ§¹Õé.",IDC_STATIC, 6,177,240,15 LTEXT "àÃÔèÁµé¹¤èÒµÑÇá»ÃµèÒ§æ:", IDC_STATIC, 6, 200, 58, 11 EDITTEXT IDC_START_PARAM, 68, 199, 178, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP + PUSHBUTTON "Edit", IDC_EDIT, 192, 215, 54, 15, WS_DISABLED END IDD_DLG_DEPEND DIALOGEX 6,6,253,225 Modified: trunk/reactos/base/applications/mscutils/servman/mainwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/mainwnd.c (original) +++ trunk/reactos/base/applications/mscutils/servman/mainwnd.c Tue Aug 28 23:54:25 2007 @@ -122,7 +122,7 @@ { SendMessage(Info->hStatus, SB_SIMPLE, - (WPARAM)Info->InMenuLoop, + (WPARAM)Info->bInMenuLoop, 0); } } @@ -623,6 +623,8 @@ MAKEINTRESOURCE(IDR_POPUP)); Info->hShortcutMenu = GetSubMenu(Info->hShortcutMenu, 0); + + Info->bIsUserAnAdmin = IsUserAnAdmin(); return TRUE; } @@ -1055,14 +1057,14 @@ case WM_ENTERMENULOOP: { - Info->InMenuLoop = TRUE; + Info->bInMenuLoop = TRUE; UpdateMainStatusBar(Info); break; } case WM_EXITMENULOOP: { - Info->InMenuLoop = FALSE; + Info->bInMenuLoop = FALSE; UpdateMainStatusBar(Info); break; } Modified: trunk/reactos/base/applications/mscutils/servman/precomp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/precomp.h (original) +++ trunk/reactos/base/applications/mscutils/servman/precomp.h Tue Aug 28 23:54:25 2007 @@ -7,6 +7,7 @@ #include <stdio.h> #include <tchar.h> #include <commctrl.h> +#include <shlobj.h> #include "resource.h" #ifdef _MSC_VER @@ -30,7 +31,8 @@ INT SelectedItem;/* selection number in the list view */ BOOL bDlgOpen; - BOOL InMenuLoop; + BOOL bInMenuLoop; + BOOL bIsUserAnAdmin; } MAIN_WND_INFO, *PMAIN_WND_INFO; @@ -72,6 +74,7 @@ /* query.c */ ENUM_SERVICE_STATUS_PROCESS* GetSelectedService(PMAIN_WND_INFO Info); LPQUERY_SERVICE_CONFIG GetServiceConfig(LPTSTR lpServiceName); +VOID SetServiceConfig(LPQUERY_SERVICE_CONFIG); LPTSTR GetServiceDescription(LPTSTR lpServiceName); LPTSTR GetExecutablePath(LPTSTR lpServiceName); BOOL RefreshServiceList(PMAIN_WND_INFO Info); Modified: trunk/reactos/base/applications/mscutils/servman/propsheet.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/propsheet.c (original) +++ trunk/reactos/base/applications/mscutils/servman/propsheet.c Tue Aug 28 23:54:25 2007 @@ -190,7 +190,39 @@ 0, (LPARAM)szServiceStatus); } -} + + if (dlgInfo->Info->bIsUserAnAdmin) + { + HWND hEdit = GetDlgItem(hwndDlg, + IDC_EDIT); + EnableWindow(hEdit, + TRUE); + } +} + + +SaveDlgInfo(PSERVICEPROPSHEET dlgInfo, + HWND hwndDlg) +{ + LPQUERY_SERVICE_CONFIG pServiceConfig = NULL; + HWND hList; + DWORD StartUp; + + hList = GetDlgItem(hwndDlg, IDC_START_TYPE); + + StartUp = SendMessage(hList, + CB_GETCURSEL, + 0, + 0); + + switch (StartUp) + { + case 0: pServiceConfig->dwStartType = SERVICE_AUTO_START; break; + case 1: pServiceConfig->dwStartType = SERVICE_DEMAND_START; break; + case 2: pServiceConfig->dwStartType = SERVICE_DISABLED; break; + } +} + /* @@ -258,14 +290,25 @@ //SendMessage(Info->hMainWnd, WM_COMMAND, ID_RESUME, 0); break; + case IDC_EDIT: + { + HWND hName, hDesc, hExePath; + + hName = GetDlgItem(hwndDlg, IDC_DISP_NAME); + hDesc = GetDlgItem(hwndDlg, IDC_DESCRIPTION); + hExePath = GetDlgItem(hwndDlg, IDC_EXEPATH); + + SendMessage(hName, EM_SETREADONLY, FALSE, 0); + SendMessage(hDesc, EM_SETREADONLY, FALSE, 0); + SendMessage(hExePath, EM_SETREADONLY, FALSE, 0); + } + break; + case IDC_START_PARAM: PropSheet_Changed(GetParent(hwndDlg), hwndDlg); break; } break; - - case WM_DESTROY: - break; case WM_NOTIFY: { @@ -296,13 +339,13 @@ WPARAM wParam, LPARAM lParam) { - PMAIN_WND_INFO Info; + PSERVICEPROPSHEET dlgInfo; /* Get the window context */ - Info = (PMAIN_WND_INFO)GetWindowLongPtr(hwndDlg, - GWLP_USERDATA); - - if (Info == NULL && uMsg != WM_INITDIALOG) + dlgInfo = (PSERVICEPROPSHEET)GetWindowLongPtr(hwndDlg, + GWLP_USERDATA); + + if (dlgInfo == NULL && uMsg != WM_INITDIALOG) { return FALSE; } @@ -311,12 +354,12 @@ { case WM_INITDIALOG: { - Info = (PMAIN_WND_INFO)(((LPPROPSHEETPAGE)lParam)->lParam); - if (Info != NULL) + dlgInfo = (PSERVICEPROPSHEET)(((LPPROPSHEETPAGE)lParam)->lParam); + if (dlgInfo != NULL) { SetWindowLongPtr(hwndDlg, GWLP_USERDATA, - (LONG_PTR)Info); + (LONG_PTR)dlgInfo); } } break; @@ -324,21 +367,6 @@ case WM_COMMAND: switch(LOWORD(wParam)) { - - } - break; - - case WM_DESTROY: - break; - - case WM_NOTIFY: - { - LPNMHDR lpnm = (LPNMHDR)lParam; - - switch (lpnm->code) - { - - } } break; @@ -404,7 +432,7 @@ ZeroMemory(&psh, sizeof(PROPSHEETHEADER)); psh.dwSize = sizeof(PROPSHEETHEADER); - psh.dwFlags = PSH_PROPSHEETPAGE | PSH_PROPTITLE | PSH_USECALLBACK; + psh.dwFlags = PSH_PROPSHEETPAGE | PSH_PROPTITLE | PSH_USECALLBACK;// | PSH_MODELESS; psh.hwndParent = Info->hMainWnd; psh.hInstance = hInstance; psh.hIcon = LoadIcon(hInstance, MAKEINTRESOURCE(IDI_SM_ICON)); Modified: trunk/reactos/base/applications/mscutils/servman/query.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/query.c (original) +++ trunk/reactos/base/applications/mscutils/servman/query.c Tue Aug 28 23:54:25 2007 @@ -87,6 +87,13 @@ CloseServiceHandle(hSc); return pServiceConfig; +} + + +VOID +SetServiceConfig(LPQUERY_SERVICE_CONFIG pServiceConfig) +{ + } @@ -159,7 +166,6 @@ return lpDescription; } - Modified: trunk/reactos/base/applications/mscutils/servman/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/resource.h (original) +++ trunk/reactos/base/applications/mscutils/servman/resource.h Tue Aug 28 23:54:25 2007 @@ -132,6 +132,7 @@ #define IDC_PAUSE 10151 #define IDC_RESUME 10161 #define IDC_START_PARAM 10191 +#define IDC_EDIT 10192 /* dependancies dialog */ #define IDD_DLG_DEPEND 20001 Modified: trunk/reactos/base/applications/mscutils/servman/start.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/start.c (original) +++ trunk/reactos/base/applications/mscutils/servman/start.c Tue Aug 28 23:54:25 2007 @@ -19,107 +19,90 @@ DWORD BytesNeeded = 0; INT ArgCount = 0; DWORD dwStartTickCount, dwOldCheckPoint; + BOOL bRet = FALSE; - /* open handle to the SCM */ hSCManager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); if (hSCManager == NULL) { - GetError(); - return FALSE; - } + hSc = OpenService(hSCManager, + Info->pCurrentService->lpServiceName, + SERVICE_ALL_ACCESS); + if (hSc != NULL) + { + if (StartService(hSc, + ArgCount, + NULL)) + { + if (QueryServiceStatusEx(hSc, + SC_STATUS_PROCESS_INFO, + (LPBYTE)&ServiceStatus, + sizeof(SERVICE_STATUS_PROCESS), + &BytesNeeded)) + { + dwStartTickCount = GetTickCount(); + dwOldCheckPoint = ServiceStatus.dwCheckPoint; - /* get a handle to the service requested for starting */ - hSc = OpenService(hSCManager, - Info->pCurrentService->lpServiceName, - SERVICE_ALL_ACCESS); - if (hSc == NULL) - { - GetError(); - return FALSE; - } + while (ServiceStatus.dwCurrentState != SERVICE_RUNNING) + { + DWORD dwWaitTime; - /* start the service opened */ - if (! StartService(hSc, - ArgCount, - NULL)) - { - GetError(); - return FALSE; - } + dwWaitTime = ServiceStatus.dwWaitHint / 10; - /* query the state of the service */ - if (! QueryServiceStatusEx(hSc, - SC_STATUS_PROCESS_INFO, - (LPBYTE)&ServiceStatus, - sizeof(SERVICE_STATUS_PROCESS), - &BytesNeeded)) - { - GetError(); - return FALSE; - } + if(dwWaitTime < 1000) + dwWaitTime = 500; + else if (dwWaitTime > 10000) + dwWaitTime = 10000; - /* Save the tick count and initial checkpoint. */ - dwStartTickCount = GetTickCount(); - dwOldCheckPoint = ServiceStatus.dwCheckPoint; + IncrementProgressBar(hProgDlg); + Sleep(dwWaitTime ); + IncrementProgressBar(hProgDlg); - /* loop whilst service is not running */ - /* FIXME: needs more control adding. 'Loop' is temparary */ - while (ServiceStatus.dwCurrentState != SERVICE_RUNNING) - { - DWORD dwWaitTime; + if (!QueryServiceStatusEx(hSc, + SC_STATUS_PROCESS_INFO, + (LPBYTE)&ServiceStatus, + sizeof(SERVICE_STATUS_PROCESS), + &BytesNeeded)) + { + break; + } - dwWaitTime = ServiceStatus.dwWaitHint / 10; - - if( dwWaitTime < 500 ) - dwWaitTime = 500; - else if ( dwWaitTime > 5000 ) - dwWaitTime = 5000; - - IncrementProgressBar(hProgDlg); - - /* wait before checking status */ - Sleep(ServiceStatus.dwWaitHint / 8); - - /* check status again */ - if (! QueryServiceStatusEx(hSc, - SC_STATUS_PROCESS_INFO, - (LPBYTE)&ServiceStatus, - sizeof(SERVICE_STATUS_PROCESS), - &BytesNeeded)) - { - GetError(); - return FALSE; + if (ServiceStatus.dwCheckPoint > dwOldCheckPoint) + { + /* The service is making progress, increment the progress bar */ + IncrementProgressBar(hProgDlg); + dwStartTickCount = GetTickCount(); + dwOldCheckPoint = ServiceStatus.dwCheckPoint; + } + else + { + if(GetTickCount() - dwStartTickCount > ServiceStatus.dwWaitHint) + { + /* No progress made within the wait hint */ + break; + } + } + } + } + } + + CloseServiceHandle(hSc); } - if (ServiceStatus.dwCheckPoint > dwOldCheckPoint) - { - /* The service is making progress. increment the progress bar */ - IncrementProgressBar(hProgDlg); - dwStartTickCount = GetTickCount(); - dwOldCheckPoint = ServiceStatus.dwCheckPoint; - } - else - { - if(GetTickCount() - dwStartTickCount > ServiceStatus.dwWaitHint) - { - /* No progress made within the wait hint */ - break; - } - } + CloseServiceHandle(hSCManager); } - - CloseServiceHandle(hSc); if (ServiceStatus.dwCurrentState == SERVICE_RUNNING) { CompleteProgressBar(hProgDlg); Sleep(1000); - return TRUE; + bRet = TRUE; } else - return FALSE; + GetError(); + + return bRet; }

1 0

[cfinck] 28629: Merge 28572:28574 ("make depends" fixes)
by cfinck＠svn.reactos.org 28 Aug '07

28 Aug '07

Author: cfinck Date: Tue Aug 28 23:50:18 2007 New Revision: 28629 URL: http://svn.reactos.org/svn/reactos?rev=28629&view=rev Log: Merge 28572:28574 ("make depends" fixes) Modified: branches/ros-branch-0_3_3-new/reactos/Makefile branches/ros-branch-0_3_3-new/reactos/tools/rbuild/backend/mingw/modulehandler.cpp Modified: branches/ros-branch-0_3_3-new/reactos/Makefile URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_3-new/reactos/Ma… ============================================================================== --- branches/ros-branch-0_3_3-new/reactos/Makefile (original) +++ branches/ros-branch-0_3_3-new/reactos/Makefile Tue Aug 28 23:50:18 2007 @@ -420,7 +420,6 @@ ${mkdir} $(OUTPUT_)media$(SEP)inf 2>$(NUL) $(ECHO_RBUILD) $(Q)$(RBUILD_TARGET) $(RBUILD_FLAGS) $(ROS_RBUILDFLAGS) mingw - @$(MAKE) psdk world: all bootcd livecd @@ -625,6 +624,6 @@ clean: makefile_auto_clean .PHONY: depends -depends: - @-$(rm) makefile.auto - @$(MAKE) $(filter-out depends, $(MAKECMDGOALS)) +depends: $(RBUILD_TARGET) + $(ECHO_RBUILD) + $(Q)$(RBUILD_TARGET) $(RBUILD_FLAGS) $(ROS_RBUILDFLAGS) mingw Modified: branches/ros-branch-0_3_3-new/reactos/tools/rbuild/backend/mingw/modulehandler.cpp URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_3-new/reactos/to… ============================================================================== --- branches/ros-branch-0_3_3-new/reactos/tools/rbuild/backend/mingw/modulehandler.cpp (original) +++ branches/ros-branch-0_3_3-new/reactos/tools/rbuild/backend/mingw/modulehandler.cpp Tue Aug 28 23:50:18 2007 @@ -615,7 +615,7 @@ fprintf ( fMakefile, "\t$(ECHO_RBUILD)\n" ); fprintf ( fMakefile, - "\t$(Q)$(RBUILD_TARGET) -dm%s mingw\n", + "\t$(Q)$(RBUILD_TARGET) $(RBUILD_FLAGS) -dm%s mingw\n", module.name.c_str () ); } @@ -2193,6 +2193,11 @@ && module.name != "hostzlib" ) dependencies.push_back ( "$(INIT)" ); + + if ( module.type != BuildTool + && module.name != "psdk" ) + + dependencies.push_back ( "$(PSDK_TARGET)" ); } void

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
67
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2007