Author: greatlrd
Date: Thu Aug 23 23:56:57 2007
New Revision: 28487
URL: http://svn.reactos.org/svn/reactos?rev=28487&view=rev
Log:
commit my verify list with api that been tested and works same/simluare as windows xp, in windows 2000/xp
Added:
trunk/reactos/dll/win32/gdi32/good api.def (with props)
Added: trunk/reactos/dll/win32/gdi32/good api.def
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/good%20api…
==============================================================================
--- trunk/reactos/dll/win32/gdi32/good api.def (added)
+++ trunk/reactos/dll/win32/gdi32/good api.def Thu Aug 23 23:56:57 2007
@@ -1,0 +1,30 @@
+; gdi32.def
+;
+; ReactOS Operating System
+; Api List that have been verify it works same as windows XP
+; and no bugs have been found in gdi32.dll, but bugs
+; can still exists, for it have not been checked in win32k.sys
+; if bugs exists their or verify
+;
+
+BRUSHOBJ_pvAllocRbrush@8
+BRUSHOBJ_pvGetRbrush@4
+BRUSHOBJ_ulGetBrushColor@4
+CreateEllipticRgn@16
+CreatePenIndirect@4
+BRUSHOBJ_hGetColorTransform@4
+CLIPOBJ_ppoGetPath@4
+CreatePalette@4
+ChoosePixelFormat@8
+CreateEllipticRgnIndirect@4
+CLIPOBJ_bEnum@12
+CreateRoundRectRgn@24
+AddFontResourceExW@12
+CreateRectRgnIndirect@4
+CombineTransform@12
+CreateHalftonePalette@4
+CreateDiscardableBitmap@12
+CLIPOBJ_cEnumStart@20
+AnyLinkedFonts@0
+AddFontResourceA@4
+AddFontResourceW@4
Propchange: trunk/reactos/dll/win32/gdi32/good api.def
------------------------------------------------------------------------------
svn:eol-style = native
Author: fireball
Date: Thu Aug 23 23:41:38 2007
New Revision: 28486
URL: http://svn.reactos.org/svn/reactos?rev=28486&view=rev
Log:
- Set NULL Io cancel routine, fixes an assert when using usb storage driver.
Modified:
trunk/reactos/drivers/usb/nt4compat/usbdriver/umss.c
Modified: trunk/reactos/drivers/usb/nt4compat/usbdriver/umss.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/nt4compat/usbd…
==============================================================================
--- trunk/reactos/drivers/usb/nt4compat/usbdriver/umss.c (original)
+++ trunk/reactos/drivers/usb/nt4compat/usbdriver/umss.c Thu Aug 23 23:41:38 2007
@@ -1449,6 +1449,7 @@
//this device has its irp queued
if (status == STATUS_CANCELLED)
{
+ usb_dbg_print(DBGLVL_MAXIMUM, ("umss_complete_request(): status of irp is cancelled\n"));
IoAcquireCancelSpinLock(&old_irql);
if (dev_obj->CurrentIrp == pirp)
{
@@ -1462,8 +1463,15 @@
}
}
else
+ {
// all requests come to this point from the irp queue
IoStartNextPacket(dev_obj, FALSE);
+
+ // we are going to complete the request, so set it's cancel routine to NULL
+ IoAcquireCancelSpinLock(&old_irql);
+ (void)IoSetCancelRoutine(pirp, NULL);
+ IoReleaseCancelSpinLock(old_irql);
+ }
pirp->IoStatus.Status = status;
Author: greatlrd
Date: Thu Aug 23 23:21:16 2007
New Revision: 28484
URL: http://svn.reactos.org/svn/reactos?rev=28484&view=rev
Log:
remove redirect of CreatePolyPolygonRgn@16 and implement own stub for it, it is hacked, it should doing, return (HRGN) NtGdiPolyPolyDraw(fnPolyFillMode, lppt, lpPolyCounts, nCount, 6 );
remove redirect of CreatePolygonRgn@12 and implement own stub for it, it is hacked, it should doing return NtGdiPolyPolyDraw(fnPolyFillMode,lppt,cPoints,1,6);
remove redirect of CreateRectRgn@16 and implement own stub for it, some part need be done in user mode
Fix CreateRectRgnIndirect it call now on CreateRectRgn for some part need be done in user mode, and it crash if NULL comes in as param, like windows does.
Fix CreatePenIndirect ir call now on CreatePen for some stuff need be done in user mode.
Add comment to CreatePen it need be fix.
Modified:
trunk/reactos/dll/win32/gdi32/gdi32.def
trunk/reactos/dll/win32/gdi32/objects/pen.c
trunk/reactos/dll/win32/gdi32/objects/region.c
Modified: trunk/reactos/dll/win32/gdi32/gdi32.def
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/gdi32.def?…
==============================================================================
--- trunk/reactos/dll/win32/gdi32/gdi32.def (original)
+++ trunk/reactos/dll/win32/gdi32/gdi32.def Thu Aug 23 23:21:16 2007
@@ -76,19 +76,19 @@
CreateMetaFileW@4
CreatePalette@4
CreatePatternBrush@4
-
-ClearBitmapAttributes@8
-ClearBrushAttributes@8
CreatePen@12
CreatePenIndirect@4
-CreatePolyPolygonRgn@16=NtGdiCreatePolyPolygonRgn@16
-CreatePolygonRgn@12=NtGdiCreatePolygonRgn@12
-CreateRectRgn@16=NtGdiCreateRectRgn@16
+CreatePolyPolygonRgn@16
+CreatePolygonRgn@12
+CreateRectRgn@16
CreateRectRgnIndirect@4
CreateRoundRectRgn@24=NtGdiCreateRoundRectRgn@24
CreateScalableFontResourceA@16
CreateScalableFontResourceW@16
CreateSolidBrush@4
+
+ClearBitmapAttributes@8
+ClearBrushAttributes@8
DPtoLP@12
DeleteColorSpace@4
DeleteDC@4
Modified: trunk/reactos/dll/win32/gdi32/objects/pen.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/objects/pe…
==============================================================================
--- trunk/reactos/dll/win32/gdi32/objects/pen.c (original)
+++ trunk/reactos/dll/win32/gdi32/objects/pen.c Thu Aug 23 23:21:16 2007
@@ -8,19 +8,10 @@
*/
HPEN WINAPI
CreatePenIndirect(
- const LOGPEN *plgpn)
+ const LOGPEN *lplgpn)
{
- if (plgpn)
- {
- return NtGdiCreatePen(plgpn->lopnStyle,
- /* FIXME: MSDN says in docs for LOGPEN:
- "If the pointer member is NULL, the pen is one pixel
- wide on raster devices." Do we need to handle this? */
- plgpn->lopnWidth.x,
- plgpn->lopnColor,
- NULL);
- }
- return NULL;
+ /* Note same behoir as Windows 2000/XP/VISTA, they do not care if plgpn is NULL´, it will crash */
+ return CreatePen(lplgpn->lopnStyle, lplgpn->lopnWidth.x, lplgpn->lopnColor);
}
/*
@@ -32,6 +23,7 @@
int nWidth,
COLORREF crColor)
{
+ /* FIXME Some part need be done in user mode */
return NtGdiCreatePen(nPenStyle, nWidth, crColor, NULL);
}
Modified: trunk/reactos/dll/win32/gdi32/objects/region.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/objects/re…
==============================================================================
--- trunk/reactos/dll/win32/gdi32/objects/region.c (original)
+++ trunk/reactos/dll/win32/gdi32/objects/region.c Thu Aug 23 23:21:16 2007
@@ -24,30 +24,41 @@
HRGN hrgn
)
{
- return NtGdiGetRandomRgn(hdc, hrgn, 1);
+ return NtGdiGetRandomRgn(hdc, hrgn, 1);
}
HRGN
WINAPI
-CreatePolygonRgn( const POINT* Point, int Count, int Mode)
+CreatePolygonRgn( const POINT* lppt, int cPoints, int fnPolyFillMode)
{
- return CreatePolyPolygonRgn(Point, (const INT*)&Count, 1, Mode);
+ /* FIXME NtGdiPolyPolyDraw */
+#if 0
+ return NtGdiPolyPolyDraw(fnPolyFillMode,lppt,cPoints,1,6);
+#else
+ return CreatePolyPolygonRgn(lppt, (const INT*)&cPoints, 1, fnPolyFillMode);
+#endif
}
HRGN
WINAPI
-CreatePolyPolygonRgn( const POINT* Point,
- const INT* Count,
- int inPolygons,
- int Mode)
+CreatePolyPolygonRgn( const POINT* lppt,
+ const INT* lpPolyCounts,
+ int nCount,
+ int fnPolyFillMode)
{
- return (HRGN) NtGdiPolyPolyDraw( (HDC) Mode,
- (PPOINT) Point,
- (PULONG) Count,
- (ULONG) inPolygons,
+ /* FIXME NtGdiPolyPolyDraw */
+#if 0
+ return (HRGN) NtGdiPolyPolyDraw( (HDC) fnPolyFillMode,
+ (PPOINT) lppt,
+ (PULONG) lpPolyCounts,
+ (ULONG) nCount,
GdiPolyPolyRgn );
+#else
+ return NtGdiCreatePolyPolygonRgn( (PPOINT)lppt, (PINT)lpPolyCounts, nCount, fnPolyFillMode);
+#endif
+
}
HRGN
@@ -61,18 +72,22 @@
}
+HRGN
+WINAPI
+CreateRectRgn(int x1, int y1, int x2,int y2)
+{
+ /* FIXME Some part need be done in user mode */
+ return NtGdiCreateRectRgn(x1,y1,x2,y2);
+}
+
+
HRGN
WINAPI
CreateRectRgnIndirect(
const RECT *prc
)
{
- if (prc)
- {
- return NtGdiCreateRectRgn(prc->left,
- prc->top,
- prc->right,
- prc->bottom);
- }
- return NULL;
+ /* Notes if prc is NULL it will crash on All Windows NT I checked 2000/XP/VISTA */
+ return CreateRectRgn(prc->left, prc->top, prc->right, prc->bottom);
+
}
Author: tkreuzer
Date: Thu Aug 23 21:28:24 2007
New Revision: 28481
URL: http://svn.reactos.org/svn/reactos?rev=28481&view=rev
Log:
move NtGdiGetSetBoundsrect from paintobj.c to dc.c, remove paintobj.c
Removed:
trunk/reactos/subsystems/win32/win32k/objects/paintobj.c
Modified:
trunk/reactos/subsystems/win32/win32k/objects/dc.c
trunk/reactos/subsystems/win32/win32k/win32k.rbuild
Modified: trunk/reactos/subsystems/win32/win32k/objects/dc.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/dc.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/dc.c Thu Aug 23 21:28:24 2007
@@ -3168,4 +3168,26 @@
return Ret;
}
+DWORD
+APIENTRY
+NtGdiGetBoundsRect(
+ IN HDC hdc,
+ OUT LPRECT prc,
+ IN DWORD f)
+{
+ DPRINT("stub");
+ return DCB_RESET; /* bounding rectangle always empty */
+}
+
+DWORD
+APIENTRY
+NtGdiSetBoundsRect(
+ IN HDC hdc,
+ IN LPRECT prc,
+ IN DWORD f)
+{
+ DPRINT("stub");
+ return DCB_DISABLE; /* bounding rectangle always empty */
+}
+
/* EOF */
Removed: trunk/reactos/subsystems/win32/win32k/objects/paintobj.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/paintobj.c (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/paintobj.c (removed)
@@ -1,47 +1,0 @@
-/*
- * ReactOS W32 Subsystem
- * Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003 ReactOS Team
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- */
-/* $Id$ */
-
-#include <w32k.h>
-
-#define NDEBUG
-#include <debug.h>
-
-DWORD
-APIENTRY
-NtGdiGetBoundsRect(
- IN HDC hdc,
- OUT LPRECT prc,
- IN DWORD f)
-{
- DPRINT("stub");
- return DCB_RESET; /* bounding rectangle always empty */
-}
-
-DWORD
-APIENTRY
-NtGdiSetBoundsRect(
- IN HDC hdc,
- IN LPRECT prc,
- IN DWORD f)
-{
- DPRINT("stub");
- return DCB_DISABLE; /* bounding rectangle always empty */
-}
-/* EOF */
Modified: trunk/reactos/subsystems/win32/win32k/win32k.rbuild
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/wi…
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/win32k.rbuild (original)
+++ trunk/reactos/subsystems/win32/win32k/win32k.rbuild Thu Aug 23 21:28:24 2007
@@ -148,7 +148,6 @@
<file>icm.c</file>
<file>line.c</file>
<file>metafile.c</file>
- <file>paintobj.c</file>
<file>palobj.c</file>
<file>path.c</file>
<file>pen.c</file>