Ros-diffs January 2008

ros-diffs@reactos.org

24 participants
539 discussions

[hpoussin] 31860: Shuffle functions to look more like in Wine. Add a few stubs

by hpoussin＠svn.reactos.org

Author: hpoussin Date: Fri Jan 18 14:51:01 2008 New Revision: 31860 URL: http://svn.reactos.org/svn/reactos?rev=31860&view=rev Log: Shuffle functions to look more like in Wine. Add a few stubs Modified: trunk/reactos/dll/win32/setupapi/devclass.c trunk/reactos/dll/win32/setupapi/devinst.c trunk/reactos/dll/win32/setupapi/interface.c trunk/reactos/dll/win32/setupapi/res/lang/Cs.rc trunk/reactos/dll/win32/setupapi/setupapi.spec trunk/reactos/dll/win32/setupapi/setupapi_private.h trunk/reactos/dll/win32/setupapi/stringtable.c trunk/reactos/dll/win32/setupapi/stubs.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/dll/win32/setupapi/devclass.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/devclas… Modified: trunk/reactos/dll/win32/setupapi/devinst.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/devinst… Modified: trunk/reactos/dll/win32/setupapi/interface.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/interfa… Modified: trunk/reactos/dll/win32/setupapi/res/lang/Cs.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/res/lan… Modified: trunk/reactos/dll/win32/setupapi/setupapi.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/setupap… Modified: trunk/reactos/dll/win32/setupapi/setupapi_private.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/setupap… Modified: trunk/reactos/dll/win32/setupapi/stringtable.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/stringt… Modified: trunk/reactos/dll/win32/setupapi/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/stubs.c…

17 years

[cwittich] 31859: Rob Shearman : rpcrt4: Handle complex arrays in calc_arg_size. <rob at codeweavers.com>

by cwittich＠svn.reactos.org

Author: cwittich Date: Fri Jan 18 14:38:47 2008 New Revision: 31859 URL: http://svn.reactos.org/svn/reactos?rev=31859&view=rev Log: Rob Shearman : rpcrt4: Handle complex arrays in calc_arg_size. <rob at codeweavers.com> Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c trunk/reactos/dll/win32/rpcrt4/ndr_misc.h trunk/reactos/dll/win32/rpcrt4/ndr_stubless.c Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_marsh… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c (original) +++ trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c Fri Jan 18 14:38:47 2008 @@ -2655,8 +2655,8 @@ return size; } -static unsigned long ComplexStructSize(PMIDL_STUB_MESSAGE pStubMsg, - PFORMAT_STRING pFormat) +unsigned long ComplexStructSize(PMIDL_STUB_MESSAGE pStubMsg, + PFORMAT_STRING pFormat) { PFORMAT_STRING desc; unsigned long size = 0; Modified: trunk/reactos/dll/win32/rpcrt4/ndr_misc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_misc.… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/ndr_misc.h (original) +++ trunk/reactos/dll/win32/rpcrt4/ndr_misc.h Fri Jan 18 14:38:47 2008 @@ -62,4 +62,6 @@ extern const NDR_MEMORYSIZE NdrMemorySizer[]; extern const NDR_FREE NdrFreer[]; +unsigned long ComplexStructSize(PMIDL_STUB_MESSAGE pStubMsg, PFORMAT_STRING pFormat); + #endif /* __WINE_NDR_MISC_H */ Modified: trunk/reactos/dll/win32/rpcrt4/ndr_stubless.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_stubl… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/ndr_stubless.c (original) +++ trunk/reactos/dll/win32/rpcrt4/ndr_stubless.c Fri Jan 18 14:38:47 2008 @@ -849,6 +849,12 @@ case RPC_FC_LGFARRAY: size = *(const DWORD*)(pFormat + 2); break; + case RPC_FC_BOGUS_ARRAY: + pFormat = ComputeConformance(pStubMsg, NULL, pFormat + 4, *(const WORD*)&pFormat[2]); + TRACE("conformance = %ld\n", pStubMsg->MaxCount); + pFormat = ComputeVariance(pStubMsg, NULL, pFormat, pStubMsg->MaxCount); + size = ComplexStructSize(pStubMsg, pFormat); + size *= pStubMsg->MaxCount; default: FIXME("Unhandled type %02x\n", *pFormat); /* fallthrough */

17 years

[cwittich] 31858: rpcrt4: Fix the calculation of element sizes for complex arrays by using a new function ComplexStructSize that doesn 't touch the buffer to calculate the size. <rob at codeweavers.com>

by cwittich＠svn.reactos.org

Author: cwittich Date: Fri Jan 18 14:35:06 2008 New Revision: 31858 URL: http://svn.reactos.org/svn/reactos?rev=31858&view=rev Log: rpcrt4: Fix the calculation of element sizes for complex arrays by using a new function ComplexStructSize that doesn 't touch the buffer to calculate the size. <rob at codeweavers.com> Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_marsh… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c (original) +++ trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c Fri Jan 18 14:35:06 2008 @@ -2655,6 +2655,69 @@ return size; } +static unsigned long ComplexStructSize(PMIDL_STUB_MESSAGE pStubMsg, + PFORMAT_STRING pFormat) +{ + PFORMAT_STRING desc; + unsigned long size = 0; + + while (*pFormat != RPC_FC_END) { + switch (*pFormat) { + case RPC_FC_BYTE: + case RPC_FC_CHAR: + case RPC_FC_SMALL: + case RPC_FC_USMALL: + size += 1; + break; + case RPC_FC_WCHAR: + case RPC_FC_SHORT: + case RPC_FC_USHORT: + size += 2; + break; + case RPC_FC_LONG: + case RPC_FC_ULONG: + case RPC_FC_ENUM32: + size += 4; + break; + case RPC_FC_HYPER: + size += 8; + break; + case RPC_FC_POINTER: + size += sizeof(void *); + break; + case RPC_FC_ALIGNM4: + ALIGN_LENGTH(size, 4); + break; + case RPC_FC_ALIGNM8: + ALIGN_LENGTH(size, 8); + break; + case RPC_FC_STRUCTPAD1: + case RPC_FC_STRUCTPAD2: + case RPC_FC_STRUCTPAD3: + case RPC_FC_STRUCTPAD4: + case RPC_FC_STRUCTPAD5: + case RPC_FC_STRUCTPAD6: + case RPC_FC_STRUCTPAD7: + size += *pFormat - RPC_FC_STRUCTPAD1 + 1; + break; + case RPC_FC_EMBEDDED_COMPLEX: + size += pFormat[1]; + pFormat += 2; + desc = pFormat + *(const SHORT*)pFormat; + size += EmbeddedComplexSize(pStubMsg, desc); + pFormat += 2; + continue; + case RPC_FC_PAD: + break; + default: + FIXME("unhandled format 0x%02x\n", *pFormat); + } + pFormat++; + } + + return size; +} + /*********************************************************************** * NdrComplexStructMarshall [RPCRT4.@] */ @@ -3453,7 +3516,6 @@ { ULONG i, count, esize, SavedMemorySize, MemorySize; unsigned char alignment; - unsigned char *Buffer; TRACE("(%p,%p)\n", pStubMsg, pFormat); @@ -3475,11 +3537,7 @@ SavedMemorySize = pStubMsg->MemorySize; - Buffer = pStubMsg->Buffer; - pStubMsg->MemorySize = 0; - esize = ComplexStructMemorySize(pStubMsg, pFormat); - pStubMsg->Buffer = Buffer; - + esize = ComplexStructSize(pStubMsg, pFormat); MemorySize = safe_multiply(pStubMsg->MaxCount, esize); count = pStubMsg->ActualCount;

17 years

[cwittich] 31857: rpcrt4: Add support for calculating the memory size of complex types with embedded non-conformant strings. <rob at codeweavers.com>

by cwittich＠svn.reactos.org

Author: cwittich Date: Fri Jan 18 14:28:18 2008 New Revision: 31857 URL: http://svn.reactos.org/svn/reactos?rev=31857&view=rev Log: rpcrt4: Add support for calculating the memory size of complex types with embedded non-conformant strings. <rob at codeweavers.com> Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_marsh… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c (original) +++ trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c Fri Jan 18 14:28:18 2008 @@ -2127,6 +2127,7 @@ case RPC_FC_BOGUS_STRUCT: case RPC_FC_SMFARRAY: case RPC_FC_SMVARRAY: + case RPC_FC_CSTRING: return *(const WORD*)&pFormat[2]; case RPC_FC_USER_MARSHAL: return *(const WORD*)&pFormat[4]; @@ -2141,6 +2142,8 @@ return *(const SHORT*)pFormat; case RPC_FC_IP: return sizeof(void *); + case RPC_FC_WSTRING: + return *(const WORD*)&pFormat[2] * 2; default: FIXME("unhandled embedded type %02x\n", *pFormat); }

17 years

[cwittich] 31856: rpcrt4: Allocate a context handle if a NULL GUID is being unmarshalled. <rob at codeweavers.com>

by cwittich＠svn.reactos.org

Author: cwittich Date: Fri Jan 18 14:25:21 2008 New Revision: 31856 URL: http://svn.reactos.org/svn/reactos?rev=31856&view=rev Log: rpcrt4: Allocate a context handle if a NULL GUID is being unmarshalled. <rob at codeweavers.com> Modified: trunk/reactos/dll/win32/rpcrt4/ndr_contexthandle.c Modified: trunk/reactos/dll/win32/rpcrt4/ndr_contexthandle.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_conte… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/ndr_contexthandle.c (original) +++ trunk/reactos/dll/win32/rpcrt4/ndr_contexthandle.c Fri Jan 18 14:25:21 2008 @@ -312,6 +312,7 @@ RpcBinding *binding = hBinding; NDR_SCONTEXT SContext; RPC_STATUS status; + const ndr_context_handle *context_ndr = pBuff; TRACE("(%p %p %08x %p %u)\n", hBinding, pBuff, DataRepresentation, CtxGuard, Flags); @@ -319,12 +320,12 @@ if (!binding->server || !binding->Assoc) RpcRaiseException(ERROR_INVALID_HANDLE); - if (!pBuff) + if (!pBuff || (!context_ndr->attributes && + UuidIsNil((UUID *)&context_ndr->uuid, &status))) status = RpcServerAssoc_AllocateContextHandle(binding->Assoc, CtxGuard, &SContext); else { - const ndr_context_handle *context_ndr = pBuff; if (context_ndr->attributes) { ERR("non-null attributes 0x%x\n", context_ndr->attributes);

17 years

[cwittich] 31855: rpcrt4: Don't print fixmes for NDR types without a freeing function. rpcrt4: Add traces to the start of TowerConstruct and TowerExplode. <rob at codeweavers.com>

by cwittich＠svn.reactos.org

Author: cwittich Date: Fri Jan 18 14:22:16 2008 New Revision: 31855 URL: http://svn.reactos.org/svn/reactos?rev=31855&view=rev Log: rpcrt4: Don't print fixmes for NDR types without a freeing function. rpcrt4: Add traces to the start of TowerConstruct and TowerExplode. <rob at codeweavers.com> Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c trunk/reactos/dll/win32/rpcrt4/rpc_epmap.c Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_marsh… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c (original) +++ trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c Fri Jan 18 14:22:16 2008 @@ -2566,7 +2566,6 @@ else m(pStubMsg, pMemory, desc); } - else FIXME("no freer for embedded type %02x\n", *desc); pMemory += size; pFormat += 2; continue; @@ -5243,7 +5242,6 @@ m(pStubMsg, pMemory, desc); } } - else FIXME("no freer for embedded type %02x\n", *desc); } } Modified: trunk/reactos/dll/win32/rpcrt4/rpc_epmap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpc_epmap… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/rpc_epmap.c (original) +++ trunk/reactos/dll/win32/rpcrt4/rpc_epmap.c Fri Jan 18 14:22:16 2008 @@ -267,6 +267,9 @@ const twr_uuid_floor_t *object_floor; const twr_uuid_floor_t *syntax_floor; + TRACE("(%p, %p, %p, %p, %p, %p)\n", tower, object, syntax, protseq, + endpoint, address); + if (protseq) *protseq = NULL; if (endpoint) @@ -336,6 +339,9 @@ twr_uuid_floor_t *object_floor; twr_uuid_floor_t *syntax_floor; + TRACE("(%p, %p, %s, %s, %s, %p)\n", object, syntax, debugstr_a(protseq), + debugstr_a(endpoint), debugstr_a(address), tower); + *tower = NULL; status = RpcTransport_GetTopOfTower(NULL, &tower_size, protseq, address, endpoint);

17 years

[cwittich] 31854: widl: Fix context handle "cannot be null" detection. The "cannot be null" attibute is applied to a parameter if and only if it is in-only. widl: Fix the conditions under which array freeing code is output. It doesn't matter whether or not the array is declared as a pointer or is declared using array subscripts - the array is still allocated by the unmarshalling function and so needs to be freed. <rob at codeweavers.com>

by cwittich＠svn.reactos.org

Author: cwittich Date: Fri Jan 18 14:17:50 2008 New Revision: 31854 URL: http://svn.reactos.org/svn/reactos?rev=31854&view=rev Log: widl: Fix context handle "cannot be null" detection. The "cannot be null" attibute is applied to a parameter if and only if it is in-only. widl: Fix the conditions under which array freeing code is output. It doesn't matter whether or not the array is declared as a pointer or is declared using array subscripts - the array is still allocated by the unmarshalling function and so needs to be freed. <rob at codeweavers.com> Modified: trunk/reactos/tools/widl/typegen.c Modified: trunk/reactos/tools/widl/typegen.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/typegen.c?rev=3… ============================================================================== --- trunk/reactos/tools/widl/typegen.c (original) +++ trunk/reactos/tools/widl/typegen.c Fri Jan 18 14:17:50 2008 @@ -2059,13 +2059,13 @@ unsigned char flags = 0x08 /* strict */; if (is_ptr(type)) - { flags |= 0x80; - if (type->type != RPC_FC_RP) + if (is_attr(var->attrs, ATTR_IN)) + { + flags |= 0x40; + if (!is_attr(var->attrs, ATTR_OUT)) flags |= 0x01; } - if (is_attr(var->attrs, ATTR_IN)) - flags |= 0x40; if (is_attr(var->attrs, ATTR_OUT)) flags |= 0x20; @@ -2807,15 +2807,13 @@ if (pointer_type != RPC_FC_RP) array_type = "Pointer"; print_phase_function(file, indent, array_type, phase, var, start_offset); - if (phase == PHASE_FREE && type->declarray && pointer_type == RPC_FC_RP) - { - /* these are all unmarshalled by pointing into the buffer on the - * server side */ + if (phase == PHASE_FREE && pointer_type == RPC_FC_RP) + { + /* these are all unmarshalled by allocating memory */ if (type->type == RPC_FC_BOGUS_ARRAY || type->type == RPC_FC_CVARRAY || - (type->type == RPC_FC_SMVARRAY && type->type == RPC_FC_LGVARRAY && in_attr) || - (type->type == RPC_FC_CARRAY && type->type == RPC_FC_CARRAY && !in_attr)) - { + ((type->type == RPC_FC_SMVARRAY || type->type == RPC_FC_LGVARRAY) && in_attr) || + (type->type == RPC_FC_CARRAY && !in_attr)) { print_file(file, indent, "if (%s)\n", var->name); indent++; print_file(file, indent, "_StubMsg.pfnFree(%s);\n", var->name);

17 years

[cwittich] 31853: rpcrt4: Don't set Buffer to NULL in I_RpcFreeBuffer. <rob at codeweavers.com>

by cwittich＠svn.reactos.org

Author: cwittich Date: Fri Jan 18 13:42:16 2008 New Revision: 31853 URL: http://svn.reactos.org/svn/reactos?rev=31853&view=rev Log: rpcrt4: Don't set Buffer to NULL in I_RpcFreeBuffer. <rob at codeweavers.com> Modified: trunk/reactos/dll/win32/rpcrt4/rpc_message.c Modified: trunk/reactos/dll/win32/rpcrt4/rpc_message.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpc_messa… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/rpc_message.c (original) +++ trunk/reactos/dll/win32/rpcrt4/rpc_message.c Fri Jan 18 13:42:16 2008 @@ -917,12 +917,10 @@ RPC_STATUS WINAPI I_RpcGetBuffer(PRPC_MESSAGE pMsg) { TRACE("(%p): BufferLength=%d\n", pMsg, pMsg->BufferLength); - /* FIXME: pfnAllocate? */ pMsg->Buffer = HeapAlloc(GetProcessHeap(), 0, pMsg->BufferLength); TRACE("Buffer=%p\n", pMsg->Buffer); - /* FIXME: which errors to return? */ - return pMsg->Buffer ? S_OK : E_OUTOFMEMORY; + return pMsg->Buffer ? RPC_S_OK : ERROR_OUTOFMEMORY; } /*********************************************************************** @@ -934,7 +932,7 @@ pMsg->Buffer = HeapReAlloc(GetProcessHeap(), 0, pMsg->Buffer, pMsg->BufferLength); TRACE("Buffer=%p\n", pMsg->Buffer); - return pMsg->Buffer ? RPC_S_OK : RPC_S_OUT_OF_RESOURCES; + return pMsg->Buffer ? RPC_S_OK : ERROR_OUTOFMEMORY; } /*********************************************************************** @@ -955,10 +953,8 @@ RPC_STATUS WINAPI I_RpcFreeBuffer(PRPC_MESSAGE pMsg) { TRACE("(%p) Buffer=%p\n", pMsg, pMsg->Buffer); - /* FIXME: pfnFree? */ HeapFree(GetProcessHeap(), 0, pMsg->Buffer); - pMsg->Buffer = NULL; - return S_OK; + return RPC_S_OK; } /***********************************************************************

17 years

[cwittich] 31852: rpcrt4: Fix memory leak in NdrFullPointerXlatFree. <rob at codeweavers.com> First of all, the code was freeing the wrong pointer (i.e. the pointer supplied by the caller of one of the NdrFullPointer* functions, not the PFULL_PTR_TO_REFID_ELEMENT. Second, the code wasn't following the Next link to the next entry in the list.

by cwittich＠svn.reactos.org

Author: cwittich Date: Fri Jan 18 13:37:37 2008 New Revision: 31852 URL: http://svn.reactos.org/svn/reactos?rev=31852&view=rev Log: rpcrt4: Fix memory leak in NdrFullPointerXlatFree. <rob at codeweavers.com> First of all, the code was freeing the wrong pointer (i.e. the pointer supplied by the caller of one of the NdrFullPointer* functions, not the PFULL_PTR_TO_REFID_ELEMENT. Second, the code wasn't following the Next link to the next entry in the list. Modified: trunk/reactos/dll/win32/rpcrt4/ndr_fullpointer.c Modified: trunk/reactos/dll/win32/rpcrt4/ndr_fullpointer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_fullp… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/ndr_fullpointer.c (original) +++ trunk/reactos/dll/win32/rpcrt4/ndr_fullpointer.c Fri Jan 18 13:37:37 2008 @@ -68,8 +68,17 @@ TRACE("(%p)\n", pXlatTables); /* free the entries in the table */ - for (i = 0; i < pXlatTables->RefIdToPointer.NumberOfEntries; i++) - HeapFree(GetProcessHeap(), 0, pXlatTables->RefIdToPointer.XlatTable[i]); + for (i = 0; i < pXlatTables->PointerToRefId.NumberOfBuckets; i++) + { + PFULL_PTR_TO_REFID_ELEMENT XlatTableEntry; + for (XlatTableEntry = pXlatTables->PointerToRefId.XlatTable[i]; + XlatTableEntry; ) + { + PFULL_PTR_TO_REFID_ELEMENT Next = XlatTableEntry->Next; + HeapFree(GetProcessHeap(), 0, XlatTableEntry); + XlatTableEntry = Next; + } + } HeapFree(GetProcessHeap(), 0, pXlatTables->RefIdToPointer.XlatTable); HeapFree(GetProcessHeap(), 0, pXlatTables->RefIdToPointer.StateTable);

17 years

[cwittich] 31851: rpcrt4: Fix a leak of msg in RPCRT4_io_thread on the error paths. <rob at codeweavers.com>

by cwittich＠svn.reactos.org

Author: cwittich Date: Fri Jan 18 13:34:34 2008 New Revision: 31851 URL: http://svn.reactos.org/svn/reactos?rev=31851&view=rev Log: rpcrt4: Fix a leak of msg in RPCRT4_io_thread on the error paths. <rob at codeweavers.com> Modified: trunk/reactos/dll/win32/rpcrt4/rpc_server.c Modified: trunk/reactos/dll/win32/rpcrt4/rpc_server.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpc_serve… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/rpc_server.c (original) +++ trunk/reactos/dll/win32/rpcrt4/rpc_server.c Fri Jan 18 13:34:34 2008 @@ -375,15 +375,18 @@ } packet = HeapAlloc(GetProcessHeap(), 0, sizeof(RpcPacket)); - if (!packet) + if (!packet) { + HeapFree(GetProcessHeap(), 0, msg); break; + } packet->conn = conn; packet->hdr = hdr; packet->msg = msg; if (!QueueUserWorkItem(RPCRT4_worker_thread, packet, WT_EXECUTELONGFUNCTION)) { - ERR("couldn't queue work item for worker thread, error was %d\n", GetLastError()); - HeapFree(GetProcessHeap(), 0, packet); - break; + ERR("couldn't queue work item for worker thread, error was %d\n", GetLastError()); + HeapFree(GetProcessHeap(), 0, msg); + HeapFree(GetProcessHeap(), 0, packet); + break; } msg = NULL; }

17 years

← Newer
1
...
19
20
21
22
23
24
25
...
54
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2008