Ros-diffs January 2008

ros-diffs@reactos.org

24 participants
539 discussions

[greatlrd] 31558: implement DxEngIncDispUniq
by greatlrd＠svn.reactos.org 02 Jan '08

02 Jan '08

Author: greatlrd Date: Wed Jan 2 13:19:56 2008 New Revision: 31558 URL: http://svn.reactos.org/svn/reactos?rev=31558&view=rev Log: implement DxEngIncDispUniq Modified: trunk/reactos/include/reactos/drivers/directx/dxeng.h trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Modified: trunk/reactos/include/reactos/drivers/directx/dxeng.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/drivers/di… ============================================================================== --- trunk/reactos/include/reactos/drivers/directx/dxeng.h (original) +++ trunk/reactos/include/reactos/drivers/directx/dxeng.h Wed Jan 2 13:19:56 2008 @@ -49,47 +49,27 @@ /************************************************************************/ /* win32k.sys internal protypes for the driver functions it export */ /************************************************************************/ - -/* Notes : Check see if termal server got a connections or not */ BOOL DxEngNUIsTermSrv(); - -/* Notes : it always return TRUE, and it update whole the screen (redaw current desktop) */ BOOL DxEngRedrawDesktop(); - -/* Notes : return the DisplayUniqVisrgn counter from gdishare memory */ ULONG DxEngDispUniq(); - -/* Notes : return the VisRgnUniq counter for win32k */ ULONG DxEngVisRgnUniq(); - -/* Notes : Enumate all drivers in win32k */ HDEV *DxEngEnumerateHdev(HDEV *hdev); - -/* Notes : same protypes NtGdiEngGetDeviceGammaRamp, diffent is we skipp the user mode checks and seh */ -BOOL -DxEngGetDeviceGammaRamp(HDEV hPDev, PGAMMARAMP Ramp); - -/* Notes : Lock the hDC */ +BOOL DxEngGetDeviceGammaRamp(HDEV hPDev, PGAMMARAMP Ramp); PDC DxEngLockDC(HDC hDC); - -/* Notes : Unlock the hDC */ BOOL DxEngUnlockDC(PDC pDC); - -/* Notes : Set Gamma ramp */ BOOL DxEngSetDeviceGammaRamp(HDEV hPDev, PGAMMARAMP Ramp, BOOL Unuse); - BOOLEAN DxEngLockShareSem(); BOOLEAN DxEngUnlockShareSem(); BOOLEAN DxEngCleanDC(HDC hdc); DWORD DxEngGetHdevData(HDEV hdev, DWORD Index); BOOLEAN DxEngSetHdevData(HDEV hdev, DWORD Index, DWORD Save); +BOOLEAN DxEngIncDispUniq(); /* prototypes are not done yet, I need gather all my notes * to make them correct */ DWORD DxEngCreateMemoryDC(DWORD x1); DWORD DxEngScreenAccessCheck(); - DWORD DxEngLockHdev(DWORD x1); DWORD DxEngUnlockHdev(DWORD x1); DWORD DxEngReferenceHdev(DWORD x1); @@ -98,7 +78,6 @@ DWORD DxEngSpTearDownSprites(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngSpUnTearDownSprites(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngSpSpritesVisible(DWORD x1); - DWORD DxEngGetDesktopDC(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngDeleteDC(DWORD x1, DWORD x2); DWORD DxEngSetDCOwner(DWORD x1, DWORD x2); @@ -116,5 +95,5 @@ DWORD DxEngSetPaletteState(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngGetRedirectionBitmap(DWORD x1); DWORD DxEngLoadImage(DWORD x1,DWORD x2); -DWORD DxEngIncDispUniq(); + Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Wed Jan 2 13:19:56 2008 @@ -89,11 +89,19 @@ } -/************************************************************************/ -/* DxEngDispUniq */ -/************************************************************************/ - -/* Notes : return the DisplayUniqVisrgn counter from gdishare memory */ +/*++ +* @name DxEngDispUniq +* @implemented +* +* The function DxEngDispUniq return the DisplayUniqVisrgn counter from gdishare memory +* +* @return +* return DisplayUniqVisrgn counter value from gdishare memory +* +* @remarks. +* none +* +*--*/ ULONG DxEngDispUniq() { @@ -633,13 +641,24 @@ return FALSE; } -/************************************************************************/ -/* DxEngIncDispUniq */ -/************************************************************************/ -DWORD DxEngIncDispUniq() -{ - UNIMPLEMENTED; - return FALSE; -} - - +/*++ +* @name DxEngIncDispUniq +* @implemented +* +* The function DxEngIncDispUniq incress DisplayUniqVisrgn counter from gdishare memory +* +* @return +* This function returns TRUE no matter what +* +* @remarks. +* none +* +*--*/ +BOOLEAN +DxEngIncDispUniq() +{ + InterlockedIncrement((LONG*)&GdiHandleTable->flDeviceUniq); + return TRUE; +} + +

1 0

[greatlrd] 31557: sorry a file been accent committed.
by greatlrd＠svn.reactos.org 02 Jan '08

02 Jan '08

Author: greatlrd Date: Wed Jan 2 12:58:51 2008 New Revision: 31557 URL: http://svn.reactos.org/svn/reactos?rev=31557&view=rev Log: sorry a file been accent committed. Modified: trunk/reactos/drivers/directx/dxg/eng.c Modified: trunk/reactos/drivers/directx/dxg/eng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/directx/dxg/eng.c?… ============================================================================== --- trunk/reactos/drivers/directx/dxg/eng.c (original) +++ trunk/reactos/drivers/directx/dxg/eng.c Wed Jan 2 12:58:51 2008 @@ -45,117 +45,6 @@ return retVal; } -HANDLE -STDCALL -DxDdCreateDirectDrawObject(HDC hdc) -{ - HANDLE hDirectDraw = NULL; - DHPDEV hPdev; // PGDIDEVICE - ULONG iDitherFormat; - - DC *pDC; = gpEngFuncs[DXENG_INDEX_DxEngLockDC](); - - if (pDC != NULL) - { - hPdev = gpEngFuncs[DXENG_INDEX_DxEngGetDCState](hdc, 3); - - if (hPdev != 0) - { - /* Get DC display flag */ - if (gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev, 12)) - { - EDD_DEVLOCK(hdc, esi); - - if (!gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev,19)) - { - CheckAgpHeaps( gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev,7) ); - } - - iDitherFormat = gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev,2); - - .text:00019FF1 cmp eax, 3 - .text:00019FF4 jb short loc_1A001 - - hDirectDraw = hDdCreateDirectDrawLocal(hPdev); - - loc_1A001: - if (hdc != NULL) - { - gpEngFuncs[DXENG_INDEX_DxEngUnlockHdev](hdc); - } - } - } - - gpEngFuncs[DXENG_INDEX_DxEngUnlockDC](pDC); - } - - return hDirectDraw; - -} - - -int __stdcall hDdCreateDirectDrawLocal(HDEV hDEV) -{ - int v1; // eax@1 - int v2; // edi@1 - int result; // eax@2 - int v4; // ebx@2 - struct HDD_OBJ__ *v5; // eax@5 - struct HDD_OBJ__ *v6; // esi@5 - int v7; // eax@1 - int v8; // eax@6 - int v9; // eax@6 - int v10; // eax@6 - int _EAX; // eax@6 - signed int _ECX; // ecx@6 - int v18; // [sp+8h] [bp-4h]@1 - - v18 = 0; - v7 = gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev,7); - v2 = v7; - v1 = *(_DWORD *)(v7 + 0x30); - if ( v1 ) - { - result = EngAllocMem(1, 4 * v1, 1885627463); - v4 = result; - if ( !result ) - return result; - } - else - { - v4 = 0; - } - v5 = DdHmgAlloc(0x54u, 1u, 1u); - v6 = v5; - if ( v5 ) - { - *((_DWORD *)v5 + 12) = *(_DWORD *)(v2 + 1448); - *(_DWORD *)(v2 + 1448) = v5; - *((_DWORD *)v5 + 8) = (char *)v5 + 28; - *((_DWORD *)v5 + 7) = (char *)v5 + 28; - *((_DWORD *)v5 + 9) = v2; - *((_DWORD *)v5 + 4) = v2; - v8 = PsGetCurrentThread(); - *((_DWORD *)v6 + 15) = PsGetThreadProcessId(v8); - v9 = PsGetCurrentProcess(); - *((_DWORD *)v6 + 19) = 0; - *((_DWORD *)v6 + 16) = v9; - v10 = a1; - *((_DWORD *)v6 + 17) = v4; - (*(int (__cdecl **)(_DWORD))(gpEngFuncs + 108))(*(_DWORD *)v10); - v18 = *(_DWORD *)v6; - _EAX = (int)((char *)v6 + 8); - _ECX = -1; - __asm { lock xadd [eax], ecx } - MapAllAgpHeaps(v6); - } - else - { - if ( v4 ) - EngFreeMem(v4); - } - return v18; -}

1 0

[greatlrd] 31556: partly implement DxEngSetHdevData fixed DxEngGetHdevData protoype as well
by greatlrd＠svn.reactos.org 02 Jan '08

02 Jan '08

Author: greatlrd Date: Wed Jan 2 12:37:05 2008 New Revision: 31556 URL: http://svn.reactos.org/svn/reactos?rev=31556&view=rev Log: partly implement DxEngSetHdevData fixed DxEngGetHdevData protoype as well Modified: trunk/reactos/drivers/directx/dxg/eng.c trunk/reactos/include/reactos/drivers/directx/dxeng.h trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Modified: trunk/reactos/drivers/directx/dxg/eng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/directx/dxg/eng.c?… ============================================================================== --- trunk/reactos/drivers/directx/dxg/eng.c (original) +++ trunk/reactos/drivers/directx/dxg/eng.c Wed Jan 2 12:37:05 2008 @@ -45,6 +45,117 @@ return retVal; } +HANDLE +STDCALL +DxDdCreateDirectDrawObject(HDC hdc) +{ + HANDLE hDirectDraw = NULL; + DHPDEV hPdev; // PGDIDEVICE + ULONG iDitherFormat; + + DC *pDC; = gpEngFuncs[DXENG_INDEX_DxEngLockDC](); + + if (pDC != NULL) + { + hPdev = gpEngFuncs[DXENG_INDEX_DxEngGetDCState](hdc, 3); + + if (hPdev != 0) + { + /* Get DC display flag */ + if (gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev, 12)) + { + EDD_DEVLOCK(hdc, esi); + + if (!gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev,19)) + { + CheckAgpHeaps( gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev,7) ); + } + + iDitherFormat = gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev,2); + + .text:00019FF1 cmp eax, 3 + .text:00019FF4 jb short loc_1A001 + + hDirectDraw = hDdCreateDirectDrawLocal(hPdev); + + loc_1A001: + if (hdc != NULL) + { + gpEngFuncs[DXENG_INDEX_DxEngUnlockHdev](hdc); + } + } + } + + gpEngFuncs[DXENG_INDEX_DxEngUnlockDC](pDC); + } + + return hDirectDraw; + +} + + +int __stdcall hDdCreateDirectDrawLocal(HDEV hDEV) +{ + int v1; // eax@1 + int v2; // edi@1 + int result; // eax@2 + int v4; // ebx@2 + struct HDD_OBJ__ *v5; // eax@5 + struct HDD_OBJ__ *v6; // esi@5 + int v7; // eax@1 + int v8; // eax@6 + int v9; // eax@6 + int v10; // eax@6 + int _EAX; // eax@6 + signed int _ECX; // ecx@6 + int v18; // [sp+8h] [bp-4h]@1 + + v18 = 0; + v7 = gpEngFuncs[DXENG_INDEX_DxEngGetHdevData](hPdev,7); + v2 = v7; + v1 = *(_DWORD *)(v7 + 0x30); + if ( v1 ) + { + result = EngAllocMem(1, 4 * v1, 1885627463); + v4 = result; + if ( !result ) + return result; + } + else + { + v4 = 0; + } + v5 = DdHmgAlloc(0x54u, 1u, 1u); + v6 = v5; + if ( v5 ) + { + *((_DWORD *)v5 + 12) = *(_DWORD *)(v2 + 1448); + *(_DWORD *)(v2 + 1448) = v5; + *((_DWORD *)v5 + 8) = (char *)v5 + 28; + *((_DWORD *)v5 + 7) = (char *)v5 + 28; + *((_DWORD *)v5 + 9) = v2; + *((_DWORD *)v5 + 4) = v2; + v8 = PsGetCurrentThread(); + *((_DWORD *)v6 + 15) = PsGetThreadProcessId(v8); + v9 = PsGetCurrentProcess(); + *((_DWORD *)v6 + 19) = 0; + *((_DWORD *)v6 + 16) = v9; + v10 = a1; + *((_DWORD *)v6 + 17) = v4; + (*(int (__cdecl **)(_DWORD))(gpEngFuncs + 108))(*(_DWORD *)v10); + v18 = *(_DWORD *)v6; + _EAX = (int)((char *)v6 + 8); + _ECX = -1; + __asm { lock xadd [eax], ecx } + MapAllAgpHeaps(v6); + } + else + { + if ( v4 ) + EngFreeMem(v4); + } + return v18; +} Modified: trunk/reactos/include/reactos/drivers/directx/dxeng.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/drivers/di… ============================================================================== --- trunk/reactos/include/reactos/drivers/directx/dxeng.h (original) +++ trunk/reactos/include/reactos/drivers/directx/dxeng.h Wed Jan 2 12:37:05 2008 @@ -81,6 +81,8 @@ BOOLEAN DxEngLockShareSem(); BOOLEAN DxEngUnlockShareSem(); BOOLEAN DxEngCleanDC(HDC hdc); +DWORD DxEngGetHdevData(HDEV hdev, DWORD Index); +BOOLEAN DxEngSetHdevData(HDEV hdev, DWORD Index, DWORD Save); /* prototypes are not done yet, I need gather all my notes * to make them correct @@ -96,8 +98,7 @@ DWORD DxEngSpTearDownSprites(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngSpUnTearDownSprites(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngSpSpritesVisible(DWORD x1); -DWORD DxEngGetHdevData(PEDD_DIRECTDRAW_GLOBAL pEDDgpl, DWORD Index); -DWORD DxEngSetHdevData(DWORD x1, DWORD x2, DWORD x3); + DWORD DxEngGetDesktopDC(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngDeleteDC(DWORD x1, DWORD x2); DWORD DxEngSetDCOwner(DWORD x1, DWORD x2); Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Wed Jan 2 12:37:05 2008 @@ -374,20 +374,49 @@ /* DxEngGetHdevData */ /************************************************************************/ DWORD -DxEngGetHdevData(PEDD_DIRECTDRAW_GLOBAL pEDDgpl, +DxEngGetHdevData(HDEV hdev, DWORD Index) { UNIMPLEMENTED; return 0; } -/************************************************************************/ -/* DxEngSetHdevData */ -/************************************************************************/ -DWORD DxEngSetHdevData(DWORD x1, DWORD x2, DWORD x3) -{ - UNIMPLEMENTED; - return FALSE; +/*++ +* @name DxEngSetHdevData +* @implemented +* +* The function DxEngSetHdevData sets a value in hdev + +* @param HDEV hPDev +* The hdev +* +* @param DWORD Index +* Support only Index 8 it is a internal counter how many time hdev been lock and unlock +* +* @param DWORD Save +* The value to be save to hdev internal counter +* +* @return +* Returns TRUE for success, FALSE for failure +* +* @remarks. +* ReactOS specfiy Not finish implement, I have not save the value into the hdev yet. +* +*--*/ +BOOLEAN +DxEngSetHdevData(HDEV hdev, + DWORD Index, + DWORD Save) +{ + BOOL retVal = FALSE; + if (Index == 8) + { + /* Counter how many time hdev been lock/unlock, we do not support it yet in ReactOS */ + DPRINT1("Warning not supproted yet\n"); + retVal = TRUE; + } + + return retVal; } /************************************************************************/

1 0

[greatlrd] 31555: fixed DxEngCleanDC protoype
by greatlrd＠svn.reactos.org 02 Jan '08

02 Jan '08

Author: greatlrd Date: Wed Jan 2 12:13:51 2008 New Revision: 31555 URL: http://svn.reactos.org/svn/reactos?rev=31555&view=rev Log: fixed DxEngCleanDC protoype Modified: trunk/reactos/include/reactos/drivers/directx/dxeng.h trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Modified: trunk/reactos/include/reactos/drivers/directx/dxeng.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/drivers/di… ============================================================================== --- trunk/reactos/include/reactos/drivers/directx/dxeng.h (original) +++ trunk/reactos/include/reactos/drivers/directx/dxeng.h Wed Jan 2 12:13:51 2008 @@ -80,6 +80,7 @@ BOOLEAN DxEngLockShareSem(); BOOLEAN DxEngUnlockShareSem(); +BOOLEAN DxEngCleanDC(HDC hdc); /* prototypes are not done yet, I need gather all my notes * to make them correct @@ -99,7 +100,6 @@ DWORD DxEngSetHdevData(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngGetDesktopDC(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngDeleteDC(DWORD x1, DWORD x2); -DWORD DxEngCleanDC(DWORD x1); DWORD DxEngSetDCOwner(DWORD x1, DWORD x2); DWORD DxEngSetDCState(DWORD x1, DWORD x2, DWORD x3); DWORD DxEngGetDCState(HDC hDC, DWORD type); Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Wed Jan 2 12:13:51 2008 @@ -411,7 +411,7 @@ /************************************************************************/ /* DxEngCleanDC */ /************************************************************************/ -DWORD DxEngCleanDC(DWORD x1) +BOOLEAN DxEngCleanDC(HDC hdc) { UNIMPLEMENTED; return FALSE;

1 0

[greatlrd] 31554: implement DxEngLockShareSem implement DxEngUnlockShareSem
by greatlrd＠svn.reactos.org 02 Jan '08

02 Jan '08

Author: greatlrd Date: Wed Jan 2 11:47:46 2008 New Revision: 31554 URL: http://svn.reactos.org/svn/reactos?rev=31554&view=rev Log: implement DxEngLockShareSem implement DxEngUnlockShareSem Modified: trunk/reactos/include/reactos/drivers/directx/dxeng.h trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Modified: trunk/reactos/include/reactos/drivers/directx/dxeng.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/drivers/di… ============================================================================== --- trunk/reactos/include/reactos/drivers/directx/dxeng.h (original) +++ trunk/reactos/include/reactos/drivers/directx/dxeng.h Wed Jan 2 11:47:46 2008 @@ -78,13 +78,15 @@ /* Notes : Set Gamma ramp */ BOOL DxEngSetDeviceGammaRamp(HDEV hPDev, PGAMMARAMP Ramp, BOOL Unuse); -/* prototypes are not done yet, I need gather all my notes - * to make them correct +BOOLEAN DxEngLockShareSem(); +BOOLEAN DxEngUnlockShareSem(); + +/* prototypes are not done yet, I need gather all my notes + * to make them correct */ DWORD DxEngCreateMemoryDC(DWORD x1); DWORD DxEngScreenAccessCheck(); -DWORD DxEngLockShareSem(); -DWORD DxEngUnlockShareSem(); + DWORD DxEngLockHdev(DWORD x1); DWORD DxEngUnlockHdev(DWORD x1); DWORD DxEngReferenceHdev(DWORD x1); Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Wed Jan 2 11:47:46 2008 @@ -10,6 +10,7 @@ #include <w32k.h> #include <debug.h> +ERESOURCE ghsemShareDevLock; @@ -214,22 +215,57 @@ return FALSE; } -/************************************************************************/ -/* DxEngLockShareSem */ -/************************************************************************/ -DWORD DxEngLockShareSem() -{ - UNIMPLEMENTED; - return FALSE; -} - -/************************************************************************/ -/* DxEngUnlockShareSem */ -/************************************************************************/ -DWORD DxEngUnlockShareSem() -{ - UNIMPLEMENTED; - return FALSE; +/*++ +* @name DxEngLockShareSem +* @implemented +* +* The function DxEngLockShareSem doing share lock of ghsemShareDevLock +* +* @return +* This function returns TRUE for susssess, or FALSE for fail, FALSE can only +* mean it being already lock. +* +* @remarks. +* it being use in diffent ntuser* functions and ntgdi* +* ReactOS specify it is not been inuse at moment +*SystemResourcesList +*--*/ +BOOLEAN +DxEngLockShareSem() +{ + BOOLEAN retVal = 0; + + if (ExIsResourceAcquiredExclusiveLite(&ghsemShareDevLock) == FALSE) + { + KeEnterCriticalRegion(); + retVal = ExAcquireResourceExclusiveLite(&ghsemShareDevLock, TRUE); + } + + return retVal; +} + +/*++ +* @name DxEngUnlockShareSem +* @implemented +* +* The function DxEngUnlockShareSem doing share unlock of ghsemShareDevLock +* +* @return +* This function returns TRUE no matter what +* +* @remarks. +* ReactOS specify it is not been inuse at moment +* +*--*/ +BOOLEAN +DxEngUnlockShareSem() +{ + if (ExIsResourceAcquiredExclusiveLite(&ghsemShareDevLock) == TRUE) + { + ExReleaseResourceLite(&ghsemShareDevLock); + KeLeaveCriticalRegion(); + } + return TRUE; } /************************************************************************/ @@ -415,9 +451,9 @@ * The DC handle * * @param DWORD type -* value 1 = Is DC fullscreen -* value 2 = Get Complexity of visible region. -* value 3 = Get Driver hdev, which is a pPDev. +* value 1 = Is DC fullscreen +* value 2 = Get Complexity of visible region. +* value 3 = Get Driver hdev, which is a pPDev. * * @return * Return one of the type values @@ -445,13 +481,13 @@ break; case 3: { - /* Return the HDEV of this DC. */ + /* Return the HDEV of this DC. */ retVal = (DWORD) pDC->pPDev; break; } default: /* if a valid type is not found, zero is returned */ - DPRINT1("Warning did not find type %d\n",type); + DPRINT1("Warning did not find type %d\n",type); break; } DC_UnlockDc(pDC);

1 0

[zguo] 31553: Completion of editing current documentation in dxg
by zguo＠svn.reactos.org 02 Jan '08

02 Jan '08

Author: zguo Date: Wed Jan 2 08:44:59 2008 New Revision: 31553 URL: http://svn.reactos.org/svn/reactos?rev=31553&view=rev Log: Completion of editing current documentation in dxg Modified: trunk/reactos/drivers/directx/dxg/ddhmg.c trunk/reactos/drivers/directx/dxg/historic.c Modified: trunk/reactos/drivers/directx/dxg/ddhmg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/directx/dxg/ddhmg.… ============================================================================== --- trunk/reactos/drivers/directx/dxg/ddhmg.c (original) +++ trunk/reactos/drivers/directx/dxg/ddhmg.c Wed Jan 2 08:44:59 2008 @@ -35,14 +35,14 @@ * @name DdHmgCreate * @implemented * -* The function DdHmgCreate is internal use in dxg.sys -* It Create all DX kernel object that is need it, for create DX object. +* The function DdHmgCreate is used internally in dxg.sys +* It creates all DX kernel objects that are need it for creation of DX objects. * * @return -* return FALSE for fail, return TRUE for sussess create DX object +* Return FALSE for failure and TRUE for success in creating the DX object * * @remarks. -* Only use internal in dxg.sys +* Only used internally in dxg.sys *--*/ BOOL FASTCALL @@ -81,14 +81,14 @@ * @name DdHmgDestroy * @implemented * -* The function DdHmgDestroy is internal use in dxg.sys -* It destore all DX kernel object +* The function DdHmgDestroy is used internally in dxg.sys +* It destroys all DX kernel objects * * @return -* return FALSE for fail or noting to destore, return TRUE for sussess destore all dx object +* Always returns true, as a failure here would result in a BSOD. * * @remarks. -* Only use internal in dxg.sys +* Only used internally in dxg.sys *--*/ BOOL FASTCALL @@ -118,29 +118,29 @@ * @name DdHmgLock * @implemented * -* The function DdHmgLock is internal use in dxg.sys -* it lock a Dx kernel object +* The function DdHmgLock is used internally in dxg.sys +* It locks a DX kernel object * * @param HANDLE DdHandle -* The handle we want lock +* The handle we want locked * * @param UCHAR ObjectType -* The type of the object we expected the handle contain -* value 0 is for getting ? -* value 1 is for getting EDD_DIRECTDRAW_LOCAL -* value 2 is for getting EDD_SURFACE -* value 3 is for getting ? -* value 4 is for getting EDD_VIDEOPORT -* value 5 is for getting EDD_MOTIONCOMP +* The type of the object we expected the handle to contain +* value 0 is for ? +* value 1 is for EDD_DIRECTDRAW_LOCAL +* value 2 is for EDD_SURFACE +* value 3 is for ? +* value 4 is for EDD_VIDEOPORT +* value 5 is for EDD_MOTIONCOMP * @param BOOLEAN LockOwned -* if it need be EngAcquireSemaphore or not +* If it needs to call EngAcquireSemaphore or not * * @return -* return a EDD_* object, or NULL depnes if it success or not. +* Returns an EDD_* object, or NULL if it fails * * @remarks. -* Only use internal in dxg.sys +* Only used internally in dxg.sys *--*/ PVOID FASTCALL Modified: trunk/reactos/drivers/directx/dxg/historic.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/directx/dxg/histor… ============================================================================== --- trunk/reactos/drivers/directx/dxg/historic.c (original) +++ trunk/reactos/drivers/directx/dxg/historic.c Wed Jan 2 08:44:59 2008 @@ -15,7 +15,7 @@ * @name DxDxgGenericThunk * @implemented * -* The function DxDxgGenericThunk redirect dx call to other thing. +* The function DxDxgGenericThunk redirects DirectX calls to other functions. * * @param ULONG_PTR ulIndex * The functions we want redirct @@ -36,10 +36,10 @@ * Unknown * * @return -* always return DDHAL_DRIVER_NOTHANDLED +* Always returns DDHAL_DRIVER_NOTHANDLED * * @remarks. -* This api are not longer use in Windows NT 2000/XP/2003 +* This function is no longer used in Windows NT 2000/XP/2003 * *--*/ DWORD @@ -59,7 +59,7 @@ * @name DxDdIoctl * @implemented * -* The function DxDdIoctl is the ioctl call to diffent dx functions +* The function DxDdIoctl is the ioctl call to diffent DirectX functions * * @param ULONG ulIoctl * The ioctl code that we want call to @@ -71,10 +71,10 @@ * The buffer size in bytes * * @return -* always return DDERR_UNSUPPORTED +* Always returns DDERR_UNSUPPORTED * * @remarks. -* This api are not longer use in Windows NT 2000/XP/2003 +* This function is no longer used in Windows NT 2000/XP/2003 * *--*/ DWORD

1 0

[zguo] 31552: Finish editing all the documentation in ntddraw.
by zguo＠svn.reactos.org 02 Jan '08

02 Jan '08

Author: zguo Date: Wed Jan 2 08:26:00 2008 New Revision: 31552 URL: http://svn.reactos.org/svn/reactos?rev=31552&view=rev Log: Finish editing all the documentation in ntddraw. Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/d3d.c trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c trunk/reactos/subsystems/win32/win32k/ntddraw/eng.c Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/d3d.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/d3d.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/d3d.c Wed Jan 2 08:26:00 2008 @@ -9,8 +9,8 @@ */ /* Comment - * NtGdiDdLock and NtGdiDdLockD3D at end calls to same api in the dxg.sys - * NtGdiDdUnlock and NtGdiDdUnlockD3D at end calls to same api in the dxg.sys + * NtGdiDdLock and NtGdiDdLockD3D ultimately call the same function in dxg.sys + * NtGdiDdUnlock and NtGdiDdUnlockD3D ultimately call the same function in dxg.sys */ #include <w32k.h> @@ -33,22 +33,22 @@ * * @return -* Depending on if the driver supports this API or not, DDHAL_DRIVER_HANDLED +* Depending on if the driver supports this function or not, DDHAL_DRIVER_HANDLED * or DDHAL_DRIVER_NOTHANDLED is returned. * To check if the function has been successful, do a full check. * A full check is done by checking if the return value is DDHAL_DRIVER_HANDLED * and puCanCreateSurfaceData->ddRVal is set to DD_OK. * * @remarks. -* dxg.sys NtGdiDdCanCreateD3DBuffer and NtGdiDdCanCreateSurface call are redirect to dxg.sys -* inside the dxg.sys they ar redirect to same functions. examine the driver list functions -* table, the memory address you will see they are pointed to same memory address. -* -* Before call to this api please set the puCanCreateSurfaceData->ddRVal to a error value example DDERR_NOTUSPORTED. -* for the ddRVal will other wise be unchange if some error happen inside the driver. -* puCanCreateSurfaceData->lpDD is pointer to DDRAWI_DIRECTDRAW_GBL, MSDN say it is PDD_DIRECTDRAW_GLOBAL it is not. -* puCanCreateSurfaceData->lpDD->hDD need also be fill in with the handle we got from NtGdiDdCreateDirectDrawObject -* puCreateSurfaceData->CanCreateSurface pointer to the real functions the HAL or HEL, that u need fill in +* dxg.sys NtGdiDdCanCreateD3DBuffer and NtGdiDdCanCreateSurface calls are redirected to dxg.sys. +* Inside the dxg.sys they are redirected to the same function. Examine the memory addresses on the driver list functions +* table and you will see they are pointed to the same memory address. +* +* Before calling this function please set the puCanCreateSurfaceData->ddRVal to an error value such as DDERR_NOTUSPORTED, +* for the ddRVal will otherwise be unchanged even if an error occurs inside the driver. +* puCanCreateSurfaceData->lpDD is a pointer to DDRAWI_DIRECTDRAW_GBL, not PDD_DIRECTDRAW_GLOBAL as MSDN claims. +* puCanCreateSurfaceData->lpDD->hDD also needs be filled in with the handle we got from NtGdiDdCreateDirectDrawObject. +* puCreateSurfaceData->CanCreateSurface is a pointer to the real functions in the HAL or HEL, that you need fill in. * *--*/ @@ -73,35 +73,33 @@ * @name NtGdiD3dContextCreate * @implemented * -* The Function NtGdiDdCanCreateD3DBuffer check if you can create a -* surface for directx it redirect the call to dxg.sys. +* The Function NtGdiDdCanCreateD3DBuffer checks if you can create a +* surface for Directx. It redirects the call to dxg.sys. * * @param HANDLE hDirectDrawLocal * The handle we got from NtGdiDdCreateDirectDrawObject * * @param HANDLE hSurfColor -* Handle to DD_SURFACE_LOCAL to be use as target rendring +* Handle to DD_SURFACE_LOCAL to be used for the rendering target * * @param HANDLE hSurfZ -* Handle to a DD_SURFACE_LOCAL it is the Z deep buffer, accdoing MSDN if it set to NULL nothing should happen. +* Handle to a DD_SURFACE_LOCAL. It is the Z deep buffer. According MSDN if it is set to NULL nothing should happen. * * @param D3DNTHAL_CONTEXTCREATEDATA* hSurfZ -* the buffer to create the context data +* The buffer to create the context data * * @return -* DDHAL_DRIVER_HANDLED or DDHAL_DRIVER_NOTHANDLED if the driver support this api. -* Todo full check if we sussess is to check the return value DDHAL_DRIVER_HANDLED -* puCanCreateSurfaceData->ddRVal are set to DD_OK. -* -* -* @remarks. -* dxg.sys NtGdiD3dContextCreate call are redirect to -* same functions in the dxg.sys. So they are working exacly same. everthing else is lying if they -* are diffent. -* -* Before call to this api please set the hSurfZ->ddRVal to a error value example DDERR_NOTUSPORTED. -* for the ddRVal will other wise be unchange if some error happen inside the driver. -* hSurfZ->dwhContext need also be fill in with the handle we got from NtGdiDdCreateDirectDrawObject +* DDHAL_DRIVER_HANDLED or DDHAL_DRIVER_NOTHANDLED if the driver supports this function. +* A full check is done by checking if the return value is DDHAL_DRIVER_HANDLED +* and puCanCreateSurfaceData->ddRVal is set to DD_OK. +* +* +* @remarks. +* dxg.sys NtGdiD3dContextCreate calls are redirected to the same function in the dxg.sys. As such they all work the same way. +* +* Before calling this function please set the hSurfZ->ddRVal to an error value such as DDERR_NOTUSPORTED, +* for the ddRVal will otherwise be unchanged even if an error occurs inside the driver. +* hSurfZ->dwhContext also needs to be filled in with the handle we got from NtGdiDdCreateDirectDrawObject * *--*/ BOOL @@ -127,19 +125,17 @@ * @name NtGdiD3dContextDestroy * @implemented * -* The Function NtGdiD3dContextDestroy Destory the context data we got from NtGdiD3dContextCreate +* The Function NtGdiD3dContextDestroy destorys the context data we got from NtGdiD3dContextCreate * * @param LPD3DNTHAL_CONTEXTDESTROYDATA pContextDestroyData -* The context data we want to destory -* -* @remarks. -* dxg.sys NtGdiD3dContextDestroy call are redirect to -* same functions in the dxg.sys. So they are working exacly same. everthing else is lying if they -* are diffent. -* -* Before call to this api please set the pContextDestroyData->ddRVal to a error value example DDERR_NOTUSPORTED. -* for the ddRVal will other wise be unchange if some error happen inside the driver. -* pContextDestroyData->dwhContext need also be fill in with the handle we got from NtGdiDdCreateDirectDrawObject +* The context data we want to destroy +* +* @remarks. +* dxg.sys NtGdiD3dContextDestroy calls are redirected to the same functions in the dxg.sys. As such they all work the same way. +* +* Before calling this function please set the pContextDestroyData->ddRVal to an error value such DDERR_NOTUSPORTED, +* for the ddRVal will otherwise be unchanged even if an error occurs inside the driver. +* pContextDestroyData->dwhContext also needs to be filled in with the handle we got from NtGdiDdCreateDirectDrawObject * *--*/ DWORD @@ -162,23 +158,21 @@ * @name NtGdiD3dContextDestroyAll * @implemented * -* The Function NtGdiD3dContextDestroyAll Destory the all context data we got in a process -* The data have been alloc with NtGdiD3dContextCreate +* The Function NtGdiD3dContextDestroyAll destroys all the context data in a process +* The data having been allocated with NtGdiD3dContextCreate * * @param LPD3DNTHAL_CONTEXTDESTROYALLDATA pdcad * The context data we want to destory * * @remarks. -* dxg.sys NtGdiD3dContextDestroyAll call are redirect to -* same functions in the dxg.sys. So they are working exacly same. everthing else is lying if they -* are diffent. -* -* Before call to this api please set the pdcad->ddRVal to a error value example DDERR_NOTUSPORTED. -* for the ddRVal will other wise be unchange if some error happen inside the driver. -* pdcad->dwPID need also be fill in with the Process ID we need destore the data for -* -* Waring MSDN is wrong about this api. it say it queare free memory and it does not accpect -* any parama, last time checked in msdn 19/10-2007 +* dxg.sys NtGdiD3dContextDestroy calls are redirected to the same function in the dxg.sys. As such they all work the same way. +* +* Before calling this function please set the pdcad->ddRVal to an error value such as DDERR_NOTUSPORTED, +* for the ddRVal will otherwise be unchanged even if an error occurs inside the driver. +* pdcad->dwPID also needs to be filled in with the ID of the process that needs its context data destroyed. +* +* Warning: MSDN is wrong about this function. It claims the function queries free memory and does not accept +* any parameters. Last time MSDN checked: 19/10-2007 *--*/ DWORD STDCALL @@ -200,51 +194,51 @@ * @name NtGdiDdCreateD3DBuffer * @implemented * -* The function NtGdiDdCreateD3DBuffer create a +* The function NtGdiDdCreateD3DBuffer creates a * surface for DirectX. It is redirected to dxg.sys. * * @param HANDLE hDirectDraw * The handle we got from NtGdiDdCreateDirectDrawObject * * @param HANDLE *hSurface -* <FILMEIN> +* <FILLMEIN> * * @param DDSURFACEDESC puSurfaceDescription -* surface desc what kind of surface it should be, example rgb, compress, deep, and more, -* see DDSURFACEDESC for more infomations +* Surface description: what kind of surface it should be. Examples: RGB, compress, deep, and etc +* See DDSURFACEDESC for more information * * @param DD_SURFACE_GLOBAL *puSurfaceGlobalData -* <FILMEIN> +* <FILLMEIN> * * @param DD_SURFACE_LOCAL *puSurfaceLocalData -* <FILMEIN> +* <FILLMEIN> * * @param DD_SURFACE_MORE *puSurfaceMoreData -* <FILMEIN> +* <FILLMEIN> * * @param PDD_CREATESURFACEDATA puCreateSurfaceData -* <FILMEIN> +* <FILLMEIN> * * @param HANDLE *puhSurface -* <FILMEIN> +* <FILLMEIN> * * @return -* Depending on if the driver supports this API or not, DDHAL_DRIVER_HANDLED +* Depending on if the driver supports this function or not, DDHAL_DRIVER_HANDLED * or DDHAL_DRIVER_NOTHANDLED is returned. -* To check if the function has been successful, do a full check. +* To check if the function was successful, do a full check. * A full check is done by checking if the return value is DDHAL_DRIVER_HANDLED * and puCanCreateSurfaceData->ddRVal is set to DD_OK. * * @remarks. -* dxg.sys NtGdiDdCreateD3DBuffer and NtGdiDdCreateSurface call are redirect to dxg.sys -* inside the dxg.sys they ar redirect to same functions. examine the driver list functions -* table, the memory address you will see they are pointed to same memory address. -* -* Before call to this api please set the puCreateSurfaceData->ddRVal to a error value example DDERR_NOTUSPORTED. -* for the ddRVal will other wise be unchange if some error happen inside the driver. -* puCreateSurfaceData->lpDD is pointer to DDRAWI_DIRECTDRAW_GBL, MSDN say it is PDD_DIRECTDRAW_GLOBAL it is not. -* puCreateSurfaceData->lpDD->hDD need also be fill in with the handle we got from NtGdiDdCreateDirectDrawObject -* puCreateSurfaceData->CreateSurface pointer to the real functions the HAL or HEL, that u need fill in +* dxg.sys NtGdiDdCreateD3DBuffer and NtGdiDdCreateSurface calls are redirected to dxg.sys. +* Inside the dxg.sys they are redirected to the same function. Examine the memory addresses on the driver list functions +* table and you will see they are pointed to the same memory address. +* +* Before calling this function please set the puCreateSurfaceData->ddRVal to an error value such as DDERR_NOTUSPORTED, +* for the ddRVal will otherwise be unchanged even if an error occurs inside the driver. +* puCreateSurfaceData->lpDD is a pointer to DDRAWI_DIRECTDRAW_GBL. MSDN claims it is PDD_DIRECTDRAW_GLOBAL but it is not. +* puCreateSurfaceData->lpDD->hDD also needs to be filled in with the handle we got from NtGdiDdCreateDirectDrawObject +* puCreateSurfaceData->CreateSurface is a pointer to the real functions in the HAL or HEL, that you need fill in * *--*/ DWORD Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c Wed Jan 2 08:26:00 2008 @@ -157,11 +157,11 @@ * @name NtGdiDxgGenericThunk * @implemented * -* The function NtGdiDxgGenericThunk redirect dx call to other thing. -* from dxg.sys +* The function NtGdiDxgGenericThunk redirects DirectX calls to another function. +* Redirection is done in dxg.sys in XP or higher. If dxg.sys does not exist, redirection takes place in win32k.sys * * @param ULONG_PTR ulIndex -* The functions we want redirct +* The functions we want to redirect * * @param ULONG_PTR ulHandle * Unknown @@ -179,11 +179,11 @@ * Unknown * * @return -* always return DDHAL_DRIVER_NOTHANDLED +* Always returns DDHAL_DRIVER_NOTHANDLED * * @remarks. -* dxg.sys NtGdiDxgGenericThunk call are redirect to dxg.sys -* This api are not longer use in Windows NT 2000/XP/2003 +* dxg.sys NtGdiDxgGenericThunk calls are redirected to dxg.sys +* This function is no longer used but is still present in Windows NT 2000/XP/2003. * *--*/ DWORD Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/eng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/eng.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/eng.c Wed Jan 2 08:26:00 2008 @@ -116,8 +116,8 @@ * @name EngDxIoctl * @implemented * -* The function EngDxIoctl is the ioctl call to diffent dx functions -* to the driver dxg.sys +* The function EngDxIoctl is the ioctl call to different DirectX functions +* in the driver dxg.sys * * @param ULONG ulIoctl * The ioctl code that we want call to @@ -129,11 +129,11 @@ * The buffer size in bytes * * @return -* always return DDERR_UNSUPPORTED +* Always returns DDERR_UNSUPPORTED * * @remarks. -* dxg.sys EngDxIoctl call are redirect to dxg.sys -* This api are not longer use in Windows NT 2000/XP/2003 +* dxg.sys EngDxIoctl call is redirected to dxg.sys +* This function is no longer used in Windows NT 2000/XP/2003 * *--*/ DWORD @@ -159,13 +159,13 @@ * @name EngLockDirectDrawSurface * @implemented * -* The function EngUnlockDirectDrawSurface locking the dx surface +* The function EngUnlockDirectDrawSurface locks the DirectX surface. * @param HANDLE hSurface * The handle of a surface * * @return -* This return vaild or NULL pointer to PDD_SURFACE_LOCAL object +* This return a vaild or NULL pointer to a PDD_SURFACE_LOCAL object * * @remarks. * None @@ -193,13 +193,13 @@ * @name EngUnlockDirectDrawSurface * @implemented * -* The function EngUnlockDirectDrawSurface locking the dx surface +* The function EngUnlockDirectDrawSurface unlocks the DirectX surface * @param PDD_SURFACE_LOCAL pSurface -* The Surface we whant lock +* The Surface we want to unlock * * @return -* This return FALSE or TRUE, FALSE for fail, TRUE for success +* This return TRUE for success, FALSE for failure * * @remarks. * None

1 0

[zguo] 31551: Grammar and spelling corrections for the documentation and comments.
by zguo＠svn.reactos.org 02 Jan '08

02 Jan '08

Author: zguo Date: Wed Jan 2 04:28:58 2008 New Revision: 31551 URL: http://svn.reactos.org/svn/reactos?rev=31551&view=rev Log: Grammar and spelling corrections for the documentation and comments. Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c Wed Jan 2 04:28:58 2008 @@ -99,7 +99,7 @@ return GdiHandleTable->flDeviceUniq; } -ULONG gulVisRgnUniqueness; // Inc count everytime client region is updated. +ULONG gulVisRgnUniqueness; // Increase count everytime client region is updated. /************************************************************************/ /* DxEngVisRgnUniq */ @@ -114,11 +114,11 @@ /************************************************************************/ /* DxEngEnumerateHdev */ /************************************************************************/ -/* Enumate all drivers in win32k */ +/* Enumerate all drivers in win32k */ HDEV * DxEngEnumerateHdev(HDEV *hdev) { - /* FIXME Enumate all drivers in win32k */ + /* FIXME Enumerate all drivers in win32k */ UNIMPLEMENTED; return FALSE; } @@ -133,13 +133,13 @@ * The hdev * * @param PGAMMARAMP Ramp -* to fill in our gama ramp +* to fill in our gamma ramp * * @return -* This return FALSE or TRUE, FALSE for fail, TRUE for success +*Returns TRUE for success, FALSE for failure * * @remarks. -* ReactOS does not loop it, only set the gamma once. +* ReactOS does not loop it, only sets the gamma once. * *--*/ BOOL @@ -153,13 +153,13 @@ * @name DxEngLockDC * @implemented * -* The function DxEngLockDC lock a hdc from dxg.sys +* The function DxEngLockDC locks a hdc from dxg.sys * * @param HDC hDC -* The handle we need want lock +* The handle we want to lock * * @return -* This api return PDC or NULL depns if it sussess lock the hdc or not +* Returns PDC if lock succeeded or NULL depns if it failed * * @remarks. * none @@ -176,13 +176,13 @@ * @name DxEngUnlockDC * @implemented * -* The function DxEngUnlockDC Unlock a pDC (hdc) from dxg.sys +* The function DxEngUnlockDC unlocks a pDC (hdc) from dxg.sys * @param PDC pDC -* The handle we need unlock +* The handle we want to unlock * * @return -* This api always return TRUE if it sussess or not +* This function returns TRUE no matter what * * @remarks. * none @@ -283,22 +283,22 @@ * @name DxEngSetDeviceGammaRamp * @implemented * -* The function DxEngSetDeviceGammaRamp Set Gamma ramp from from dxg.sys +* The function DxEngSetDeviceGammaRamp sets gamma ramp from dxg.sys * @param HDEV hPDev * The hdev * * @param PGAMMARAMP Ramp -* to set in our gama ramp +* Value to change gamma ramp to * * @param BOOL Test -* Testing the gama or not. FALSE for no test, TRUE for testing +* Whether gamma should be tested. TRUE to test, FALSE to not test * * @return -* This return FALSE or TRUE, FALSE for fail, TRUE for success +*Returns TRUE for success, FALSE for failure * * @remarks. -* ReactOS does not loop it, only set the gamma once. +* ReactOS does not loop and only sets the gamma once. * *--*/ BOOL @@ -405,23 +405,25 @@ * @name DxEngGetDCState * @implemented * -* The function DxEngGetDCState getting sate -* if it DC full screen / Get Complexity of visiable region or -* Get Driver hdev, which is pPDev +* The function DxEngGetDCState is capable of returning three +* DC states depending on what value is passed in its second parameter: +* 1. If the DC is full screen +* 2. Get Complexity of visible region +* 3. Get Driver hdev, which is pPDev * * @param HDC hdc -* The hdc +* The DC handle * * @param DWORD type -* value 1 = Is DC full screen -* value 2 = Get Complexity of visiable region. -* value 3 = Get Driver hdev, which is pPDev. +* value 1 = Is DC fullscreen +* value 2 = Get Complexity of visible region. +* value 3 = Get Driver hdev, which is a pPDev. * * @return -* return one of the type value +* Return one of the type values * * @remarks. -* we do not have type 2 implement yet +* We do not have type 2 implement yet * *--*/ DWORD @@ -443,13 +445,13 @@ break; case 3: { - /* Return HDEV of this DC. */ + /* Return the HDEV of this DC. */ retVal = (DWORD) pDC->pPDev; break; } default: - /* if it does not found a type it wanted we return 0 as value */ - DPRINT1("warning did not found type %d\n",type); + /* if a valid type is not found, zero is returned */ + DPRINT1("Warning did not find type %d\n",type); break; } DC_UnlockDc(pDC);

1 0

[akorotaev] 31550: Descrease number of link errors
by akorotaev＠svn.reactos.org 02 Jan '08

02 Jan '08

Author: akorotaev Date: Wed Jan 2 04:01:57 2008 New Revision: 31550 URL: http://svn.reactos.org/svn/reactos?rev=31550&view=rev Log: Descrease number of link errors Modified: branches/cache_manager_rewrite/cc/mdl.c Modified: branches/cache_manager_rewrite/cc/mdl.c URL: http://svn.reactos.org/svn/reactos/branches/cache_manager_rewrite/cc/mdl.c?… ============================================================================== --- branches/cache_manager_rewrite/cc/mdl.c (original) +++ branches/cache_manager_rewrite/cc/mdl.c Wed Jan 2 04:01:57 2008 @@ -129,9 +129,19 @@ * @unimplemented */ VOID NTAPI -CcMdlWriteCompleteDev (IN PFILE_OBJECT FileObject, - IN PLARGE_INTEGER FileOffset, - IN PMDL MdlChain) +CcMdlReadComplete2 (IN PMDL MemoryDescriptorList, + IN PFILE_OBJECT FileObject) +{ + UNIMPLEMENTED; +} + +/* + * @unimplemented + */ +VOID NTAPI +CcMdlWriteComplete2 (IN PFILE_OBJECT FileObject, + IN PLARGE_INTEGER FileOffset, + IN PMDL MdlChain) { UNIMPLEMENTED; }

1 0

[janderwald] 31549: - fix button control size for german language
by janderwald＠svn.reactos.org 01 Jan '08

01 Jan '08

Author: janderwald Date: Wed Jan 2 02:57:59 2008 New Revision: 31549 URL: http://svn.reactos.org/svn/reactos?rev=31549&view=rev Log: - fix button control size for german language Modified: trunk/reactos/dll/cpl/desk/lang/de-DE.rc Modified: trunk/reactos/dll/cpl/desk/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/lang/de-DE.rc… ============================================================================== --- trunk/reactos/dll/cpl/desk/lang/de-DE.rc (original) +++ trunk/reactos/dll/cpl/desk/lang/de-DE.rc Wed Jan 2 02:57:59 2008 @@ -41,7 +41,7 @@ GROUPBOX "&Enerigespar Features des Monitors:", IDC_SCREENS_DUMMY2, 6, 155, 232, 41 LTEXT "Um die Energieeinstellungen des Monitors zu editieren, wählen Sie Energieeinstellungen.", IDC_STATIC, 14, 166, 146 ,20 - PUSHBUTTON "Energieeinstell&ungen", IDC_SCREENS_POWER_BUTTON, 176, 171, 50, 13 + PUSHBUTTON "Energieeinstell&ungen", IDC_SCREENS_POWER_BUTTON, 162, 171, 70, 13 END IDD_APPEARANCE DIALOGEX DISCARDABLE 0, 0, 246, 228

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2008