Ros-diffs January 2008

ros-diffs@reactos.org

24 participants
539 discussions

[gedmurphy] 32012: fix typo
by gedmurphy＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: gedmurphy Date: Sat Jan 26 16:05:39 2008 New Revision: 32012 URL: http://svn.reactos.org/svn/reactos?rev=32012&view=rev Log: fix typo Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Sat Jan 26 16:05:39 2008 @@ -2159,7 +2159,7 @@ PUNICODE_STRING ClassName, LPWNDCLASSEXW lpWndClassEx, LPWSTR *ppszMenuName, - BOOL Ansi); + BOOL Ansi) { UNICODE_STRING CapturedClassName; PWINDOWCLASS Class;

1 0

[fireball] 32011: - Display string identifiers in debug log too.
by fireball＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: fireball Date: Sat Jan 26 16:03:32 2008 New Revision: 32011 URL: http://svn.reactos.org/svn/reactos?rev=32011&view=rev Log: - Display string identifiers in debug log too. Modified: trunk/reactos/boot/freeldr/freeldr/windows/conversion.c Modified: trunk/reactos/boot/freeldr/freeldr/windows/conversion.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/windows/conversion.c (original) +++ trunk/reactos/boot/freeldr/freeldr/windows/conversion.c Sat Jan 26 16:03:32 2008 @@ -90,8 +90,8 @@ if (Child->ComponentEntry.Identifier) Child->ComponentEntry.Identifier = PaToVa(Child->ComponentEntry.Identifier); - DbgPrint((DPRINT_WINDOWS, "Device 0x%X class %d type %d id %p, parent %p\n", Child, - Child->ComponentEntry.Class, Child->ComponentEntry.Type, Child->ComponentEntry.Identifier, Child->Parent)); + DbgPrint((DPRINT_WINDOWS, "Device 0x%X class %d type %d id '%s', parent %p\n", Child, + Child->ComponentEntry.Class, Child->ComponentEntry.Type, VaToPa(Child->ComponentEntry.Identifier), Child->Parent)); // Go through siblings list Sibling = VaToPa(Child->Sibling); @@ -112,8 +112,8 @@ if (Sibling->ComponentEntry.Identifier) Sibling->ComponentEntry.Identifier = PaToVa(Sibling->ComponentEntry.Identifier); - DbgPrint((DPRINT_WINDOWS, "Device 0x%X class %d type %d id %p, parent %p\n", Sibling, - Sibling->ComponentEntry.Class, Sibling->ComponentEntry.Type, Sibling->ComponentEntry.Identifier, Sibling->Parent)); + DbgPrint((DPRINT_WINDOWS, "Device 0x%X class %d type %d id '%s', parent %p\n", Sibling, + Sibling->ComponentEntry.Class, Sibling->ComponentEntry.Type, VaToPa(Sibling->ComponentEntry.Identifier), Sibling->Parent)); // Recurse into the Child tree if (VaToPa(Sibling->Child) != NULL)

1 0

[gedmurphy] 32010: - fix number of params in 3 win32k syscalls - patch by Stefan Ginsberg (stefan__100__@hotmail.com) (NtUserGetClassInfo params advised by myself)
by gedmurphy＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: gedmurphy Date: Sat Jan 26 15:55:46 2008 New Revision: 32010 URL: http://svn.reactos.org/svn/reactos?rev=32010&view=rev Log: - fix number of params in 3 win32k syscalls - patch by Stefan Ginsberg (stefan__100__(a)hotmail.com) (NtUserGetClassInfo params advised by myself) Modified: trunk/reactos/dll/win32/user32/windows/class.c trunk/reactos/include/reactos/win32k/ntuser.h trunk/reactos/subsystems/win32/win32k/ntuser/class.c trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c trunk/reactos/subsystems/win32/win32k/w32ksvc.db Modified: trunk/reactos/dll/win32/user32/windows/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/class.c (original) +++ trunk/reactos/dll/win32/user32/windows/class.c Sat Jan 26 15:55:46 2008 @@ -63,6 +63,7 @@ Ret = NtUserGetClassInfo(hInstance, &ClassName, (LPWNDCLASSEXW)lpwcx, + NULL, TRUE); if (!IS_ATOM(lpszClass)) @@ -118,6 +119,7 @@ return NtUserGetClassInfo(hInstance, &ClassName, lpwcx, + NULL, FALSE); } @@ -1226,7 +1228,8 @@ ClassName.Buffer = (PWSTR)((ULONG_PTR)lpClassName); Ret = NtUserUnregisterClass(&ClassName, - hInstance); + hInstance, + 0); if (!IS_ATOM(lpClassName)) RtlFreeUnicodeString(&ClassName); @@ -1260,7 +1263,8 @@ ClassName.Buffer = (PWSTR)((ULONG_PTR)lpClassName); return NtUserUnregisterClass(&ClassName, - hInstance); + hInstance, + 0); } /* EOF */ Modified: trunk/reactos/include/reactos/win32k/ntuser.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/win32k/ntu… ============================================================================== --- trunk/reactos/include/reactos/win32k/ntuser.h (original) +++ trunk/reactos/include/reactos/win32k/ntuser.h Sat Jan 26 15:55:46 2008 @@ -1099,6 +1099,7 @@ NtUserGetClassInfo(HINSTANCE hInstance, PUNICODE_STRING ClassName, LPWNDCLASSEXW wcex, + LPWSTR *ppszMenuName, BOOL Ansi); INT @@ -1496,7 +1497,8 @@ DWORD Unknown7, DWORD Unknown8, DWORD Unknown9, - DWORD Unknown10); + DWORD Unknown10, + DWORD Unknown11); INT NTAPI @@ -2422,7 +2424,8 @@ NTAPI NtUserUnregisterClass( PUNICODE_STRING ClassNameOrAtom, - HINSTANCE hInstance); + HINSTANCE hInstance, + DWORD Unknown); BOOL NTAPI Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Sat Jan 26 15:55:46 2008 @@ -2104,7 +2104,8 @@ BOOL NTAPI NtUserUnregisterClass(IN PUNICODE_STRING ClassNameOrAtom, - IN HINSTANCE hInstance) + IN HINSTANCE hInstance, + DWORD Unknown) { UNICODE_STRING CapturedClassName; BOOL Ret = FALSE; @@ -2157,7 +2158,8 @@ HINSTANCE hInstance, PUNICODE_STRING ClassName, LPWNDCLASSEXW lpWndClassEx, - BOOL Ansi) + LPWSTR *ppszMenuName, + BOOL Ansi); { UNICODE_STRING CapturedClassName; PWINDOWCLASS Class; Modified: trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c Sat Jan 26 15:55:46 2008 @@ -414,7 +414,8 @@ DWORD Unknown7, DWORD Unknown8, DWORD Unknown9, - DWORD Unknown10) + DWORD Unknown10, + DWORD Unknown11) { UNIMPLEMENTED Modified: trunk/reactos/subsystems/win32/win32k/w32ksvc.db URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/w3… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/w32ksvc.db (original) +++ trunk/reactos/subsystems/win32/win32k/w32ksvc.db Sat Jan 26 15:55:46 2008 @@ -391,8 +391,7 @@ NtUserGetAtomName 2 NtUserGetCaretBlinkTime 0 NtUserGetCaretPos 1 -# NtUserGetClassInfo 5 Wrong number of param ? -NtUserGetClassInfo 4 +NtUserGetClassInfo 5 NtUserGetClassName 3 NtUserGetClipboardData 2 NtUserGetClipboardFormatName 3 @@ -453,8 +452,7 @@ NtUserImpersonateDdeClientWindow 2 NtUserInitialize 3 NtUserInitializeClientPfnArrays 4 -# NtUserInitTask 12 Wrong number of param ? -NtUserInitTask 11 +NtUserInitTask 12 NtUserInternalGetWindowText 3 NtUserInvalidateRect 3 NtUserInvalidateRgn 3 @@ -580,8 +578,7 @@ NtUserUnhookWinEvent 1 NtUserUnloadKeyboardLayout 1 NtUserUnlockWindowStation 1 -# NtUserUnregisterClass 3 Wrong number of param ? -NtUserUnregisterClass 2 +NtUserUnregisterClass 3 NtUserUnregisterUserApiHook 0 NtUserUnregisterHotKey 2 NtUserUpdateInputContext 3

1 0

[cwittich] 32009: allowwarnings="true" (req. by gcc 4.3.0)
by cwittich＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: cwittich Date: Sat Jan 26 13:40:53 2008 New Revision: 32009 URL: http://svn.reactos.org/svn/reactos?rev=32009&view=rev Log: allowwarnings="true" (req. by gcc 4.3.0) Modified: trunk/reactos/base/applications/winhelp/winhelp.rbuild Modified: trunk/reactos/base/applications/winhelp/winhelp.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/winhelp/… ============================================================================== --- trunk/reactos/base/applications/winhelp/winhelp.rbuild (original) +++ trunk/reactos/base/applications/winhelp/winhelp.rbuild Sat Jan 26 13:40:53 2008 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="winhelp" type="win32gui" installbase="system32" installname="winhelp.exe" unicode="no"> +<module name="winhelp" type="win32gui" installbase="system32" installname="winhelp.exe" unicode="no" allowwarnings="true"> <include base="winhelp">.</include> <define name="_WIN32_IE">0x0600</define> <define name="_WIN32_WINNT">0x0501</define>

1 0

[cwittich] 32008: the address of gpDxFuncs will always evaluate as true
by cwittich＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: cwittich Date: Sat Jan 26 13:10:43 2008 New Revision: 32008 URL: http://svn.reactos.org/svn/reactos?rev=32008&view=rev Log: the address of gpDxFuncs will always evaluate as true Modified: trunk/reactos/subsystems/win32/win32k/include/intddraw.h Modified: trunk/reactos/subsystems/win32/win32k/include/intddraw.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/intddraw.h (original) +++ trunk/reactos/subsystems/win32/win32k/include/intddraw.h Sat Jan 26 13:10:43 2008 @@ -109,16 +109,13 @@ /* Standard macro */ #define DXG_GET_INDEX_FUNCTION(INDEX, FUNCTION) \ - if (gpDxFuncs) \ + for (i = 0; i <= DXG_INDEX_DxDdIoctl; i++) \ { \ - for (i = 0; i <= DXG_INDEX_DxDdIoctl; i++) \ + if (gpDxFuncs[i].iFunc == INDEX) \ { \ - if (gpDxFuncs[i].iFunc == INDEX) \ - { \ - FUNCTION = (VOID *)gpDxFuncs[i].pfn; \ - break; \ - } \ - } \ + FUNCTION = (VOID *)gpDxFuncs[i].pfn; \ + break; \ + } \ } /* Gammaramp internal prototype */

1 0

[arty] 32007: Fix termination of process under debug.
by arty＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: arty Date: Sat Jan 26 12:20:56 2008 New Revision: 32007 URL: http://svn.reactos.org/svn/reactos?rev=32007&view=rev Log: Fix termination of process under debug. Modified: trunk/reactos/ntoskrnl/dbgk/dbgkobj.c Modified: trunk/reactos/ntoskrnl/dbgk/dbgkobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/dbgk/dbgkobj.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/dbgk/dbgkobj.c (original) +++ trunk/reactos/ntoskrnl/dbgk/dbgkobj.c Sat Jan 26 12:20:56 2008 @@ -1065,6 +1065,17 @@ VOID NTAPI +DbgkpDelayedTerminateProcess(PVOID Arg) +{ + PWORK_QUEUE_ITEM WorkItem = (PWORK_QUEUE_ITEM)Arg; + PEPROCESS OwnerProcess = *((PEPROCESS *)&WorkItem[1]); + ExFreePool(WorkItem); + /* Terminate the process */ + PsTerminateProcess(OwnerProcess, STATUS_DEBUGGER_INACTIVE); +} + +VOID +NTAPI DbgkpCloseObject(IN PEPROCESS OwnerProcess OPTIONAL, IN PVOID ObjectBody, IN ACCESS_MASK GrantedAccess, @@ -1079,6 +1090,8 @@ DBGKTRACE(DBGK_OBJECT_DEBUG, "OwnerProcess: %p DebugObject: %p\n", OwnerProcess, DebugObject); + DPRINT("APC DISABLE: %d\n", ((PETHREAD)KeGetCurrentThread())->Tcb.CombinedApcDisable); + /* If this isn't the last handle, do nothing */ if (SystemHandleCount > 1) return; @@ -1127,8 +1140,16 @@ /* Check if we terminate on exit */ if (DebugObject->KillProcessOnExit) { - /* Terminate the process */ - PsTerminateProcess(OwnerProcess, STATUS_DEBUGGER_INACTIVE); + PWORK_QUEUE_ITEM WorkItem = + ExAllocatePool + (NonPagedPool, + sizeof(WORK_QUEUE_ITEM) + sizeof(PVOID)); + ExInitializeWorkItem + (WorkItem, + DbgkpDelayedTerminateProcess, + WorkItem); + *((PEPROCESS *)&WorkItem[1]) = OwnerProcess; + ExQueueWorkItem(WorkItem, CriticalWorkQueue); } /* Dereference the debug object */

1 0

[spetreolle] 32006: display exception text as well
by spetreolle＠svn.reactos.org 25 Jan '08

25 Jan '08

Author: spetreolle Date: Sat Jan 26 00:38:43 2008 New Revision: 32006 URL: http://svn.reactos.org/svn/reactos?rev=32006&view=rev Log: display exception text as well Modified: trunk/reactos/dll/win32/kernel32/except/except.c Modified: trunk/reactos/dll/win32/kernel32/except/except.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/except/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/except/except.c (original) +++ trunk/reactos/dll/win32/kernel32/except/except.c Sat Jan 26 00:38:43 2008 @@ -395,6 +395,7 @@ { DPRINT1("Delphi Exception at address: %p\n", ExceptionRecord.ExceptionInformation[0]); DPRINT1("Exception-Object: %p\n", ExceptionRecord.ExceptionInformation[1]); + DPRINT1("Exception text: %s\n", ExceptionRecord.ExceptionInformation[2]); } /* Raise the exception */

1 0

[cwittich] 32005: Fno-strict-aliasing -> fno-strict-aliasing
by cwittich＠svn.reactos.org 25 Jan '08

25 Jan '08

Author: cwittich Date: Fri Jan 25 23:30:52 2008 New Revision: 32005 URL: http://svn.reactos.org/svn/reactos?rev=32005&view=rev Log: Fno-strict-aliasing -> fno-strict-aliasing Modified: trunk/reactos/ReactOS-i386.rbuild Modified: trunk/reactos/ReactOS-i386.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ReactOS-i386.rbuild?rev=32… ============================================================================== --- trunk/reactos/ReactOS-i386.rbuild (original) +++ trunk/reactos/ReactOS-i386.rbuild Fri Jan 25 23:30:52 2008 @@ -34,7 +34,7 @@ </if> <compilerflag>-mpreferred-stack-boundary=2</compilerflag> - <compilerflag>-Fno-strict-aliasing</compilerflag> + <compilerflag>-fno-strict-aliasing</compilerflag> <compilerflag>-Wno-strict-aliasing</compilerflag> <compilerflag>-Wpointer-arith</compilerflag> <linkerflag>-enable-stdcall-fixup</linkerflag>

1 0

[cwittich] 32004: use Fno-strict-aliasing
by cwittich＠svn.reactos.org 25 Jan '08

25 Jan '08

Author: cwittich Date: Fri Jan 25 21:32:27 2008 New Revision: 32004 URL: http://svn.reactos.org/svn/reactos?rev=32004&view=rev Log: use Fno-strict-aliasing Modified: trunk/reactos/ReactOS-i386.rbuild Modified: trunk/reactos/ReactOS-i386.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ReactOS-i386.rbuild?rev=32… ============================================================================== --- trunk/reactos/ReactOS-i386.rbuild (original) +++ trunk/reactos/ReactOS-i386.rbuild Fri Jan 25 21:32:27 2008 @@ -34,6 +34,7 @@ </if> <compilerflag>-mpreferred-stack-boundary=2</compilerflag> + <compilerflag>-Fno-strict-aliasing</compilerflag> <compilerflag>-Wno-strict-aliasing</compilerflag> <compilerflag>-Wpointer-arith</compilerflag> <linkerflag>-enable-stdcall-fixup</linkerflag>

1 0

[cwittich] 32003: fix warnings
by cwittich＠svn.reactos.org 25 Jan '08

25 Jan '08

Author: cwittich Date: Fri Jan 25 21:19:41 2008 New Revision: 32003 URL: http://svn.reactos.org/svn/reactos?rev=32003&view=rev Log: fix warnings Modified: trunk/reactos/base/applications/mscutils/servman/misc.c Modified: trunk/reactos/base/applications/mscutils/servman/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/misc.c (original) +++ trunk/reactos/base/applications/mscutils/servman/misc.c Fri Jan 25 21:19:41 2008 @@ -126,7 +126,7 @@ lpFormat, 0, 0, - (LPTSTR)&lpStr, + (VOID*)&lpStr, 0, &lArgs); va_end(lArgs); @@ -189,10 +189,9 @@ return len; } - VOID GetError(VOID) { - LPVOID lpMsgBuf; + LPTSTR lpMsgBuf = NULL; FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | @@ -200,11 +199,11 @@ NULL, GetLastError(), MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), - (LPTSTR) &lpMsgBuf, + (VOID*)&lpMsgBuf, 0, NULL ); - MessageBox(NULL, (LPCTSTR) lpMsgBuf, _T("Error!"), MB_OK | MB_ICONERROR); + MessageBox(NULL, lpMsgBuf, _T("Error!"), MB_OK | MB_ICONERROR); LocalFree(lpMsgBuf); }

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
54
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2008