Ros-diffs October 2008

ros-diffs@reactos.org

25 participants
517 discussions

[sginsberg] 37111: - Don't dereference inside an SEH block after doing unsafe writes, as this could be missed in case a pointer is bad.
by sginsberg＠svn.reactos.org 31 Oct '08

31 Oct '08

Author: sginsberg Date: Fri Oct 31 08:16:01 2008 New Revision: 37111 URL: http://svn.reactos.org/svn/reactos?rev=37111&view=rev Log: - Don't dereference inside an SEH block after doing unsafe writes, as this could be missed in case a pointer is bad. Modified: trunk/reactos/ntoskrnl/io/iomgr/iocomp.c Modified: trunk/reactos/ntoskrnl/io/iomgr/iocomp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iocomp.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iocomp.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iocomp.c [iso-8859-1] Fri Oct 31 08:16:01 2008 @@ -424,9 +424,6 @@ ((PIO_COMPLETION_BASIC_INFORMATION)IoCompletionInformation)-> Depth = KeReadStateQueue(Queue); - /* Dereference the queue */ - ObDereferenceObject(Queue); - /* Return Result Length if needed */ if (ResultLength) { @@ -439,6 +436,9 @@ Status = _SEH_GetExceptionCode(); } _SEH_END; + + /* Dereference the queue */ + ObDereferenceObject(Queue); } /* Return Status */

1 0

[janderwald] 37110: - Add Documentation for netshell
by janderwald＠svn.reactos.org 31 Oct '08

31 Oct '08

Author: janderwald Date: Fri Oct 31 06:26:23 2008 New Revision: 37110 URL: http://svn.reactos.org/svn/reactos?rev=37110&view=rev Log: - Add Documentation for netshell Added: trunk/reactos/dll/win32/netshell/README (with props) Added: trunk/reactos/dll/win32/netshell/README URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netshell/README?… ============================================================================== --- trunk/reactos/dll/win32/netshell/README (added) +++ trunk/reactos/dll/win32/netshell/README [iso-8859-1] Fri Oct 31 06:26:23 2008 @@ -1,0 +1,58 @@ +=== Introduction === + +The netshell library is responsible for managing network connections. The user interface is accessed +by opening the control panel and selecting the "Network Connections" folder. +The netshell library provides COM interfaces to enumerate available network adapters, network protocols, network clients and network transports +and receive detailed information about them. However, it cannot configure these components. For configuration, look in the netcfgx documentation +(Hint: INetCfg) + +=== Interface === + +The user interface is exposed by implementing the IShellFolder interface as required by explorer +namespace extension. The code is currently placed in shfldr_netconnect.c + +The enumeration of the available network connections is performed by the IShellFolder::EnumObjects +(ISF_NetConnect_fnEnumObjects). It uses the INetConnectionManager interface implemented by netshell +in connectmanager.c to enumerate all available network connections. + +The context menu of network connection items is populated by the IContextMenu::QueryContextMenu +(ISF_NetConnect_IContextMenu3_QueryContextMenu) which is obtained by IShellFolder::GetUIObjectOf. The actions are performed by the +IContextMenu::InvokeCommand function (ISF_NetConnect_IContextMenu3_InvokeCommand). At the moment +the actions "Status" / "Properties" are implemented. + +=== Status Dialog & Notification Area === + +The status dialog is implemented by IOleCommandTarget interface(CLSID_LanConnectStatusUI). This interface manages all status dialogs +for all available dialogs. The interface is implemented as a singleton to advoid multiple notification icons +appear in the Notification area of the explorer. Everytime the IShellFolder object is created (ISF_NetConnect_Constructor), +it creates a reference to IOleCommandTarget interface and calls its IOleCommandTarget::Exec function with CGID_ShellServiceObject. +This causes IOleCommandTarget interface to enumerate all available network connections, check if they should be shown (NCCF_SHOW_ICON flag set +in the NETCON_PROPERTIES dwCharacter), and add them to notification area with Shell_NotifyIcon. For that purpose a hidden window is created (dialog +procedure is LANStatusDlg) which receives WM_SHOWSTATUSDLG msg when it shall show display the status dialog. + +When a user wants to display the status dialog by clicking on the context menu of network connection item, the IShellFolder sends the NetCfgInstanceId of +the selected network connection to IOleCommandTarget::Exec function. The function then looks up the specified notification item and then sends +the WM_SHOWSTATUSDLG msg to specific window. + +=== Network Connections Property Dialog === + +The network connections property dialog is implemented by the INetConnectionPropertyUi2 interface. The class id is obtained by calling +INetConnection::GetUiObjectClassId of the current selected network connection. After obtaining the interface by calling CoCreateInstance, the +selected network connection is stored as reference by calling INetConnectionPropertyUi::SetConnection. The next step is to call +INetConnectionPropertyUi::AddPages to add custom property pages to the property sheet set. If the function suceeds, the caller can then invoke +PropertySheetW function to display the properties. + Note: If the context doesnt match, i.e. the INetConnectionPropertyUi2 cannot work together + with current INetConnection, then it should fail INetConnectionPropertyUi::AddPages + Note: The function ShowNetConnectionProperties in shlfdr_netconnect.c shows how to invoke the Network Connections Property Dialog + +The enumeration of network components (protocols, client, transport) is done by using the INetCfg api). Initialization is performed in InitializeLANPropertiesUIDlg +function. When a user accepts changes, it calls INetCfg::Apply or when it aborts the changes INetCfg::Cancel. + +=== Known Issues === +* The notification icons are only added once IShellFolder of netshell is created for the first time +* Status changes of an adapter are not automatically updated because the information is cached +* There seems to be an icon problem which makes icon blink in the status dialog + +Last Update 31/10/2008 + + Propchange: trunk/reactos/dll/win32/netshell/README ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[cfinck] 37109: Merge in 37063, 37071, 37080, 37106-37108
by cfinck＠svn.reactos.org 30 Oct '08

30 Oct '08

Author: cfinck Date: Thu Oct 30 16:13:29 2008 New Revision: 37109 URL: http://svn.reactos.org/svn/reactos?rev=37109&view=rev Log: Merge in 37063, 37071, 37080, 37106-37108 Modified: branches/ros-branch-0_3_7/reactos/dll/win32/iphlpapi/iphlpapi_main.c branches/ros-branch-0_3_7/reactos/dll/win32/iphlpapi/resinfo_reactos.c branches/ros-branch-0_3_7/reactos/dll/win32/netshell/lanstatusui.c branches/ros-branch-0_3_7/reactos/dll/win32/shell32/shlview.c branches/ros-branch-0_3_7/reactos/dll/win32/shell32/shv_def_cmenu.c Modified: branches/ros-branch-0_3_7/reactos/dll/win32/iphlpapi/iphlpapi_main.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_7/reactos/dll/wi… ============================================================================== --- branches/ros-branch-0_3_7/reactos/dll/win32/iphlpapi/iphlpapi_main.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_7/reactos/dll/win32/iphlpapi/iphlpapi_main.c [iso-8859-1] Thu Oct 30 16:13:29 2008 @@ -1388,8 +1388,32 @@ CopyMemory(&pFixedInfo->DnsServerList, resInfo->DnsList, sizeof(IP_ADDR_STRING)); if (resInfo->riCount > 1) { - pFixedInfo->DnsServerList.Next = (struct _IP_ADDR_STRING*)((char*)pFixedInfo + sizeof(FIXED_INFO)); - CopyMemory(pFixedInfo->DnsServerList.Next, resInfo->DnsList->Next, sizeof(IP_ADDR_STRING) * (resInfo->riCount-1)); + IP_ADDR_STRING *pSrc = resInfo->DnsList->Next; + IP_ADDR_STRING *pTarget = (struct _IP_ADDR_STRING*)((char*)pFixedInfo + sizeof(FIXED_INFO)); + + pFixedInfo->DnsServerList.Next = pTarget; + + do + { + CopyMemory(pTarget, pSrc, sizeof(IP_ADDR_STRING)); + resInfo->riCount--; + if (resInfo->riCount > 1) + { + pTarget->Next = (IP_ADDR_STRING*)((char*)pTarget + sizeof(IP_ADDR_STRING)); + pTarget = pTarget->Next; + pSrc = pSrc->Next; + } + else + { + pTarget->Next = NULL; + break; + } + } + while(TRUE); + } + else + { + pFixedInfo->DnsServerList.Next = NULL; } } Modified: branches/ros-branch-0_3_7/reactos/dll/win32/iphlpapi/resinfo_reactos.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_7/reactos/dll/wi… ============================================================================== --- branches/ros-branch-0_3_7/reactos/dll/win32/iphlpapi/resinfo_reactos.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_7/reactos/dll/win32/iphlpapi/resinfo_reactos.c [iso-8859-1] Thu Oct 30 16:13:29 2008 @@ -244,6 +244,6 @@ VOID disposeResInfo( PIPHLP_RES_INFO InfoPtr ) { + HeapFree(GetProcessHeap(), 0, InfoPtr->DnsList); RtlFreeHeap( GetProcessHeap(), 0, InfoPtr ); - HeapFree(GetProcessHeap(), 0, InfoPtr->DnsList); -} +} Modified: branches/ros-branch-0_3_7/reactos/dll/win32/netshell/lanstatusui.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_7/reactos/dll/wi… ============================================================================== --- branches/ros-branch-0_3_7/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_7/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] Thu Oct 30 16:13:29 2008 @@ -429,9 +429,11 @@ { li.iItem = InsertItemToListView(hDlgCtrl, IDS_PHYSICAL_ADDRESS); if (li.iItem >= 0) - if (MultiByteToWideChar(CP_ACP, 0, (LPCSTR)pCurAdapter->Address, -1, szBuffer, sizeof(szBuffer)/sizeof(WCHAR))) - SendMessageW(hDlgCtrl, LVM_SETITEMW, 0, (LPARAM)&li); - + { + swprintf(szBuffer, L"%02x-%02x-%02x-%02x-%02x-%02x",pCurAdapter->Address[0], pCurAdapter->Address[1], + pCurAdapter->Address[2], pCurAdapter->Address[3], pCurAdapter->Address[4], pCurAdapter->Address[5]); + SendMessageW(hDlgCtrl, LVM_SETITEMW, 0, (LPARAM)&li); + } li.iItem = InsertItemToListView(hDlgCtrl, IDS_IP_ADDRESS); if (li.iItem >= 0) if (MultiByteToWideChar(CP_ACP, 0, pCurAdapter->IpAddressList.IpAddress.String, -1, szBuffer, sizeof(szBuffer)/sizeof(WCHAR))) Modified: branches/ros-branch-0_3_7/reactos/dll/win32/shell32/shlview.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_7/reactos/dll/wi… ============================================================================== --- branches/ros-branch-0_3_7/reactos/dll/win32/shell32/shlview.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_7/reactos/dll/win32/shell32/shlview.c [iso-8859-1] Thu Oct 30 16:13:29 2008 @@ -835,6 +835,8 @@ static UINT CF_IDLIST = 0; HRESULT hr; IDataObject* selection; + IContextMenu * cm; + HMENU hmenu; FORMATETC fetc; STGMEDIUM stgm; LPIDA pIDList; @@ -843,14 +845,68 @@ LPCWSTR parent_dir = NULL; SFGAOF attribs; int i; + CMINVOKECOMMANDINFOEX ici; + MENUITEMINFOW info; if (0 == ShellView_GetSelections(This)) { return S_OK; } + + hr = IShellFolder_GetUIObjectOf(This->pSFParent, This->hWnd, This->cidl, + (LPCITEMIDLIST*)This->apidl, &IID_IContextMenu, + 0, (LPVOID *)&cm); + + if (SUCCEEDED(hr)) + { + hmenu = CreatePopupMenu(); + if (hmenu) + { + if (SUCCEEDED(IContextMenu_QueryContextMenu( cm, hmenu, 0, 0x20, 0x7fff, CMF_DEFAULTONLY))) + { + INT def = -1, n = GetMenuItemCount(hmenu); + + for ( i = 0; i < n; i++ ) + { + memset( &info, 0, sizeof info ); + info.cbSize = sizeof info; + info.fMask = MIIM_FTYPE | MIIM_STATE | MIIM_ID; + if (GetMenuItemInfoW( hmenu, i, TRUE, &info)) + { + if (info.fState & MFS_DEFAULT) + { + def = info.wID; + break; + } + } + } + if (def != -1) + { + memset( &ici, 0, sizeof ici ); + ici.cbSize = sizeof ici; + ici.lpVerb = MAKEINTRESOURCEA( def ); + ici.hwnd = This->hWnd; + + IContextMenu_InvokeCommand(cm, (LPCMINVOKECOMMANDINFO) &ici ); + IContextMenu_Release(cm); + DestroyMenu( hmenu ); + return S_OK; + } + + } + DestroyMenu( hmenu ); + } + IContextMenu_Release(cm); + } + + + hr = IShellFolder_GetUIObjectOf(This->pSFParent, This->hWnd, This->cidl, (LPCITEMIDLIST*)This->apidl, &IID_IDataObject, 0, (LPVOID *)&selection); + + + if (FAILED(hr)) return hr; Modified: branches/ros-branch-0_3_7/reactos/dll/win32/shell32/shv_def_cmenu.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_7/reactos/dll/wi… ============================================================================== --- branches/ros-branch-0_3_7/reactos/dll/win32/shell32/shv_def_cmenu.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_7/reactos/dll/win32/shell32/shv_def_cmenu.c [iso-8859-1] Thu Oct 30 16:13:29 2008 @@ -1404,10 +1404,10 @@ } else if (_ILIsNetHood(This->dcm.apidl[0])) { - /* FIXME - * implement nethood properties - */ - FIXME("implement network connection shell folder\n"); + //FIXME path! + ShellExecuteW(NULL, L"open", L"explorer.exe", + L"/n,::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{7007ACC7-3202-11D1-AAD2-00805FC1270E}", + NULL, SW_SHOWDEFAULT); return S_OK; } else if (_ILIsBitBucket(This->dcm.apidl[0]))

1 0

[janderwald] 37108: - Make sure its DNS ServerList is NULL terminated
by janderwald＠svn.reactos.org 30 Oct '08

30 Oct '08

Author: janderwald Date: Thu Oct 30 15:25:27 2008 New Revision: 37108 URL: http://svn.reactos.org/svn/reactos?rev=37108&view=rev Log: - Make sure its DNS ServerList is NULL terminated Modified: trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c Modified: trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/iphlpap… ============================================================================== --- trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c [iso-8859-1] Thu Oct 30 15:25:27 2008 @@ -1388,7 +1388,6 @@ CopyMemory(&pFixedInfo->DnsServerList, resInfo->DnsList, sizeof(IP_ADDR_STRING)); if (resInfo->riCount > 1) { - IP_ADDR_STRING *pSrc = resInfo->DnsList->Next; IP_ADDR_STRING *pTarget = (struct _IP_ADDR_STRING*)((char*)pFixedInfo + sizeof(FIXED_INFO)); @@ -1411,6 +1410,10 @@ } } while(TRUE); + } + else + { + pFixedInfo->DnsServerList.Next = NULL; } }

1 0

[janderwald] 37107: - Fix ...
by janderwald＠svn.reactos.org 30 Oct '08

30 Oct '08

Author: janderwald Date: Thu Oct 30 15:12:09 2008 New Revision: 37107 URL: http://svn.reactos.org/svn/reactos?rev=37107&view=rev Log: - Fix ... Modified: trunk/reactos/dll/win32/iphlpapi/resinfo_reactos.c Modified: trunk/reactos/dll/win32/iphlpapi/resinfo_reactos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/resinfo… ============================================================================== --- trunk/reactos/dll/win32/iphlpapi/resinfo_reactos.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/iphlpapi/resinfo_reactos.c [iso-8859-1] Thu Oct 30 15:12:09 2008 @@ -244,6 +244,6 @@ VOID disposeResInfo( PIPHLP_RES_INFO InfoPtr ) { + HeapFree(GetProcessHeap(), 0, InfoPtr->DnsList); RtlFreeHeap( GetProcessHeap(), 0, InfoPtr ); - HeapFree(GetProcessHeap(), 0, InfoPtr->DnsList); -} +}

1 0

[janderwald] 37106: - Try fix GetNetworkParams api
by janderwald＠svn.reactos.org 30 Oct '08

30 Oct '08

Author: janderwald Date: Thu Oct 30 14:27:58 2008 New Revision: 37106 URL: http://svn.reactos.org/svn/reactos?rev=37106&view=rev Log: - Try fix GetNetworkParams api Modified: trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c Modified: trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/iphlpap… ============================================================================== --- trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c [iso-8859-1] Thu Oct 30 14:27:58 2008 @@ -1388,8 +1388,29 @@ CopyMemory(&pFixedInfo->DnsServerList, resInfo->DnsList, sizeof(IP_ADDR_STRING)); if (resInfo->riCount > 1) { - pFixedInfo->DnsServerList.Next = (struct _IP_ADDR_STRING*)((char*)pFixedInfo + sizeof(FIXED_INFO)); - CopyMemory(pFixedInfo->DnsServerList.Next, resInfo->DnsList->Next, sizeof(IP_ADDR_STRING) * (resInfo->riCount-1)); + + IP_ADDR_STRING *pSrc = resInfo->DnsList->Next; + IP_ADDR_STRING *pTarget = (struct _IP_ADDR_STRING*)((char*)pFixedInfo + sizeof(FIXED_INFO)); + + pFixedInfo->DnsServerList.Next = pTarget; + + do + { + CopyMemory(pTarget, pSrc, sizeof(IP_ADDR_STRING)); + resInfo->riCount--; + if (resInfo->riCount > 1) + { + pTarget->Next = (IP_ADDR_STRING*)((char*)pTarget + sizeof(IP_ADDR_STRING)); + pTarget = pTarget->Next; + pSrc = pSrc->Next; + } + else + { + pTarget->Next = NULL; + break; + } + } + while(TRUE); } }

1 0

[cfinck] 37105: Gregor Schneider (grschneider@gmail.com) - Hack: Hackfix displaying 32-bit tray icons in 32-bit color depth mode
by cfinck＠svn.reactos.org 30 Oct '08

30 Oct '08

Author: cfinck Date: Thu Oct 30 13:43:36 2008 New Revision: 37105 URL: http://svn.reactos.org/svn/reactos?rev=37105&view=rev Log: Gregor Schneider (grschneider(a)gmail.com) - Hack: Hackfix displaying 32-bit tray icons in 32-bit color depth mode Modified: branches/ros-branch-0_3_7/reactos/base/shell/explorer/taskbar/traynotify.cpp Modified: branches/ros-branch-0_3_7/reactos/base/shell/explorer/taskbar/traynotify.cpp URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_7/reactos/base/s… ============================================================================== --- branches/ros-branch-0_3_7/reactos/base/shell/explorer/taskbar/traynotify.cpp [iso-8859-1] (original) +++ branches/ros-branch-0_3_7/reactos/base/shell/explorer/taskbar/traynotify.cpp [iso-8859-1] Thu Oct 30 13:43:36 2008 @@ -741,7 +741,7 @@ AlphaBlend(canvas, x, y, NOTIFYICON_SIZE, NOTIFYICON_SIZE, mem_dc, 0, 0, NOTIFYICON_SIZE, NOTIFYICON_SIZE, blend); } else #endif - DrawIconEx(canvas, x, y, it->_hIcon, NOTIFYICON_SIZE, NOTIFYICON_SIZE, 0, 0, DI_NORMAL); + DrawIconEx(canvas, x, y, it->_hIcon, NOTIFYICON_SIZE, NOTIFYICON_SIZE, 0, GetSysColorBrush(COLOR_BTNFACE), DI_NORMAL); x += NOTIFYICON_DIST; }

1 0

[cfinck] 37104: Hack: Copy the toolbar image on our own instead of using CopyImage to hackfix the messed up toolbar graphics as it was done for previous releases.
by cfinck＠svn.reactos.org 30 Oct '08

30 Oct '08

Author: cfinck Date: Thu Oct 30 13:15:00 2008 New Revision: 37104 URL: http://svn.reactos.org/svn/reactos?rev=37104&view=rev Log: Hack: Copy the toolbar image on our own instead of using CopyImage to hackfix the messed up toolbar graphics as it was done for previous releases. Modified: branches/ros-branch-0_3_7/reactos/dll/win32/comctl32/toolbar.c Modified: branches/ros-branch-0_3_7/reactos/dll/win32/comctl32/toolbar.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_7/reactos/dll/wi… ============================================================================== --- branches/ros-branch-0_3_7/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_7/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] Thu Oct 30 13:15:00 2008 @@ -2665,7 +2665,33 @@ TRACE("adding hInst=%p nID=%d nButtons=%d\n", bitmap->hInst, bitmap->nID, bitmap->nButtons); /* Add bitmaps to the default image list */ if (bitmap->hInst == NULL) /* a handle was passed */ - hbmLoad = (HBITMAP)CopyImage(ULongToHandle(bitmap->nID), IMAGE_BITMAP, 0, 0, 0); + { + BITMAP bmp; + HBITMAP hOldBitmapBitmap, hOldBitmapLoad; + HDC hdcImage, hdcBitmap; + + /* copy the bitmap before adding it so that the user's bitmap + * doesn't get modified. + */ + GetObjectW ((HBITMAP)bitmap->nID, sizeof(BITMAP), (LPVOID)&bmp); + + hdcImage = CreateCompatibleDC(0); + hdcBitmap = CreateCompatibleDC(0); + + /* create new bitmap */ + hbmLoad = CreateBitmap (bmp.bmWidth, bmp.bmHeight, bmp.bmPlanes, bmp.bmBitsPixel, NULL); + hOldBitmapBitmap = SelectObject(hdcBitmap, (HBITMAP)bitmap->nID); + hOldBitmapLoad = SelectObject(hdcImage, hbmLoad); + + /* Copy the user's image */ + BitBlt (hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, + hdcBitmap, 0, 0, SRCCOPY); + + SelectObject (hdcImage, hOldBitmapLoad); + SelectObject (hdcBitmap, hOldBitmapBitmap); + DeleteDC (hdcImage); + DeleteDC (hdcBitmap); + } else hbmLoad = CreateMappedBitmap(bitmap->hInst, bitmap->nID, 0, NULL, 0);

1 0

[fireball] 37103: - Add some ReactOS-on-OLPC notes (just one entry for now).
by fireball＠svn.reactos.org 30 Oct '08

30 Oct '08

Author: fireball Date: Thu Oct 30 11:22:35 2008 New Revision: 37103 URL: http://svn.reactos.org/svn/reactos?rev=37103&view=rev Log: - Add some ReactOS-on-OLPC notes (just one entry for now). Added: branches/olpc/olpc_notes.txt (with props) Added: branches/olpc/olpc_notes.txt URL: http://svn.reactos.org/svn/reactos/branches/olpc/olpc_notes.txt?rev=37103&v… ============================================================================== --- branches/olpc/olpc_notes.txt (added) +++ branches/olpc/olpc_notes.txt [iso-8859-1] Thu Oct 30 11:22:35 2008 @@ -1,0 +1,3 @@ +1. To make sure usb controller is released: +' noop to go-hook +before booting freeldr Propchange: branches/olpc/olpc_notes.txt ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[sginsberg] 37102: - NtWrite/ReadFile: Don't hardcode Irp->RequestorMode to KernelMode! Instead, use the PreviousMode we saved earlier. This caused user mode APCs to be called from kernel mode, which is a...very...bad... idea. - Spotted by bug 3607 and exposed by ntdll Winetests "file" See issue #3607 for more details.
by sginsberg＠svn.reactos.org 30 Oct '08

30 Oct '08

Author: sginsberg Date: Thu Oct 30 10:59:00 2008 New Revision: 37102 URL: http://svn.reactos.org/svn/reactos?rev=37102&view=rev Log: - NtWrite/ReadFile: Don't hardcode Irp->RequestorMode to KernelMode! Instead, use the PreviousMode we saved earlier. This caused user mode APCs to be called from kernel mode, which is a...very...bad... idea. - Spotted by bug 3607 and exposed by ntdll Winetests "file" See issue #3607 for more details. Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Thu Oct 30 10:59:00 2008 @@ -2070,7 +2070,7 @@ /* Set the IRP */ Irp->Tail.Overlay.OriginalFileObject = FileObject; Irp->Tail.Overlay.Thread = PsGetCurrentThread(); - Irp->RequestorMode = KernelMode; + Irp->RequestorMode = PreviousMode; Irp->Overlay.AsynchronousParameters.UserApcRoutine = ApcRoutine; Irp->Overlay.AsynchronousParameters.UserApcContext = ApcContext; Irp->UserIosb = IoStatusBlock; @@ -2929,7 +2929,7 @@ /* Set the IRP */ Irp->Tail.Overlay.OriginalFileObject = FileObject; Irp->Tail.Overlay.Thread = PsGetCurrentThread(); - Irp->RequestorMode = KernelMode; + Irp->RequestorMode = PreviousMode; Irp->Overlay.AsynchronousParameters.UserApcRoutine = ApcRoutine; Irp->Overlay.AsynchronousParameters.UserApcContext = ApcContext; Irp->UserIosb = IoStatusBlock;

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2008