Ros-diffs October 2008

ros-diffs@reactos.org

25 participants
517 discussions

[cgutman] 36921: - Move the checks inside of the lock
by cgutman＠svn.reactos.org 24 Oct '08

24 Oct '08

Author: cgutman Date: Thu Oct 23 21:56:16 2008 New Revision: 36921 URL: http://svn.reactos.org/svn/reactos?rev=36921&view=rev Log: - Move the checks inside of the lock Modified: branches/aicom-network-fixes/drivers/network/afd/afd/connect.c branches/aicom-network-fixes/drivers/network/afd/afd/listen.c branches/aicom-network-fixes/drivers/network/afd/afd/read.c branches/aicom-network-fixes/drivers/network/afd/afd/write.c Modified: branches/aicom-network-fixes/drivers/network/afd/afd/connect.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/afd/afd/connect.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/afd/afd/connect.c [iso-8859-1] Thu Oct 23 21:56:16 2008 @@ -77,11 +77,6 @@ AFD_DbgPrint(MID_TRACE,("Called: FCB %x, FO %x\n", Context, FCB->FileObject)); - if( Irp->Cancel ) { - if( FCB ) FCB->ConnectIrp.InFlightRequest = NULL; - return STATUS_CANCELLED; - } - /* I was wrong about this before as we can have pending writes to a not * yet connected socket */ if( !SocketAcquireStateLock( FCB ) ) return STATUS_FILE_CLOSED; @@ -90,6 +85,11 @@ Irp->IoStatus.Status)); FCB->ConnectIrp.InFlightRequest = NULL; + + if( Irp->Cancel ) { + SocketStateUnlock( FCB ); + return STATUS_CANCELLED; + } if( NT_SUCCESS(Irp->IoStatus.Status) ) { FCB->PollState |= AFD_EVENT_CONNECT | AFD_EVENT_SEND; Modified: branches/aicom-network-fixes/drivers/network/afd/afd/listen.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/afd/afd/listen.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/afd/afd/listen.c [iso-8859-1] Thu Oct 23 21:56:16 2008 @@ -102,14 +102,14 @@ PAFD_FCB FCB = (PAFD_FCB)Context; PAFD_TDI_OBJECT_QELT Qelt; + if( !SocketAcquireStateLock( FCB ) ) return STATUS_FILE_CLOSED; + + FCB->ListenIrp.InFlightRequest = NULL; + if( Irp->Cancel ) { - if( FCB ) FCB->ListenIrp.InFlightRequest = NULL; + SocketStateUnlock( FCB ); return STATUS_CANCELLED; } - - if( !SocketAcquireStateLock( FCB ) ) return STATUS_FILE_CLOSED; - - FCB->ListenIrp.InFlightRequest = NULL; if( FCB->State == SOCKET_STATE_CLOSED ) { SocketStateUnlock( FCB ); Modified: branches/aicom-network-fixes/drivers/network/afd/afd/read.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/afd/afd/read.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/afd/afd/read.c [iso-8859-1] Thu Oct 23 21:56:16 2008 @@ -234,14 +234,15 @@ ASSERT_IRQL(APC_LEVEL); + if( !SocketAcquireStateLock( FCB ) ) return Status; + + FCB->ReceiveIrp.InFlightRequest = NULL; + if( Irp->Cancel ) { - if( FCB ) FCB->ReceiveIrp.InFlightRequest = NULL; + SocketStateUnlock( FCB ); return STATUS_CANCELLED; } - if( !SocketAcquireStateLock( FCB ) ) return Status; - - FCB->ReceiveIrp.InFlightRequest = NULL; FCB->Recv.Content = Irp->IoStatus.Information; FCB->Recv.BytesUsed = 0; @@ -455,14 +456,14 @@ AFD_DbgPrint(MID_TRACE,("Called on %x\n", FCB)); + if( !SocketAcquireStateLock( FCB ) ) return STATUS_FILE_CLOSED; + + FCB->ReceiveIrp.InFlightRequest = NULL; + if( Irp->Cancel ) { - if( FCB ) FCB->ReceiveIrp.InFlightRequest = NULL; + SocketStateUnlock( FCB ); return STATUS_CANCELLED; } - - if( !SocketAcquireStateLock( FCB ) ) return STATUS_FILE_CLOSED; - - FCB->ReceiveIrp.InFlightRequest = NULL; if( FCB->State == SOCKET_STATE_CLOSED ) { SocketStateUnlock( FCB ); Modified: branches/aicom-network-fixes/drivers/network/afd/afd/write.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/afd/afd/write.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/afd/afd/write.c [iso-8859-1] Thu Oct 23 21:56:16 2008 @@ -40,15 +40,15 @@ ASSERT_IRQL(APC_LEVEL); - if( Irp->Cancel ) { - if( FCB ) FCB->SendIrp.InFlightRequest = NULL; - return STATUS_CANCELLED; - } - if( !SocketAcquireStateLock( FCB ) ) return Status; FCB->SendIrp.InFlightRequest = NULL; /* Request is not in flight any longer */ + + if( Irp->Cancel ) { + SocketStateUnlock( FCB ); + return STATUS_CANCELLED; + } if( FCB->State == SOCKET_STATE_CLOSED ) { SocketStateUnlock( FCB ); @@ -176,19 +176,19 @@ Irp->IoStatus.Status, Irp->IoStatus.Information)); - if( Irp->Cancel ) { - if( FCB ) FCB->SendIrp.InFlightRequest = NULL; - return STATUS_CANCELLED; - } - /* It's ok if the FCB already died */ if( !SocketAcquireStateLock( FCB ) ) return STATUS_SUCCESS; + FCB->SendIrp.InFlightRequest = NULL; + /* Request is not in flight any longer */ + + if( Irp->Cancel ) { + SocketStateUnlock( FCB ); + return STATUS_CANCELLED; + } + FCB->PollState |= AFD_EVENT_SEND; PollReeval( FCB->DeviceExt, FCB->FileObject ); - - FCB->SendIrp.InFlightRequest = NULL; - /* Request is not in flight any longer */ if( FCB->State == SOCKET_STATE_CLOSED ) { SocketStateUnlock( FCB );

1 0

[cgutman] 36920: - Check for a NULL NCE - Mark the IRP pending before queuing it
by cgutman＠svn.reactos.org 23 Oct '08

23 Oct '08

Author: cgutman Date: Thu Oct 23 18:23:48 2008 New Revision: 36920 URL: http://svn.reactos.org/svn/reactos?rev=36920&view=rev Log: - Check for a NULL NCE - Mark the IRP pending before queuing it Modified: branches/aicom-network-fixes/lib/drivers/ip/network/arp.c branches/aicom-network-fixes/lib/drivers/ip/transport/datagram/datagram.c Modified: branches/aicom-network-fixes/lib/drivers/ip/network/arp.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/lib/drivers… ============================================================================== --- branches/aicom-network-fixes/lib/drivers/ip/network/arp.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/lib/drivers/ip/network/arp.c [iso-8859-1] Thu Oct 23 18:23:48 2008 @@ -230,7 +230,7 @@ Header->HWAddrLen, NUD_REACHABLE); } - if (Header->Opcode != ARP_OPCODE_REQUEST) + if (Header->Opcode != ARP_OPCODE_REQUEST || !NCE) return; /* This is a request for our address. Swap the addresses and Modified: branches/aicom-network-fixes/lib/drivers/ip/transport/datagram/datagram.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/lib/drivers… ============================================================================== --- branches/aicom-network-fixes/lib/drivers/ip/transport/datagram/datagram.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/lib/drivers/ip/transport/datagram/datagram.c [iso-8859-1] Thu Oct 23 18:23:48 2008 @@ -254,6 +254,9 @@ { ReceiveRequest->RemotePort = 0; } + + IoMarkIrpPending(Irp); + ReceiveRequest->ReturnInfo = ReturnInfo; ReceiveRequest->Buffer = BufferData; ReceiveRequest->BufferSize = ReceiveLength;

1 0

[dreimer] 36919: Last minute changes: Update NASM to 2.05 RC8, because 2.04 does not get our Bootsectors built. Changed defaults for the modules exclusion var from default off to default on.
by dreimer＠svn.reactos.org 23 Oct '08

23 Oct '08

Author: dreimer Date: Thu Oct 23 15:38:56 2008 New Revision: 36919 URL: http://svn.reactos.org/svn/reactos?rev=36919&view=rev Log: Last minute changes: Update NASM to 2.05 RC8, because 2.04 does not get our Bootsectors built. Changed defaults for the modules exclusion var from default off to default on. Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt trunk/tools/RosBE/RosBE-Windows/Root/README.odt trunk/tools/RosBE/RosBE-Windows/Root/RosBE.cmd Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Cha… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] Thu Oct 23 15:38:56 2008 @@ -1,7 +1,7 @@ *** October 26th, 2008 - RosBE 1.3 Released - Added: Tool to set the Architecture to build ROS for. (Daniel Reimer) -- Updated: NASM to 2.04 (Daniel Reimer) +- Updated: NASM to 2.05 RC8 (Daniel Reimer) - Updated: NSIS to 2.40 (Daniel Reimer) - Updated: Subversion to 1.5.3 (Daniel Reimer) - Updated: GDB to 6.8-3 (Daniel Reimer) Modified: trunk/tools/RosBE/RosBE-Windows/Root/README.odt URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/REA… ============================================================================== Binary files - no diff available. Modified: trunk/tools/RosBE/RosBE-Windows/Root/RosBE.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Ros… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/RosBE.cmd [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/RosBE.cmd [iso-8859-1] Thu Oct 23 15:38:56 2008 @@ -32,7 +32,7 @@ set _ROSBE_USECCACHE=0 set _ROSBE_STRIP=0 set _ROSBE_NOSTRIP=0 -set _ROSBE_MODULES=0 +set _ROSBE_MODULES=1 set _ROSBE_HOST_MINGWPATH=%_ROSBE_BASEDIR%\4.1.3 set _ROSBE_TARGET_MINGWPATH=%_ROSBE_BASEDIR%\4.1.3 set _ROSBE_LOGDIR=%CD%\RosBE-Logs

1 0

[cgutman] 36918: - Fix a typo - Add one more lock that I forgot - Fix a possible irp double completion
by cgutman＠svn.reactos.org 23 Oct '08

23 Oct '08

Author: cgutman Date: Thu Oct 23 14:44:30 2008 New Revision: 36918 URL: http://svn.reactos.org/svn/reactos?rev=36918&view=rev Log: - Fix a typo - Add one more lock that I forgot - Fix a possible irp double completion Modified: branches/aicom-network-fixes/drivers/network/tcpip/tcpip/dispatch.c branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c Modified: branches/aicom-network-fixes/drivers/network/tcpip/tcpip/dispatch.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/tcpip/tcpip/dispatch.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/tcpip/tcpip/dispatch.c [iso-8859-1] Thu Oct 23 14:44:30 2008 @@ -485,18 +485,22 @@ IrpSp = IoGetCurrentIrpStackLocation(Irp); DisReq = (PTDI_REQUEST_KERNEL_DISCONNECT)&IrpSp->Parameters; + TcpipRecursiveMutexEnter( &TCPLock, TRUE ); + /* Get associated connection endpoint file object. Quit if none exists */ TranContext = IrpSp->FileObject->FsContext; if (!TranContext) { TI_DbgPrint(MID_TRACE, ("Bad transport context.\n")); - return STATUS_INVALID_CONNECTION; + Status = STATUS_INVALID_CONNECTION; + goto done; } Connection = (PCONNECTION_ENDPOINT)TranContext->Handle.ConnectionContext; if (!Connection) { TI_DbgPrint(MID_TRACE, ("No connection endpoint file object.\n")); - return STATUS_INVALID_CONNECTION; + Status = STATUS_INVALID_CONNECTION; + goto done; } Status = TCPDisconnect( @@ -507,7 +511,15 @@ DispDataRequestComplete, Irp ); - TI_DbgPrint(MAX_TRACE, ("TCP Connect returned %08x\n", Status)); +done: + if (Status != STATUS_PENDING) { + DispDataRequestComplete(Irp, Status, 0); + } else + IoMarkIrpPending(Irp); + + TcpipRecursiveMutexLeave( &TCPLock ); + + TI_DbgPrint(MAX_TRACE, ("TCP Disconnect returned %08x\n", Status)); return Status; } @@ -1490,7 +1502,7 @@ TI_DbgPrint(DEBUG_IRP, ("Completing IRP at (0x%X).\n", Irp)); - return IRPFinish(Irp, STATUS_INVALID_PARAMETER); + return Irp->IoStatus.Status; } Status = DispPrepareIrpForCancel(TranContext, Irp, NULL); Modified: branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/tcpip/tcpip/main.c [iso-8859-1] Thu Oct 23 14:44:30 2008 @@ -437,6 +437,7 @@ case TDI_DISCONNECT: Status = DispTdiDisconnect(Irp); + Complete = FALSE; break; case TDI_ASSOCIATE_ADDRESS:

1 0

[sginsberg] 36917: - Fix EPROFILE/KPROFILE.Segment member -- it is a pointer
by sginsberg＠svn.reactos.org 23 Oct '08

23 Oct '08

Author: sginsberg Date: Thu Oct 23 14:15:44 2008 New Revision: 36917 URL: http://svn.reactos.org/svn/reactos?rev=36917&view=rev Log: - Fix EPROFILE/KPROFILE.Segment member -- it is a pointer Modified: trunk/reactos/include/ndk/extypes.h trunk/reactos/include/ndk/ketypes.h trunk/reactos/ntoskrnl/ex/profile.c Modified: trunk/reactos/include/ndk/extypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/extypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/extypes.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/extypes.h [iso-8859-1] Thu Oct 23 14:15:44 2008 @@ -532,7 +532,7 @@ PKPROFILE ProfileObject; PVOID LockedBufferAddress; PMDL Mdl; - ULONG Segment; + PVOID Segment; KPROFILE_SOURCE ProfileSource; KAFFINITY Affinity; } EPROFILE, *PEPROFILE; Modified: trunk/reactos/include/ndk/ketypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/ketypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/ketypes.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/ketypes.h [iso-8859-1] Thu Oct 23 14:15:44 2008 @@ -598,7 +598,7 @@ PVOID RangeLimit; ULONG BucketShift; PVOID Buffer; - ULONG Segment; + PVOID Segment; KAFFINITY Affinity; KPROFILE_SOURCE Source; BOOLEAN Started; Modified: trunk/reactos/ntoskrnl/ex/profile.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/profile.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ex/profile.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/profile.c [iso-8859-1] Thu Oct 23 14:15:44 2008 @@ -103,7 +103,8 @@ KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); OBJECT_ATTRIBUTES ObjectAttributes; NTSTATUS Status = STATUS_SUCCESS; - ULONG Segment = 0, Log2 = 0; + ULONG Log2 = 0; + PVOID Segment = NULL; PAGED_CODE(); /* Easy way out */ @@ -116,7 +117,7 @@ if (BufferSize < sizeof(ULONG)) return STATUS_INVALID_PARAMETER_7; /* This will become a segmented profile object */ - Segment = (ULONG)RangeBase; + Segment = RangeBase; RangeBase = 0; /* Recalculate the bucket size */

1 0

[dreimer] 36916: OMG, I missed -------=======|||/\THE FIX/\|||=======------- Sry encoded.
by dreimer＠svn.reactos.org 23 Oct '08

23 Oct '08

Author: dreimer Date: Thu Oct 23 13:23:29 2008 New Revision: 36916 URL: http://svn.reactos.org/svn/reactos?rev=36916&view=rev Log: OMG, I missed -------=======|||/\THE FIX/\|||=======------- Sry encoded. Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt trunk/tools/RosBE/RosBE-Windows/Root/README.odt Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Cha… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] Thu Oct 23 13:23:29 2008 @@ -19,6 +19,8 @@ _ROSBE_DEBUG=1 (Daniel Reimer) - Added: Mingw-64 GCC 4.4.0 for the 64 bit Branch. It will be installed with a Optional installer (Daniel Reimer) +- Fixed: Fixed the Header Mess in the different GCC Versions. Now the need for + LIBRARY_PATH is no more and all Arches use THEIR Headers. (Samuel Serapion) - Fixed: Dependant on the Arch variable a crosscompiler will be used now. (Daniel Reimer) - Fixed: Clean only cleans the arch which is active right now. (Daniel Reimer) - Fixed: "if defined xxx" with a nested "if %xxx% == foobar" does not work in batch. @@ -26,7 +28,7 @@ - Fixed: Bug 3043: Polish translation update (olaf_siejka(a)o2.pl) - Fixed: Bug 3044: Ukrainian translation update (temarez(a)yandex.ru) - Fixed: Bug 3035: Patch for RosBE that solves improper handling of a path with - spaces by roelmessiant(a)gmail.com + spaces (roelmessiant(a)gmail.com) - Fixed: Stripped apps and removed Debug Symbols at once may not be possible. (Daniel Reimer) - Fixed: Warnings, Resource Leaks, Problems with non-allocated Memory, RC MSVC Modified: trunk/tools/RosBE/RosBE-Windows/Root/README.odt URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/REA… ============================================================================== Binary files - no diff available.

1 0

[sginsberg] 36915: - Fix Nt/ZwMapViewOfSection parameters (ULONG -> ULONG_PTR and SIZE_T) and the few callers which sent incorrect types - Also fix MapViewOfFile/Ex parameters
by sginsberg＠svn.reactos.org 23 Oct '08

23 Oct '08

Author: sginsberg Date: Thu Oct 23 13:19:20 2008 New Revision: 36915 URL: http://svn.reactos.org/svn/reactos?rev=36915&view=rev Log: - Fix Nt/ZwMapViewOfSection parameters (ULONG -> ULONG_PTR and SIZE_T) and the few callers which sent incorrect types - Also fix MapViewOfFile/Ex parameters Modified: trunk/reactos/dll/win32/kernel32/mem/section.c trunk/reactos/include/ddk/winddk.h trunk/reactos/include/psdk/winbase.h trunk/reactos/lib/rtl/thread.c trunk/reactos/ntoskrnl/config/i386/cmhardwr.c Modified: trunk/reactos/dll/win32/kernel32/mem/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/mem/sec… ============================================================================== --- trunk/reactos/dll/win32/kernel32/mem/section.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/mem/section.c [iso-8859-1] Thu Oct 23 13:19:20 2008 @@ -158,12 +158,12 @@ DWORD dwDesiredAccess, DWORD dwFileOffsetHigh, DWORD dwFileOffsetLow, - DWORD dwNumberOfBytesToMap, + SIZE_T dwNumberOfBytesToMap, LPVOID lpBaseAddress) { NTSTATUS Status; LARGE_INTEGER SectionOffset; - ULONG ViewSize; + SIZE_T ViewSize; ULONG Protect; LPVOID ViewBase; @@ -224,7 +224,7 @@ DWORD dwDesiredAccess, DWORD dwFileOffsetHigh, DWORD dwFileOffsetLow, - DWORD dwNumberOfBytesToMap) + SIZE_T dwNumberOfBytesToMap) { /* Call the extended API */ return MapViewOfFileEx(hFileMappingObject, Modified: trunk/reactos/include/ddk/winddk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/winddk.h?rev=3… ============================================================================== --- trunk/reactos/include/ddk/winddk.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/winddk.h [iso-8859-1] Thu Oct 23 13:19:20 2008 @@ -11105,8 +11105,8 @@ IN HANDLE SectionHandle, IN HANDLE ProcessHandle, IN OUT PVOID *BaseAddress, - IN ULONG ZeroBits, - IN ULONG CommitSize, + IN ULONG_PTR ZeroBits, + IN SIZE_T CommitSize, IN OUT PLARGE_INTEGER SectionOffset OPTIONAL, IN OUT PSIZE_T ViewSize, IN SECTION_INHERIT InheritDisposition, @@ -11120,8 +11120,8 @@ IN HANDLE SectionHandle, IN HANDLE ProcessHandle, IN OUT PVOID *BaseAddress, - IN ULONG ZeroBits, - IN ULONG CommitSize, + IN ULONG_PTR ZeroBits, + IN SIZE_T CommitSize, IN OUT PLARGE_INTEGER SectionOffset OPTIONAL, IN OUT PSIZE_T ViewSize, IN SECTION_INHERIT InheritDisposition, Modified: trunk/reactos/include/psdk/winbase.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winbase.h?rev… ============================================================================== --- trunk/reactos/include/psdk/winbase.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/winbase.h [iso-8859-1] Thu Oct 23 13:19:20 2008 @@ -1890,8 +1890,8 @@ #define MakeProcInstance(p,i) (p) BOOL WINAPI MakeSelfRelativeSD(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,PDWORD); VOID WINAPI MapGenericMask(PDWORD,PGENERIC_MAPPING); -PVOID WINAPI MapViewOfFile(HANDLE,DWORD,DWORD,DWORD,DWORD); -PVOID WINAPI MapViewOfFileEx(HANDLE,DWORD,DWORD,DWORD,DWORD,PVOID); +PVOID WINAPI MapViewOfFile(HANDLE,DWORD,DWORD,DWORD,SIZE_T); +PVOID WINAPI MapViewOfFileEx(HANDLE,DWORD,DWORD,DWORD,SIZE_T,PVOID); BOOL WINAPI MoveFileA(LPCSTR,LPCSTR); BOOL WINAPI MoveFileExA(LPCSTR,LPCSTR,DWORD); BOOL WINAPI MoveFileExW(LPCWSTR,LPCWSTR,DWORD); Modified: trunk/reactos/lib/rtl/thread.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/thread.c?rev=36915… ============================================================================== --- trunk/reactos/lib/rtl/thread.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/thread.c [iso-8859-1] Thu Oct 23 13:19:20 2008 @@ -31,7 +31,8 @@ PIMAGE_NT_HEADERS Headers; ULONG_PTR Stack = 0; BOOLEAN UseGuard = FALSE; - ULONG Dummy, GuardPageSize; + ULONG Dummy; + SIZE_T GuardPageSize; /* Get some memory information */ Status = ZwQuerySystemInformation(SystemBasicInformation, Modified: trunk/reactos/ntoskrnl/config/i386/cmhardwr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/i386/cmhar… ============================================================================== --- trunk/reactos/ntoskrnl/config/i386/cmhardwr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/i386/cmhardwr.c [iso-8859-1] Thu Oct 23 13:19:20 2008 @@ -232,7 +232,8 @@ { UNICODE_STRING KeyName, ValueName, Data, SectionName; OBJECT_ATTRIBUTES ObjectAttributes; - ULONG HavePae, CacheSize, ViewSize, Length, TotalLength = 0, i, Disposition; + ULONG HavePae, CacheSize, Length, TotalLength = 0, i, Disposition; + SIZE_T ViewSize; NTSTATUS Status; HANDLE KeyHandle, BiosHandle, SystemHandle, FpuHandle, SectionHandle; CONFIGURATION_COMPONENT_DATA ConfigData;

1 0

[dreimer] 36914: Hello, almost final changelog. Small fix for uninstall routine.
by dreimer＠svn.reactos.org 23 Oct '08

23 Oct '08

Author: dreimer Date: Thu Oct 23 12:58:26 2008 New Revision: 36914 URL: http://svn.reactos.org/svn/reactos?rev=36914&view=rev Log: Hello, almost final changelog. Small fix for uninstall routine. Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt trunk/tools/RosBE/RosBE-Windows/RosBE.nsi Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Cha… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] Thu Oct 23 12:58:26 2008 @@ -1,4 +1,4 @@ -*** July 17th, 2008 - RosBE 1.3 Released +*** October 26th, 2008 - RosBE 1.3 Released - Added: Tool to set the Architecture to build ROS for. (Daniel Reimer) - Updated: NASM to 2.04 (Daniel Reimer) @@ -7,16 +7,35 @@ - Updated: GDB to 6.8-3 (Daniel Reimer) - Updated: Binutils 2.18.50 Build 20080109. (Daniel Reimer) - Updated: MingW32 Make 3.81-3 (Daniel Reimer) -- Updated: ccache 2.4 is now a native Version Without Cygwin (Colin Finck) X +- Updated: MingW32 Runtime DLL 3.15.1 (Daniel Reimer) - Other small Fixes here and there (Daniel Reimer) - Added: Basic PowerShell Version of RosBE (Daniel Reimer) - Added: YASM 0.72, which supports 64 bit asm too. (Daniel Reimer) - Added: Update command (Daniel Reimer) -- Added: Mingw-64 GCC 4.4.0 for the 64 bit Branch. (Daniel Reimer) +- Added: A way to include rosapps and rostests into the build and ssvn script by modifying + one var. Add this var to options.exe (Maciej Bialas and slight changes by me) +- Added: nostrip function (Christoph von Wittich) +- Added: RosBE Debugging Feature which disables the @echo off. just set + _ROSBE_DEBUG=1 (Daniel Reimer) +- Added: Mingw-64 GCC 4.4.0 for the 64 bit Branch. It will be installed with a + Optional installer (Daniel Reimer) - Fixed: Dependant on the Arch variable a crosscompiler will be used now. (Daniel Reimer) - Fixed: Clean only cleans the arch which is active right now. (Daniel Reimer) -- Fixed: "if defined xxx" with a nested "if %xxx% == foobar" does not work in batch. (Daniel Reimer) -- Fixed: Stripped apps and removed Debug Symbols at once may not be possible. (Daniel Reimer) +- Fixed: "if defined xxx" with a nested "if %xxx% == foobar" does not work in batch. + (Daniel Reimer) +- Fixed: Bug 3043: Polish translation update (olaf_siejka(a)o2.pl) +- Fixed: Bug 3044: Ukrainian translation update (temarez(a)yandex.ru) +- Fixed: Bug 3035: Patch for RosBE that solves improper handling of a path with + spaces by roelmessiant(a)gmail.com +- Fixed: Stripped apps and removed Debug Symbols at once may not be possible. + (Daniel Reimer) +- Fixed: Warnings, Resource Leaks, Problems with non-allocated Memory, RC MSVC + Comptibility (Christoph von Wittich) +- Fixed: First look into %_ROSBE_BASEDIR% for the specified directory and use it if it + exists. his makes it possible to just call "chdefgcc 3.4.5" instead of + "chdefgcc full\path\to\the\3.4.5\directory" if there is a "3.4.5" directory + in the RosBE installation directory. (Colin Finck) + *** January 23rd, 2008 - RosBE 1.2 Released Modified: trunk/tools/RosBE/RosBE-Windows/RosBE.nsi URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/RosBE.ns… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/RosBE.nsi [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/RosBE.nsi [iso-8859-1] Thu Oct 23 12:58:26 2008 @@ -339,7 +339,6 @@ RMDir /r /REBOOTOK "$APPDATA\RosBE" Delete /REBOOTOK "$INSTDIR\Build.cmd" Delete /REBOOTOK "$INSTDIR\Build.ps1" - Delete /REBOOTOK "$INSTDIR\charch.cmd" Delete /REBOOTOK "$INSTDIR\chdefdir.cmd" Delete /REBOOTOK "$INSTDIR\chdefgcc.cmd" Delete /REBOOTOK "$INSTDIR\Clean.cmd"

1 0

[tkreuzer] 36913: Quickfix for bug 3808 Don't set SystemMetrics to -1, when there's no CurInfo. Apparently we initialize the metrics before we have a WindowStation. This code needs to be improved... See issue #3808 for more details.
by tkreuzer＠svn.reactos.org 23 Oct '08

23 Oct '08

Author: tkreuzer Date: Thu Oct 23 12:26:50 2008 New Revision: 36913 URL: http://svn.reactos.org/svn/reactos?rev=36913&view=rev Log: Quickfix for bug 3808 Don't set SystemMetrics to -1, when there's no CurInfo. Apparently we initialize the metrics before we have a WindowStation. This code needs to be improved... See issue #3808 for more details. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/metric.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/metric.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/metric.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/metric.c [iso-8859-1] Thu Oct 23 12:26:50 2008 @@ -85,7 +85,7 @@ gpsi->SystemMetrics[SM_CYVSCROLL] = 16; gpsi->SystemMetrics[SM_CXHSCROLL] = 16; gpsi->SystemMetrics[SM_DEBUG] = 0; - gpsi->SystemMetrics[SM_SWAPBUTTON] = CurInfo ? CurInfo->SwapButtons : 0xFFFFFFFF; + gpsi->SystemMetrics[SM_SWAPBUTTON] = CurInfo ? CurInfo->SwapButtons : 0; gpsi->SystemMetrics[SM_RESERVED1] = 0; gpsi->SystemMetrics[SM_RESERVED2] = 0; gpsi->SystemMetrics[SM_RESERVED3] = 0; @@ -98,8 +98,8 @@ gpsi->SystemMetrics[SM_CYFRAME] = 4; gpsi->SystemMetrics[SM_CXMINTRACK] = 112; gpsi->SystemMetrics[SM_CYMINTRACK] = 27; - gpsi->SystemMetrics[SM_CXDOUBLECLK] = CurInfo ? CurInfo->DblClickWidth : 0xFFFFFFFF; - gpsi->SystemMetrics[SM_CYDOUBLECLK] = CurInfo ? CurInfo->DblClickWidth : 0xFFFFFFFF; + gpsi->SystemMetrics[SM_CXDOUBLECLK] = CurInfo ? CurInfo->DblClickWidth : 4; + gpsi->SystemMetrics[SM_CYDOUBLECLK] = CurInfo ? CurInfo->DblClickWidth : 4; gpsi->SystemMetrics[SM_CXICONSPACING] = 64; gpsi->SystemMetrics[SM_CYICONSPACING] = 64; gpsi->SystemMetrics[SM_MENUDROPALIGNMENT] = 0;

1 0

[sginsberg] 36912: - More 64-bit fixes
by sginsberg＠svn.reactos.org 23 Oct '08

23 Oct '08

Author: sginsberg Date: Thu Oct 23 12:05:40 2008 New Revision: 36912 URL: http://svn.reactos.org/svn/reactos?rev=36912&view=rev Log: - More 64-bit fixes Modified: trunk/reactos/subsystems/win32/win32k/include/hook.h trunk/reactos/subsystems/win32/win32k/ntuser/event.c trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c Modified: trunk/reactos/subsystems/win32/win32k/include/hook.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/hook.h [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/include/hook.h [iso-8859-1] Thu Oct 23 12:05:40 2008 @@ -48,7 +48,7 @@ } EVENTTABLE, *PEVENTTABLE; LRESULT FASTCALL co_HOOK_CallHooks(INT HookId, INT Code, WPARAM wParam, LPARAM lParam); -LRESULT FASTCALL co_EVENT_CallEvents(DWORD, HWND, LONG, LONG); +LRESULT FASTCALL co_EVENT_CallEvents(DWORD, HWND, UINT_PTR, LONG_PTR); VOID FASTCALL HOOK_DestroyThreadHooks(PETHREAD Thread); PHOOK FASTCALL IntGetHookObject(HHOOK); PHOOK FASTCALL IntGetNextHook(PHOOK Hook); Modified: trunk/reactos/subsystems/win32/win32k/ntuser/event.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/event.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/event.c [iso-8859-1] Thu Oct 23 12:05:40 2008 @@ -141,8 +141,8 @@ FASTCALL co_EVENT_CallEvents( DWORD event, HWND hwnd, - LONG idObject, - LONG idChild) + UINT_PTR idObject, + LONG_PTR idChild) { PEVENTHOOK pEH; LRESULT Result; @@ -185,14 +185,14 @@ if ((pEH->Thread != PsGetCurrentThread()) && (pEH->Thread != NULL)) { // if all process || all thread || other thread same process if (!(pEH->idProcess) || !(pEH->idThread) || - ((DWORD)(NtCurrentTeb()->ClientId).UniqueProcess == pEH->idProcess)) + (NtCurrentTeb()->ClientId.UniqueProcess == (PVOID)pEH->idProcess)) { Result = IntCallLowLevelEvent(pEH, Event, Window->hSelf, idObject, idChild); } }// if ^skip own thread && ((Pid && CPid == Pid && ^skip own process) || all process) else if ( !(pEH->Flags & WINEVENT_SKIPOWNTHREAD) && ( ((pEH->idProcess && - (DWORD)(NtCurrentTeb()->ClientId).UniqueProcess == pEH->idProcess) && + NtCurrentTeb()->ClientId.UniqueProcess == (PVOID)pEH->idProcess) && !(pEH->Flags & WINEVENT_SKIPOWNPROCESS)) || !pEH->idProcess ) ) { @@ -201,7 +201,7 @@ Window->hSelf, idObject, idChild, - (DWORD)(NtCurrentTeb()->ClientId).UniqueThread, + PtrToUint(NtCurrentTeb()->ClientId.UniqueThread), (DWORD)EngGetTickCount(), pEH->Proc); } Modified: trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c [iso-8859-1] Thu Oct 23 12:05:40 2008 @@ -942,8 +942,8 @@ { Result = co_EVENT_CallEvents( Message->Msg.message, Message->Msg.hwnd, - (LONG) Message->Msg.wParam, - (LONG) Message->Msg.lParam); + Message->Msg.wParam, + Message->Msg.lParam); } else {

1 0

← Newer
1
...
18
19
20
21
22
23
24
...
52
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2008