Ros-diffs December 2008

ros-diffs@reactos.org

31 participants
710 discussions

[sginsberg] 38064: - Hack away mru tests as Cm is broken
by sginsberg＠svn.reactos.org 14 Dec '08

14 Dec '08

Author: sginsberg Date: Sat Dec 13 18:46:06 2008 New Revision: 38064 URL: http://svn.reactos.org/svn/reactos?rev=38064&view=rev Log: - Hack away mru tests as Cm is broken Added: trunk/rostests/winetests/comctl32/roshack.diff Modified: trunk/rostests/winetests/comctl32/mru.c Modified: trunk/rostests/winetests/comctl32/mru.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/comctl32/mru.c?… ============================================================================== --- trunk/rostests/winetests/comctl32/mru.c [iso-8859-1] (original) +++ trunk/rostests/winetests/comctl32/mru.c [iso-8859-1] Sat Dec 13 18:46:06 2008 @@ -418,6 +418,10 @@ { hComctl32 = GetModuleHandleA("comctl32.dll"); + /* The registry usage here crashes the system because of broken Cm -- remove this when Cm gets fixed */ + skip("ROS-HACK: Skipping mru tests -- Cm is broken\n"); + return; + delete_reg_entries(); if (!create_reg_entries()) return; Added: trunk/rostests/winetests/comctl32/roshack.diff URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/comctl32/roshac… ============================================================================== --- trunk/rostests/winetests/comctl32/roshack.diff (added) +++ trunk/rostests/winetests/comctl32/roshack.diff [iso-8859-1] Sat Dec 13 18:46:06 2008 @@ -1,0 +1,15 @@ +Index: mru.c +=================================================================== +--- mru.c (revision 38062) ++++ mru.c (working copy) +@@ -418,6 +418,10 @@ + { + hComctl32 = GetModuleHandleA("comctl32.dll"); + ++ /* The registry usage here crashes the system because of broken Cm -- remove this when Cm gets fixed */ ++ skip("ROS-HACK: Skipping mru tests -- Cm is broken\n"); ++ return; ++ + delete_reg_entries(); + if (!create_reg_entries()) + return;

1 0

[sginsberg] 38063: - Disable lsasrv and advapi debug tracing, accidentally committed in 38041
by sginsberg＠svn.reactos.org 14 Dec '08

14 Dec '08

Author: sginsberg Date: Sat Dec 13 18:05:19 2008 New Revision: 38063 URL: http://svn.reactos.org/svn/reactos?rev=38063&view=rev Log: - Disable lsasrv and advapi debug tracing, accidentally committed in 38041 Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_i386… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] Sat Dec 13 18:05:19 2008 @@ -1127,6 +1127,6 @@ HKLM,"SYSTEM\Setup","SystemSetupInProgress",0x00010001,0x00000001 ; Debug channels -HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","DEBUGCHANNEL",0x00020000,"+lsasrv,+advapi" +;HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\Environment","DEBUGCHANNEL",0x00020000,"+ole,+rpc" ; EOF

1 0

[tkreuzer] 38062: Didn't want to commit this. Use the opportunity to convert spaces -> tabs.
by tkreuzer＠svn.reactos.org 13 Dec '08

13 Dec '08

Author: tkreuzer Date: Sat Dec 13 17:50:28 2008 New Revision: 38062 URL: http://svn.reactos.org/svn/reactos?rev=38062&view=rev Log: Didn't want to commit this. Use the opportunity to convert spaces -> tabs. Modified: trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.rbuild Modified: trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/util… ============================================================================== --- trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.rbuild [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.rbuild [iso-8859-1] Sat Dec 13 17:50:28 2008 @@ -1,21 +1,20 @@ <module name="rosperf" type="win32cui" installbase="system32" installname="rosperf.exe"> - <include base="rosperf">.</include> - <define name="UNICODE" /> - <library>version</library> - <library>msvcrt</library> - <library>msimg32</library> - <library>gdi32</library> - <library>shell32</library> - <library>advapi32</library> - <library>user32</library> - <library>kernel32</library> - <library>ntdll</library> - <file>rosperf.c</file> - <file>lines.c</file> - <file>fill.c</file> - <file>text.c</file> - <file>alphablend.c</file> - <file>testlist.c</file> - <file>gradient.c</file> - <file>rosperf.rc</file> + <include base="rosperf">.</include> + <define name="UNICODE" /> + <library>version</library> + <library>msimg32</library> + <library>gdi32</library> + <library>shell32</library> + <library>advapi32</library> + <library>user32</library> + <library>kernel32</library> + <library>ntdll</library> + <file>rosperf.c</file> + <file>lines.c</file> + <file>fill.c</file> + <file>text.c</file> + <file>alphablend.c</file> + <file>testlist.c</file> + <file>gradient.c</file> + <file>rosperf.rc</file> </module>

1 0

[tkreuzer] 38061: fix rosperf build
by tkreuzer＠svn.reactos.org 13 Dec '08

13 Dec '08

Author: tkreuzer Date: Sat Dec 13 17:48:38 2008 New Revision: 38061 URL: http://svn.reactos.org/svn/reactos?rev=38061&view=rev Log: fix rosperf build Modified: trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.c trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.rbuild Modified: trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/util… ============================================================================== --- trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.c [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.c [iso-8859-1] Sat Dec 13 17:48:38 2008 @@ -170,7 +170,7 @@ { WCHAR Status[128]; - snwprintf(Status, sizeof(Status) / sizeof(Status[0]), L"%d %s %s", Try, Message, Test); + _snwprintf(Status, sizeof(Status) / sizeof(Status[0]), L"%d %s %s", Try, Message, Test); SetWindowTextW(Label, Status); InvalidateRect(Label, NULL, TRUE); UpdateWindow(Label); Modified: trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/util… ============================================================================== --- trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.rbuild [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/utils/rosperf/rosperf.rbuild [iso-8859-1] Sat Dec 13 17:48:38 2008 @@ -2,6 +2,7 @@ <include base="rosperf">.</include> <define name="UNICODE" /> <library>version</library> + <library>msvcrt</library> <library>msimg32</library> <library>gdi32</library> <library>shell32</library>

1 0

[tkreuzer] 38060: include stdlib.h for exit()
by tkreuzer＠svn.reactos.org 13 Dec '08

13 Dec '08

Author: tkreuzer Date: Sat Dec 13 17:37:26 2008 New Revision: 38060 URL: http://svn.reactos.org/svn/reactos?rev=38060&view=rev Log: include stdlib.h for exit() Modified: trunk/rosapps/applications/sysutils/pedump/pedump.c Modified: trunk/rosapps/applications/sysutils/pedump/pedump.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/pedu… ============================================================================== --- trunk/rosapps/applications/sysutils/pedump/pedump.c [iso-8859-1] (original) +++ trunk/rosapps/applications/sysutils/pedump/pedump.c [iso-8859-1] Sat Dec 13 17:37:26 2008 @@ -44,6 +44,7 @@ // #include <stdio.h> +#include <stdlib.h> #include <stdarg.h> #include <string.h> #include <setjmp.h>

1 0

[tkreuzer] 38059: fix build of rostests
by tkreuzer＠svn.reactos.org 13 Dec '08

13 Dec '08

Author: tkreuzer Date: Sat Dec 13 17:12:44 2008 New Revision: 38059 URL: http://svn.reactos.org/svn/reactos?rev=38059&view=rev Log: fix build of rostests Modified: trunk/reactos/include/crt/dos.h Modified: trunk/reactos/include/crt/dos.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/dos.h?rev=3805… ============================================================================== --- trunk/reactos/include/crt/dos.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/dos.h [iso-8859-1] Sat Dec 13 17:12:44 2008 @@ -39,8 +39,8 @@ #endif #if (defined(_X86_) && !defined(__x86_64)) - void __cdecl _disable(void); - void __cdecl _enable(void); +// void __cdecl _disable(void); +// void __cdecl _enable(void); #endif #ifndef NO_OLDNAMES

1 0

[tkreuzer] 38058: fix fontview build
by tkreuzer＠svn.reactos.org 13 Dec '08

13 Dec '08

Author: tkreuzer Date: Sat Dec 13 16:25:59 2008 New Revision: 38058 URL: http://svn.reactos.org/svn/reactos?rev=38058&view=rev Log: fix fontview build Modified: trunk/rosapps/applications/fontview/display.c Modified: trunk/rosapps/applications/fontview/display.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/fontview/disp… ============================================================================== --- trunk/rosapps/applications/fontview/display.c [iso-8859-1] (original) +++ trunk/rosapps/applications/fontview/display.c [iso-8859-1] Sat Dec 13 16:25:59 2008 @@ -152,7 +152,7 @@ /* Set the new type face name */ pData = (DISPLAYDATA*)GetWindowLongPtr(hwnd, GWLP_USERDATA); - snwprintf(pData->szTypeFaceName, LF_FULLFACESIZE, pExtLogFont->elfFullName); + _snwprintf(pData->szTypeFaceName, LF_FULLFACESIZE, pExtLogFont->elfFullName); /* Create the new fonts */ hDC = GetDC(hwnd); @@ -202,7 +202,7 @@ DISPLAYDATA* pData; pData = (DISPLAYDATA*)GetWindowLongPtr(hwnd, GWLP_USERDATA); - snwprintf(pData->szString, MAX_STRING, (WCHAR*)lParam); + _snwprintf(pData->szString, MAX_STRING, (WCHAR*)lParam); // FIXME: redraw the window

1 0

[tkreuzer] 38057: Add a hack to wait for WinDbg after KdInitSystem.
by tkreuzer＠svn.reactos.org 13 Dec '08

13 Dec '08

Author: tkreuzer Date: Sat Dec 13 15:46:38 2008 New Revision: 38057 URL: http://svn.reactos.org/svn/reactos?rev=38057&view=rev Log: Add a hack to wait for WinDbg after KdInitSystem. Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/kiinit.c Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/kiinit.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… ============================================================================== --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/kiinit.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/kiinit.c [iso-8859-1] Sat Dec 13 15:46:38 2008 @@ -770,7 +770,20 @@ /* Check for break-in */ // if (KdPollBreakIn()) DbgBreakPointWithStatus(1); } -DPRINT1("after KdInitSystem\n"); +FrLdrDbgPrint("after KdInitSystem\n"); + + /* Hack! Wait for the debugger! */ + while (!KdPollBreakIn()); + DbgBreakPointWithStatus(0); + + /* Display separator + ReactOS version at start of the debug log */ + DPRINT1("-----------------------------------------------------\n"); + DPRINT1("ReactOS "KERNEL_VERSION_STR" (Build "KERNEL_VERSION_BUILD_STR")\n"); + DPRINT1("Command Line: %s\n", LoaderBlock->LoadOptions); + DPRINT1("ARC Paths: %s %s %s %s\n", LoaderBlock->ArcBootDeviceName, + LoaderBlock->NtHalPathName, + LoaderBlock->ArcHalDeviceName, + LoaderBlock->NtBootPathName); /* Raise to HIGH_LEVEL */ KfRaiseIrql(HIGH_LEVEL);

1 0

[tkreuzer] 38056: ProgramCounter is 64 bit, so don't cast to ULONG
by tkreuzer＠svn.reactos.org 13 Dec '08

13 Dec '08

Author: tkreuzer Date: Sat Dec 13 15:42:34 2008 New Revision: 38056 URL: http://svn.reactos.org/svn/reactos?rev=38056&view=rev Log: ProgramCounter is 64 bit, so don't cast to ULONG Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/kd64/kdapi.c Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/kd64/kdapi.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… ============================================================================== --- branches/ros-amd64-bringup/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] Sat Dec 13 15:42:34 2008 @@ -176,7 +176,7 @@ #if defined(_M_X86_) WaitStateChange->ProgramCounter = (ULONG)(LONG_PTR)Context->Eip; #elif defined(_M_AMD64) - WaitStateChange->ProgramCounter = (ULONG)(LONG_PTR)Context->Rip; + WaitStateChange->ProgramCounter = (LONG_PTR)Context->Rip; #else #error Unknown platform #endif @@ -544,7 +544,7 @@ DBGKD_MANIPULATE_STATE64 ManipulateState; ULONG Length; KDSTATUS RecvCode; - +FrLdrDbgPrint("Enter KdpSendWaitContinue\n"); /* Setup the Manipulate State structure */ Header.MaximumLength = sizeof(DBGKD_MANIPULATE_STATE64); Header.Buffer = (PCHAR)&ManipulateState; @@ -554,7 +554,8 @@ SendPacket: /* Send the Packet */ - KdSendPacket(PacketType, SendHeader, SendData, &KdpContext); +// KdSendPacket(PacketType, SendHeader, SendData, &KdpContext); + KdSendPacket(PacketType, SendHeader, SendData, (PVOID)FrLdrDbgPrint); /* If the debugger isn't present anymore, just return success */ if (KdDebuggerNotPresent) return ContinueSuccess; @@ -565,6 +566,7 @@ /* Receive Loop */ do { + FrLdrDbgPrint("KdpSendWaitContinue 1\n"); /* Wait to get a reply to our packet */ RecvCode = KdReceivePacket(PACKET_TYPE_KD_STATE_MANIPULATE, &Header, @@ -947,7 +949,7 @@ STRING Header, Data; DBGKD_WAIT_STATE_CHANGE64 WaitStateChange; BOOLEAN Status; - +FrLdrDbgPrint("Enter KdpReportExceptionStateChange, Rip = 0x%p\n", (PVOID)Context->Rip); /* Start report loop */ do { @@ -968,14 +970,14 @@ /* Setup the trace data */ DumpTraceData(&Data); - +FrLdrDbgPrint("KdpReportExceptionStateChange 5\n"); /* Send State Change packet and wait for a reply */ Status = KdpSendWaitContinue(PACKET_TYPE_KD_STATE_CHANGE64, &Header, &Data, Context); } while (Status == KdPacketNeedsResend); - +FrLdrDbgPrint("Leave KdpReportExceptionStateChange, Status = 0x%x\n", Status); /* Return */ return Status; } @@ -1072,7 +1074,7 @@ IN PKEXCEPTION_FRAME ExceptionFrame) { BOOLEAN Entered; - +FrLdrDbgPrint("KdEnterDebugger!\n"); /* Check if we have a trap frame */ if (TrapFrame) { @@ -1114,7 +1116,7 @@ /* Make sure we acquired the port */ if (!KdpPortLocked) DbgPrint("Port lock was not acquired!\n"); - +FrLdrDbgPrint("KdEnterDebugger returns %d\n", Entered); /* Return enter state */ return Entered; }

1 0

[tkreuzer] 38055: Fix a typo, comment out a DPRINT
by tkreuzer＠svn.reactos.org 13 Dec '08

13 Dec '08

Author: tkreuzer Date: Sat Dec 13 15:37:59 2008 New Revision: 38055 URL: http://svn.reactos.org/svn/reactos?rev=38055&view=rev Log: Fix a typo, comment out a DPRINT Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/except.c Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/except.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… ============================================================================== --- branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/except.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/ntoskrnl/ke/amd64/except.c [iso-8859-1] Sat Dec 13 15:37:59 2008 @@ -100,8 +100,8 @@ { CONTEXT Context; - DPRINT1("KiDispatchException(%p, %p, %p, %d, %d)\n", - ExceptionRecord, ExceptionFrame, TrapFrame, PreviousMode, FirstChance); +// FrLdrDbgPrint("KiDispatchException(%p, %p, %p, %d, %d)\n", +// ExceptionRecord, ExceptionFrame, TrapFrame, PreviousMode, FirstChance); /* Increase number of Exception Dispatches */ KeGetCurrentPrcb()->KeExceptionDispatchCount++; @@ -125,7 +125,7 @@ /* Breakpoint */ case STATUS_BREAKPOINT: - /* Decrement EIP by one */ + /* Decrement RIP by one */ Context.Rip--; break;

1 0

← Newer
1
...
41
42
43
44
45
46
47
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs December 2008